profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/eugene-manuilov/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Eugene Manuilov eugene-manuilov @10up Kyiv, Ukraine http://10up.com/

google/site-kit-wp 1063

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.

10up/wp-local-docker-v2 321

A simple Docker based development environment for WordPress.

10up/wpsnapshots 195

A project sharing tool for WordPress.

eugene-manuilov/typeorm-uml 108

Generate Entity Relationship diagrams for Typeorm powered projects.

eugene-manuilov/jest-runner-groups 83

A custom runner that allows to tag test files and run groups of tests with Jest.

eugene-manuilov/phalcon-vm 43

Vagrant configuration for PHP7, Phalcon 3.x and Zephir development.

eugene-manuilov/react-gettext 22

Tiny React library for implementing gettext localization in your application.

eugene-manuilov/redux-wordpress 21

Redux helpers to generate actions and reducers for WordPress REST API endpoints.

10up/wp-local-docker-docs 19

Documentation for WP Local Docker

10up/post-finder 17

Creates a rich input field that allows a user to curate and rank content items (posts or other custom post types).

issue commentgoogle/site-kit-wp

Release 1.44.0

@felixarntz yes, I can check it. I'll create a follow-up PR for 4226.

aaemnnosttv

comment created time in 25 minutes

push eventgoogle/site-kit-wp

Evan Mattson

commit sha 8f4def5737f8b69703fab2f8c091a4ae33182311

Bump version to 1.44.0.

view details

Eugene Manuilov

commit sha 9fafe975e52e41abb8519e0a8ef764232f3b2d0d

Merge remote-tracking branch 'origin/main' into enhancement/3807-enable-ga4-support.

view details

Eugene Manuilov

commit sha ef51049d65508b7c82f4d5006bf8069841b3c826

Update settings datastore to keep checking the ga4setup feature flag.

view details

push time in 21 hours

push eventgoogle/site-kit-wp

Eugene Manuilov

commit sha 6f37894b54d27361a07f261435dfde59f62a261d

Add initial EmptyPieChart component.

view details

Eugene Manuilov

commit sha 65abf233bfb7c37d17f4775169a29e539e13cd06

Update styles of the empty state component.

view details

Eugene Manuilov

commit sha 3cdfd8cb371c3a0699114d7ad7b107bd6e96e591

Update linear charts to have viewWindow.max option equals to 100 if the report is empty.

view details

Eugene Manuilov

commit sha 39025b113625d3bc99194918ea1067b8792e9232

Update the TotalUserCount component not to display change arrow if the change is null.

view details

Eugene Manuilov

commit sha 1c73153ba5280d3e3581170f299ed4e433f9e4a0

Update analytics related widgets to display the zero data message in page-related widgets.

view details

Eugene Manuilov

commit sha c0ca8b5861484524f47fdc52cc78fcba77c890ac

Update search console related widgets to display the zero data message in table widgets.

view details

Eugene Manuilov

commit sha d6254611064530211c8ad0b111c682de28ad5ca3

Update widgets.

view details

Eugene Manuilov

commit sha cad1a34e9bd47e62cfc713d8587e52598c22879f

Merge remote-tracking branch 'origin/main' into enhancement/4226-zero-data-states.

view details

Eugene Manuilov

commit sha cb17d81febcac783a26ea58938c3f0c35a2aa8d2

Merge remote-tracking branch 'origin/enhancement/4226-zero-data-states' into enhancement/4226-zero-data-states.

view details

Eugene Manuilov

commit sha e948d92a79fdeb1bc2603520e4da033b21fa8e0b

Update the sparkline component to use green color by default.

view details

Eugene Manuilov

commit sha 7e7a016a2e3053188dbebcfd16fa3de389b927eb

Remove .stories.js file for the DashboardSearchVisitorsWidget component since it is added to the main widgets file with stories.

view details

Eugene Manuilov

commit sha 038a32e3caa8f88ea7ca3c3b5f9635c04abf1054

Merge branch 'enhancement/4226-zero-data-states' of github.com:google/site-kit-wp into enhancement/4226-zero-data-states.

view details

Eugene Manuilov

commit sha b6ff9dc436249cedf9291ffb82fe156f21efba47

Add the DashboardSearchVisitorsWidget.stories.js file back.

view details

Eugene Manuilov

commit sha 21ae56ae5f44ff3b8fd17fa71dedde4a67bb9697

Merge remote-tracking branch 'origin/main' into enhancement/4226-zero-data-states.

view details

Eugene Manuilov

commit sha 7afa1add0a6dae7671703c25c6aea068a5d441a9

Update DashboardSearchVisitorsWidget stories.

view details

Eugene Manuilov

commit sha a2f1903614b32adc8d62801ac1f2649935a7969f

Fix vrt issues.

view details

Felix Arntz

commit sha 9e8137a654e7e40cf9eca50715844242097f9242

Merge pull request #4236 from google/enhancement/4226-zero-data-states Enhancement/4226 zero data states

view details

Eugene Manuilov

commit sha 31601663efa08ba2e7fdcfd7449c61475a0d73fe

Merge remote-tracking branch 'origin/main' into enhancement/3807-enable-ga4-support.

view details

push time in 2 days

push eventgoogle/site-kit-wp

Eugene Manuilov

commit sha a2f1903614b32adc8d62801ac1f2649935a7969f

Fix vrt issues.

view details

push time in 2 days

pull request commentgoogle/site-kit-wp

Enhancement/4226 zero data states

@eugene-manuilov Hmm, somehow this isn't working now, the stories for DashboardSearchVisitorsWidget now all show "Gathering data" state, see https://google.github.io/site-kit-wp/storybook/pull/4236/?path=/story/modules-analytics-widgets-dashboardsearchvisitorswidget--ready

@felixarntz, ok, it should work now. Please, check again.

eugene-manuilov

comment created time in 2 days

push eventgoogle/site-kit-wp

Asvin Balloo

commit sha bedb26dc759245f33f4a90bfb236217a1f023e92

Add AdBlockerWarning Widget.

view details

Arafat Zahan

commit sha c335dec4f6dc9fd430134bff0b3f1193c887b610

Improve reauthenticate message for 'access_denied' error.

view details

Asvin Balloo

commit sha d421c2bd7052c1045677b3b6d9d9261daa81cb18

Merge branch 'develop' into fix/4178-adblocker-widget.

view details

Arafat Zahan

commit sha eda6388c3f1b29b51a8cd2594e0e4bc9db1c4d95

Fix `esc_url` position.

view details

Arafat Zahan

commit sha d87082fd70ee449718dacc4a8759528ed75bf16a

Fix url for already authenticated users.

view details

Asvin Balloo

commit sha c1d90eaa69bfe1dacc99c1e0166f65c558d44360

Remove padding from ad blocker widget.

view details

Evan Mattson

commit sha 7cba23dd1e9e50667047e15d8d795c1778f9da39

Remove surrounding blank lines.

view details

Evan Mattson

commit sha 89fa456b086a1807467da2e4c9589b9cbf349e15

Merge pull request #4234 from google/enhance/3970-access-denied

view details

Evan Mattson

commit sha 1c55ec31e7dc78d351db3101a8f71d487be46357

Merge pull request #4206 from google/fix/4178-adblocker-widget

view details

Asvin Balloo

commit sha 40d6d9108c0362c94943cb02eb6ead013937cf2d

Update AdSense blocker warning messages.

view details

Matthew Riley MacPherson (tofumatt)

commit sha 312f37831f7962ebbf2f2df99e8ff4801b090247

Only load Analytics widget when Analytics is active.

view details

Evan Mattson

commit sha 2a9d3a159596c0b42b7b32e2fb8a9ecaf34bab02

Merge pull request #4250 from google/fix/4178-adsense-widget

view details

Evan Mattson

commit sha 08c4e3fbdda986b0c5a1e30d2143c8ee2974fd53

Merge pull request #4251 from google/fix/4048

view details

Eugene Manuilov

commit sha 21ae56ae5f44ff3b8fd17fa71dedde4a67bb9697

Merge remote-tracking branch 'origin/main' into enhancement/4226-zero-data-states.

view details

Eugene Manuilov

commit sha 7afa1add0a6dae7671703c25c6aea068a5d441a9

Update DashboardSearchVisitorsWidget stories.

view details

push time in 2 days

push eventgoogle/site-kit-wp

Eugene Manuilov

commit sha 081f8a859e3613b700ec685debf0bb5fd961ea38

Fix broken js tests.

view details

Eugene Manuilov

commit sha b57efb2872c825e4ac0b18ec5fc7e62963c1f999

Revert changes in the SettingsActiveModule component.

view details

push time in 2 days

push eventgoogle/site-kit-wp

Asvin Balloo

commit sha bedb26dc759245f33f4a90bfb236217a1f023e92

Add AdBlockerWarning Widget.

view details

Arafat Zahan

commit sha c624ee0580e9fbebf292d7bc0ca305c44fff78f7

Fix Unified Dasboard Header Elements.

view details

Arafat Zahan

commit sha 99ffe6042bf014799ca01a4d241585f559af5730

Add label to search field.

view details

Arafat Zahan

commit sha c335dec4f6dc9fd430134bff0b3f1193c887b610

Improve reauthenticate message for 'access_denied' error.

view details

Asvin Balloo

commit sha d421c2bd7052c1045677b3b6d9d9261daa81cb18

Merge branch 'develop' into fix/4178-adblocker-widget.

view details

Felix Arntz

commit sha f64f86791eddf60a9baea1b8ef62fadcb5f8e375

Update AdSense signup URL to newer version.

view details

Matthew Riley MacPherson (tofumatt)

commit sha 1df60078a9c9401f9071a41669e64bcd1972b8bb

Add an instanceID to the search ID.

view details

Matthew Riley MacPherson

commit sha 1f783fc39329df3dad98b0b072d8f368de5c3d30

Merge pull request #4224 from google/enhance/4048-follow-up Fix Unified Dashboard Header Elements.

view details

Evan Mattson

commit sha ecc7f43540d0254ca8cbcd605a53f2d9864f425b

Merge remote-tracking branch 'remotes/origin/develop'.

view details

Evan Mattson

commit sha 298ca3724445f43430f785afbbbfe0b341afaeb4

Merge pull request #4240 from google/update/adsense-url

view details

Arafat Zahan

commit sha eda6388c3f1b29b51a8cd2594e0e4bc9db1c4d95

Fix `esc_url` position.

view details

Arafat Zahan

commit sha d87082fd70ee449718dacc4a8759528ed75bf16a

Fix url for already authenticated users.

view details

Eugene Manuilov

commit sha 21023eb93e1114e24e07cb7009f610d04b98a3f1

Merge remote-tracking branch 'origin/main' into enhancement/3807-enable-ga4-support.

view details

Asvin Balloo

commit sha c1d90eaa69bfe1dacc99c1e0166f65c558d44360

Remove padding from ad blocker widget.

view details

Evan Mattson

commit sha 7cba23dd1e9e50667047e15d8d795c1778f9da39

Remove surrounding blank lines.

view details

Evan Mattson

commit sha 89fa456b086a1807467da2e4c9589b9cbf349e15

Merge pull request #4234 from google/enhance/3970-access-denied

view details

Evan Mattson

commit sha 1c55ec31e7dc78d351db3101a8f71d487be46357

Merge pull request #4206 from google/fix/4178-adblocker-widget

view details

Eugene Manuilov

commit sha 1cd44b9b35b7293210a93b9e0b462df6f7a29ae5

Update styles.

view details

Eugene Manuilov

commit sha 8d7cd8de5f1dde184eef559948fc0bb7910ed1bf

Add activation switch.

view details

Asvin Balloo

commit sha 40d6d9108c0362c94943cb02eb6ead013937cf2d

Update AdSense blocker warning messages.

view details

push time in 2 days

Pull request review commentgoogle/site-kit-wp

Enhancement/4226 zero data states

-/**

Updated.

eugene-manuilov

comment created time in 3 days

PullRequestReviewEvent

push eventgoogle/site-kit-wp

Eugene Manuilov

commit sha 038a32e3caa8f88ea7ca3c3b5f9635c04abf1054

Merge branch 'enhancement/4226-zero-data-states' of github.com:google/site-kit-wp into enhancement/4226-zero-data-states.

view details

Eugene Manuilov

commit sha b6ff9dc436249cedf9291ffb82fe156f21efba47

Add the DashboardSearchVisitorsWidget.stories.js file back.

view details

push time in 3 days

issue commentgoogle/site-kit-wp

Refactor user input events

IB ✔️

felixarntz

comment created time in 3 days

issue commentgoogle/site-kit-wp

Refactor/enhance Analytics-specific setup/settings tracking events

Update the events listed in the remaining points in the ACs.

@tofumatt could you please extend this into a list of all changes that need to be made to successfully implement "the remaining points in the ACs"?

felixarntz

comment created time in 3 days

issue commentgoogle/site-kit-wp

"Most Popular Content" table displaying page titles in different languages since 1.42.0

@kuasha420, we forgot to mention it in IB that report arguments need to be updated in storybook stories too. Please, update the following report arguments:

https://github.com/google/site-kit-wp/blob/1f783fc39329df3dad98b0b072d8f368de5c3d30/stories/module-analytics-components.stories.js#L363-L375 https://github.com/google/site-kit-wp/blob/1f783fc39329df3dad98b0b072d8f368de5c3d30/stories/module-analytics-components.stories.js#L457-L469

jamesozzie

comment created time in 3 days

issue commentgoogle/site-kit-wp

Enhance GA event dimensions sent

Thanks, @kuasha420. IB ✔️

felixarntz

comment created time in 3 days

Pull request review commentgoogle/site-kit-wp

Enhancement/4226 zero data states

 function Sparkline( { change, data, invertChangeColor, loadingHeight } ) { 		return null; 	} -	const positiveColor = ! invertChangeColor ? 'green' : 'red';-	const negativeColor = ! invertChangeColor ? 'red' : 'green';+	const colors = [];++	if ( change === null ) {+		// Use black if the change can't be determined.+		colors.push( '#3c4043' );+	} else {+		const positiveColor = ! invertChangeColor ? 'green' : 'red';+		const negativeColor = ! invertChangeColor ? 'red' : 'green';+		colors.push(+			0 <= ( parseFloat( change ) || 0 ) ? positiveColor : negativeColor+		);+	}

Ok, updated it to use green by default. Will it work?

eugene-manuilov

comment created time in 3 days

PullRequestReviewEvent

push eventgoogle/site-kit-wp

Arafat Zahan

commit sha c624ee0580e9fbebf292d7bc0ca305c44fff78f7

Fix Unified Dasboard Header Elements.

view details

Arafat Zahan

commit sha 99ffe6042bf014799ca01a4d241585f559af5730

Add label to search field.

view details

Felix Arntz

commit sha f64f86791eddf60a9baea1b8ef62fadcb5f8e375

Update AdSense signup URL to newer version.

view details

Matthew Riley MacPherson (tofumatt)

commit sha 1df60078a9c9401f9071a41669e64bcd1972b8bb

Add an instanceID to the search ID.

view details

Matthew Riley MacPherson

commit sha 1f783fc39329df3dad98b0b072d8f368de5c3d30

Merge pull request #4224 from google/enhance/4048-follow-up Fix Unified Dashboard Header Elements.

view details

Evan Mattson

commit sha ecc7f43540d0254ca8cbcd605a53f2d9864f425b

Merge remote-tracking branch 'remotes/origin/develop'.

view details

Evan Mattson

commit sha 298ca3724445f43430f785afbbbfe0b341afaeb4

Merge pull request #4240 from google/update/adsense-url

view details

Eugene Manuilov

commit sha cad1a34e9bd47e62cfc713d8587e52598c22879f

Merge remote-tracking branch 'origin/main' into enhancement/4226-zero-data-states.

view details

Eugene Manuilov

commit sha cb17d81febcac783a26ea58938c3f0c35a2aa8d2

Merge remote-tracking branch 'origin/enhancement/4226-zero-data-states' into enhancement/4226-zero-data-states.

view details

Eugene Manuilov

commit sha e948d92a79fdeb1bc2603520e4da033b21fa8e0b

Update the sparkline component to use green color by default.

view details

Eugene Manuilov

commit sha 7e7a016a2e3053188dbebcfd16fa3de389b927eb

Remove .stories.js file for the DashboardSearchVisitorsWidget component since it is added to the main widgets file with stories.

view details

push time in 3 days

Pull request review commentgoogle/site-kit-wp

Enhancement/4226 zero data states

 export default function ModulePopularPagesWidget( props ) { 			MODULES_ANALYTICS 		).hasFinishedResolution( 'getReport', [ args ] ); -		data.titles = select( MODULES_ANALYTICS ).getPageTitles(-			data.report,-			args-		);+		data.titles = ! data.error+			? select( MODULES_ANALYTICS ).getPageTitles( data.report, args )+			: undefined; -		data.loaded = reportLoaded && undefined !== data.titles;+		data.loaded =+			undefined !== data.error ||+			( reportLoaded && undefined !== data.titles );

@felixarntz, yes, i think it should fix it.

eugene-manuilov

comment created time in 3 days

PullRequestReviewEvent

issue commentgoogle/site-kit-wp

Unified Dashboard: Register existing widgets in new Content area

Thanks, @kuasha420, but this is out-of-scope for this ticket since this ticket is intended to add widgets to new areas only.

Padding and margin on half width DashboardPopularKeywordsWidget is off, specially the top padding seems unaligned with the idea hub module.

I believe this issue will be addressed in a separate ticket.

If Analytics module is not connected, the ModulePopularPagesWidget shows loading skeleton forever instead of a CTA to activate analytics module. Not sure if it falls outside of the scope this ticket.

This one will be fixed with #4226.

tofumatt

comment created time in 3 days

issue commentgoogle/site-kit-wp

Fix UI issues as a result of now showing 0s for "zero data"

@felixarntz this is ready for code review. I have included more changes in my PR that fix some edge cases and broken storybook stories.

felixarntz

comment created time in 4 days

push eventgoogle/site-kit-wp

Eugene Manuilov

commit sha d6254611064530211c8ad0b111c682de28ad5ca3

Update widgets.

view details

push time in 4 days

issue commentgoogle/site-kit-wp

Ensure Analytics widgets only show "Gathering data" box when API is actually gathering data

@wpdarren, assigning it back to you for QA. Is there anything else that we need to fix? Charts will be updated as part of the work on 4226.

felixarntz

comment created time in 4 days

issue commentgoogle/site-kit-wp

Enhance GA event dimensions sent

IB almost looks good to me. Just one comment:

  • In Google\Site_Kit\Core\Assets\Assets class:
    • Inside the get_inline_base_data method,
      • Get currently active modules list using the get_active_modules method of Google\Site_Kit\Core\Modules\Modules class.
      • add a new key ie. activeModules in inline_data array and pass the keys of the list as the value of it.

@kuasha420 let's better add a new hook for the googlesitekit_inline_base_data action to the Modules class that will add modules information to the array.

felixarntz

comment created time in 4 days

PR opened google/site-kit-wp

Enhancement/4226 zero data states

Summary

<!-- Please reference the issue this PR addresses. --> Addresses issue #4226

Relevant technical choices

<!-- Please describe your changes. -->

Checklist

  • [ ] My code is tested and passes existing unit tests.
  • [ ] My code has an appropriate set of unit tests which all pass.
  • [ ] My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • [ ] My code follows the WordPress coding standards.
  • [ ] My code has proper inline documentation.
  • [ ] I have added a QA Brief on the issue linked above.
  • [ ] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).
+326 -99

0 comment

21 changed files

pr created time in 4 days

create barnchgoogle/site-kit-wp

branch : enhancement/4226-zero-data-states

created branch time in 4 days

push eventgoogle/site-kit-wp

Eugene Manuilov

commit sha 8d9ebd74ad15de9377e3b143e22c1782cf0aaf9c

Merge remote-tracking branch 'origin/develop' into enhancement/4085-search-console-gathering.

view details

Eugene Manuilov

commit sha c73e8d79c4e7c17a2dee6a483e88e1952cc7079a

Update the ModuleOverviewWidget component.

view details

Eugene Manuilov

commit sha 2669bada3af9d710267ac721b86492a14ad481b4

Update the ModulePopularKeywordsWidget component.

view details

Eugene Manuilov

commit sha 9dcc595f8ef71b33d241c1b6fa33fecde9cbd884

Merge remote-tracking branch 'origin/develop' into enhancement/4085-search-console-gathering.

view details

Eugene Manuilov

commit sha ff3e50d15bf33acffd76c70a0c0f68a0ad844943

Merge remote-tracking branch 'origin/develop' into enhancement/4084-search-console-gathering

view details

Eugene Manuilov

commit sha 8f29a35dffdf38ae818fe1bab53c75fe28928782

Update storybook stories for SC widgets.

view details

Eugene Manuilov

commit sha 29013d0db5f044f0fd71042562182087c5f849ab

Merge branch 'enhancement/4085-search-console-gathering' of github.com:google/site-kit-wp into enhancement/4085-search-console-gathering.

view details

Eugene Manuilov

commit sha 3d6ff0b7269061b41ee886d3f914b13e4eadfa93

Update the DashboardSearchVisitorsWidget component.

view details

Eugene Manuilov

commit sha ebef725ffe66c5e0170433d96113639b2b2021fe

Delete the UseUAandGA4SnippetSwitches component.

view details

Felix Arntz

commit sha 22ded8f56153d798dcceece328dfe1467b0fea0b

Merge pull request #4225 from google/enhancement/4085-search-console-gathering Enhancement/4085 search console gathering

view details

Eugene Manuilov

commit sha e652471f5b4e8cc97a73f38d4569a79de2d370ca

Update labels for useSnippets.

view details

Eugene Manuilov

commit sha b41a1ab5eb9e56e757ef211a928f1371bcbdfef8

Merge remote-tracking branch 'origin/develop' into enhancement/3807-enable-ga4-support.

view details

push time in 4 days

push eventwpld/wpld

Eugene Manuilov

commit sha 72a68eeb493049335b1f6cbeba5b24f5f82c3fa8

Added reverse proxy back.

view details

push time in 6 days

Pull request review commentgoogle/site-kit-wp

Enhancement/4085 search console gathering

 function DashboardSearchVisitorsWidget( { 		}  		const sparklineArgs = {-			metrics: [-				{-					expression: 'ga:users',-					alias: 'Users',-				},-			], 			dimensions: [ 'ga:date', 'ga:channelGrouping' ],+			dimensionFilters: { 'ga:channelGrouping': 'Organic Search' }, 			...commonArgs, 		};  		// This request needs to be separate from the sparkline request because it would result in a different total if it included the ga:date dimension. 		const visitorsArgs = { 			compareStartDate, 			compareEndDate,-			metrics: [-				{-					expression: 'ga:users',-					alias: 'Total Users',-				},-			], 			dimensions: [ 'ga:channelGrouping' ],+			dimensionFilters: { 'ga:channelGrouping': 'Organic Search' }, 			...commonArgs, 		};  		const totalUsersArgs = {-			startDate,-			endDate,-			url, 			compareStartDate, 			compareEndDate,-			metrics: [-				{-					expression: 'ga:users',-					alias: 'Total Users',-				},-			],+			...commonArgs,

@felixarntz, see changes at the bottom of this file, I forgot to update it when I worked on 4086. As to other changes, it's just refactoring to make the component a bit more concise. I haven't changed any arguments, just moved them around to take less space.

eugene-manuilov

comment created time in 7 days