profile
viewpoint
Andy Russell euclio Amazon Robotics Cambridge, MA acrussell.com

euclio/aurelius 51

A complete solution for previewing markdown written in Rust.

euclio/chip-lang 5

A Domain-specific language for chiptune.

euclio/auto-gif 1

Artificial Intelligence Final Project - Fall 2013

euclio/circus-charlie 1

Objectdraw implementation of the classic "Circus Charlie" video game

euclio/5c-dining-api 0

Dining hall API for Claremont Colleges.

euclio/acrussell.com 0

The source code for my personal website.

euclio/apply-license 0

Automatically apply licenses to your projects

euclio/atty 0

are you or are you not a tty?

delete branch euclio/rust

delete branch : argument-span

delete time in 4 days

issue commentrust-lang/rust

Error span for missing main function is too large

@rustbot claim

lnicola

comment created time in 5 days

Pull request review commentrust-lang/rust

ensure arguments are included in count mismatch span

 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {                 );             } -            if let Some(def_s) = def_span.map(|sp| tcx.sess.source_map().guess_head_span(sp)) {-                err.span_label(def_s, "defined here");+            if let Some(def_id) = def_id {+                if let Some(node) = tcx.hir().get_if_local(def_id) {+                    let mut spans: MultiSpan = node+                        .ident()+                        .map(|ident| ident.span)+                        .unwrap_or_else(|| tcx.hir().span(node.hir_id().unwrap()))

#77739 removed hir_id(). Rebased and added it back.

euclio

comment created time in 5 days

PullRequestReviewEvent

push eventeuclio/rust

Guillaume Gomez

commit sha a215151cd357945acdb2675010708cb2d10bb4c0

Allow ascii whitespace char for doc aliases

view details

Guillaume Gomez

commit sha accc26abc0e53067d7a97d0fb19800c37a24f844

Add test for whitespace in doc alias

view details

Guillaume Gomez

commit sha 11f3476c59ee013c017e669676cfaca00a67b3f1

Enforce whitespace ascii character check for doc alias

view details

Roxane

commit sha dc183702da942f4a25bff99b2bb6073d1aa7c9f9

Replace tuple of infer vars for upvar_tys with single infer var This commit allows us to decide the number of captures required after completing capture ananysis, which is required as part of implementing RFC-2229. Co-authored-by: Aman Arora <me@aman-arora.com> Co-authored-by: Jenny Wills <wills.jenniferg@gmail.com>

view details

Aman Arora

commit sha 08d1ab0bf1c01948135548f5404eb625e454160e

Always return tupled_upvar_tys for Closure/Generator consituent tys Depending on if upvar_tys inferred or not, we were returning either an inference variable which later resolves to a tuple or else the upvar tys themselves Co-authored-by: Roxane Fruytier <roxane.fruytier@hotmail.com>

view details

Aman Arora

commit sha 3c46fd67f8b4831da9f2e8a536d34f498cf70241

traits diagnostics: Don't print closure/generator upvar_tys tuple Co-authored-by: Roxane Fruytier <roxane.fruytier@hotmail.com>

view details

Guillaume Gomez

commit sha 861b8921c08e3cbe2ff8176679cc0cb3216bb2e3

Clean up rustdoc HTML tags check pass

view details

Guillaume Gomez

commit sha 0009cbaabd6f2ba986e7631905612aa83d5970f8

Add check for HTML comments

view details

Antoine Martin

commit sha ab614b0f010e68b74b8f8a6ce26d53302fb4f14a

Implement "if-available" option for download-ci-llvm

view details

Antoine Martin

commit sha b8ae4c5e36d5ce36bf255dbaa66f64450b21efa5

Handle included config in bootstrap.py

view details

Tomasz Miąsko

commit sha 585e737ec1844e13bbf2f50f3dc1057057a52184

Validate references to source scopes

view details

Arlo Siemsen

commit sha de4bcfd33133a8c7e6947e13a0711de5352197aa

Include aarch64-pc-windows-msvc in the dist manifests

view details

est31

commit sha d7791f485ba51a4eda241a0ec70d7933858b124b

Remove unused code from rustc_middle

view details

est31

commit sha 49d4a756f1138d8246abb1c027490d1ea37be920

Remove unused code from rustc_ast

view details

est31

commit sha feaac592a303f7407d604b52aa2abf42be68b40b

Remove unused code from rustc_codegen_*

view details

est31

commit sha 6897619d6d7c530d071cb8587d12c5de3353aa75

Remove unused code from rustc_hir

view details

est31

commit sha 9ed2177d86f7d80dbd6ce23ab009cd3dc716492c

Remove unused code from rustc_infer

view details

est31

commit sha 338fad21621638ed93e4f6cb05c55105b617af71

Remove unused code from rustc_query_system

view details

est31

commit sha 58b3923ad377e79a0517ec15a672e3f8f90b10b4

Remove unused code from rustc_span

view details

est31

commit sha 215cd36e1cff1806429806cb5be81f6d1a5f98b0

Remove unused code from remaining compiler crates

view details

push time in 5 days

pull request commentrust-lang/rust

ensure arguments are included in count mismatch span

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

euclio

comment created time in 6 days

pull request commentrust-lang/rust

ensure arguments are included in count mismatch span

Rebased.

euclio

comment created time in 6 days

issue commentwebcompat/web-bugs

www.cvs.com - site is not usable

Works on Chrome, looks related to tracking protection.

euclio

comment created time in 6 days

issue openedwebcompat/web-bugs

www.cvs.com - site is not usable

<!-- @browser: Firefox 68.0 --> <!-- @ua_header: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Firefox/68.0 --> <!-- @reported_with: unknown -->

URL: https://www.cvs.com/vaccine/intake/store/covid-screener/covid-qns

Browser / Version: Firefox 68.0 Operating System: Mac OS X 10.15 Tested Another Browser: Yes Chrome

Problem type: Site is not usable Description: Buttons or links not working Steps to Reproduce:

<details> <summary>Browser Configuration</summary> <ul> <li>None</li> </ul> </details>

From webcompat.com with ❤️

created time in 6 days

push eventeuclio/rust

Dániel Buga

commit sha 3d4a2e6bb93ce4d1ffd77be7eaf3e4b752104346

Remove duplicate comment

view details

Dániel Buga

commit sha e4200512ff976b9c1afff8069ae66ace52dfbcb8

Clean up trivial if let

view details

Mara Bos

commit sha 1464fc3a0cb2b8a92c54357fcff7c632b334cb29

Move thread parker to a separate module.

view details

Mara Bos

commit sha ec13df4ec4780b679dde227db2185a82cf31c93b

Add fast futex-based thread parker for Linux.

view details

Mara Bos

commit sha f18f93d44cb2d95388865f98bb5938e572f0fc94

Mark unpark() as #[inline].

view details

Mara Bos

commit sha 568d9696e90d6bd8125d59cebf13b3af624abd31

Fix warning.

view details

Mara Bos

commit sha 2cf0f64722a92dffa12d43a4c0383a9d76becbcc

Move linux-specific futex code into `sys` module.

view details

Mara Bos

commit sha 485f882d7713b0e0b864fc8b21368910e5b8b0a7

Check conversion from Duration to timespec in futex_wait.

view details

Mara Bos

commit sha 4301b5c1cc9652247b1c465d304ff9c94df294ef

Add notes about memory ordering to futex parker implementation.

view details

bors

commit sha b8363295d555494bbaa119eba8b16a3057e6728c

Auto merge of #71274 - RalfJung:raw-init-check-aggregate, r=petrochenkov might_permit_raw_init: also check aggregate fields This is the next step for https://github.com/rust-lang/rust/issues/66151: when doing `mem::zeroed`/`mem::uninitialized`, also recursively check fields of aggregates (except for arrays) for whether they permit zero/uninit initialization.

view details

Mara Bos

commit sha 0b73fd7105db81a994a81b775a43bbdb1be3c76a

Move thread parker to sys_common.

view details

bjorn3

commit sha 71bc62b9f696ae83ef1713bd96054c92cda9f27f

Add option to pass a custom codegen backend from a driver

view details

bjorn3

commit sha 210e89198d72108fbba6de3fa539a8a92c1e7213

Add option to pass a custom codegen backend from a driver

view details

bors

commit sha d902752866cbbdb331e3cf28ff6bba86ab0f6c62

Auto merge of #77118 - exrook:stability-generic-parameters-2, r=varkor Stability annotations on generic parameters (take 2.5) Rebase of #72314 + more tests Implements rust-lang/wg-allocators#2.

view details

Eduardo Broto

commit sha 798a5cf5bc70eb7d9140b8bed4ed8c48ab16feae

Merge remote-tracking branch 'upstream/master' into rustup

view details

Dániel Buga

commit sha 89b8a97aead4aa366eb2587ffdcfa7df39f3815a

Refactor memchr to allow optimization

view details

Eduardo Broto

commit sha cd4706413fb891ffe33ef06e0c229d97258fbfaf

Run cargo dev fmt

view details

Eduardo Broto

commit sha 8bf27c5e92af39215a3d1da992a7207dafc883e1

Fix dogfood

view details

bors

commit sha db6fb90bc0d9cbf4ddf1bfa560b9e8db10851a84

Auto merge of #6091 - ebroto:rustup, r=ebroto Rustup changelog: none r? `@ghost`

view details

Bram van den Heuvel

commit sha ef7377eb058e98d43454d8635855c39051d068ce

Update chalk to 0.29.0

view details

push time in 6 days

push eventeuclio/dotfiles

Andy Russell

commit sha 8f5c2a7788c1665406fe01068e98186215048711

fix(zsh): disable flow control

view details

Andy Russell

commit sha 615cfd3a273453e07e79052eb061efcc4cc010b4

feat(zsh): bind push-line-or-edit to Ctrl+Q

view details

push time in 8 days

pull request commentrust-rosetta/rust-rosetta

Implement another solution to combinations

Looks great.

bors r+

Gadiguibou

comment created time in 8 days

pull request commentrust-rosetta/rust-rosetta

fix remaining clippy warnings

bors r+

euclio

comment created time in 11 days

PR opened rust-rosetta/rust-rosetta

fix remaining clippy warnings
+1679 -1680

0 comment

84 changed files

pr created time in 11 days

push eventeuclio/rust-rosetta

bors[bot]

commit sha 7198d4afe2140e8870e863ea0387a9450b1c8758

Merge #713 713: Fix clippy syntax and warnings r=euclio a=euclio Co-authored-by: Andy Russell <arussell123@gmail.com>

view details

Andy Russell

commit sha 20168f9c1353e0919a4ec01272bbecfc72f1d2a4

fix remaining clippy warnings

view details

push time in 11 days

pull request commentrust-rosetta/rust-rosetta

Fix clippy syntax and warnings

bors r+

euclio

comment created time in 12 days

PR opened rust-rosetta/rust-rosetta

Fix clippy syntax and warnings
+43 -41

0 comment

31 changed files

pr created time in 12 days

push eventeuclio/rust-rosetta

bors[bot]

commit sha 902dbae3b7077a1d0bb3cda63205f50a137d8184

Merge #694 694: Fix warnings from the compiler and rustfmt r=euclio a=euclio Co-authored-by: Andy Russell <arussell123@gmail.com>

view details

Polochon-street

commit sha 892a5398db1215eeadca68b179d038fc4aed0c96

Added "rep-string"

view details

bors[bot]

commit sha a92d8381456ba038c554785b91bd03656add953b

Merge #695 695: Added "rep-string" r=euclio a=Polochon-street This is https://rosettacode.org/wiki/Rep-string Maybe the logic could be improved though, I'm definitely up for hearing criticism :) Co-authored-by: Polochon-street <polochonstreet@gmx.fr>

view details

Polochon-street

commit sha 0be71a4d92054ce60c535e16cf762d073d0a3f0b

Add phrase reversal https://rosettacode.org/wiki/Phrase_reversals#Python

view details

bors[bot]

commit sha 8c2878d1bbb45db14090ad70d59bdcc99b8630be

Merge #696 696: Add phrase reversal r=euclio a=Polochon-street https://rosettacode.org/wiki/Phrase_reversals Not sure about cloning the string every time, but it wasn't indicated in the task's description, so... Co-authored-by: Polochon-street <polochonstreet@gmx.fr>

view details

Eli Flanagan

commit sha 1642e32e5872c0a43f17804768c159059f8d83ab

nitpick minor typo

view details

Eli Flanagan

commit sha d726a59ff6e31f6c0ba3bc5a5fdff360432166dc

remove String allocations, style tweaks

view details

Eli Flanagan

commit sha 29aeb58cbaa1cdbb7c96ae343ad652088224adda

use an array instead of a vector Arrays express fixed lists more precisely.

view details

bors[bot]

commit sha 796bf58ebe8c857db53f8f87f6e1980b78bc1dd9

Merge #697 697: nitpick minor typo r=euclio a=efx Meandered into [tasks/rep-string/src/main.rs](https://github.com/rust-rosetta/rust-rosetta/blob/1642e32e5872c0a43f17804768c159059f8d83ab/tasks/rep-string/src/main.rs) - fix a typo - remove needless `String::from` creations and make some style changes @Polochon-street nice work! I saw your comment in a92d8381456ba038c554785b91bd03656add953b and figured I'd PR :smile: If you want we could take a functional programming approach for some of that logic too. Co-authored-by: Eli Flanagan <eli@typedspace.com>

view details

Eli Flanagan

commit sha a7daef9944787e7fdc84e3547a848c13d10b9984

allow for ? operator Rust 2018 lets you use this when defining the main return signature accordingly.

view details

Eli Flanagan

commit sha b3b322898348ac19d84ef6e0af52e5a300b4f8ab

use if let for brevity

view details

Eli Flanagan

commit sha e564157005562f221fe71d0ddd808e1e3ffb11ea

condense import. functional style

view details

Eli Flanagan

commit sha d8ee6efd31cb9d69bc45489e9fa4739740e2f04d

use for_each

view details

Eli Flanagan

commit sha 15c77f5627dd044edfd0be14b66ddce62dce5a1e

incorporate euclio's helpful feedback

view details

Eli Flanagan

commit sha 1e5419997e32054231a4f9e69b9c4035e55a3787

apply a few clippy lints

view details

bors[bot]

commit sha 02b2dfdd226da7bfc8c3fbca1ec747b0ac90b878

Merge #698 698: improve unix/ls task r=euclio a=efx - 2018 edition - slightly more functional style - using `?` operator over `unwrap()` Co-authored-by: Eli Flanagan <efx@users.noreply.github.com>

view details

Eli Flanagan

commit sha 16dc148c8eea497e4ab5ff2cc061f1da6bb9beea

Merge branch 'master' into internal-clippy-lints

view details

Eli Flanagan

commit sha a2f506df323394c6652cde7b31a2a546e88edd6c

migrate to 2018 edition remove commented code, add TODO

view details

Polochon-street

commit sha e631d925d9a215bb6cc5af50cd81d391d7babaf2

Add soundex http://rosettacode.org/wiki/Soundex

view details

Eli Flanagan

commit sha f89fd34d93d6e06db173b2cec03bd13e14497396

use ? operator as well

view details

push time in 12 days

Pull request review commentrust-lang/rust

suggest `MAX` constant if -1 is assigned to unsigned type

 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {                     match actual.kind() {                         Uint(_) if op == hir::UnOp::UnNeg => {                             err.note("unsigned values cannot be negated");++                            if let hir::ExprKind::Unary(+                                _,+                                hir::Expr {+                                    kind:+                                        hir::ExprKind::Lit(Spanned {+                                            node: ast::LitKind::Int(1, _),+                                            ..+                                        }),+                                    ..+                                },+                            ) = ex.kind+                            {+                                err.span_suggestion(+                                    ex.span,+                                    &format!("obtain the maximum `{}` value with its `MAX` associated constant", actual),

Fixed, but tweaked slightly.

euclio

comment created time in 12 days

PullRequestReviewEvent

push eventeuclio/rust

Andy Russell

commit sha ced11a83cb6cae998df514eb08d1f3dc4bd990c8

suggest `MAX` constant if -1 is assigned to unsigned type

view details

push time in 12 days

issue commentrust-lang/rust-clippy

lint unnecessary literal casts

I think the lints serve different purposes. I 1 as u32 is almost certainly a mistake, while there are legitimate uses of as casts in general (which is why it's allow-by-default).

euclio

comment created time in 13 days

startedjasdel/vim-smithy

started time in 14 days

pull request commentrust-rosetta/rust-rosetta

Fix Clippy warnings

bors r+

brenov

comment created time in 15 days

pull request commentrust-rosetta/rust-rosetta

Fix Clippy warnings

Thanks! bors r+

brenov

comment created time in 15 days

Pull request review commentrust-lang/rust

suggest `MAX` constant if -1 is assigned to unsigned type

 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {                     match actual.kind() {                         Uint(_) if op == hir::UnOp::UnNeg => {                             err.note("unsigned values cannot be negated");++                            if let hir::ExprKind::Unary(+                                _,+                                hir::Expr {+                                    kind:+                                        hir::ExprKind::Lit(Spanned {+                                            node: ast::LitKind::Int(1, _),+                                            ..+                                        }),+                                    ..+                                },+                            ) = ex.kind+                            {+                                err.span_suggestion(+                                    ex.span,+                                    &format!("obtain the maximum `{}` value with its `MAX` associated constant", actual),

Not sure if "its" is the right word here. "the" might work better.

euclio

comment created time in 15 days

PullRequestReviewEvent

issue commentrust-lang/rust

Error message on casting negative numbers to usize is quite unhelpful

The compiler should also suggest to replace -1 as usize with -1_usize, to remove some hard "as" casts from the code.

I think this is more appropriate as a clippy lint, opened https://github.com/rust-lang/rust-clippy/issues/6116.

Disasm

comment created time in 15 days

issue openedrust-lang/rust-clippy

lint unnecessary literal casts

What it does

Lints unnecessary as-casts of literals when they could be written using literal syntax.

Categories (optional)

  • Kind: clippy::style

What is the advantage of the recommended code over the original code

  • Avoids accidental truncation
  • Uses syntax dedicated to this purpose

Drawbacks

None.

Example

1 as u32

Could be written as:

1u32

created time in 15 days

PR opened rust-lang/rust

suggest `MAX` constant if -1 is assigned to unsigned type

Fixes #76413. Fixes #77416.

+70 -0

0 comment

4 changed files

pr created time in 15 days

create barncheuclio/rust

branch : max-suggestion

created branch time in 15 days

startedkabili207/zoragen-gtk

started time in 16 days

startedkabili207/zora-sharp

started time in 16 days

Pull request review commentrust-rosetta/rust-rosetta

Fix Clippy warnings

 pub struct LocalTask {     pub title: String, } +/// Return a closure that checks if a package has a proc-macro or dylib target.+fn is_dylib_or_proc_macro() -> Box<dyn Fn(&cargo_metadata::Target) -> bool> {

Ah, I meant a function fn is_dylib_or_proc_macro(target: &cargo_metadata::Target) -> bool.

brenov

comment created time in 17 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentrust-lang/rust

Error message on casting negative numbers to usize is quite unhelpful

@rustbot claim

Disasm

comment created time in 18 days

Pull request review commentrust-rosetta/rust-rosetta

Fix Clippy warnings

 where          // If the package has a proc-macro or dylib target, it's probably just a dependency of         // another task. Skip it.-        if package.targets.iter().any(|t| {+        let closure = |t: &cargo_metadata::Target| {

Let's extract this into a fn is_dylib_or_proc_macro.

brenov

comment created time in 18 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentrust-lang/rust-clippy

Wrong similar code lint

For the case in the OP, it would be worthwhile to suggest #[derive(PartialEq, Eq)] as well.

leonardo-m

comment created time in 19 days

Pull request review commentrust-lang/rust

ensure arguments are included in count mismatch span

 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {                 );             } -            if let Some(def_s) = def_span.map(|sp| tcx.sess.source_map().guess_head_span(sp)) {-                err.span_label(def_s, "defined here");+            if let Some(def_id) = def_id {+                if let Some(node) = tcx.hir().get_if_local(def_id) {+                    let mut spans = Vec::with_capacity(1 + expected_count);++                    // Fall back to the full span if the node doesn't have an ident (tuple variants).+                    spans.push(+                        node.ident()+                            .map(|ident| ident.span)+                            .unwrap_or_else(|| tcx.hir().span(node.hir_id().unwrap())),+                    );++                    if let Some(id) = node.body_id() {+                        let body = tcx.hir().body(id);+                        spans.extend(body.params.iter().map(|param| param.span));+                    }++                    let def_kind = tcx.def_kind(def_id);+                    err.span_note(+                        MultiSpan::from_spans(spans),

Done.

euclio

comment created time in 24 days

PullRequestReviewEvent

Pull request review commentrust-lang/rust

ensure arguments are included in count mismatch span

 error[E0061]: this function takes 2 arguments but 1 argument was supplied   --> $DIR/E0061.rs:6:5    |-LL | fn f(a: u16, b: &str) {}-   | --------------------- defined here-... LL |     f(0);    |     ^ - supplied 1 argument    |     |    |     expected 2 arguments+   |+note: function defined here+  --> $DIR/E0061.rs:1:4+   |+LL | fn f(a: u16, b: &str) {}+   |    ^ ^^^^^^^ ^^^^^^^^

Fixed.

euclio

comment created time in 24 days

PullRequestReviewEvent

push eventeuclio/rust

Vali Schneider

commit sha 459969f88ff95c94b7b34043a7f0e13de91de4f8

added restriction lint that prohibits the usage of unimplemented, unreachable or panic in a function of type result or option

view details

Vali Schneider

commit sha ceab1a9167655eba9f9556f8766f8702e49dfef3

removed unnecessary comment

view details

Vali Schneider

commit sha 8462cce96081b87eba7a5bc89130a1a09fe1f6d0

edited documentation

view details

Vali Schneider

commit sha b2d8ca9a766703469178ea37d4d46067bb6fa926

ran cargo dev update lints

view details

Vali Schneider

commit sha b006522393a3c3c2656e1ccdfbb0076ff1bd7e99

added lint for todo and removed option

view details

Vali Schneider

commit sha a424a2c1676a29c147252873037e8943d54941d3

changed check_impl_item to check_fn and added a few more test cases

view details

Vali Schneider

commit sha 73a3288282e733bfc5893e9920d29f1de5a21591

uncommented fn

view details

Erik Desjardins

commit sha d3b9ece4c0028ff7e36e34df2d2b26366f9c0648

add tests related to tuple scalar layout with ZST in last field

view details

Erik Desjardins

commit sha e5d85f917b8965a5e62513c17cbb887366b152bc

allow reordering of the last field of a MaybeUnsized struct if it's a ZST

view details

Erik Desjardins

commit sha e9bc3ddb073f2261ac46832d985efe8db863ed6a

test that we do not change the offset of ZST tuple fields when unsizing

view details

Erik Desjardins

commit sha 68217c9e0f1269d29b4c1c72d08fb1b95bf441cd

ignore zst offsets instead

view details

Erik Desjardins

commit sha 6fc1d8bc13124bb134d7ab54e56237821a55912e

add codegen test

view details

Erik Desjardins

commit sha 24e0913e37cc6fc363b37d13bf519db212f175a2

handle vector layout

view details

Vali Schneider

commit sha f9fcbbea03edb735c22311522b55d7b854bd6ac0

fixed bug

view details

Ricky

commit sha e49a29933be3bd988ccb75b053f480d9c99a7ff5

Working map_err_ignore lint

view details

Ricky

commit sha 202a80c927412a548180eca5990ee764d76ed643

Added tests for map_err, ignored map_err lint on drop_ref tests

view details

Ricky

commit sha 337729137bdec31b55665653ef0cf7dc124b0eaa

Ran cargo dev update_lints

view details

Ricky

commit sha 2387f68e437bf2ff5f117f63936257ce64052cfa

Removed map_err suggestion in lint, and updated lint documentation example

view details

Jane Lusby

commit sha c31d4730b0d40c62934839405d0c25e2ffa3fad1

update example to be more idiomatic

view details

Ricky

commit sha 4f1c4a99d4d98f1acea3c9c7cc55355aa46119aa

Fixed typo in lint and test

view details

push time in 24 days

delete branch euclio/rust

delete branch : param-spans

delete time in 24 days

PR closed rust-lang/rust

fix off-by-one in parameter spans S-waiting-on-review

Uncovered by #75023.

+37 -37

1 comment

4 changed files

euclio

pr closed time in 24 days

PR opened rust-lang/rust

fix off-by-one in parameter spans

Uncovered by #75023.

+37 -37

0 comment

4 changed files

pr created time in 24 days

create barncheuclio/rust

branch : param-spans

created branch time in 24 days

push eventeuclio/rust

Andy Russell

commit sha 6b38eaade16be6bf50f2c6c287ab0e62b1d8be8b

ensure arguments are included in count mismatch span

view details

push time in 24 days

pull request commentrust-rosetta/rust-rosetta

Implemented "Display a Linear Combination"

Thanks!

bors r+

bdamitz

comment created time in a month

create barncheuclio/rust

branch : intra-link-escapes

created branch time in a month

PullRequestReviewEvent

Pull request review commentrust-lang/rust

Refactor and fix intra-doc link diagnostics, and fix links to primitives

 impl<'a, 'tcx> LinkCollector<'a, 'tcx> {         let ty_res = match ty_res {             Err(()) | Ok(Res::Err) => {                 return if ns == Namespace::ValueNS {-                    self.variant_field(path_str, current_item, module_id, extra_fragment)+                    self.variant_field(path_str, current_item, module_id)                 } else {-                    // See if it only broke because of the namespace.

Please file an issue so we don't forget.

jyn514

comment created time in a month

PullRequestReviewEvent

pull request commentrust-lang/rust

ensure arguments are included in count mismatch span

@rustbot modify labels: -S-waiting-on-author +S-waiting-on-review

euclio

comment created time in a month

push eventeuclio/rust

Simon Vandel Sillesen

commit sha c2693db264900005ceb13f917dc1fab0cbf8d459

Add peephold optimization that simplifies Ne(_1, false) and Ne(false, _1) into _1 This was observed emitted from the MatchBranchSimplification pass.

view details

Simon Vandel Sillesen

commit sha 9b0fc6202bf295e2518f7a781ca069c71c81698f

Generalize to Eq(true, _place) and Eq(_place, true)

view details

Sasha

commit sha 84fc6fd2d0005d452ec966a65518948e3eab3f06

Fix documentation for TyCtxt::all_impls

view details

bors

commit sha 23e49ddafbe6765d117d3c7e2485d7ac73d9d79e

Auto merge of #76370 - fusion-engineering-forks:synconcecell-soundness, r=nagisa Fix dropck issue of SyncOnceCell. Fixes #76367.

view details

Elichai Turkel

commit sha 2e82589741a475185421a481f7a00142725fb609

linker-plugin-lto.md: Convert the rust-clang MxN table to a 2xM table

view details

Ralf Jung

commit sha 720293b6407ad883c609efb6badda990edf59769

do not premote non-ZST mutable references ever

view details

Ralf Jung

commit sha 28ddda76b730960cdfd35f188345af0299e29517

add compile-fail test for &mut promotion

view details

bors

commit sha aa81d32165dc9f0952bc520f223503aedd755b31

Auto merge of #76128 - poliorcetics:doc-use-arc-clone, r=KodrAus Use Arc::clone and Rc::clone in documentation This PR replaces uses of `x.clone()` by `Rc::clone(&x)` (or `Arc::clone(&x)`) to better match the documentation for those types. @rustbot modify labels: T-doc

view details

Jonas Schievink

commit sha 24dc182f2013cf53c23120ae1a09d256c8c98fa8

Remove unneeded `#[cfg(not(test))]` from libcore

view details

bors

commit sha 4b65872d272875adb298b6dc12d5e4e79cf8e263

Auto merge of #76067 - simonvandel:peephole-ne, r=wesleywiser MIR peephole optimize {Ne, Eq}(_1, false) into _1 Add peephole optimization that simplifies Ne(_1, false) and Ne(false, _1) into _1. Similarly handles Eq(_1, true) and Eq(true, _1). This was observed emitted from the MatchBranchSimplification pass.

view details

bors

commit sha ac892a12743551c98da1d4b8c6366e285a10833f

Auto merge of #76390 - MaulingMonkey:pr-min-cdb-version, r=petrochenkov debuginfo: Ignore HashMap .natvis tests before cdb 10.0.18362.1 CDB <10.0.18362.1 chokes on casts within HashMap's natvis visualizers. This PR adds support for "min-cdb-version" (per existing "min-gdb-version" and "min-lldb-version" filters) and uses it. CI uses a more recent version of CDB for testing and thus should still run the tests. Credit to @petrochenkov per https://github.com/rust-lang/rust/issues/76352 for helping catch this. ### SDK Testing | Win 10 SDK | x64 CDB | rustc 1.47.0-nightly (bf4342114 2020-08-25) built-in .natvis | Note | | --------------------------------------------------------------------- | ----------------- | ------------------------------------------------------------- | ---- | | [10.0.19041.0](https://go.microsoft.com/fwlink/p/?linkid=2120843) | 10.0.19041.1 | ✔️ | CI | [10.0.18362.1](https://go.microsoft.com/fwlink/?linkid=2083338) | 10.0.18362.1 | ✔️ | MaulingMonkey | [10.0.17763.0](https://go.microsoft.com/fwlink/p/?LinkID=2033908) | 10.0.17763.132 | ❌ `Unable to find type 'tuple<u64,u64> *' for cast.` | [10.0.17134.12](https://go.microsoft.com/fwlink/p/?linkid=870807) | 10.0.17134.12 | ❌ `Unable to find type 'tuple<u64,u64> *' for cast.` | [10.0.16299.91](https://go.microsoft.com/fwlink/p/?linkid=864422) | 10.0.16299.91 | ❌ `Unable to find type 'tuple<u64,u64> *' for cast.` | [10.0.15063.468](https://go.microsoft.com/fwlink/p/?LinkId=845298) | 10.0.15063.468 | ❌ `Unable to find type 'tuple<u64,u64> *' for cast.` | [10.0.14393.795](https://go.microsoft.com/fwlink/p/?LinkId=838916) | 10.0.14321.1024 | ❌ `Unable to find type 'tuple<u64,u64> *' for cast.` | petrochenkov | [10.0.10586.212](https://go.microsoft.com/fwlink/p/?LinkID=698771) | 10.0.10586.567 | ❌ `Expected ')' at '+ 1)].__1'` | [10.0.10240](https://go.microsoft.com/fwlink/p/?LinkId=619296) | 10.0.10240? | ❔ Untested ### Rust Testing ```cmd x.py test --stage 1 src/tools/tidy x.py test --stage 1 --build x86_64-pc-windows-msvc src\test\debuginfo ``` Also verified test still fails when intentionally broken w/ CDB version >= min-cdb-version.

view details

Jens Reidel

commit sha 78097d96828c16a259fa9b5c2430e8d9ff1820b3

initial attempt to add aarch64-unknown-linux-musl to dist-linux-arm

view details

bors

commit sha 5d74e880061c250936105125a2ffa901f315aaaa

Auto merge of #75949 - vext01:filter-docs, r=jyn514 Try to improve the documentation of `filter()` and `filter_map()`. I believe the documentation is currently a little misleading. For example, in the docs for `filter()`: > If the closure returns `false`, it will try again, and call the closure on > the next element, seeing if it passes the test. This kind of implies that if the closure returns true then we *don't* "try again" and no further elements are considered. In actuality that's not the case, every element is tried regardless of what happened with the previous element. This change tries to clarify that by removing the uses of "try again" altogether.

view details

Joshua Nelson

commit sha 3ecfd5ca518364ba0c5fb4ed92d5ae16245f6171

Move sections about contributing closer together

view details

Joshua Nelson

commit sha aee0ef13dd13b84dd270f7729fae5e9918ee309c

Remove duplicate 'note:'

view details

bors

commit sha 73dc675b9437c2a51a975a9f58cc66f05463c351

Auto merge of #76157 - ArekPiekarz:const_caller_location_tracking_issue, r=joshtriplett Update tracking issue for const_caller_location Update the tracking issue to https://github.com/rust-lang/rust/issues/76156, as suggested in https://github.com/rust-lang/rust/issues/76105.

view details

Vadim Petrochenkov

commit sha 77d11c3ce2976adaee83cf5b9f60449467557868

rustbuild: Build tests with LLD if `use-lld = true` was passed

view details

Vadim Petrochenkov

commit sha 8e6b563b934c0f5b57b38c57efdd005ed100d64c

rustbuild: Build tests with LLD if `use-lld = true` was passed (non-msvc)

view details

Vadim Petrochenkov

commit sha 5118a51b4d49a139ea21d280001105948de298f7

rustbuild: Propagate LLD to more places when `use-lld` is enabled

view details

Vadim Petrochenkov

commit sha b27fca71d46b2da88611bb5cc8cfb6e90c0a4af0

rustbuild: Deduplicate LLD checks slightly

view details

push time in a month

Pull request review commentrust-lang/rust

Refactor and fix intra-doc link diagnostics, and fix links to primitives

 fn resolution_failure(             // ignore duplicates             let mut variants_seen = SmallVec::<[_; 3]>::new();             for mut failure in kinds {-                // Check if _any_ parent of the path gets resolved.-                // If so, report it and say the first which failed; if not, say the first path segment didn't resolve.-                if let ResolutionFailure::NotInScope { module_id, name } = &mut failure {-                    let mut current = name.as_ref();-                    loop {-                        current = match current.rsplitn(2, "::").nth(1) {-                            Some(p) => p,-                            None => {-                                *name = current.to_owned().into();-                                break;-                            }-                        };-                        if let Some(res) =-                            collector.check_full_res(TypeNS, &current, *module_id, &None, &None)-                        {-                            failure = ResolutionFailure::NoAssocItem(res, Symbol::intern(current));-                            break;-                        }-                    }-                }                 let variant = std::mem::discriminant(&failure);                 if variants_seen.contains(&variant) {                     continue;                 }                 variants_seen.push(variant);-                let note = match failure {-                    ResolutionFailure::NotInScope { module_id, name, .. } => {-                        if in_scope {-                            continue;++                if let ResolutionFailure::NotResolved { module_id, partial_res, unresolved } =+                    &mut failure+                {+                    use DefKind::*;++                    let module_id = *module_id;+                    // FIXME(jynelson): this might conflict with my `Self` fix in #76467+                    // FIXME: maybe use itertools `collect_tuple` instead?+                    fn split(path: &str) -> Option<(&str, &str)> {+                        let mut splitter = path.rsplitn(2, "::");+                        splitter.next().and_then(|right| splitter.next().map(|left| (left, right)))+                    }++                    // Check if _any_ parent of the path gets resolved.+                    // If so, report it and say the first which failed; if not, say the first path segment didn't resolve.+                    let mut name = path_str;+                    'outer: loop {+                        let (start, end) = if let Some(x) = split(name) {+                            x+                        } else {+                            // avoid bug that marked [Quux::Z] as missing Z, not Quux+                            if partial_res.is_none() {+                                *unresolved = name.into();+                            }+                            break;+                        };+                        name = start;+                        for &ns in &[TypeNS, ValueNS, MacroNS] {+                            if let Some(res) =+                                collector.check_full_res(ns, &start, module_id, &None, &None)+                            {+                                debug!("found partial_res={:?}", res);+                                *partial_res = Some(res);+                                *unresolved = end.into();+                                break 'outer;+                            }                         }-                        // NOTE: uses an explicit `continue` so the `note:` will come before the `help:`-                        let module_name = collector.cx.tcx.item_name(module_id);-                        let note = format!("no item named `{}` in `{}`", name, module_name);+                        *unresolved = end.into();+                    }++                    let last_found_module = match *partial_res {+                        Some(Res::Def(DefKind::Mod, id)) => Some(id),+                        None => Some(module_id),+                        _ => None,+                    };+                    // See if this was a module: `[path]` or `[std::io::nope]`+                    if let Some(module) = last_found_module {+                        let module_name = collector.cx.tcx.item_name(module);+                        let note = format!(+                            "the module `{}` has no inner item named `{}`",

nit: I prefer "contains" over "has". Consider module `{}` does not contain an item `{}`

jyn514

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

issue commentrust-lang/rust

Rustdoc feature idea: Documentation comment blocks

Block syntax is already supported as /**: https://doc.rust-lang.org/stable/reference/comments.html#doc-comments

bdashore3

comment created time in a month

startedJakeWharton/picnic

started time in a month

push eventeuclio/pixels

Andy Russell

commit sha fbc11b24ab4e3a8eff14ce42a489a9e9703b7b82

use wgpu commit with polyfilled buffer creation

view details

push time in a month

pull request commentrust-lang/rust

Remove weird looking dashes

"Documenting platform or feature specific information" reads well to me.

arijit79

comment created time in a month

delete branch euclio/rust-clippy

delete branch : println-empty

delete time in a month

pull request commentrust-lang/rust-clippy

{print,write}-with-newline: do not suggest empty format string

Updated. I'm not super happy about the span on writeln!, but I'm not sure trying to finagle the span to include the , is worth it. Unfortunately rustfmt won't take care of it.

euclio

comment created time in a month

push eventeuclio/rust-clippy

Andy Russell

commit sha 0261e341fd435f0b42954510fb436cb0b289cdac

{print,write}-with-newline: do not suggest empty format string

view details

push time in a month

pull request commentautozimu/LanguageClient-neovim

support the workspace/configuration request

Yes, this is an instance of microsoft/language-server-protocol#972.

euclio

comment created time in a month

pull request commentrust-lang/rust-clippy

print-with-newline: do not suggest `println!("")`

Oops, this is not quite ready to go: I need to get write_with_newline to work as well.

euclio

comment created time in a month

create barncheuclio/rust-clippy

branch : println-empty

created branch time in a month

PR opened rust-lang/rust-clippy

print-with-newline: do not suggest `println!("")`

changelog: do not suggest println!("") in print-with-newline

+23 -7

0 comment

3 changed files

pr created time in a month

push eventeuclio/rust-clippy

Andy Russell

commit sha ed245c9a040e6518de2ba886e17b391ca135e687

print-with-newline: do not suggest `println!("")`

view details

push time in a month

push eventeuclio/rust-rosetta

Andrew Hobden

commit sha 2f13720accad297dfa5af67386dd38f8591eef31

Merge pull request #617 from euclio/clippy fix clippy warnings

view details

areinull

commit sha 3b9faa5dd2c3f72635e4f2f2317793011f5b9b46

chaos game initial version fix clippy warnings rustfmt changes

view details

areinull

commit sha e67295ccf50d9acce0eca989612f4041cc7bb15f

Implement Mandelbrot set

view details

TheIronBorn

commit sha e63899fe9163683df14802ae0e197c8bc9f465cc

Add CLI take notes

view details

TheIronBorn

commit sha 0fb6748a6eac9a5c2740477e8b99e2639983cd2d

add cargo.toml

view details

TheIronBorn

commit sha 22e9d16f9c00d5f5833a16ae2822e6167c439b73

update workspace members

view details

TheIronBorn

commit sha 0c5777b2ec7cd5cfd8f1d01708bfc1f3aaf29726

Implement unbias RNG

view details

TheIronBorn

commit sha 2bdc69efe03ad6aed425c3c41580679dd492b28c

add cargo.toml

view details

TheIronBorn

commit sha e07ad5851ce95d2a0630b353b41637e8f7dd682a

update workspace members

view details

TheIronBorn

commit sha 54468e9644fb32bdf82dcef1c86a2cfdeaeb97d8

implement random circle points

view details

TheIronBorn

commit sha 6140aa54d525d52e7b504eee61da01f817c96468

add cargo.toml

view details

TheIronBorn

commit sha d1cc8be5d18a8bc37e15e9ea13812c9d17d2a33c

update workspace members

view details

TheIronBorn

commit sha 40331f6ef83086924292f098f5d8ad88db14091f

loosen test

view details

TheIronBorn

commit sha 70b7cc46cf832b0b704d03d9c9f41db2ce9e4ab7

implement RNG (device)

view details

TheIronBorn

commit sha 5459b133ca0e026896d560053d2737ab9b1966bd

add cargo.toml

view details

TheIronBorn

commit sha f23c45e23f903d7dad07d82917e48bb58ca8b3d5

update workspace members

view details

areinull

commit sha a7395b69cafe0f2e2de3306cca8844def1e8f35a

explicit deps version

view details

areinull

commit sha b696d55e6a25bcb8e3565600a6f5c9262e51676f

explicit deps version

view details

TheIronBorn

commit sha 7a8e91489378852eb1e8bdf5866551fc3a8c9efe

improve error handling, switch to chrono crate

view details

TheIronBorn

commit sha a92a59abb1cc4076cbebbff22dc4c52428945122

switch to chrono

view details

push time in a month

pull request commentrust-rosetta/rust-rosetta

roots-of-unity: do not collect into Vec

Looks great, thank you!

bors r+

jhwgh1968

comment created time in a month

pull request commentrust-lang/rust

ensure arguments are included in count mismatch span

Yes, I'll try to get back to this this weekend.

euclio

comment created time in a month

issue commentrust-lang/rust

rustdoc: Item summaries have unrendered Markdown and sometimes don't show up

This is a dupe of #32040.

camelid

comment created time in a month

pull request commentautozimu/LanguageClient-neovim

support the workspace/configuration request

I'm not familiar with gopls, but it sounds like there might be some discrepancy between how it and rust-analyzer handle configuration: https://github.com/golang/go/issues/38819

euclio

comment created time in a month

pull request commentautozimu/LanguageClient-neovim

support the workspace/configuration request

I realized I was merging this PR into the wrong branch, which is why the lint errors were showing up. Fixed.

euclio

comment created time in a month

push eventeuclio/LanguageClient-neovim

OKURA Masafumi

commit sha a9231fd4feb0e9abde16c1dcd10ac563b01b82c3

Fix typo (#1074) Tring -> Trying

view details

martskins

commit sha 406be2bd628c0fb45c9513dc0e6a15ce361a36e3

Add LanguageClient_textDocument_formatting_sync function (#1077)

view details

martskins

commit sha c17681c5a7655eaaec1cada78421c8f4c014eb1a

Prioritise diagnostics over code lenses in virtual texts (#1076)

view details

Yuki Ito

commit sha b7189042576029aa8077dfd4eb7e4042561c8ea4

Add feature to filter diagnostics messages by its source

view details

Junfeng Li

commit sha dcdd3e4b06fde2b63c8a583fbfdb9f1e562752cc

Replace structopt with clap and remove commit hash from version string

view details

Junfeng Li

commit sha 9de13bc7411f08ad52e0f5c4ca562d1c4daadaae

Add rust-toolchain file and replace cargo with rustup - Avoid issue of compiling project with an older version of compiler and getting error due to new API such as `Option::as_deref`. - Will download and use binaries from rust-lang.org based on specified version in rust-toolchain. This avoid the issue that compiler loads plugin using different versions of glibc/ld than the ones used to produce the plugin. See https://github.com/rust-lang/rust/issues/58394

view details

Junfeng Li

commit sha 468aaf93cd5358ce8b2f779967e3261f772326e8

Simplify CI

view details

Junfeng Li

commit sha adf7d7b2f755799c2be11dc0a47cfcd425529ffa

Fix lint

view details

Junfeng Li

commit sha 217feedd131fe4c05831f72bad965dce9c79dcbb

Fix CI

view details

martskins

commit sha d4d1db7bf29385c4501f9aaf42a74c16e033c23a

Add function and plug mappings to cycle diagnostics (#1075) * Add function and plug mappings to cycle diagnostics * Fix lint errors

view details

David Hotham

commit sha b47cc8f63511aefc7cee472462293001aa735671

Update dependencies (#1080) * Bump lsp-types * bump itertools * Cargo update

view details

Damien Radtke

commit sha a98835f26eb32e72370351a69088434236e5319a

Fix recursive notify (#1047) This commit attempts to fix filesystem notifications for recursive paths that also specify an extension, such as "**/*.java".

view details

Andy Russell

commit sha 226f0217d1d75f72563aad280cfc35ff0a90c114

support the workspace/configuration request

view details

push time in a month

push eventeuclio/LanguageClient-neovim

Andy Russell

commit sha 4ea9347649c620707699971d0a6229c5aabaffaa

fix clippy warnings

view details

push time in a month

startedKDAB/hotspot

started time in a month

delete branch euclio/rust

delete branch : intra-link-iterator

delete time in a month

startedy4my4my4m/kde-shader-wallpaper

started time in a month

issue commentparasyte/pixels

WASM support

I tried binding the Gecko branch here: https://github.com/euclio/pixels/tree/web

Unfortunately the code depends on getMappedRange, which causes Firefox to segfault and isn't supported on Chrome.

euclio

comment created time in a month

push eventeuclio/pixels

Andy Russell

commit sha ee2d6705cbe264dc2cea13bc4b2086be0efc677f

add web support to minimal-winit

view details

push time in a month

push eventeuclio/pixels

Andy Russell

commit sha 9fabefd333b7770ae5696daacde575237ec4dee3

change texture format (crash)

view details

push time in a month

push eventeuclio/pixels

Andy Russell

commit sha e7876b09a3cf61ae13ae9a1d8fe0c85f01ed90d3

use shared instance

view details

Andy Russell

commit sha 36f8dd543a13d68c5c8732b5c5e41e453b05b5ca

fix borrow error

view details

push time in a month

push eventeuclio/pixels

Andy Russell

commit sha d03f71c441b9f629140c37f2031dd389801f6273

make work in both web and native

view details

push time in 2 months

push eventeuclio/pixels

Andy Russell

commit sha ba3054b4a62c221d4c6b4fc005af99e0cb5482fd

make work in both web and native

view details

push time in 2 months

PR opened rust-lang/rust

add some intra-doc links to `Iterator`
+13 -13

0 comment

1 changed file

pr created time in 2 months

create barncheuclio/rust

branch : intra-link-iterator

created branch time in 2 months

delete branch euclio/rust

delete branch : rustdoc-summaries

delete time in 2 months

Pull request review commentrust-lang/rust

rustdoc: do not use plain summary for trait impls

 impl MarkdownSummaryLine<'_> {     } } -pub fn plain_summary_line(md: &str) -> String {-    struct ParserWrapper<'a> {-        inner: Parser<'a>,-        is_in: isize,-        is_first: bool,+/// Renders the first paragraph of the provided markdown as plain text.+///+/// - Headings, links, and formatting are stripped.+/// - Inline code is rendered as-is, surrounded by backticks.+/// - HTML and code blocks are ignored.+pub fn plain_text_summary(md: &str) -> String {+    if md.is_empty() {+        return String::new();     } -    impl<'a> Iterator for ParserWrapper<'a> {-        type Item = String;--        fn next(&mut self) -> Option<String> {-            let next_event = self.inner.next()?;-            let (ret, is_in) = match next_event {-                Event::Start(Tag::Paragraph) => (None, 1),-                Event::Start(Tag::Heading(_)) => (None, 1),-                Event::Code(code) => (Some(format!("`{}`", code)), 0),-                Event::Text(ref s) if self.is_in > 0 => (Some(s.as_ref().to_owned()), 0),-                Event::End(Tag::Paragraph | Tag::Heading(_)) => (None, -1),-                _ => (None, 0),-            };-            if is_in > 0 || (is_in < 0 && self.is_in > 0) {-                self.is_in += is_in;-            }-            if ret.is_some() {-                self.is_first = false;-                ret-            } else {-                Some(String::new())+    let mut s = String::with_capacity(md.len() * 3 / 2);++    for event in Parser::new_ext(md, Options::ENABLE_STRIKETHROUGH) {+        match &event {+            Event::Text(text) => s.push_str(text),+            Event::Code(code) => {+                s.push('`');+                s.push_str(code);+                s.push('`');

Yep, this is intended. plain_text_summary is for non-HTML contexts, like the search index and tooltips. Part of the original bug here is that it was being used for trait impls, too.

I changed the name and added some docs to try and make that clearer.

euclio

comment created time in 2 months

PullRequestReviewEvent

delete branch euclio/rust-analyzer

delete branch : check-on-save-default

delete time in 2 months

pull request commentrust-lang/rust

rustdoc: do not use plain summary for trait impls

It's the same output with 4 and 5 spaces. I disagree that it's a bug, seems like expected behavior from the unindent-comments pass.

euclio

comment created time in 2 months

pull request commentrust-lang/rust

rustdoc: do not use plain summary for trait impls

My point is that

///    hello
pub struct Foo;

isn't rendered as a code block either.

euclio

comment created time in 2 months

pull request commentrust-lang/rust

rustdoc: do not use plain summary for trait impls

@GuillaumeGomez What's the expected behavior? unindent-comments trims the leading spaces so that

///    hello

is rendered as a paragraph, not a code block. There's nothing special about trait methods here.

euclio

comment created time in 2 months

more