profile
viewpoint
Eric Sauer etsauer Red Hat Raleigh, NC

etsauer/eap6_build_bash 2

Bash Script Automation for EAP6

etsauer/container-pipelines 1

Let's get the ball rolling on some Container-driven CI & CD

etsauer/Hygieia 1

CapitalOne DevOps Dashboard

etsauer/agnosticd 0

Ansible Deployer for multiple Cloud Deployers

etsauer/ansible-stacks 0

Ansible playbook and roles used to creates stacks via push button infrastructure (PBI)

etsauer/architect-enablement-ha-openshift 0

Architect Enablement for Consulting's HA/DR OpenShift story

etsauer/argocd-openshift 0

Example use cases for using ArgoCD to manage OpenShift clusters and Applications

etsauer/cakephp-ex 0

CakePHP Example

pull request commentopenshift/openshift-docs

[WIP] Adding more detail to load balancer setup documentation

@sttts I'm unclear on what the ask is in that comment, considering that the line about Round Robin load balancing was removed. Are you saying we need to add content covering the configuration of apiserver healthchecks via /readyz? If so, I'm ok taking a stab at that, but none of that is covered in the current documentation either.

etsauer

comment created time in 5 hours

pull request commentredhat-cop/container-pipelines

🌲 FIX - broken selector on service and updated nginx image 🌳

@springdo the problem with this is that nginx:1.14 doesn't seem to exist in 4.3, so this breaks in that case. I find it odd that from one version to the next, there is no overlap in the tags.

$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.3.18    True        False         56d     Cluster version is 4.3.18

$ oc get imagestream -n openshift nginx
NAME    IMAGE REPOSITORY                                                                   TAGS               UPDATED
nginx   default-route-openshift-image-registry.apps.d1.casl.rht-labs.com/openshift/nginx   1.10,1.12,latest   4 months ago
springdo

comment created time in 12 hours

PR opened redhat-cop/org

Onboard jonahkh to MDT team

@sabre1041 @oybed @pabrahamsson

+2 -0

0 comment

1 changed file

pr created time in a day

create barnchetsauer/org

branch : onboard-jonahkh

created branch time in a day

issue commentredhat-cop/pelorus

Write pelorus usage docs

This probably needs to be broken up into multiple items, but here are some of the questions we are being asked.

  • What exactly IS pelorus? What isn't it?
  • How do the exporters work? What do they collect, and how?
  • How does Pelorus measure activity going on in my feature branches, vs master branch, and how do I distinguish which ones should be "counted"?
etsauer

comment created time in a day

issue openedredhat-cop/pelorus

Combine 'deploy' and 'exporter' charts into a single pelorus chart that deploys the full stack.

I'm thinking the structure of a values file that looks something like:

---
global:
  deployment:
    labels:
      app.kubernetes.io/component: prometheus
      app.kubernetes.io/name: pelorus
      app.kubernetes.io/version: v0.33.0
  # custom_ca: true
  extra_prometheus_hosts:

exporters:
  comittime:
    app_name: deploytime-exporter
    # env_from_secrets:
    # - github-secret
    # extraEnv:
    # - name: APP_LABEL
    #   value: foo
    source_context_dir: exporters/committime
    source_ref: master
    source_url: https://github.com/redhat-cop/pelorus.git
    scrapeInterval: 5m
  deploytime:
    ...
  failure:

created time in a day

issue openedredhat-cop/pelorus

Define a framework for writing additional exporters and/or extending existing exporters.

In my mind, this includes two, potentially independent components:

  1. Defining/enforcing a standard for the metric formatting that comes out of a particular exporter.

This could be in the format of some sort of abstract class or interface that defines a standard set of attributes for each metric type, such as: commit_timestamp{app, exported_namespace, image_sha}

This would allow for other forms of committime exporters to be written defining processes outside of the OpenShift build system, and still allow all forms of committime metrics to be aggregated together.

  1. Defining some sort of architecture for each core exporter such that it can be easily extended to accommodate different backend systems, such as different git implementations.

created time in 2 days

issue openedredhat-cop/pelorus

Deployment Frequency panel doesn't actually do sums over time

I realized this too late to get it fixed for 1.2, but I noticed that, when you change the timescope of the SDP dashboard, the Deployment Frequency doesn't change. I played around with some queries, and realized its actually only showing the deployments that current exist in the cluster, not counting all the historical data that was gathered earlier.

This is what I believe the DF panel query should actually look like:

count( count_over_time(deploy_timestamp [2d]) )

created time in 6 days

push eventetsauer/uncontained.io

Eric Sauer

commit sha 8622a7043e0224d2e5d5b5fd1a48b22365eb43e5

Remove scl script

view details

push time in 6 days

push eventetsauer/uncontained.io

Eric Sauer

commit sha 26a5e1461dc71ca4d2b7c1d703f613d3dc7f6dd4

Change builder label

view details

push time in 6 days

push eventetsauer/uncontained.io

Eric Sauer

commit sha f90d8475213773a06f8e7b899765e401faabc717

Fix pipeline-library version

view details

push time in 6 days

PR opened redhat-cop/uncontained.io

[WIP] Clean out unused tech debt from pipeline code and migrate to OpenShift 4

What is this PR About?

Brief explanation of the guide or document changes you have made and/or the new content you are contributing.

How should we test or review this PR?

Include any information or commands (please use code blocks) to help reviewers understand and verify your contribution.

Is there a relevant Trello card or Github issue open for this?

Provide a link to any open Github issues or Trello cards that describe the use case or problem you are solving.

Who would you like to review this?

cc: @redhat-cop/cant-contain-this

'''''

  • [ ] Have you followed the contributing guidelines?
  • [ ] Have you explained what your changes do, and why they add value to the uncontained.io guides?

'''''

Please note: we may close your PR without comment if you do not check the boxes above and provide ALL requested information.

+9 -283

0 comment

4 changed files

pr created time in 6 days

create barnchetsauer/uncontained.io

branch : pipeline-cleanup-ocp4

created branch time in 6 days

push eventetsauer/container-pipelines

Eric Sauer

commit sha 7acaa563cd9730dc699d3c8ad0231f6a8a8f3e22

doing a change

view details

push time in 7 days

issue commentredhat-cop/pelorus

Support Bitbucket integration

Just to clarify... this should not be a net-new exporter. Instead this should be an enhancement to the existing committime exporter. If anyone is interested in picking this up, we should chat about what this looks like.

tdbeattie

comment created time in 7 days

created tagredhat-cop/pelorus

tagv1.2.0

Automate the measurement of organizational behavior

created time in 7 days

release redhat-cop/pelorus

v1.2.0

released time in 7 days

push eventetsauer/container-pipelines

Eric Sauer

commit sha 8463b271fe4ea9505d959651c7bfe26012b44631

doing a change

view details

push time in 7 days

push eventetsauer/container-pipelines

Eric Sauer

commit sha 7caad4ae5869513874f848ee7e4c2e9b42877830

doing a change

view details

push time in 7 days

issue openedredhat-cop/pelorus

Document assumptions of prior knowledge and understanding in order to be successful with Pelorus

For example:

  • Should understand OpenShift Builds and Pipelines.
  • Should be able to administer openshift clusters. etc.

created time in 7 days

PR closed redhat-cop/pelorus

initial commit
+0 -173

2 comments

3 changed files

joecharles33

pr closed time in 7 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha 08f89e2f3b17b70acf59871d0d2e9304e5d69e38

Ensure grafana mounts configmap properly

view details

push time in 8 days

push eventetsauer/container-pipelines

push time in 8 days

push eventredhat-cop/pelorus

Austin Dewey

commit sha 7ec28ca682521a8a258f84330fc104ada35d0352

adding ct lint action (#113)

view details

push time in 8 days

PR merged redhat-cop/pelorus

adding ct lint action

Closes #110

Adds a workflow for linting values.yaml and Chart.yaml styles and schema using ct. Templates are also checked for invalid YAML syntax. The workflow is in a separate yaml file but of course the existing pylama workflow can be combined with this one instead.

By default, ct will check that you have incremented any chart versions that you modified and will fail if the version isn't incremented. Is this ok? The version check is especially useful if you're releasing to a chart repo, but I don't think this is the case here. LMK if you want this off instead.

I had to make a couple changes to charts/exporter to allow a couple linter rules to pass. The good news is that any style rule currently in place can be overridden by lintconf.yaml or chart_schema.yaml if there's something being enforced you'd rather not be.

+91 -6

0 comment

6 changed files

deweya

pr closed time in 8 days

push eventredhat-cop/pelorus

kenwilli

commit sha dd0529e468e7dcda342ef31ecb2f64d39cc64220

adding demo folder and script (#82) * adding demo folder and script * Update Demo Instructions.md * added use of 2nd argument for source code url * Updated Prerequisites (Ansible and oc tools) * Update Demo.md * Added information regarding source_code_url flag * change redeploy command in script * uncomment custom ca cert * adding demo folder and script * Update Demo Instructions.md * adding dashboard photos * Updated Demo.md with screenshots and revisions * Commenting custom_ca in chart/deploy/values.yaml * Fixed example argument link * Removed Demo Execution Block * Created from removed block from Demo.md * Added image section back, edit first one out * Update Demo.md Add Demo Goal * Update Demo.md * Update README.md * modified script, added recursion element * Added prereq for pelorus to be up * Updated information * fixed script, added pushd/popd * Updating Goal Co-authored-by: Prakriti <prakritiverma@gmail.com>

view details

push time in 8 days

PR merged redhat-cop/pelorus

adding demo folder and script
+123 -0

2 comments

8 changed files

kenwilli

pr closed time in 8 days

issue closedredhat-cop/pelorus

Build a more consumable quickstart/demo that showcases the functionality of the dashboard

Readme with a walkthrough Sample app & automation

closed time in 8 days

etsauer

push eventetsauer/container-pipelines

Eric Sauer

commit sha 801f241b273215b3da9e3683b5d5e29bcf43f390

doing a change

view details

push time in 8 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha 0755b742ffab846e6dc22f096d2489a21c545285

Fix pylama issue

view details

push time in 8 days

PR opened redhat-cop/pelorus

Add production label to deploytime metric

This PR add the ability for an admin to set a label, such as env=production as the search criteria for namespaces in scope for tracking deployment metrics.

To Test:

  1. Spin up deploytime exporter locally. Behavior should be same as before.
  2. Set PROD_LABEL="env=production" and spin up exporter again. Initially you should see no metrics captured.
  3. Label a relevant namespace like oc label ns/basic-nginx-prod env=production, and then curl localhost:8080 to trigger again, and you should see metrics from that namespace.
+7 -1

0 comment

3 changed files

pr created time in 8 days

create barnchetsauer/mdt-quickstart

branch : production-label

created branch time in 8 days

push eventetsauer/container-pipelines

Eric Sauer

commit sha ab4e0ac887b119ba95c3370311b857e9ce507919

doing a change

view details

push time in 8 days

Pull request review commentredhat-cop/pelorus

adding demo folder and script

+#!/bin/bash+#Test oc tool+#Assumes User is logged in to cluster++path=$1+url=$2++# Will create spring rest deployment+cd $path/basic-nginx

this needs to change to another pushd... popd. otherwise this will break the commit logic below.

kenwilli

comment created time in 8 days

push eventetsauer/container-pipelines

Eric Sauer

commit sha 9ecffb194e822d74575e299ff1f854c04e3518d0

doing a change

view details

push time in 8 days

push eventetsauer/container-pipelines

Eric Sauer

commit sha 63223422a525b0e9fd3f1d0a3dd270984e9b0125

doing a change

view details

push time in 9 days

push eventetsauer/container-pipelines

push time in 9 days

Pull request review commentredhat-cop/pelorus

adding demo folder and script

+#!/bin/bash+#Test oc tool+#Assumes User is logged in to cluster++path=$1+url=$2++# Will create spring rest deployment+cd $path/basic-nginx+ansible-galaxy install -r requirements.yml --roles-path=galaxy+ansible-playbook -i ./.applier/ galaxy/openshift-applier/playbooks/openshift-cluster-seed.yml -e skip_manual_promotion=true -e source_code_url=$url+++# Wait a bit (5 min) for the app to be finished deployed+sleep 300++#Add Comment to a file to replicate a "change"+echo "this is a comment" >> $path/basic-nginx/index.html++#Change git dir to the one we're changing+export GIT_DIR=$path/.git+export GIT_WORK_TREE=$path++# git commit+git add .+git commit -m "doing a change"+git push origin master

When I run this, I get an error message:

demo/demo.sh: line 18: ../container-pipelines//basic-nginx/index.html: No such file or directory
fatal: not a git repository: '../container-pipelines//.git'
fatal: not a git repository: '../container-pipelines//.git'
fatal: not a git repository: '../container-pipelines//.git'
build.build.openshift.io/basic-nginx-pipeline-4 started

It looks like you're not actually doing anything with the path var to change directories. I would add some handling of this like:

pop $path
  git add .
  git commit  -m "doing a change"
  git push origin master
popd
kenwilli

comment created time in 9 days

Pull request review commentredhat-cop/pelorus

adding demo folder and script

+# Pelorus Demo++## Demo Assumptions+- Github SSH key is setup on the machine where the demo will run.+- Ansible is installed+- oc command line tools installed+- Logged into OCP Cluster++## Demo Purpose+- Deploy sample application (basic-nginx)+- Make changes to the application (adding a line to index.html)+- commit changes to source control+- redeploy application with the changes to be captured by pelorus++## Demo Prerequisites++Clone the [pelorus repo](https://github.com/redhat-cop/pelorus).++Fork the [RedHat COP Container Pipeline Repo](https://github.com/redhat-cop/container-pipelines), then clone (using ssh).++The location of the repo will be passed as an argument to the pelorus demo script (i.e. /home/<user>/projects/container-pipelines).++The second argument the script takes is the url of the forked repo, so for example ,"https://github.com/kenwilli/pelorus".++## Demo Execution++Note: If exporters are not functioning or deployed, no data will show up in the dashboard. It will look like the following:+![No-Data](../media/pelorus-dashboard-no-data.png)++An "idle" state could resemble:+![Idle-Data](../media/pelorus-dashboard-idle-data.png)++Run the demo script+``` pelorus/demo/demo.sh <path to container-pipelines> <url to forked repo>```++Once the script has completed the openshift applier segment, it will pause for 5 minutes in order for jenkins to get setup and basic-nginx to run through it's first pipeline build. Once the pipeline has completed the dashboard will update accordingly:+![First-Deploy-Data](../media/pelorus-dashboard-first-deploy.png)++Once the 5 minute rest period is up, a simple change will be committed and pushed back to the forked repo. Then the second pipeline build of basic-nginx will start. Once complete, the dashboard will update again:

From the first deploy to the second deploy, we should see the Lead Time for Change decrease (negative number and green background) and the deployment frequency increase. We should show some screenshots that show the desired states.

kenwilli

comment created time in 9 days

Pull request review commentredhat-cop/pelorus

adding demo folder and script

+# Pelorus Demo++## Demo Assumptions+- Github SSH key is setup on the machine where the demo will run.+- Ansible is installed+- oc command line tools installed+- Logged into OCP Cluster++## Demo Purpose+- Deploy sample application (basic-nginx)+- Make changes to the application (adding a line to index.html)+- commit changes to source control+- redeploy application with the changes to be captured by pelorus++## Demo Prerequisites++Clone the [pelorus repo](https://github.com/redhat-cop/pelorus).++Fork the [RedHat COP Container Pipeline Repo](https://github.com/redhat-cop/container-pipelines), then clone (using ssh).++The location of the repo will be passed as an argument to the pelorus demo script (i.e. /home/<user>/projects/container-pipelines).++The second argument the script takes is the url of the forked repo, so for example ,"https://github.com/kenwilli/pelorus".++## Demo Execution++Note: If exporters are not functioning or deployed, no data will show up in the dashboard. It will look like the following:+![No-Data](../media/pelorus-dashboard-no-data.png)++An "idle" state could resemble:+![Idle-Data](../media/pelorus-dashboard-idle-data.png)++Run the demo script+``` pelorus/demo/demo.sh <path to container-pipelines> <url to forked repo>```

Change this to a code block so that it shows up on its own line.

kenwilli

comment created time in 9 days

Pull request review commentredhat-cop/pelorus

adding demo folder and script

+# Pelorus Demo++## Demo Assumptions+- Github SSH key is setup on the machine where the demo will run.+- Ansible is installed+- oc command line tools installed+- Logged into OCP Cluster++## Demo Purpose+- Deploy sample application (basic-nginx)+- Make changes to the application (adding a line to index.html)+- commit changes to source control+- redeploy application with the changes to be captured by pelorus++## Demo Prerequisites++Clone the [pelorus repo](https://github.com/redhat-cop/pelorus).++Fork the [RedHat COP Container Pipeline Repo](https://github.com/redhat-cop/container-pipelines), then clone (using ssh).++The location of the repo will be passed as an argument to the pelorus demo script (i.e. /home/<user>/projects/container-pipelines).++The second argument the script takes is the url of the forked repo, so for example ,"https://github.com/kenwilli/pelorus".++## Demo Execution++Note: If exporters are not functioning or deployed, no data will show up in the dashboard. It will look like the following:

I don't think we need this in the flow of the Demo. This would be good for a troubleshooting guide.

kenwilli

comment created time in 9 days

Pull request review commentredhat-cop/pelorus

adding demo folder and script

+#!/bin/bash+#Test oc tool+#Assumes User is logged in to cluster++path=$1+url=$2++# Will create spring rest deployment+cd $path/basic-nginx+ansible-galaxy install -r requirements.yml --roles-path=galaxy+ansible-playbook -i ./.applier/ galaxy/openshift-applier/playbooks/openshift-cluster-seed.yml -e skip_manual_promotion=true -e source_code_url=$url+++# Wait a bit (5 min) for the app to be finished deployed+sleep 300

Instead of silently waiting for 5 minutes, let's have it wait for the user to "continue" by pressing Enter.

kenwilli

comment created time in 9 days

Pull request review commentredhat-cop/pelorus

adding demo folder and script

+# Pelorus Demo++## Demo Assumptions+- Github SSH key is setup on the machine where the demo will run.+- Ansible is installed+- oc command line tools installed+- Logged into OCP Cluster++## Demo Purpose+- Deploy sample application (basic-nginx)+- Make changes to the application (adding a line to index.html)+- commit changes to source control+- redeploy application with the changes to be captured by pelorus++## Demo Prerequisites++Clone the [pelorus repo](https://github.com/redhat-cop/pelorus).++Fork the [RedHat COP Container Pipeline Repo](https://github.com/redhat-cop/container-pipelines), then clone (using ssh).++The location of the repo will be passed as an argument to the pelorus demo script (i.e. /home/<user>/projects/container-pipelines).++The second argument the script takes is the url of the forked repo, so for example ,"https://github.com/kenwilli/pelorus".

"https://github.com/kenwilli/container-pipelines.git"

kenwilli

comment created time in 9 days

push eventetsauer/container-pipelines

Eric Sauer

commit sha c3266c8a15c2530dc6ceb62e54f01ad8743c6c01

Temporary commit

view details

push time in 9 days

push eventetsauer/container-pipelines

Eric Sauer

commit sha 429e48aa90d9d62125322424e2fd8875106e2a20

Temporary commit

view details

push time in 9 days

push eventetsauer/container-pipelines

Petter Abrahamsson

commit sha 38e26d352e9517aed682dc49e687b2e6b671625e

Use OpenShift Applier

view details

Petter Abrahamsson

commit sha a8082f0c4d7fedf18c17f974e27ecab1d4e44e0e

Add python example w/ python-slave builder + coverage plugin

view details

Petter Abrahamsson

commit sha 449d2f984a616beb312e4eba6921b53bf3d660e5

Add jenkins slave-python & sonarqube

view details

Petter Abrahamsson

commit sha 24dd3fe7c54cb2a9de46edd5d196d3b3c2ab8ade

Add NodeJS Express REST application pipeline

view details

Petter Abrahamsson

commit sha 5a91043a4998c45ff0e2f62deb563a47b3d7011a

Merge pull request #1 from pabrahamsson/python-flask-rest Add python Flask example w/ jenkins-slave builder + sonarqube

view details

Petter Abrahamsson

commit sha 8a3a0826d78837559870dcce1afc39833840bb24

Merge pull request #2 from pabrahamsson/nodejs-express-rest Add NodeJS Express REST application pipeline

view details

Petter Abrahamsson

commit sha ce5727feefe3f3dfecdd8c11e813a8b8ae507984

Merge remote-tracking branch 'upstream/master'

view details

Petter Abrahamsson

commit sha 62ee3ba3f56ca38f9bc7bdab98d8be12ec642665

Merge remote-tracking branch 'upstream/master'

view details

Petter Abrahamsson

commit sha a25131460267650179e9a960a0477b29b9b99829

Merge remote-tracking branch 'upstream/master'

view details

Petter Abrahamsson

commit sha d46aed7407a6835b5be13ec79eecbbbbafa55c67

Merge remote-tracking branch 'upstream/master'

view details

Eric Sauer

commit sha bdea401f0b6d7cb00edf14bbfdf8471a23f3b72e

Updating blue green pipeline with applier v2.0.3 (#42) * Updating blue green pipeline with applier v2.0.3 * Adjust scm step in Jenkinsfile * Remove git describe * Fixing environment search & replace * Fixing pipeline * Fixing project display names so they group together * Pointing to primary repository instead of fork * Adding removal of slash from namespace

view details

Eric Sauer

commit sha 44691f943cf72454dcc103243eaefac3db5e9b39

Updating Tomcat pipeline to v2.0.3 applier conventions (#41) * Updating Tomcat pipeline to v2.0.3 applier conventions * Fixing file path in README * Fixing up jenkinsfile to support separation from source code * More jenkinsfile fixes * Adding support for passing branch * remove mvn complexity * Trying to fix image build logic * parameterizing jenkinsfile * more jenkinsfile fixes * more jenkinsfile fixes * more jenkinsfile fixes * Final template mods * Adding println of app name in Jenkinsfile * Adding println of app name in Jenkinsfile * Fixing app_name extraction logicJenkinsfile * Fixing route so that it is clickable and works; update sample app reference in README

view details

Petter Abrahamsson

commit sha ad3261591a8d02223554e25b41552142e2fe2dea

Add promt for promotion to prod, fixes #37

view details

Eric Sauer

commit sha 8b82dfbdf1b20c0ea0290abf924bbd28ca67408a

Merge pull request #44 from pabrahamsson/issue-37 Add promt for promotion to prod, fixes #37

view details

Petter Abrahamsson

commit sha 76bbb2b791eb273a7cb08b097e38432d6cb9953d

Use pipeline-library for basic-spring-boot app, fixes #32

view details

Petter Abrahamsson

commit sha 981a91555888546618ae5ffd5c3c4a2232622d3c

Remove WIP stuff

view details

Petter Abrahamsson

commit sha 5812f2f792b794ae5af5b0c5341b21df77ae95cb

Fix merge conflict

view details

Petter Abrahamsson

commit sha 577f7c3ee8eb980fde2338278a4af0f68b5232a3

Move off nodejs & python pipelines

view details

Petter Abrahamsson

commit sha 0251a158036b1aeed12e3571d37893d21e88b60b

Merge remote-tracking branch 'upstream/master'

view details

miguel

commit sha f524bb308f80760e98948c55db8e509ecc4cd047

updated versions to 2.0.4

view details

push time in 9 days

Pull request review commentredhat-cop/redhat-cop.github.io

Added CI resource management document

 title: How to implement continuous integration for redhat-cop repos This section talks through various continuous integration strategies we employ across the repositories in this organization.  * [Publishing Container Images to Quay.io](./publishing-images.html)+* [Resource Management](./resource-management.md)

Can we come up with something more descriptive than "resource management"? Something like "requesting repository provisioning and access". Otherwise I don't think many people will click on it.

sabre1041

comment created time in 10 days

pull request commentredhat-cop/pelorus

initial commit

Hi @joecharles33 not sure what this PR was supposed to be for, but it looks like you're just deleting files in the repo.

joecharles33

comment created time in 10 days

Pull request review commentredhat-cop/pelorus

adding ct lint action

 name: exporter-version: v0.0.1+version: v0.0.2

I would update the version to v.1.1.0 to match the current repo version.

deweya

comment created time in 10 days

PR opened redhat-cop/pelorus

Resolve several outstanding issues with thanos component

This PR does the following

  • adds support for custom CAs in the thanos component (we missed this when we resolved #91 )
  • resolves #105

To test:

  1. Deploy pelorus with and without thanos. Make sure that the dashboard is working.
  2. Configure a custom wildcard cert, and ensure you can still log into thanos.
+17 -0

0 comment

2 changed files

pr created time in 12 days

create barnchetsauer/mdt-quickstart

branch : thanos-label-fix

created branch time in 12 days

issue commentredhat-cop/redhat-cop.github.io

Document the process for creating new Quay.io repositories

We should also put something in the org repo readme that explains what types of things are managed in the repo.

etsauer

comment created time in 12 days

issue openedredhat-cop/redhat-cop.github.io

Document the process for creating new Quay.io repositories

Now that we have automation in the org repo, we should have a document that covers that process.

created time in 12 days

issue closedredhat-cop/pelorus

Error: failed to start container

Running in a disconnected install, changed all image refrances to pull form local quay. look like everting deploys corerctly but have this error for prometheus-prometheus-pelorus-0 prometheus-prometheus-pelorus-1 Error: failed to start container "prometheus-config-reloader": Error response from daemon: oci runtime error: container_linux.go:235: starting container process caused "exec: "/bin/prometheus-config-reloader": stat /bin/prometheus-config-reloader: no such file or directory"

quaylocal.local/coreos/prometheus-config-reloader:v0.33.0" already present on machine

3.11.153 cluster

closed time in 14 days

jon2100

issue commentredhat-cop/pelorus

Error: failed to start container

Closing based on our side conversation @jon2100

jon2100

comment created time in 14 days

issue openedredhat-cop/pelorus

When thanos is in place, some dashboard panels throw errors

thanos-query

When we put thanos in place, it collects the same metrics from both prometheus pods. Thus each metric gets collected twice. As a result some of our dashboard queries break because they receive duplicate results.

created time in 14 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha 0e2621a06123269b98527e8676f9903f45c9c183

Skip images that don't have a SHA256

view details

push time in 14 days

Pull request review commentopenshift/openshift-docs

Adding more detail to load balancer setup documentation

 balancer after the bootstrap machine initializes the cluster control plane. | |Machine Config server +|===+++2. *Application Ingress Load Balancer*: Provides an ingress point for application traffic flowing in from outside of the cluster.+  * Layer 4 load balancing only (this is sometimes referred to as Raw TCP, SSL Passthrough, or SSL Bridge mode)+  * Round robin load balancing

@lihongan @vikram-redhat I'm not clear on what you are asking me to change here. Do you want me to just remove the round robin line since it doesn't apply across the board?

etsauer

comment created time in 14 days

PR opened redhat-cop/pelorus

Fix issue with unresolved image reference

Found an issue where ReplicationControllers that contain unresolved image references are missing a SHA256 component in the URL cause a NoneType exception that crashes the exporter. This PR handles that exception.

+6 -1

0 comment

1 changed file

pr created time in 14 days

create barnchetsauer/mdt-quickstart

branch : deploytime-fix

created branch time in 14 days

issue commentredhat-cop/pelorus

Need to implement a unit testing framework for exporter code

Coverage.py looks interesting for this:

https://coverage.readthedocs.io/en/coverage-5.1/

etsauer

comment created time in 14 days

issue commentredhat-cop/pelorus

Error: failed to start container

@jon2100 sorry for the long lead time on this, we didn't see your issue come in.

That's a strange error, as we don't do anything special with that container image. Have you tried standing up a vanilla prometheus stack using the prometheus operator?

jon2100

comment created time in 14 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha 85f998a28fbadca0e9038ca9c94cbb94ed967aac

Fix arg in docs

view details

push time in 14 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha 440d860558ded912895d60338fd982471219cf1a

Fix configmap volume mounts and file paths

view details

push time in 14 days

push eventredhat-cop/pelorus

Karl Moos

commit sha 07a6d8dedd6d8c6e09de9ac90aa6e839585adee9

Add Pylama status badge (#103)

view details

push time in 15 days

PR merged redhat-cop/pelorus

Add Pylama status badge

Add the Pylama pass/failure badge.

Selection_305

+2 -0

0 comment

1 changed file

themoosman

pr closed time in 15 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha 943b0048668157f1f384504df82dcf54835c5005

Fix ca configmap

view details

push time in 15 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha e18b956c62194164fdb5480442adc00b854a2ecd

Add documentation

view details

push time in 15 days

PR opened redhat-cop/pelorus

WIP: Support custom ca

This PR supports configuring Pelorus to use a custom CA.

This can be tested on a cluster with a privately signed wildcard certificate by setting custom_ca: true in the values.yaml for the deploy chart. (see commented out value).

Docs coming soon, this the "Work In Progress" designation.

+57 -30

0 comment

4 changed files

pr created time in 15 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha d0df77f6d88894d6cc8e71bd18016e6a16cc213b

Making custom ca support conditional

view details

push time in 15 days

create barnchetsauer/mdt-quickstart

branch : support-custom-ca

created branch time in 15 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha 3e248a29a473bc7d6e0e6b365414b3b747321f60

Clean up one reference to lib_pelorus

view details

push time in 16 days

push eventetsauer/openshift-applier

Eric Sauer

commit sha e33f50ce6608538129751f798eddd9223f6a96ae

Readme updates per tylerauerbeck

view details

push time in 19 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha 65dd306273dbab4799fb3ea7ac6181195d88fa67

Change lib_pelorus.loader to simply pelorus

view details

push time in 20 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha ea933fe077058a8f666d36f77578a4e7f2987035

Refactor main committime method to reduce complexity (#98)

view details

Eric Sauer

commit sha 36a2eeb2ca2424298f20329affea34347d434656

Address issue #95, and make APP_LABEL more configurable

view details

Eric Sauer

commit sha cc11d163b9e28aa253b21f452f24eb21f5573ed8

Update values file for other exporters

view details

Eric Sauer

commit sha 6372e140a4b614465e2622c2751913d190aead93

Exit app if required env vars aren't set

view details

Eric Sauer

commit sha 88d7483e56c5cd787a9f8543e551e16d9560f13c

Resolve pylama issues

view details

push time in 20 days

issue closedredhat-cop/pelorus

Committime exporter failing to return any data because of one build.

I have the committime exporter deployed in a cluster, returning the following error in the logs:

INFO:root:Namespace: kenwilli-basic-spring-boot-build, App: kenwilli-basic-spring-boot-ea67853d8f9b4f43400500f807d72cdfb5b0936d, Build: kenwilli-basic-spring-boot-3
Traceback (most recent call last):
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/wsgiref/handlers.py", line 137, in run
    self.result = application(self.environ, self.start_response)
  File "/opt/app-root/lib/python3.6/site-packages/prometheus_client/exposition.py", line 52, in prometheus_app
    status, header, output = _bake_output(registry, accept_header, params)
  File "/opt/app-root/lib/python3.6/site-packages/prometheus_client/exposition.py", line 40, in _bake_output
    output = encoder(registry)
  File "/opt/app-root/lib/python3.6/site-packages/prometheus_client/openmetrics/exposition.py", line 56, in generate_latest
    floatToGoString(s.value),
  File "/opt/app-root/lib/python3.6/site-packages/prometheus_client/utils.py", line 9, in floatToGoString
    d = float(d)
TypeError: ("float() argument must be a string or a number, not 'NoneType'", Metric(github_commit_timestamp, Commit timestamp, gauge, , [Sample(name='github_commit_timestamp', labels={'namespace': 'basic-nginx-build', 'app': 'basic-nginx-d5959a2450fa575f95e27a77951ee296319ecfae', 'image_sha': 'sha256:b662b493c37a2f0810e6c96268a46bda0364bb5e93f0d7c672ea8fd20966da2e'}, value=1591804346.0, timestamp=None, exemplar=None), Sample(name='github_commit_timestamp', labels={'namespace': 'basic-nginx-build', 'app': 'basic-nginx-d5959a2450fa575f95e27a77951ee296319ecfae', 'image_sha': 'sha256:5818ec7641d40144628c2537914d2874167c6edf64cfefa8bda89f8b525a36b6'}, value=1591804346.0, timestamp=None, exemplar=None), Sample(name='github_commit_timestamp', labels={'namespace': 'basic-nginx-build', 'app': 'basic-nginx-d5959a2450fa575f95e27a77951ee296319ecfae', 'image_sha': 'sha256:2e7efc7c011eef8795f2d73fe37b0ce71198aeb62eca97de49dd2379d8855885'}, value=1591804346.0, timestamp=None, exemplar=None), Sample(name='github_commit_timestamp', labels={'namespace': 'basic-nginx-build', 'app': 'basic-nginx-d5959a2450fa575f95e27a77951ee296319ecfae', 'image_sha': 'sha256:2f934e61518d81b9decd423ec8ea88f06e379281df860d120f564721328b7ae3'}, value=1591804346.0, timestamp=None, exemplar=None), Sample(name='github_commit_timestamp', labels={'namespace': 'basic-nginx-build', 'app': 'basic-nginx-d5959a2450fa575f95e27a77951ee296319ecfae', 'image_sha': 'sha256:fbcb7bd0acf00c0f012b09e7fbab09c445e3ff71ca96e5bf2625970751029777'}, value=1591804346.0, timestamp=None, exemplar=None), Sample(name='github_commit_timestamp', labels={'namespace': 'kenwilli-basic-spring-boot-build', 'app': 'kenwilli-basic-spring-boot-ea67853d8f9b4f43400500f807d72cdfb5b0936d', 'image_sha': 'sha256:46332b417660900361f7185830a4eb6d5ddc7e3002944ba26ed260e83f415197'}, value=None, timestamp=None, exemplar=None)]))

Because it this one error, the exporter won't return ANY data. If you hit the endpoint for the exporter, it simply returns:

$ curl http://committime-exporter-pelorus-etsauer.apps.cluster-eric.blue.osp.opentlc.com/
A server error occurred.  Please contact the administrator.

We need to do the following:

  1. Figure out why this build is triggering NoneType error (it shouldn't be)
  2. Find a way to ensure this type of error can be handled in the future, and just skip the broken build instead of failing to return data.

closed time in 20 days

etsauer

pull request commentredhat-cop/pelorus

adding demo folder and script

resolves #56

kenwilli

comment created time in 20 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha db3b25ab805f714fc0a68e5e6efacdadea4bf4bd

Exit app if required env vars aren't set

view details

push time in 20 days

PR opened redhat-cop/pelorus

Change default app label to `app.kubernetes.io/name` and make it configurable

This PR includes the following changes:

  • Update exporter code to use app.kubernetes.io/name as the default app label
  • Move some default values to constants
  • Update exporter helm chart to support an extraEnv variable, allowing user to set environment variables.

@redhat-cop/mdt

+32 -12

0 comment

7 changed files

pr created time in 20 days

create barnchetsauer/mdt-quickstart

branch : change-default-app-label

created branch time in 20 days

pull request commentredhat-cop/container-pipelines

Adopt standardized app labels for the basic-nginx app

related to #121

etsauer

comment created time in 21 days

PR opened redhat-cop/container-pipelines

Adopt standardized app labels for the basic-nginx app

What does this PR do?

Apply the standard app labels to the basic-nginx pipeline.

How should this be tested?

Follow basic-nginx/README.md. Check the builds and deployments to see that the new labels are applied.

Is there a relevant Issue open for this?

n/a

Who would you like to review this?

cc: @redhat-cop/containers-approvers

+46 -10

0 comment

2 changed files

pr created time in 21 days

create barnchetsauer/container-pipelines

branch : basic-nginx-labels

created branch time in 21 days

pull request commentredhat-cop/pelorus

Refactor main committime method to reduce complexity

To test:

  1. Log in to openshift (with build data present)
  2. Start exporter. python exporters/committime/app.py
  3. Once started, run the following and confirm you get results back: curl localhost:8080 | grep 'commit_timestamp{.*} \d\.\d+e\+\d\d'
etsauer

comment created time in 21 days

PR opened redhat-cop/pelorus

Refactor main committime method to reduce complexity

This should resolve the final linting error as well.

@redhat-cop/mdt

+70 -60

0 comment

2 changed files

pr created time in 22 days

create barnchetsauer/mdt-quickstart

branch : refactor-committime

created branch time in 22 days

push eventetsauer/mdt-quickstart

Eric Sauer

commit sha ea0fde3538580c5aa3b7ae5e2b35ca96e9411da5

Fix an E124

view details

push time in 22 days

issue openedredhat-cop/pelorus

Need a cleaner uninstall process.

This is more of a development problem, where we are testing multiple instances of Pelorus in a single cluster. When we follow the documented uninstall process:

helm template --namespace pelorus pelorus ./charts/deploy/ | oc delete -f- -n pelorus

We end up deleting the operator CRDs, which may still be in use by other instances of pelorus, or other non-pelorus instances of prometheus or grafana. We need a safer way to uninstall the stack, without leaving a bunch of cluster-level rbac resource behind.

created time in 22 days

push eventredhat-cop/pelorus

Karl Moos

commit sha 7e17fc895906aa943a9fed6b2a23620b4e6a4e8b

Fix for issue #89 (#94)

view details

push time in 22 days

PR merged redhat-cop/pelorus

Fix for issue #89

If bucket_access_point isn't specified, then Pelorus defaults to no LTS and uses the legacy Prometheus service endpoint.

resolves: #89

+4 -0

0 comment

1 changed file

themoosman

pr closed time in 22 days

issue closedredhat-cop/pelorus

Pelorus Grafana dashboard does not work if long term storage isn't used

Running pelorus without long term storage breaks Grafana. This is because when long term storage isn't run, the service https://thanos-pelorus.pelorus.svc:9092 isn't created. However, the Grafana dashboard still points to that service.

closed time in 22 days

themoosman

PR opened redhat-cop/pelorus

Fix issue 88; resolve linting errors in exporters

@redhat-cop/mdt

+96 -67

0 comment

4 changed files

pr created time in 22 days

create barnchetsauer/mdt-quickstart

branch : fix-88

created branch time in 22 days

issue commentredhat-cop/pelorus

Modify Deploytime exporter to use Kubernetes standard app label

Document how to set environment variables through helm.

themoosman

comment created time in 22 days

more