profile
viewpoint
Eric Samelson esamelson @expo CA, USA

unimodules/react-native-unimodules 434

Core Unimodule infrastructure and a collection of Unimodules and interfaces that are commonly depended on by other Unimodules

esamelson/electron 1

Build cross platform desktop apps with JavaScript, HTML, and CSS

esamelson/tippecanoe 1

Build vector tilesets from large collections of GeoJSON features.

expo/sharp 0

High performance Node.js image processing, the fastest module to resize JPEG, PNG, WebP and TIFF images. Uses the libvips library.

issue commentexpo/expo

[expo-av][android] cannot read assets embedded by packager in apk `res` directory

Hey @jonathanstiansen -- I've just published expo-av@8.3.0 (tagged as next on NPM) with this commit included. Apologies it took so long; generally updates to individual packages between SDK releases are haphazard, though we'd like to publish more frequently! For now, you can check the package CHANGELOG to determine how recently it's been published.

jonathanstiansen

comment created time in 9 hours

push eventexpo/expo

Eric Samelson

commit sha 62aa41504c39c964c3ba0fdffc82b69f1676e047

Publish expo-av expo-av@8.3.0

view details

push time in 9 hours

PR opened expo/expo-cli

Reviewers
[xdl] add sdkVersion to Start Project and Serve Manifest events

Following up on some internal discussions, we'd like to start tracking the SDK version of projects that send Start Project and Serve Manifest events to segment so that we can get an idea of the distribution of development usage across supported SDK versions over time.

I added sdkVersion as an extra property when these two events are logged. Ran a project without any issues. @tcdavis does sdkVersion need to be added to a table somewhere in our analytics, or will it start being saved automatically?

Did not make a changelog entry as this is not a user-facing change (but let me know if I should anyway).

+3 -1

0 comment

1 changed file

pr created time in 16 hours

create barnchexpo/expo-cli

branch : @eric/analytics-sdk-version

created branch time in 16 hours

issue commentexpo/expo

If the app was closed, event listeners added using Notifications.addListener not called in standalone iOS app

Hi everyone, the original issue from this thread was fixed last year when the issue was closed. If you are seeing similar issues with different symptoms, this thread is not a good place to report a problem or get help. Please open a new issue and fill out the template fully, including clear and easy steps we can follow to reproduce your case. Thank you!

hesyifei

comment created time in 5 days

push eventexpo/expo

Eric Samelson

commit sha e86f37feb40b9b1a46ffaa0c622ec9fc5ead4d4a

[expo-updates] add iOS example app in order to add tests

view details

Eric Samelson

commit sha df318aad9a12d42ec1a6c17a924260b8ac273af8

[expo-updates][ios] add a basic unit test and add dependency injection into a few Utils methods

view details

push time in 7 days

push eventexpo/expo

Eric Samelson

commit sha 0b6d058f0ba43c07800d9f1f1785ea0a98328412

add EXUpdates example app

view details

Eric Samelson

commit sha a709dfc65a1f0c95028ff95a0698eaa9708fc4c2

move existing logic and tests into new lib

view details

Eric Samelson

commit sha e424bf459e809c6f8b869f1651a9b9e11799b4d9

use existing podspec

view details

Eric Samelson

commit sha 3668a6e2ce04a1dbc9e9507fffa32692bd55f37b

mv EXUpdates ios

view details

Eric Samelson

commit sha 2138ddea3f46feb86bf63d4f40b4d04e3e0ad465

remove unnecessary extra files from lib template

view details

Eric Samelson

commit sha de34afe7153825beda45ee32852b845f844ae1f8

[ios] delete tests added in 0c2a264c871f5dc45084b5b4e11ff65c4ca545f7

view details

Eric Samelson

commit sha d4edaa6b5c29d6e6ddb86054b391c19884be9df4

fix copyright message

view details

push time in 7 days

push eventexpo/expo

Tomasz Sapeta

commit sha 15d3de4d782d09ebebbcacdc464e5c72423f3b92

[et] Introduce incremental check-packages command (#8947) # Why Makes `et check-packages` process faster. # How - Made `check-packages` work in *incremental* mode. It means that by default it checks only those packages that have been changed since merge base commit with master or any other base ref. - Updated GitHub Actions configuration so that the base branch name is passed to the command. That being said, it's compared to the most recent commit on the branch that you want to merge your PR into. In terms of push events on master branch, only packages that have changed since previous remote head will be checked. It may cause that previously occurring errors won't appear in subsequent checks, so I added scheduled weekdays event that will check all packages. - I had to make `action/checkout` go deeper and fetch 100 commits instead of one and also fetch 100 commits on the base branch to increase the chance that we find a merge base. If we won't find a merge base, then all packages will be checked. - Did some cleanups in that command to make it more clear and prepare for some other changes that I'm going to apply in expotools 🙊 # Test Plan I added a change in `expo-gl` in between some commits of this PR (it's removed now) and the only package that has been checked was `expo-gl` and the entire process took ~5 minutes instead of ~25 🎉

view details

Eric Samelson

commit sha 9ce589594ce7f219907ba85e2998f96e302e2198

[templates][bare] fix expo-updates installation compatibility with Flipper on Android

view details

Eric Samelson

commit sha a40a5a72394c75944b5efb0c3934bf46c6e54d93

[expo-updates] clarify installation instructions for RN 0.62 with Flipper initialization

view details

Tomasz Sapeta

commit sha 34c43bf693ab953c8e94b2496d6b99ded44343f8

Fix check-packages on push events

view details

Tomasz Sapeta

commit sha e2917f45836e947df4cfd86b726293fd3504077c

[fastlane] Build iOS simulator only for x86_64 arch (#8991) # Why When I was debugging occasional fails in `client-ios` workflow, I noticed that we build iOS simulator for both i386 and x86_64 architectures, while only the latter one is being released. This also makes the workflow faster as it no longer needs to compile things twice. # How Removed i386 from xcbuild parameters. # Test Plan CI job passes and is 15 minutes faster 🎉

view details

Filiph Sandström

commit sha f7fec16fb54565c622ddddc90ab865ae6527a7b4

Fix grammatical mistake (#7741)

view details

Nick Novitski

commit sha d91380e2f6ae697102b7e0a279b06507c82a411c

[ci] Update slack fields (#8952) - Remove "commit" ("message" has the same link) - Replace "action" with "job" (action is not a field) - Add "ref" for actions which notify on branches besides master

view details

Guillaume "B.B." Van Hemmen

commit sha 487a68ed8f82618138907199162c12aeb4d26c05

[unimodules] Remove andExperience:nil from the README (#9002) removed andExperience:nil from code snippet to align # Why It seems that the readme document is not fully aligned (following https://github.com/unimodules/react-native-unimodules/issues/38) # How Just removed `andExperience:nil` from the code snippet as well. # Test Plan N/A

view details

Bartłomiej Bukowski

commit sha 0cda53af2eb9aa6e857ab6b19cfdaa2e3fb0478d

[tools] Fix ERR_HTTP_INVALID_HEADER_VALUE being thrown (#8984)

view details

Eric Samelson

commit sha 72adc0206fea64049fbbf6e30d38bb89ae606f25

[expo-updates] fix missing config var in expo-updates.gradle for publish workflow

view details

Eric Samelson

commit sha f3e910075dfeedb2d1ecb063b406227372da33a8

Publish expo-updates expo-updates@0.2.11

view details

Eric Samelson

commit sha 9b8c033552aea991c9e96315cb4c794383e738c0

[expoview] add expo-updates as a dependency

view details

Eric Samelson

commit sha 0ce6924d58376b7871c8f5e57a800d6f922b6b82

[expo-updates][android] add a few basic unit tests

view details

Eric Samelson

commit sha b24800f8c6d15b9552c3532fb8b0316e0223f199

[ios] add expo-updates as a pod dependency

view details

Eric Samelson

commit sha 0c2a264c871f5dc45084b5b4e11ff65c4ca545f7

[expo-updates][ios] add a basic unit test and add dependency injection into a few Utils methods

view details

push time in 9 days

pull request commentexpo/expo

Add check for bundleIn${targetName}

@sunny-lirr - thanks for the heads up, breaking the old publish workflow was not intentional. I've just released expo-updates@0.2.11 which should fix this issue. However, please note that support for the publish workflow will likely be removed in a future version of expo-updates and we highly recommend migrating to the no-publish workflow.

rickysullivan

comment created time in 9 days

push eventexpo/expo

Eric Samelson

commit sha f3e910075dfeedb2d1ecb063b406227372da33a8

Publish expo-updates expo-updates@0.2.11

view details

push time in 9 days

push eventexpo/expo

Eric Samelson

commit sha 72adc0206fea64049fbbf6e30d38bb89ae606f25

[expo-updates] fix missing config var in expo-updates.gradle for publish workflow

view details

push time in 9 days

issue commentexpo/expo

[SDK 38] Android Release crash at startup

Hey all -- thanks for the heads up, and sorry for the trouble! The correct fix here is to initialize expo-updates before Flipper in onCreate rather than the other way around. So your onCreate method (inside of MainApplication.java) should look like this:

  @Override
  public void onCreate() {
    super.onCreate();
    SoLoader.init(this, /* native exopackage */ false);

    if (!BuildConfig.DEBUG) {
      UpdatesController.initialize(this);
    }

    initializeFlipper(this, getReactNativeHost().getReactInstanceManager());
  }

This has been fixed for new projects created by expo init or expo eject starting now. If you already created or ejected your project, just update your MainApplication.onCreate method to look like the above.

RodolfoGS

comment created time in 11 days

push eventexpo/expo

Eric Samelson

commit sha 9ce589594ce7f219907ba85e2998f96e302e2198

[templates][bare] fix expo-updates installation compatibility with Flipper on Android

view details

Eric Samelson

commit sha a40a5a72394c75944b5efb0c3934bf46c6e54d93

[expo-updates] clarify installation instructions for RN 0.62 with Flipper initialization

view details

push time in 11 days

push eventexpo/expo

Eric Samelson

commit sha a75c5c5532875b262a2db034fbbefda60b31e34e

[templates][bare] publish 38.0.3

view details

push time in 11 days

push eventexpo/expo

Eric Samelson

commit sha 6e75e8f78c972d768b45e607c63164f95febbd13

[templates][bare] fix expo-updates installation compatibility with Flipper on Android

view details

push time in 11 days

pull request commentexpo/expo

[android] remove GCM

seems reasonable to me! I might be able to find some spare minutes next week to update this PR but would also welcome if someone else wanted to take it over. 😇

esamelson

comment created time in 11 days

PR opened expo/expo

[WIP][expo-updates] add some basic unit tests

Why

Set up unit testing frameworks for expo-updates & add a few basic tests. This way I can add tests along the way as I'm integrating the module into the managed workflow/app store clients, in case any refactoring needs to happen.

How

added some basic junit tests that pass in Android Studio. TODO: iOS

Test Plan

Run the tests 😄

+71 -2

0 comment

5 changed files

pr created time in 11 days

create barnchexpo/expo

branch : @eric/updates-unit-tests

created branch time in 11 days

push eventexpo/expo

Eric Samelson

commit sha 9a118d295171895ddcddef9d46c48270d268eec7

[guides] remove algolia config step from Release Workflow ref https://github.com/algolia/docsearch-configs/pull/1924

view details

push time in 13 days

push eventexpo/expo

Eric Samelson

commit sha 3f83069c12ec580fdf2ddaee4457174174fffbad

[docs] add SDK 38 release notes to upgrade guide

view details

push time in 13 days

push eventexpo/turtle

Eric Samelson

commit sha 19a17231b303cef13ace56b5c03f3129b5c7fcbe

update CHANGELOG

view details

push time in 13 days

release expo/turtle

v0.16.0

released time in 13 days

push eventexpo/turtle

Eric Samelson

commit sha 98c03bc8a29dc7f82a98017b29714288ee8cd1d0

Release 0.16.0

view details

push time in 13 days

created tagexpo/turtle

tagv0.16.0

Standalone app builder service

created time in 13 days

push eventexpo/expo

Eric Samelson

commit sha 2cbe7fed8373b2d3e76b0156ce8d8f94ac1055a4

[fastlane][android] add 129 changelog

view details

push time in 13 days

push eventexpo/expo

Brent Vatne

commit sha 6001a420fe22b23571b66f6856bd211d23bc5795

[android] When Consants.DISABLE_NUX is set then skip the onboarding experience (#8954)

view details

Eric Samelson

commit sha 6ead49f273cdb1d086ab71157eeb1f6ed194a501

[android] bump version to 2.16.1 (129)

view details

push time in 13 days

delete branch expo/expo

delete branch : @brent/android-dev-menu-appetize-compat

delete time in 13 days

push eventexpo/expo

Brent Vatne

commit sha 7ad7945958da5fe7217543700b85aae3027262b0

[android] When Consants.DISABLE_NUX is set then skip the onboarding experience (#8954)

view details

push time in 13 days

PR merged expo/expo

[android] When Consants.DISABLE_NUX is set then skip the onboarding experience

Why

Each time the Expo client is started in Snack it's for the first time, and the EXKernelDisableNuxDefaultsKey is passed in through the intent that launches the app, we listen to that and set Constants.DISABLE_NUX in the Kernel: https://github.com/expo/expo/blob/450147ae9af81c2552f0ae86d271496e49961ce4/android/expoview/src/main/java/host/exp/exponent/kernel/Kernel.java#L444-L449

How

In DeveMenuManager.shouldShowOnboarding() I added a check to skip showing onboarding if Constants.DISABLE_NUX is set to true.

Test Plan

I tested this locally by making DISABLE_NUX default to true in Constants.java: https://github.com/expo/expo/blob/450147ae9af81c2552f0ae86d271496e49961ce4/android/expoview/src/main/java/host/exp/exponent/Constants.java#L49

I did not integration test it by starting the app with an intent. Presumably this still works as expected as the code hasn't changed in several years.

+1 -1

0 comment

1 changed file

brentvatne

pr closed time in 13 days

push eventexpo/expo

Eric Samelson

commit sha a65c45fd727217d516e6ce5e373314bc0896672a

[docs] remove some changes from master unversioned from the SDK 38 docs

view details

push time in 13 days

push eventexpo/expo

Eric Samelson

commit sha 450147ae9af81c2552f0ae86d271496e49961ce4

[expo-av] allow playing media files from apk res folder (#8936) # Why ref https://github.com/expo/expo/issues/8888 -- expo-av currently does not support playing media files from an android apk's `res/raw` folder, which is where the RN packager embeds required assets by default. # How RN's asset source resolver sets the `uri` for assets embedded in `res` to simply the resource name with no scheme. Therefore, if the url provided to expo-av has no scheme, we can assume it comes from RN's asset source resolver and is a resource name. ([We do the same thing in expo-file-system.](https://github.com/expo/expo/blob/1b61af26782c89da45ba559e60ebb2a38b6e80b3/packages/expo-file-system/android/src/main/java/expo/modules/filesystem/FileSystemModule.java#L312-L314)) # Test Plan Tested using the repo provided in #8888 and confirmed that with expo-updates disabled, after this change, the audio file played as expected both with ExoPlayer and with `androidImplementation: 'MediaPlayer'`.

view details

push time in 13 days

delete branch expo/expo

delete branch : @eric/expo-av-res

delete time in 13 days

PR merged expo/expo

Reviewers
[expo-av] allow playing media files from apk res folder

Why

ref https://github.com/expo/expo/issues/8888 -- expo-av currently does not support playing media files from an android apk's res/raw folder, which is where the RN packager embeds required assets by default.

How

RN's asset source resolver sets the uri for assets embedded in res to simply the resource name with no scheme. Therefore, if the url provided to expo-av has no scheme, we can assume it comes from RN's asset source resolver and is a resource name. (We do the same thing in expo-file-system.)

Found a couple of sources for how to read from resources in MediaPlayer and ExoPlayer (but I am no expert on either library!).

Test Plan

Tested using the repo provided in #8888 and confirmed that with expo-updates disabled, after this change, the audio file played as expected both with ExoPlayer and with androidImplementation: 'MediaPlayer'.

+23 -2

2 comments

3 changed files

esamelson

pr closed time in 13 days

push eventexpo/expo

Eric Samelson

commit sha 7c76fff3fae0a8bb9057b3355871b80865fb4ed6

update CHANGELOG

view details

push time in 13 days

push eventexpo/expo

Eric Samelson

commit sha 745d2ad0100e3b827e985613c274cd1a91d584ee

update CHANGELOG

view details

push time in 13 days

push eventexpo/expo

Eric Samelson

commit sha da6978f766b3fe355c0daab4be218139b61b26b7

[bare-expo] pod install

view details

push time in 13 days

create barnchexpo/expo

branch : @eric/sdk-38-docs-2

created branch time in 13 days

push eventexpo/expo

Eric Samelson

commit sha c210851ad54b18ef0d0232f3e9f88342e09df960

[expo-updates] fix README expo-splash-screen integration instructions

view details

push time in 14 days

create barnchexpo/expo

branch : @eric/sdk-38-docs

created branch time in 14 days

create barnchexpo/expo

branch : @eric/sdk-38-docs-master

created branch time in 14 days

PR opened expo/expo

Reviewers
[expo-av] allow playing media files from apk res folder

Why

fixes https://github.com/expo/expo/issues/8888 -- expo-av currently does not support playing media files from an android apk's res/raw folder, which is where the RN packager embeds required assets by default.

How

RN's asset source resolver sets the uri for assets embedded in res to simply the resource name with no scheme. Therefore, if the url provided to expo-av has no scheme, we can assume it comes from RN's asset source resolver and is a resource name. (We do the same thing in expo-file-system.)

Found a couple of sources for how to read from resources in MediaPlayer and ExoPlayer (but I am no expert on either library!).

Test Plan

Tested using the repo provided in #8888 and confirmed that with expo-updates disabled, after this change, the audio file played as expected both with ExoPlayer and with androidImplementation: 'MediaPlayer'.

+21 -2

0 comment

2 changed files

pr created time in 14 days

push eventexpo/expo

Charlie Cruzan

commit sha bc88de73b49e9a8dcd37fa2bec9d8d4f94ce19bf

[changelog] remove duplicate `netinfo` update entry

view details

Charlie Cruzan

commit sha 080e5b897a3b1e4b36f3fce6cd18c7437a578441

[docs] Improve webhook documentation (#8565)

view details

Stanisław Chmiela

commit sha 207cb4ac38e1615df80ecc73bea851a2f59a3307

[changelog] Add react-native upgrade to CHANGELOG (#8573) # Why Let's have all the user-facing changes in the changelog! (Sorry for not adding it earlier.) # How Edited the file, mentioning both pull requests related to the upgrade. # Test Plan None.

view details

Stanisław Chmiela

commit sha 539625ca5816e2505275b847fcaa042181874567

[repo] Upgrade CocoaPods and Fastlane (#8560) # Why When running `git pull` I noticed a strangely long output mentioning a lot of new `.xcconfig`s so I went to see when and why they were added. The commit adding them was [Publish expo-permissions, expo-notifications](https://github.com/expo/expo/commit/264a8722e01eb91cf1ec20eb5bdd09dd26fb829d). This does not sound like a commit that willingly upgrades CocoaPods used throughout the repository (which it did), so I decided to: - fix the long-standing problem of `pod` being used not-from-the-bundle - upgrade CocoaPods and Fastlane while I'm at it # How - updated version requirement for CocoaPods to `~> 1.9.1` - had to run `gem install bundler:2.1.4` even though I thought I've already run this command some time before - ran `bundle install` to install new CocoaPods - updated version requirement for Fastlane to `~> 2.148.0` - ran `bundle install` to install new CocoaPods - added `pod` and `fastlane` executables to the `bin` directory that are similar to `lock` executable—they are like an alias that makes `pod <X>` resolve to `bundle exec pod <X>` which should ensure that `pod` commands will fail if they would not resolve to the version installed by the bundler (In fact, `bundle install` installs its own executable commands under `.direnv/bin/`, but… you first have to run `bundle install` to have them, fail on `bundle exec pod…` should make it clear for the developers to install pods this way.) This commit also updates Pods of `react-native-safe-area-context` in `bare-expo`. # Test Plan - Ran `where pod`, verified that `/Users/sjchmiela/Applications/expo/bin/pod` is on the list. - Ran `bundle exec pod install` in `ios`, verified that it installs pods properly - Ran `pod install`, verified that it installs pods properly

view details

Tomasz Sapeta

commit sha aa2d439af4c9977d654623eb23355a9f64b6b4c6

[calendar] Make `sourceId` parameter optional when creating a calendar (#8570)

view details

Tomasz Sapeta

commit sha 41c245aa3cbd1d8f7d497779881a9acb0a5a0be1

[test-suite] Fix ImagePicker's camera tests (#8587)

view details

Łukasz Kosmaty

commit sha 0c417d7267a298516661e639f1b2048af4b1484a

[expo-notifications][ios] Fix scoped notifications handler (#8588)

view details

Tomasz Sapeta

commit sha c31c4f3d21f7991f1addaa22beca8adad04a5331

[test-suite] Make SMS tests more reliable (#8574)

view details

Tomasz Sapeta

commit sha 162a8054bae5dc45d36921e3a1505242278eed1a

[sms] Fix `MFMessageComposeViewController` being initialized from non-main thread (#8575)

view details

Łukasz Kosmaty

commit sha 81596da07708caf5d948044b03048b791dd20bfc

[expo-linking] Fix test-suite (#8591)

view details

Stanisław Chmiela

commit sha 1d09954bb0607b7198a07f5d97afd2732186c8e6

[android] Upgrade Gradle stuff (#8557) # Why [Android Studio 4 got released](https://android-developers.googleblog.com/2020/05/android-studio-4.html)! I decided it's good time to upgrade AS and also to click that "New version of Gradle Plugin is available" button. # How Upgraded Gradle and Android Gradle plugin in both `android` and `bare-expo/android`. Had to upgrade Butterknife too to get rid of [this problem](https://stackoverflow.com/a/60614971/1123156). Also had to add `.DEFAULT` attribute to `HomeActivity`'s `intent-filter`, otherwise AS decided to open… `.TvActivity` as the _default activity_. Reordering activities in `AndroidManifest.xml` did not fix the issue. Had to add specific version of NDK installation to GitHub CI workflow. # Test Plan Expo Client compiles, `bare-expo` compiles.

view details

Stanisław Chmiela

commit sha 3d1fb0e3f94434d15c3fa70073bb496e82e7ac41

[expo-payments-stripe] Upgrade Stripe dependency to fix Xcode 11.4 compat (#8594) # Why - Fixes https://github.com/expo/expo/issues/7621. - Stripe 13 is incompatible with Xcode 11.4. - We've been slow to update the package. # How - Updated the dependency version to `~> 14.0.1` fixing the issue as per https://github.com/stripe/stripe-ios/issues/1525#issuecomment-604037716. The 13 ➡️ 14 upgrade should not break anything, I have verified that we don't use any of the changed classes described [in changelog](https://github.com/stripe/stripe-ios/blob/master/CHANGELOG.md#1400-2018-11-14). - Added the ability to set a completely custom version of Stripe in order to let people upgrade to newer versions without using `patch-package` etc. We already do this in eg. `expo-image`. # Test Plan Temporarily I have removed the `expo-payments-stripe` package from the list of `excludedUnimodules` in `bare-expo`. I have verified that after applying these changes the application runs successfully.

view details

Stanisław Chmiela

commit sha cb71472a9a51ba422b1ded43a07d89ee13dd3eca

Publish expo-payments-stripe expo-payments-stripe@8.2.2

view details

Łukasz Kosmaty

commit sha 3ba2b94b3e316326c36d6a9c1d940e4d9bf83aff

[expo-file-system] The background session doesn't fail if connection is down (#8593) * [expo-file-system] Fix test-suite & update docs * Update filesystem.md Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com> Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com>

view details

Tomasz Sapeta

commit sha 6729019bf21f17c7ffa9356004f35fac5d8d7614

[local-authentication] Fix crash when `NSFaceIDUsageDescription` is not provided and device fallback is disabled (#8595)

view details

Jon Samp

commit sha d6f8557123d0c7fc92a845dd5902b4ace577fe93

[docs] Adds android studio download link (#8513)

view details

Ronald

commit sha fc0ff9e62e5bccb3b264073febd4c106bb51da15

[docs] switch imagePicker docs from class components to functional components (#8581) * switch imagePicker docs from class components to functional components * moved v37 docs to use components

view details

Vamshi krishna

commit sha db86470a41c1a47de9025847a9b0bf37a3ce2865

AuthRequestConfig , DiscoveryDocument links (#8582) Links for AuthRequestConfig , DiscoveryDocument corrected

view details

Evan Bacon

commit sha b32c7ce98d31cdf54edd3788b768ca9eb7d48892

[auth-session][docs] Fix links (#8601) * Use lowercase links * Added missing type AuthSessionResult

view details

Evan Bacon

commit sha 09389aecddd13772cc78fe9d1d355ab497d47ada

[docs][auth-session] Add implicit auth guides (#8572) * Added switcher * Update authentication.md * Updated Spotify API * converted all to tsx * slack implicit * reddit implicit * Update authentication.md * Update authentication.md * Update AuthSessionElements.js * Made tabs dynamic * Update authentication.md * Update AuthSessionElements.js * Update AuthSessionElements.js * Update authentication.md

view details

push time in 14 days

create barnchexpo/expo

branch : @eric/expo-av-res

created branch time in 14 days

delete branch expo/expo-cli

delete branch : @eric/init-updates-config

delete time in 14 days

push eventexpo/expo-cli

Eric Samelson

commit sha 51cb2d6ccb4a716110e1e5d73f46ef58afabb442

[expo-cli] configure expo-updates plist/xml values in expo init (#2249)

view details

push time in 14 days

PR merged expo/expo-cli

Reviewers
[expo-cli] configure expo-updates plist/xml values in expo init

Currently if you want to try out OTA updates in a new bare project, this is what likely happens

  • expo init bare
  • make release build
  • expo publish
  • relaunch app, OTA update doesn't load ???

This is because expo-updates depends on some native configuration values in Expo.plist/AndroidManifest.xml. expo publish sets these values automatically, but in the flow above, by the time the user runs expo publish they have already made a release build without the necessary values.

This PR adds configuring these fields with best-guess values on expo init. We need the SDK version and project URL; we can get the SDK version from the project config, and we can make a best guess of the URL by combining the project slug with the logged-in user's username. We also show a message warning the user they'll need to change these values if they publish under a different user (although expo publish will do this automatically), or letting them know if we can't configure these values at all for some reason.

Todo next:

  • same thing in eject
  • configure more values from app.json updates field in eject, if they exist
+75 -2

8 comments

1 changed file

esamelson

pr closed time in 14 days

issue commentexpo/expo

[expo-updates][bare] Assets not bundled with build since expo-updates 1.3

Hey @jonathanstiansen - thanks for the report and the repro. It looks like this is actually an issue with expo-av not knowing how to read assets bundled into an apk's res directory. (You would see the same issue if you used expo-av in a bare React Native app without expo-updates -- it just so happens that enabling expo-updates is a workaround for the issue as it DOES know how to read assets from the res folder and copies them to a different location.)

I'm going to rename this issue to track it appropriately. We'll try and have a fix out soon but can't promise it on any given timeline.

jonathanstiansen

comment created time in 14 days

issue closedexpo/expo

[expo-updates][Bare] setting `expo.modules.updates.ENABLED` to false does NOT stop updates

🐛 Bug Report

Summary of Issue (just a few sentences)

When working in bareworkflow turning off updates for android does not work.

<meta-data android:name="expo.modules.updates.ENABLED" android:value="false"/>

Environment - output of expo diagnostics & the platform(s) you're targeting

Expo CLI 3.20.9 environment info: System: OS: macOS 10.15.4 Shell: 5.7.1 - /bin/zsh Binaries: Node: 13.14.0 - ~/.nvm/versions/node/v13.14.0/bin/node Yarn: 1.22.4 - /usr/local/bin/yarn npm: 6.14.4 - ~/.nvm/versions/node/v13.14.0/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman IDEs: Xcode: 11.4.1/11E503a - /usr/bin/xcodebuild npmPackages: expo: ~37.0.3 => 37.0.12 react: ~16.9.0 => 16.9.0 react-dom: ~16.9.0 => 16.9.0 react-native: ~0.61.5 => 0.61.5 react-native-web: ~0.11.7 => 0.11.7 npmGlobalPackages: expo-cli: 3.21.9

Reproducible Demo

  1. expo init -> Bareworkflow
  2. add this to App.js component

  const update = async () => {
    try {
      const update = await Updates.checkForUpdateAsync();
      if (update.isAvailable) {
        await Updates.fetchUpdateAsync();
        alert('Got update')
        await Updates.reloadAsync()
      }
    } catch (e) {
      console.log("Update fail", e);
    }
  }

  React.useEffect(() => {
    update()
  }, [])

  1. add: <meta-data android:name="expo.modules.updates.ENABLED" android:value="false"/> to xxx/main/AndroidManifest.xml
  2. run yarn android --variant=release
  3. Change App.js to include some text that is recognizable
  4. run expo publish
  5. Restart the app,
  6. note that the alert is shown and the new text is displayed

here is a repo to demonstrate.

Expected Behavior vs Actual Behavior

I'd expect no updates to be received, or gotten from the app. But all are.

closed time in 14 days

jonathanstiansen

issue commentexpo/expo

[expo-updates][Bare] setting `expo.modules.updates.ENABLED` to false does NOT stop updates

yikes! thanks for the report, this has been fixed in expo-updates@0.2.10.

jonathanstiansen

comment created time in 14 days

push eventexpo/expo

Eric Samelson

commit sha 1b61af26782c89da45ba559e60ebb2a38b6e80b3

Publish expo-updates expo-updates@0.2.10

view details

push time in 14 days

push eventexpo/expo

Eric Samelson

commit sha 084f390d0dd868a343b31abc197fb4f8cc18be4f

[expo-updates] update CHANGELOG

view details

push time in 14 days

push eventexpo/expo

Eric Samelson

commit sha 0d1eae1495418ec9f4f8b40c4f78e96fd2098b38

[expo-updates] fix AndroidManifest property name for ENABLED

view details

push time in 14 days

push eventexpo/expo-cli

Eric Samelson

commit sha df553e1e202391fee091c996b1eb96d49894c47d

apply ios config on all platforms!

view details

push time in 15 days

push eventexpo/expo-cli

Eric Samelson

commit sha 4d54abaa8cdd34f824bb325592f31da137526934

only try to apply ios config if running on macOS

view details

push time in 15 days

push eventexpo/turtle

Eric Samelson

commit sha 83ab2539c1629f28a66bf0b1a6ae4a8f95886dc1

[ios][android] remove SDK 34 shell apps

view details

push time in 15 days

push eventexpo/turtle

Eric Samelson

commit sha 064619e1ae92c3ffcf0f98aed83f519255a0ff20

[android] add SDK 38 shell tarball (#233)

view details

push time in 15 days

PR merged expo/turtle

[android] add SDK 38 shell tarball

<!-- Thanks for contributing to turtle! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

Checklist

  • [x] I've read the Contribution Guidelines.
  • [x] I've updated the CHANGELOG if necessary.
  • [ ] I've ensured the unit and smoke tests are still passing - either by running yarn test:unit and yarn test:smoke:[ios|android] or by checking the appropriate CircleCI builds' statuses.
  • [x] I've manually tested whether the changes I made work as expected.

Motivation and Context

<!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. -->

Description

<!-- Describe your changes in detail --> <!-- Please describe in detail how you tested your changes. -->

+2 -0

0 comment

2 changed files

esamelson

pr closed time in 15 days

push eventexpo/turtle

Tomasz Sapeta

commit sha b7fe01b7584007cb0981f55b13c84dcc7e9a4283

[ios] Add shell tarballs for SDK38 (#231)

view details

Eric Samelson

commit sha 83c816b02311e6441030dc4ef82ee1c98101ff40

[android] add SDK 38 shell tarball

view details

Eric Samelson

commit sha 1f07da81dfa29b3b1a3ecde21e138d064307bb28

update changelog

view details

push time in 15 days

push eventexpo/expo

Eric Samelson

commit sha 18a58afe742e63f1d2ac71ba21404d8b84e6563e

[expokit] publish 38.0.0

view details

push time in 15 days

PR opened expo/turtle

[android] add SDK 38 shell tarball

<!-- Thanks for contributing to turtle! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

Checklist

  • [x] I've read the Contribution Guidelines.
  • [ ] I've updated the CHANGELOG if necessary.
  • [ ] I've ensured the unit and smoke tests are still passing - either by running yarn test:unit and yarn test:smoke:[ios|android] or by checking the appropriate CircleCI builds' statuses.
  • [ ] I've manually tested whether the changes I made work as expected.

Motivation and Context

<!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. -->

Description

<!-- Describe your changes in detail --> <!-- Please describe in detail how you tested your changes. -->

+1 -0

0 comment

1 changed file

pr created time in 15 days

create barnchexpo/turtle

branch : @eric/android-sdk-38

created branch time in 15 days

push eventexpo/expo

Eric Samelson

commit sha 076a13fd8b4ee84a59eb6d2777f6db0a2c71fb6d

Revert "[react-native-lab] Update head to hermes-engine stub commit" This reverts commit 785c51aad7b9122d6feb4cc6540af9829806cec4.

view details

push time in 16 days

push eventexpo/expo

Eric Samelson

commit sha ab5cc146ca00e1cfa296b57df8ac13f13e004238

[sdk-38][ci] fix APK and Android shell app jobs (#8915)

view details

push time in 16 days

delete branch expo/expo

delete branch : @eric/sdk-38-apk

delete time in 16 days

PR merged expo/expo

[sdk-38][ci] fix APK and Android shell app jobs

Why

APK and Android shell app jobs are broken on circle currently.

How

  • add bundle_install to APK job since it uses fastlane
  • correct changed working directory
  • install rsync (and update apt-get)
  • use android executor for the APK job since it needs java

Test Plan

  • [x] shell_app_android job passes on this branch
  • [x] client_android_apk_release job passes on this branch
+16 -3

0 comment

1 changed file

esamelson

pr closed time in 16 days

push eventexpo/expo

Eric Samelson

commit sha f95c2d22feadd840c448e547370046514f5dc2c2

source expotools.env

view details

push time in 16 days

push eventexpo/expo

Eric Samelson

commit sha 5cd02f50a53e6974aa4f2a5a84f58251bc5ab27c

decode release keystore

view details

push time in 16 days

push eventexpo/expo

Eric Samelson

commit sha ddcbbf4358d6605de440d52557e821e19724ca3f

yarn install project root

view details

push time in 16 days

push eventexpo/expo

Eric Samelson

commit sha 7df53085da38fae6e7a2bb8233e3350077a83058

install yarn

view details

push time in 16 days

push eventexpo/expo

Eric Samelson

commit sha 599dcc3123c52322ad7bb4c9f44b78ff522bfab0

[android] bump version to 2.16.0 (128)

view details

push time in 16 days

push eventexpo/expo

Eric Samelson

commit sha e79bc108fa7b376d60bba553ec6b593a5e94c9c8

[android] bump version to 2.16.0 (128)

view details

push time in 16 days

PR opened expo/expo

Reviewers
[sdk-38][ci] fix APK and Android shell app jobs

Why

APK and Android shell app jobs are broken on circle currently.

How

  • add bundle_install to APK job since it uses fastlane
  • correct changed working directory
  • install rsync (and update apt-get)
  • use android executor for the APK job since it needs java

Test Plan

  • [x] shell_app_android job passes on this branch
  • [ ] client_android_apk_release job passes on this branch
+7 -2

0 comment

1 changed file

pr created time in 16 days

push eventexpo/expo

Eric Samelson

commit sha 34f6ca4cef99d99007d481ba58d75d75ed581c93

[ci] run sudo apt-get update

view details

push time in 16 days

push eventexpo/expo

Eric Samelson

commit sha e96d2a434dad91d681671233baaf29e1641e0531

[expo-updates] improve error messages when embedded manifest cannot be found

view details

push time in 16 days

push eventexpo/expo

Eric Samelson

commit sha d0bb950491358b6c4fbcf0125447fb160d72c052

[expokit] rebuild expoview

view details

push time in 18 days

push eventexpo/expo

Brent Vatne

commit sha 753abc0774a92e8811de1bbad3cdb4937af4f681

[android] Fix orientation when starting home activity

view details

Brent Vatne

commit sha 1c1156b19848a3a9f38d5d32b22f0d34ace7bee4

[templates] Add SafeAreaProvider to tabs template root

view details

Eric Samelson

commit sha d68e42e73d2a1fec7889c71fab1bfe19a25d6136

[android] catch error when trying to send an event to JS Kernel before RCTDeviceEventEmitter has initialized (#8883)

view details

Eric Samelson

commit sha e16a076ff3a51debb08e21ab2461c0376bc06dae

[expokit] rebuild expoview

view details

Eric Samelson

commit sha bb90ef1e71c8e8fdf8de333039f67ef0e69753b5

[ci] add bundle_install to APK job and change working directory

view details

Eric Samelson

commit sha 09e071544d056dfeb3fd17be53fef86953a70abf

[ci] install rsync

view details

Eric Samelson

commit sha a6f7a42caccd0445da18f2a08e774b49e6959740

use android executor

view details

push time in 18 days

push eventexpo/expo

Eric Samelson

commit sha e16a076ff3a51debb08e21ab2461c0376bc06dae

[expokit] rebuild expoview

view details

push time in 18 days

push eventexpo/expo

Eric Samelson

commit sha d68e42e73d2a1fec7889c71fab1bfe19a25d6136

[android] catch error when trying to send an event to JS Kernel before RCTDeviceEventEmitter has initialized (#8883)

view details

push time in 18 days

push eventexpo/expo

Eric Samelson

commit sha 35c149980efc7f25f6f9be3b5a67363bd7bdb117

[android] catch error when trying to send an event to JS Kernel before RCTDeviceEventEmitter has initialized (#8883)

view details

push time in 18 days

delete branch expo/expo

delete branch : @eric/fix-kernel-crash

delete time in 18 days

PR merged expo/expo

[android] catch error when trying to send an event to JS Kernel before RCTDeviceEventEmitter has initialized

Why

Brent reported a crash https://exponent-internal.slack.com/archives/CNHBN8LNS/p1592588269002300

For me, this race condition happens about one in ~5 times opening an experience from the command line, without the Expo app already being open on the device.

How

Catch the exception thrown by getJSModule when it's called too early in the app lifecycle, and call the failure callback instead of crashing.

Catching this exception should be safe as none of the events used by this module are critical. In this case the event being sent is to add the experience as a history item in Home's Projects tab. In the case where the exception is triggered the experience simply isn't added to the history, but it looks like that is already the case for projects opened from the command line if the Expo app isn't already open. (Worth investigating as a separate issue.)

The only other event that uses this code is used to tell the dev menu to play the "closing" animation when the user requests the menu to close. We shouldn't ever run into the issue where RCTDeviceEventEmitter is not yet established in this case, and even if we do, not running the animation is not the end of the world.

Test Plan

Added some logging to identify when the race condition occurs, verified it no longer causes the app to crash.

+5 -1

0 comment

1 changed file

esamelson

pr closed time in 18 days

pull request commentexpo/expo-cli

[expo-cli] configure expo-updates plist/xml values in expo init

Changes applied, but one thing I don't like about the AndroidConfig is that the package we use to read and write the AndroidManifest doesn't preserve comments, whitespace, and in some cases, order of tags, which makes the AndroidManifest less readable (especially for a newly inited project). I'm 50/50 on whether it's worth it to have slightly cleaner code on our side.

esamelson

comment created time in 19 days

push eventexpo/expo-cli

Evan Bacon

commit sha 3511e1e835e13fcbd9cda7b172a040be9b1aaa1c

[expo-cli][install] format error messages (#2234) * Updated install error messages * Added e2e tests * Update install-test.ts

view details

Evan Bacon

commit sha 578ef4a7954221fe6df82260d193f717965a3ffd

Upgrade find-yarn-workspace-root (#2251)

view details

Eric Samelson

commit sha e106afa4f6bc7a8126469a3a123af46d7db5ec3f

[xdl] set EXPO_TARGET to correct value when starting dev server (#2250)

view details

Wojciech Kozyra

commit sha 9a44da0688f2793c87c5e1c5c362d031d2761c0d

fix: remove opt-in-google-play-signing (#2247) * fix: remove opt-in-google-play-signing * update CHANGELOG.md

view details

Ville Immonen

commit sha 40fc01f652d73750c220d7728bba390576eee252

refactor: unify glob usage (#2218)

view details

Ville Immonen

commit sha d2b1d54eb451aea8ed130b0cc392a6f030dbc0d7

chore: bump @react-native-community/cli-server-api version

view details

Ville Immonen

commit sha c4d114b32ca7e02fe3d17b6ade83c5ad65f1c3b0

Upgrade changelog

view details

Ville Immonen

commit sha 468fdf9a4d1ae04dabd07fd1ce5d0ab0f7fee6d4

chore: upgrade and partially remove deprecated joi package

view details

Tomasz Sapeta

commit sha 3af3c4815acc7ec87672fabedbef51c694a6c101

[xdl] Change generated ExpoKit pod path

view details

Tomasz Sapeta

commit sha e1164f937c2b7841cada2b67715d55ae5d1743c7

[xdl] Fix broken condition after removing lodash

view details

Tomasz Sapeta

commit sha 210da96f6296b7331fb2024040c6a7f31b7307a9

[xdl] Fix standalone service context being recognized as user context

view details

Tomasz Sapeta

commit sha 3eecc9a7755b09f005c2e0d205bbbe4416602128

[xdl] Fix StandaloneContext.isAnonymous implementation

view details

Wojciech Kozyra

commit sha f44d0d7f82d84f162ace8abe609e0b23ef750363

fix(expo-cli): remove keystore only if confirmed (#2258)

view details

Tomasz Sapeta

commit sha 6b4992ca3bc4e23d32c5fc95110d3750c54dedfe

Publish - @expo/config@3.2.10 - @expo/configure-splash-screen@0.1.12 - @expo/dev-server@0.1.11 - @expo/dev-tools@0.13.17 - @expo/electron-adapter@0.0.0 - expo-cli@3.21.6 - expo-optimize@0.1.33 - @expo/metro-config@0.1.11 - @expo/next-adapter@2.1.13 - @expo/package-manager@0.0.28 - pod-install@0.1.7 - expo-pwa@0.0.21 - uri-scheme@1.0.18 - @expo/webpack-config@0.12.13 - @expo/xdl@57.9.14

view details

Evan Bacon

commit sha 7b9f9ab711db267e3108745fe98eff0e8bbfb40a

Use default splash.resizeMode on web (#2268)

view details

Ville Immonen

commit sha ce02510771db2e20922f62e4ee904fc5796391f7

Adjust config types to take defaults in account (#2260)

view details

Dominik Sokal

commit sha 5ffe34d6c56562210284698c5219f9d5e41ce23c

[expo-cli] turtle v2: create app before running build (#2248) * [expo-cli] turtle v2: create app before running build * [expo-cli] add progress bar for project upload * [expo-cli] don't fall back to 'untitled'

view details

Tomasz Sapeta

commit sha 3781ac081d63d1e57b91396298fea4c81f009e5b

Update changelog

view details

Quinlan Jung

commit sha f7a59d4154153b60ac8ca61ed70ed96a633b2dc6

[traveling-fastlane] bump traveling fastlane (#2273)

view details

Quinlan Jung

commit sha b3eddb327506da9c89949e83286aedaf3118828b

[traveling-fastlane] publish 1.15.0

view details

push time in 19 days

push eventexpo/expo-cli

Eric Samelson

commit sha fa2252fab18ea75549a49e773d4fe238540388f1

[config][expo-cli] add updates config to expo eject and expo apply (#2275) Adds Updates configuration (both the properties set in app.json, and other properties like the update URL) to the `configureAndroidProjectAsync` and `configureIOSProjectAsync` steps of `expo eject`. This allows workflows like - expo eject - make release build - publish update - get update in app right away without having to set configuration options (like the URL) manually before making a release build. Tested manually with defaults and with each of the app.json fields set manually (including owner) and verified that the resulting fields in Expo.plist and AndroidManifest.xml were correct in all cases.

view details

push time in 19 days

delete branch expo/expo-cli

delete branch : @eric/eject-updates-config

delete time in 19 days

PR merged expo/expo-cli

Reviewers
[config][expo-cli] add updates config to expo eject and expo apply

Follow up to #2249, partial step of #1494.

Adds Updates configuration (both the properties set in app.json, and other properties like the update URL) to the configureAndroidProjectAsync and configureIOSProjectAsync steps of expo eject.

This allows workflows like

  • expo eject
  • make release build
  • publish update
  • get update in app right away

without having to set configuration options (like the URL) manually before making a release build.

Tested manually with defaults and with each of the app.json fields set manually (including owner) and verified that the resulting fields in Expo.plist and AndroidManifest.xml were correct in all cases.

  • [x] TODO: add unit tests for these config methods
+341 -2

0 comment

10 changed files

esamelson

pr closed time in 19 days

push eventexpo/expo

Eric Samelson

commit sha b2f3dfc1b78bd93c3925e105eca8fd707a399be1

[ci] add bundle_install to APK job and change working directory

view details

Eric Samelson

commit sha 46203c9a02da78b2526795a1c0ff82ad1537ba03

[ci] install rsync

view details

push time in 19 days

PR opened expo/expo

Reviewers
[android] catch error when trying to send an event to JS Kernel before RCTDeviceEventEmitter has initialized

Why

Brent reported a crash https://exponent-internal.slack.com/archives/CNHBN8LNS/p1592588269002300

For me, this race condition happens about one in ~5 times opening an experience from the command line, without the Expo app already being open on the device.

How

Catch the exception thrown by getJSModule when it's called too early in the app lifecycle, and call the failure callback instead of crashing.

Catching this exception should be safe as none of the events used by this module are critical. In this case the event being sent is to add the experience as a history item in Home's Projects tab. In the case where the exception is triggered the experience simply isn't added to the history, but it looks like that is already the case for projects opened from the command line if the Expo app isn't already open. (Worth investigating as a separate issue.)

The only other event that uses this code is used to tell the dev menu to play the "closing" animation when the user requests the menu to close. We shouldn't ever run into the issue where RCTDeviceEventEmitter is not yet established in this case, and even if we do, not running the animation is not the end of the world.

Test Plan

Added some logging to identify when the race condition occurs, verified it no longer causes the app to crash.

+5 -1

0 comment

1 changed file

pr created time in 19 days

create barnchexpo/expo

branch : @eric/fix-kernel-crash

created branch time in 19 days

push eventexpo/expo

Tomasz Sapeta

commit sha 82ea7c3b3f3299f962398714e4137ef0899a020a

[calendar] Make `sourceId` parameter optional when creating a calendar (#8570)

view details

Tomasz Sapeta

commit sha 3f2aeba9d8350beb419c49f1bbb71f1323e1c74f

[test-suite] Fix ImagePicker's camera tests (#8587)

view details

Łukasz Kosmaty

commit sha 523325b43671bafe67b4c7ff6129b49efe392172

[expo-notifications][ios] Fix scoped notifications handler (#8588)

view details

Tomasz Sapeta

commit sha 8f54c8cd0b70d7a05adc504fe02a9a9f72bb8343

[test-suite] Make SMS tests more reliable (#8574)

view details

Tomasz Sapeta

commit sha 4ab001dbfc3b1533b29d4be743337508a02adce3

[sms] Fix `MFMessageComposeViewController` being initialized from non-main thread (#8575)

view details

Łukasz Kosmaty

commit sha 82c5cb08338a6b2684df52beac2a7ed276c11fcf

[expo-linking] Fix test-suite (#8591)

view details

Łukasz Kosmaty

commit sha bd1e8f0cc6b20e9937e5e56d19cfec9041b20328

[expo-file-system] The background session doesn't fail if connection is down (#8593) * [expo-file-system] Fix test-suite & update docs * Update filesystem.md Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com> Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com>

view details

Tomasz Sapeta

commit sha 5fc5d267e49a7d549f9db05dc750615ffcedeed4

[local-authentication] Fix crash when `NSFaceIDUsageDescription` is not provided and device fallback is disabled (#8595)

view details

Stanisław Chmiela

commit sha 645f4dab7b3ed24f2a4a02bba6260a81ee25c88d

[expo-notifications] Allow simultaneous calls to push token fetch (#8608) # Why May make `get[Expo|Device]PushTokenAsync` more resilient by both: - letting those two methods share a single request to fetch device push token - handling Fast Refresh better by sharing the single request. Should fix https://github.com/expo/expo/issues/8084. # How Save the `Promise` that will resolve with device push token. # Test Plan - [x] added a new test case and verified that it passes as expected

view details

Łukasz Kosmaty

commit sha d69ca7e647c4fdc96b5f366390adfca9b8ece45a

[expo-notifications] Fix SDK version check (#8611)

view details

Michał Czernek

commit sha 00607d8cdde81346691511edec976ec733b8a74b

[expo-task-manager][android] Fix removing tasks from repository when … (#8612) * [expo-task-manager][android] Fix removing tasks from repository when unregistering them. Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com>

view details

Eric Samelson

commit sha b70390abb61e38e895330c264ecb62fb0c1c5f66

[expo-file-system] fix download progress event name on Android (#8605)

view details

Eric Samelson

commit sha ca1ff36e814e8e749188766e01393cb947eef862

[ncl] fixes from Android unversioned QA (#8604) * [ncl] prettier fixes (separate commit) * [ncl] fix remaining Picker imports * [ncl] fix Linking screen * [ncl] fix style and auth session redirect on WebBrowser screen

view details

Eric Samelson

commit sha 04cb7d483fe75a9c28d7450f7137bcde36d89da6

[ncl] address missed feedback from https://github.com/expo/expo/pull/8604#discussion_r433582230

view details

Tomasz Sapeta

commit sha e0159b471ea4d13f18eac2ab71a107b65fef0dfe

[ios] Version code for SDK38 (#8620)

view details

Tomasz Sapeta

commit sha e36bade48d8588449515604dcd9f1082b43b3f5e

[ios] Fix React's dependencies not being prefixed in podspec

view details

Tomasz Sapeta

commit sha 760c81cfca678efe5491edd17eaf2580211ab13d

[et] Fix versioning React.podspec

view details

Tomasz Sapeta

commit sha a5cf424f41910f721f914887f9d4a5be9ee4f5c6

Publish expo, jest-expo expo@38.0.0 jest-expo@38.0.0

view details

Tomasz Sapeta

commit sha 583e1a693ea76151771041659664068de216a188

Remove gitHead from expo and jest-expo

view details

Eric Samelson

commit sha 721cfa9743ab3a6cfa01c582ada27ad0326e4e04

[test-suite] make green on Android (#8642)

view details

push time in 19 days

create barnchexpo/expo

branch : @eric/sdk-38-apk

created branch time in 19 days

push eventexpo/expo

Eric Samelson

commit sha f9f9b81f18feb6d255a320cd4dd281f48a3af04e

[expokit] rebuild expoview package

view details

Eric Samelson

commit sha a9807e70c3ac78dc6679587fe3157acd92df1087

[android][expoview] backport changes from 15c7796f7c757df85c4bf12013e36f763f0379a8 to versioned SDK 38 code

view details

Eric Samelson

commit sha c00211e23ee0a6635198caf80caca58bc60cb16a

[expokit] rebuild packages

view details

push time in 19 days

push eventexpo/expo

Michał Czernek

commit sha 17e521a22b443dd0dc773c09e85360f53e3cbacf

Add null checks to minimize probability of NPE in TaskManager. (#8868) During QA for SDK38 came up some NPE crashes while testing background tasks. Those checks does not provide full safety. Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com> Co-authored-by: Eric Samelson <esamelson@users.noreply.github.com>

view details

Eric Samelson

commit sha f4e181650747a2826ce7cacad1dfea30e4c20079

[android][expoview] backport changes from 15c7796f7c757df85c4bf12013e36f763f0379a8 to versioned SDK 38 code

view details

Eric Samelson

commit sha bcfb8b33405bf8ef188acae94f5fe11780ece4c8

[expokit] rebuild packages

view details

push time in 19 days

issue commentexpo/expo

expo app crushes in production. expo-updates is involved

Hey @RohovDmytro - sorry this is causing you so much trouble! 😞 Are you able to access the debug logs for your device via adb logcat? If so, could you try running adb logcat | grep "EmbeddedLoader", launch the app and paste the output here? That will hopefully give us some more information to work with.

RohovDmytro

comment created time in 19 days

pull request commentexpo/expo-cli

[expo-cli] configure expo-updates plist/xml values in expo init

could we use the implementation from @expo/config here instead? it would be one less thing to keep up to date then

yes, good point 😄 will wait for #2275 to land and then update this PR

esamelson

comment created time in 19 days

Pull request review commentexpo/expo-cli

[config][expo-cli] add updates config to expo eject and expo apply

+import { ExpoConfig } from '../Config.types';+import { Document } from './Manifest';++export function getUpdateUrl(config: ExpoConfig, username: string | null) {

opened this issue to track https://github.com/expo/expo-cli/issues/2285

esamelson

comment created time in 19 days

issue openedexpo/expo-cli

[config] add `exportUrl` field

follow-up from https://github.com/expo/expo-cli/pull/2275#discussion_r441900987

Would be nice to have an exportUrl field (or similar) in app.json which would accomplish two purposes: (1) keep user from having to enter the same --public-url every time they run expo export and (2) let us set the update URL field to the correct value in expo eject.

created time in 19 days

push eventexpo/expo-cli

Eric Samelson

commit sha 0ec8ddcb086217f4440fa5fc843f76b708028787

PR feedback

view details

Eric Samelson

commit sha 2db1ecd0079eb8af991ba3895746f6876da94368

add tests

view details

push time in 19 days

push eventexpo/expo

Stanisław Chmiela

commit sha db1c4130845c538331020a3c46967b59d4fc685c

[expo-notifications] Add preliminary "support" for Web (#8853) # Why Even though we don't support Web in `expo-notifications`, we don't want to be a pain to the users and throw errors just because of running the code on Web. # How Added simple object fallbacks for missing modules on web so that they are queryable by ```ts if (!Module.methodAsync) { throw new Unavailability… } ``` Swapped `.ts` + `.web.ts` for `.native.ts` + `.ts` (or + `.web.ts` + `.ts` where it made sense, eg. if we would need to use `localStorage` inside the `.ts` file I renamed it to `.web.ts` and added an empty fallback in `.ts`). # Test Plan - [x] Ran NCL in `bare-expo` on Web, clicked buttons around, noticed the error is readable and makes sense. - [x] Ran `expo-notifications` test-suite on both iOS and Web. It seems iOS tests are a little bit flaky, unfortunately (the errors could also happen due to erroring Expo API, HTTP error 504 when fetching push token, but I was able to make all of the tests pass just refreshing).

view details

push time in 19 days

delete branch expo/expo

delete branch : @sjchmiela/expo-notifications-web

delete time in 19 days

more