profile
viewpoint
Eric Bottard ericbottard @pivotal Paris

ericbottard/cloudfoundry-tomcat-7 6

A template for running Tomcat7 in CloudFoundry (as a standalone app)

ericbottard/csv-subsampler 1

A simple program to sample data out of a csv file

cloudfoundry-blueprints/angular-phonecat 0

Tutorial on building an angular application.

cloudfoundry-blueprints/redispubsub 0

A Node.js chat app using Express 3.x, Redis Pub/Sub + Redis SessionStore + Socket.io + Socket.Sessions that shows scaling on Cloud foundry

cloudfoundry-blueprints/spring-petclinic 0

A sample Spring-based application

cloudfoundry-blueprints/zentasks-scala-cloudfoundry 0

a slight reworking of the Play framework 2.1.1 sample application - zentasks - to run on Cloud Foundry v1

Pull request review commentprojectriff/system

[Coordinated, template] Use CloudEvent aware modules.

 subjects: --- apiVersion: v1 data:-  gatewayImage: bsideup/liiklus:0.9.0+  gatewayImage: ctr.run/github.com/bsideup/liiklus:00385b688bc34d6fdbe2b5eeb39daa26e09f8b02

Let's kill two birds with one stone once the streaming-processor PR is merged as well...

ericbottard

comment created time in 20 hours

Pull request review commentprojectriff/streaming-processor

[Coordinated] Serialize messages as liiklus CloudEvents

 public void run() {     }      /**-     * This converts an RPC representation of an {@link OutputFrame} to an at-rest {@link Message}, and creates a publish request for it.+     * This converts an RPC representation of an {@link OutputFrame} to an at-rest CloudEvent, and creates a publish request for it.      */     private PublishRequest createPublishRequest(OutputFrame next, String topic) {-        Message msg = Message.newBuilder()-                .setPayload(next.getPayload())-                .setContentType(next.getContentType())-                .putAllHeaders(next.getHeadersMap())-                .build();-         return PublishRequest.newBuilder()-                .setValue(msg.toByteString())+                .setLiiklusEvent(+                        LiiklusEvent.newBuilder()+                                .setData(next.getPayload())+                                .setDataContentType(next.getContentType())+                                .setType("riff-event") // TODO+                                .setSource(this.group) // TODO

Later, needs to figure out even the meaning we want to give this.

The whole PR is ready for review as-is, but what you see is what you get

ericbottard

comment created time in a day

push eventericbottard/system

dependabot-preview[bot]

commit sha ffc78699b50aadab6e01cc14c5110a075af7cfb0

Bump github.com/stretchr/testify from 1.5.0 to 1.5.1 (#331) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.5.0 to 1.5.1. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](https://github.com/stretchr/testify/compare/v1.5.0...v1.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Eric Bottard

commit sha 65823b63a5d0e86f3d2ef9cb364702e4d88f39f8

Use CloudEvent aware components

view details

Eric Bottard

commit sha cd1f82ec35c9f2ebb3329f7498ec1c728a89d3c8

Use latest liiklus supporting CEs

view details

Eric Bottard

commit sha 5708ddf7affeaac9a84dba26a6ad45e2e0c48862

Use liiklus:latest that now supports cloudevents

view details

push time in a day

create barnchericbottard/streaming-http-adapter

branch : issue_22

created branch time in 2 days

Pull request review commentbsideup/liiklus

CloudEvents support

 message SubscribeRequest {      string group = 2; -    uint32 groupVersion = 4;+    uint32 group_version = 4; -    AutoOffsetReset autoOffsetReset = 3;+    AutoOffsetReset auto_offset_reset = 3;

Yes : https://developers.google.com/protocol-buffers/docs/style#message-and-field-names

This has the advantage of generating python-friendly names while preserving what was there for Java and other languages.

bsideup

comment created time in 2 days

create barnchericbottard/streaming-http-adapter

branch : issue_37

created branch time in 3 days

pull request commentbsideup/liiklus

CloudEvents support

I can confirm that I saw our headers transit all the way using extensions in Kafka. To me this PR is ready to go!

bsideup

comment created time in 3 days

push eventericbottard/streaming-processor

dependabot-preview[bot]

commit sha 3cef1e5dd892b26f938e1e1a881eee01f31f8388

Bump spring-boot-starter-parent from 2.2.2.RELEASE to 2.2.3.RELEASE Bumps spring-boot-starter-parent from 2.2.2.RELEASE to 2.2.3.RELEASE. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha f9480d5b0b368554bad6ea12b311255f7326504f

Bump spring-boot-starter-parent from 2.2.3.RELEASE to 2.2.4.RELEASE Bumps spring-boot-starter-parent from 2.2.3.RELEASE to 2.2.4.RELEASE. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 175d5eaa0a211a210b92fa237ad02195b0e0908f

Bump grpc.version from 1.24.1 to 1.27.0 (#41) Bumps `grpc.version` from 1.24.1 to 1.27.0. Updates `grpc-netty` from 1.24.1 to 1.27.0 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](https://github.com/grpc/grpc-java/compare/v1.24.1...v1.27.0) Updates `grpc-protobuf` from 1.24.1 to 1.27.0 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](https://github.com/grpc/grpc-java/compare/v1.24.1...v1.27.0) Updates `grpc-stub` from 1.24.1 to 1.27.0 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](https://github.com/grpc/grpc-java/compare/v1.24.1...v1.27.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Scott Andrews

commit sha 1a6c5835693ec54e66d0405d12b452f644b62627

Publish images to gcr instead of dockerhub (#43) - gcr.io/projectriff/streaming-processor/processor - gcr.io/projectriff/streaming-processor/processor-native

view details

Scott Andrews

commit sha afec5aa0d1d69a5293b73d83126f7c56784c727d

Bump version to 0.5.0-SNAPSHOT The processor is a component of riff and should share a most-significant version number.

view details

Scott Andrews

commit sha 53ea0783e0feaa18e27476937f1248e5dcc0f9da

bump version for development

view details

dependabot-preview[bot]

commit sha 560d966c576e518c1f7005bd20047c06afe54cf5

Bump grpc.version from 1.27.0 to 1.27.1 Bumps `grpc.version` from 1.27.0 to 1.27.1. Updates `grpc-netty` from 1.27.0 to 1.27.1 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](https://github.com/grpc/grpc-java/compare/v1.27.0...v1.27.1) Updates `grpc-protobuf` from 1.27.0 to 1.27.1 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](https://github.com/grpc/grpc-java/compare/v1.27.0...v1.27.1) Updates `grpc-stub` from 1.27.0 to 1.27.1 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](https://github.com/grpc/grpc-java/compare/v1.27.0...v1.27.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Eric Bottard

commit sha 87482cb4ca8ed633879abcb5e28ab8dd7a4172eb

Serialize messages as liiklus CloudEvents

view details

Eric Bottard

commit sha 5dc217082a7af9d02dd210b0ce44690737875e01

Support extensions

view details

push time in 6 days

pull request commentbsideup/liiklus

CloudEvents support

keep in mind that Riff-Rox is not a valid extension key AFAIK.

Using riffrox as a key (all lowercase, no dash) ends up in the same situation: the header is riffrox, and not ce-riffrox. Would you say this is expected?

When you say

that's something I wanted to fix

are you implying that liiklus writes the header, or are you relying on the (currently broken) sdk?

In any case, the values seem to propagate "correctly" from publication to Kafka.

bsideup

comment created time in 6 days

push eventericbottard/system

Scott Andrews

commit sha 47eeaf41eb9169eb8a24f97796d119a8fa0a9ebc

Check for owned conflicting resources (#312) When encountering an existing resource that causes a create to fail, lookup the resource to see if it is the child we wanted to create. This can happen due to a delay for existing resources getting into the informer cache. Changes include: - adding an APIReader to controller.Config for direct access to the api server bypassing the cache - adding APIGivenObjects to the reconciler table test case to populate a test api reader - detects failed creates due to an existing resource, looks up the conflicting resource directly on the api server and skips updating the parent's status if the conflict is the child Resolves #310

view details

Scott Andrews

commit sha 1afa1e8b223ac20f4b4c1cca11c2a274e0a0247a

Bump liiklus, provisioner and processor images resolve latest images from templates

view details

Scott Andrews

commit sha b65037a331bb01a24d96a5ce8a43fc374e97a824

Test pulsar (#316) Depends on https://github.com/bsideup/liiklus/pull/260 Refs https://github.com/projectriff/release/issues/136

view details

Scott Andrews

commit sha 0343ff03ceec6d39ddc69231e8231cfeb239a180

Downgrade controller-gen Restore compatibility with GKE

view details

Eric Bottard

commit sha 7ba9296fe888b7ad79c9254493a46fb679fb6947

Use latest 0.5.0-snapshot versions for components

view details

Eric Bottard

commit sha 41216869db6af5c40648c0e82e824a7d4529b588

Regenerate streaming yaml resources

view details

Scott Andrews

commit sha de2fa0e6568b9d8e3c3d5625f74451c796bf7210

bump version for development

view details

dependabot-preview[bot]

commit sha 369a64fd6ab12164c2cd4fa1782b9daf922e581d

Bump k8s.io/api from 0.17.2 to 0.17.3 (#322) * Bump k8s.io/api from 0.17.2 to 0.17.3 Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.17.2 to 0.17.3. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](https://github.com/kubernetes/api/compare/v0.17.2...v0.17.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump all k8s.io deps to v0.17.3 Co-authored-by: Scott Andrews <scott@andrews.me>

view details

dependabot-preview[bot]

commit sha 9dbf21e7c6ba8b69ea34c89061d41dcf5c525fe9

Bump sigs.k8s.io/controller-runtime from 0.4.0 to 0.5.0 (#327) * Bump sigs.k8s.io/controller-runtime from 0.4.0 to 0.5.0 Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.4.0 to 0.5.0. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.4.0...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * tidy Co-authored-by: Scott Andrews <scott@andrews.me>

view details

dependabot-preview[bot]

commit sha 3b5998952ad6cfe21a0756d22e25e56a2c5be948

Bump github.com/stretchr/testify from 1.4.0 to 1.5.0 (#329) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](https://github.com/stretchr/testify/compare/v1.4.0...v1.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Eric Bottard

commit sha 2caed6dbd2fee3302506bea63f6d1a2658dfbd0b

Use CloudEvent aware components

view details

Eric Bottard

commit sha c038a5d87723dbdaf376aa6cdf8b27302e91e808

Use latest liiklus supporting CEs

view details

push time in 8 days

pull request commentbsideup/liiklus

CloudEvents support

This is what I see when I set a Riff-Rox: true extension, I don't think this is mapped correctly (according to this):

kafkacat -b kafkabroker:9092 -t default_out -C \
  -f '\nKey (%K bytes): %k
  Value (%S bytes): %s
  Timestamp: %T
  Partition: %p
  Offset: %o
  Headers: %h\n'
% Reached end of topic default_out [0] at offset 12

Key (0 bytes):
  Value (1 bytes): 4
  Timestamp: 1582130904180
  Partition: 0
  Offset: 12
  Headers: ce_specversion=1.0,ce_id=54dcd19f-d73b-436f-b975-4e7626810eb9,ce_type=riff-event,Riff-Rox=true,ce_source=source-todo,ce_datacontenttype=application/json
% Reached end of topic default_out [0] at offset 13
bsideup

comment created time in 8 days

push eventericbottard/stream-client-go

Eric Bottard

commit sha 54f8737ff6c4e077d2759c0e57aad27423509bab

Add support for headers as extensions

view details

push time in 8 days

push eventericbottard/stream-client-go

Eric Bottard

commit sha 7e365f32670f80ecb7ef9b2d22f0de48412d917a

Add support for headers as extensions

view details

push time in 8 days

issue commentprojectriff/java-function-invoker

Not able to use "Message" in function signature

I created a testcase for that here.

I wonder what you think about this @olegz. Excluding the spring-messaging jar from the function doesn't seem to fix the issue (gotta admit I tried it without thinking much about it), so must be more subtle.

trisberg

comment created time in 8 days

create barnchericbottard/java-function-invoker

branch : issue_191

created branch time in 8 days

push eventprojectriff/java-function-invoker

Eric Bottard

commit sha 2de123a868e8179c7f87a82bcd82e4ed544361f4

Fail on on-data frame after first one

view details

push time in 13 days

push eventprojectriff/java-function-invoker

dependabot-preview[bot]

commit sha febd5b9c13ccc2e4a1478f74f5d8ffec1f887b70

Bump grpc.version from 1.27.0 to 1.27.1 Bumps `grpc.version` from 1.27.0 to 1.27.1. Updates `grpc-netty-shaded` from 1.27.0 to 1.27.1 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](https://github.com/grpc/grpc-java/compare/v1.27.0...v1.27.1) Updates `grpc-protobuf` from 1.27.0 to 1.27.1 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](https://github.com/grpc/grpc-java/compare/v1.27.0...v1.27.1) Updates `grpc-stub` from 1.27.0 to 1.27.1 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](https://github.com/grpc/grpc-java/compare/v1.27.0...v1.27.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 13 days

PR merged projectriff/java-function-invoker

Reviewers
Bump grpc.version from 1.27.0 to 1.27.1 dependencies

Bumps grpc.version from 1.27.0 to 1.27.1. Updates grpc-netty-shaded from 1.27.0 to 1.27.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-java/releases">grpc-netty-shaded's releases</a>.</em></p> <blockquote> <h2>v1.27.1</h2> <h2>Bug Fixes</h2> <ul> <li>alts: Fix using the wrong way of checking if Conscrypt is available (<a href="https://github-redirect.dependabot.com/grpc/grpc-java/issues/6672">#6672</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/grpc/grpc-java/commit/0b4fa21d50578d917f15dad41ca7a7ab2612356b"><code>0b4fa21</code></a> Bump version to 1.27.1</li> <li><a href="https://github.com/grpc/grpc-java/commit/2be7cc34c923c716175c6a6a3a91e33244e53069"><code>2be7cc3</code></a> Update README etc to reference 1.27.1</li> <li><a href="https://github.com/grpc/grpc-java/commit/2a836373a1de6505a7c63354fcdc8d1f3debac4a"><code>2a83637</code></a> alts: <em>Actually</em> use Conscrypt when available (<a href="https://github-redirect.dependabot.com/grpc/grpc-java/issues/6700">#6700</a>)</li> <li><a href="https://github.com/grpc/grpc-java/commit/772709833df51d114895ca9a647d6d9b01279f8a"><code>7727098</code></a> interop-testing: fix bug of xds test missing transitive dependency</li> <li><a href="https://github.com/grpc/grpc-java/commit/f0b2d77da8419423f43276d142142ddd40c25f29"><code>f0b2d77</code></a> interop-testing: fix bug for xds dependency not published yet</li> <li><a href="https://github.com/grpc/grpc-java/commit/467649ba0e6300eb348535c412b4e62a36537a9a"><code>467649b</code></a> Bump version to 1.27.1-SNAPSHOT</li> <li>See full diff in <a href="https://github.com/grpc/grpc-java/compare/v1.27.0...v1.27.1">compare view</a></li> </ul> </details> <br />

Updates grpc-protobuf from 1.27.0 to 1.27.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-java/releases">grpc-protobuf's releases</a>.</em></p> <blockquote> <h2>v1.27.1</h2> <h2>Bug Fixes</h2> <ul> <li>alts: Fix using the wrong way of checking if Conscrypt is available (<a href="https://github-redirect.dependabot.com/grpc/grpc-java/issues/6672">#6672</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/grpc/grpc-java/commit/0b4fa21d50578d917f15dad41ca7a7ab2612356b"><code>0b4fa21</code></a> Bump version to 1.27.1</li> <li><a href="https://github.com/grpc/grpc-java/commit/2be7cc34c923c716175c6a6a3a91e33244e53069"><code>2be7cc3</code></a> Update README etc to reference 1.27.1</li> <li><a href="https://github.com/grpc/grpc-java/commit/2a836373a1de6505a7c63354fcdc8d1f3debac4a"><code>2a83637</code></a> alts: <em>Actually</em> use Conscrypt when available (<a href="https://github-redirect.dependabot.com/grpc/grpc-java/issues/6700">#6700</a>)</li> <li><a href="https://github.com/grpc/grpc-java/commit/772709833df51d114895ca9a647d6d9b01279f8a"><code>7727098</code></a> interop-testing: fix bug of xds test missing transitive dependency</li> <li><a href="https://github.com/grpc/grpc-java/commit/f0b2d77da8419423f43276d142142ddd40c25f29"><code>f0b2d77</code></a> interop-testing: fix bug for xds dependency not published yet</li> <li><a href="https://github.com/grpc/grpc-java/commit/467649ba0e6300eb348535c412b4e62a36537a9a"><code>467649b</code></a> Bump version to 1.27.1-SNAPSHOT</li> <li>See full diff in <a href="https://github.com/grpc/grpc-java/compare/v1.27.0...v1.27.1">compare view</a></li> </ul> </details> <br />

Updates grpc-stub from 1.27.0 to 1.27.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-java/releases">grpc-stub's releases</a>.</em></p> <blockquote> <h2>v1.27.1</h2> <h2>Bug Fixes</h2> <ul> <li>alts: Fix using the wrong way of checking if Conscrypt is available (<a href="https://github-redirect.dependabot.com/grpc/grpc-java/issues/6672">#6672</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/grpc/grpc-java/commit/0b4fa21d50578d917f15dad41ca7a7ab2612356b"><code>0b4fa21</code></a> Bump version to 1.27.1</li> <li><a href="https://github.com/grpc/grpc-java/commit/2be7cc34c923c716175c6a6a3a91e33244e53069"><code>2be7cc3</code></a> Update README etc to reference 1.27.1</li> <li><a href="https://github.com/grpc/grpc-java/commit/2a836373a1de6505a7c63354fcdc8d1f3debac4a"><code>2a83637</code></a> alts: <em>Actually</em> use Conscrypt when available (<a href="https://github-redirect.dependabot.com/grpc/grpc-java/issues/6700">#6700</a>)</li> <li><a href="https://github.com/grpc/grpc-java/commit/772709833df51d114895ca9a647d6d9b01279f8a"><code>7727098</code></a> interop-testing: fix bug of xds test missing transitive dependency</li> <li><a href="https://github.com/grpc/grpc-java/commit/f0b2d77da8419423f43276d142142ddd40c25f29"><code>f0b2d77</code></a> interop-testing: fix bug for xds dependency not published yet</li> <li><a href="https://github.com/grpc/grpc-java/commit/467649ba0e6300eb348535c412b4e62a36537a9a"><code>467649b</code></a> Bump version to 1.27.1-SNAPSHOT</li> <li>See full diff in <a href="https://github.com/grpc/grpc-java/compare/v1.27.0...v1.27.1">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

1 comment

1 changed file

dependabot-preview[bot]

pr closed time in 13 days

push eventprojectriff/java-function-invoker

dependabot-preview[bot]

commit sha 47e41a5f81b3e4ad18f62f5459662da6add86e60

Bump spring-cloud-function.version Bumps `spring-cloud-function.version` from 3.0.2.BUILD-SNAPSHOT to 3.0.3.BUILD-SNAPSHOT. Updates `spring-cloud-function-dependencies` from 3.0.2.BUILD-SNAPSHOT to 3.0.3.BUILD-SNAPSHOT Updates `spring-cloud-function-deployer` from 3.0.2.BUILD-SNAPSHOT to 3.0.3.BUILD-SNAPSHOT - [Release notes](https://github.com/spring-cloud/spring-cloud-build/releases) - [Commits](https://github.com/spring-cloud/spring-cloud-build/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 14 days

PR merged projectriff/java-function-invoker

Reviewers
Bump spring-cloud-function.version from 3.0.2.BUILD-SNAPSHOT to 3.0.3.BUILD-SNAPSHOT dependencies

Bumps spring-cloud-function.version from 3.0.2.BUILD-SNAPSHOT to 3.0.3.BUILD-SNAPSHOT. Updates spring-cloud-function-dependencies from 3.0.2.BUILD-SNAPSHOT to 3.0.3.BUILD-SNAPSHOT

Updates spring-cloud-function-deployer from 3.0.2.BUILD-SNAPSHOT to 3.0.3.BUILD-SNAPSHOT <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/spring-cloud/spring-cloud-build/commits">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

2 comments

1 changed file

dependabot-preview[bot]

pr closed time in 14 days

push eventericbottard/invoker-specification

Eric Bottard

commit sha 0d44fbcc76005fa06ee40e4e6d3de59c00b23dad

Add more request-reply testcases, add Makefile

view details

push time in 14 days

push eventprojectriff/builder

Eric Bottard

commit sha 227ea45ceb4bd1452fb34825316c5d272bda6168

Use latest java|node buildpacks

view details

push time in 14 days

push eventprojectriff/node-function-buildpack

Eric Bottard

commit sha 8269d0ee88596e6580de0b912d8b6f6dce21a3b3

Use latest adapter that output build info at startup

view details

push time in 14 days

push eventprojectriff/java-function-buildpack

Eric Bottard

commit sha 49d6422c59d185f09ec816a93d1bd199ff9ab6ce

Use latest adapter that outputs build info at startup

view details

push time in 14 days

push eventprojectriff/streaming-http-adapter

Eric Bottard

commit sha b607f3d37585fe77b7c3a7a2ea5c96dac3f44c07

Print build info at start

view details

push time in 14 days

create barnchericbottard/streaming-http-adapter

branch : build_info

created branch time in 15 days

issue commentprojectriff/system

Relax stream alias uniqueness

@AElMehdi We don't need to. To clarify, the function that needs to change is validateStreamAliasUniqueness() in processor_validation.go

ericbottard

comment created time in 15 days

issue closedprojectriff/streaming-http-adapter

Only honor POSTs on /

Currently doesn't check the path

closed time in 15 days

ericbottard

issue commentprojectriff/streaming-http-adapter

Only honor POSTs on /

Fixed by f030c6c4f9d2efe83c436fdf48d4e561eb5ea778

ericbottard

comment created time in 15 days

push eventprojectriff/builder

Eric Bottard

commit sha 9f651b0d9791fb8c060bf3d8628f365d5827b590

Upgrade to latest invoker buildpacks

view details

push time in 16 days

push eventprojectriff/java-function-buildpack

Eric Bottard

commit sha bc06e2a495cdc1ef5d48d558ab8eccec3ff74141

Use latest snapshot versions of components

view details

push time in 16 days

pull request commentprojectriff/java-function-invoker

Leverage information from thrown SCF exceptions to comply with spec.

Merged as a5445ef021965223754fd668f245d61715e1ed98

ericbottard

comment created time in 16 days

push eventprojectriff/java-function-invoker

Eric Bottard

commit sha a5445ef021965223754fd668f245d61715e1ed98

Leverage information from thrown SCF exceptions to comply with spec.

view details

push time in 16 days

push eventericbottard/java-function-invoker

Eric Bottard

commit sha 4d188d385ddc3fa4f575944da7ca78763a74f113

Address review comments

view details

push time in 16 days

create barnchericbottard/java-function-invoker

branch : issue_187_contentTypeErrors

created branch time in 16 days

PR merged projectriff/stream-client-go

Reviewers
Streamline tests
  • drop "unit" job, it did absolutely nothing
  • drop FATS, it's overkill
  • run liiklus as a docker container
  • report coverage to codecov

Resolves #5

+22 -162

1 comment

4 changed files

scothis

pr closed time in 16 days

push eventprojectriff/stream-client-go

Scott Andrews

commit sha 0a80a0bb8381fae9184b833d55c8a99e518b0ee4

Streamline tests - drop "unit" job, it did absolutely nothing - drop FATS, it's overkill - run liiklus as a docker container - report coverage to codecov Resolves #5

view details

push time in 16 days

issue closedprojectriff/stream-client-go

simplify integration testing

The current integration tests install k8s and riff for testing. These tests should be lighter weight.

closed time in 16 days

sbawaska

push eventprojectriff/streaming-http-adapter

Florent Biville

commit sha c26fe12635006536ca584e95ef437d80c93025f3

Write headers before response payload Fixes #30.

view details

push time in 17 days

issue closedprojectriff/streaming-http-adapter

Response headers are discarded

Here is what happens with a locally running adapter and an uppercase function:

curl http://localhost:8080 -H'Content-Type:text/plain' -d'hello' -H'Accept:application/json' -v
[...]
< HTTP/1.1 200 OK
< Date: Mon, 10 Feb 2020 13:27:53 GMT
< Content-Length: 7
< Content-Type: text/plain; charset=utf-8
<
* Connection #0 to host localhost left intact
"HELLO"* Closing connection 0

Notice the payload is correct but the Content-Type is not.

closed time in 17 days

fbiville

push eventprojectriff/streaming-http-adapter

Florent Biville

commit sha f030c6c4f9d2efe83c436fdf48d4e561eb5ea778

Accept only / as path Fixes #32.

view details

push time in 17 days

PR merged projectriff/streaming-http-adapter

Reviewers
Accept only / as path

Fixes #32.

+23 -1

0 comment

2 changed files

fbiville

pr closed time in 17 days

issue closedprojectriff/streaming-http-adapter

Only "/" should be served

Currently, all paths are accepted.

closed time in 17 days

fbiville

push eventericbottard/invoker-specification

Eric Bottard

commit sha 04f7cab95d57682f87b9f7b545d3c427b37862e7

WIP

view details

push time in 17 days

push eventprojectriff/system

Eric Bottard

commit sha 41216869db6af5c40648c0e82e824a7d4529b588

Regenerate streaming yaml resources

view details

push time in 20 days

push eventprojectriff/system

Eric Bottard

commit sha 7ba9296fe888b7ad79c9254493a46fb679fb6947

Use latest 0.5.0-snapshot versions for components

view details

push time in 20 days

push eventprojectriff/kafka-provisioner

Scott Andrews

commit sha b23384e717a918ddb2f7b7d74dda36337a3fe41d

Switch base image to cf tiny

view details

push time in 20 days

push eventprojectriff/streaming-http-adapter

Scott Andrews

commit sha 3aa59ab1eff52d873c6a17cc78598d42fe896ce1

Bump version to 0.5.0-snapshot The adapter is a component of riff and should share a most-significant version number.

view details

push time in 20 days

PR merged projectriff/streaming-http-adapter

Reviewers
Bump version to 0.5.0-snapshot

The adapter is a component of riff and should share a most-significant version number.

+1 -1

0 comment

1 changed file

scothis

pr closed time in 20 days

push eventprojectriff/pulsar-provisioner

Scott Andrews

commit sha dd70fe6c03dd6d3db2e748427cd4f5744df7ec9d

Switch base image to cf tiny

view details

push time in 20 days

push eventprojectriff/k8s-manifest-scanner

Scott Andrews

commit sha 244f9d7209df7a5001822340e9adbc0765eb659f

Bump version to 0.5.0-snapshot The scanner is a component of riff and should share a most-significant version number.

view details

push time in 20 days

PR merged projectriff/k8s-manifest-scanner

Reviewers
Bump version to 0.5.0-snapshot

The scanner is a component of riff and should share a most-significant version number.

+1 -1

0 comment

1 changed file

scothis

pr closed time in 20 days

push eventprojectriff/streaming-processor

Scott Andrews

commit sha afec5aa0d1d69a5293b73d83126f7c56784c727d

Bump version to 0.5.0-SNAPSHOT The processor is a component of riff and should share a most-significant version number.

view details

push time in 20 days

PR merged projectriff/streaming-processor

Reviewers
Bump version to 0.5.0-SNAPSHOT

The processor is a component of riff and should share a most-significant version number.

+1 -1

0 comment

1 changed file

scothis

pr closed time in 20 days

push eventprojectriff/nop-provisioner

Scott Andrews

commit sha 112647e89e22c0067349add152c052da31c1c57a

Bump version to 0.5.0-snapshot The provisioner is a component of riff and should share a most-significant version number.

view details

push time in 20 days

PR merged projectriff/nop-provisioner

Reviewers
Bump version to 0.5.0-snapshot

The provisioner is a component of riff and should share a most-significant version number.

+1 -1

0 comment

1 changed file

scothis

pr closed time in 20 days

push eventprojectriff/pulsar-provisioner

Scott Andrews

commit sha a7418dcfefa28e3d0087050baa788788f5b7a47e

Bump version to 0.5.0-snapshot The provisioner is a component of riff and should share a most-significant version number.

view details

push time in 20 days

PR merged projectriff/pulsar-provisioner

Reviewers
Bump version to 0.5.0-snapshot

The provisioner is a component of riff and should share a most-significant version number.

+1 -1

0 comment

1 changed file

scothis

pr closed time in 20 days

PR merged projectriff/node-function-invoker

Reviewers
Cancel grpc invocation when sensible

Includes specific gRPC status errors for unsupported input/output MIME types (see https://github.com/projectriff/invoker-specification/issues/12 and https://github.com/projectriff/invoker-specification/issues/13).

The invocation is also canceled when an invalid signal sequence occurs or when the function throws at invocation time.


How to validate

Start the adapter

Make sure it includes https://github.com/projectriff/streaming-http-adapter/commit/b1bbbaf30f2e84a0e102fc144b251da108a0d656

 $ FUNCTION_URI=~/node-square/square.js NODE_DEBUG='riff' ./streaming-http-adapter npm --prefix ~/workspace/node-function-invoker start

Scenario 1: unsupported output content type

 $ curl http://localhost:8080 -d'4' -H'Content-Type: application/json' -H'Accept:text/zglorbf' -v
[...]
< HTTP/1.1 406 Not Acceptable
< Date: Wed, 05 Feb 2020 14:39:49 GMT
< Content-Length: 79
< Content-Type: text/plain; charset=utf-8
<
Invoker: Not Acceptable: Unsupported content-type 'text/zglorbf' for output #0

Scenario 2: unsupported output content type

 $ curl http://localhost:8080 -d'4' -H'Content-Type: application/jackson-five' -H'Accept:text/plain' -v
[...]
< HTTP/1.1 415 Unsupported Media Type
< Date: Wed, 05 Feb 2020 14:42:00 GMT
< Content-Length: 98
< Content-Type: text/plain; charset=utf-8
<
Invoker: Unsupported Media Type: Unsupported content-type 'application/jackson-five' for input #0

Scenario 3: another error

 $ curl http://localhost:8080 -d'invalid JSON' -H'Content-Type: application/json' -H'Accept:text/plain' -v
[...]
< HTTP/1.1 500 Internal Server Error
< Date: Wed, 05 Feb 2020 14:43:55 GMT
< Content-Length: 81
< Content-Type: text/plain; charset=utf-8
<
Invoker: Unexpected Error: SyntaxError: Unexpected token i in JSON at position 0
+283 -122

2 comments

13 changed files

fbiville

pr closed time in 21 days

push eventprojectriff/node-function-invoker

Florent Biville

commit sha 0945c63aebe2a14650933ff71b72068c87755c3d

Cancel grpc invocation when sensible Includes specific gRPC status errors for unsupported input/output MIME types (see https://github.com/projectriff/invoker-specification/issues/12 and https://github.com/projectriff/invoker-specification/issues/13). The invocation is also canceled when an invalid signal sequence occurs and when the function throws at invocation time.

view details

Florent Biville

commit sha 420235bc5c6d8fd94b389f7b85a6291d95566e70

Centralize error types and reserved error message prefixes

view details

Florent Biville

commit sha b49081481119fab3fc919da82343bf93d10d561b

Add a catch-all

view details

Florent Biville

commit sha 3a8b3021c281b88a5f7d044b4db77b04aa630c75

Improve output content type validation

view details

Florent Biville

commit sha d1843ef17a5bb6d6871732d0cedfa96084774ed2

Iterate over output content types only once when validating

view details

push time in 21 days

pull request commentprojectriff/system

[Coordinated, template] Use CloudEvent aware modules.

@ericbottard is this in scope for 0.5?

I would say no, although not really for me to decide. Also depends on the state of the liiklus PR. I would rather have us depend on a released version of liiklus for our releases.

cc @bsideup @jldec @markfisher

ericbottard

comment created time in 21 days

PR merged projectriff/system

Reviewers
Bump liiklus, provisioner and processor images

resolve latest images from templates

+78 -14

1 comment

11 changed files

scothis

pr closed time in 21 days

push eventprojectriff/system

Scott Andrews

commit sha 1afa1e8b223ac20f4b4c1cca11c2a274e0a0247a

Bump liiklus, provisioner and processor images resolve latest images from templates

view details

push time in 21 days

Pull request review commentbsideup/liiklus

CloudEvents support

+package com.github.bsideup.liiklus.records;++import io.cloudevents.v1.ContextAttributes;+import lombok.NonNull;++import java.util.HashMap;+import java.util.Locale;+import java.util.Map;++import static com.github.bsideup.liiklus.records.AttributeMapper.HEADER_PREFIX;++/**+ * See https://github.com/cloudevents/spec/blob/v1.0/kafka-protocol-binding.md+ */+class HeaderMapper {++    static final String CONTENT_TYPE = "content-type";++    public static Map<String, String> map(+            @NonNull Map<String, String> attributes,+            @NonNull Map<String, String> extensions+    ) {+        Map<String, String> result = new HashMap<>();++        extensions.forEach((key, value) -> {

Ah, my bad, I thought this was acting in place (which would cause concurrent modification anyway). So my other comment is moot too.

bsideup

comment created time in 22 days

Pull request review commentbsideup/liiklus

CloudEvents support

+package com.github.bsideup.liiklus.records;++import io.cloudevents.v1.ContextAttributes;+import lombok.NonNull;++import java.util.HashMap;+import java.util.Locale;+import java.util.Map;++import static com.github.bsideup.liiklus.records.AttributeMapper.HEADER_PREFIX;++/**+ * See https://github.com/cloudevents/spec/blob/v1.0/kafka-protocol-binding.md+ */+class HeaderMapper {++    static final String CONTENT_TYPE = "content-type";++    public static Map<String, String> map(+            @NonNull Map<String, String> attributes,+            @NonNull Map<String, String> extensions+    ) {+        Map<String, String> result = new HashMap<>();++        extensions.forEach((key, value) -> {

This is a NO-OP

bsideup

comment created time in 22 days

pull request commentbsideup/liiklus

CloudEvents support

Successfully tested this is the context of riff, using Kafka:

kafkacat -b kafkabroker:9092 -t default_out -C \
  -f '\nKey (%K bytes): %k
  Value (%S bytes): %s
  Timestamp: %T
  Partition: %p
  Offset: %o
  Headers: %h\n'
% Reached end of topic default_out [0] at offset 0

Key (0 bytes):
  Value (2 bytes): 10
  Timestamp: 1580910284299
  Partition: 0
  Offset: 0
  Headers: ce-source=proc,ce-specversion=1.0,ce-type=riff-event,ce-id=431ed262-4f61-4ced-9115-341e9f2473b3,Content-Type=application/json
bsideup

comment created time in 22 days

Pull request review commentprojectriff/dev-utils

[Coordinated, template] Use CloudEvent aware stream client

 require ( 	k8s.io/apimachinery v0.16.6 	k8s.io/client-go v0.16.6 )++replace github.com/projectriff/stream-client-go => github.com/ericbottard/stream-client-go v0.0.0-20200204150506-7cfb9bf48a59

Final version will not use this line but instead change the hash on line 6 above, once https://github.com/projectriff/stream-client-go/pull/15 is merged

ericbottard

comment created time in 22 days

PR opened projectriff/dev-utils

[Coordinated, template] Use CloudEvent aware stream client

For people willing to test only. The final changes will use different coordinates

+5 -2

0 comment

2 changed files

pr created time in 22 days

create barnchericbottard/dev-utils

branch : cloud-events

created branch time in 22 days

Pull request review commentprojectriff/system

[Coordinated, template] Use CloudEvent aware modules.

 metadata: --- apiVersion: v1 data:-  processorImage: projectriff/streaming-processor-native:1.0.0-SNAPSHOT-20191223112938-672714499ed0c511@sha256:41ad7b6b350370b5e53cc718eb7cde49d7f9f7e22e33a3204ae0a4158f798819+  processorImage: ericbottard/processor-native@sha256:9e1a16a68bd58e61c34e6bfc0af4c25fbd3f04fa2a045f0cd156c0ed71c8a641

Or wait for https://github.com/projectriff/streaming-processor/pull/42 to be merged

ericbottard

comment created time in 22 days

Pull request review commentprojectriff/system

[Coordinated, template] Use CloudEvent aware modules.

 subjects: --- apiVersion: v1 data:-  gatewayImage: bsideup/liiklus:0.9.0+  gatewayImage: ctr.run/github.com/bsideup/liiklus:00385b688bc34d6fdbe2b5eeb39daa26e09f8b02

Or wait for https://github.com/bsideup/liiklus/pull/252 to be merged and use a released version

ericbottard

comment created time in 22 days

PR opened projectriff/system

[Coordinated, template] Use CloudEvent aware modules.

This PR uses temporary coordinates, showcases where edits will be needed.

+8 -8

0 comment

5 changed files

pr created time in 22 days

create barnchericbottard/system

branch : cloud-events

created branch time in 22 days

push eventericbottard/streaming-processor

Eric Bottard

commit sha 5e39945b4797cfd50139768e396c9298c72c7937

Serialize messages as liiklus CloudEvents

view details

push time in 22 days

PR closed projectriff/streaming-http-adapter

Reviewers
Translate gRPC errors to 406 and 415 respectively

Fixes projectriff/invoker-specification#12. Fixes projectriff/invoker-specification#13.

+80 -4

2 comments

3 changed files

fbiville

pr closed time in 22 days

pull request commentprojectriff/streaming-http-adapter

Translate gRPC errors to 406 and 415 respectively

Merged as rebased b1bbbaf

fbiville

comment created time in 22 days

push eventprojectriff/streaming-http-adapter

Florent Biville

commit sha fada20153e783614f529b6159ede9a4a540d8fe4

Include debug symbols when building adapter

view details

Florent Biville

commit sha b1bbbaf30f2e84a0e102fc144b251da108a0d656

Translate gRPC errors to 406 and 415 respectively. Fixes https://github.com/projectriff/invoker-specification/issues/12. Fixes https://github.com/projectriff/invoker-specification/issues/13.

view details

push time in 22 days

issue closedprojectriff/invoker-specification

Specify behavior when output accepted type is not supported

If an output's accepted type is not supported, streaming invokers MUST craft a gRPC status error of code InvalidArgument and the error message MUST start with "Invoker: Not Acceptable". Invokers MAY append error details to that message prefix.

The streaming HTTP adapter must translate that error to 406 Not Acceptable.

closed time in 22 days

fbiville

issue closedprojectriff/invoker-specification

Specify behavior when input content type is not supported

If an input's content type is not supported, streaming invokers MUST craft a gRPC status error of code InvalidArgument and the error message MUST start with "Invoker: Unsupported Media Type". Invokers MAY append error details to that message prefix.

The streaming HTTP adapter must translate that error to 415 Unsupported Media Type.

closed time in 22 days

fbiville

Pull request review commentprojectriff/node-function-invoker

Cancel grpc invocation when sensible

 module.exports = class StreamingPipeline extends Writable {             logger('Ending input streams');             this._endInputs();         });-        this.on('error', () => {-            logger('Error occurred - ending pipeline now');-            this.end();+        this.on('error', (err) => {+            logger('Error occurred - canceling invocation now');+            this._cancelCall(grpcStream, err);         });         this._invokeHooks();         logger('Streaming pipeline initialized');     } +    _cancelCall(grpcStream, err) {+        switch (err.type) {+            case 'error-streaming-invalid-input-signal':+            case 'error-streaming-invalid-output-count':+            case 'error-streaming-missing-start-signal':+            case 'error-streaming-too-many-start-signals':+                grpcStream.call.cancelWithStatus(+                    grpc.status.UNKNOWN,+                    `Invoker: Protocol Violation: ${err.cause}`+                );+                break;+            case 'error-output-content-type-unsupported':+                grpcStream.call.cancelWithStatus(+                    grpc.status.INVALID_ARGUMENT,+                    `Invoker: Not Acceptable: ${err.cause}`+                );+                break;+            case 'error-input-content-type-unsupported':

Maybe all these error strings can be made constants too

fbiville

comment created time in 22 days

Pull request review commentprojectriff/node-function-invoker

Cancel grpc invocation when sensible

 module.exports = class StreamingPipeline extends Writable {             logger('Ending input streams');             this._endInputs();         });-        this.on('error', () => {-            logger('Error occurred - ending pipeline now');-            this.end();+        this.on('error', (err) => {+            logger('Error occurred - canceling invocation now');+            this._cancelCall(grpcStream, err);         });         this._invokeHooks();         logger('Streaming pipeline initialized');     } +    _cancelCall(grpcStream, err) {+        switch (err.type) {+            case 'error-streaming-invalid-input-signal':+            case 'error-streaming-invalid-output-count':+            case 'error-streaming-missing-start-signal':+            case 'error-streaming-too-many-start-signals':+                grpcStream.call.cancelWithStatus(+                    grpc.status.UNKNOWN,+                    `Invoker: Protocol Violation: ${err.cause}`+                );+                break;+            case 'error-output-content-type-unsupported':+                grpcStream.call.cancelWithStatus(+                    grpc.status.INVALID_ARGUMENT,+                    `Invoker: Not Acceptable: ${err.cause}`

Would be nice to extract the prefix, which is public API, in a const

fbiville

comment created time in 22 days

pull request commentprojectriff/streaming-http-adapter

Fix mockery on CI

I have the same version (arguably)

md5 `which mockery`
MD5 (/Users/ericbottard/Documents/Projects/go/bin/mockery) = c9a769459c556e94fa94b094dbe9406e

The changes are related to imports.

scothis

comment created time in 23 days

Pull request review commentbsideup/liiklus

CloudEvents support

         );     } +    default Wire<ByteBuffer, String, String> toWire(Envelope envelope) throws IllegalArgumentException {+        Object rawValue = envelope.getRawValue();++        if (!(rawValue instanceof CloudEvent)) {+            // TODO Add Envelope#event and make CloudEvent a fist-class citizen+            throw new IllegalArgumentException("Must be a CloudEvent!");

Trying this PR in the context of projectriff, it seems I'm always hitting this line. I'm sure I'm doing something wrong, but I don't know what yet.

bsideup

comment created time in 23 days

pull request commentprojectriff/streaming-http-adapter

Fix mockery on CI

The problem with the change in this PR (and the use of a Makefile var for MOCKERY) is that it always rebuilds mocks when running gen-mocks, which is what the Makefile was trying to avoid.

Also, I'm getting changes when running gen-mocks, is that expected?

scothis

comment created time in 23 days

push eventericbottard/stream-client-go

Eric Bottard

commit sha 1061e6159f72982ae1b0e58c074d286d1a6eacc8

Add ability to construct a StreamClient from a binding Fixes #6

view details

Swapnil Bawaskar

commit sha ad39ec9bb5aaec6f3a4042116b628fce62360e29

use kapp for cluster setup rather than helm (#9)

view details

Swapnil Bawaskar

commit sha 662831f7deb4240ce147418ae74dee7ffb98ea58

adding test for multiple subscribers (#8)

view details

Swapnil Bawaskar

commit sha 15a279312c0396bac9c5317e6686013fa19400b2

use a bool to read from the beginning of the stream liiklus does not support explicit offset currently. Also see this rfc: https://github.com/projectriff/riff/pull/1367

view details

trisberg

commit sha ee3ba654551c6e78e16bdc4589c92a95b3b2d29f

Update release artifact location

view details

Scott Andrews

commit sha 98f17bcb3df68b854e2ab16486143e0fb0735623

Fix tests - consume latest riff cli - consume latest FATS - uninstall components before deleting cluster

view details

Scott Andrews

commit sha 2744e85512a3a573185b3ca90a614d8a9f8ac5c0

make script executable

view details

Scott Andrews

commit sha 1838e41da129d869ea3b63f92cc04387ae86c4f1

make clean up a good faith attempt

view details

Scott Andrews

commit sha 0d60e2942a0d2e051c85b2af29b285788ef08111

Merge pull request #13 from scothis/bump-fats Fix tests

view details

dependabot-preview[bot]

commit sha 3defd6c9e8dd3cbb4dbe6b2fd9ac39b79d04386c

Bump github.com/golang/protobuf from 1.3.2 to 1.3.3 Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.3.2 to 1.3.3. - [Release notes](https://github.com/golang/protobuf/releases) - [Commits](https://github.com/golang/protobuf/compare/v1.3.2...v1.3.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Scott Andrews

commit sha 1d5fd850088063a405f53762d9e54b955f02dd87

Merge pull request #12 from projectriff/dependabot/go_modules/github.com/golang/protobuf-1.3.3 Bump github.com/golang/protobuf from 1.3.2 to 1.3.3

view details

dependabot-preview[bot]

commit sha 5a8ee76d07880bdecbc8cb4c01e343086718def5

Bump google.golang.org/grpc from 1.24.0 to 1.27.0 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.24.0 to 1.27.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.24.0...v1.27.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Scott Andrews

commit sha 6e1996befa308a8acbb50f04ee7388cf59151d3c

Merge pull request #11 from projectriff/dependabot/go_modules/google.golang.org/grpc-1.27.0 Bump google.golang.org/grpc from 1.24.0 to 1.27.0

view details

Scott Andrews

commit sha b0f81b40a96f7da1d095e00b3d1ca1f7999d6104

Test each gateway (#14) - add tests with inmemory and pulsar gateways (pulsar is a work in progress) - receive messages from each partition, not just the first partition - use appropriate topic names in tests

view details

Eric Bottard

commit sha 7cfb9bf48a593aa25911f09b91ce3269200a332d

Support CloudEvents from liiklus

view details

push time in 23 days

fork ericbottard/dev-utils

tools for developing/debugging using riff

fork in 23 days

create barnchericbottard/stream-client-go

branch : cloud-events

created branch time in 23 days

create barnchericbottard/streaming-processor

branch : cloud-events

created branch time in 23 days

Pull request review commentprojectriff/invoker-specification

Marshalling

 message OutputFrame {  ### OutputFrame `OutputFrames` represent data coming out of the function. Upon reception of a result data structure on the j-th output stream of a function, an invoker-1. MUST serialize the data structure to a series of bytes (hereafter the `OutputFrame payload`) by selecting a MIME type that is compatible with the preference ordered list of MIME types specified in the j-th string of `expectedContentTypes` seen in the [`StartFrame`](#StartFrame). As a consequence, the invoker MUST not send any `OutputFrames` until it has received the `StartFrame`. -2. If it cannot successfully serialize data using such a MIME type, then it MUST fail this rpc invocation-3. Otherwise, it MUST set the value of the `payload` field of the frame to the byte representation of the data, and the `contentType` field to the *concrete* MIME type that was selected for serialization-4. MUST set the `resultIndex` field of the frame to `j`-5. MAY set additional custom `headers`.+1. MUST serialize the data structure to a series of bytes (hereafter the `OutputFrame payload`) by selecting a MIME type that is compatible with the preference ordered list of MIME types specified in the j-th string of `expectedContentTypes` seen in the [`StartFrame`](#StartFrame). As a consequence, the invoker MUST not send any `OutputFrames` until it has received the `StartFrame`.+2. If such a MIME type is not supported, then it MUST fail this rpc invocation with a crafted status error of code [InvalidArgument](https://github.com/grpc/grpc/blob/2a7191abe717d3ce33b5fcbfd6bd118367499cde/doc/statuscodes.md#status-codes-and-their-use-in-grpc) and the error message MUST start with `"Invoker: Not Acceptable"`. An invoker MAY append error details to that message prefix. These details SHOULD start with punctuation to separate them from the error message prefix.+3. If it cannot otherwise successfully serialize data using such a MIME type, then it MUST fail this rpc invocation

Yes, UNKNOWN is the default and seems sensible for this case

fbiville

comment created time in 23 days

more