ericbarnhill ( Eric Barnhill )

Eric Barnhill ericbarnhill San Francisco, California http://linkedin.com/in/ericbarnhill Biomedical scientist and engineer, San Francisco bay area. Data science, signal processing, software engineering. PhD in MRI. Committer, Apache Software Fdn.

repos

gists

followers

following

ericbarnhill/JVCL 2

Methods for faster convolutions in Java including vectorized methods, GPU methods, and FFT methods

ericbarnhill/barnhill-ij-toolkit 1

Collection of tools to enhance Fiji and ImageJ workflow, with particular focus on the MIJ (Matlab to ImageJ) interface

ericbarnhill/deepMRE 1

Repository for notebooks and scripts pertaining to using deep learning in Magnetic Resonance Elastography

ericbarnhill/phaseTools 1

4D rapid unwrapping software for ImageJ and Fiji. If you use in your research, please cite associated paper 10.1002/mrm.25332

ericbarnhill/altair 0

Declarative statistical visualization library for Python

ericbarnhill/bioformats 0

Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the Open Microscopy Environment (particularly UW-Madison LOCI and Glencoe Software). Bio-Formats is released under the GNU General Public License (GPL); commercial licenses are available from Glencoe Software.

ericbarnhill/commons-lang 0

Mirror of Apache Commons Lang

ericbarnhill/commons-math 0

Mirror of Apache Commons Math

ericbarnhill/commons-numbers 0

Mirror of Apache Commons Complex Numbers

ericbarnhill/commons-statistics 0

Mirror of Apache Commons Statistics

push eventapache/commons-numbers

Gary Gregory

commit sha 63d0309db75f6841e2e6f875ca336a542e2bfcac

Use isEmpty().

view details

Gary Gregory

commit sha e33b2ae6b1a70e51cf0d943eb4a291a3695a5f2a

Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-numbers.git

view details

push time in 3 days

push eventapache/commons-numbers

Alex Herbert

commit sha dce272036fd06c579bd4c7e003274af07bbfac69

Update NOTICE to 2021

view details

push time in 12 days

push eventapache/commons-statistics

Alex Herbert

commit sha ba67542b8df7b98744f6ca92671a1cb33f658e91

Update NOTICE to 2021

view details

push time in 12 days

pull request commentapache/commons-graph

[SANDBOX-511] Minor Improvement commons-graph

HI @kinow Check this --> https://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/

arturobernalg

comment created time in 25 days

pull request commentapache/commons-numbers

Minor Improvement:

This is my pitch for using final: https://www.google.com/amp/s/garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/

arturobernalg

comment created time in a month

pull request commentapache/commons-numbers

Minor Improvement:

The 'final' status of parameters is enforced in the project using PMD rules: AvoidReassigningParameters. However we have avoided using final in the code as it adds visual noise to the source code and the PMD rule MethodArgumentCouldBeFinal is disabled. There is no benefit of final method arguments to the JVM compiler, which knows about effectively final variables for example those that can be referenced inside lambda statements.

As such it is difficult to see what other modifications are in the PR. Can you remove the use of final for method arguments and then it will be clear what is left?

The use of final for method params is a style choice and you can raise this on the dev mailing list to start a discussion about what is preferred.

arturobernalg

comment created time in a month

pull request commentapache/commons-numbers

Minor Improvement:

Coverage remained the same at 99.637% when pulling b7283ed175c1c225f4cfce7f84e57f5ec67f75dc on arturobernalg:feature/minor_improvement into 134133bf7e556e3e5ff631bea0bc350c73d48ae8 on apache:master.

arturobernalg

comment created time in a month

PR opened apache/commons-numbers

Minor Improvement:

commons-number
Add final
Unnecessary semicolon

+825 -823

1 commit in arturobernalg/commons-numbers/tree/feature/minor_improvement apache/commons-numbers/tree/master

0 comment

80 changed files

pr created time in a month

pull request commentapache/commons-graph

[SANDBOX-511] Minor Improvement commons-graph

I just think it can be good practice.

arturobernalg

comment created time in a month

pull request commentapache/commons-graph

[SANDBOX-511] Minor Improvement commons-graph

IMO on type ensure that the reference will never change. For the values types it will ensure that the value cannot change. If you check some of the other apache commons modules you can see that they follow the same approach.

Yup, there are many modules in Commons that use final. I use it to ensure immutability in some objects. But not everyone writes

public void methodA(final param1, final param2) {
  return param1 + param2;
}

Some projects may enforce it. But as far as I am aware, we have nothing in Commons, nor in Commons Graph. So reviewers would have to inspect each PR to ensure the code was consistent in using the final modifiers.

Otherwise, in a few months/years, the code would have a few methods and local variables without the final, and we would need to keep updating the code again, chasing for variables missing the final modifier.

Let's leave it open and see if others prefer to use the final modifier everywhere it's possible in Graph (ping @garydgregory ?).

-Bruno

arturobernalg

comment created time in a month

pull request commentapache/commons-graph

[SANDBOX-511] Minor Improvement commons-graph

IMO on type ensure that the reference will never change. For the values types it will ensure that the value cannot change. If you check some of the other apache commons modules you can see that they follow the same approach.

arturobernalg

comment created time in a month

PR closed apache/commons-graph

Minor Improvement