profile
viewpoint

apple/swift 51848

The Swift Programming Language

apple/llvm-project 199

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. This fork is used to manage Apple’s stable releases of Clang as well as support the Swift project.

ematejska/community 0

Stores documents used by the TensorFlow developer community

ematejska/swift 0

The Swift Programming Language

ematejska/swift-1 0

Swift for TensorFlow Project Home Page

ematejska/swift-apis 0

Swift for TensorFlow Deep Learning Library

ematejska/swift-evolution 0

This maintains proposals for changes and user-visible enhancements to the Swift Programming Language.

ematejska/swift-lldb 0

This is the version of LLDB that supports the Swift programming language & REPL.

ematejska/swift-source-compat-suite 0

The infrastructure and project index comprising the Swift source compatibility suite.

ematejska/tensorflow 0

An Open Source Machine Learning Framework for Everyone

push eventapple/swift

Saleem Abdulrasool

commit sha c6cc769a64c58cc820ce76699275cae5e9dd6e95

build: default the lld/gold enabling as per reality Rather than defaulting both of these to true, enable gold by default only on ELFish targets, and enable LLD by default for Windows on non-Windows hosts.

view details

Owen Voorhees

commit sha f00953c62d36c0d89b8dd8d4e0afb22bd7c07fef

[Diags-Experimental-Formatting] Fixes for printing diagnostics when #sourceLocation is used - Always use the line number in the actual source file when extracting excerpts and adding highlights/fix-its - Always use the display name when printing excerpt titles - Don't print surrounding lines when an annotated line is in a virtual file This reverts commit f919e047834eddf8863723b9db1fcb8d344d2006.

view details

Owen Voorhees

commit sha 96696c88231bebe3ed65ce164bd59bf8c94f9432

[Diag-Experimental-Formatting] Add a formatting test for Swift diags emitted in clang virtual files

view details

David Goldman

commit sha 40759df737166167422824d2d2ea678247a1a25d

[SourceKit] Include operation kind in compile notifications - Compile will start / did finish now includes the operation kind (perform sema or code complete). - See also https://forums.swift.org/t/sourcekit-lsp-file-status-ux/35947

view details

David Goldman

commit sha 67a2fe494a0eb4827bfe4e14116b521c4293eb97

Fix up compile operation kind - `key.compile_operation` instead of `key.compileoperation` - Make the operation kind optional (nothing emitted for perform sema)

view details

Pavel Yaskevich

commit sha 3e9e253acb038c32a4b9f43789bf2a49a371142a

[ConstraintSystem] Add a new locator element - `argument attribute` `ArgumentAttribute` points to a particular attribute associated with one of the arguments e.g. `inout` or its type e.g. `@escaping`. This is very useful when dealing with argument-to-parameter failures because it allows to express in the locator kind of a problem.

view details

Pavel Yaskevich

commit sha 3efa052aae8d03b0795f0e8948f970ff14502975

[Diagnostics] Adjust r-value -> l-value diagnostic to account for `ArgumentAttribute`

view details

Pavel Yaskevich

commit sha 9347a091e112b8d65b723f917c1e9ce88344c7c4

[ConstraintSystem] Adjust `getCalleeLocator` and `simplifyLocator` to handle `ArgumentAttribute` - `getCalleeLocator`, if given locator ends at `ArgumentAttribute` strip the last element which makes sure that produced locator always refers directly to argument-to-parameter conversion. - `simplifyLocator`, always leave `ArgumentAttribute` in the path because it's useful for diagnostics.

view details

Pavel Yaskevich

commit sha 5db1c70cd019f57ff59149a978bb7300b2de3307

[CSFix] Extend locator with `ArgumentAttribute` for escaping/inout fixes If either `MarkExplicitlyEscaping` or `TreatRValueAsLValue` fix points to an argument-to-parameter conversion, let's add more more clarifying argument to the locator to pinpoint the problem.

view details

Greg Titus

commit sha 6216242c9cb77423bf355db9876910a874d4ac5e

If the missing generic requirement includes type variables, don't emit an unhelpful note for it. Fixes SR-12759

view details

Hamish Knight

commit sha 917c937fc9bba57b5891169efea79ae8f51452aa

Allow shadowing checks to deal with operator decls Add overloads of `removeShadowedDecls` that deal with operator and precedencegroup decls, and template the existing shadowing logic such that it can process them.

view details

Hamish Knight

commit sha 54df0a4e8d0fe3000eb4972b13212486f3fbe5ee

[Frontend] Add flag to enable new operator lookup For now disabled by default, but once we get a new language mode, we should flip it on by default.

view details

Hamish Knight

commit sha 912baa8a8b503b723cfb36576202cf23bd73eeba

[Serialization] Use direct operator lookup for xrefs We don't need to look at re-exports when resolving cross references. Luckily the old lookup logic didn't, but the new logic will. Therefore switch it over to calling the appropriate request for a direct operator lookup. In addition, return a deserialization error instead of silently returning nullptr if the lookup fails.

view details

Hamish Knight

commit sha cc062ee2bb96c4624dc787e394f021f5258ae804

Fix precedencegroup and operator decl lookup Re-implement operator and precedencegroup decl lookup to use `namelookup::getAllImports` and existing decl shadowing logic. This allows us to find operator decls through `@_exported` imports, prefer operator decls defined in the same module over imported decls, and fixes a couple of other subtle issues. Because this new implementation is technically source breaking, as we can find multiple results where we used to only find one result, it's placed behind the new Frontend flag `-enable-new-operator-lookup` (with the aim of enabling it by default when we get a new language mode). However the new logic will always be used if the result is unambiguous. This means that e.g `@_exported` operators will be instantly available as long as there's only one candidate. If multiple candidates are found, we fall back to the old logic. Resolves SR-12132. Resolves rdar://59198796.

view details

Hamish Knight

commit sha e7cb6bb48c3b94b798309fd8d48d049a27905cee

[Sema] Diagnose cross-file operator redeclarations Previously we permitted operator redeclarations across files as the user could shadow imported operator decls on a per-file basis, and we would prefer an imported operator decl over one in another file. However with the new operator lookup implementation, operators in the current module always shadow imported decls. As such, we should start diagnosing cross-file redeclarations when the new lookup logic is enabled. Resolves rdar://48731166

view details

Suyash Srijan

commit sha 14a2d265ea2cd76c3c3d9729f528956499763b2f

[SIL] Use Limit::OnDemand for an enum element in SILDeclRef::getLinkage

view details

Suyash Srijan

commit sha 233b9a35679f01089b1e00cc7ab39338d0e18a9f

[TBDGen] Emit case symbols only if enum is resilient and some other fixes (1) Pass property getter as requirement when the witness is an payload-less enum case (2) Remove dead code from visitEnumDecl

view details

Suyash Srijan

commit sha 6cdb54018a4eb939fd3cead3d74718f9f499347f

[Test] Add some TBDGen test cases for enum case witnesses

view details

Greg Titus

commit sha d764fe8ae06f82c69a13f2d685b9a922bfb8cf2b

Pass down solution to simplify types, and map missingType to translate taus to generic param names for emissions.

view details

Robert Widmann

commit sha 4c5d87e07cb34ce89c9727efc262bb98fd485026

[Gardening] Move options setup code into argument parsing

view details

push time in a day

delete branch apple/swift

delete branch : tensorflow-merge

delete time in a day

PR merged apple/swift

Merge swift-DEVELOPMENT-SNAPSHOT-2020-05-26-a into tensorflow tensorflow
+9118 -3466

3 comments

474 changed files

ematejska

pr closed time in a day

push eventapple/llvm-project

Tony Allevato

commit sha 0f6908ee5451a3391208a1b947db07068a31f150

Define SWIFT_INLINE_NAMESPACE for swiftDemangling inclusions. https://github.com/apple/swift/pull/30733 will begin requiring this in a change that allows the swiftDemangling symbols to be conditionally renamed using an inline namespace so that compiler and runtime symbols don't collide if statically linked in the same binary. The namespace `compiler` was chosen for lldb since that's what would have been used if its build was properly inheriting the public definition from the Swift CMake target.

view details

Raphael Isemann

commit sha 59d31bcb4f62ad2e2a08a0c3c9c265ce2963baa2

[lldb] Don't complete ObjCInterfaceDecls in ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName Summary: For ObjCInterfaceDecls, LLDB iterates over the `methods` of the interface in FindExternalVisibleDeclsByName since commit ef423a3ba57045f80b0fcafce72121449a8b54d4 . However, when LLDB calls `oid->methods()` in that function, Clang will pull in all declarations in the current DeclContext from the current ExternalASTSource (which is again, `ClangExternalASTSourceCallbacks`). The reason for that is that `methods()` is just a wrapper for `decls()` which is supposed to provide a list of *all* (both currently loaded and external) decls in the DeclContext. However, `ClangExternalASTSourceCallbacks::FindExternalLexicalDecls` doesn't implement support for ObjCInterfaceDecl, so we don't actually add any declarations and just mark the ObjCInterfaceDecl as having no ExternalLexicalStorage. As LLDB uses the ExternalLexicalStorage to see if it can complete a type with the ExternalASTSource, this causes that LLDB thinks our class can't be completed any further by the ExternalASTSource and will from on no longer make any CompleteType/FindExternalLexicalDecls calls to that decl. This essentially renders those types unusable in the expression parser as they will always be considered incomplete. This patch just changes the call to `methods` (which is just a `decls()` wrapper), to some ad-hoc `noload_methods` call which is wrapping `noload_decls()`. `noload_decls()` won't trigger any calls to the ExternalASTSource, so this prevents that ExternalLexicalStorage will be set to false. The test for this is just adding a method to an ObjC interface. Before this patch, this unset the ExternalLexicalStorage flag and put the interface into the state described above. In a normal user session this situation was triggered by setting a breakpoint in a method of some ObjC class. This caused LLDB to create the MethodDecl for that specific method and put it into the the ObjCInterfaceDecl. Also `ObjCLanguageRuntime::LookupInCompleteClassCache` needs to be unable to resolve the type do an actual definition when the breakpoint is set (I'm not sure how exactly this can happen, but we just found no Type instance that had the `TypePayloadClang::IsCompleteObjCClass` flag set in its payload in the situation where this happens. This however doesn't seem to be a regression as logic wasn't changed from what I can see). The module-ownership.mm test had to be changed as the only reason why the ObjC interface in that test had it's ExternalLexicalStorage flag set to false was because of this unintended side effect. What actually happens in the test is that ExternalLexicalStorage is first set to false in `DWARFASTParserClang::CompleteTypeFromDWARF` when we try to complete the `SomeClass` interface, but is then the flag is set back to true once we add the last ivar of `SomeClass` (see `SetMemberOwningModule` in `TypeSystemClang.cpp` which is called when we add the ivar). I'll fix the code for that in a follow-up patch. I think some of the code here needs some rethinking. LLDB and Clang shouldn't infer anything about the ExternalASTSource and its ability to complete the current type form the `ExternalLexicalStorage` flag. We probably should also actually provide any declarations when we get asked for the lexical decls of an ObjCInterfaceDecl. But both of those changes are bigger (and most likely would cause us to eagerly complete more types), so those will be follow up patches and this patch just brings us back to the state before commit ef423a3ba57045f80b0fcafce72121449a8b54d4 . Fixes rdar://63584164 Reviewers: aprantl, friss Subscribers: arphaman, abidh, JDevlieghere Differential Revision: https://reviews.llvm.org/D80556 (cherry picked from commit 83d523b62d1a02f50be4a691ed578cb226ff3a92)

view details

Raphael Isemann

commit sha 18b06f6a7ec6d3f8393cb3861dd3d80c088f0f67

Revert "[lldb/Test] XFAIL TestDataFormatterObjCNSError except for gmodules." This reverts commit 07e680a59f96fc792583eb567ef1f48c4b66194b. The test was fixed by D80556. The test originally broke because of commit ef423a3ba570 .

view details

Adrian Prantl

commit sha b8fe1f678a1e40ac7cda147f9b0570cc03f9086c

Debug Info: Mark os_log helper functions as artificial The os_log helper functions are linkonce_odr and supposed to be uniqued across TUs, so attachine a DW_AT_decl_line on it is highly misleading. By setting the function decl to implicit, CGDebugInfo properly marks the functions as artificial and uses a default file / line 0 location for the function. rdar://problem/63450824 Differential Revision: https://reviews.llvm.org/D80463 (cherry picked from commit b59b3640bcbdfc6cf4b35ff3a6ad5f524a073b45)

view details

Adrian Prantl

commit sha 7b8129610059eb77fd18598051e91ff4f373c9ac

Disable ptr_ref tests under ASAN (cherry picked from commit 2af2bc33d36f97b43bbad33286d6ec81e6d7afad)

view details

Adrian Prantl

commit sha 461cbbdd0dc71a0d0bf81701393e50600446c5e4

Disable malloc stepping test under ASAN. The output is different and I'm not sure how stable it is. (cherry picked from commit a62a5200445abddd5a559a4dee2db0cc545eab5b)

view details

Adrian Prantl

commit sha a411d8ccd4c19677e2d951725f9ed7a4b215028c

Move decorator to the correct function. (cherry picked from commit 60dff35fd435e5c5b434091019a78183260552be)

view details

fredriss

commit sha 552360332bb94533e495ac0fd253a13c2779ca4d

Merge pull request #1263 from adrian-prantl/disable-asan-tests Cherry-pick: disable LLDB tests under asan that don't work under asan

view details

Adrian Prantl

commit sha ea02c6cf8cb893ef5854420dc01c0b45cbedcd8e

Let @skipUnlessAddressSanitizer imply @skipIfAsan Don't run tests that use address sanitizer inside an address-sanitized LLDB. The tests don't support that configuration. Incidentally they were skipped on green dragon for a different reason, so this hasn't come up there before. (cherry picked from commit 09de6e0fbd0b6ca7fa8760ac3513be6bbbba5a81) Conflicts: lldb/packages/Python/lldbsuite/test/decorators.py

view details

fredriss

commit sha 62eba3ff3745e370572a1b95d514688fbf1e6cab

Merge pull request #1264 from adrian-prantl/disable-asan-asan Let @skipUnlessAddressSanitizer imply @skipIfAsan

view details

Vedant Kumar

commit sha 15919fba7efae84b0c266c3946122863b44de261

[DwarfExpression] Support entry values for indirect parameters Summary: A struct argument can be passed-by-value to a callee via a pointer to a temporary stack copy. Add support for emitting an entry value DBG_VALUE when an indirect parameter DBG_VALUE becomes unavailable. This is done by omitting DW_OP_stack_value from the entry value expression, to make the expression describe the location of an object. rdar://63373691 Reviewers: djtodoro, aprantl, dstenb Subscribers: hiraditya, lldb-commits, llvm-commits Tags: #lldb, #llvm Differential Revision: https://reviews.llvm.org/D80345

view details

fredriss

commit sha 2c22fbb14f75cb57e8582e4ef8ae93d034855940

Merge pull request #1259 from Teemperor/DontEarlyCompleteObjCInterfaces Backport D80556 to incomplete ObjCInterfaceDecls

view details

adrian-prantl

commit sha bec0e22d060dd54784869bac964e5ffa083b1dbe

Merge pull request #1261 from adrian-prantl/63450824 Debug Info: Mark os_log helper functions as artificial

view details

Jonas Devlieghere

commit sha 685d95bc30feb05c349e1c9ae34cc3aa6b35520c

[lldb/Docs] Add the application speicfic lldbinit to the man page This used to be part of the man page but got lost when we moved to generating it with Sphinx. (cherry picked from commit 40c4ecabc238cfdd639bc1e927800337457e69e3)

view details

fredriss

commit sha 85649e1dfaefc2871fa5fd68acf324a6eba5a461

Merge pull request #1266 from JDevlieghere/lldbinit-man-page [lldb/Docs] Add the application speicfic lldbinit to the man page

view details

git apple-llvm automerger

commit sha 2a444822911aae066c7f62715fc06054dc35fb9d

Merge commit '0c04ff8853f6' from swift/release/5.3 into swift/master

view details

Adrian Prantl

commit sha 0c04ff8853f6fb3139e6391733518df51ce905c1

Merge commit '85649e1dfaef' from apple/stable/20200108 into swift/release/5.3 Conflicts: lldb/packages/Python/lldbsuite/test/decorators.py

view details

Hamish Knight

commit sha 1daf53c337902a0129c9436ea3b3c56cc888fd6e

[lldb] Update call to performSILGeneration

view details

Adrian Prantl

commit sha 8f6e1bacacc07badd1b271f751cbf4f58981db21

Fix a use-after-free

view details

TensorFlow SyncBot

commit sha b427de9f1ec3588bffbf1127c966f281c05e291b

Merge remote-tracking branch 'github/swift/master' into HEAD

view details

push time in a day

push eventtensorflow/swift-apis

ematejska

commit sha 219b7c3283322c297f14d5b48b98a5b09c27151d

Hides the symbols except for those that are marked as visible (#957) * Hides the symbols except for those that are marked as visible. This fixes the immediate mode issue when the TensoFlow modules was used with swift because the symbols are not being loaded thice for llvm. * Updating visiblity to __visibility__ * Updating visiblity to __visibility__ * Updating visiblity to __visibility__

view details

push time in a day

PR merged tensorflow/swift-apis

Hides the symbols except for those that are marked as visible

This fixes the immediate mode issue when the TensoFlow modules was used with swift because the symbols are not being loaded twice for llvm.

https://bugs.swift.org/projects/TF/issues/TF-1273

+9 -2

5 comments

4 changed files

ematejska

pr closed time in a day

Pull request review commenttensorflow/swift-apis

[WIP] Hides the symbols except for those that are marked as visible

 #if defined(_WIN32) #define XLA_API __declspec(dllexport) #else-#define XLA_API+#define XLA_API __attribute__((visibility("default")))

Done

ematejska

comment created time in 3 days

push eventematejska/swift-apis

ematejska

commit sha 045313ba9848f54e910cd2a6c6007fb764a24191

Updating visiblity to __visibility__

view details

push time in 3 days

push eventematejska/swift-apis

ematejska

commit sha 72229ec047e727f3912149ae88788f035faaf8ba

Updating visiblity to __visibility__

view details

push time in 3 days

push eventematejska/swift-apis

ematejska

commit sha 34778e19ffc0a8de8e23fecb7a31fa2a2e1fe53b

Updating visiblity to __visibility__

view details

push time in 3 days

pull request commenttensorflow/swift-apis

[WIP] Hides the symbols except for those that are marked as visible

Removed reliance of TFE_GetServerDef here: https://github.com/tensorflow/swift-apis/pull/976. If testing passes, we're good to merge.

ematejska

comment created time in 3 days

push eventtensorflow/swift-apis

ematejska

commit sha fa373f346853a49c02b2cbcb3b2bdf86c5bbbcb5

Removing reliance on experimental TF_GetServerDef TensorFlow api (#976) * Removing reliance on experimental TF_GetServerDef TensorFlow api * Turning off for windows until I can run a windows build to verify it will work.

view details

push time in 3 days

PR merged tensorflow/swift-apis

Reviewers
Removing reliance on experimental TF_GetServerDef TensorFlow api kokoro:run

Removing reliance on experimental TF_GetServerDef TensorFlow api.

This will unblock: https://github.com/tensorflow/swift-apis/pull/957 Part of: https://github.com/tensorflow/swift-apis/issues/970

+6 -8

2 comments

1 changed file

ematejska

pr closed time in 3 days

push eventematejska/swift-apis

ematejska

commit sha 3fde83544478e23b0a495b5d967250c9d44602b8

Turning off for windows until I can run a windows build to verify it will work.

view details

push time in 3 days

pull request commentapple/swift

Merge swift-DEVELOPMENT-SNAPSHOT-2020-05-26-a into tensorflow

@swift-ci Please clean test TensorFlow

ematejska

comment created time in 3 days

pull request commentapple/swift

Merge swift-DEVELOPMENT-SNAPSHOT-2020-05-26-a into tensorflow

@swift-ci Please clean test TensorFlow

ematejska

comment created time in 4 days

push eventapple/swift

Saleem Abdulrasool

commit sha 9f408f51059d0bdcdf9c5ff615094e5d01c696f4

Merge pull request #32066 from compnerd/small-change-for-small-vector runtime: further isolate runtime from LLVMSupport

view details

Saleem Abdulrasool

commit sha 23d077e1fe32b81e84144a2176b00326a2f98ec7

Merge pull request #32076 from compnerd/switching-strings stdlib: add `StringSwitch` to LLVMSupport fork

view details

push time in 4 days

push eventapple/swift

Saleem Abdulrasool

commit sha 352b2c14f005ab4de867b3c804b379f6c7797e22

Merge pull request #32066 from compnerd/small-change-for-small-vector runtime: further isolate runtime from LLVMSupport

view details

Saleem Abdulrasool

commit sha debd19951ba560df1080b5064e5ac939b93abed7

Merge pull request #32076 from compnerd/switching-strings stdlib: add `StringSwitch` to LLVMSupport fork

view details

push time in 4 days

push eventapple/swift

Saleem Abdulrasool

commit sha 9391a916721006ef94a7b078dffceb2c0b9906d3

Merge pull request #32066 from compnerd/small-change-for-small-vector runtime: further isolate runtime from LLVMSupport

view details

Saleem Abdulrasool

commit sha d2873b66404eebf4e14159324f20eebc4f8e1d6b

Merge pull request #32076 from compnerd/switching-strings stdlib: add `StringSwitch` to LLVMSupport fork

view details

push time in 4 days

pull request commenttensorflow/swift-apis

Removing reliance on experimental TF_GetServerDef TensorFlow api

@compnerd How do I test Windows?

ematejska

comment created time in 4 days

pull request commenttensorflow/swift-apis

Removing reliance on experimental TF_GetServerDef TensorFlow api

Any tips on how to properly test this are appreciated.

ematejska

comment created time in 4 days

PR opened tensorflow/swift-apis

Removing reliance on experimental TF_GetServerDef TensorFlow api

Removing reliance on experimental TF_GetServerDef TensorFlow api.

This will unblock: https://github.com/tensorflow/swift-apis/pull/957 Part of: https://github.com/tensorflow/swift-apis/issues/970

+6 -10

0 comment

1 changed file

pr created time in 4 days

create barnchematejska/swift-apis

branch : removeing_TFE_GetServerDef

created branch time in 4 days

pull request commentapple/swift

Merge swift-DEVELOPMENT-SNAPSHOT-2020-05-26-a into tensorflow

@swift-ci Please clean test TensorFlow

ematejska

comment created time in 4 days

PR opened apple/swift

Merge swift-DEVELOPMENT-SNAPSHOT-2020-05-26-a into tensorflow
+8893 -3439

0 comment

467 changed files

pr created time in 4 days

push eventapple/swift

Ewa Matejska

commit sha 240b90f0bbd91795547cb032b0cfd11a29287596

update-checkout-config.json: adjust for tensorflow merge

view details

push time in 4 days

create barnchapple/swift

branch : tensorflow-merge

created branch time in 4 days

delete branch apple/swift

delete branch : tensorflow-merge

delete time in 4 days

pull request commenttensorflow/community

RFC: CSRSparseMatrix

@penpornk Looks good from a process point of view. The once section I might augment is if you plan to have some documentation/tutorial somewhere. Did you already email developers@tensorflow.org to announce the two week review period?

penpornk

comment created time in 4 days

pull request commentapple/llvm-project

Merge swift-DEVELOPMENT-SNAPSHOT-2020-05-26-a into swift/tensorflow

@swift-ci Please clean test TensorFlow

ematejska

comment created time in 4 days

pull request commentapple/swift

Merge swift-DEVELOPMENT-SNAPSHOT-2020-05-26-a into tensorflow

@swift-ci Please clean test TensorFlow

ematejska

comment created time in 4 days

pull request commentapple/swift

Merge swift-DEVELOPMENT-SNAPSHOT-2020-05-26-a into tensorflow

swift-ci Please clean test TensorFlow

ematejska

comment created time in 4 days

PR opened apple/swift

Merge swift-DEVELOPMENT-SNAPSHOT-2020-05-26-a into tensorflow
+7365 -3035

0 comment

390 changed files

pr created time in 4 days

push eventapple/swift

Ewa Matejska

commit sha b3b285574f88adf15c817d758c8b6dfe2330b42a

update-checkout-config.json: adjust for tensorflow merge

view details

push time in 4 days

create barnchapple/swift

branch : tensorflow-merge

created branch time in 5 days

PR closed tensorflow/tensorflow

Reviewers
Updating the visibility of TFE_GetServerDef to public cla: yes size:XS stat:awaiting response

TFE_GetServerDef is used by the S4TF project here: (tensorflow/swift-apis)

+1 -1

2 comments

1 changed file

ematejska

pr closed time in 5 days

pull request commenttensorflow/tensorflow

Updating the visibility of TFE_GetServerDef to public

Discussed with @jaingaurav. Closing this pull request in favor of removing reference to TFE_GetServerDev in S4TF.

ematejska

comment created time in 5 days

issue openedtensorflow/swift-apis

Remove dependency on TFE_InferShapes and TFE_GetServerDef

We probably don't need these anymore: Remove dependency on TFE_InferShapes and TFE_GetServerDef.

created time in 5 days

Pull request review commenttensorflow/tensorflow

Updating the visibility of TFE_GetServerDef to public

 TF_CAPI_EXPORT extern void TF_EnqueueNamedTensor(TF_Session* session,                                                  TF_Tensor* tensor,                                                  TF_Status* status); // Create a serialized tensorflow.ServerDef proto.-TF_Buffer* TFE_GetServerDef(const char* text_proto, TF_Status* status);+TF_CAPI_EXPORT extern TF_Buffer* TFE_GetServerDef(const char* text_proto, TF_Status* status);

Thanks for reviewing. I don't understand what I need to change. Do you have an example?

ematejska

comment created time in 5 days

Pull request review commentapple/swift

Merge 2020-05-19 into tensorflow

        "tensorflow": {             "aliases": ["tensorflow"],             "repos": {-                "llvm-project": "a2905f3b8df7784e5c455390c6c0b0f7564e00e4",+                "llvm-project": "2e4f104624f9cdc7c8cb471a393f496b48922c0b",                 "swift": "tensorflow",-                "cmark": "swift-DEVELOPMENT-SNAPSHOT-2020-05-11-a",-                "llbuild": "swift-DEVELOPMENT-SNAPSHOT-2020-05-11-a",+                "cmark": "swift-DEVELOPMENT-SNAPSHOT-2020-05-18-a",+                "llbuild": "swift-DEVELOPMENT-SNAPSHOT-2020-05-18-a",                 "swift-tools-support-core": "0.0.1",-                "swiftpm": "swift-DEVELOPMENT-SNAPSHOT-2020-05-11-a",+                "swiftpm": "swift-DEVELOPMENT-SNAPSHOT-2020-05-20-a",

Ok, got it.

asuhan

comment created time in 6 days

Pull request review commentapple/swift

Merge 2020-05-19 into tensorflow

             "platforms": [ "Linux" ]         },         "yams": {-            "remote": { "id": "jpsim/Yams" }+            "remote": { "id": "asuhan/Yams" }

Got it.

asuhan

comment created time in 6 days

pull request commenttensorflow/swift

corrected Windows installation verification step instructions

The page now needs to take into consideration all platforms.

maxvol

comment created time in 6 days

pull request commenttensorflow/swift-models

Fractal image generation

Will you be linking to the notebook from tensorflow/swift?

BradLarson

comment created time in 6 days

push eventematejska/swift-1

Ewa Matejska

commit sha e7464be4052a93553c82b3e2e67ba670e45f0c5c

Adding S4TF API docs

view details

push time in 7 days

startedSwiftDocOrg/swift-doc

started time in 11 days

pull request commenttensorflow/swift-apis

add @noDerivative to isReducedPrecision declaration

Looks good, just waiting for CI results.

mikowals

comment created time in 12 days

issue commenttensorflow/swift-models

[TextUnsupervised] Add encoded version of WikiText103

There are some issues to resolve before progress can be made.

xihui-wu

comment created time in 12 days

pull request commenttensorflow/swift-models

Add Support for SNLI

We'll review once it's out of draft unless you're asking for a review now. Thanks!

Shashi456

comment created time in 12 days

issue closedtensorflow/swift

Cannot verify swift-tensorflow with macOS Catalina

I downloaded swift-for-tensorflow v0.9 as stated in Installation.md. Apparently, when I tried to run the package installer this error comes up: this macOS cannot verify that this app is free from malware.

My macOS version is: 10.15.4

closed time in 12 days

yos1p

issue commenttensorflow/swift

Cannot verify swift-tensorflow with macOS Catalina

Per Brad's comment, this is the expected workflow right now.

yos1p

comment created time in 12 days

pull request commenttensorflow/swift

corrected Windows installation verification step instructions

@maxvol Could you please sign the CLA?

maxvol

comment created time in 13 days

pull request commenttensorflow/swift-apis

[WIP] Hides the symbols except for those that are marked as visible

I got the PR for tensorflow here: https://github.com/tensorflow/tensorflow/pull/39551 but if it's accepted, we have to wait for S4TF to pull that version of Tensorflow in before merging this.

ematejska

comment created time in 18 days

PR opened tensorflow/tensorflow

Updating the visibility of TFE_GetServerDef to public

TFE_GetServerDef is used by the S4TF project here: (tensorflow/swift-apis)

+1 -1

0 comment

1 changed file

pr created time in 18 days

create barnchematejska/tensorflow

branch : VisiblityGetServerDef

created branch time in 18 days

fork ematejska/tensorflow

An Open Source Machine Learning Framework for Everyone

https://tensorflow.org

fork in 18 days

push eventtensorflow/swift

Timothy Salmon

commit sha 6cfb19ae6370421b71550903ff0f3e547d78aa93

Fix readme's Swift API Reference hyperlink (#465)

view details

push time in 18 days

PR merged tensorflow/swift

Fixed readme's TensorFlow Swift API Reference hyperlink

Fixed a small issue in README.md's link to the Tensorflow Swift API reference page which leads to a 404 page. The change consists of swapping /api_docs/ and /swift/ in the URL.

Original URL: https://www.tensorflow.org/api_docs/swift/Structs/Tensor Updated URL: https://www.tensorflow.org/swift/api_docs/Structs/Tensor

Let me know if it's more appropriate to point to the base docs at https://www.tensorflow.org/swift/api_docs rather than the documentation for Tensor.

+1 -1

0 comment

1 changed file

SalmonTimo

pr closed time in 18 days

pull request commenttensorflow/swift-apis

[WIP] Hides the symbols except for those that are marked as visible

Yeah, I wonder if TensorFlow will accept that change or if there is anyther API that can be used.

ematejska

comment created time in 19 days

pull request commenttensorflow/swift-apis

[WIP] Hides the symbols except for those that are marked as visible

This is not to be merged yet because the TFE_GetServerDef symbol in Sources/TensorFlow/Core/Runtime.swift ends up undefined. (It's an experimental symbol in tensorflow/c/c_api_experimental.h whose visibility is not public.

ematejska

comment created time in 19 days

PR opened tensorflow/swift-apis

[WIP] Hides the symbols except for those that are marked as visible

This fixes the immediate mode issue when the TensoFlow modules was used with swift because the symbols are not being loaded twice for llvm.

https://bugs.swift.org/projects/TF/issues/TF-1273

+9 -2

0 comment

4 changed files

pr created time in 19 days

create barnchematejska/swift-apis

branch : immediate-mode-fix

created branch time in 19 days

push eventtensorflow/swift

ematejska

commit sha 96c292165df66ca022225cb66f42c79b713b7b87

Releasing 0.9 for MacOS (#463) The immediate mode issue is still there and will have to wait for next release.

view details

push time in 20 days

PR merged tensorflow/swift

Releasing 0.9 for MacOS

The immediate mode issue is still there and will have to wait for next release.

+10 -8

0 comment

1 changed file

ematejska

pr closed time in 20 days

PR opened tensorflow/swift

Reviewers
Releasing 0.9 for MacOS

The immediate mode issue is still there and will have to wait for next release.

+10 -8

0 comment

1 changed file

pr created time in 20 days

create barnchtensorflow/swift

branch : ematejska-patch-9

created branch time in 20 days

push eventtensorflow/community

tongxuan.ltx

commit sha 9cdd68b1eb424a63972ca2f73f756882125727d5

RFC: FuseRecv

view details

Jeroen Bédorf

commit sha 5f54a3046413ef6027d3f3bdb438d232d18fe1f9

Fix irregular writing and expression issues.

view details

tongxuan.ltx

commit sha 57ee7b2ce16dcb9f0339c722f6c051ad6f6dd1d8

update reviewers and submit time

view details

tongxuan.ltx

commit sha b005a469afc335b839961557d7261dbf583a1998

update sponsor

view details

tongxuan.ltx

commit sha af8ab47f1962a03a77207c5a9630adb2e3c269e3

fix typo

view details

ematejska

commit sha 912657cde917cca7216ed317ee82a94d8ee5dd26

Update to set the status to proposed.

view details

tongxuan.ltx

commit sha f4b925cc72461f69adc16df9421b3fd5a4ad9155

Update user API and op definition based on comments.

view details

ematejska

commit sha 12f4414b30c4c990c9f113bfacc1f304e2b076ec

Merge pull request #224 from liutongxuan/master RFC: FuseRecv

view details

push time in 20 days

PR merged tensorflow/community

Reviewers
RFC: FuseRecv RFC: Accepted cla: yes

This RFC will be open for comment until Friday, May 1st, 2020.

FuseRecv

Status Proposed
Author(s) Tongxuan Liu(tongxuan.ltx@alibaba-inc.com) Peng Tao(jiankeng.pt@alibaba-inc.com) Langshi Chen (langshi.cls@alibaba-inc.com)
Reviewers(s) Ayush Dubey(ayushd@google.com) Jeroen Bédorf(jeroen@minds.ai) Derek Murray(mrry@google.com) Bairen Yi(yibairen.byron@bytedance.com) Paul Tucker(paul.tucker@gmail.com)
Sponsor Ayush Dubey(ayushd@google.com)
Updated 2020-04-11

Objective

This RFC proposes a new FuseRecv Op which would receive multiple tensors with different types through one Remote Procedure Call (RPC). This feature could significantly reduce the number of RPC calls in most rank or match models such as Search, Recommend or Ad systems.

+232 -0

13 comments

5 changed files

liutongxuan

pr closed time in 20 days

push eventtensorflow/community

Jiayi Zhao

commit sha 44159ab0ad4fbeca0e6cfa3b1a6e2340af79a38b

Add files via upload

view details

Jiayi Zhao

commit sha 3c390179e675eb2315b115bc9633c47ec949ea3a

Merge pull request #1 from 1025KB/1025KB-patch-2-1 1025 kb patch 2 1

view details

Jiayi Zhao

commit sha 877a03ab6472c5a2fcfc8437e26baa483fa4adbf

Delete cloud.png

view details

Jiayi Zhao

commit sha bd376ad8941a77a88fe9c3a2a8756707f050ea49

Delete parallel_tuning.png

view details

Jiayi Zhao

commit sha 352cce66d876bbc0c3d8c727db382ca03e7d342c

Delete workflow.png

view details

Jiayi Zhao

commit sha c1da0349088363383508ab53fd9e4b808ee1249c

Create 123

view details

Jiayi Zhao

commit sha 9cc6552fd03dc19e279386c082d3564c236791c8

Add files via upload

view details

Jiayi Zhao

commit sha 55a50fef7bc95651cf25b980ffb92d6df8bbf8d1

Delete 123

view details

Jiayi Zhao

commit sha 16fbadfa905ec0b56de8087969e50b3074f9dbac

Update 20200420-tfx-tuner-component.md

view details

ematejska

commit sha d1c022d980a19b1e6e1f858adcbcfe7d9f1c4a8e

Merge pull request #236 from 1025KB/master RFC: TFX Tuner Component

view details

push time in 20 days

PR merged tensorflow/community

Reviewers
RFC: TFX Tuner Component RFC: Proposed cla: yes

This RFC will be open for comment until Friday, May 8, 2020.

TFX Tuner Component

Status Proposed
RFC # 236
Author(s) Jiayi Zhao (jyzhao@google.com), Amy Wu (wuamy@google.com)
Sponsor Zhitao Li (zhitaoli@google.com), Tom O'Malley (omalleyt@google.com), Matthieu Monsch (mtth@google.com), Makoto Uchida (muchida@google.com), Goutham Bhat (goutham@google.com)
Updated 2020-04-20

Objective

Goal

  • A new Tuner component in TFX for automated hyper-parameter tuning, which is based on abstractions from KerasTuner library, in order to reuse abstractions and algorithms from latter.

Non Goal

  • Natively support multi-worker tuning by the system. As TFX doesn't have ability to manage multi-worker clusters, running multiple trials in parallel (parallel tuning) and running each trial in distributed env (distributed training) are not supported natively. Parallel tuning may instead be realized by a particular implementation of TFX Tuner (custom Executor), e.g., in Google Cloud environment.
  • Implementation of custom tuner for KerasTuner library is out of scope of this design discussion, e.g., a built-in EstimatorTuner support. However, user project can still implement a tuner that inherits from kerastuner.BaseTuner and provide it to the proposed TFX Tuner component.
+383 -0

1 comment

4 changed files

1025KB

pr closed time in 20 days

pull request commenttensorflow/community

RFC: TFX Tuner Component

The review happened today. There was no extra feedback and the Design is accepted as is.

1025KB

comment created time in 20 days

pull request commenttensorflow/community

RFC: FuseRecv

This has been accepted, just waiting for the final updates to this PR and notes from the review before merging.

liutongxuan

comment created time in 21 days

pull request commenttensorflow/community

RFC: Easily Customizable Optimizer.minimize

@omalleyt12 Please post the notes from the design review here.

omalleyt12

comment created time in 21 days

push eventtensorflow/swift

Dan Zheng

commit sha f65d55795d1410b1ce23eb54d231f5eb4e0277b2

Update 0.9 macOS toolchain from rc1 to rc2. (#459) * Update 0.9 macOS toolchain from rc1 to rc2. rc2 toolchain has a fix for https://bugs.swift.org/browse/TF-1260: macOS 10.15+ `swiftc` binary dynamic linker issues. * Update Installation.md Co-authored-by: ematejska <ematejska@google.com>

view details

push time in 25 days

PR merged tensorflow/swift

Update 0.9 macOS toolchain from rc1 to rc2.

rc2 toolchain has a fix for TF-1260: macOS 10.15+ swiftc binary dynamic linker issues.

I kept the macOS toolchain as a release candidate in case @ematejska wants to fix TF-1273 (immediate mode crash) before creating an official release.

+1 -4

0 comment

1 changed file

dan-zheng

pr closed time in 25 days

push eventdan-zheng/tensorflow-swift

ematejska

commit sha a175b29a6ee3149c46c9de248dc689b730c812ca

Update Installation.md

view details

push time in 25 days

pull request commentapple/swift

For the TensorFlow toolchain, keep using @rpath for libraries

@swift-ci please test tensorflow

ematejska

comment created time in 25 days

pull request commentapple/swift

For the TensorFlow toolchain, keep using @rpath for libraries

@swift-ci Please test tensorflow

ematejska

comment created time in 25 days

push eventematejska/swift

ematejska

commit sha 69d83ecfb6ea43270ec9f2eeca0e83ea9d495d60

Updating to fix test.

view details

push time in 25 days

push eventtensorflow/swift

Dan Zheng

commit sha bdd580973cbef6275e8d9b2ab1a5332566f7e9e7

Release 2020-05-07 toolchain for macOS. (#456) https://github.com/apple/swift/commit/ed8683aeaf54b95079a8f6e8d3d7482e7cfa7973

view details

push time in 25 days

PR merged tensorflow/swift

Release 2020-05-07 toolchain for macOS.

https://github.com/apple/swift/commit/ed8683aeaf54b95079a8f6e8d3d7482e7cfa7973


Notable changes:

  • swift-DEVELOPMENT-SNAPSHOT-2020-05-05-a (2020-05-07) -> tensorflow merge.
  • TF-1260 still persists, but https://github.com/apple/swift/pull/31592 should fix that.
+2 -1

0 comment

1 changed file

dan-zheng

pr closed time in 25 days

pull request commentapple/swift

For the TensorFlow toolchain, keep using @rpath for libraries

@swift-ci please test tensorflow

ematejska

comment created time in 25 days

pull request commentapple/swift

For the TensorFlow toolchain, keep using @rpath for libraries

@swift-ci Please test tensorflow

ematejska

comment created time in 25 days

push eventematejska/swift

ematejska

commit sha 8993d2013b3c343c60206a3bb464258550f9ff0c

Updating linker rpath test

view details

push time in 25 days

push eventtensorflow/swift

ematejska

commit sha 4cd02b314e8c2c9b009c4c03a51144c7d7fe5501

Releasing Linux 0.9, holding MacOS in Candidate (#454) * Releasing Linux 0.9, holding MacOS in Candidate * Updating to match development snapshot descriptions * Fixing spacing for release notes.

view details

push time in a month

PR merged tensorflow/swift

Reviewers
Releasing Linux 0.9, holding MacOS in Candidate

Waiting for https://github.com/apple/swift/pull/31592 for MacOS toolchains.

+6 -7

0 comment

1 changed file

ematejska

pr closed time in a month

push eventtensorflow/swift

ematejska

commit sha 50a326d0dae1ee2cec3a2ebda29b8a722d1359f9

Tensorflow 0.9 updates to master (#453) * Raw notebook fix (#446) * Updated Xcode project setup instructions. These modifications are based on the suggestions by Dave Fernandes here: https://groups.google.com/a/tensorflow.org/d/msg/swift/YntTUh6E20Q/LchmSQhIBAAJ * Changing Raw to _Raw in raw operator tutorial notebook. * Release 2020-05-03 toolchain for macOS. (#441) https://github.com/apple/swift/commit/04e9303405773237e30a33e05892b286167dca37 * Staging the 0.9 Candidate (#444) * Updating raw operation notebook for @derivative(of:). Co-authored-by: Brad Larson <bradlarson@google.com> Co-authored-by: Dan Zheng <danielzheng@google.com> * [tensorflow-0.9] Adding an introductory tutorial for X10 (#448) * Release 2020-05-03 toolchain for macOS. (#441) https://github.com/apple/swift/commit/04e9303405773237e30a33e05892b286167dca37 * Staging the 0.9 Candidate (#444) * [Do Not Merge] Updating for `@derivative(of:)` usage in Raw TensorFlow Operators tutorial (#445) * Updated Xcode project setup instructions. These modifications are based on the suggestions by Dave Fernandes here: https://groups.google.com/a/tensorflow.org/d/msg/swift/YntTUh6E20Q/LchmSQhIBAAJ * Changing Raw to _Raw in raw operator tutorial notebook. * Updating raw operation notebook for @derivative(of:). * Adding a tutorial for X10, along with a links in the README and table of contents. * Adding a tutorial for X10, along with a links in the README and table of contents. * Made the links to the tutorial slightly more descriptive. Removed time-dependent wording. Co-authored-by: Dan Zheng <danielzheng@google.com> Co-authored-by: ematejska <ematejska@google.com> Co-authored-by: Brad Larson <bradlarson@google.com> Co-authored-by: Dan Zheng <danielzheng@google.com>

view details

ematejska

commit sha 7242b6704e268a63fe42f33eec0edd9f9f4fadd0

Adding link to colab notebook for x10

view details

ematejska

commit sha 431ba804ad6dd27ccd74601f2b5d5f9b9193d708

Merge branch 'master' into ematejska-patch-8

view details

push time in a month

push eventtensorflow/swift

ematejska

commit sha 7242b6704e268a63fe42f33eec0edd9f9f4fadd0

Adding link to colab notebook for x10

view details

push time in a month

push eventtensorflow/swift

ematejska

commit sha 2cd1e810171eda511fd71cad970a22a7eb201ac2

Fixing spacing for release notes.

view details

push time in a month

push eventtensorflow/swift

ematejska

commit sha 83624ad0a9a257ef482b16788e0ae171933219a7

Updating to match development snapshot descriptions

view details

push time in a month

push eventtensorflow/swift

ematejska

commit sha 50a326d0dae1ee2cec3a2ebda29b8a722d1359f9

Tensorflow 0.9 updates to master (#453) * Raw notebook fix (#446) * Updated Xcode project setup instructions. These modifications are based on the suggestions by Dave Fernandes here: https://groups.google.com/a/tensorflow.org/d/msg/swift/YntTUh6E20Q/LchmSQhIBAAJ * Changing Raw to _Raw in raw operator tutorial notebook. * Release 2020-05-03 toolchain for macOS. (#441) https://github.com/apple/swift/commit/04e9303405773237e30a33e05892b286167dca37 * Staging the 0.9 Candidate (#444) * Updating raw operation notebook for @derivative(of:). Co-authored-by: Brad Larson <bradlarson@google.com> Co-authored-by: Dan Zheng <danielzheng@google.com> * [tensorflow-0.9] Adding an introductory tutorial for X10 (#448) * Release 2020-05-03 toolchain for macOS. (#441) https://github.com/apple/swift/commit/04e9303405773237e30a33e05892b286167dca37 * Staging the 0.9 Candidate (#444) * [Do Not Merge] Updating for `@derivative(of:)` usage in Raw TensorFlow Operators tutorial (#445) * Updated Xcode project setup instructions. These modifications are based on the suggestions by Dave Fernandes here: https://groups.google.com/a/tensorflow.org/d/msg/swift/YntTUh6E20Q/LchmSQhIBAAJ * Changing Raw to _Raw in raw operator tutorial notebook. * Updating raw operation notebook for @derivative(of:). * Adding a tutorial for X10, along with a links in the README and table of contents. * Adding a tutorial for X10, along with a links in the README and table of contents. * Made the links to the tutorial slightly more descriptive. Removed time-dependent wording. Co-authored-by: Dan Zheng <danielzheng@google.com> Co-authored-by: ematejska <ematejska@google.com> Co-authored-by: Brad Larson <bradlarson@google.com> Co-authored-by: Dan Zheng <danielzheng@google.com>

view details

push time in a month

PR merged tensorflow/swift

Tensorflow 0.9 updates to master
+553 -0

3 comments

3 changed files

ematejska

pr closed time in a month

PR opened tensorflow/swift

Reviewers
Releasing Linux 0.9, holding MacOS in Candidate

Waiting for https://github.com/apple/swift/pull/31592 for MacOS toolchains.

+5 -7

0 comment

1 changed file

pr created time in a month

create barnchtensorflow/swift

branch : ematejska-patch-8

created branch time in a month

pull request commenttensorflow/swift

Tensorflow 0.9 updates to master

@googlebot rerun cla

ematejska

comment created time in a month

push eventtensorflow/swift

Dan Zheng

commit sha 68b63b22aa3f6be6f0c59be3289719576f8eb898

Release 2020-05-03 toolchain for macOS. (#441) https://github.com/apple/swift/commit/04e9303405773237e30a33e05892b286167dca37

view details

ematejska

commit sha aa2ebbbc6860f53dd8770cbba0dec15a553ef3d7

Staging the 0.9 Candidate (#444)

view details

Brad Larson

commit sha c9c3990413a767d59c0d6ea6c3f4b3679c921747

[Do Not Merge] Updating for `@derivative(of:)` usage in Raw TensorFlow Operators tutorial (#445) * Updated Xcode project setup instructions. These modifications are based on the suggestions by Dave Fernandes here: https://groups.google.com/a/tensorflow.org/d/msg/swift/YntTUh6E20Q/LchmSQhIBAAJ * Changing Raw to _Raw in raw operator tutorial notebook. * Updating raw operation notebook for @derivative(of:).

view details

ematejska

commit sha 53eefd5c19ce673397a9738eb3817077e96ef8c1

Removing this outdated template that points to JIRA (#447) Will be replaced by template encouraging Github Issues

view details

ematejska

commit sha b663959e4387128280670c8f4285cb3d70c18289

Adding docs about backends (#449)

view details

ematejska

commit sha 65af7958a1fc9ef59b7b369f5467d546d9c3132f

Merge branch 'master' into tensorflow-0.9

view details

push time in a month

more