profile
viewpoint
Elliotte Rusty Harold elharo New York http://www.elharo.com/blog/ Elliotte Rusty Harold lives in a secret mountaintop laboratory on a large island off the East Coast of the United States. He's an active member of SFWA and BSFW

elharo/aether-demo-maven-plugin 0

A simple Maven plugin demonstrating the use of Aether.

elharo/appengine-maven-archetypes-java 0

App Engine Maven Archetypes

elharo/appengine-php-wordpress-starter-project 0

Starter project for running WordPress on Google Cloud Platform

elharo/auto 0

A collection of source code generators for Java.

elharo/avro 0

Apache Avro

elharo/bazel 0

a fast, scalable, multi-language and extensible build system

elharo/beam 0

Apache Beam

PR closed googleapis/google-api-java-client

chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.31 cla: yes

This PR contains the following updates:

Package Update Change
com.puppycrawl.tools:checkstyle (source) minor 8.23 -> 8.31

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

0 comment

1 changed file

renovate-bot

pr closed time in 11 hours

PR closed googleapis/google-http-java-client

chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.31 cla: yes

This PR contains the following updates:

Package Update Change
com.puppycrawl.tools:checkstyle (source) minor 8.23 -> 8.31

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+2 -2

0 comment

2 changed files

renovate-bot

pr closed time in 11 hours

issue commentgoogleapis/gax-java

Java 7 CI broken

https://travis-ci.community/t/zulu-jdk-7-availability-to-replace-openjdk/7884

elharo

comment created time in 14 hours

issue commentgoogleapis/gax-java

Java 7 CI broken

see https://github.com/travis-ci/travis-ci/issues/8503 https://github.com/travis-ci/travis-ci/issues/8574 https://github.com/eseifert/gral/commit/c24e08a91952a99b8c8b686a1b172335db8cdf87

elharo

comment created time in 14 hours

pull request commentgoogleapis/gax-java

deps: com.google.api:api-common

The Java 7 failure is due to old SSL in our Java 7 VM. We've seen this in other repos, but we do need to fix it:

  • What went wrong: A problem occurred configuring root project 'gax-java'.

Could not resolve all artifacts for configuration ':classpath'. Could not resolve net.ltgt.gradle:gradle-apt-plugin:0.10. Required by: project : Could not resolve net.ltgt.gradle:gradle-apt-plugin:0.10. Could not get resource 'https://plugins.gradle.org/m2/net/ltgt/gradle/gradle-apt-plugin/0.10/gradle-apt-plugin-0.10.pom'. Could not GET 'https://plugins.gradle.org/m2/net/ltgt/gradle/gradle-apt-plugin/0.10/gradle-apt-plugin-0.10.pom'. sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed Could not resolve gradle.plugin.com.dorongold.plugins:task-tree:1.3.1. Required by: project : Could not resolve gradle.plugin.com.dorongold.plugins:task-tree:1.3.1. Could not get resource 'https://plugins.gradle.org/m2/gradle/plugin/com/dorongold/plugins/task-tree/1.3.1/task-tree-1.3.1.pom'. Could not GET 'https://plugins.gradle.org/m2/gradle/plugin/com/dorongold/plugins/task-tree/1.3.1/task-tree-1.3.1.pom'. sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed Could not resolve gradle.plugin.com.github.sherter.google-java-format:google-java-format-gradle-plugin:0.8. Required by: project : Could not resolve gradle.plugin.com.github.sherter.google-java-format:google-java-format-gradle-plugin:0.8. Could not get resource 'https://plugins.gradle.org/m2/gradle/plugin/com/github/sherter/google-java-format/google-java-format-gradle-plugin/0.8/google-java-format-gradle-plugin-0.8.pom'. Could not GET 'https://plugins.gradle.org/m2/gradle/plugin/com/github/sherter/google-java-format/google-java-format-gradle-plugin/0.8/google-java-format-gradle-plugin-0.8.pom'. sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: signature check failed

elharo

comment created time in 14 hours

PR opened googleapis/gax-java

deps: com.google.api:api-common

@chingor13 update api-common

+1 -1

0 comment

1 changed file

pr created time in 15 hours

create barnchgoogleapis/gax-java

branch : elharo-patch-5

created branch time in 15 hours

PR opened apache/maven-verifier

Reviewers
deps: update parent POM dependencies

@rfscholte

+2 -2

0 comment

1 changed file

pr created time in 17 hours

create barnchapache/maven-verifier

branch : elharo-patch-1

created branch time in 17 hours

PR opened apache/maven-surefire

Reviewers
deps: update parent POM

@eolivelli

+1 -1

0 comment

1 changed file

pr created time in a day

create barnchapache/maven-surefire

branch : elharo-patch-1

created branch time in a day

push eventapache/maven-dependency-plugin

Elliotte Rusty Harold

commit sha 8d2174493823fa3f221df600aa0e5f29041dff41

remove unused code (#34)

view details

Elliotte Rusty Harold

commit sha 5b1f6fb72e501385c030f48546c54b9c71f9c56c

remove unthrown exceptions (#35)

view details

Elliotte Rusty Harold

commit sha 4db04b7c0b9b9744c9fe4527a8399f46354aeb82

docs: fix typo (#38) @Tibor17

view details

Karl Heinz Marbaise

commit sha dac074ee6389c6ae671d9a4579d58a3cf332c9cf

[MDEP-681] - Remove no longer required execlusions

view details

Elliotte Rusty Harold

commit sha a1037f717999ededa0e99c908f4131d955445a6f

cure a deprecation warning (#39)

view details

Elliotte Rusty Harold

commit sha b446eeaf337c51ca0cbd2a1b7ff70ee3484c3e2b

merge master

view details

push time in a day

PR opened apache/maven-dependency-plugin

update commons-lang

@michael-o

+3 -3

0 comment

1 changed file

pr created time in a day

create barnchapache/maven-dependency-plugin

branch : lang

created branch time in a day

create barnchapache/maven-javadoc-plugin

branch : prob

created branch time in a day

PR opened codehaus-plexus/plexus-archiver

remove incorrect JavaDoc comments

@hboutemy You can't inline from an interface since there's no implementation to replace it with.

+6 -22

0 comment

1 changed file

pr created time in a day

push eventelharo/plexus-archiver

Elliotte Rusty Harold

commit sha 017802d21941d969e086c1cf3fc43f2df56a26ec

remove incorrect JavaDoc comments @hboutemy You can't inline from an interface since there's no implementation to replace it with.

view details

push time in a day

delete branch apache/maven-javadoc-plugin

delete branch : depr

delete time in a day

push eventapache/maven-javadoc-plugin

Elliotte Rusty Harold

commit sha e203bbf08ff1944800538fb6101e181b70b56553

cure a couple of deprecation warnings (#46)

view details

push time in a day

PR merged apache/maven-javadoc-plugin

toURL --> toURI().toURL()

@michael-o

+2 -2

0 comment

2 changed files

elharo

pr closed time in a day

delete branch apache/maven-dependency-plugin

delete branch : sink

delete time in a day

push eventapache/maven-dependency-plugin

Elliotte Rusty Harold

commit sha a1037f717999ededa0e99c908f4131d955445a6f

cure a deprecation warning (#39)

view details

push time in a day

PR merged apache/maven-dependency-plugin

Reviewers
cure a deprecation warning

@eolivelli

+1 -1

0 comment

1 changed file

elharo

pr closed time in a day

delete branch apache/maven-site

delete branch : elharo-patch-2

delete time in a day

push eventapache/maven-site

Elliotte Rusty Harold

commit sha 5264f30ef85a835520bf7857ce9c8b20f987c1bb

Update link to appache instructions (#148) @eolivelli

view details

push time in a day

PR merged apache/maven-site

Reviewers
Update link to apache instructions

@eolivelli

+1 -1

0 comment

1 changed file

elharo

pr closed time in a day

PR opened apache/maven-site

Reviewers
Update link to appache instructions

@eolivelli

+1 -1

0 comment

1 changed file

pr created time in a day

create barnchapache/maven-site

branch : elharo-patch-2

created branch time in a day

PR opened apache/maven-reporting-api

Reviewers
update dependencies

@rfscholte This is needed by the maven-javadoc-plugin

+2 -2

0 comment

1 changed file

pr created time in a day

create barnchapache/maven-reporting-api

branch : deps

created branch time in a day

PR opened apache/maven-dependency-plugin

Reviewers
cure a deprecation warning

@eolivelli

+1 -1

0 comment

1 changed file

pr created time in a day

create barnchapache/maven-dependency-plugin

branch : sink

created branch time in a day

PR opened apache/maven-javadoc-plugin

Reviewers
toURL --> toURI().toURL()

@michael-o

+2 -2

0 comment

2 changed files

pr created time in a day

create barnchapache/maven-javadoc-plugin

branch : depr

created branch time in a day

pull request commentapache/maven-javadoc-plugin

Uses try with resources

Build passing: https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/job/plexus/

elharo

comment created time in 2 days

delete branch apache/maven-javadoc-plugin

delete branch : plexus

delete time in 2 days

push eventapache/maven-javadoc-plugin

Elliotte Rusty Harold

commit sha 12a08bf36cb9b5734e3bd647af6f735a948eaf9e

Uses try with resources (#45) * use try with resources

view details

push time in 2 days

PR merged apache/maven-javadoc-plugin

Uses try with resources

@michael-o Starting work on clearing out some old code so we can update plexus and aether. Also fixes some API docs

+158 -172

0 comment

3 changed files

elharo

pr closed time in 2 days

PR opened apache/maven-javadoc-plugin

Reviewers
Uses try with resources

@michael-o Starting work on clearing out some old code so we can update plexus and aether. Also fixes some API docs

+158 -172

0 comment

3 changed files

pr created time in 2 days

push eventapache/maven-javadoc-plugin

Elliotte Rusty Harold

commit sha a200f562fd25c53ec2cf7f2be12274d7a574a55d

use try with resources

view details

push time in 2 days

create barnchapache/maven-javadoc-plugin

branch : plexus

created branch time in 2 days

issue openedGoogleCloudPlatform/cloud-opensource-java

avoid Guava ClassPath.from in ClassPathEntry

Here's what we do:

    // Leveraging Google Guava reflection as BCEL doesn't have API to list classes in a jar file
    com.google.common.reflect.ClassPath classPath =
        com.google.common.reflect.ClassPath.from(classLoaderFromJar);

Could we read the jar file directly instead without loading the classes? It's just a zip file. That might miss inner classes though.

created time in 2 days

create barnchGoogleCloudPlatform/cloud-opensource-java

branch : con

created branch time in 2 days

create barnchGoogleCloudPlatform/cloud-opensource-java

branch : of

created branch time in 2 days

PR opened GoogleCloudPlatform/cloud-opensource-java

unused import

@suztomo remove unused import

+0 -1

0 comment

1 changed file

pr created time in 2 days

create barnchGoogleCloudPlatform/cloud-opensource-java

branch : inline

created branch time in 2 days

push eventapache/maven-javadoc-plugin

Alexis

commit sha e7b61147916a3b803fac3ce56f2ce11e5149b4aa

[MJAVADOC-614] - "No source files for package" in a directory with accent characters (#30)

view details

push time in 2 days

PR merged apache/maven-javadoc-plugin

[MJAVADOC-614] - "No source files for package" in a directory with accent characters

Related issue: https://issues.apache.org/jira/browse/MJAVADOC-614

+2 -2

0 comment

2 changed files

alexisjehan

pr closed time in 2 days

delete branch apache/maven-javadoc-plugin

delete branch : ht

delete time in 2 days

push eventapache/maven-javadoc-plugin

Elliotte Rusty Harold

commit sha 67921dec760698fc3db18415bafaa24b5ee63f3f

update misc apache dependencies

view details

Elliotte Rusty Harold

commit sha 3725fcf4f2f587864f37576862c20beee312134f

Merge pull request #44 from apache/ht update misc apache dependencies

view details

push time in 2 days

PR merged apache/maven-javadoc-plugin

Reviewers
update misc apache dependencies

@michael-o

+3 -3

0 comment

1 changed file

elharo

pr closed time in 2 days

push eventGoogleCloudPlatform/cloud-opensource-java

Elliotte Rusty Harold

commit sha f55d642ca7a9b66f3ff5f923207564ca62bce6ff

fix a test

view details

push time in 2 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

push class file names into ClasspathEntry

    /** An entry for a Maven artifact. */   public ClassPathEntry(Artifact artifact) {-    checkNotNull(artifact.getFile());+    this(artifact.getFile().toPath());

removed

elharo

comment created time in 2 days

push eventGoogleCloudPlatform/cloud-opensource-java

Elliotte Rusty Harold

commit sha 8055d3ff5d433dbe9704a7a0668e34411a25fc5e

remove old comment

view details

push time in 2 days

push eventGoogleCloudPlatform/cloud-opensource-java

Elliotte Rusty Harold

commit sha 56a440fd3c6d8da7696ed998baf5caf0bcffb580

fix a test

view details

push time in 2 days

push eventGoogleCloudPlatform/cloud-opensource-java

Elliotte Rusty Harold

commit sha a253f6b96abd4e1857dc7057b7220b872335a11f

fix a test

view details

push time in 2 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

LinkageCheckerMain and LinkageCheckerRule to support exclusion filter file option

 public ClassReferenceGraph getClassReferenceGraph() {     return classReferenceGraph;   } +  @VisibleForTesting+  static LinkageChecker create(List<ClassPathEntry> classPath) throws IOException {+    return create(classPath, ImmutableSet.copyOf(classPath), null);+  }++  /**+   * Returns Linkage Checker for {@code classPath}.+   *+   * @param classPath List of JAR files to find linkage errrors

"JAR files to find linkage errors in"

suztomo

comment created time in 2 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

LinkageCheckerMain and LinkageCheckerRule to support exclusion filter file option

 public ClassReferenceGraph getClassReferenceGraph() {     return classReferenceGraph;   } +  @VisibleForTesting+  static LinkageChecker create(List<ClassPathEntry> classPath) throws IOException {+    return create(classPath, ImmutableSet.copyOf(classPath), null);+  }++  /**+   * Returns Linkage Checker for {@code classPath}.+   *+   * @param classPath List of JAR files to find linkage errrors+   * @param entryPoints List of JAR files to define entry point classes in reachability.

List of JAR --> JAR

suztomo

comment created time in 2 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

LinkageCheckerMain and LinkageCheckerRule to support exclusion filter file option

 public ClassReferenceGraph getClassReferenceGraph() {     return classReferenceGraph;   } +  @VisibleForTesting+  static LinkageChecker create(List<ClassPathEntry> classPath) throws IOException {+    return create(classPath, ImmutableSet.copyOf(classPath), null);+  }++  /**+   * Returns Linkage Checker for {@code classPath}.+   *+   * @param classPath List of JAR files to find linkage errrors+   * @param entryPoints List of JAR files to define entry point classes in reachability.+   * @param exclusionFile Exclusion file to filter out linkage errors.

exclusion file to suppress linkage errors.

suztomo

comment created time in 2 days

push eventGoogleCloudPlatform/cloud-opensource-java

Elliotte Rusty Harold

commit sha cade5d2a300903d63227dcc8a8b9dd28c47862db

reuse constructor

view details

push time in 2 days

push eventGoogleCloudPlatform/cloud-opensource-java

Elliotte Rusty Harold

commit sha 55e4bbb523d7680e3d097db18a138ae161b828f7

javadoc

view details

push time in 2 days

push eventGoogleCloudPlatform/cloud-opensource-java

Elliotte Rusty Harold

commit sha 05d4198bcf291d27014a4d078d678d9c9d72dc64

make listClassFileNames void

view details

push time in 2 days

PR opened GoogleCloudPlatform/cloud-opensource-java

push class file names into ClasspathEntry

some initial work on pushing more info into classes instead of parallel data structures

+14 -16

0 comment

3 changed files

pr created time in 2 days

create barnchGoogleCloudPlatform/cloud-opensource-java

branch : sim

created branch time in 2 days

delete branch apache/maven-shared-utils

delete branch : elharo-patch-1

delete time in 3 days

push eventapache/maven-shared-utils

Elliotte Rusty Harold

commit sha 50bba92fd7d7b2c37f6302ececd99de6b7f814ef

docs: we don't shade commons-io (#22) @hboutemy Maybe we used to, but not anymore.

view details

push time in 3 days

PR merged apache/maven-shared-utils

docs: we don't shade commons-io

@hboutemy Maybe we used to, but not anymore.

+0 -9

0 comment

1 changed file

elharo

pr closed time in 3 days

issue commentGoogleCloudPlatform/cloud-opensource-java

Custom Type for SymbolProblem Mappings

We might not need a new type. It might work as part of ClasspathEntry or ClasspathResult.

suztomo

comment created time in 3 days

PR opened apache/maven-javadoc-plugin

Reviewers
update misc apache dependencies

@michael-o

+3 -3

0 comment

1 changed file

pr created time in 3 days

create barnchapache/maven-javadoc-plugin

branch : ht

created branch time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

 private static FieldSymbol makeSymbol(     return innerClassNames.build();   } -  /**-   * Returns the first jar file {@link Path} defining the class. Null if the location is unknown.-   */+  /** Returns the first class path entry defining the class. Null if the location is unknown. */

defining --> containing

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

 Path findClassLocation(String className) {     if (specialLocation == null) {       return null;     }-    return Iterables.getFirst(classFileNameToJarFiles.get(specialLocation), null);+    return Iterables.getFirst(classFileNameToClassPathEntry.get(specialLocation), null);   }    /**-   * Returns mapping from jar files to class file names they contain.+   * Returns mapping from class path entries to class file names they contain.    *-   * @param jars absolute paths to jar files+   * @param classPath class path entries in which it finds the class names.

no period

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

 public void testResolve_removingDuplicates() {     Artifact grpcArtifact = new DefaultArtifact("io.grpc:grpc-auth:1.15.1");     ClassPathResult result = classPathBuilder.resolve(ImmutableList.of(grpcArtifact)); -    ImmutableList<Path> paths = result.getClassPath();-    long jsr305Count = paths.stream().filter(path -> path.toString().contains("jsr305-")).count();+    ImmutableList<ClassPathEntry> classPath = result.getClassPath();+    long jsr305Count = classPath.stream().filter(path -> path.toString().contains("jsr305")).count();     Truth.assertWithMessage("There should not be duplicated versions for jsr305")

for --> of

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

 boolean isSystemClass(String className) {     }   } -  /**-   * Returns class file names defined in the jar file.-   *-   * @param jarPath absolute path to the jar file-   */-  ImmutableSet<String> classesDefinedInJar(Path jarPath) {-    return jarFileToClassFileNames.get(jarPath);+  /** Returns class file names defined in the class path entry. */

"defined" is perhaps not the right word here. Perhaps "Found"? Or maybe just classNamesInJar

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

 private static Options configureOptions() {     }   } -  /** Returns a list of absolute paths to files specified in the JAR file option. */-  ImmutableList<Path> getJarFiles() {+  /**+   * Returns class path entries for the absolute paths of the files specified in the JAR file+   * option.+   */+  ImmutableList<ClassPathEntry> getJarFiles() {     if (commandLine.hasOption("j")) {       String[] jarFiles = commandLine.getOptionValues("j");       return Arrays.stream(jarFiles)           .map(name -> Paths.get(name).toAbsolutePath())+          .map(ClassPathEntry::new)           .collect(toImmutableList());     } else {       throw new IllegalArgumentException("The arguments must have option 'j' to list JAR files");

Perhaps this should be an empty list instead?

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

 import org.eclipse.aether.artifact.Artifact;  /**- * Utility to build a class path (a list of jar files) through a dependency tree of Maven artifacts.+ * Utility to build a class path (a list of class path entries) through a dependency tree of Maven

so why do we get a ClasspathResult out of this and not a ClassPath?

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

  import com.google.common.annotations.VisibleForTesting; import com.google.common.base.MoreObjects;-import java.nio.file.Path; import java.util.Objects;  /**- * A locator for a compiled class file of {@code className} in {@code jar} to uniquely locate the- * class implementation in a class path.+ * A locator for a compiled class file of {@code className} in {@code classPathEntry} to uniquely

What's a "locator"? This is redundant with locate below. And perhaps this class is incorrectly named. I.e. why is it not ClassFileLocator if it represents a locator and not a class file.

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

 Path findClassLocation(String className) {   }    /**-   * Returns a set of {@link JavaClass}es which have entries in the {@code jar} through {@link+   * Returns a set of {@link JavaClass}es which have entries in the {@code entry} through {@link    * #classRepository}.    */-  private ImmutableSet<JavaClass> listClasses(Path jar) throws IOException {+  private ImmutableSet<JavaClass> listClasses(ClassPathEntry entry) throws IOException {     ImmutableSet.Builder<JavaClass> javaClasses = ImmutableSet.builder();      ImmutableList.Builder<String> corruptedClassFileNames = ImmutableList.builder(); -    for (String classFileName : listClassFileNames(jar)) {+    for (String classFileName : listClassFileNames(entry)) {

entry.getClassFileNames()? That is, should we move the listing into the ClassPathEntry class?

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

 Path findClassLocation(String className) {   }    /**-   * Returns a set of {@link JavaClass}es which have entries in the {@code jar} through {@link+   * Returns a set of {@link JavaClass}es which have entries in the {@code entry} through {@link    * #classRepository}.

How does the repository work here? What if there are multiple repositories?

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

 class ClassDumper {   private static final Logger logger = Logger.getLogger(ClassDumper.class.getName()); -  private final ImmutableList<Path> inputClassPath;+  private final ImmutableList<ClassPathEntry> inputClassPath;   private final FixedSizeClassPathRepository classRepository;   private final ClassLoader extensionClassLoader;-  private final ImmutableSetMultimap<Path, String> jarFileToClassFileNames;-  private final ImmutableListMultimap<String, Path> classFileNameToJarFiles;+  private final ImmutableSetMultimap<ClassPathEntry, String> classPathEntryToClassFileNames;+  private final ImmutableListMultimap<String, ClassPathEntry> classFileNameToClassPathEntry; -  private static FixedSizeClassPathRepository createClassRepository(List<Path> paths) {-    ClassPath classPath = new LinkageCheckClassPath(paths);+  private static FixedSizeClassPathRepository createClassRepository(List<ClassPathEntry> entries) {+    ClassPath classPath = new LinkageCheckClassPath(entries);     return new FixedSizeClassPathRepository(classPath);   } -  static ClassDumper create(List<Path> jarPaths) throws IOException {+  static ClassDumper create(List<ClassPathEntry> entries) throws IOException {     ClassLoader systemClassLoader = ClassLoader.getSystemClassLoader();     ClassLoader extensionClassLoader = systemClassLoader.getParent();      ImmutableList<Path> unreadableFiles =-        jarPaths.stream()+        entries.stream()+            .map(ClassPathEntry::getPath)

They could convert to a string if that's what they want. It's surprising to have the method name inconsistent with the return type.

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

 static Configuration configureFreemarker() {    * Returns mapping from the Maven coordinates of BOM members to jar files that are in the    * dependency tree of the BOM members.    */-  private static ImmutableSetMultimap<String, Path> bomMemberToJars(+  private static ImmutableSetMultimap<String, ClassPathEntry> bomMemberToJars(       ClassPathResult classPathResult) {

For later: we could perhaps push a lot of this into ClassPathResult whihc could become simply Classpath. Hide a lot of the implementation details.

suztomo

comment created time in 3 days

PR merged apache/maven-javadoc-plugin

update doxia

@rfscholte

+1 -1

1 comment

1 changed file

elharo

pr closed time in 3 days

push eventapache/maven-javadoc-plugin

Elliotte Rusty Harold

commit sha 991c382b1b6d7e2c1abf586e882ac63d72404aad

update doxia

view details

push time in 3 days

pull request commentapache/maven-javadoc-plugin

update doxia

Thanks. Waiting for CI to fire:

https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/job/up/

elharo

comment created time in 3 days

PR opened apache/maven-javadoc-plugin

Reviewers
update doxia

@rfscholte

+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchapache/maven-javadoc-plugin

branch : up

created branch time in 3 days

push eventGoogleCloudPlatform/appengine-plugins-core

Elliotte Rusty Harold

commit sha bd7c97172cd78b02b66509c0f23ec3c3142f849b

trivial change--http-->https-->to force CI to run again

view details

Elliotte Rusty Harold

commit sha 457035d3bc2062d02c8d020c36d9d54b2e500b54

Merge branch 'guava' of github.com:GoogleCloudPlatform/appengine-plugins-core into guava

view details

push time in 3 days

Pull request review commentgoogleapis/java-firestore

feat: add Query.limitToLast()

 public Query orderBy(@Nonnull FieldPath fieldPath, @Nonnull Direction direction)   }    /**-   * Creates and returns a new Query that's additionally limited to only return up to the specified-   * number of documents.+   * Creates and returns a new Query that only returns the first matching documents.    *    * @param limit The maximum number of items to return.    * @return The created Query.    */   @Nonnull   public Query limit(int limit) {-    return new Query(firestore, options.toBuilder().setLimit(limit).build());+    return new Query(+        firestore, options.toBuilder().setLimit(limit).setLimitType(LimitType.First).build());+  }++  /**+   * Creates and returns a new Query that only returns the last matching documents.+   *+   * <p>You must specify at least one orderBy clause for limitToLast queries, otherwise an exception+   * will be thrown during execution.+   *+   * <p>Results for limitToLast queries cannot be streamed via the {@link+   * #stream(ApiStreamObserver)} API.+   *+   * @param limit The maximum number of items to return.

Google Java practices explicitly rule out consistency with existing code as a justification for violating style guidelines in newly added code:

https://engdoc.corp.google.com/eng/doc/devguide/java/style/index.md?cl=head#s8.5.2-newly-added-code

schmidt-sebastian

comment created time in 3 days

Pull request review commentgoogleapis/java-firestore

feat: add Query.limitToLast()

 public Query orderBy(@Nonnull FieldPath fieldPath, @Nonnull Direction direction)   }    /**-   * Creates and returns a new Query that's additionally limited to only return up to the specified-   * number of documents.+   * Creates and returns a new Query that only returns the first matching documents.    *    * @param limit The maximum number of items to return.    * @return The created Query.    */   @Nonnull   public Query limit(int limit) {-    return new Query(firestore, options.toBuilder().setLimit(limit).build());+    return new Query(+        firestore, options.toBuilder().setLimit(limit).setLimitType(LimitType.First).build());+  }++  /**+   * Creates and returns a new Query that only returns the last matching documents.+   *+   * <p>You must specify at least one orderBy clause for limitToLast queries, otherwise an {@link+   * java.lang.IllegalStateException} will be thrown during execution.

will be --> is

schmidt-sebastian

comment created time in 3 days

Pull request review commentgoogleapis/java-firestore

feat: add Query.limitToLast()

 public Query orderBy(@Nonnull FieldPath fieldPath, @Nonnull Direction direction)   }    /**-   * Creates and returns a new Query that's additionally limited to only return up to the specified-   * number of documents.+   * Creates and returns a new Query that only returns the first matching documents.    *    * @param limit The maximum number of items to return.    * @return The created Query.    */   @Nonnull   public Query limit(int limit) {-    return new Query(firestore, options.toBuilder().setLimit(limit).build());+    return new Query(+        firestore, options.toBuilder().setLimit(limit).setLimitType(LimitType.First).build());+  }++  /**+   * Creates and returns a new Query that only returns the last matching documents.+   *+   * <p>You must specify at least one orderBy clause for limitToLast queries, otherwise an {@link

, otherwise --> . Otherwise

schmidt-sebastian

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Recovering settings.xml to use Google Cloud Maven Mirror

     <!-- Google's Maven Central mirror for Americas

move comment down

suztomo

comment created time in 3 days

pull request commentGoogleCloudPlatform/cloud-opensource-java

Replace List<Path> with List<ClassPathEntry>

Probably Maven central has flagged that CI machine as abusive for some reason.

suztomo

comment created time in 3 days

Pull request review commentGoogleCloudPlatform/cloud-opensource-java

Recovering settings.xml to use Google Cloud Maven Mirror

+<!--+  ~ Copyright 2020 Google LLC.+  ~+  ~ Licensed under the Apache License, Version 2.0 (the "License");+  ~ you may not use this file except in compliance with the License.+  ~ You may obtain a copy of the License at+  ~+  ~     http://www.apache.org/licenses/LICENSE-2.0+  ~+  ~ Unless required by applicable law or agreed to in writing, software+  ~ distributed under the License is distributed on an "AS IS" BASIS,+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+  ~ See the License for the specific language governing permissions and+  ~ limitations under the License.+  -->++<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"+    xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0+                          https://maven.apache.org/xsd/settings-1.0.0.xsd">+  <mirrors>+    <!-- Google's Maven Central mirror for Americas+     https://maven-central.storage.googleapis.com/index.html+    -->+    <mirror>+      <id>google-maven-central</id>+      <name>GCS Maven Central mirror</name>+      <url>https://maven-central.storage-download.googleapis.com/maven2/</url>

Is there anyway we can set one repo as a backup for another?

suztomo

comment created time in 3 days

delete branch apache/maven-javadoc-plugin

delete branch : qdox

delete time in 3 days

push eventapache/maven-javadoc-plugin

Elliotte Rusty Harold

commit sha d852e7a21342141e64a1514cf2d13a6e2dda49c8

update qdox

view details

Elliotte Rusty Harold

commit sha 500847ac87435f39874d259bae1f771ac0cc1f19

Merge pull request #42 from apache/qdox update qdox

view details

push time in 3 days

PR merged apache/maven-javadoc-plugin

update qdox

@rfscholte

+1 -1

2 comments

1 changed file

elharo

pr closed time in 3 days

more