profile
viewpoint

eikes/jquery.fullscreen.js 177

jQuery HTML5 Fullscreen Slideshow

eikes/facetedsearch 107

This JS lib lets you filter, sort and display large datasets in the browser.

eikes/jquery.swipe-events.js 101

Add swipe events on mobile devices to elements using jQuery

eikes/jump 19

A very simple jQuery maps plugin

eikes/charts 2

Create charts, graphs and info graphics with ruby as SVG, JPG or PNG

eikes/activeadmin 0

The administration framework for Ruby on Rails applications.

eikes/angular-bootstrap-datetimepicker-directive 0

A wrapper directive around the bootstrap-datetimepicker component.

eikes/angular-initial-value 0

A tiny AngularJS directive to set ng-model (and consequently field value) based on form fields attributes.

eikes/angular.js 0

AngularJS - HTML enhanced for web apps!

eikes/assemblyscript-samples 0

AssemblyScript samples

PullRequestReviewEvent

Pull request review commentioki-mobility/ioki-ruby

Fixes log filter to actually work

 def self.get(config)       ::Faraday.new(config.api_base_url, headers: headers(config)) do |f|         f.adapter :net_http +        f.request :authorization, 'Bearer', -> { config.api_token }+        f.request :json # encode req bodies as JSON

These two are the middleware for the outgoing request. The order of the middleware for the incoming response is what I changed in #44. The thing is, that the logger inspects both resquest and response even if it is only called on the response (don't ask me why) and I noticed, that the authorization header would not be logged if it is configured in this setup after the logger. I was not able to test yet how this order affects the logging of the outgoing request bodies, such as a POST request body.

I can take a look after the weekend though.

eikes

comment created time in 2 days

PR opened ioki-mobility/ioki-ruby

Fixes log filter to actually work

The filter regexp didn't match the actual headers. Now there is a test which verifies that...

+20 -9

0 comment

2 changed files

pr created time in 3 days

create barnchioki-mobility/ioki-ruby

branch : log-filter

created branch time in 3 days

push eventioki-mobility/ioki-ruby

Eike Send

commit sha df14f1072e5dc74d676e7caaecd3271be6cb85e0

Makes sure, that JSON decoding occurs before logging, so no Encoding::UndefinedConversionError is raised

view details

push time in 3 days

create barnchioki-mobility/ioki-ruby

branch : encoding-middleware

created branch time in 3 days

issue commentioki-mobility/ioki-ruby

Iterate setup/installations steps on a fresh install to be as smooth as possible

I would like to point out, that installing this as a gem via rubygems.org is currently not yet possible. What I did was add this repository into the vendor folder as a git submodule and require it in the Gemfile with the :path param:

git submodule add git@github.com:ioki-mobility/ioki-ruby.git vendor/ioki-ruby

Gemfile

gem 'ioki-ruby', path: 'vendor/ioki-ruby'
ans-ioki

comment created time in 4 days

pull request commentioki-mobility/ioki-ruby

Removes custom logger and HttpAdapter subclasses, uses Faraday directly

Looks good to me! Thank you for letting me contribute this large PR.

eikes

comment created time in 6 days

pull request commentioki-mobility/ioki-ruby

Removes custom logger and HttpAdapter subclasses, uses Faraday directly

I realize this is a big PR. I really got into it, learned a lot about the gem while I was at it.

I think it would be beneficial if we would set up a meeting-call where we could go through the changes. Otherwise I'd more than happy to answer any questions here in the PR.

eikes

comment created time in 9 days

PR opened ioki-mobility/ioki-ruby

Removes custom logger and HttpAdapter subclasses, uses Faraday directly

Faraday provides some tools which were re-implemented in this gem: notably logging. The built-in logging ability of a Faraday::Connection is superior to a custom solution. Any custom logging code is removed and replaced with the Faraday logger middleware.

The Test adapter was removed because it wasn't used anywhere. Faraday has a test stub adapter built in, so that is the preferred way of inspecting requests and providing custom responses.

As a user of this gem, I would like to be able to provide my own Faraday::Connection with the Test Adapter, so I can run tests against my own responses. These changes make it possible to do so.

+358 -694

0 comment

35 changed files

pr created time in 10 days

push eventioki-mobility/ioki-ruby

Eike Send

commit sha ea55433f3a04d682f6a0a349c9516620f4ebf252

Removes custom logger and HttpAdapter subclasses, uses Faraday directly

view details

push time in 10 days

create barnchioki-mobility/ioki-ruby

branch : faraday-config

created branch time in 10 days

issue openedioki-mobility/ioki-ruby

Make all attributes which are defined in the openapi files attributes of all models

I noticed, that there are many attributes defined in the openapi specification file which are not accessible through the ruby models. As a user of this gem I would like to be able to access all attributes from the API response though.

The match_open_api_definition matcher can be used to show the difference like this:

RSpec::Matchers.define :match_open_api_definition do |scope, model, options = {}|
  # [...]
  match do |actual_model|
    return false if model_node.nil?
    model_attributes = defined_attributes(actual_model)
    (model_attributes - specified_attributes | specified_attributes - model_attributes).empty?
  end

  failure_message do |actual_model|
    if model_node.nil?
      <<~MESSAGE
        Specification not found for #{actual_model}. I was looking for: #{schema_path}. Available specifications:
        #{schemas.keys}
      MESSAGE
    else
      <<~MESSAGE
        expected that the model #{actual_model} would only define attributes defined in the open_api definition, but there are attributes in the model that are not in the specification.
        The attributes which are used in the model but which are not in the specification are:
        #{(defined_attributes(actual_model) - specified_attributes).sort}
        The attributes which are not used in the model but which are in the specification are:
        #{(specified_attributes - defined_attributes(actual_model)).sort}
        The attributes defined in the model are:
        #{defined_attributes(actual_model).sort}
        The attributes defined in the specification are:
        #{specified_attributes.sort}
      MESSAGE
    end
  end
end

created time in 10 days

push eventioki-mobility/ioki-ruby

Eike Send

commit sha cb46191985c00ef69bb9b95b739a36a20f44574a

Fixes gem name, url and gemspec file name

view details

push time in 11 days

push eventioki-mobility/ioki-ruby

Eike Send

commit sha 1380620c6a85a8e3589f39ebe58f132bf62caee6

Fixes gem name, url and gemspec file name

view details

push time in 11 days

create barnchioki-mobility/ioki-ruby

branch : fix-gemspec

created branch time in 11 days

push eventioki-mobility/ioki-ruby

Eike Send

commit sha 3fb17943f62a2adfbce2e4e85f700ad2f0024555

Fixes #31 VCR::Errors due to mismatch in API_BASE_URL in test setup when run locally

view details

push time in 12 days

create barnchioki-mobility/ioki-ruby

branch : issue-31

created branch time in 12 days

issue commentioki-mobility/ioki-ruby

VCR::Errors due to mismatch in API_BASE_URL in test setup

Setting the env variable in the spec helper was the simplest:

ENV['IOKI_PLATFORM_API_BASE_URL']  ||= "https://demo.io.ki/api/"
ENV['IOKI_PASSENGER_API_BASE_URL'] ||= "https://demo.io.ki/api/"
ENV['IOKI_DRIVER_API_BASE_URL']    ||= "https://demo.io.ki/api/"
eikes

comment created time in 13 days

issue openedioki-mobility/ioki-ruby

VCR::Errors due to mismatch in API_BASE_URL in test setup

I just cloned this repository and noticed that the spec/ioki/vcr tests all failed with similar messages:

 VCR::Errors::UnhandledHTTPRequestError:

   ================================================================================
   An HTTP request has been made that VCR does not know how to handle:
     GET https://app.io.ki/api/platform/providers

The reason seems to be, that in the spec/fixtures/vcr_cassettes files the https://demo.io.ki/api/ API_BASE_URL is used, but this is not configured by default in the test setup where https://app.io.ki/api/ is used.

I was able to fix this by exporting the appropriate ENV variables as it is done in the .github/ci_workflow.env file:

export IOKI_PLATFORM_API_BASE_URL="https://demo.io.ki/api/"
export IOKI_PASSENGER_API_BASE_URL="https://demo.io.ki/api/" 
export IOKI_DRIVER_API_BASE_URL="https://demo.io.ki/api/"

This should be documented somewhere or maybe simply use the https://app.io.ki/api/ API_BASE_URL in the VCR files as well and remove these ENV vars from the CI setup? Or set the ENV variable in the spec_helper.rb file?

created time in 13 days

startedcanonical/multipass

started time in 17 days

pull request commentrails/rails

Improves ActionView FormHelper check_box documentation [ci-skip]

I don't think that the :include_hidden option should be at the very bottom, while the other options are at the top, it seems too spread out.

Instead I took a look at how the options of other methods in this class are documented and adopted their approach where the options have their own section.

eikes

comment created time in 2 months

push eventeikes/rails

Eike S

commit sha 9b368645959c3a97a14857368d932b9ec27f2ce3

Improves ActionView FormHelper check_box documentation The ActionView::Helpers::Tags::CheckBox class accepts the `checked` and `include_hidden` options. The documentation for these options is added to the `check_box` methods in the ActionView::Helpers::FormHelper class where they are exposed. Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>

view details

push time in 2 months

Pull request review commentrails/rails

Improves ActionView FormHelper check_box documentation [ci-skip]

 def text_area(object_name, method, options = {})       # To prevent this the helper generates an auxiliary hidden field before       # the very check box. The hidden field has the same name and its       # attributes mimic an unchecked check box.+      # To disable the hidden field pass <code>include_hidden: false</code> in the options hash.       #       # This way, the client either sends only the hidden field (representing

I see what you mean. How about this:

  # To prevent this the helper generates an auxiliary hidden field before
  # the very check box. The hidden field (which can be removed using the 
  # <code>include_hidden: false</code> option) has the same name and its
  # attributes mimic an unchecked check box.
eikes

comment created time in 2 months

PullRequestReviewEvent

push eventeikes/rails

Eike S

commit sha c45f4f21270dc7ea672e445c95915e62d95ee7b5

Improves ActionView FormHelper check_box documentation The ActionView::Helpers::Tags::CheckBox class accepts the `checked` and `include_hidden` options. The documentation for these options is added to the `check_box` methods in the ActionView::Helpers::FormHelper class where they are exposed. Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>

view details

push time in 2 months

push eventeikes/rails

Eike S

commit sha 4ebc748dccdd8f7d04aff07066c5f7c789edd930

Improves ActionView FormHelper check_box documentation The ActionView::Helpers::Tags::CheckBox class accepts the `checked` and `include_hidden` options. The documentation for these options is added to the `check_box` methods in the ActionView::Helpers::FormHelper class where they are exposed.

view details

Eike S

commit sha 82cd06e7aab870f24cdbab487b96a7368b31291b

Apply suggestions from code review Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>

view details

Eike S

commit sha a7ac35341c58d9ac7db08ccc7603f487d06e3f2f

Removes trailing whitespace

view details

push time in 2 months

more