profile
viewpoint

firebase/snippets-node 248

Node.js snippets for firebase.google.com

egilmorez/firebase-js-sdk 0

Firebase Javascript SDK

egilmorez/functions-samples 0

Collection of sample apps showcasing popular use cases using Cloud Functions for Firebase

egilmorez/gcm 0

Automatically exported from code.google.com/p/gcm

egilmorez/google-services 0

A collection of quickstart samples demonstrating the Google APIs for Android and iOS

egilmorez/quickstart-android 0

Firebase Quickstart Samples for Android

egilmorez/quickstart-ios 0

Firebase Quickstart Samples for iOS

egilmorez/quickstart-java 0

Quickstart samples for Firebase Java Admin SDK

delete branch firebase/firebase-admin-node

delete branch : egilmorez-typo-1

delete time in 12 days

push eventfirebase/firebase-admin-node

egilmorez

commit sha aea280d325c202fedc3890850d8c04f2f7e9cd54

Update base-auth.ts (#1501) Fixing typo uncovered in an internal changelist.

view details

push time in 12 days

PR merged firebase/firebase-admin-node

Update base-auth.ts

Fixing typo uncovered in an internal changelist.

+2 -2

0 comment

1 changed file

egilmorez

pr closed time in 12 days

PR opened firebase/firebase-admin-node

Reviewers
Update base-auth.ts

Fixing typo uncovered in an internal changelist.

+2 -2

0 comment

1 changed file

pr created time in 13 days

create barnchfirebase/firebase-admin-node

branch : egilmorez-typo-1

created branch time in 13 days

Pull request review commentfirebase/firebase-js-sdk

Add getBytes()

 export { } from './implementation/taskenums'; export { StringFormat }; +/**+ * Downloads the data at the object's location. Returns an error if the object+ * is not found.+ *+ * To use this functionality, you have to whitelist your app's origin in your+ * Cloud Storage bucket. See also+ * https://cloud.google.com/storage/docs/configuring-cors+ *+ * @public

I was hoping @markarndt could give that a go . . . but if he's too busy and there's urgency, I can take a look this afternoon for sure.

schmidt-sebastian

comment created time in 19 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentfirebase/firebase-js-sdk

Allow type T in WithFieldValue<T>

+---+'@firebase/firestore': minor+---++Expanded `Firestore.WithFieldValue<T>` to include `T`. This allows developers to delegate `WithFieldValue<T>` inside a wrappers of type `T` to avoid exposing Firebase types beyond Firebase-specific logic.

I think "a wrappers" should just be "wrappers"

thebrianchen

comment created time in a month

PullRequestReviewEvent

pull request commentfirebase/firebase-js-sdk

AppCheck integration for Firestore

Adding Kevin and Mark for doc review. Thanks!

ehsannas

comment created time in a month

PullRequestReviewEvent

push eventfirebase/snippets-node

Sam

commit sha 762c22ae3bd4dc4fdf01b795e878de6fa81248bb

Update to exp version

view details

Sam

commit sha eba953defb025168d8b98ae3cb029323749d5a89

Update auth snippets

view details

Sam

commit sha 39cda2c4029e24f8f5a2d7cea3de9dab3bfc1e3d

Remote config

view details

Sam

commit sha e95db7c7ab614facb8401987594e9ab85f7a8698

FirebaseApp

view details

Sam

commit sha ec05596a51b1201217cffc611d941f7ec1745215

Firestore

view details

Sam

commit sha f65c6f4bb0307722821189c7addbad11c23d6ed6

Management

view details

Sam

commit sha 9ae0a1189557071195e91ca5421a8676ec6ba82b

Move to const/require

view details

Sam

commit sha 02e329be1f3c75c16773cc382e1ff61b5cbc9bfe

Fix import

view details

Sam

commit sha ecd6fc74ad589895d7c2f09642a0078bf33d2c32

Drop Node 10 support

view details

Sam Stern

commit sha 138f4b3ea21272ae4d6912a9dc14360a97ba556b

Merge branch 'master' into modular-admin

view details

Sam

commit sha 027ef5bfb80499052439bda1ef28c37dbfbdc290

Merge branch 'master' into modular-admin

view details

Sam

commit sha 1417029514e9ab8b65daa394e3c280b7729f8a4c

Merge branch 'modular-admin' of github.com:firebase/snippets-node into modular-admin

view details

Sam

commit sha 05110e3983885c0e4f0bc5e962d3d04298f2f1bb

Downgrade SDK where functions is used

view details

Sam

commit sha 0d309f546fabf0bc4397b0fb2d29002fbac22397

Fix compilation issues

view details

Sam

commit sha 3829184036ec81af0ce89103de961747f068a005

Merge branch 'master' into HEAD

view details

Sam

commit sha eecfc0b5d9dd44187155e86fdf6a6d5000047850

Bootstrap

view details

Sam

commit sha d59c18a85db9a286ee935ca5c341fc3f5a00002f

functions-stackdriver-logging

view details

Sam

commit sha 396cdfd38e8d5d5caffd34017cc4fc0acd6b6d5b

firestore-extend-with-functions

view details

Sam

commit sha 37da9bfeb7aae5631ac23503df4d6b35d3605982

firestore-solution-aggregation

view details

Sam

commit sha 000c07203e123d0d47f18fdb488194d51852da06

auth-functions

view details

push time in a month

PR merged firebase/snippets-node

Reviewers
Update to new modular Admin SDK cla: yes

Breaking:

  • [x] Update to new Admin SDK
  • [x] Drop Node 10 support

Products:

  • [x] auth
  • [x] config
  • [x] database
  • [x] firebaseapp
  • [x] firestore
  • [x] functions
  • [x] management
  • [x] messaging
  • [x] storage

TODO Before Submit:

  • [x] Figure out how to make it work with firebase-functions
  • [x] Replace exp with real version

TODO After Submit:

  • [ ] Update auth custom claims functions snippet (it moved)
+2758 -944

2 comments

55 changed files

samtstern

pr closed time in a month

pull request commentfirebase/snippets-node

Update to new modular Admin SDK

Going to go ahead and merge this and publish the docs that contain these. Thanks!

samtstern

comment created time in a month

Pull request review commentfirebase/firebase-admin-node

chore: Enabled tsdoc error checking

 export interface FirebaseError {    * A string value containing the execution backtrace when the error originally    * occurred.    *-   * This information can be useful to you and can be sent to+   * This information can be useful for troubleshooting the cause of the error with

Oh, I should have clarified that the rephrase means we could omit "to help

  • explain the cause of an error." We should just end with a period after {@link https://firebase.google.com/support | Firebase Support} I think.
hiranya911

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentfirebase/firebase-admin-node

chore: Enabled tsdoc error checking

 export interface FirebaseError {    * occurred.    *    * This information can be useful to you and can be sent to-   * {@link https://firebase.google.com/support/ Firebase Support} to help+   * {@link https://firebase.google.com/support | Firebase Support} to help

Is it easy to update this text?

I'm wondering whether "sent to" is the best phrasing. That link takes you through the troubleshooter and finally to submitting a support case.

WDYT about text like "This information can be useful for troubleshooting the cause of the error with Firebase Support"

hiranya911

comment created time in 2 months

Pull request review commentfirebase/firebase-admin-node

chore: Enabled tsdoc error checking

 export class AppCheckTokenGenerator {  * Creates a new FirebaseAppCheckError by extracting the error code, message and other relevant  * details from a CryptoSignerError.  *- * @param err The Error to convert into a FirebaseAppCheckError error+ * @param err - The Error to convert into a FirebaseAppCheckError error

Looks like FirebaseAppCheckError should be backticked.

hiranya911

comment created time in 2 months

Pull request review commentfirebase/firebase-admin-node

chore: Enabled tsdoc error checking

 export class UserInfo {     /**-   * @param response The server side response returned from the getAccountInfo+   * @param response - The server side response returned from the getAccountInfo

Should instances of getAccountInfo be literals?

hiranya911

comment created time in 2 months

Pull request review commentfirebase/firebase-admin-node

chore: Enabled tsdoc error checking

 export class AppCheckApiClient {   /**    * Exchange a signed custom token to App Check token    *-   * @param customToken The custom token to be exchanged.-   * @param appId The mobile App ID.+   * @param customToken - The custom token to be exchanged.

Are these single dashes, double dashes, or an "em dash?"

Curious if this is our choice our a Rushstack standard.

hiranya911

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentfirebase/firebase-functions

Tries to fix v1 docs.

As we noted in offline discussions:

  1. To make the v1 TOC work as usual, we'd need to change back the v2-ish values in https://github.com/firebase/firebase-functions/blob/master/docgen/theme/layouts/default.hbs

  2. Filenames linked from index.html generated with this PR don't match the actual HTML filenames. I think/hope that could be fixed in the script, but am not sure exactly how.

Values for 1) would be:

<meta name="book_path" value="/docs/reference/_book.yaml" /> <meta name="gtm_var" data-key="docType" data-value="reference">

Thanks!

mbleigh

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
more