profile
viewpoint

eggyal/backtrace-rs 0

Backtraces in Rust

eggyal/cargo-xbuild 0

Automatically cross-compiles the sysroot crates core, compiler_builtins, and alloc.

eggyal/h2 0

HTTP 2.0 client & server implementation for Rust.

eggyal/headers 0

Typed HTTP Headers from hyper

eggyal/http 0

Rust HTTP types

eggyal/hyper 0

An HTTP library for Rust

eggyal/mach 0

A rust interface to the Mach 3.0 kernel that underlies OSX.

eggyal/nom 0

Rust parser combinator framework

eggyal/paste 0

Macros for all your token pasting needs

issue commentbbqsrc/cucumber-rust

println! in steps

Hey thank you @bbqsrc that is good enough for my needs at the moment!

Chocrates

comment created time in a day

issue commentbbqsrc/cucumber-rust

println! in steps

If you run cargo test -- --nocapture, all stdout will be printed (this is true for the ordinary tests and Cucumber tests). It might be nicer however to have a specific and clean way to capture and print it while debugging a step, but this is what we have for now. 😄

Chocrates

comment created time in a day

pull request commentbbqsrc/cucumber-rust

Implement failure reporting

Thanks! Only thing left from my original suggestion is a run_and_exit function, so I would happily accept a PR for that, otherwise I'm sure someone will get to it, if not me. 😄

gnunicorn

comment created time in a day

push eventbbqsrc/cucumber-rust

Benjamin Kampmann

commit sha ad6c23c5d487b193e5bbd14d0f5038d86e243159

Implement failure reporting (#91)

view details

push time in a day

PR merged bbqsrc/cucumber-rust

Implement failure reporting

Currently when running Cucumber..run() nothing it reported back to the caller. This changes this behavior by making the result value a result with either () in the regular case (arguably could be the number of successes or something) and u64 if any errors have been found. This number also equals the total number of failure found.

To implement this a handy function failed() is added to the various events allowing for checking down the tree whether the currently reported item reports a failure or not. All functions have minimal rustdoc documentation added.

+246 -108

8 comments

6 changed files

gnunicorn

pr closed time in a day

issue commentbjorn3/rustc_codegen_cranelift

Unable to compile funty on MacOS

The rotate_left and rotate_right methods indirectly use intrinsics that lower to the rotl and rotr clif instructions. These are not yet supported for bit widths less than 32 bit. (https://github.com/bytecodealliance/wasmtime/issues/1045) If funty were to mark all methods as #[inline], which they likely should, this wouldn't be a problem unless they were actually used.

vultix

comment created time in a day

create barnchbjorn3/rustc_codegen_cranelift

branch : wip_abi_refactor

created branch time in 2 days

issue openedbjorn3/rustc_codegen_cranelift

Unable to compile funty on MacOS

funty is a crate required by sqlx. To reproduce the build error, add this as a dependency:

funty = "1.0.1"

This is the error message I'm seeing:

thread 'rustc' panicked at 'ABI argument v5 should be in a register', /Users/aidan/.cargo/git/checkouts/wasmtime-41807828cb3a7a7e/1964036/cranelift/codegen/src/regalloc/coloring.rs:409:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.50.0-nightly (593fe977a 2020-11-20) running on x86_64-apple-darwin

note: compiler flags: -C embed-bitcode=no -C debuginfo=2 -C link-arg=-undefined -C link-arg=dynamic_lookup --crate-type lib

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
end of query stack
Instance { def: Item(WithOptConstParam { did: DefId(2:18122 ~ core[343e]::num::{impl#6}::rotate_left), const_param_did: None }), substs: [] } _ZN4core3num20_$LT$impl$u20$u8$GT$11rotate_left17h4a9f2e335f0d4da1E
error: could not compile `funty`

created time in 2 days

push eventWebAssembly/proposals

Daniel Ehrenberg

commit sha 925a55814c5cecec52a94ec123b157f1485cff65

Module types was renamed to module linking (#86) * Module types was renamed to module linking * Move Module Linking to phase 1 Co-authored-by: Sergey Rubanov <chi187@gmail.com>

view details

push time in 2 days

PR merged WebAssembly/proposals

Module types was renamed to module linking

Is it still Phase 0 or did it go to Phase 1 at some point?

+2 -2

6 comments

1 changed file

littledan

pr closed time in 2 days

pull request commentWebAssembly/proposals

Module types was renamed to module linking

@littledan thanks! I've rebased on master and moved it to phase 1

littledan

comment created time in 2 days

issue openedbjorn3/rustc_codegen_cranelift

Add option to instrument which functions are used by which test

See https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Live.20unit.20testing/near/217883005

With lazy compilation instrumenting would be trivial. It wouldn't even be necessary to add instrumentation calls in the jitted code. Just record the function call when you lazily compile a function. You could reset the GOT used for swapping all calls from the lazy compilation stub to the jitted code back to the lazy compilation stubs after every test and then as optimization keep a pointer to the jitted code in a side-table.

created time in 2 days

issue commentbbqsrc/cucumber-rust

Support pass-through for all arguments that `cargo test` supports

@privalou https://github.com/bbqsrc/cucumber-rust/blob/2d5de3261fe9ec2368cee96eaed36d11cb786287/src/cucumber.rs#L131

humb1t

comment created time in 2 days

issue openedbbqsrc/cucumber-rust

println! in steps

Is it possible to print data to the console in steps for debugging? It would be very useful while trying to get your regex right.

So something like this:

builder
    .given_regex_async(
        r#"^([a-z]$)",
        t!(|mut world, _match, _step| {
            println!("Hello World!");
            world
         }),
    );

created time in 2 days

PR opened demurgos/c88

Bump highlight.js from 9.18.1 to 9.18.5

Bumps highlight.js from 9.18.1 to 9.18.5. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/highlightjs/highlight.js/blob/9.18.5/CHANGES.md">highlight.js's changelog</a>.</em></p> <blockquote> <h2>Release v9.18.5</h2> <p><strong>Version 9 has reached end-of-support and will not receive future updates or fixes.</strong></p> <p>Please see <a href="https://github.com/highlightjs/highlight.js/blob/master/VERSION_10_UPGRADE.md">VERSION_10_UPGRADE.md</a> and perhaps <a href="https://github.com/highlightjs/highlight.js/blob/master/SECURITY.md">SECURITY.md</a>.</p> <ul> <li>enh: Post-install script can be disabled with <code>HLJS_HIDE_UPGRADE_WARNING=yes</code></li> <li>fix: Deprecation notice logged at library startup a <code>console.log</code> vs <code>console.warn</code>. <ul> <li>Notice only shown if actually highlighting code, not just requiring the library.</li> <li>Node.js treats <code>warn</code> the same as <code>error</code> and that was problematic.</li> <li>You (or perhaps your indirect dependency) may disable the notice with the <code>hideUpgradeWarningAcceptNoSupportOrSecurityUpdates</code> option</li> <li>You can also set <code>HLJS_HIDE_UPGRADE_WARNING=yes</code> in your envionment to disable the warning</li> </ul> </li> </ul> <p>Example:</p> <pre lang="js"><code>hljs.configure({ hideUpgradeWarningAcceptNoSupportOrSecurityUpdates: true }) </code></pre> <p>Reference: <a href="https://github-redirect.dependabot.com/highlightjs/highlight.js/issues/2877">highlightjs/highlight.js#2877</a></p> <h2>Release v9.18.4</h2> <p><strong>Version 9 has reached end-of-support and will not receive future updates or fixes.</strong></p> <p>Please see <a href="https://github.com/highlightjs/highlight.js/blob/master/VERSION_10_UPGRADE.md">VERSION_10_UPGRADE.md</a> and perhaps <a href="https://github.com/highlightjs/highlight.js/blob/master/SECURITY.md">SECURITY.md</a>.</p> <ul> <li>fix(livescript) fix potential catastrophic backtracking (<a href="https://github-redirect.dependabot.com/highlightjs/highlight.js/pull/2852">#2852</a>) [<a href="https://github-redirect.dependabot.com/highlightjs/highlight.js/pull/2852/commits/ebaf171d2b3a21961b605aa6173a6a4c57346194">commit</a>]</li> </ul> <h2>Version 9.18.3</h2> <ul> <li>fix(parser) Freezing issue with illegal 0 width illegals (<a href="https://github-redirect.dependabot.com/highlightjs/highlight.js/issues/2524">#2524</a>) <ul> <li>backported from v10.x</li> </ul> </li> </ul> <h2>Version 9.18.2</h2> <p>Fixes:</p> <ul> <li>fix(night) Prevent object prototype values from being returned by <code>getLanguage</code> (<a href="https://github-redirect.dependabot.com/highlightjs/highlight.js/issues/2636">#2636</a>) <a href="https://github.com/night">night</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/highlightjs/highlight.js/commit/f54e96c24325f077a027bb950dcd9f8f3ef48b16"><code>f54e96c</code></a> 9.18.5</li> <li><a href="https://github.com/highlightjs/highlight.js/commit/c34318b6a720a0852d27cd13dc55ca896e1292ec"><code>c34318b</code></a> fix the link since i saw it</li> <li><a href="https://github.com/highlightjs/highlight.js/commit/d2e9bdd7597e308534fc2b0fc4aa2f935895a45d"><code>d2e9bdd</code></a> include date of last release</li> <li><a href="https://github.com/highlightjs/highlight.js/commit/f5e06454216644cf20d7c9275d42e37707281a8e"><code>f5e0645</code></a> typos and tweaks</li> <li><a href="https://github.com/highlightjs/highlight.js/commit/2e0e8ee996eb5b3f5c4ab25b60d910690a0e7258"><code>2e0e8ee</code></a> changelog</li> <li><a href="https://github.com/highlightjs/highlight.js/commit/dc45f7cd21fe51a4cbb23fb36459982d1e06a6d5"><code>dc45f7c</code></a> fix(livescript) fix potential catastrophic backtracking</li> <li><a href="https://github.com/highlightjs/highlight.js/commit/0a2624afb8dc71ef01815b49709481f06914474a"><code>0a2624a</code></a> update readme</li> <li><a href="https://github.com/highlightjs/highlight.js/commit/d571b235c0c079ef971965a5a540eec5d68b531c"><code>d571b23</code></a> add warning</li> <li><a href="https://github.com/highlightjs/highlight.js/commit/ec0bfd5490ca1ec667c9c2b528b364f10b9ea71d"><code>ec0bfd5</code></a> 9.18.4</li> <li><a href="https://github.com/highlightjs/highlight.js/commit/2a04835c959f0adb18e7a3649aa68350c0286101"><code>2a04835</code></a> bump v9.18.3</li> <li>Additional commits viewable in <a href="https://github.com/highlightjs/highlight.js/compare/9.18.1...9.18.5">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+14 -220

0 comment

1 changed file

pr created time in 2 days

create barnchdemurgos/c88

branch : dependabot/npm_and_yarn/highlight.js-9.18.5

created branch time in 2 days

pull request commentbbqsrc/cucumber-rust

Implement failure reporting

Should be good to go :) .

gnunicorn

comment created time in 2 days

delete branch WebAssembly/proposals

delete branch : wat-data-segments

delete time in 2 days

push eventWebAssembly/proposals

Sergey Rubanov

commit sha 4cf7e008f8295237ea965d1476c9cd5b022be2d9

Move Numeric Values in WAT Data Segments to phase 2 (#92) per [November 24th CG meeting](https://github.com/WebAssembly/meetings/blob/master/main/2020/CG-11-24.md)

view details

push time in 2 days

issue commentbbqsrc/cucumber-rust

README is confusing - it possibly has errors

The readme will be replaced by a book. In the mean time, there is Florian's tutorial.

saveriomiroddi

comment created time in 3 days

pull request commentbbqsrc/cucumber-rust

Implement failure reporting

Nice. :smile: Any other changes or do you think it's ready?

gnunicorn

comment created time in 3 days

create barnchWebAssembly/proposals

branch : wat-data-segments

created branch time in 3 days

pull request commentbbqsrc/cucumber-rust

Implement failure reporting

Can you rebase onto the current main and force push your branch? CI should hopefully run then. 🙂

gnunicorn

comment created time in 3 days

push eventbbqsrc/cucumber-rust

Brendan Molloy

commit sha f7520fb1ffa7622bacd48c01abd88a85bed822d2

Run CI on pull request

view details

push time in 3 days

Pull request review commentbbqsrc/cucumber-rust

Implement failure reporting

 impl<W: World> Cucumber<W> {         let mut stream = runner.run();          while let Some(event) = stream.next().await {+            let ret = {+                if let crate::event::CucumberEvent::Finished(ref result) = event {+                    Some(result.clone())+                } else {+                    None+                }+            };+             self.event_handler.handle_event(event);++            if let Some(res) = ret {+                return res+            }         }++        unimplemented!("Programmer Error - run _must end_ with the Finished Event")

It is a bit of a code smell, and at a glance I don't see a way to make the logic nicer. Maybe the ref change will make it more flexible.

In any case, if you need to keep it, I'd change this to panic!("Invariant broken: no Finish event found before stream ended") or something similar.

gnunicorn

comment created time in 3 days

Pull request review commentbbqsrc/cucumber-rust

Implement failure reporting

 impl<W: World> Cucumber<W> {         let mut stream = runner.run();          while let Some(event) = stream.next().await {+            let ret = {

Change handle_event to take a reference. 👍

gnunicorn

comment created time in 3 days

Pull request review commentbbqsrc/cucumber-rust

Implement failure reporting

 impl<W: World> Cucumber<W> {         let mut stream = runner.run();          while let Some(event) = stream.next().await {+            let ret = {+                if let crate::event::CucumberEvent::Finished(ref result) = event {+                    Some(result.clone())+                } else {+                    None+                }+            };+             self.event_handler.handle_event(event);++            if let Some(res) = ret {+                return res+            }         }++        unimplemented!("Programmer Error - run _must end_ with the Finished Event")

another quirk of the implementation: theoretically the stream could end without the proper result being yielded and then we'd run into this here. not sure how to make this nicer...

gnunicorn

comment created time in 3 days

Pull request review commentbbqsrc/cucumber-rust

Implement failure reporting

 impl<W: World> Cucumber<W> {         let mut stream = runner.run();          while let Some(event) = stream.next().await {+            let ret = {

this is a bit ugly but the only way to keep the result around without cloning every event. Cleaner (here) would be to change the handle_event to take a reference instead of the value, which would also allow for using more than one handler at a time...

gnunicorn

comment created time in 3 days

more