profile
viewpoint
Adrián Estrada edsadr MedellinJS Medellin, Colombia

colombia-dev/leonel 46

Director de inteligencia artificial - colombia.dev

coljs/workshop-microservices-micro 22

A demo using Zeit's micro

edsadr/graphql101 17

A gentle introduction to a different API paradigm

c4milo/gitd 11

Git Smart HTTP Backend

edsadr/change-api 3

Change.org API client - module for io.js/NodeJS

edsadr/iojs-es 2

Localización y traducción de io.js a Español

edsadr/Meteor-Rock-Paper-Scissors 2

This is a simple application allowing multiple users to play and watch rock, paper, scissors games, it allows users to create accounts or login using GitHub.

edsadr/docker-tutorial 1

For use with the accompanying blog post: https://nodesource.com/blog/dockerizing-your-nodejs-applications

edsadr/edsadr-card 1

An NPM module to display my info

edsadr/hb-default-ejs-less 1

Harp default template but using EJS instead of Jade

PR closed edsadr/circle-ci-demo

Adding a README
+29 -0

0 comment

1 changed file

edsadr

pr closed time in 12 days

delete branch edsadr/installer

delete branch : error-handler

delete time in 12 days

PR closed nodejs/installer

Implement basic error handler

This implements all basic errors that should be covered for an Electron app, I would like also start discussing the implementation for a Crash reporter service using https://electron.atom.io/docs/api/crash-reporter/

+59 -0

4 comments

2 changed files

edsadr

pr closed time in 12 days

delete branch edsadr/proxyline

delete branch : bud-support

delete time in 12 days

PR closed tellnes/proxyline

Bud support

Bud has a custom proxyline not being supported right now:

'BUD {"family":"TCP4","bud":{"host":"...","port":...},"peer":{...}'

This PR implements support for it, and also adds a proper package.json with the same info

+91 -32

6 comments

4 changed files

edsadr

pr closed time in 12 days

PR closed hypatia/virtuoso

Adding spanish version
+128 -0

3 comments

1 changed file

edsadr

pr closed time in 12 days

PR closed harp-boilerplates/registry

Adding a very basic template

ejs and less ... not sure why is currently missing

+1 -0

0 comment

1 changed file

edsadr

pr closed time in 12 days

PR closed thomasstreet/famous-angular-docs

Fixing the sidebar

as is messed and is really hard to read he docs as it is right now

+24 -18

0 comment

2 changed files

edsadr

pr closed time in 12 days

pull request commentnodejs/node

benchmark: fixing http_server_for_chunky_client.js

ping @nodejs/benchmarking

edsadr

comment created time in 19 days

issue commentcypress-io/cypress

SIGSEGV after passing all tests

yeah.... same problem in our CI:

The Test Runner unexpectedly exited via a exit event with signal SIGSEGV

Please search Cypress documentation for possible solutions:
https://on.cypress.io

Check if there is a GitHub issue describing this crash:

https://github.com/cypress-io/cypress/issues

Consider opening a new issue.

Platform: linux (Ubuntu Linux - 18.04)    
Cypress Version: 4.5.0
bwiklund

comment created time in 20 days

PR opened nodejs/node

benchmark: fixing http_server_for_chunky_client.js

This PR fixes a broken benchmark due to the http header's size restriction introduced earlier

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines
+8 -2

0 comment

1 changed file

pr created time in 21 days

create barnchedsadr/node

branch : edsadr/http-benchmark-fix

created branch time in 21 days

delete branch edsadr/node

delete branch : edsadr/unused-namespace-task-queue

delete time in 24 days

PR closed nodejs/node

src: remove unused v8 Message namespace C++ author ready

Small nit removing an unused namespace in src/node_task_queue.cc

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+0 -1

3 comments

1 changed file

edsadr

pr closed time in 24 days

pull request commentnodejs/node

src: remove unused v8 Message namespace

landed in b0aba53

edsadr

comment created time in 24 days

push eventnodejs/node

Adrian Estrada

commit sha b0aba53195530a95688c9d5f274f854fd423da5c

src: remove unused v8 Message namespace PR-URL: https://github.com/nodejs/node/pull/33180 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

push time in 24 days

startedjasnell/piscina

started time in 24 days

startedjasnell/piscina

started time in 24 days

Pull request review commentnodejs/node

test: add tests for options.fs in fs streams

+'use strict';++require('../common');+const fixtures = require('../common/fixtures');+const path = require('path');+const fs = require('fs');+const assert = require('assert');++const tmpdir = require('../common/tmpdir');+tmpdir.refresh();++const writeStreamOptions = ['open', 'close', 'write', 'writev'];+const readStreamOptions = ['open', 'close', 'read'];++{+  const file = path.join(tmpdir.path, 'write-end-test0.txt');++  writeStreamOptions.forEach((fn) => {+    const opts = {+      fs: {+        [fn]: null+      }+    };+    assert.throws(+      () => fs.createWriteStream(file, opts), { code: 'ERR_INVALID_ARG_TYPE' }+    );+  });+}++{+  const file = fixtures.path('x.txt');+  readStreamOptions.forEach((fn) => {+    const opts = {+      fs: {+        [fn]: null+      }+    };+    assert.throws(+      () => fs.createReadStream(file, opts), { code: 'ERR_INVALID_ARG_TYPE' }

same as above 🙂

julianduque

comment created time in a month

Pull request review commentnodejs/node

test: add tests for options.fs in fs streams

+'use strict';++require('../common');+const fixtures = require('../common/fixtures');+const path = require('path');+const fs = require('fs');+const assert = require('assert');++const tmpdir = require('../common/tmpdir');+tmpdir.refresh();++const writeStreamOptions = ['open', 'close', 'write', 'writev'];+const readStreamOptions = ['open', 'close', 'read'];++{+  const file = path.join(tmpdir.path, 'write-end-test0.txt');++  writeStreamOptions.forEach((fn) => {+    const opts = {+      fs: {+        [fn]: null+      }+    };+    assert.throws(+      () => fs.createWriteStream(file, opts), { code: 'ERR_INVALID_ARG_TYPE' }

Would be nice to include a custom message including the method being executed, so if one fails it will be easier to identify, also, could be possible to validate the Error message too

julianduque

comment created time in a month

PR opened nodejs/node

src: remove unused v8 Message namespace

Small nit removing an unused namespace in src/node_task_queue.cc

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+0 -1

0 comment

1 changed file

pr created time in a month

create barnchedsadr/node

branch : edsadr/unused-namespace-task-queue

created branch time in a month

push eventedsadr/node

龙腾道

commit sha 4439009d6531230f2f15992483d136bcc416c6ae

lib: fix return type of setTimeout in net.Socket Function setTimeout in net.Socket should return this, not undefined, as doc said. PR-URL: https://github.com/nodejs/node/pull/32722 Refs: https://nodejs.org/api/net.html#net_socket_settimeout_timeout_callback Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

himself65

commit sha 1c4b20546ab3300a16a71ed815679a1902ca59a8

src: remove duplicated code PR-URL: https://github.com/nodejs/node/pull/32719 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Juan José Arboleda

commit sha 468d05aa8544fdaeb11ffcc72263927d2f889ab1

src: remove unused v8::TryCatch namespace PR-URL: https://github.com/nodejs/node/pull/32729 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Nimit

commit sha df05b0785b9e611a41fe9bad704a6df630fe439b

doc: add useful v8 option section This adds new section for v8 options and --max-old-space-size Fixes: https://github.com/nodejs/node/issues/32252 PR-URL: https://github.com/nodejs/node/pull/32262 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Richard Lau

commit sha ce21749742d4211638a38e0e5a0364478de8a9c9

build: move doc versions JSON file out of out/doc Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32728 Fixes: https://github.com/nodejs/build/issues/2276 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Juan José Arboleda

commit sha 5c535386ac6f352f56663737e90a72ffb4a750b3

doc: replace node-test-pull-request-lite-pipeline from onboarding Replace the obsolete node-test-pull-request-lite-pipeline CI task in favour of node-test-pull-request. PR-URL: https://github.com/nodejs/node/pull/32736 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Michaël Zasso

commit sha 57aba5e454d86b5142074d44225e64e6d63440b4

build: output dots instead of tap in GitHub actions This makes the output much smaller and lets us focus on errors if there are any. PR-URL: https://github.com/nodejs/node/pull/32714 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Beth Griggs

commit sha 8d93df41b0f0ca1824e485bd1612953bdb0bb5ce

2020-04-12 Node.js v10.20.1 'Dubnium' (LTS) Release Notable changes: Due to release process failures, Node.js v10.20.0 shipped with source and header tarballs that did not properly match the final release commit that was used to build the binaries. We recommend that Node.js v10.20.0 not be used, particularly in any applications using native add-ons or where compiling Node.js from source is involved. Node.js v10.20.1 is a clean release with the correct sources and is strongly recommended in place of v10.20.0. PR-URL: https://github.com/nodejs/node/pull/32768

view details

Jesus Hernandez

commit sha a8c243109654fd1cfcfeedf8ec351fea87a2df68

src: removes unused v8::Integer and v8::Array namespace PR-URL: https://github.com/nodejs/node/pull/32779 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Robert Nagy

commit sha cf888ac105ffd02bbceef02c16d0df548676abd1

doc: add link to code ide configs Refs: https://github.com/nodejs/node/issues/32764 PR-URL: https://github.com/nodejs/node/pull/32767 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Anna Henningsen

commit sha a46345d8af634994e51c10f8756148b037cf05b7

worker: fix type check in receiveMessageOnPort Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: https://github.com/nodejs/node/issues/32742 PR-URL: https://github.com/nodejs/node/pull/32745 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Andrey Pechkurov

commit sha 38bf1beea923f7f1f03b93b686db131f2a2f71ee

doc: add puzpuzpuz to collaborators PR-URL: https://github.com/nodejs/node/pull/32817 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

John Kleinschmidt

commit sha 8866ff5ab192bff10d641febfeb48b2ffd02a913

test: use symlinks to copy shells Git for Windows includes `C:\Program Files\Git\bin\bash.exe`, which spawns ..\usr\bin\bash.exe, so copying that executable won't work. However, if a symlink is used to test paths with spaces, this executable will still work. PR-URL: https://github.com/nodejs/node/pull/32129 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

John Kleinschmidt

commit sha 26924faa54142da4635efdefca311a3f3ec369d2

build: add build from tarball Fixes: https://github.com/nodejs/build/issues/1931 PR-URL: https://github.com/nodejs/node/pull/32129 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Stephen Belanger

commit sha f7f04419973d5fc6090de3c81c5b116e030db8a9

async_hooks: prevent sync methods of async storage exiting outer context PR-URL: https://github.com/nodejs/node/pull/31950 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Andrey Pechkurov

commit sha 50dd63e8eff2e1b760b87b0e6c36315286b80ba3

async_hooks: merge run and exit methods PR-URL: https://github.com/nodejs/node/pull/31950 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Harshitha KP

commit sha 2f755ffc8f06cc5a8ffdd067ced21d495ab68281

doc: document `buffer.from` returns internal pool buffer Fixes: https://github.com/nodejs/node/issues/22139 Co-authored-by: Mritunjay Goutam <mritunjaygoutam2204@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32703 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Juan José Arboleda

commit sha 4e6504ec59b94f28ad8cc5988c385dfbcc001085

src: remove unused v8 Array namespace PR-URL: https://github.com/nodejs/node/pull/32749 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Andrey Pechkurov

commit sha 82d6726dcb4e05a603e971f46956c142f9403968

doc: improve AsyncLocalStorage sample PR-URL: https://github.com/nodejs/node/pull/32757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha bb5e7097e89685787e2a81e67512f32132b4606c

buffer: mark pool ArrayBuffer as untransferable This removes a footgun in which users could attempt to transfer the pooled ArrayBuffer underlying a regular `Buffer`, which would lead to all `Buffer`s that share the same pool being rendered unusable as well, and potentially break creation of new pooled `Buffer`s. This disables this kind of transfer. Refs: https://github.com/nodejs/node/issues/32752 PR-URL: https://github.com/nodejs/node/pull/32759 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in a month

delete branch edsadr/node

delete branch : edsadr/test-event-emitter-invalid-listener

delete time in a month

delete branch edsadr/node

delete branch : edsadr/test-event-capture-rejections-messages

delete time in a month

pull request commentnodejs/node

test: refactor events tests for invalid listeners

great catch @richardlau, just added a custom message per assertion revealing the method being tested, so if one fails you will have clarity which one was

edsadr

comment created time in 2 months

push eventedsadr/node

Adrian Estrada

commit sha 13e3442df76bd101844f74a98ce2cc17d1851ced

test: refactor events tests for invalid listeners

view details

push time in 2 months

push eventedsadr/node

Rich Trott

commit sha 153524300829565b43635efa11a67bde90b99854

doc: split process.umask() entry into two Split doc entries for process.umask() into one entry for process.umask() (which is deprecated) and another for `process.umask(mask)` which is not deprecated. PR-URL: https://github.com/nodejs/node/pull/32711 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 months

PR opened nodejs/node

test: better error validations for event-capture

This PR improves the error validation including messages for test-event-capture-rejections.js

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+10 -2

0 comment

1 changed file

pr created time in 2 months

create barnchedsadr/node

branch : edsadr/test-event-capture-rejections-messages

created branch time in 2 months

push eventedsadr/node

Anna Henningsen

commit sha c66421452686c1f93a708b1edcd4ca8d48037f25

src: make `Environment::interrupt_data_` atomic Otherwise this potentially leads to race conditions when used in a multi-threaded environment (i.e. when used for its very purpose). PR-URL: https://github.com/nodejs/node/pull/32523 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 583edd9526b3b9a6965761c7cf53495957f082ef

src: fix cleanup hook removal for InspectorTimer Fix this to account for the fact that `Stop()` may already have been called from a cleanup hook when the `inspector::Agent` is deleted along with the `Environment`, at which point cleanup hooks are no longer available. PR-URL: https://github.com/nodejs/node/pull/32523 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 32e3a6bb87f2f88b8f54ff9e9f216aa5f5f0a647

src: use env->RequestInterrupt() for inspector io thread start This cleans up `Agent::RequestIoThreadStart()` significantly. PR-URL: https://github.com/nodejs/node/pull/32523 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 6f9f546406820dc9e233380e061081c9bcd1de0b

src: use env->RequestInterrupt() for inspector MainThreadInterface This simplifies the code significantly, and removes the dependency of the inspector code on the availability of a `MultiIsolatePlatform` (by removing the dependency on a platform altogether). It also fixes a memory leak that occurs when `RequestInterrupt()` is used, but the interrupt handler is never called before the Isolate is destroyed. One downside is that this leads to a slight change in timing, because inspector messages are not dispatched in a re-entrant way. This means having to harden one test to account for that possibility by making sure that the stack is always clear through a `setImmediate()`. This does not affect the assertion made by the test, which is that messages will not be delivered synchronously while other code is executing. https://github.com/nodejs/node/issues/32415 PR-URL: https://github.com/nodejs/node/pull/32523 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha a173473ba2e76cce679c7d805b091c3a43556983

src: flush V8 interrupts from Environment dtor This avoids an edge-case memory leak. Refs: https://github.com/nodejs/node/pull/32523#discussion_r399554491 PR-URL: https://github.com/nodejs/node/pull/32523 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 months

PR opened nodejs/node

test: refactor events tests for invalid listeners

This PR refactor some duplicated assertions in different event-emitter tests to a single one

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+20 -44

0 comment

5 changed files

pr created time in 2 months

create barnchedsadr/node

branch : edsadr/test-event-emitter-invalid-listener

created branch time in 2 months

push eventedsadr/node

Anna Henningsen

commit sha e2ea73af0447130ca033b59b62092474ed9f4ec4

test: make sure that inspector tests finish PR-URL: https://github.com/nodejs/node/pull/32673 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Sam Roberts

commit sha fcde1de382b321bb5f91b5550e34216508377d7d

src: sync access for report and openssl options Audited usage of per-process OpenSSL and Report options, adding two required mutexes. Also documented existence and typical use of the per-process cli option mutex. PR-URL: https://github.com/nodejs/node/pull/32618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Beth Griggs

commit sha 9b46e3f7cc237538383ad7c38bc8dc3f0380c80a

2020-04-08, Version 10.20.0 'Dubnium' (LTS) macOS package notarization and a change in builder configuration The macOS binaries for this release, and future 10.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 10.x were compiled on macOS 10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion). As binaries are still being compiled to support a minimum of macOS 10.7 (Lion) we do not anticipate this having a negative impact on Node.js 10.x users with older versions of macOS. Notable changes: - buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](https://github.com/nodejs/node/pull/19691) - build: macOS package notarization (Rod Vagg) [#31459](https://github.com/nodejs/node/pull/31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](https://github.com/nodejs/node/pull/32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](https://github.com/nodejs/node/pull/32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](https://github.com/nodejs/node/pull/31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](https://github.com/nodejs/node/pull/30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](https://github.com/nodejs/node/pull/28682) - define release 6 [#32058](https://github.com/nodejs/node/pull/32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](https://github.com/nodejs/node/pull/26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](https://github.com/nodejs/node/pull/27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](https://github.com/nodejs/node/pull/27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](https://github.com/nodejs/node/pull/26226) PR-URL: https://github.com/nodejs/node/pull/31984

view details

unknown

commit sha 944d8626b37d3096f4c4a0e881c52f3ac2da0213

util: add `maxStrLength` option to `inspect` function Refs: https://github.com/nodejs/node/issues/25478 PR-URL: https://github.com/nodejs/node/pull/32392 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Shelley Vohr

commit sha 6ec0285478391635887cf7f018f1e55e8013e6a4

2020-04-08 Version 12.16.2 'Erbium' (LTS) Notable changes: doc: * add ronag to collaborators (Robert Nagy) [#31498](https://github.com/nodejs/node/pull/31498) * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](https://github.com/nodejs/node/pull/31306) deps: * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](https://github.com/nodejs/node/pull/31304) * update openssl to 1.1.1e (Hassaan Pasha) [#32328](https://github.com/nodejs/node/pull/32328)

view details

Michael Dawson

commit sha 2681cba62e5e08338036c968c93ae467dda3e800

doc: clarify behavior of napi_get_typedarray_info Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> Fixes: https://github.com/nodejs/node/issues/32089 PR-URL: https://github.com/nodejs/node/pull/32603 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

himself65

commit sha 934ef43a62406314b989309793109f35b81561b3

doc: add himself65 to collaborators PR-URL: https://github.com/nodejs/node/pull/32734 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

gengjiawen

commit sha b82d72c199e70a0c9fbeb6c06715ef8120b3de2f

report: fix stderr matching for fatal error PR-URL: https://github.com/nodejs/node/pull/32699 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Gabriel Schulhof

commit sha aeb7084fe6446350ec032e9819746126811bf44f

n-api: detect deadlocks in thread-safe function We introduce status `napi_would_deadlock` to be used as a return status by `napi_call_threadsafe_function` if the call is made with `napi_tsfn_blocking` on the main thread and the queue is full. PR-URL: https://github.com/nodejs/node/pull/32689 Fixes: https://github.com/nodejs/node/issues/32615 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Richard Lau

commit sha 7251e8c2689f2f5dc2ca86d5077f22a3d12210bb

build: log detected compilers in --verbose mode Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32715 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Agustin Daguerre

commit sha 41b1e87356ec73810d57c37c7058d186f8d574bd

test: replace console.log/error with debuglog Use utility debug logs instead of console logs in test-cluster-setup-master-multiple.js Refs: https://github.com/nodejs/node/issues/32678 PR-URL: https://github.com/nodejs/node/pull/32695 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Anna Henningsen

commit sha dccdc51788bd5337f9fd80441ef52932383a2441

deps: fix zlib compilation for CPUs without SIMD features Fix the compile flags so that zlib can run on CPUs that do not have SSSE3/SSE4.2/etc. Do not compile zlib with flags that indicate that those features are available, and instead enable them selectively for functions that use them. There are probably better way to do this, e.g. through gyp file modifications as suggested in the issue. However, this patch should do just fine until that happens. Fixes: https://github.com/nodejs/node/issues/32553 PR-URL: https://github.com/nodejs/node/pull/32627 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha ea4b0bcb3cf13a5b94b358e1d60ec91dc9297f8f

build: remove `.txt` files from .gitignore Refs: https://github.com/nodejs/node/pull/32670#issuecomment-609498003 PR-URL: https://github.com/nodejs/node/pull/32710 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Rich Trott

commit sha 203776fb7185092fa0e2e3a854c7c4595304eb83

build: fix LINT_MD_NEWER assignment Indentation with a tab breaks the functionality, resulting in linting all .md files when any one is changed. For consistency with the rest of the Makefile and to restore functionality, remove indentation. Refs: https://github.com/nodejs/node/pull/32614#issuecomment-610670779 PR-URL: https://github.com/nodejs/node/pull/32712 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Jesus Hernandez

commit sha 4076e043b895233fb3c0060980eaab6bb74358a9

lib: removes unnecessary params PR-URL: https://github.com/nodejs/node/pull/32694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

himself65

commit sha d0a3bf1f115a619ffcd8804d5b006555433af13b

perf_hooks: allow omitted parameters in 'performance.measure' Make `startMark` and `endMark` parameters optional. PR-URL: https://github.com/nodejs/node/pull/32651 Fixes: https://github.com/nodejs/node/issues/32647 Refs: https://www.w3.org/TR/user-timing-2/#measure-method Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 months

delete branch edsadr/node

delete branch : edsadr/fs-promises-destructuring

delete time in 2 months

PR closed nodejs/node

test: using fs.promises destructuring test

This PR uses fs.promises destructuring in few fs tests

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines
+9 -9

0 comment

3 changed files

edsadr

pr closed time in 2 months

PR opened nodejs/node

test: using fs.promises destructuring

This PR uses fs.promises destructuring in few fs tests

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines
+9 -9

0 comment

3 changed files

pr created time in 2 months

create barnchedsadr/node

branch : edsadr/fs-promises-destructuring

created branch time in 2 months

push eventedsadr/node

Rich Trott

commit sha 436c71db6656b6b48b8a3771c382d093c79e4d1a

test: revise test-http-client-default-headers-exist * Remove assert.strictEqual where assert.ok suffices * Replace countdown with Promise.all() PR-URL: https://github.com/nodejs/node/pull/32493 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Gabriel Schulhof

commit sha fa3fd78c8855379f4d785a5a40176e7cf604f857

src: simplify large pages mapping code * Introduce `OnScopeLeave` handler for cleaning up mmap()ed range(s). * Factor out failure scenario at the bottom of the function with `fail` label for use with `goto`. * Do not allocate temporary range (`nmem`) on FreeBSD, because it is not used. The intention is that the steps involved in re-mapping to large pages become more clearly visible. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/32396 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rich Trott

commit sha a1686e00ab726f70d83241fbea53d577b94ee3a7

test: replace Map with Array in test-cluster-net-listen-ipv6only-false Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32398 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha 2565442ac0215cbea398d7f0dc1faa49e9632a93

test: use Promise.all() in test-cluster-net-listen-ipv6only-false Use Promise.all() instead of countdown in test-cluster-net-listen-ipv6only-false. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32398 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

himself65

commit sha a744dad589cdfe35f322f28d199968559cd4953a

src: remove excess v8 namespace PR-URL: https://github.com/nodejs/node/pull/32191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

James M Snell

commit sha 7d3791a3a4fced7ab524cfd34ecb3b9805d86e28

fs: fixup error message for invalid options.recursive Use "options.recursive" instead of just "recursive" Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32472 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 05aa67aa21b77933033027615eb30df70338c735

console: fixup error message Use "options.inspectOptions" instead of just "inspectOptions" Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32475 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Daniel Bevenius

commit sha cd1db2db48d28db805227e7f6ade79a106d85bc6

src: fix compiler warnings in node_report_module Currently, the following compiler warnings are generated: ../src/node_report_module.cc: In function ‘void report::ShouldReportOnFatalError( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_report_module.cc:132:16: warning: unused variable ‘env’ [-Wunused-variable] 132 | Environment* env = Environment::GetCurrent(info); | ^~~ ../src/node_report_module.cc: In function ‘void report::SetReportOnFatalError( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_report_module.cc:138:16: warning: unused variable ‘env’ [-Wunused-variable] 138 | Environment* env = Environment::GetCurrent(info); | ^~~ This commit removes the unused variables. PR-URL: https://github.com/nodejs/node/pull/32498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ben Noordhuis

commit sha 037f8448bee5ca62ea6bd771495c59c81258ab94

build: disable -Wattributes warnings on aix Disable the following compiler warning: warning: visibility attribute not supported in this configuration; ignored [-Wattributes] This is gcc complaining about `__attribute((visibility("default"))` in static library builds. Legitimate but harmless (and uninteresting) and it drowns out more relevant warnings. PR-URL: https://github.com/nodejs/node/pull/32419 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anna Henningsen

commit sha c0668fec2a0d08b42a981216b179875e83ba38ad

doc: add missing changes: entry for mkdir Refs: https://github.com/nodejs/node/pull/31530 PR-URL: https://github.com/nodejs/node/pull/32490 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Ling Samuel

commit sha bc28daa9f7a73ce2c21984684315cf03925ca175

doc: rename cve_management_process.md to fit doc style guide PR-URL: https://github.com/nodejs/node/pull/32456 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Bartosz Sosnowski

commit sha eb553a473bc5ff2ad1b155774553122f4e52d231

test: unflake async-hooks/test-statwatcher On Windows 2016 under high load further change events can be emitted after writing the 5 bytes is reported. Updating the mtime of the file can be reported as a separate change. This will increase the "before" count, but not the "w1HookCount" since we removed the listener. This makes the test keep the listeners until the end of the test. Fixes: https://github.com/nodejs/node/issues/21425 PR-URL: https://github.com/nodejs/node/pull/32484 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Richard Lau

commit sha 0cb0f306b6eabce5d81583446de52a5b4cacae00

test: check bundled binaries are signed on macOS For notarization on macOS all packaged binaries must be signed. Add a regression test to check that known binaries from our dependencies (at the time of this commit term-size via npm) are signed. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32522 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

himself65

commit sha 9b4306dc153c73b71cfcc58b14de04d3a53809de

test: remove a duplicated test PR-URL: https://github.com/nodejs/node/pull/32453 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

unknown

commit sha 400bc5cdc0b528a853c6b01b5b5ac993c078f9a2

http: increase default header size from 8KB to 16KB Fixes: https://github.com/nodejs/node/issues/27645 PR-URL: https://github.com/nodejs/node/pull/32520 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Filip Skokan

commit sha 154d4e573aabcb230b0774481246cc1e487abcb4

doc,crypto: clarify oaepHash option's impact PR-URL: https://github.com/nodejs/node/pull/32340 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

himself65

commit sha a2463124dad02988b5f844c83a56081ec22b2c93

src: enhance template function 'MakeUtf8String' PR-URL: https://github.com/nodejs/node/pull/32322 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

Ruben Bridgewater

commit sha 08c656bb7b852454da85e98640f889ce11beda46

deps: update acorn to v7.1.1 Also clean up the plugins package.json files. PR-URL: https://github.com/nodejs/node/pull/32310 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

himself65

commit sha cc8066e0d196f0180ddcfa04207de8bee69db285

doc: use uppercase on windows path PR-URL: https://github.com/nodejs/node/pull/32294 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Syohei YOSHIDA

commit sha 3822cae39cf6ad95dd2840ebb31afb6903ee33e2

doc: fix profile type of --heap-prof-name V8 CPU profile -> V8 heap profile PR-URL: https://github.com/nodejs/node/pull/32404 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 months

delete branch edsadr/node

delete branch : edsadr/ninja-guide

delete time in 2 months

pull request commentnodejs/node

doc: updating Ninja guide

Thanks for the review and the amazing suggestions @Trott , I just applied them and I guess this is ready :)

edsadr

comment created time in 2 months

push eventedsadr/node

Adrian Estrada

commit sha b97518595f87fefb43397435533b71ce5a064fa0

doc: updating Ninja guide

view details

push time in 2 months

Pull request review commentnodejs/node

doc: updating Ninja guide

 The bottom line will change while building, showing the progress as `[finished/total]` build steps. This is useful output that `make` does not produce and is one of the benefits of using Ninja. Also, Ninja will likely compile much faster than even `make -j4` (or-`-j<number of processor threads on your machine>`).+`-j<number of processor threads on your machine>`), you can still pass the+number of processes to run for [Ninja][] using the environment variable `JOBS`,+and this will be the equivalent to the `-j` parameter in the regular `make`: -## Considerations--Ninja builds vary slightly from `make` builds. If you wish to run `make test`-after, `make` will likely still need to rebuild some amount of Node.js.--As such, if you wish to run the tests, it can be helpful to invoke the test-runner directly, like so:-`tools/test.py --mode=release message parallel sequential -J`--## Alias--`alias nnode='./configure --ninja && ninja -C out/Release && ln -fs-out/Release/node node'`+```bash+$ JOBS=12 make+```  ## Producing a debug build -The above alias can be modified slightly to produce a debug build, rather than a+Is possible to create an alias to produce a debug build, rather than a release build as shown below:+ `alias nnodedebug='./configure --ninja && ninja -C out/Debug && ln -fs out/Debug/node node_g'`  [Ninja]: https://ninja-build.org/+[this commit]: https://github.com/nodejs/node/pull/27504/commits/46eb532a2a144ebd0fe1aa91a2b4a9e9372aa902

Got it, removed the reference too :)

edsadr

comment created time in 2 months

Pull request review commentnodejs/node

doc: updating Ninja guide

 The bottom line will change while building, showing the progress as `[finished/total]` build steps. This is useful output that `make` does not produce and is one of the benefits of using Ninja. Also, Ninja will likely compile much faster than even `make -j4` (or-`-j<number of processor threads on your machine>`).+`-j<number of processor threads on your machine>`), you can still pass the+number of processes to run for [Ninja][] using the environment variable `JOBS`,+and this will be the equivalent to the `-j` parameter in the regular `make`: -## Considerations--Ninja builds vary slightly from `make` builds. If you wish to run `make test`-after, `make` will likely still need to rebuild some amount of Node.js.--As such, if you wish to run the tests, it can be helpful to invoke the test-runner directly, like so:-`tools/test.py --mode=release message parallel sequential -J`--## Alias--`alias nnode='./configure --ninja && ninja -C out/Release && ln -fs-out/Release/node node'`+```bash+$ JOBS=12 make+```  ## Producing a debug build -The above alias can be modified slightly to produce a debug build, rather than a+Is possible to create an alias to produce a debug build, rather than a release build as shown below:+ `alias nnodedebug='./configure --ninja && ninja -C out/Debug && ln -fs

Thanks for your suggestion, changed the instructions to match your suggestion

edsadr

comment created time in 2 months

Pull request review commentnodejs/node

doc: updating Ninja guide

 The bottom line will change while building, showing the progress as `[finished/total]` build steps. This is useful output that `make` does not produce and is one of the benefits of using Ninja. Also, Ninja will likely compile much faster than even `make -j4` (or-`-j<number of processor threads on your machine>`).+`-j<number of processor threads on your machine>`), you can still pass the+number of processes to run for [Ninja][] using the environment variable `JOBS`,+and this will be the equivalent to the `-j` parameter in the regular `make`: -## Considerations--Ninja builds vary slightly from `make` builds. If you wish to run `make test`-after, `make` will likely still need to rebuild some amount of Node.js.--As such, if you wish to run the tests, it can be helpful to invoke the test-runner directly, like so:-`tools/test.py --mode=release message parallel sequential -J`--## Alias--`alias nnode='./configure --ninja && ninja -C out/Release && ln -fs-out/Release/node node'`+```bash+$ JOBS=12 make+```  ## Producing a debug build -The above alias can be modified slightly to produce a debug build, rather than a+Is possible to create an alias to produce a debug build, rather than a

Thanks for reviewing, just addressed your feedback

edsadr

comment created time in 2 months

push eventedsadr/node

Adrian Estrada

commit sha 4ebde3fef7c7f2f5b9ca4b5ce97509559904b3db

doc: updating Ninja guide

view details

push time in 2 months

PR opened nodejs/node

doc: updating Ninja guide

This PR updates the guide to use Ninja, because the instructions were outdated after merging this PR

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master
+17 -20

0 comment

1 changed file

pr created time in 2 months

create barnchedsadr/node

branch : edsadr/ninja-guide

created branch time in 2 months

issue commentnodejs/node

Nominating @juanarbol as a collaborator

:tada: +1

addaleax

comment created time in 2 months

push eventedsadr/node

Rich Trott

commit sha decc5f5506bfaeac9f09ed1d12b4f519bc0ac250

test: add test for validation for wasi.start() argument PR-URL: https://github.com/nodejs/node/pull/30919 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Robert Nagy

commit sha e902fadc5ee7615b15ce86d1986785c169d59c01

stream: do not throw multiple callback errors in writable Align ERR_MULTIPLE_CALLBACK in Writable with the rest of error handling as well as how the error is implemented in Transform. PR-URL: https://github.com/nodejs/node/pull/30614 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 2097a6fc053823a8585cdbe858ade70f62c6bb1d

test: add missing test flags test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. https://github.com/nodejs/node/pull/30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag. PR-URL: https://github.com/nodejs/node/pull/30971 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Derek Lewis

commit sha 80fb15353ab8ea9d149d2d2606e1ca0b41ff926b

tools: enable Markdown linter's usage information Prior to this commit, running `node tools/lint-md --help` and `node tools/lint-md --version` resulted in an error. * Use `unified-args` to start processor * Use `unified-args`'s error handler Fixes: https://github.com/nodejs/node/issues/30156 PR-URL: https://github.com/nodejs/node/pull/30216 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

João Reis

commit sha 3ead1c2fb7b75fbf8d45925308ee8dba4baba0ca

build,win: fix goto exit in vcbuild PR-URL: https://github.com/nodejs/node/pull/30931 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Gerhard Stoebich

commit sha b2bfacb9142c70e060f522cc5f05f937e66b07c7

test: avoid leftover report file test-windows-failed-heap-allocation forces a out of mem crash resulting in a report file. To avoid a leftover in repo the child is started in a tmp folder like in test-report-fatal-error. PR-URL: https://github.com/nodejs/node/pull/30925 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ruben Bridgewater

commit sha eeae5986fdd77558cee2699afbe83a3a461b61fb

util: refactor inspect code for constistency This removes the special handling to inspect iterable objects with a null prototype. It is now handled together with the regular prototype. PR-URL: https://github.com/nodejs/node/pull/30225 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha ab599898617f222679b200fe78d3eb0e974bfa69

util: add Set and map size to inspect output This adds the size of a set and map to the output. This aligns the output with the one from Chromium. PR-URL: https://github.com/nodejs/node/pull/30225 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Derek Lewis

commit sha b4281403d57bd8c205337359eaa4f9475de9dae9

doc: clarify expectations for PR commit messages Prior to this commit, new contributors were suggested to use a utility to validate commit messages. Although not inaccurate, this utility produces misleading results. * Remove reference to `core-validate-commit` PR-URL: https://github.com/nodejs/node/pull/30922 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Kirill Ponomarev

commit sha 2d138965971109ddf6a583f78e5cdc3026c5f7f4

test: improve dns lookup coverage Adding tests covering promises-related code paths. PR-URL: https://github.com/nodejs/node/pull/30777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Robert Nagy

commit sha 67ed526ab03c3e9b2f41290b7cd6e9c2e7d9b4dd

stream: error state cleanup Clean up end simplify errored state. - errorEmitted should be set in the same tick as 'error' is emitted. - errored should be set as soon as an error occurs. - errored should exist on Readable as well. - refactor destroy logic and make it easier to follow. PR-URL: https://github.com/nodejs/node/pull/30851 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ruben Bridgewater

commit sha 7327f390f69fe53c665b48862f51e343af555d37

repl: remove dead code The .scope command was used only in the old debugger. Since that's not part of core anymore it's does not have any use. I tried to replicate the expected behavior but it even results in just exiting the repl immediately when using the completion similar to the removed test case. PR-URL: https://github.com/nodejs/node/pull/30907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 37f6a42f72b51f5574f503d949da4aa73a463261

repl: simplify repl autocompletion This simplifies calling `filteredOwnPropertyNames()`. The context is not used in that function, so there's no need to call the function as such. PR-URL: https://github.com/nodejs/node/pull/30907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 1aab392cf3b40ce9be78cd2c2019e51e01141064

repl: simplify code This simplifies some repl code and removes a code branch that is unreachable. PR-URL: https://github.com/nodejs/node/pull/30907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 8f9cd3841d3fe52f7cb9a6dbd3f65e7ddec13e8b

readline: update ansi-regex This updates the used regular expression to the latest version. It includes a number of additional escape codes. PR-URL: https://github.com/nodejs/node/pull/30907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 52e5eb7e521da4516523c8918eb32fd51a5e87f2

repl,readline: refactor common code This renames some variables for clarity and moves the common substring part into a shared file. One algorithm was more efficient than the other but the functionality itself was identical. PR-URL: https://github.com/nodejs/node/pull/30907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha af5c8af5e9d02532d6a59e2a2544c1ea0c4877f7

repl,readline: refactor for simplicity This just refactors code without changing the behavior. Especially the REPL code is difficult to read and deeply indented. This reduces the indentation to improve that. PR-URL: https://github.com/nodejs/node/pull/30907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 6c542d1c26decd53fa1154a5aa7a53b4199cad1f

repl: improve completion This improves the completion output by removing the nested special handling. It never fully worked as expected and required a lot of hacks to even keep it working halfway reliable. Our tests did not cover syntax errors though and those can not be handled by this implementation. Those break the layout and confuse the REPL. Besides that the completion now also works in case the current line has leading whitespace. Also improve the error output in case the completion fails. PR-URL: https://github.com/nodejs/node/pull/30907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 21ecaa47eed39a4ede527e0b340d102ba8e1972b

repl: add completion preview This improves the already existing preview functionality by also checking for the input completion. In case there's only a single completion, it will automatically be visible to the user in grey. If colors are deactivated, it will be visible as comment. This also changes some keys by automatically accepting the preview by moving the cursor behind the current input end. PR-URL: https://github.com/nodejs/node/pull/30907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 2986068c5a168dc314b696d2cad4155675f741e5

repl: fix preview bug in case of long lines This addresses an issue that is caused by lines that exceed the current window columns. That would cause the preview to confuse the REPL. This is meant as hot fix. The preview should be able to handle these cases appropriately as well later on. PR-URL: https://github.com/nodejs/node/pull/30907 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 2 months

more