profile
viewpoint
Eddú Meléndez Gonzales eddumelendez @nubank Ica, Perú https://blog.eddumelendez.me Java Developer and Open Source Contributor

eddumelendez/awesome-projects-for-contributors 25

List of projects for people looking for to contribute

Adopt-a-JSR/javaee8-mvc 7

JSR-371 MVC 1.0

eddumelendez/awesome-java 1

A curated list of awesome frameworks, libraries and software for the Java programming language.

eddumelendez/dbdeploy-example 1

Database Control Management using dbdeploy

eddumelendez/Activiti 0

Activiti is a light-weight workflow and Business Process Management (BPM) Platform targeted at business people, developers and system admins. Its core is a super-fast and rock-solid BPMN 2 process engine for Java. It's open-source and distributed under the Apache license. Activiti runs in any Java application, on a server, on a cluster or in the cloud. It integrates perfectly with Spring, it is extremely lightweight and based on simple concepts.

eddumelendez/adoptopenjdk-getting-started-kit 0

A one stop guide for developers of all levels, you start with simple and basic know-how and dive deep into the realms of OpenJDK. Know what the Adopt OpenJDK program is about.

create barncheddumelendez/micrometer-docs

branch : boot_stackdriver_ref

created branch time in 18 hours

fork eddumelendez/micrometer-docs

Static website and documentation for Micrometer.

fork in 18 hours

Pull request review commentspring-cloud/spring-cloud-gcp

Add Micrometer AutoConfiguration

+/*+ * Copyright 2017-2020 the original author or authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package org.springframework.cloud.gcp.autoconfigure.metrics;++import java.io.IOException;++import com.google.api.gax.core.CredentialsProvider;+import io.micrometer.core.instrument.Clock;+import io.micrometer.core.instrument.step.StepMeterRegistry;+import io.micrometer.stackdriver.StackdriverConfig;++import org.springframework.boot.actuate.autoconfigure.metrics.export.stackdriver.StackdriverMetricsExportAutoConfiguration;+import org.springframework.boot.actuate.autoconfigure.metrics.export.stackdriver.StackdriverProperties;+import org.springframework.boot.autoconfigure.AutoConfigureBefore;+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;+import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;+import org.springframework.boot.context.properties.EnableConfigurationProperties;+import org.springframework.cloud.gcp.core.DefaultCredentialsProvider;+import org.springframework.cloud.gcp.core.GcpProjectIdProvider;+import org.springframework.context.annotation.Bean;+import org.springframework.context.annotation.Configuration;++/**+ * Provides auto-detection for project.+ *+ * @author Eddú Meléndez+ */+@Configuration+@AutoConfigureBefore(StackdriverMetricsExportAutoConfiguration.class)+@ConditionalOnClass({StepMeterRegistry.class, StackdriverConfig.class})+@ConditionalOnBean(Clock.class)+@EnableConfigurationProperties({GcpMetricsProperties.class, StackdriverProperties.class})+@ConditionalOnProperty(value = "spring.cloud.gcp.metrics.enabled", matchIfMissing = true)+public class GcpStackdriverMetricsAutoConfiguration {++	private final StackdriverProperties stackdriverProperties;++	private final String projectId;++	private final CredentialsProvider credentialsProvider;++	public GcpStackdriverMetricsAutoConfiguration(GcpMetricsProperties gcpMetricsProperties,+			StackdriverProperties stackdriverProperties, GcpProjectIdProvider gcpProjectIdProvider,+			CredentialsProvider credentialsProvider) throws IOException {+		this.stackdriverProperties = stackdriverProperties;+		this.projectId = (gcpMetricsProperties.getProjectId() != null)+				? gcpMetricsProperties.getProjectId() : gcpProjectIdProvider.getProjectId();+		this.credentialsProvider = gcpMetricsProperties.getCredentials().hasKey()+				? new DefaultCredentialsProvider(gcpMetricsProperties) : credentialsProvider;+	}++	@Bean+	@ConditionalOnMissingBean+	public StackdriverConfig stackdriverConfig() {

this is the current auto-configuration for stackdriver in spring-booot https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/stackdriver/StackdriverMetricsExportAutoConfiguration.java

eddumelendez

comment created time in 21 hours

Pull request review commentspring-cloud/spring-cloud-gcp

Allow `projectId` override in Firebase authentication

+/*+ * Copyright 2017-2020 the original author or authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package org.springframework.cloud.gcp.autoconfigure.security;+++import org.junit.Test;++import org.springframework.boot.autoconfigure.AutoConfigurations;+import org.springframework.boot.test.context.runner.ApplicationContextRunner;+import org.springframework.cloud.gcp.core.GcpProjectIdProvider;+import org.springframework.context.annotation.Bean;++import static org.assertj.core.api.Assertions.assertThat;+import static org.mockito.Mockito.mock;+import static org.mockito.Mockito.when;+++/**+ * @author Felipe M Amaral+ * @since 1.2.2+ */+public class FirebaseAuthenticationProjectIdEvaluatorTests {++	/**+	 * Project ID used by GcpProjectIdProvider.+	 */+	public static final String GCP_PROVIDER_PROJECT_ID = "spring-gcp-test-project";++	/**+	 * Project ID used by FirebaseAuthenticationProperties.+	 */+	public static final String FIREBASE_PROJECT_ID = "spring-firebase-test-project";++	@Test+	public void testFirebaseProjectIdNotSet() throws Exception {+		new ApplicationContextRunner()+				.withBean(FirebaseAuthenticationProjectIdEvaluator.class)+				.withConfiguration(AutoConfigurations.of(TestConfig.class))+				.run(context -> {+					FirebaseAuthenticationProjectIdEvaluator evaluator = context.getBean(FirebaseAuthenticationProjectIdEvaluator.class);+					assertThat(evaluator.getProjectId()).isEqualTo(GCP_PROVIDER_PROJECT_ID);+				});+	}++	@Test+	public void testFirebaseProjectIdSet() throws Exception {+		new ApplicationContextRunner()+				.withPropertyValues("spring.cloud.gcp.security.firebase=" + FIREBASE_PROJECT_ID)+				.withBean(FirebaseAuthenticationProjectIdEvaluator.class)+				.withConfiguration(AutoConfigurations.of(TestConfigWithFirebaseProjectId.class))+				.run(context -> {+					FirebaseAuthenticationProjectIdEvaluator evaluator = context.getBean(FirebaseAuthenticationProjectIdEvaluator.class);+					assertThat(evaluator.getProjectId()).isEqualTo(FIREBASE_PROJECT_ID);+				});+	}++	static class TestConfig {++		@Bean+		public GcpProjectIdProvider projectIdProvider() {+			return () -> GCP_PROVIDER_PROJECT_ID;+		}++		@Bean+		public FirebaseAuthenticationProperties firebaseAuthenticationProperties() {+			return mock(FirebaseAuthenticationProperties.class);+		}++	}++	static class TestConfigWithFirebaseProjectId {

I think, you can use @EnableConfigurationProperties(FirebaseAuthenticationProperties .class so you can remove the bean mocking FirebaseAuthenticationProperties

femrtnz

comment created time in 21 hours

Pull request review commentspring-cloud/spring-cloud-gcp

Allow `projectId` override in Firebase authentication

+/*+ * Copyright 2020-2020 the original author or authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package org.springframework.cloud.gcp.autoconfigure.security;++import org.springframework.cloud.gcp.core.GcpProjectIdProvider;++/**+ *+ * @author Felipe M Amaral+ * @since 1.2.2

1.2.4

femrtnz

comment created time in 21 hours

Pull request review commentspring-cloud/spring-cloud-gcp

Allow `projectId` override in Firebase authentication

+/*+ * Copyright 2017-2020 the original author or authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package org.springframework.cloud.gcp.autoconfigure.security;+++import org.junit.Test;++import org.springframework.boot.autoconfigure.AutoConfigurations;+import org.springframework.boot.test.context.runner.ApplicationContextRunner;+import org.springframework.cloud.gcp.core.GcpProjectIdProvider;+import org.springframework.context.annotation.Bean;++import static org.assertj.core.api.Assertions.assertThat;+import static org.mockito.Mockito.mock;+import static org.mockito.Mockito.when;+++/**+ * @author Felipe M Amaral+ * @since 1.2.2+ */+public class FirebaseAuthenticationProjectIdEvaluatorTests {++	/**+	 * Project ID used by GcpProjectIdProvider.+	 */+	public static final String GCP_PROVIDER_PROJECT_ID = "spring-gcp-test-project";++	/**+	 * Project ID used by FirebaseAuthenticationProperties.+	 */+	public static final String FIREBASE_PROJECT_ID = "spring-firebase-test-project";++	@Test+	public void testFirebaseProjectIdNotSet() throws Exception {+		new ApplicationContextRunner()+				.withBean(FirebaseAuthenticationProjectIdEvaluator.class)+				.withConfiguration(AutoConfigurations.of(TestConfig.class))+				.run(context -> {+					FirebaseAuthenticationProjectIdEvaluator evaluator = context.getBean(FirebaseAuthenticationProjectIdEvaluator.class);+					assertThat(evaluator.getProjectId()).isEqualTo(GCP_PROVIDER_PROJECT_ID);+				});+	}++	@Test+	public void testFirebaseProjectIdSet() throws Exception {+		new ApplicationContextRunner()+				.withPropertyValues("spring.cloud.gcp.security.firebase=" + FIREBASE_PROJECT_ID)

missing .project-id

femrtnz

comment created time in 21 hours

push eventeddumelendez/spring-cloud-gcp

Eddú Meléndez

commit sha eb40df5997f30835adbba3b640b5cbb09c4f8a9f

Add since in javadocs

view details

push time in a day

create barncheddumelendez/sdkman-db-migrations

branch : openjdk_15ea25

created branch time in 2 days

push eventeddumelendez/spring-cloud-gcp

Eddú Meléndez Gonzales

commit sha 3da4e2829a630bffc1059dcd0be8799706f89495

Update docs Co-authored-by: Elena Felder <41136058+elefeint@users.noreply.github.com>

view details

push time in 2 days

push eventeddumelendez/spring-cloud-gcp

Eddú Meléndez

commit sha 2e612ffc60d54f476f50cbb3c59cce606a04c2f9

Mention spring-boot-starter-actuator dependency

view details

push time in 2 days

Pull request review commentspring-cloud/spring-cloud-gcp

Add Micrometer AutoConfiguration

+== Stackdriver Monitoring++Google Cloud Platform provides a service called https://cloud.google.com/monitoring/[Stackdriver Monitoring], and https://micrometer.io/docs/registry/stackdriver[Micrometer] can be used with it to easily instrument Spring Boot applications for observability.++Spring Boot already provides auto-configuration for Stackdriver. This module enables to auto-detect the `project-id` and `credentials`. Also, it can be customized.++Maven coordinates, using <<getting-started.adoc#_bill_of_materials, Spring Cloud GCP BOM>>:++[source,xml]+----+<dependency>+    <groupId>org.springframework.cloud</groupId>+    <artifactId>spring-cloud-gcp-starter-metrics</artifactId>+</dependency>+----

That's right, actuator is required. Even though the new starter will not make sense without the actuator dependency, I would prefer to let this clear in the docs so the developers are aware about what dependencies are declaring for this case. WDYT?

eddumelendez

comment created time in 2 days

Pull request review commentspring-cloud/spring-cloud-gcp

Add Micrometer AutoConfiguration

+/*+ * Copyright 2017-2020 the original author or authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package org.springframework.cloud.gcp.autoconfigure.metrics;++import java.io.IOException;++import com.google.api.gax.core.CredentialsProvider;+import io.micrometer.core.instrument.Clock;+import io.micrometer.core.instrument.step.StepMeterRegistry;+import io.micrometer.stackdriver.StackdriverConfig;++import org.springframework.boot.actuate.autoconfigure.metrics.export.stackdriver.StackdriverMetricsExportAutoConfiguration;+import org.springframework.boot.actuate.autoconfigure.metrics.export.stackdriver.StackdriverProperties;+import org.springframework.boot.autoconfigure.AutoConfigureBefore;+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;+import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;+import org.springframework.boot.context.properties.EnableConfigurationProperties;+import org.springframework.cloud.gcp.core.DefaultCredentialsProvider;+import org.springframework.cloud.gcp.core.GcpProjectIdProvider;+import org.springframework.context.annotation.Bean;+import org.springframework.context.annotation.Configuration;++/**+ * Provides auto-detection for project.+ *+ * @author Eddú Meléndez+ */+@Configuration+@AutoConfigureBefore(StackdriverMetricsExportAutoConfiguration.class)+@ConditionalOnClass({StepMeterRegistry.class, StackdriverConfig.class})+@ConditionalOnBean(Clock.class)

Don't think so. Since all of them are provided for spring-boot once actuator, micrometer and micrometer-stackdriver are declared. When the conditions meet we this auto-config triggers.

eddumelendez

comment created time in 2 days

Pull request review commentspring-cloud/spring-cloud-gcp

Add Micrometer AutoConfiguration

+/*+ * Copyright 2017-2020 the original author or authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package org.springframework.cloud.gcp.autoconfigure.metrics;++import java.io.IOException;++import com.google.api.gax.core.CredentialsProvider;+import io.micrometer.core.instrument.Clock;+import io.micrometer.core.instrument.step.StepMeterRegistry;+import io.micrometer.stackdriver.StackdriverConfig;++import org.springframework.boot.actuate.autoconfigure.metrics.export.stackdriver.StackdriverMetricsExportAutoConfiguration;+import org.springframework.boot.actuate.autoconfigure.metrics.export.stackdriver.StackdriverProperties;+import org.springframework.boot.autoconfigure.AutoConfigureBefore;+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;+import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;+import org.springframework.boot.context.properties.EnableConfigurationProperties;+import org.springframework.cloud.gcp.core.DefaultCredentialsProvider;+import org.springframework.cloud.gcp.core.GcpProjectIdProvider;+import org.springframework.context.annotation.Bean;+import org.springframework.context.annotation.Configuration;++/**+ * Provides auto-detection for project.+ *+ * @author Eddú Meléndez+ */+@Configuration+@AutoConfigureBefore(StackdriverMetricsExportAutoConfiguration.class)+@ConditionalOnClass({StepMeterRegistry.class, StackdriverConfig.class})+@ConditionalOnBean(Clock.class)+@EnableConfigurationProperties({GcpMetricsProperties.class, StackdriverProperties.class})+@ConditionalOnProperty(value = "spring.cloud.gcp.metrics.enabled", matchIfMissing = true)+public class GcpStackdriverMetricsAutoConfiguration {++	private final StackdriverProperties stackdriverProperties;++	private final String projectId;++	private final CredentialsProvider credentialsProvider;++	public GcpStackdriverMetricsAutoConfiguration(GcpMetricsProperties gcpMetricsProperties,+			StackdriverProperties stackdriverProperties, GcpProjectIdProvider gcpProjectIdProvider,+			CredentialsProvider credentialsProvider) throws IOException {+		this.stackdriverProperties = stackdriverProperties;+		this.projectId = (gcpMetricsProperties.getProjectId() != null)+				? gcpMetricsProperties.getProjectId() : gcpProjectIdProvider.getProjectId();+		this.credentialsProvider = gcpMetricsProperties.getCredentials().hasKey()+				? new DefaultCredentialsProvider(gcpMetricsProperties) : credentialsProvider;+	}++	@Bean+	@ConditionalOnMissingBean+	public StackdriverConfig stackdriverConfig() {

just added an assertion to make sure the meterRegistry bean is created

eddumelendez

comment created time in 3 days

push eventeddumelendez/spring-cloud-gcp

Eddú Meléndez

commit sha cc124814e620595ef9d64d2822e1808f741e13a5

Add assert to ensure meterRegistry bean is created

view details

push time in 3 days

Pull request review commentspring-cloud/spring-cloud-gcp

Add Micrometer AutoConfiguration

+/*+ * Copyright 2017-2020 the original author or authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package org.springframework.cloud.gcp.autoconfigure.metrics;++import java.io.IOException;++import com.google.api.gax.core.CredentialsProvider;+import io.micrometer.core.instrument.Clock;+import io.micrometer.core.instrument.step.StepMeterRegistry;+import io.micrometer.stackdriver.StackdriverConfig;++import org.springframework.boot.actuate.autoconfigure.metrics.export.stackdriver.StackdriverMetricsExportAutoConfiguration;+import org.springframework.boot.actuate.autoconfigure.metrics.export.stackdriver.StackdriverProperties;+import org.springframework.boot.autoconfigure.AutoConfigureBefore;+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;+import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;+import org.springframework.boot.context.properties.EnableConfigurationProperties;+import org.springframework.cloud.gcp.core.DefaultCredentialsProvider;+import org.springframework.cloud.gcp.core.GcpProjectIdProvider;+import org.springframework.context.annotation.Bean;+import org.springframework.context.annotation.Configuration;++/**+ * Provides auto-detection for project.+ *+ * @author Eddú Meléndez+ */+@Configuration+@AutoConfigureBefore(StackdriverMetricsExportAutoConfiguration.class)+@ConditionalOnClass({StepMeterRegistry.class, StackdriverConfig.class})+@ConditionalOnBean(Clock.class)+@EnableConfigurationProperties({GcpMetricsProperties.class, StackdriverProperties.class})+@ConditionalOnProperty(value = "spring.cloud.gcp.metrics.enabled", matchIfMissing = true)+public class GcpStackdriverMetricsAutoConfiguration {++	private final StackdriverProperties stackdriverProperties;++	private final String projectId;++	private final CredentialsProvider credentialsProvider;++	public GcpStackdriverMetricsAutoConfiguration(GcpMetricsProperties gcpMetricsProperties,+			StackdriverProperties stackdriverProperties, GcpProjectIdProvider gcpProjectIdProvider,+			CredentialsProvider credentialsProvider) throws IOException {+		this.stackdriverProperties = stackdriverProperties;+		this.projectId = (gcpMetricsProperties.getProjectId() != null)+				? gcpMetricsProperties.getProjectId() : gcpProjectIdProvider.getProjectId();+		this.credentialsProvider = gcpMetricsProperties.getCredentials().hasKey()+				? new DefaultCredentialsProvider(gcpMetricsProperties) : credentialsProvider;+	}++	@Bean+	@ConditionalOnMissingBean+	public StackdriverConfig stackdriverConfig() {

it is not required since we are performing this auto-configuration before the one provided by spring-boot. So, we just need to pre-configure the config so spring-boot takes it

eddumelendez

comment created time in 3 days

push eventeddumelendez/spring-cloud-gcp

Eddú Meléndez

commit sha b4a0c6ce243bc3cd6c71d41c2ddc9cad01c59f00

Polish docs

view details

Eddú Meléndez

commit sha b1ced570d284864208999c4a573ab3b775e586c8

Add havingValue attribute

view details

push time in 3 days

issue commentspring-cloud/spring-cloud-aws

Project Roadmap

I would like to join and help for the future of the project 🙂

spencergibb

comment created time in 3 days

issue commentGoogleCloudPlatform/buildpacks

Add support to create a container from jar

I have enabled the logging and this is the result. Instructions in the previous comment

[INFO]  > Running creator
[INFO]     [creator]     ---> DETECTING
[INFO]     [creator]     ======== Output: google.dotnet.functions-framework@0.0.1 ========
[INFO]     [creator]     GOOGLE_FUNCTION_TARGET not set
[INFO]     [creator]     ======== Output: google.dotnet.runtime@0.9.0 ========
[INFO]     [creator]     No project files nor .dll files found.
[INFO]     [creator]     ======== Output: google.dotnet.publish@0.9.0 ========
[INFO]     [creator]     no project file found and GOOGLE_BUILDABLE not set.
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     skip: google.dotnet.functions-framework@0.0.1
[INFO]     [creator]     fail: google.dotnet.runtime@0.9.0
[INFO]     [creator]     fail: google.dotnet.publish@0.9.0
[INFO]     [creator]     skip: google.config.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.dotnet.runtime@0.9.0 ========
[INFO]     [creator]     No project files nor .dll files found.
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.dotnet.runtime@0.9.0
[INFO]     [creator]     fail: google.config.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.go.runtime@0.9.0 ========
[INFO]     [creator]     No *.go files found.
[INFO]     [creator]     ======== Output: google.go.functions-framework@0.9.0 ========
[INFO]     [creator]     GOOGLE_FUNCTION_TARGET not set
[INFO]     [creator]     ======== Output: google.go.build@0.9.0 ========
[INFO]     [creator]     No *.go files found
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Output: google.go.clear_source@0.9.0 ========
[INFO]     [creator]     GOOGLE_CLEAR_SOURCE not set
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.go.runtime@0.9.0
[INFO]     [creator]     fail: google.go.functions-framework@0.9.0
[INFO]     [creator]     fail: google.go.build@0.9.0
[INFO]     [creator]     skip: google.config.entrypoint@0.9.0
[INFO]     [creator]     skip: google.go.clear_source@0.9.0
[INFO]     [creator]     ======== Output: google.go.runtime@0.9.0 ========
[INFO]     [creator]     No *.go files found.
[INFO]     [creator]     ======== Output: google.go.build@0.9.0 ========
[INFO]     [creator]     No *.go files found
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Output: google.go.clear_source@0.9.0 ========
[INFO]     [creator]     GOOGLE_CLEAR_SOURCE not set
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.go.runtime@0.9.0
[INFO]     [creator]     pass: google.go.gopath@0.9.0
[INFO]     [creator]     fail: google.go.build@0.9.0
[INFO]     [creator]     skip: google.config.entrypoint@0.9.0
[INFO]     [creator]     skip: google.go.clear_source@0.9.0
[INFO]     [creator]     ======== Output: google.java.runtime@0.9.0 ========
[INFO]     [creator]     None of the following found: pom.xml, build.gradle, build.gradle.kts, *.java, *.jar.
[INFO]     [creator]     ======== Output: google.java.maven@0.9.0 ========
[INFO]     [creator]     pom.xml not found.
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.java.runtime@0.9.0
[INFO]     [creator]     fail: google.java.maven@0.9.0
[INFO]     [creator]     fail: google.config.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.java.runtime@0.9.0 ========
[INFO]     [creator]     None of the following found: pom.xml, build.gradle, build.gradle.kts, *.java, *.jar.
[INFO]     [creator]     ======== Output: google.java.maven@0.9.0 ========
[INFO]     [creator]     pom.xml not found.
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.java.runtime@0.9.0
[INFO]     [creator]     fail: google.java.maven@0.9.0
[INFO]     [creator]     pass: google.java.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.java.runtime@0.9.0 ========
[INFO]     [creator]     None of the following found: pom.xml, build.gradle, build.gradle.kts, *.java, *.jar.
[INFO]     [creator]     ======== Output: google.java.gradle@0.9.0 ========
[INFO]     [creator]     Neither build.gradle nor build.gradle.kts found.
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.java.runtime@0.9.0
[INFO]     [creator]     skip: google.java.gradle@0.9.0
[INFO]     [creator]     fail: google.config.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.java.runtime@0.9.0 ========
[INFO]     [creator]     None of the following found: pom.xml, build.gradle, build.gradle.kts, *.java, *.jar.
[INFO]     [creator]     ======== Output: google.java.gradle@0.9.0 ========
[INFO]     [creator]     Neither build.gradle nor build.gradle.kts found.
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.java.runtime@0.9.0
[INFO]     [creator]     skip: google.java.gradle@0.9.0
[INFO]     [creator]     pass: google.java.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.python.runtime@0.9.0 ========
[INFO]     [creator]     No *.py files found.
[INFO]     [creator]     ======== Output: google.python.functions-framework@0.9.0 ========
[INFO]     [creator]     GOOGLE_FUNCTION_TARGET not set
[INFO]     [creator]     ======== Output: google.python.pip@0.9.0 ========
[INFO]     [creator]     requirements.txt not found
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.python.runtime@0.9.0
[INFO]     [creator]     fail: google.python.functions-framework@0.9.0
[INFO]     [creator]     skip: google.python.pip@0.9.0
[INFO]     [creator]     skip: google.config.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.python.runtime@0.9.0 ========
[INFO]     [creator]     No *.py files found.
[INFO]     [creator]     ======== Output: google.python.pip@0.9.0 ========
[INFO]     [creator]     requirements.txt not found
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.python.runtime@0.9.0
[INFO]     [creator]     skip: google.python.pip@0.9.0
[INFO]     [creator]     fail: google.config.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.nodejs.runtime@0.9.0 ========
[INFO]     [creator]     package.json not found and no *.js files found
[INFO]     [creator]     ======== Output: google.nodejs.yarn@0.9.0 ========
[INFO]     [creator]     yarn.lock not found.
[INFO]     [creator]     ======== Output: google.nodejs.functions-framework@0.9.0 ========
[INFO]     [creator]     GOOGLE_FUNCTION_TARGET not set
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.nodejs.runtime@0.9.0
[INFO]     [creator]     fail: google.nodejs.yarn@0.9.0
[INFO]     [creator]     skip: google.nodejs.functions-framework@0.9.0
[INFO]     [creator]     skip: google.config.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.nodejs.runtime@0.9.0 ========
[INFO]     [creator]     package.json not found and no *.js files found
[INFO]     [creator]     ======== Output: google.nodejs.npm@0.9.0 ========
[INFO]     [creator]     package.json not found.
[INFO]     [creator]     ======== Output: google.nodejs.functions-framework@0.9.0 ========
[INFO]     [creator]     GOOGLE_FUNCTION_TARGET not set
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.nodejs.runtime@0.9.0
[INFO]     [creator]     fail: google.nodejs.npm@0.9.0
[INFO]     [creator]     skip: google.nodejs.functions-framework@0.9.0
[INFO]     [creator]     skip: google.config.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.nodejs.runtime@0.9.0 ========
[INFO]     [creator]     package.json not found and no *.js files found
[INFO]     [creator]     ======== Output: google.nodejs.functions-framework@0.9.0 ========
[INFO]     [creator]     GOOGLE_FUNCTION_TARGET not set
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.nodejs.runtime@0.9.0
[INFO]     [creator]     fail: google.nodejs.functions-framework@0.9.0
[INFO]     [creator]     skip: google.config.entrypoint@0.9.0
[INFO]     [creator]     ======== Output: google.nodejs.runtime@0.9.0 ========
[INFO]     [creator]     package.json not found and no *.js files found
[INFO]     [creator]     ======== Output: google.config.entrypoint@0.9.0 ========
[INFO]     [creator]     GOOGLE_ENTRYPOINT not set and Procfile not found
[INFO]     [creator]     ======== Results ========
[INFO]     [creator]     fail: google.nodejs.runtime@0.9.0
[INFO]     [creator]     fail: google.config.entrypoint@0.9.0
[INFO]     [creator]     ERROR: No buildpack groups passed detection.
[INFO]     [creator]     ERROR: Please check that you are running against the correct path.
[INFO]     [creator]     ERROR: failed to detect: failed to detect: no buildpacks participating
eddumelendez

comment created time in 4 days

PR opened benwilcock/spring-rsocket-demo

Improvements
  • Polish
  • Use LocalRSocketServerPort instead Value annotation
+4 -5

0 comment

1 changed file

pr created time in 4 days

create barncheddumelendez/spring-rsocket-demo

branch : polish

created branch time in 4 days

fork eddumelendez/spring-rsocket-demo

Getting Started With RSocket in Spring Boot

fork in 4 days

issue commentGoogleCloudPlatform/buildpacks

Add support to create a container from jar

examples are attached. They are generated from start.spring.io with the latest snapshots only

In order to run gradle-demo: ./gradlew bootBuildImage --builder=gcr.io/buildpacks/builder

In order to run maven-demo:./mvnw spring-boot:build-image -DskipTests -Dspring-boot.build-image.builder=gcr.io/buildpacks/builder

Both generate the error message ERROR: No buildpack groups passed detection.

gradle-demo.zip maven-demo.zip

eddumelendez

comment created time in 5 days

issue commentGoogleCloudPlatform/buildpacks

Add support to create a container from jar

for maven projects the jar is inside root-project -> target -> jar and for gradle is root-project -> build -> libs -> jar

eddumelendez

comment created time in 5 days

issue commentspring-cloud/spring-cloud-gcp

Stackdriver Monitoring Exporter for Micrometer

there is currently support for stackdriver in spring-boot you can see the docs here

#2391 tries to solve the project-id and credentials auto-detection.

saturnism

comment created time in 5 days

issue openedGoogleCloudPlatform/buildpacks

Add support to create a container from jar

Currently, spring-boot supports image customization via maven or gradle in the latest snapshots get

[INFO] Building image 'docker.io/library/demo:0.0.1-SNAPSHOT'
[INFO]
[INFO]  > Pulling builder image 'gcr.io/buildpacks/builder:latest' 100%
[INFO]  > Pulled builder image 'gcr.io/buildpacks/builder@sha256:efb5f9b7cd976ab6e5a959f453795863a476878be8e5c20b50db22c8aec1227f'
[INFO]  > Pulling run image 'gcr.io/buildpacks/gcp/run:latest' 100%
[INFO]  > Pulled run image 'gcr.io/buildpacks/gcp/run@sha256:9b3973dd6765f88815318454e337b7f5aacf25cf27f3038be49ef18cf6fce3b1'
[INFO]  > Executing lifecycle version v0.7.5
[INFO]  > Using build cache volume 'pack-cache-5cbe5692dbc4.build'
[INFO]
[INFO]  > Running creator
[INFO]     [creator]     ---> DETECTING
[INFO]     [creator]     ERROR: No buildpack groups passed detection.
[INFO]     [creator]     ERROR: Please check that you are running against the correct path.
[INFO]     [creator]     ERROR: failed to detect: failed to detect: no buildpacks participating

and this is due to spring-boot already build the jar so the builder is not able to detect the jar produced. I think will be nice to have this.

Originally posted by @eddumelendez in https://github.com/GoogleCloudPlatform/buildpacks/issues/32#issuecomment-632735912

created time in 6 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha 7c9e0ae0e5e56c81773471c47cf349d7341eaf61

Remove port assertion

view details

Eddú Meléndez

commit sha 76b566218c4752cd7809852a7e8730c1c27c484f

Add incubating module note

view details

Eddú Meléndez

commit sha f9c7005b1fce53426d427d5c8f88ce001e0828a1

Use codeinclude macro

view details

Eddú Meléndez

commit sha 21caa01bfe44688e1add8363e56ad8fa344d60ee

spaces instead of tabs

view details

push time in 6 days

push eventeddumelendez/spring-cloud-gcp

Eddú Meléndez

commit sha 0c14609a68fb2922a06adcabffcca2bdaf523741

Add docs

view details

push time in 6 days

push eventeddumelendez/spring-cloud-gcp

Eddú Meléndez

commit sha febc0e9e7397f1f18f288f0f48256d5fa86d6bdd

Add spring-cloud-gcp-starter-metrics

view details

push time in 6 days

pull request commentspring-cloud/spring-cloud-gcp

Add secret manager enabled property to properties metadata

the entry is now duplicated. it was renamed as part of https://github.com/spring-cloud/spring-cloud-gcp/pull/2302

dzou

comment created time in 7 days

create barncheddumelendez/spring-cloud-gcp

branch : micrometer_autoconfig

created branch time in 7 days

PR opened spring-cloud/spring-cloud-gcp

micrometer autoconfig
  • Add configuration properties for metrics
  • Add Micrometer AutoConfiguration
+266 -2

0 comment

8 changed files

pr created time in 7 days

push eventeddumelendez/lein-paketo-buildpack

Eddú Meléndez

commit sha 0686539ddc8d0f9c604590f836d01b726f6f7338

Add detect

view details

push time in 8 days

create barncheddumelendez/lein-paketo-buildpack

branch : master

created branch time in 8 days

created repositoryeddumelendez/lein-paketo-buildpack

created time in 8 days

fork eddumelendez/maven

A Cloud Native Buildpack that builds Maven-based applications from source

fork in 8 days

issue commentGoogleCloudPlatform/buildpacks

No buildpack groups passed detection for cf-acceptance-test java and dotnet-core sample

Currently, spring-boot supports image customization via maven or gradle in the latest snapshots get

[INFO] Building image 'docker.io/library/demo:0.0.1-SNAPSHOT'
[INFO]
[INFO]  > Pulling builder image 'gcr.io/buildpacks/builder:latest' 100%
[INFO]  > Pulled builder image 'gcr.io/buildpacks/builder@sha256:efb5f9b7cd976ab6e5a959f453795863a476878be8e5c20b50db22c8aec1227f'
[INFO]  > Pulling run image 'gcr.io/buildpacks/gcp/run:latest' 100%
[INFO]  > Pulled run image 'gcr.io/buildpacks/gcp/run@sha256:9b3973dd6765f88815318454e337b7f5aacf25cf27f3038be49ef18cf6fce3b1'
[INFO]  > Executing lifecycle version v0.7.5
[INFO]  > Using build cache volume 'pack-cache-5cbe5692dbc4.build'
[INFO]
[INFO]  > Running creator
[INFO]     [creator]     ---> DETECTING
[INFO]     [creator]     ERROR: No buildpack groups passed detection.
[INFO]     [creator]     ERROR: Please check that you are running against the correct path.
[INFO]     [creator]     ERROR: failed to detect: failed to detect: no buildpacks participating

and this is due to spring-boot already build the jar so the builder is not able to detect the jar produced. I think will be nice to have this.

xiujuan95

comment created time in 9 days

create barncheddumelendez/sdkman-db-migrations

branch : openjdk_15ea24

created branch time in 9 days

issue commentspring-projects/spring-boot

Pulling CNB run image fails when no tag is provided in image name

@scottfrederick running the command ./mvnw spring-boot:build-image -DskipTests -Dspring-boot.build-image.builder=gcr.io/buildpacks/builder now causes

[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.3.1.BUILD-SNAPSHOT:build-image (default-cli) on project demo: Execution default-cli of goal org.springframework.boot:spring-boot-maven-plugin:2.3.1.BUILD-SNAPSHOT:build-image failed: Builder lifecycle 'creator' failed with status code 1 -> [Help 1]
scottfrederick

comment created time in 9 days

Pull request review commentspring-cloud/spring-cloud-function

Add instructions for GCF background functions

 curl http://localhost:8080/ -d "hello" As of March 2020, Google Cloud Functions for Java is in Alpha. You can get on the https://docs.google.com/forms/d/e/1FAIpQLScC98jGi7CfG0n3UYlj7Xad8XScvZC8-BBOg7Pk3uSZx_2cdQ/viewform[whitelist] to try it out. -In order to use the adapter, first add the dependency to your pom.xml:+Start by packaging your application. -[source, xml] -----<dependency>-    <groupId>org.springframework.cloud</groupId>-    <artifactId>spring-cloud-function-adapter-gcp</artifactId>-</dependency>+mvn package ---- -Then, add the `spring-boot-maven-plugin` with `spring-cloud-function-adapter-gcp` as a dependency.-The extra dependency is used for `spring-boot-maven-plugin` to package your function in the correct JAR format for deployment on Google Cloud Functions.+If you added the custom `spring-boot-maven-plugin` plugin defined above, you should see the resulting JAR in `target/deploy` directory.+This JAR is correctly formatted for deployment to Google Cloud Functions.++Next, make sure that you have the https://cloud.google.com/sdk/install[Cloud SDK CLI] installed.++From the project base directory run the following command to deploy. -[source, xml] -----<plugin>-    <groupId>org.springframework.boot</groupId>-    <artifactId>spring-boot-maven-plugin</artifactId>-    <configuration>-        <outputDirectory>target/deploy</outputDirectory>-    </configuration>-    <dependencies>-        <dependency>-            <groupId>org.springframework.cloud</groupId>-            <artifactId>spring-cloud-function-adapter-gcp</artifactId>-        </dependency>-    </dependencies>-</plugin>+gcloud alpha functions deploy function-sample-gcp \+--entry-point org.springframework.cloud.function.adapter.gcp.GcfJarLauncher \+--runtime java11 \+--trigger-http \+--source target/deploy \+--memory 512MB ---- -Package the application.+Invoke the HTTP function:++----+curl https://REGION-PROJECT_ID.cloudfunctions.net/function-sample-gcp -d "hello"+----++==== Background Functions++Google Cloud Functions also supports deploying https://cloud.google.com/functions/docs/writing/background[Background Functions] which are invoked indirectly in response to an event, such as a message on a https://cloud.google.com/pubsub[Pub/Sub] topic, a change in a https://cloud.google.com/storage[Cloud Storage] bucket, or a https://firebase.google.com/[Firebase] event.++The `spring-cloud-function-adapter-gcp` allows for functions to be deployed as background functions as well.++The sections below describe the process for writing a Cloud Pub/Sub topic background function.+However, there are a number of different event types that can trigger a background function to execute which are not discussed here; these are described in the https://cloud.google.com/functions/docs/calling[Background Function triggers documentation].++===== Getting Started++Let’s start with a simple Spring Cloud Function which will run as a GCF background function:++[source, java]+----+@SpringBootApplication+public class BackgroundFunctionMain {++	public static void main(String[] args) {+		SpringApplication.run(BackgroundFunctionMain.class, args);+	}++	@Bean+	public Consumer<PubSubMessage> pubSubFunction() {+		return message -> System.out.println("The Pub/Sub message data: " + message.getData());+	}+}+----++In addition, create `PubSubMessage` class in the project with the below definition.+This class represents the https://cloud.google.com/functions/docs/calling/pubsub#event_structure[Pub/Sub event structure] which gets passed to your function on a Pub/Sub topic event.++[source, java]+----+public class PubSubMessage {++	private String data;++	private Map<String, String> attributes;++	private String messageId;++	private String publishTime;++	public String getData() {+		return data;+	}++	public void setData(String data) {+		this.data = data;+	}++	public Map<String, String> getAttributes() {+		return attributes;+	}++	public void setAttributes(Map<String, String> attributes) {+		this.attributes = attributes;+	}++	public String getMessageId() {+		return messageId;+	}++	public void setMessageId(String messageId) {+		this.messageId = messageId;+	}++	public String getPublishTime() {+		return publishTime;+	}++	public void setPublishTime(String publishTime) {+		this.publishTime = publishTime;+	}++}+----++Specify your configuration main class in `resources/META-INF/MANIFEST.MF`.++[source]+----+Main-Class: com.example.BackgroundFunctionMain+----++Then run the function locally.+This is provided by the Google Cloud Functions `function-maven-plugin` described in the project dependencies section.++----+mvn function:run+----++Invoke the HTTP function:++----+curl localhost:8080 -H "Content-Type: application/json" -d '{"data":"hello"}'+----++Verify that the function was invoked by viewing the logs.++===== Deploy to GCP++In order to deploy your background function to GCP, first package your application.  ---- mvn package ---- -You should see the resulting JAR in `target/deploy` directory.+If you added the custom `spring-boot-maven-plugin` plugin defined above, you should see the resulting JAR in `target/deploy` directory. This JAR is correctly formatted for deployment to Google Cloud Functions. -Make sure that you have the https://cloud.google.com/sdk/install[Cloud SDK CLI] installed.+Next, make sure that you have the https://cloud.google.com/sdk/install[Cloud SDK CLI] installed.  From the project base directory run the following command to deploy.  -----gcloud alpha functions deploy function-sample-gcp \+gcloud alpha functions deploy function-sample-gcp-background \

I am wondering if --allow-unauthenticated should be added

dzou

comment created time in 11 days

startedopenrewrite/rewrite-gradle-plugin

started time in 11 days

startedopenrewrite/rewrite-maven-plugin

started time in 11 days

startedopenrewrite/rewrite-spring

started time in 11 days

Pull request review commentspring-io/start.spring.io

Add support for Testcontainers

+/*+ * Copyright 2012-2019 the original author or authors.

2020? the same for the other classes

maciejwalkowiak

comment created time in 12 days

push eventeddumelendez/start.spring.io

Damien Vitrac

commit sha 1b7e0f70c5002467c2f6f1d31bd6e58133b53aa4

Error message See gh-418

view details

Stephane Nicoll

commit sha 75a203b924f3e757d86ed1d9a40e03569481aabc

Merge pull request #418 from oodamien * pr/418: Error message Closes gh-418

view details

Stephane Nicoll

commit sha 949284f8f95ce1fd5a43464ff2a582be3608e4e8

Revert "Merge pull request #418 from oodamien" This reverts commit 75a203b924f3e757d86ed1d9a40e03569481aabc, reversing changes made to faaf9b7a04b6ef64fd756902781282ef1fa33f8f.

view details

Damien Vitrac

commit sha 4881b5390d9111e58efa17166a574033d8892b63

Fix closing issue on dialog dependencies

view details

Damien Vitrac

commit sha 8af4a1afd6fd37020f990aa60e1643362031d36e

Fix changes name metadata See gh-1078

view details

Zhe Sun

commit sha 64daaf45a95025917502cd590a0250559ce551fb

Upgrade to Vaadin 14.1.23 See gh-420

view details

Stephane Nicoll

commit sha 3baf3eb7c413a57e7e254d9ec70f11b548bb07f7

Merge pull request #420 from ZheSun88 * pr/420: Upgrade to Vaadin 14.1.23 Closes gh-420

view details

Damien Vitrac

commit sha f2500bde986f7df9889e6b880196319cb0900ba3

Add init test on empty values (Initializr Reducer) Closes gh-423

view details

Damien Vitrac

commit sha 23f3aa7995fa1b4d1b27a63412d4f3898c99c9c3

Add visual indication on project generation Closes gh-422

view details

Damien Vitrac

commit sha ad06f2c20d9be5081c0b94954a4ae6b22edf6b7b

Fix loading time

view details

Claus Ibsen

commit sha 9bb29686c5a5a5658fb5077870032c2ba9d65da5

Upgrade to Apache Camel 3.2.0 and 2.25.1 See gh-427

view details

Stephane Nicoll

commit sha 38255ebb43faa6a1a5b21def8e875b5a17190104

Merge pull request #427 from davsclaus * pr/427: Upgrade to Apache Camel 3.2.0 and 2.25.1 Closes gh-427

view details

juhopiirainen

commit sha a925667c1cce47ace6552add4fa5a6c0d9647e9f

Upgrade to Vaadin 14.1.25 See gh-425

view details

Stephane Nicoll

commit sha 12cd7ce03289d47b1b7fe5b643a0573c1e023583

Merge pull request #425 from juhopiirainen * pr/425: Upgrade to Vaadin 14.1.25 Closes gh-425

view details

Damien Vitrac

commit sha 8b3042cdbdb97ed65c40e206e857196a3d92e0fe

Update radio style

view details

Damien Vitrac

commit sha 7f707c17bed34a13b5bc9d5d58c71fc5a901c335

Update button style

view details

Stephane Nicoll

commit sha e74294bfc70c6574710689922bfb13b43a9221f4

Upgrade to Spring for Apache Geode 1.3.0.M4 Closes gh-428

view details

Stephane Nicoll

commit sha bbf8dd0d259d2de311e568cdc097b6994a1b4009

Upgrade to Spring Cloud Hoxton.SR4 Closes gh-429

view details

Stephane Nicoll

commit sha dd6b980b2430f8e7451c199f7ad1e2d85a53b543

Fix consul config metadata again This commit reverts 420c284bf829104798029a0040921614b47fc2ae since the metadata of the starter have changed again. Closes gh-433

view details

juhopiirainen

commit sha 2731cdf8ba068f9ae3988390033a99b05e72d3e6

Upgrade to Vaadin 14.1.27 See gh-432

view details

push time in 12 days

pull request commentsdkman/sdkman-db-migrations

Add GraalVM 20.1.0

I have added a new commit in order to remove the older versions. Just let me know If there should be another change.

eddumelendez

comment created time in 12 days

push eventeddumelendez/sdkman-db-migrations

Eddú Meléndez

commit sha 64e02902dd36967546fb2e2e0832346ebdb7ac09

Remove old graalvm versions

view details

push time in 12 days

push eventeddumelendez/sdkman-db-migrations

push time in 12 days

push eventeddumelendez/sdkman-db-migrations

Eddú Meléndez

commit sha d7c2abe7acfd68bc49baca6eed8ea04356409c22

Add Java 14ea30

view details

Eddú Meléndez

commit sha 4e625f3b6f2c1315ef357014b8953c19593027f4

Add Java 15ea4

view details

Eddú Meléndez

commit sha b14574f1d3b2714b1bd5bd22ed51678d28017224

Remove old versions for java 14 and 15

view details

Iván López

commit sha 0b71fa62d484d0de935ff08a8746f42a82b68296

Add GraalVM 19.3.1

view details

Eddú Meléndez

commit sha c0648b236f955632c2fdc71fad3ed7e1c27576b2

Add Java 14ea32

view details

Eddú Meléndez

commit sha ff9552b7da68403c16e71992c8a36f9c793a5ade

Add Java 15ea6

view details

Kenji Saito

commit sha 270209336f302ca77652d3479a6cdaacf309e099

Fix the migrate error Delete unavailable "OpenJDK 14 EA"

view details

Kenji Saito

commit sha 26452b77cc89de5f2738433d00ff6f996fc39e2b

Update version of SapMachine January 2020 release

view details

Kenji Saito

commit sha e1417aa3491a1dab51122ac7754fe09216380a0b

Update version of Amazon Corretto January 2020 release

view details

Kenji Saito

commit sha 98c7d58f5b3c02b81899ba5b8cdae95fc0685e44

Update version of Zulu January 2020 release

view details

Kenji Saito

commit sha 9fdb5173f88882170dd3e5bb679dfd99a2f09cbc

[Review Fix] Removes duplicate version expression

view details

Kenji Saito

commit sha 9714d3d8ae78f72054759b21cde23ecbb9289ef4

Update version of BellSoft Liberica JDK January 2020 release

view details

Marco Vermeulen

commit sha 0822b095161733ed4bbac2a0a9ef89b2ef73de54

Introduce scalafmt.

view details

Marco Vermeulen

commit sha fbc186b314b1e26f1a13179bfe0c53a46e6ebf91

Apply scalafmt to all scala sources.

view details

Marco Vermeulen

commit sha fc9f02089354ea0d3be6f1d64cc11df513a65093

Make scalafmt depend on compileScala.

view details

Kenji Saito

commit sha 4b018aa3c8296dcb7e792788ab0dc23007ae338f

Added AdoptOpenJDK 11.0.6 - HotSpot - OpenJ9

view details

Kenji Saito

commit sha 27acedf9d52c9e603d8a5cb474f4d574757dec22

[Review fix] Add the default mark to 11.0.6.hs-adpt in AdoptOpenJDK

view details

Kenji Saito

commit sha edc276e46e8a7cac19c8725db876888aeb1d7e56

Added AdoptOpen_jdk 8.0.242 hotspot

view details

Kenji Saito

commit sha 60e66a8be3f9a84bee7897a376495593a79b7494

[Fix the build error and apply scalafmt

view details

Marco Vermeulen

commit sha 223d21e6f3f0eeb319d98f99549755e3f70733a3

Fix typo in removing JDK 8.0.232.hs-adpt.

view details

push time in 12 days

create barncheddumelendez/sdkman-db-migrations

branch : visualvm_2.0.2

created branch time in 12 days

create barncheddumelendez/sdkman-db-migrations

branch : graalvm_20.1.0

created branch time in 12 days

issue commentspring-cloud/spring-cloud-gcp

spring.cloud.gcp.pubsub.emulator-host doensn't work

The prefix is required for dns names. I don't think we can switch to requiring users to append it to the host name (breaking change).

@dmitry-s throw a warning when the prefix is not used, wdyt? and let people know that in future versions they need to prepend dns:// and to keep backward compatibility.

saturnism

comment created time in 13 days

startedspring-cloud/spring-cloud-bindings

started time in 15 days

issue commentspring-cloud/spring-cloud-gcp

Add annotation which bring support to test against spanner

this is what we currently should do in order to test the repositories.

With the @SpannerTest or @DataSpannerTest we can provide the right dependencies via spring.factories and drop the config to detect repositories. However, the properties need to be set.

I am wondering how the amazing work #2357 can also help this approach too! I am also thinking about testing the emulator not only against localhost but also include testcontainers.

eddumelendez

comment created time in 17 days

create barncheddumelendez/sdkman-db-migrations

branch : openjdk_15ea23

created branch time in 17 days

Pull request review commenttestcontainers/testcontainers-java

Add gcloud module

+package org.testcontainers.containers;++import java.io.IOException;+import java.util.ArrayList;+import java.util.Arrays;+import java.util.List;++import com.github.dockerjava.api.command.InspectContainerResponse;+import org.testcontainers.images.builder.ImageFromDockerfile;+import org.testcontainers.images.builder.dockerfile.DockerfileBuilder;++/**+ * @author Eddú Meléndez+ */+public class GCloudGenericContainer<SELF extends GCloudGenericContainer<SELF>> extends GenericContainer<SELF> {++	public static final String DEFAULT_GCLOUD_IMAGE = "google/cloud-sdk:291.0.0-alpine";++	private List<String> commands = new ArrayList<>();++	public GCloudGenericContainer(String image) {+		super(image);+	}++	public GCloudGenericContainer(String image, String mainCmd, String[] prerequisiteCmds) {+		super(buildImage(image, mainCmd, prerequisiteCmds));+	}++	@Override+	protected void containerIsStarted(InspectContainerResponse containerInfo) {+		runAdditionalCommands();+	}++	private void runAdditionalCommands() {+		this.commands.forEach(cmd -> {+			try {+				execInContainer(cmd);+			} catch (IOException | InterruptedException e) {+				logger().error("Failed to execute {}. Exception message: {}", cmd, e.getMessage());+			}+		});+	}++	public SELF withAdditionalCommands(String... cmds) {+		this.commands.addAll(Arrays.asList(cmds));+		return self();+	}++	private static ImageFromDockerfile buildImage(String image, String mainCmd, String[] prerequisiteCmds) {

At the beginning I was not able to run it using command but that led me to know more about testcontainers. Now, I did it but had to set up a startupTimeout.

eddumelendez

comment created time in 18 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha bb74295396171501ae57d495609e1f5fd90ca8e4

Build images using CMD

view details

push time in 18 days

startedopenrewrite/rewrite

started time in 18 days

pull request commenttestcontainers/testcontainers-java

Add gcloud module

It is pending to polish the pubsub test 🙈

eddumelendez

comment created time in 22 days

PR opened testcontainers/testcontainers-java

Reviewers
gcloud
  • Add support to perform additional commands in the container
  • Add docs
  • Add gcloud module
+479 -0

0 comment

12 changed files

pr created time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha 964103c3f495f8c4338eac2095fd3d869aaa8c15

Add gcloud module Based on google cloud sdk docker image. This module provides: * DatastoreEmulatorContainer * FirestoreEmulatorContainer * PubSubEmulatorContainer `SpannerEmulatorContainer` is also provided but is based on its own docker image. See gh-2633

view details

Eddú Meléndez

commit sha 59f9e3eb558cab81b9e41b4aa1b0a0090f76c96d

Add docs

view details

Eddú Meléndez

commit sha 64f426c620372d757fa16d63b966620dd4e5d7d5

Add support to perform additional commands in the container

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha e33f60ad896dc3e9df8304b906967681b99f504f

Add gcloud module Based on google cloud sdk docker image. This module provides: * DatastoreEmulatorContainer * FirestoreEmulatorContainer * PubSubEmulatorContainer `SpannerEmulatorContainer` is also provided but is based on its own docker image.

view details

Eddú Meléndez

commit sha 174922d19acb665d70962db23a26cb1b1ec40f2c

Add docs

view details

Eddú Meléndez

commit sha 884514759984d450bc8f3c0933be7fce709a25a3

Add support to perform additional commands in the container

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha 722d3e247ce01fe6f448e00c97163d6928e95859

Add gcloud module This module provides: * DatastoreEmulatorContainer * FirestoreEmulatorContainer * PubSubEmulatorContainer * SpannerEmulatorContainer

view details

Eddú Meléndez

commit sha 5265b9f1e7f2329a077ee973eb31217dae457ce4

Add docs

view details

Eddú Meléndez

commit sha c28340520979275f7f58122e610c9876c3adaf71

Add support to perform additional commands in the container

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha 18c379708476b67954adcb2fd2392a860ff897c0

Add support to perform additional commands in the container

view details

Eddú Meléndez

commit sha 06e57d401887f428f755a0b2ea90cab707c12746

Clean imports

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha 499242a0684bd8bdfcec6cd78e42c4e6a071d8e5

Polish docs

view details

Eddú Meléndez

commit sha 77c6af5276578f33a0390fdf4ee2c4ad800c60fd

Polish GCloudGenericContainer

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha 4d0bf77d1a702158cd77928854f138a164b7fa47

Polish GCloudGenericContainer

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha 468017dad338bbf67a7ccdac0dfd3ac9a0c44e38

Polish docs

view details

Eddú Meléndez

commit sha 5c31962aca398b1a29495985c9d77310d0db2dec

Remove abstract

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha 9dae415c8383f5332b25014b9a32d3f8a4cf024e

Provide constructor to override images

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha c97ccd2e9151053bf5e15bf13fa509ca70c999fc

Add docs

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha 19132a04f6afeffce85f92613dae7a96bcaa1648

Polish spanner

view details

Eddú Meléndez

commit sha 155651178c48c3df05669073759c588ba52d4eeb

Polish expose ports

view details

Eddú Meléndez

commit sha 2beda1e55633d57b63c289adc2f1149bf5bf25e3

Polish wait strategy

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Eddú Meléndez

commit sha 0cd464cffcf7a114ec58dd32441a6f29cbbd7ba0

Update image tag

view details

push time in 22 days

push eventeddumelendez/testcontainers-java

Sergei Egorov

commit sha d4f894f081838de96f0053312b08dc2f9a365a64

Fallback to `getDefaultGateway()` if "bridge" is unavailable. (#2429) Fixes #2239

view details

Anton Deriabin

commit sha 7acb08d6c5c99f94a40998e00fb1db18cc66c061

Bump Cucucmber example version to 5.5.0 (#2476) * Bump Cucucmber example version to 5.5.0 * Fixed wrong imports

view details

Grzegorz Piwowarek

commit sha a51b1e0d457f652dcd236320b3e089bc2ee0228c

Add custom exception message when HealthState not present in response (#2206) See ##2205

view details

Sergei Egorov

commit sha 682bfac4e45b5a900f9ce9d6ca687af692ed6e8c

Use `@DynamicPropertySource` in the Spring Boot example (#2495)

view details

dependabot-preview[bot]

commit sha 7c635e0c86adf3c88bad081d124ea651736c0738

Bump mockito-core from 3.3.0 to 3.3.3 in /core (#2439) Bumps [mockito-core](https://github.com/mockito/mockito) from 3.3.0 to 3.3.3. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](https://github.com/mockito/mockito/compare/v3.3.0...v3.3.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 0c02e71a507cdeb106aaf692ccc33bccd5729a6c

Bump httpclient from 4.5.11 to 4.5.12 in /modules/spock (#2411) Bumps httpclient from 4.5.11 to 4.5.12. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha ab72e1b07759a292bdd256aa53f274f083aa3339

Bump postgresql from 42.2.10 to 42.2.12 in /modules/spock (#2502) Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.10 to 42.2.12. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.2.10...REL42.2.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 7025e3fbdb934962454070b00b6444936c1f9ecd

Bump elasticsearch-rest-client from 7.6.1 to 7.6.2 in /modules/… (#2501) Bumps [elasticsearch-rest-client](https://github.com/elastic/elasticsearch) from 7.6.1 to 7.6.2. - [Release notes](https://github.com/elastic/elasticsearch/releases) - [Commits](https://github.com/elastic/elasticsearch/compare/v7.6.1...v7.6.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha b3ec8a38a6da5c88b1989ba0d9b3765dcdb44675

Bump postgresql from 42.2.10 to 42.2.12 in /examples (#2500) Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.10 to 42.2.12. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.2.10...REL42.2.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha b96c84bc2ae71adea293a50015ccd26f520ddb81

Bump postgresql from 42.2.10 to 42.2.12 in /modules/junit-jupit… (#2498) Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.10 to 42.2.12. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.2.10...REL42.2.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 2ef0ef28d39d327d351ad96623191fbcc921b238

Bump tomcat-jdbc from 9.0.31 to 9.0.33 in /modules/mysql (#2445) Bumps tomcat-jdbc from 9.0.31 to 9.0.33. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha e4633d827d057e260d2324d7e9103cd1bcc894cd

Bump mariadb-java-client from 2.5.4 to 2.6.0 in /modules/mariadb (#2461) Bumps [mariadb-java-client](https://github.com/mariadb-corporation/mariadb-connector-j) from 2.5.4 to 2.6.0. - [Release notes](https://github.com/mariadb-corporation/mariadb-connector-j/releases) - [Changelog](https://github.com/mariadb-corporation/mariadb-connector-j/blob/master/CHANGELOG.md) - [Commits](https://github.com/mariadb-corporation/mariadb-connector-j/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha d64e5790b51e1fdccba86f5c13a8c40b9f3af2a0

Bump kafka-clients from 2.4.0 to 2.4.1 in /modules/kafka (#2424) Bumps kafka-clients from 2.4.0 to 2.4.1. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 19d954c2ce08f9e762a52e55491bb4108e5a7c17

Bump testng from 7.1.1 to 7.2.0 in /examples (#2441) Bumps [testng](https://github.com/cbeust/testng) from 7.1.1 to 7.2.0. - [Release notes](https://github.com/cbeust/testng/releases) - [Changelog](https://github.com/cbeust/testng/blob/master/CHANGES.txt) - [Commits](https://github.com/cbeust/testng/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha b6866be6c29795c9499e73c91b3a8b40b5c9966e

Bump postgresql from 42.2.10 to 42.2.12 in /modules/postgresql (#2499) Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.10 to 42.2.12. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.2.10...REL42.2.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 5c2714f55c665bcd9f266b7039d39613f448ae65

Bump tomcat-jdbc from 9.0.31 to 9.0.33 in /modules/mariadb (#2444) Bumps tomcat-jdbc from 9.0.31 to 9.0.33. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha a65789df7b77582f10e5255cc4002f6e5ce4c82e

Bump okhttp from 3.14.6 to 3.14.7 in /examples (#2481) Bumps [okhttp](https://github.com/square/okhttp) from 3.14.6 to 3.14.7. - [Release notes](https://github.com/square/okhttp/releases) - [Changelog](https://github.com/square/okhttp/blob/master/docs/changelog_3x.md) - [Commits](https://github.com/square/okhttp/compare/parent-3.14.6...parent-3.14.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha fad1667d53c1832cac79fe9f94a688a05d98a933

Bump rest-assured from 4.2.0 to 4.3.0 in /modules/vault (#2440) Bumps [rest-assured](https://github.com/jayway/rest-assured) from 4.2.0 to 4.3.0. - [Release notes](https://github.com/jayway/rest-assured/releases) - [Changelog](https://github.com/rest-assured/rest-assured/blob/master/changelog.txt) - [Commits](https://github.com/jayway/rest-assured/compare/rest-assured-4.2.0...rest-assured-4.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Grzegorz Piwowarek

commit sha 08e13bf2273ef6e2da004644ae7de6051e39ccda

Bump Copyrights to 2020 (#2488)

view details

Richard North

commit sha 7eced8b44de8bda25c6312e4a08461d9514d9686

Cache results of auth lookups (#2213)

view details

push time in 22 days

push eventeddumelendez/gcloud-emulators-docker

Eddú Meléndez

commit sha b7a6dfb588804056e098d44a72ec251297620e78

Add links to docker hub

view details

Eddú Meléndez

commit sha 35bf345fd98da1bf7606b1ebadaa3a1b19ee53cf

Polish Dockerfiles

view details

push time in 23 days

create barncheddumelendez/gcloud-emulators-docker

branch : master

created branch time in 23 days

created repositoryeddumelendez/gcloud-emulators-docker

This repository is exclusively to create gcloud emulators based on alpine image

created time in 23 days

Pull request review commentspring-cloud/spring-cloud-gcp

Test support module

+/*+ * Copyright 2017-2020 the original author or authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package org.springframework.cloud.gcp.test;++import org.apache.commons.logging.Log;+import org.apache.commons.logging.LogFactory;++public class PubSubEmulatorHelper extends AbstractEmulatorHelper {+	private static final Log LOGGER = LogFactory.getLog(PubSubEmulatorHelper.class);++	String getGatingPropertyName() {

not sure if this should be provided

dmitry-s

comment created time in 23 days

Pull request review commentspring-cloud/spring-cloud-gcp

Test support module

+/*+ * Copyright 2017-2018 the original author or authors.

update copyright's year

dmitry-s

comment created time in 23 days

create barncheddumelendez/spring-cloud-gcp

branch : missing_spanner_tx_manager

created branch time in 23 days

startedGoogleCloudPlatform/buildpacks

started time in 24 days

pull request commentspring-cloud/spring-cloud-gcp

Add SpannerOptions auto-configuration for emulator

don't mind at all. I'd prefer to use emulator.host but I think we need to align with for the other emulator properties too. WDYT?

eddumelendez

comment created time in 24 days

push eventeddumelendez/spring-cloud-gcp

Eddú Meléndez

commit sha 6353ecab1987b295f8c20c9acef06beb7c6bcb98

Polish

view details

push time in 24 days

create barncheddumelendez/sdkman-db-migrations

branch : openjdk_15ea22

created branch time in 24 days

create barncheddumelendez/assertj-core

branch : fix_javadoc

created branch time in 25 days

PR opened joel-costigliola/assertj-core

Fix javadoc
+1 -1

0 comment

1 changed file

pr created time in 25 days

pull request commentspring-cloud/spring-cloud-gcp

Add SpannerOptions auto-configuration for emulator

PR is updated with docs and also in order to keep the consistency between emulator rename the previous emulator-host to host-port.

eddumelendez

comment created time in 25 days

push eventeddumelendez/spring-cloud-gcp

Eddú Meléndez

commit sha f1f8394974d87a36100df26057529226ecb2eb5d

Update docs

view details

Eddú Meléndez

commit sha 6c5c52a64307d2d4280fbfcb2da9a03e762ee183

Rename property to host-port and add assert

view details

push time in 25 days

Pull request review commentspring-cloud/spring-cloud-gcp

Add SpannerOptions auto-configuration for emulator

+/*+ * Copyright 2017-2020 the original author or authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package org.springframework.cloud.gcp.autoconfigure.spanner;++import com.google.cloud.NoCredentials;+import com.google.cloud.spanner.SpannerOptions;++import org.springframework.boot.autoconfigure.AutoConfigureBefore;+import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;+import org.springframework.boot.context.properties.EnableConfigurationProperties;+import org.springframework.context.annotation.Bean;+import org.springframework.context.annotation.Configuration;++/**+ * Provides auto-configuration to use the Spanner emulator if enabled.+ *+ * @author Eddú Meléndez+ */+@Configuration+@AutoConfigureBefore(GcpSpannerAutoConfiguration.class)+@EnableConfigurationProperties(GcpSpannerProperties.class)+@ConditionalOnProperty(prefix = "spring.cloud.gcp.spanner.emulator", name = "enabled", havingValue = "true")+public class GcpSpannerEmulatorAutoConfiguration {++	private final GcpSpannerProperties properties;++	public GcpSpannerEmulatorAutoConfiguration(GcpSpannerProperties properties) {+		this.properties = properties;+	}++	@Bean+	@ConditionalOnMissingBean+	public SpannerOptions spannerOptions() {+		SpannerOptions.Builder builder = SpannerOptions.newBuilder()+				.setProjectId(this.properties.getProjectId())+				.setCredentials(NoCredentials.getInstance());+		if (this.properties.getEmulatorHost() != null) {

the client library resolves the SPANNER_EMULATOR_HOST environment variable. But, I agree it can be dismiss. I think we can validate if the environment variable or the property is set, otherwise we can fail and say neither environment variable or property was set. WDYT?

eddumelendez

comment created time in 25 days

create barncheddumelendez/spring-cloud-gcp

branch : spanner_emulator_support

created branch time in a month

PR opened spring-cloud/spring-cloud-gcp

Add SpannerOptions auto-configuration for emulator

Currently, in order to execute against the emulator, Spanner relies on SPANNER_EMULATOR_HOST environment variable. This commit introduces new configuration properties in order to enable and set the emulator host.

+131 -0

0 comment

5 changed files

pr created time in a month

Pull request review commentspring-cloud/spring-cloud-gcp

pubsub emulator rule moved to a separate project

+<?xml version="1.0" encoding="UTF-8"?>+<project xmlns="http://maven.apache.org/POM/4.0.0"+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">+    <modelVersion>4.0.0</modelVersion>+    <parent>+        <artifactId>spring-cloud-gcp</artifactId>+        <groupId>org.springframework.cloud</groupId>+        <version>1.2.3.BUILD-SNAPSHOT</version>+    </parent>+++    <artifactId>spring-cloud-gcp-test</artifactId>+    <name>Spring Cloud GCP Test Support</name>+    <description>Provides tools for testing Spring Cloud GCP projects</description>+    <dependencies>+		<dependency>+			<groupId>junit</groupId>+			<artifactId>junit</artifactId>

make it generic so people can reuse it sounds good. Can you take into account that may some people will be able to contribute creating rules for junit4 or extension for junit5 specifically? Those can be issues with ideal for contribution or help wanted. WDYT?

dmitry-s

comment created time in a month

create barncheddumelendez/testcontainers-java

branch : gcloud

created branch time in a month

issue openedGoogleCloudPlatform/cloud-sdk-docker

Provide alpine images for emulators

Currently using testcontainers to spin up emulators such as datastore, firestore, pubsub. In order to reduce the size of the images I am using the alpine image but need additional steps to install the components already mentioned. I think it would be awesome to get these components already installed in independent images with the cloud sdk.

Images can be:

  • google/cloud_sdk_datastore_emulator
  • google/cloud_sdk_firestore_emulator
  • google/cloud_sdk_pubsub_emulator

created time in a month

push eventeddumelendez/sdkman-db-migrations

Andre Brait

commit sha 7a1b1d860f5be538a4a10a1199bf2c8255b851a4

Update OpenJDK 8 and 11 to latest upstream versions (#255)

view details

Eddú Meléndez

commit sha c8abe71453346847b48bade12a2683e984a9e1e1

Add OpenJDK 15ea21

view details

push time in a month

more