profile
viewpoint
Marat Dyatko dyatko @Spotify Stockholm, Sweden https://www.linkedin.com/in/maratdyatko/ Full-stack developer with product management skills

dyatko/arkit 762

JavaScript architecture diagrams and dependency graphs

dyatko/worldstar 22

Generates world map chart of GitHub stargazers

dyatko/node-memwatch 1

A NodeJS library to keep an eye on your memory usage, and discover and isolate leaks.

dyatko/plantuml-encoder 1

PlantUML encoder, works in browser & node.js

dyatko/arkit-editor 0

React-based editor for PlantUML

dyatko/arkit-nuxt-todomvc 0

Nuxt.js TodoMVC Example

dyatko/beanstalk-deploy 0

GitHub action (and command line script) to deploy apps to Elastic Beanstalk

dyatko/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

dyatko/eslint-plugin-testing-library 0

ESLint plugin to follow best practices and anticipate common mistakes when writing tests with Testing Library

dyatko/js.org 0

Dedicated to JavaScript and its awesome community since 2015

startedclauderic/dnd-kit

started time in 2 months

startedcsswizardry/ct

started time in 2 months

startedsmartvotedocs/votesmart2021

started time in 3 months

delete branch dyatko/eslint-plugin-testing-library

delete branch : fix-prefer-by

delete time in 3 months

pull request commenttesting-library/eslint-plugin-testing-library

fix(prefer-find-by): stop prefer-find-by fixer to break code when no …

@Belco90 yeah, same issues in another PR https://github.com/testing-library/eslint-plugin-testing-library/pull/465

dyatko

comment created time in 3 months

Pull request review commenttesting-library/eslint-plugin-testing-library

fix(prefer-find-by): stop prefer-find-by fixer to break code when no …

 export default createTestingLibraryRule<Options, MessageIds>({               const textDestructuring = sourceCode.getText(                 allVariableDeclarations               );+              const hasSpaceBeforeBracket = textDestructuring.endsWith(' }');+              const symbolsToRemove = hasSpaceBeforeBracket ? 2 : 1;

@Belco90 yes, regex will do it best. Fixed in 41a8264

dyatko

comment created time in 3 months

PullRequestReviewEvent

push eventdyatko/eslint-plugin-testing-library

Marat Dyatko

commit sha 41a826401953a50174151db1d44c0ae9331df489

fix(prefer-find-by): use regex to add findByMethod

view details

push time in 3 months

PR opened testing-library/eslint-plugin-testing-library

fix(prefer-find-by): stop prefer-find-by fixer to break code when no …

…spaces before bracket

Checks

  • [x] I have read the contributing guidelines.
  • [ ] If some rule is added/updated/removed, I've regenerated the rules list.
  • [ ] If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

Add check for spaces before brackets for prefer-find-by fixer

Context

The rule fixer didn't assume that some codebases may not separate brackets with spaces, so it's braking the code:

-        const {getByLabelText, getByTestId, getByText} = await renderComponent();
+        const {getByLabelText, getByTestId, getByTex, findByText} = await renderComponent();
+33 -2

0 comment

2 changed files

pr created time in 3 months

create barnchdyatko/eslint-plugin-testing-library

branch : fix-prefer-by

created branch time in 3 months

fork dyatko/eslint-plugin-testing-library

ESLint plugin to follow best practices and anticipate common mistakes when writing tests with Testing Library

https://npm.im/eslint-plugin-testing-library

fork in 3 months

more