profile
viewpoint

dustinsoftware/Campusbullet 3

This repository contains historical commits for the campus bullet

dustinsoftware/Challonge-Scheduler 2

A C# app for scheduling stations a live tournament.

dustinsoftware/dotnet-wasm 2

🚀 A demo built using mono-wasm 0.0.1

dustinsoftware/2017-Projects 0

Every month, I'll post about a new project I'm experimenting with.

dustinsoftware/AlexaSkillsKit.NET 0

.NET library that simplifies Alexa skills development; started as a port of Amazon's AlexaSkillsKit for Java

dustinsoftware/Arduino 0

A repo for my random Arduino adventures.

dustinsoftware/awesome-react 0

A collection of awesome things regarding React ecosystem

startedalanhussey/golden-hour

started time in 18 hours

PR closed facebookexperimental/Recoil

Pack all JS files in dist folder CLA Signed

This was an oversight from #67

+1 -3

5 comments

1 changed file

dustinsoftware

pr closed time in a day

startedkentcdodds/react-performance

started time in a day

startedTracerBench/tracerbench

started time in 2 days

pull request commentfacebookexperimental/Recoil

Pack all JS files in dist folder

#195 appears to be a duplicate PR, should we land one of them soon?

dustinsoftware

comment created time in 2 days

startedxoofx/NUglify

started time in 2 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 3e2a8f9d7f7cdaa43a6379d000096ff6f31683a8

Improve merge detection

view details

push time in 4 days

pull request commentfacebook/create-react-app

Add optional support for custom postcss plugins

Bump? Is there any interest in this?

Otherwise probably need to use craco or something.....

dustinsoftware

comment created time in 6 days

pull request commentfacebookexperimental/Recoil

[docs] Use splice to make the docs more intuitive

I tested this out locally just to re-verify my understanding:

> let a = [1,2,3]
undefined
> a.splice(0,1)
[ 1 ]
> a
[ 2, 3 ]

Was just reminded of a surprising behavior: splice does not return the mutated array; it returns the items removed. While this documentation PR doesn't make this mistake, this is a subtle error that downstream consumers of this library could make.

For this reason I think we should avoid using splice in the docs...

GunaShekar02

comment created time in 6 days

pull request commentfacebookexperimental/Recoil

Remove duplicate package.json

Yeah I think blacklisting it would be good with whatever sync tool is in use... as an outsider it's confusing which package.json file should be trusted as the source of truth for the version shipped to npm.

dustinsoftware

comment created time in 6 days

Pull request review commentfacebookexperimental/Recoil

Fix global variable __DEV__

 const config = mode => ({     },     nodeResolve(),     commonjs(),-    mode === 'development' ? undefined : terser({ mangle: false }),+    replace({__DEV__: JSON.stringify(mode === 'development')}),

This seems to match the React rollup config, so looks good to me. Can we add a test verifying that DEV mode is active in Jest tests?

https://github.com/facebook/react/blob/master/scripts/rollup/build.js#L426

mondaychen

comment created time in 6 days

Pull request review commentfacebookexperimental/Recoil

[docs] Use splice to make the docs more intuitive

 function TodoItem({item}) {   };    const toggleItemCompletion = () => {-    const newList = replaceItemAtIndex(todoList, index, {-      ...item,-      isComplete: !item.isComplete,-    });+    const newList = todoList;+    newList.splice(index, 1, {...item, isComplete: !item.isComplete});

FWIW this seems like a stylistic change only; the code is perfectly readable as-is. Many codebases may prefer to avoid splice, speaking personally I prefer using spread over splice since with spread you can see exactly how the array is going to be transformed.

As an aside, this will mutate todoList instead of making a copy and passing it in; if you wanted to keep using splice then line 95 and 102 should probably be changed to const newList = [...todoList].

GunaShekar02

comment created time in 6 days

pull request commentfacebookexperimental/Recoil

Fix call stack size exceeded when set atom value with object that has circular reference

Cool! Seems like a pretty straight forward fix.

n3tr

comment created time in 6 days

pull request commentfacebookexperimental/Recoil

Rename .babelrc to babel.config.js to fix test runner

I don't think this is the right approach; the tests only started failing when https://github.com/facebookexperimental/Recoil/pull/148 was merged.

The cause seems to be a duplicate package.json, I have PR'd removing that here and can confirm locally that the issue is resolved

https://github.com/facebookexperimental/Recoil/pull/156

n3tr

comment created time in 6 days

PR opened facebookexperimental/Recoil

Remove duplicate package.json

This also seems to fix Jest not resolving the babelrc correctly.

+0 -51

0 comment

1 changed file

pr created time in 6 days

create barnchdustinsoftware/Recoil

branch : package-json

created branch time in 6 days

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

push eventdustinsoftware/Recoil

Dustin Masters

commit sha 072102b50096123c7b7cceb6c2e66ffb611b9bb9

Enable Github Actions

view details

David McCabe

commit sha 2f383bfac9098a8fac3670f0b49941b4c24f0a89

Merge pull request #88 from dustinsoftware/github-actions GitHub actions

view details

leushkin

commit sha ef37b340047233dc402ef2d3f4fe8faf46e6946a

fix(flow): Add flow configuration file, add flow and flow:restart scripts to package.json

view details

David McCabe

commit sha 9c8934059aa1890f60a2022f4ea0bcf9fec8c6f6

Merge pull request #121 from leushkin/flow-config fix(flow): Add flow configuration file

view details

Daniel Lo Nigro

commit sha e25da9d2c7328b7eda130c4ce91c49ce13a213f1

Fix badge in README

view details

Douglas Armstrong

commit sha c3773ea1ac646d24dd8712bb4d3e4fdbb9f8bf2c

Merge pull request #133 from Daniel15/patch-1 Fix badge URL in README

view details

Jacques Blom

commit sha ec371fd808ac2588bfb7915a891dd8be6db74dbf

Adds lint-staged (#109) * Adds lint-staged * Update package.json Co-authored-by: Jacques Blom <39128232+jacquesnf@users.noreply.github.com>

view details

mondaychen

commit sha f6fcbc4dc56eacfa0f3332f1a0e26b8dc7e422ee

Set up ShipIt again fbshipit-source-id: 1002160619

view details

mengdi

commit sha d56ec3c77c81e4b3947f36b1600290fdc808caed

fbshipit-source-id: f69fc319d20940b35be2b17e10430cf5d487583a

view details

mondaychen

commit sha 9fe7bb543a60cb93e15cc138c81d372419a51dfb

Fix sync issues (#141) Summary: - missing dot files - missing/broken scripts - bad oss-only format and import errors Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/141 Reviewed By: davidmccabe Differential Revision: D21705989 Pulled By: mondaychen fbshipit-source-id: 8b23cd2dbab4d7e28be0d0331050c37fd0bca5d3

view details

mondaychen

commit sha 4dbbb400aea044f4d62d991f7b4de82f247c0dc2

missing file when syncing from master (#147) Summary: Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/147 Reviewed By: drarmstr Differential Revision: D21708571 Pulled By: mondaychen fbshipit-source-id: bfc2b4165c501030e22d071e1e2d871d6e027194

view details

Mengdi "Monday" Chen

commit sha 5f4491a69b8d1e383e49ddae06a1d4f3ac14c8e2

Merge pull request #148 from facebookexperimental/sync-www Sync master with internal repo

view details

Dustin Masters

commit sha a2591ef7fd694404e8ec1e38ba786fa975faec91

Pack all JS files in dist folder

view details

push time in 6 days

pull request commentfacebookexperimental/Recoil

Pack all JS files in dist folder

FWIW there is a fair amount of discussion on #33 so on second thought, landing this sooner would unblock releasing the current master branch. cc @vjeux

dustinsoftware

comment created time in 6 days

pull request commentfacebookexperimental/Recoil

update rollup config and fix unresolved path

If there is shared internal state that has to be synced between Recoil and RecoilUtils, then yeah pulling this into a single bundle makes sense as a simple solution...

Rollup has pretty good support for exporting tree-shakable ES module bundles so if bundle size is the concern here I think that can be addressed. Eg. if downstream apps don't use the utils, they won't be included in the final bundle. Right now only a commonJS bundle is exported which IIRC will always be the full bundle size when compiled by downstream apps.

tony-go

comment created time in 6 days

pull request commentfacebookexperimental/Recoil

Pack all JS files in dist folder

#33 also addresses this; if that lands first this can be closed.

dustinsoftware

comment created time in 7 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 263789c5f46687b0cd19b9b96a3ac5865c7a9b3d

Fix a few edge cases around branch and tag handling

view details

push time in 9 days

pull request commentfacebookexperimental/Recoil

update rollup config and fix unresolved path

Cool! Yeah that approach sounds great.

On Thu, May 21, 2020 at 05:27, Jared Palmer notifications@github.com wrote:

Hey all, so I run into this a lot because of tsdx. NPM imports are relative to the position of package.json and not the main entry point. To get recoil/utils as the import you have 2 options.

  1. Copy package.json from the root into the dist as a postbuild step and publish from that directory, fix files accordingly.
  2. Keep package.json where it is, change files to ["dist", "utils.js"], make/copy an entry file ./utils.js as follows:

// ./utils.js'use strict'; if (process.env.NODE_ENV === 'production') { module.exports = require('./dist/utils.production.js');} else { module.exports = require('./dist/utils.development.js');}

You can add utils.js to .gitignore, or just leave it hard coded.

Now imports will work like you want:

import { RecoilRoot } from 'recoil'import { atomFamily } from 'recoil/utils'

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/facebookexperimental/Recoil/pull/33#issuecomment-632057887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHGCFSUVGIF4EXN4AZKBDTRSUMZHANCNFSM4NBZTVYQ .

tony-go

comment created time in 9 days

pull request commentfacebookexperimental/Recoil

Fix badge URL in README

Thanks for raining on my parade Daniel ;)

On Wed, May 20, 2020 at 22:23, Daniel Lo Nigro notifications@github.com wrote:

Show the status of the official build rather than @dustinsoftware https://github.com/dustinsoftware's, and make it link to the actions page rather than just showing the badge image on click.

You can view, comment on, or merge this pull request online at:

https://github.com/facebookexperimental/Recoil/pull/133 Commit Summary

  • Fix badge in README

File Changes

Patch Links:

  • https://github.com/facebookexperimental/Recoil/pull/133.patch
  • https://github.com/facebookexperimental/Recoil/pull/133.diff

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/facebookexperimental/Recoil/pull/133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHGCFR56FNPPH3SBZ356GTRSS3GNANCNFSM4NGRTZHQ .

Daniel15

comment created time in 10 days

startedyaakov-h/Notepad.Extensions.Logging

started time in 10 days

pull request commentfacebookexperimental/Recoil

update rollup config and fix unresolved path

I’m fairly sure node won’t resolve that, but you could try it.

On Wed, May 20, 2020 at 09:07, Tony Gorez notifications@github.com wrote:

@dustinsoftware https://github.com/dustinsoftware

What if we replace :

fs.copyFileSync('./src/npm/utils/index.js', './dist/utils/index.js');

by this :

fs.copyFileSync('./src/npm/utils/index.js', './dist/utils.js');

as utils.js will be at the dist root, we should get:

require('recoil/utils')

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/facebookexperimental/Recoil/pull/33#issuecomment-631572124, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHGCFSXHTUEUP4RAJQ44RLRSP54ZANCNFSM4NBZTVYQ .

tony-go

comment created time in 10 days

issue commentfacebookexperimental/Recoil

Typescript support

This issue is getting a bit off topic;

Keeping TS types in Definitely Typed seems like the right move for the project in its current state if it needs to keep using Flow.

RichardLindhout

comment created time in 10 days

pull request commentfacebookexperimental/Recoil

update rollup config and fix unresolved path

Verified by pulling down the artifact for this build and running from Node require('recoil/dist/utils')

That's probably good enough for this pass, we can iterate on a nicer import in the future if we need to.

tony-go

comment created time in 10 days

issue commentreactjs/React.NET

[reactnet-webpack] Nested routes have ReactDOM undefined due to wrong manifest publicPath

Nice catch, we can fix that....

On Tue, May 19, 2020 at 20:25, mattywong notifications@github.com wrote:

Thanks for filing a bug! To save time, if you're having trouble using the library, please check off the items you have tried. If you are just asking a question, skip right to the bottom. Please verify these steps before filing an issue, and check them off as you go

  • The relevant native JavascriptEngineSwitcher library packages are installed (such as JavaScriptEngineSwitcher.V8.Native.win-x64)
  • The VC++ 2017 runtime is installed
  • The value of SetUseReact and SetUseBabel is correct in ReactConfig.cs or Startup.cs
  • I've looked at the sample projects in this repo to verify that my app is configured correctly

I'm using these library versions:

  • ReactJS.NET:
  • JavaScriptEngineSwitcher:
  • react and react-dom: (N/A if using bundled react, or version number)
  • webpack: (N/A if using bundled react)
  • node: (N/A if using bundled react)

Runtime environment:

  • OS: (Mac, Windows, Linux flavor. Include 32-bit/64-bit and version)
  • .NET Framework or .NET Core Version:

Steps to reproduce

Follow quick start guide with reactnet-webpack template. Go to /comments/page-2, check console, ReactDOM is undefined.

This is due to the webpack config missing the publicPath in ManifestPlugin, without it the path of the scripts are relative to the current route and not the actual wwwroot, e.g

@ /comments/page-2,

<script src="dist/bundle.js"></script> // /comments/dist/bundle.js

see:

https://github.com/reactjs/React.NET/blob/master/src/React.Template/reactnet-webpack/webpack.config.js

adding

new ManifestPlugin({ ..., publicPath: "/dist/", // suffix "/" is necessary otherwise a server error is thrown ..., });

resolves this issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/reactjs/React.NET/issues/1112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHGCFUSDEFLDFOU3FQVSATRSNETPANCNFSM4NFRTELQ .

mattywong

comment created time in 11 days

pull request commentfacebookexperimental/Recoil

React native

Correct; this solution should require no configuration to work with either web or native projects.

I can keep the PascalCase names if that keeps it working with FB internal tooling.

dustinsoftware

comment created time in 11 days

Pull request review commentfacebookexperimental/Recoil

update rollup config and fix unresolved path

   "description": "Recoil - A React state management library for complex UIs",   "main": "dist/index.js",   "files": [-    "dist/recoil.js"+    "dist/index.js",

There are other files in dist that should be exported; try ‘dist/**/*.js’

You can confirm the result with ‘npm pack’ and inspecting the generated tar ball

tony-go

comment created time in 11 days

Pull request review commentfacebookexperimental/Recoil

React Native bundle

 export type {   RecoilValueReadOnly, } from './core/Recoil_RecoilValue'; +const {unstable_batchedUpdates} = require('./util/ReactBatchedUpdates');+const {setBatch} = require('./util/Recoil_batch');+setBatch(unstable_batchedUpdates);

I like that this is exported; future-proofs the library a bit. We should probably add a test for this once they are passing.

jacques-blom

comment created time in 11 days

Pull request review commentfacebookexperimental/Recoil

React Native bundle

+// Default to a dummy "batch" implementation that just runs the callback+function defaultNoopBatch(callback) {+  callback();

Is there a case where we would actually want to invoke the callback right away outside of a test context? Thinking this may hide bugs where the react-dom/react-native batching wasn't used by mistake....

We could throw an error here instead to surface the problem and make users provide their own callback => callback() function

jacques-blom

comment created time in 11 days

Pull request review commentfacebookexperimental/Recoil

React Native bundle

 'use strict';  if (process.env.NODE_ENV === 'production') {-  module.exports = require('./recoil.production.js');+  module.exports = require('./recoil.production');

This works; however resolution problems are harder to debug later if they go wrong :) For instance, this may resolve the browser version by mistake depending on how the react-native bundler is configured.

Can we stick with a more explicit approach as in #108? Or does that not work with the React Native bundler?

jacques-blom

comment created time in 11 days

Pull request review commentfacebookexperimental/Recoil

React Native bundle

 const config = mode => ({         if (source === 'ReactDOM') {           return {id: 'react-dom', external: true};         }+        if (source === 'ReactNative') {

I get that this is following prior art, but this seems like an artifact that we could remove unless there is a compelling reason to keep the PascalCase aliases.

jacques-blom

comment created time in 11 days

Pull request review commentfacebookexperimental/Recoil

React Native bundle

 import babel from '@rollup/plugin-babel'; import commonjs from '@rollup/plugin-commonjs'; import {terser} from 'rollup-plugin-terser'; -const config = mode => ({+const config = ({mode, target}) => ({   input: 'src/Recoil.js',   output: {-    file: `dist/recoil.${mode}.js`,+    file:+      target === 'web'+        ? `dist/recoil.${mode}.js`+        : `dist/recoil.${mode}.${target}.js`,     format: 'cjs',     exports: 'named',   },-  external: ['react', 'react-dom'],+  external: ['react', 'react-dom', 'react-native'],

react-native should probably not be resolved unless the target is native, likewise for react-dom and browser. (See the config in #108 for how to pull this off)

jacques-blom

comment created time in 11 days

Pull request review commentfacebookexperimental/Recoil

React Native bundle

 const config = mode => ({         if (source === 'ReactDOM') {           return {id: 'react-dom', external: true};         }+        if (source === 'ReactNative') {+          return {id: 'react-native', external: true};+        }         return null;       },     },-    nodeResolve(),+    nodeResolve({+      extensions: target === 'native' ? ['.native.js', '.js'] : undefined,

This seems error prone, if a .native.js file is missing or has a typo, the browser version would be resolved instead. Was there an issue you discovered with the rollup config proposed in #108?

jacques-blom

comment created time in 11 days

Pull request review commentfacebookexperimental/Recoil

React Native bundle

     "install-peers-cli": "^2.2.0",     "jest-cli": "^26.0.1",     "prettier": "^2.0.5",+    "react-native": "^0.62.2",

It should work fine to make react-dom as a devDependency for the test runner and leave out react-native entirely

jacques-blom

comment created time in 11 days

pull request commentfacebookexperimental/Recoil

React native

Hmm I see that there is a duplicate effort now in #114 .....

I'm probably not going to work on this any further until a maintainer weighs in on what the preferred approach is.

dustinsoftware

comment created time in 11 days

pull request commentfacebookexperimental/Recoil

Adds lint-staged

Lint-staged is awesome, this pr looks good to me...

jacques-blom

comment created time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 7da66cae080d7b61e00564a11599c83d03dd0092

Fix oversight in tag naming

view details

push time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha a45c6dd12217de76d7c6eb2f763d9ad17859e447

Delete dummy hotfix files

view details

push time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 312de7711dee9fc1eb373b870264e1b187eff19b

Remove create_tag flag Fallback logic exists already, if a CI environment tags a commit we don't need to.

view details

Dustin Masters

commit sha 1d8b04146e5ab39c66653c05528bd7ddf39973c3

Fail creating release if tag already exists

view details

Dustin Masters

commit sha 698d7926961fe929118598237ddde02dfde46dea

Merge pull request #19 from dustinsoftware/master Backmerge from master to develop

view details

push time in 11 days

PR opened dustinsoftware/gitflow-tools

Backmerge from master to develop

Backmerge

+18 -17

0 comment

2 changed files

pr created time in 11 days

delete branch dustinsoftware/gitflow-tools

delete branch : release-110

delete time in 11 days

created tagdustinsoftware/gitflow-tools

tagv110

created time in 11 days

create barnchdustinsoftware/gitflow-tools

branch : release-110

created branch time in 11 days

delete branch dustinsoftware/gitflow-tools

delete branch : release-110

delete time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 312de7711dee9fc1eb373b870264e1b187eff19b

Remove create_tag flag Fallback logic exists already, if a CI environment tags a commit we don't need to.

view details

Dustin Masters

commit sha 1d8b04146e5ab39c66653c05528bd7ddf39973c3

Fail creating release if tag already exists

view details

push time in 11 days

create barnchdustinsoftware/gitflow-tools

branch : release-110

created branch time in 11 days

create barnchdustinsoftware/gitflow-tools

branch : release-109

created branch time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 15b6cd844d244f5823fbd71456d1bd752ab2ddc4

108 hotfix

view details

Dustin Masters

commit sha 4e9339fac65e210a0bdb7d570221af6b165303d1

Merge pull request #18 from dustinsoftware/master Backmerge from master to develop

view details

push time in 11 days

PR opened dustinsoftware/gitflow-tools

Backmerge from master to develop

Backmerge

+0 -0

0 comment

1 changed file

pr created time in 11 days

delete branch dustinsoftware/gitflow-tools

delete branch : release-109

delete time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 15b6cd844d244f5823fbd71456d1bd752ab2ddc4

108 hotfix

view details

push time in 11 days

created tagdustinsoftware/gitflow-tools

tagv109

created time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 15b6cd844d244f5823fbd71456d1bd752ab2ddc4

108 hotfix

view details

push time in 11 days

create barnchdustinsoftware/gitflow-tools

branch : release-109

created branch time in 11 days

create barnchdustinsoftware/gitflow-tools

branch : release-108

created branch time in 11 days

delete branch dustinsoftware/gitflow-tools

delete branch : release-108

delete time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 9140be581b248bcd5d46e6b80505e8e5a1558273

Merge pull request #17 from dustinsoftware/master Backmerge from master to develop

view details

push time in 11 days

created tagdustinsoftware/gitflow-tools

tagv108

created time in 11 days

create barnchdustinsoftware/gitflow-tools

branch : release-108

created branch time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 69b85d061d4093783d020ca74cb7d96f4e838567

release 107 oops

view details

Dustin Masters

commit sha 9140be581b248bcd5d46e6b80505e8e5a1558273

Merge pull request #17 from dustinsoftware/master Backmerge from master to develop

view details

push time in 11 days

PR opened dustinsoftware/gitflow-tools

Backmerge from master to develop

Backmerge

+0 -0

0 comment

1 changed file

pr created time in 11 days

created tagdustinsoftware/gitflow-tools

tagv107

created time in 11 days

delete branch dustinsoftware/gitflow-tools

delete branch : release-107

delete time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha d1243c4d85edf5c9a638b71b5aa2382af04a1366

Implement -backmerge_branchname support

view details

Dustin Masters

commit sha e443b3e864a07b55c576369382df0da720fc9acf

Update readme

view details

Dustin Masters

commit sha 5ea88e231669f927bda8420df60e887c7983e990

Fix argument validation on older Powershell versions

view details

Dustin Masters

commit sha 6331d330d138bfb0e6698ba584e29bf7a2f40c5b

Fix ci

view details

Dustin Masters

commit sha 69b85d061d4093783d020ca74cb7d96f4e838567

release 107 oops

view details

push time in 11 days

push eventdustinsoftware/gitflow-tools

Dustin Masters

commit sha 69b85d061d4093783d020ca74cb7d96f4e838567

release 107 oops

view details

push time in 11 days

create barnchdustinsoftware/gitflow-tools

branch : release-107

created branch time in 11 days

starteddotnet/maui

started time in 11 days

PR opened facebookexperimental/Recoil

React native

Fixes #99

Disclaimer: stayed up late hacking this out, there are likely a few bugs.

+150 -60

0 comment

22 changed files

pr created time in 12 days

create barnchdustinsoftware/Recoil

branch : react-native

created branch time in 12 days

issue commentfacebookexperimental/Recoil

React Native Support

Rollup aliases/externals for stubbing out react-dom and react-native depending on build context

https://github.com/mobxjs/mobx-react/blob/1e8d6b5009377badcc5ab11ef8a605a071bb60e3/build-rollup.js#L29-L49

stephanoparaskeva

comment created time in 12 days

issue commentfacebookexperimental/Recoil

React Native Support

Prior art: https://github.com/mobxjs/mobx-react/blob/1e8d6b5009377badcc5ab11ef8a605a071bb60e3/src/index.js#L1-L10

stephanoparaskeva

comment created time in 12 days

issue closedfacebookexperimental/Recoil

Tests

Is the plan to use Flow as a test suite? I see many pre-existing tests, and flow-bin is a devDependency, but running yarn run flow produces an error about a missing .flowconfig.

closed time in 12 days

dustinsoftware

issue commentfacebookexperimental/Recoil

Tests

I think it makes sense to stick with Jest; closing now that #81 is merged.

We can get tests wired up via Github Actions once they are all passing.

dustinsoftware

comment created time in 12 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha 3bd6eaa1efef8295dae26ee0ee392838985352f8

Disable variable name mangling in terser This fixes an issue that was breaking a fresh create-react-app from working, due to CRA's own minfiication step running only in production mode.

view details

Jacques Blom

commit sha 6c7733a941d0173902f69f08db09d8dd713cc58e

Adds Prettier and script

view details

Jacques Blom

commit sha 8307a1505fda17654f8c8976703d160c21c1056a

Runs format script

view details

Jacques Blom

commit sha 4aa5f9fcd4636ba2ff6360a2d6ae219f9cc56be7

Updates glob pattern

view details

Jacques Blom

commit sha e6165d12ba3438951d6e4591d3cefba8e9f6615d

Runs prettier

view details

Jacques Blom

commit sha 61f16271a342d19fe53ccb5749fb239d14624c00

Merge branch 'prettier' of github.com:jacques-blom/Recoil into prettier

view details

Jacques Blom

commit sha f68a609a30db3496bb7470c434c060a71064702f

Adds hint to docs to run prettier

view details

Christopher Chedeau

commit sha ca3aae10ae290a905b1ad2b5870971113fc78bba

Fix more tests This is the current output after this PR: https://gist.github.com/vjeux/0050ee599a30c12e922e181c73518f2e Test Suites: 8 failed, 12 passed, 20 total Tests: 43 failed, 110 passed, 153 total I have no idea how the tests are working on www right now...

view details

Douglas Armstrong

commit sha 6e30a71e9330fd9329b5c3fd53485750e1bbedfe

Merge pull request #86 from vjeux/fix_some_tests Fix more tests

view details

mitermayer

commit sha bd2a614f2b14f9148e6f0bf69e896cb30717390b

nit/fixing-misspelling - Fixing minor misspelling - Fixing minor misspelling

view details

Douglas Armstrong

commit sha 532a0f17c160eb9dd38a94515a43ffcc84408d5e

Merge pull request #89 from mitermayer/nit/fixing-misspelling nit/fixing-misspelling - Fixing minor misspelling

view details

Daniel Hong

commit sha 44455dada1d144adcc0069440015307e0cd3866b

Fix minor misspelling Changes: compoment -> component

view details

Jacques Blom

commit sha d20a28cef260604dd3ca173b9c63fc320ff415c3

Ignores oss-only functions

view details

Jacques Blom

commit sha 91a0b7c4ae567ce01a55e5505e99ba33d36193c2

Removes JSX from overrides

view details

Jacques Blom

commit sha 9e8a3762e39b9e8360e893f03b52a4f54c59038f

Merge branch 'master' into prettier

view details

Daniel Hong

commit sha 5e054c84c3e9b514a5a84c006042eb98c7306931

Remove formatting changes from Prettier Applied : Recoil_Link.react.js, Recoil_Hooks.js

view details

David McCabe

commit sha 1cea9f7b24d7f4433cc4c2a189f367db9c6ae5ff

Merge pull request #83 from jacques-blom/prettier Prettier

view details

Douglas Armstrong

commit sha 1e6e077de77e35dadf28b1a452980f2cb76620a5

Merge pull request #93 from hongjidev/fix-typo-component Fix minor misspelling

view details

David McCabe

commit sha 6927bbda5e5eb9468e9268a2d1cbbd4b0aa09cfa

Merge pull request #69 from dustinsoftware/disable-rollup-name-mangling Disable variable name mangling in terser

view details

Dustin Masters

commit sha 3a923b2e0c15f0998538529167c3bcdf52d4ea39

Pack all JS files in dist folder

view details

push time in 12 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha 3bd6eaa1efef8295dae26ee0ee392838985352f8

Disable variable name mangling in terser This fixes an issue that was breaking a fresh create-react-app from working, due to CRA's own minfiication step running only in production mode.

view details

Jacques Blom

commit sha 6c7733a941d0173902f69f08db09d8dd713cc58e

Adds Prettier and script

view details

Jacques Blom

commit sha 8307a1505fda17654f8c8976703d160c21c1056a

Runs format script

view details

Jacques Blom

commit sha 4aa5f9fcd4636ba2ff6360a2d6ae219f9cc56be7

Updates glob pattern

view details

Jacques Blom

commit sha e6165d12ba3438951d6e4591d3cefba8e9f6615d

Runs prettier

view details

Jacques Blom

commit sha 61f16271a342d19fe53ccb5749fb239d14624c00

Merge branch 'prettier' of github.com:jacques-blom/Recoil into prettier

view details

Jacques Blom

commit sha f68a609a30db3496bb7470c434c060a71064702f

Adds hint to docs to run prettier

view details

Christopher Chedeau

commit sha ca3aae10ae290a905b1ad2b5870971113fc78bba

Fix more tests This is the current output after this PR: https://gist.github.com/vjeux/0050ee599a30c12e922e181c73518f2e Test Suites: 8 failed, 12 passed, 20 total Tests: 43 failed, 110 passed, 153 total I have no idea how the tests are working on www right now...

view details

Douglas Armstrong

commit sha 6e30a71e9330fd9329b5c3fd53485750e1bbedfe

Merge pull request #86 from vjeux/fix_some_tests Fix more tests

view details

mitermayer

commit sha bd2a614f2b14f9148e6f0bf69e896cb30717390b

nit/fixing-misspelling - Fixing minor misspelling - Fixing minor misspelling

view details

Douglas Armstrong

commit sha 532a0f17c160eb9dd38a94515a43ffcc84408d5e

Merge pull request #89 from mitermayer/nit/fixing-misspelling nit/fixing-misspelling - Fixing minor misspelling

view details

Daniel Hong

commit sha 44455dada1d144adcc0069440015307e0cd3866b

Fix minor misspelling Changes: compoment -> component

view details

Jacques Blom

commit sha d20a28cef260604dd3ca173b9c63fc320ff415c3

Ignores oss-only functions

view details

Jacques Blom

commit sha 91a0b7c4ae567ce01a55e5505e99ba33d36193c2

Removes JSX from overrides

view details

Jacques Blom

commit sha 9e8a3762e39b9e8360e893f03b52a4f54c59038f

Merge branch 'master' into prettier

view details

Daniel Hong

commit sha 5e054c84c3e9b514a5a84c006042eb98c7306931

Remove formatting changes from Prettier Applied : Recoil_Link.react.js, Recoil_Hooks.js

view details

David McCabe

commit sha 1cea9f7b24d7f4433cc4c2a189f367db9c6ae5ff

Merge pull request #83 from jacques-blom/prettier Prettier

view details

Douglas Armstrong

commit sha 1e6e077de77e35dadf28b1a452980f2cb76620a5

Merge pull request #93 from hongjidev/fix-typo-component Fix minor misspelling

view details

David McCabe

commit sha 6927bbda5e5eb9468e9268a2d1cbbd4b0aa09cfa

Merge pull request #69 from dustinsoftware/disable-rollup-name-mangling Disable variable name mangling in terser

view details

Dustin Masters

commit sha 072102b50096123c7b7cceb6c2e66ffb611b9bb9

Enable Github Actions

view details

push time in 12 days

PR opened facebookexperimental/Recoil

Pack all JS files in dist folder

This was an oversight from #67

+1 -3

0 comment

1 changed file

pr created time in 12 days

create barnchdustinsoftware/Recoil

branch : fix-dist-files

created branch time in 12 days

issue commentfacebookexperimental/Recoil

React Native Support

I can look at the rollup config for this within the next day or two and send a PR for the common case proposed in this thread

stephanoparaskeva

comment created time in 12 days

PR opened dustinsoftware/Recoil

Test PR.
+3 -0

0 comment

1 changed file

pr created time in 13 days

create barnchdustinsoftware/Recoil

branch : dustinsoftware-patch-1

created branch time in 13 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha 0ed9366af14a73a75859875abccf3dbc104ecc1d

Enable Github Actions

view details

Dustin Masters

commit sha 3cbcff02682893ec6c0d8dc8b164d567197818f5

Pack all JS files in dist folder

view details

push time in 13 days

PR opened facebookexperimental/Recoil

GitHub actions

Fixes #66

After tests are passing, add yarn test to the end of nodejs.yml.

In testing this I noticed an oversight in #67 where during yarn publish a few files were missing from the dist folder. This is addressed in this PR.

image

image

+39 -1

0 comment

3 changed files

pr created time in 13 days

create barnchdustinsoftware/Recoil

branch : github-actions

created branch time in 13 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha 338b1302508b632e3f4e43ff062f440c6fffb60c

Pack all JS files in dist folder

view details

push time in 13 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha 4ceab35f396609217951d3d5f8aa56c88d320200

Run yarn again

view details

push time in 13 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha cc9752416562ece6fc8a1ef0a4a1fc7058e0dc5b

Use v2 artifact

view details

push time in 13 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha 71491928c96e2afc1108bac0a2640f53e2a95c84

Try using npm?

view details

push time in 13 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha ebaf345962e87bcbe05bc637c89f4701f6be5c73

Add package artifact

view details

push time in 13 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha a5b5f8611454f4f7a0ed618982b2b8a009772dc4

Add status badge to readme

view details

push time in 13 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha c05f57e1d8f7bb3724f134776d9ce7938ca90e8e

Enable build on macOS, Windows, Ubuntu

view details

push time in 13 days

push eventdustinsoftware/Recoil

Dustin Masters

commit sha 7e56477b57d95e0eacce3501d21a25eacdaa114f

Enable Github Actions

view details

push time in 13 days

more