profile
viewpoint
David Symonds dsymonds Google Sydney, Australia

dsymonds/gotoc 113

Protocol Buffer compiler written in Go

dsymonds/marcopolo 18

Context aware computing for Mac OS X

dsymonds/fixhub 16

Fixhub runs golint on a GitHub repository.

dsymonds/goembed 12

goembed is a tool for embedding data in a Go program.

dsymonds/prbot 10

prbot: Pull Request robot

dsymonds/unifi 8

Go package for interacting with UniFi hardware

dsymonds/talks 5

talks

dsymonds/gitutil 3

Pure Go access to Git information.

dsymonds/gmail 3

A package for interacting with Gmail via IMAP, authenticated with OAuth2.

dsymonds/objective-git 3

Git Implementation in Objective-C

issue commentgoogleapis/google-cloud-go

spannertest: Support read timestamps

What did you make of my simplified proposal, namely that of returning the timestamp of the last commit? That wouldn't be a lot of work.

odsod

comment created time in 30 minutes

issue commentgoogleapis/google-cloud-go

spannertest: Support read timestamps

This might be tricky to support correctly, but might be plausible to support enough to be useful. Can you explain in a bit more detail how you'd use the read timestamp? Is it just to bust some sort of cache or state for paging, so you'd just re-query if previous pages came from an older read timestamp?

I could imagine simply returning the last issued commit timestamp on any reads, which would get bumped on any mutation. Would that suffice?

odsod

comment created time in a day

issue commentgoogleapis/google-cloud-go

spannertest: Support CommitTimestamp

The fix for the latter is now submitted as ee18a51, so update to that if you are depending on commit timestamps being monotonic.

odsod

comment created time in 3 days

push eventdsymonds/gocloud

Olav Loite

commit sha 107ad13493dd0641d0cd1e133cb1317224c975a3

spanner: unflake TestSessionNotFoundOnPrepareSession Increase timeout to prevent flaky failures. Also removes a deprecated comment that no longer applies. Fixes #1736. Change-Id: I27e664ca079d353c218fd92197ee0e3bf78af371 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51730 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Hengfeng Li

commit sha 1bd4ddf7f1a7015b0b749d30785833ca3a86a1e2

spanner: release v1.2.1 Change-Id: I1b805e3608318bfcc291a59924668ef7b62f14b8 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/52034 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

David Symonds

commit sha 77aef8da30fc278063e408a50d031a06c97fb75b

spanner/spannertest: enforce commit timestamp selection, transaction exclusion The requirements for commit timestamps are such that this simplified simulation needs to enforce only one read-write transaction operating at a time. Updates #1774. Change-Id: I8c1d0349fdc7d08f86f0eafceb703eb82f7b5b08

view details

David Symonds

commit sha 6ac634823d27bede596738f5c9c3c6b41d48e185

spanner/spansql: fix InlineComment It never worked unless the Start/End offsets were zeroed out, which was true for tests but never true for real situations. Also fix the End.Offset of comments, which were inadvertently set relative to the Start.Offset rather than the start of the file. Change-Id: Ib47daba822d1df8a6c76ca58ad638b83d61fa561

view details

David Symonds

commit sha e79abc347a8c6fbd588dc6f8883abc552909f912

spanner/spansql: don't coalesce adjacent comments with intervening tokens Comments on adjacent lines should only form a single comment block if there aren't other tokens in between. This prevents inline comments from being joined in a situation such as CREATE TABLE Foo ( F1 INT64, -- some comment F2 INT64, -- another comment ) PRIMARY KEY (F1); This actually simplifies the parsing by doing the comment collapsing in skipSpace instead of trying to reverse-engineer it after the parse completes. Change-Id: I84a46adf8f848f572016e0a9ba70118cb9d67ccc

view details

David Symonds

commit sha 1140bd11e7f91c94939076ee1ab1d917f49ffa1a

spanner/spannertest: evaluate add, subtract, multiply divide arithmetic expressions Change-Id: Ia09f3c48bf28d1532d12ab6c297f72f4f623e82e

view details

David Symonds

commit sha c0de881b0bba40ddd1b212ffb2f948070bf18c36

spanner/spannertest: fix handling of descending primary keys This adjusts row comparison to account for primary keys marked as descending, and the rest falls out: rows are stored in the correct order, and searching and ranges behave correctly. Change-Id: Iaabdaf9f4f7d57cc7820e4fcee05b3dd2b4b9c3a

view details

push time in 8 days

push eventdsymonds/gocloud

David Symonds

commit sha c386b408b91937b2bb9c3328f735723c03bf4efc

spanner/spansql: don't coalesce adjacent comments with intervening tokens Comments on adjacent lines should only form a single comment block if there aren't other tokens in between. This prevents inline comments from being joined in a situation such as CREATE TABLE Foo ( F1 INT64, -- some comment F2 INT64, -- another comment ) PRIMARY KEY (F1); This actually simplifies the parsing by doing the comment collapsing in skipSpace instead of trying to reverse-engineer it after the parse completes. Change-Id: I84a46adf8f848f572016e0a9ba70118cb9d67ccc

view details

push time in 8 days

issue closedgoogle/licensecheck

Support for bespoke open source licenses

I use a bespoke open source license for all of my projects, e.g.

  • https://github.com/dappui/core/blob/master/UNLICENSE.md

Unfortunately pkg.go.dev refuses to display documentation since it's not on the pre-approved list of licenses. Is the recommended solution to host the documentation ourselves or to add the license to licensecheck?

closed time in 8 days

tav

issue commentgoogle/licensecheck

Support for bespoke open source licenses

You'd have to ask the pkg.go.dev folk what the recommended solution is. This package is only about license detection, not about policies for acting on those licenses.

tav

comment created time in 8 days

push eventdsymonds/gocloud

David Symonds

commit sha c386b408b91937b2bb9c3328f735723c03bf4efc

spanner/spansql: don't coalesce adjacent comments with intervening tokens Comments on adjacent lines should only form a single comment block if there aren't other tokens in between. This prevents inline comments from being joined in a situation such as CREATE TABLE Foo ( F1 INT64, -- some comment F2 INT64, -- another comment ) PRIMARY KEY (F1); This actually simplifies the parsing by doing the comment collapsing in skipSpace instead of trying to reverse-engineer it after the parse completes. Change-Id: I84a46adf8f848f572016e0a9ba70118cb9d67ccc

view details

push time in 9 days

push eventdsymonds/gocloud

Chris Broadfoot

commit sha d96ccb2ba7586bb79a416471882d347754a78ce5

all: release v0.53.0, datastore/v1.1.0, bigtable/v1.3.0 This commit will be tagged: - v0.5.30 - datastore/v1.1.0 - bigtable/v1.3.0 Change-Id: Iece28786a91e92a6d68b96a3e04c0f2cd66742b9 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51874 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com> Reviewed-by: Seth Hollyman <shollyman@google.com>

view details

Noah

commit sha 281e3bbe79dab45acead10e8f1193030bad19179

asset: remove invalid v1beta1 client pkg Use cloud.google.com/go/asset/apiv1beta1 instead Change-Id: Icc6463d696c8ec4ff99091c2fed10d70a3492dea Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51930 Reviewed-by: Chris Broadfoot <cbro@google.com>

view details

Leonard Hecker

commit sha 2875e8218028118430b05b8a4bff54ff210f47e7

spanner: Fixed session leakage for ApplyAtLeastOnce Previously session handles where leaked whenever Commit() returned a non-abort, non-session-not-found error, due to a missing recycle() call. Fixes #1776. Change-Id: I45839d3258f96bf6d1dfc15c35e6e146117d70f1 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51890 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Shanika Kuruppu <skuruppu@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

Alex Hong

commit sha e89285337e9500bd726ae990b68d349c9aabd4b0

storage: switch to use live service for benchwrapper Change-Id: I3e1d34d21469e1b2b775ed703a3eb03caf589fdc Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51993 Reviewed-by: Seth Hollyman <shollyman@google.com>

view details

Olav Loite

commit sha 6182a19bb12861f89e3fd69516bbfb815f0bbeba

spanner: Add tests for ApplyAtLeastOnce The Apply and ApplyAtLeastOnce methods contained a possible session leak when a non-retryable error occurred. These tests ensure that such a session leak cannot happen again without triggering a test failure. Updates #1776. Change-Id: Ie90a396fe30aefe87b537710292aba8b2ade5219 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51950 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Shanika Kuruppu <skuruppu@google.com>

view details

David Symonds

commit sha d4674f1362604d5f0f3891fdc4f3a00295ab0d5d

spanner/spannertest: support reading by key ranges Also deduplicate returned rows to match Cloud Spanner's documented behaviour. Fixes #1779. Change-Id: I1ae3fa84fbdb238a3eb476f98849ea154bc1f53d Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51970 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

David Symonds

commit sha 0863b3a6f90ef98a727b6199817e875ba4247634

spanner/spansql: record parse locations for column_def productions This makes it useful for code generators or other tools to extract per-column comments. Change-Id: Ib61a1965ac736936c09b59e8d5651c212b467759 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51971 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

David Symonds

commit sha 588a9ef7ec4cab363486a85cbae7c1bf0949e8b9

spanner/spansql: parse arithmetic operators Also fix precedence of parsing parenthesised expressions and function calls. This doesn't implement the evaluation of these expressions in spannertest. Change-Id: I53402b290aff3db467945c861de2d43d90fef2b8 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/52030 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

David Symonds

commit sha a52385fb2ad3bb7c55789c072685df5ca8462300

spanner/spannertest: enforce commit timestamp selection, transaction exclusion The requirements for commit timestamps are such that this simplified simulation needs to enforce only one read-write transaction operating at a time. Updates #1774. Change-Id: I8c1d0349fdc7d08f86f0eafceb703eb82f7b5b08

view details

David Symonds

commit sha b70a611d4edc10b39bf6a3e08258b3b1bf59b93e

spanner/spansql: fix InlineComment It never worked unless the Start/End offsets were zeroed out, which was true for tests but never true for real situations. Also fix the End.Offset of comments, which were inadvertently set relative to the Start.Offset rather than the start of the file. Change-Id: Ib47daba822d1df8a6c76ca58ad638b83d61fa561

view details

push time in 9 days

push eventdsymonds/gocloud

David Symonds

commit sha b70a611d4edc10b39bf6a3e08258b3b1bf59b93e

spanner/spansql: fix InlineComment It never worked unless the Start/End offsets were zeroed out, which was true for tests but never true for real situations. Also fix the End.Offset of comments, which were inadvertently set relative to the Start.Offset rather than the start of the file. Change-Id: Ib47daba822d1df8a6c76ca58ad638b83d61fa561

view details

push time in 9 days

push eventdsymonds/gocloud

Alex Hong

commit sha e89285337e9500bd726ae990b68d349c9aabd4b0

storage: switch to use live service for benchwrapper Change-Id: I3e1d34d21469e1b2b775ed703a3eb03caf589fdc Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51993 Reviewed-by: Seth Hollyman <shollyman@google.com>

view details

Olav Loite

commit sha 6182a19bb12861f89e3fd69516bbfb815f0bbeba

spanner: Add tests for ApplyAtLeastOnce The Apply and ApplyAtLeastOnce methods contained a possible session leak when a non-retryable error occurred. These tests ensure that such a session leak cannot happen again without triggering a test failure. Updates #1776. Change-Id: Ie90a396fe30aefe87b537710292aba8b2ade5219 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51950 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Shanika Kuruppu <skuruppu@google.com>

view details

David Symonds

commit sha d4674f1362604d5f0f3891fdc4f3a00295ab0d5d

spanner/spannertest: support reading by key ranges Also deduplicate returned rows to match Cloud Spanner's documented behaviour. Fixes #1779. Change-Id: I1ae3fa84fbdb238a3eb476f98849ea154bc1f53d Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51970 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

David Symonds

commit sha 0863b3a6f90ef98a727b6199817e875ba4247634

spanner/spansql: record parse locations for column_def productions This makes it useful for code generators or other tools to extract per-column comments. Change-Id: Ib61a1965ac736936c09b59e8d5651c212b467759 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51971 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

David Symonds

commit sha 588a9ef7ec4cab363486a85cbae7c1bf0949e8b9

spanner/spansql: parse arithmetic operators Also fix precedence of parsing parenthesised expressions and function calls. This doesn't implement the evaluation of these expressions in spannertest. Change-Id: I53402b290aff3db467945c861de2d43d90fef2b8 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/52030 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

David Symonds

commit sha a52385fb2ad3bb7c55789c072685df5ca8462300

spanner/spannertest: enforce commit timestamp selection, transaction exclusion The requirements for commit timestamps are such that this simplified simulation needs to enforce only one read-write transaction operating at a time. Updates #1774. Change-Id: I8c1d0349fdc7d08f86f0eafceb703eb82f7b5b08

view details

push time in 9 days

push eventdsymonds/gocloud

Tyler Bui-Palsulich

commit sha 50496d98cafd677e9759796804d3b0f1931a2f74

all: delete .repo-metadata.json files, add internal README Fixes #1758. Change-Id: Ib522ad8af4a31a0db63e4c851d7b3ca4596142bd Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51090 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Noah Dietz <ndietz@google.com>

view details

David Symonds

commit sha b954d44683796b109fc2ac43dac541838ed1b5fc

spanner/spansql: preserve filename, token position information during parse This is useful for tools built on top of spansql to be able to construct cross-references and similar. It is also a necessary condition for tools such as a formatter. This necessitates some backward incompatible changes to spansql, but they are simple to track. In particular, ParseDDL takes a filename argument, and a bunch of the AST types are now pointers instead of values. This has no impact on users of spannertest, only on direct users of the spansql package. Change-Id: Ic21e83879cdb1da8ac04692a5198e311383ca7a2 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50850 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

Hengfeng Li

commit sha 6482125bfc0d0dbfb1a81393f19c5b64c7952d05

spanner: skip TestIntegration_TransactionRunner test for the emulator The TransactionRunner test is testing the WoundWait algorithm of Cloud Spanner. Unfortunately, that is not supported within Emulator. Change-Id: I6fd5d0509935917b72378274afa31911039bce8b Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51050 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Shanika Kuruppu <skuruppu@google.com>

view details

David Symonds

commit sha 555bbfec440f0d88f933ca101cddcbe29f6f8349

spanner/spannertest: update signature of Server.UpdateDDL This was an oversight in the previous change. The natural type for spansql.DDL is now the pointer type (it is what is returned by ParseDDL), so functions accepting that type should match. Change-Id: I5a4f15df9d2963fd227fa9d203a5fd662a1e7d95 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51111 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

Chris Cotter

commit sha c7b88019aca2abf4e3f839397e3fde96c1507c0f

storage: fix default scopes for client The option WithScopes was not being applied correctly, such that the client had ScopeFullControl regardless of what the user passed in. This fixes the way the default is applied and adds an integration test to ensure that user-provided scope is respected. Fixes #1756 Change-Id: Ibeb5fc3d36eea8befc8faec33a72410cca6328b7 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51130 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Frank Natividad <franknatividad@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Eli Bendersky

commit sha 4a196869d0c34b98698dc7886bb9357b29b2790f

storage: fix some issues identified by staticcheck - bucket: complaint about explicit comparison to bool literals. Restructured the switch to an if/else chain. - bucket_test/storage: replaced use of deprecated constructor by the recommended replacement. - integration_test: seems like a genuine bug where a "return" is ommitted and no error is returned when it should be. With these changes staticcheck passes cleanly within the storage module. Change-Id: I090e8345ccbff66e632855802602251d26e217e5 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51030 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

jqll

commit sha bad0644c7a354b4f7c0ad511d7f7f1ef40f5bb6e

profiler: remove symbolization Go runtime symbolizes all profiles since Go 1.10. This repo officially dropped support for Go versions earlier than Go1.11. Extra symbolization can be removed. Fixes #1761 Tested: Ran busybench.go with Go 1.11, Go 1.12 and Go 1.13. All profile types are symbolized with all these versions. Change-Id: Ifa094f9f4f80404a923d368c73a9a87f98cc0bd5 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51150 Reviewed-by: Alexey Alexandrov <aalexand@google.com>

view details

Tyler Bui-Palsulich

commit sha bd1e6ab18e7f5395341036990f70dd0e0fc6db76

internal: change metadata to a map with package keys I also print the JSON with indentation to make diffs easier to read. Fixes #1764 Change-Id: Ief6877b2a1890b16ebc984f16baea271520d00bb Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51172 Reviewed-by: Noah Dietz <ndietz@google.com> Reviewed-by: David Supplee <dsupplee@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Chris Cotter

commit sha 30f6efe631f7b8dabaeaff1468824f55799384ea

storage: skip TestIntegration_RequesterPays This test has been flaking frequently; there is an issue open to fix. Updates #1753 Change-Id: I6210b67a154ea77085003846e04f7e36c28b07cc Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51210 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Noah

commit sha f9111a9a64ba53ea2c1fa32c0c2557d109e84967

asset: move v1beta1 & v1p2beta1 to microgen Note: this change generates a breaking change to v1p2beta1 as requested by the API team. Fix asset/apiv1p2beta1/mock_test.go for breaking change. Evaluation diff: https://code-review.googlesource.com/c/gocloud/+/51171 Change-Id: I19448c0bf329dd0cd8d6a354768a75fc6fbf40a6 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51190 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Tyler Bui-Palsulich

commit sha 9945411ca8ba6bb45338a4e1fd8ced690b7a58aa

internal/kokoro: run staticcheck on storage Change-Id: I736a22423a97b1748d94bb047a6a8e8e58b75f28 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51170 Reviewed-by: Eli Bendersky <eliben@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

Noah

commit sha 4466dc12d28517002da0e8928f324496e38cbaa5

monitoring: migrate to microgen Evaluation diff: https://code-review.googlesource.com/c/gocloud/+/51192 Change-Id: I18878615440c917d32b73c7ae0add6974ee79d42 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51193 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Noah

commit sha ae96aa22230a1f429d6fa38edc1d4f2cfd35d5e9

vision: v1p1beta1 migrate to microgen Evaluation diff: https://code-review.googlesource.com/c/gocloud/+/51270 Change-Id: I7fc4d4a4b36c7f19a24a262868625f252615b877 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51271 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Seth Hollyman <shollyman@google.com>

view details

IlyaFaer

commit sha 1eb0d529b77512b248a3d0f239f83e1ef8fa1162

storage: fix TestIndefiniteRetries flaky Test server treated */x content ranges as an end of object uploading. Fixes #1641 Change-Id: I8c94ce8a8b57b804a4ceef6ad1d1909a9a301c27 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51070 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

Masahiro Furudate

commit sha 115cfad1a8dd04bcad2f96be6ff4302d31c6210c

datastore: fix example comment Change-Id: Ifcf5a4ce7a2642c2fda8ffbc2ee1ad1be722252c Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51310 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Broadfoot <cbro@google.com>

view details

Alex Hong

commit sha 62ed622ec548ed8d1837309fe1661913ec42679d

pubsub: make DeliveryAttempt field nil when dead lettering is disabled. Change DeliveryAttempt from an int field to an optional.Int that is nil when the associated subscription does not have dead lettering enabled. This is a backwards incompatible change, but is allowed since the field has not yet been marked as stable. Fixes #1762. Change-Id: I0ec70ecbecd91888bb1ebecb30c7ed53f3c91b06 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51151 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Chris Broadfoot

commit sha 790001b314b38ba1fb200d11f15bc6e20685762d

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genmgr will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/297 Change-Id: Iab002e26a8fe2dac05ab1f9806397a95eccde5f1 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51331 Reviewed-by: Alex Hong <hongalex@google.com> Reviewed-by: Noah Dietz <ndietz@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Chris Broadfoot

commit sha bb68fe553ba39e9f40720c4d8cca86249bb108a0

internal/gapicgen: simplify genbot, add more logging * Simplified Dockerfile for genbot * Added more logging to generator * Fixed a couple typos * Revved deps Change-Id: I222e01f5764939b3ddd1d8f29a448733f8192912 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51370 Reviewed-by: Seth Hollyman <shollyman@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Noah Dietz <ndietz@google.com>

view details

Yoshi Automation Bot

commit sha 272a39df1ac083f59933b86122b0f715b111e9af

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genmgr will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/298 Change-Id: I66000804893a635fa609c0e6801c7d5aba710e2a Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51394 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Chris Cotter

commit sha 0f9dd32f810d414b41934a44668ed1e65f4afcce

pubsub: skip TestEndToEnd_Dupes This test is flaking currently. Updates #1752 Change-Id: Idd55ecf3a13f590be7c163ab1a073cef2245bc11 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51430 Reviewed-by: Alex Hong <hongalex@google.com>

view details

push time in 9 days

push eventdsymonds/gocloud

Chris Broadfoot

commit sha d96ccb2ba7586bb79a416471882d347754a78ce5

all: release v0.53.0, datastore/v1.1.0, bigtable/v1.3.0 This commit will be tagged: - v0.5.30 - datastore/v1.1.0 - bigtable/v1.3.0 Change-Id: Iece28786a91e92a6d68b96a3e04c0f2cd66742b9 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51874 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com> Reviewed-by: Seth Hollyman <shollyman@google.com>

view details

Noah

commit sha 281e3bbe79dab45acead10e8f1193030bad19179

asset: remove invalid v1beta1 client pkg Use cloud.google.com/go/asset/apiv1beta1 instead Change-Id: Icc6463d696c8ec4ff99091c2fed10d70a3492dea Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51930 Reviewed-by: Chris Broadfoot <cbro@google.com>

view details

Leonard Hecker

commit sha 2875e8218028118430b05b8a4bff54ff210f47e7

spanner: Fixed session leakage for ApplyAtLeastOnce Previously session handles where leaked whenever Commit() returned a non-abort, non-session-not-found error, due to a missing recycle() call. Fixes #1776. Change-Id: I45839d3258f96bf6d1dfc15c35e6e146117d70f1 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51890 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Shanika Kuruppu <skuruppu@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

David Symonds

commit sha c21c864a9c208e9ad7afe663b942b16d7ee2e015

spanner/spannertest: enforce commit timestamp selection, transaction exclusion The requirements for commit timestamps are such that this simplified simulation needs to enforce only one read-write transaction operating at a time. Updates #1774. Change-Id: I8c1d0349fdc7d08f86f0eafceb703eb82f7b5b08

view details

push time in 12 days

issue commentgoogleapis/google-cloud-go

spannertest: Support reading with ranges

https://code-review.googlesource.com/c/gocloud/+/51970

odsod

comment created time in 12 days

push eventdsymonds/terraform-provider-kubernetes

John Houston

commit sha 64c66f7634de8ca27d79fcda6b7d058ffaec460c

Add support for startup_probe (#739) * Add startupProbe to container spec * Update docs for daemonset, pod, deployment to include startup_probe * Add test helper function for skipping cluster versions * Add acceptance test for startup_probe * Update docs with feature gate link * Remove superfluous import alias * Fix daemonset docs * Fix whitespace in pod test

view details

Heechul Ryu

commit sha f2dd96faa62d8791d1d8e07fe4aa2252a71bf7a7

Add `load_config_file = false` to static configurations (#750) without these the provider will keep trying loading irrelevant local file

view details

Rudi C

commit sha 66f96024dc2c5833cfedc80a48276f6ed8c483ea

Allow 3s age gap between serviceaccount and secret (#748) Importing service accounts isn't always working on EKS clusters, which sometimes see secrets created more than one second after the service account, as reported in https://github.com/terraform-providers/terraform-provider-kubernetes/pull/377#issuecomment-540126765 and https://github.com/terraform-providers/terraform-provider-kubernetes/issues/268#issuecomment-578469711 With some fields removed for clarity: ``` { "kind": "ServiceAccount", "metadata": { "name": "coredns", "uid": "e2885307-37d7-11ea-9db3-1211528e452b", "resourceVersion": "201", "creationTimestamp": "2020-01-15T20:44:54Z", }, "secrets": [ { "name": "coredns-token-8tdpj" } ] } { "kind": "Secret", "metadata": { "name": "coredns-token-8tdpj", "resourceVersion": "196", "creationTimestamp": "2020-01-15T20:44:56Z", "annotations": { "kubernetes.io/service-account.name": "coredns", "kubernetes.io/service-account.uid": "e2885307-37d7-11ea-9db3-1211528e452b" } }, "type": "kubernetes.io/service-account-token" } ``` It's not clear what could be causing this. In our case, the cluster was brand new at the time the account was created, as can be seen in the relatively low resourceVersions. Maybe it's load, maybe it's clock drift between API servers (where creationTimestamp is injected, AFAIK). No matter the cause, this is a real problem and it's stopping imports. This is the simplest fix. A more comprehensive one could also double check that the annotations for SA name and the UID on the secret match with the account's. If more than one secret matches all criteria, perhaps the oldest one could be picked. But that's all better addressed separately.

view details

Patrick Decat

commit sha ae969a7941e08095454f1cd2603055257b7eb98f

Refactor kubernetes client config initialization and fix in-cluster config (#690) * Revert "Support in-cluster configuration with service accounts (#497)" This reverts commit e8360394f5d414f7eaf029de3ebed4bd8261249d. * Fix in-cluster config * Fix in-cluster config * Add in-cluster and cross cluster examples * Update in-cluster example * Fix passing bare IP addresses in provider's host field * Fix in-cluster and cross-cluster examples when not using custom builds * Replicate what defaultServerUrlFor() does with config but for overrides to support both HTTP and HTTPS when a bare IP address is passed into the host provider field * Log when selecting to load the client config from file Co-authored-by: Alex Somesan <alex.somesan@gmail.com>

view details

Miguel Alexandre

commit sha b8f8a00c82d843d4c04fcc8e5a863d3e25bb1141

Do not force base64 encoding for the ca_bundle (#735)

view details

Christopher Webb

commit sha 6cba06eccfe5d3859df69973ccab4bd0c704824a

Support for mount_options for StorageClass (#653) * CW Supporting mount_options for storageclass * CW Supporting documentation for storageclass/mount_options * Update kubernetes/resource_kubernetes_storage_class.go

view details

Joshua Hoblitt

commit sha d11bd2b142dff82400e8af43cd747bf8f8c4001d

add mount_options argument to kubernetes_persistent_volume (#429) * add mount_options argument to kubernetes_persistent_volume * add simple kubernetes_persistent_volume mount_options test * Wait-retry for PVC deletion * Add documentation for 'mount_options' on PV * Fix PV test for 'mount_options' Co-authored-by: Alex Somesan <alex.somesan@gmail.com>

view details

Alex Somesan

commit sha 5ff973036abdac60ef2efaa7198bc0b23666eba2

Update CHANGELOG.md

view details

tf-release-bot

commit sha 27908823b8a74629a076d7693f551831283f0373

v1.11.0

view details

tf-release-bot

commit sha 3572842358cc92d21074012f7111437d12774df5

Cleanup after v1.11.0 release

view details

David Symonds

commit sha fc39d33ecdea87d0e6bb9095997a101612144a71

Don't wait for Deployment updates to fully roll out. This can take a long time, and we don't care to wait.

view details

push time in 12 days

issue commentgoogleapis/google-cloud-go

spannertest: Support CommitTimestamp

Note that the implementation is a little buggy in the presence of racing transactions; the commit timestamps aren't guaranteed to be monotonic (though they will be unique). I'm preparing a change to fix that, but thought I should give you a heads up in case you rely on that property.

odsod

comment created time in 13 days

push eventdsymonds/gocloud

Tyler Bui-Palsulich

commit sha 50496d98cafd677e9759796804d3b0f1931a2f74

all: delete .repo-metadata.json files, add internal README Fixes #1758. Change-Id: Ib522ad8af4a31a0db63e4c851d7b3ca4596142bd Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51090 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Noah Dietz <ndietz@google.com>

view details

David Symonds

commit sha b954d44683796b109fc2ac43dac541838ed1b5fc

spanner/spansql: preserve filename, token position information during parse This is useful for tools built on top of spansql to be able to construct cross-references and similar. It is also a necessary condition for tools such as a formatter. This necessitates some backward incompatible changes to spansql, but they are simple to track. In particular, ParseDDL takes a filename argument, and a bunch of the AST types are now pointers instead of values. This has no impact on users of spannertest, only on direct users of the spansql package. Change-Id: Ic21e83879cdb1da8ac04692a5198e311383ca7a2 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50850 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

Hengfeng Li

commit sha 6482125bfc0d0dbfb1a81393f19c5b64c7952d05

spanner: skip TestIntegration_TransactionRunner test for the emulator The TransactionRunner test is testing the WoundWait algorithm of Cloud Spanner. Unfortunately, that is not supported within Emulator. Change-Id: I6fd5d0509935917b72378274afa31911039bce8b Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51050 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Shanika Kuruppu <skuruppu@google.com>

view details

David Symonds

commit sha 555bbfec440f0d88f933ca101cddcbe29f6f8349

spanner/spannertest: update signature of Server.UpdateDDL This was an oversight in the previous change. The natural type for spansql.DDL is now the pointer type (it is what is returned by ParseDDL), so functions accepting that type should match. Change-Id: I5a4f15df9d2963fd227fa9d203a5fd662a1e7d95 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51111 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

Chris Cotter

commit sha c7b88019aca2abf4e3f839397e3fde96c1507c0f

storage: fix default scopes for client The option WithScopes was not being applied correctly, such that the client had ScopeFullControl regardless of what the user passed in. This fixes the way the default is applied and adds an integration test to ensure that user-provided scope is respected. Fixes #1756 Change-Id: Ibeb5fc3d36eea8befc8faec33a72410cca6328b7 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51130 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Frank Natividad <franknatividad@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Eli Bendersky

commit sha 4a196869d0c34b98698dc7886bb9357b29b2790f

storage: fix some issues identified by staticcheck - bucket: complaint about explicit comparison to bool literals. Restructured the switch to an if/else chain. - bucket_test/storage: replaced use of deprecated constructor by the recommended replacement. - integration_test: seems like a genuine bug where a "return" is ommitted and no error is returned when it should be. With these changes staticcheck passes cleanly within the storage module. Change-Id: I090e8345ccbff66e632855802602251d26e217e5 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51030 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

jqll

commit sha bad0644c7a354b4f7c0ad511d7f7f1ef40f5bb6e

profiler: remove symbolization Go runtime symbolizes all profiles since Go 1.10. This repo officially dropped support for Go versions earlier than Go1.11. Extra symbolization can be removed. Fixes #1761 Tested: Ran busybench.go with Go 1.11, Go 1.12 and Go 1.13. All profile types are symbolized with all these versions. Change-Id: Ifa094f9f4f80404a923d368c73a9a87f98cc0bd5 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51150 Reviewed-by: Alexey Alexandrov <aalexand@google.com>

view details

Tyler Bui-Palsulich

commit sha bd1e6ab18e7f5395341036990f70dd0e0fc6db76

internal: change metadata to a map with package keys I also print the JSON with indentation to make diffs easier to read. Fixes #1764 Change-Id: Ief6877b2a1890b16ebc984f16baea271520d00bb Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51172 Reviewed-by: Noah Dietz <ndietz@google.com> Reviewed-by: David Supplee <dsupplee@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Chris Cotter

commit sha 30f6efe631f7b8dabaeaff1468824f55799384ea

storage: skip TestIntegration_RequesterPays This test has been flaking frequently; there is an issue open to fix. Updates #1753 Change-Id: I6210b67a154ea77085003846e04f7e36c28b07cc Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51210 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Noah

commit sha f9111a9a64ba53ea2c1fa32c0c2557d109e84967

asset: move v1beta1 & v1p2beta1 to microgen Note: this change generates a breaking change to v1p2beta1 as requested by the API team. Fix asset/apiv1p2beta1/mock_test.go for breaking change. Evaluation diff: https://code-review.googlesource.com/c/gocloud/+/51171 Change-Id: I19448c0bf329dd0cd8d6a354768a75fc6fbf40a6 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51190 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Tyler Bui-Palsulich

commit sha 9945411ca8ba6bb45338a4e1fd8ced690b7a58aa

internal/kokoro: run staticcheck on storage Change-Id: I736a22423a97b1748d94bb047a6a8e8e58b75f28 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51170 Reviewed-by: Eli Bendersky <eliben@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

Noah

commit sha 4466dc12d28517002da0e8928f324496e38cbaa5

monitoring: migrate to microgen Evaluation diff: https://code-review.googlesource.com/c/gocloud/+/51192 Change-Id: I18878615440c917d32b73c7ae0add6974ee79d42 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51193 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Noah

commit sha ae96aa22230a1f429d6fa38edc1d4f2cfd35d5e9

vision: v1p1beta1 migrate to microgen Evaluation diff: https://code-review.googlesource.com/c/gocloud/+/51270 Change-Id: I7fc4d4a4b36c7f19a24a262868625f252615b877 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51271 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Seth Hollyman <shollyman@google.com>

view details

IlyaFaer

commit sha 1eb0d529b77512b248a3d0f239f83e1ef8fa1162

storage: fix TestIndefiniteRetries flaky Test server treated */x content ranges as an end of object uploading. Fixes #1641 Change-Id: I8c94ce8a8b57b804a4ceef6ad1d1909a9a301c27 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51070 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

Masahiro Furudate

commit sha 115cfad1a8dd04bcad2f96be6ff4302d31c6210c

datastore: fix example comment Change-Id: Ifcf5a4ce7a2642c2fda8ffbc2ee1ad1be722252c Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51310 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Broadfoot <cbro@google.com>

view details

Alex Hong

commit sha 62ed622ec548ed8d1837309fe1661913ec42679d

pubsub: make DeliveryAttempt field nil when dead lettering is disabled. Change DeliveryAttempt from an int field to an optional.Int that is nil when the associated subscription does not have dead lettering enabled. This is a backwards incompatible change, but is allowed since the field has not yet been marked as stable. Fixes #1762. Change-Id: I0ec70ecbecd91888bb1ebecb30c7ed53f3c91b06 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51151 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Chris Broadfoot

commit sha 790001b314b38ba1fb200d11f15bc6e20685762d

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genmgr will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/297 Change-Id: Iab002e26a8fe2dac05ab1f9806397a95eccde5f1 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51331 Reviewed-by: Alex Hong <hongalex@google.com> Reviewed-by: Noah Dietz <ndietz@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Chris Broadfoot

commit sha bb68fe553ba39e9f40720c4d8cca86249bb108a0

internal/gapicgen: simplify genbot, add more logging * Simplified Dockerfile for genbot * Added more logging to generator * Fixed a couple typos * Revved deps Change-Id: I222e01f5764939b3ddd1d8f29a448733f8192912 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51370 Reviewed-by: Seth Hollyman <shollyman@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Noah Dietz <ndietz@google.com>

view details

Yoshi Automation Bot

commit sha 272a39df1ac083f59933b86122b0f715b111e9af

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genmgr will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/298 Change-Id: I66000804893a635fa609c0e6801c7d5aba710e2a Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51394 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Chris Cotter

commit sha 0f9dd32f810d414b41934a44668ed1e65f4afcce

pubsub: skip TestEndToEnd_Dupes This test is flaking currently. Updates #1752 Change-Id: Idd55ecf3a13f590be7c163ab1a073cef2245bc11 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51430 Reviewed-by: Alex Hong <hongalex@google.com>

view details

push time in 13 days

push eventdsymonds/gocloud

David Symonds

commit sha 263f0b395d0e7abc789165ae2490b8ed906bbe9b

compute/metadata: add tracing info Bug: 147444210 Change-Id: Id708733f100cbf5f5f426e18a06fe06a1d755208

view details

push time in 13 days

issue commentgolang/go

x/exp: reconsider using single module for all unrelated experimental packages of various maturity levels

It seems like cmd/apidiff should at least be moved to x/tools given its stability these days.

But separate go.mod files throughout x/exp seems good too, especially since that repository is prone to having dependencies outside the standard library and other x/ repos.

dmitshur

comment created time in 14 days

issue openedgolang/go

cmd/go: `go mod why` isn't enlightening for non-build dependencies

What version of Go are you using (go version)?

<pre> $ go version go version devel +0377f06168 Tue Dec 17 20:57:06 2019 +0000 linux/amd64 </pre>

Does this issue reproduce with the latest release?

Unknown

What did you do?

Check out a clean copy of cloud.google.com/go, and run go mod why dmitri.shuralyov.com/gpu/mtl in its main module.

Providing -m to the command doesn't change it either.

What did you expect to see?

I expect to see some list of packages that show the dependency tree.

What did you see instead?

# dmitri.shuralyov.com/gpu/mtl
(main module does not need module dmitri.shuralyov.com/gpu/mtl)

/cc @robpike @dmitshur

created time in 15 days

issue commentgoogleapis/google-cloud-go

spannertest: Support CommitTimestamp

https://code-review.googlesource.com/c/gocloud/+/51710

odsod

comment created time in 16 days

issue commentgoogle/licensecheck

Apache license recognized as ECL-2

I guess this would be fixed by #6.

jba

comment created time in 16 days

issue openedgoogleapis/google-cloud-go

spanner: unnecessary Rollback after failed Commit

The Spanner client invokes the Rollback RPC when a ReadWriteTransaction is needing to be terminated. However, this also happens when a Commit fails in a permanent way, and the Rollback RPC is rejected saying that it is invalid to invoke Rollback after Commit.

Nothing breaks, but it adds noise to logs and the like, messes with RPC metrics, and probably slows things down a bit due to unnecessary RPCs.

Maybe related to the old #892 issue.

created time in 19 days

issue commentgoogleapis/google-cloud-go

spanner: ` for special keywords not supported in cloud.google.com/go/spanner/spansql

https://code-review.googlesource.com/c/gocloud/+/51415

geerttouquet

comment created time in 21 days

push eventdsymonds/gocloud

Tyler Bui-Palsulich

commit sha 50496d98cafd677e9759796804d3b0f1931a2f74

all: delete .repo-metadata.json files, add internal README Fixes #1758. Change-Id: Ib522ad8af4a31a0db63e4c851d7b3ca4596142bd Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51090 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Noah Dietz <ndietz@google.com>

view details

David Symonds

commit sha b954d44683796b109fc2ac43dac541838ed1b5fc

spanner/spansql: preserve filename, token position information during parse This is useful for tools built on top of spansql to be able to construct cross-references and similar. It is also a necessary condition for tools such as a formatter. This necessitates some backward incompatible changes to spansql, but they are simple to track. In particular, ParseDDL takes a filename argument, and a bunch of the AST types are now pointers instead of values. This has no impact on users of spannertest, only on direct users of the spansql package. Change-Id: Ic21e83879cdb1da8ac04692a5198e311383ca7a2 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50850 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

David Symonds

commit sha 1b55b21722b535b2f4ffd317f9930408a074e2fb

compute/metadata: add tracing info Bug: 147444210 Change-Id: Id708733f100cbf5f5f426e18a06fe06a1d755208

view details

push time in a month

push eventdsymonds/gocloud

David Symonds

commit sha 25354cb9a25f8717feec874580571e126accaa0f

spanner: adjust where trace span is created for Apply It should cover both regular and at-least-once applies, or else there is no span that covers the former. Fixes #1750 Change-Id: I2d60e74fe0c4ce6c5283fefcc551eda8f6ff21a3 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50910 Reviewed-by: Knut Olav Løite <koloite@gmail.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Yoshi Automation Bot

commit sha e48feef819212e061f6699d9209872bfe09e4969

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/293 Change-Id: I0eec39e3bd32259c8faaf1de9178513abbd9b0d4 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50872 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Chris Cotter

commit sha c5fcd67e3d904b723a2ec52f0054f03186a19674

storage: don't drop port in endpoint If the user creates a client with a custom endpoint, we should retain the port for readhost. Fixes #1737 Change-Id: Ic0cf928ae99fe115e1eebce46c3965044d682db4 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50891 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

David Symonds

commit sha 297277dd2601ad6ce326eca145c31245aaab1b1e

spanner/spannertest: implement SELECT DISTINCT This is implemented as a fairly inefficient but simple post-query filter. Change-Id: I050256d7d990bdfb59a7c2a54baafd37908744eb Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50951 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

Olav Loite

commit sha fbe1038431742623104ab8a3b44345f7866de5cb

spanner: Allow encoding and decoding to pointers This CL adds support for decoding and encoding Spanner values to fields that have a pointer type to a base type. This makes working with nullable values more natural, as it makes it possible to define a field as *string instead of having to use the special spanner.NullString type. This CL does NOT add support for decoding and encoding to pointers to custom types that point back to base types. I.e. the following struct cannot be used to decode rows from Spanner. type CustomString string type Entity struct { ID *CustomString } Fixes #1684 Change-Id: Id5cb4c0b189d27ab9c7fff4b37be1cc69c7644b7 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50650 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Yoshi Automation Bot

commit sha 90176c53334792a9398997305a10aad645088be9

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/294 Change-Id: Ic38baeeb61c09dbb9fd5ef99c8ab1063cc3341ef Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50970 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

noahdietz

commit sha 2e6a3a7f40ebfea7261a8537f779cbdf3a72d1be

videointelligence: migrate v1beta2 to microgen Eval diff at: https://code-review.googlesource.com/c/gocloud/+/50930 Change-Id: If4282109a63717c53a8dab431a4e71ba2ee789e4 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50931 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Alex Hong

commit sha cd8954bea41b88f89f328ba294aea2cc7bda6649

pubsub: keep streams open unconditionally by sending ping every 30 seconds Currently, we keep StreamingPull streams alive only if there are messages that have not expired. This is inconsistent with other client libraries, which send pings/heartbeats to keep streams open every 30s. This will result in fewer connection open requests with clients with many idle subscriptions. Fixes #1671 Change-Id: I5cd3080f6d90b09c5548d4f557727db208a4f852 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50890 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Kamal Aboul-Hosn <aboulhosn@google.com> Reviewed-by: Seth Hollyman <shollyman@google.com>

view details

Tyler Bui-Palsulich

commit sha fb1f92920422b24f94637d3bf6deddbb637fe2ad

internal/gapicgen: generate a package manifest I output the file to internal/.repo-metadata-full.json, but I'm open to other paths or filenames. This only covers packages generated by the microgenerator. I left a TODO to include the other packages/clients. Where it makes sense, we may just wait for the microgenerator to pick the rest up. Change-Id: I29aa50103fce4d67cf9a0047a2eac5d6076609d9 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50990 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Noah Dietz <ndietz@google.com>

view details

Hengfeng Li

commit sha ad7cd32b39df6e142b24ab86b2cda03f21e1d708

spanner: release v1.2.0 Change-Id: I373c02d0b4c814510c59f8423437c95eaab1c651 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50950 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com> Reviewed-by: Shanika Kuruppu <skuruppu@google.com>

view details

David Symonds

commit sha 263f0b395d0e7abc789165ae2490b8ed906bbe9b

compute/metadata: add tracing info Bug: 147444210 Change-Id: Id708733f100cbf5f5f426e18a06fe06a1d755208

view details

push time in a month

issue closedgolang/geo

polylines match

Hi, what is the recommended way to find two polylines (intersecting each other) are in same direction. Is there any function written for it?

closed time in a month

nakulmandal

push eventdsymonds/gocloud

David Symonds

commit sha 25354cb9a25f8717feec874580571e126accaa0f

spanner: adjust where trace span is created for Apply It should cover both regular and at-least-once applies, or else there is no span that covers the former. Fixes #1750 Change-Id: I2d60e74fe0c4ce6c5283fefcc551eda8f6ff21a3 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50910 Reviewed-by: Knut Olav Løite <koloite@gmail.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Yoshi Automation Bot

commit sha e48feef819212e061f6699d9209872bfe09e4969

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/293 Change-Id: I0eec39e3bd32259c8faaf1de9178513abbd9b0d4 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50872 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Chris Cotter

commit sha c5fcd67e3d904b723a2ec52f0054f03186a19674

storage: don't drop port in endpoint If the user creates a client with a custom endpoint, we should retain the port for readhost. Fixes #1737 Change-Id: Ic0cf928ae99fe115e1eebce46c3965044d682db4 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50891 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

David Symonds

commit sha 297277dd2601ad6ce326eca145c31245aaab1b1e

spanner/spannertest: implement SELECT DISTINCT This is implemented as a fairly inefficient but simple post-query filter. Change-Id: I050256d7d990bdfb59a7c2a54baafd37908744eb Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50951 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

Olav Loite

commit sha fbe1038431742623104ab8a3b44345f7866de5cb

spanner: Allow encoding and decoding to pointers This CL adds support for decoding and encoding Spanner values to fields that have a pointer type to a base type. This makes working with nullable values more natural, as it makes it possible to define a field as *string instead of having to use the special spanner.NullString type. This CL does NOT add support for decoding and encoding to pointers to custom types that point back to base types. I.e. the following struct cannot be used to decode rows from Spanner. type CustomString string type Entity struct { ID *CustomString } Fixes #1684 Change-Id: Id5cb4c0b189d27ab9c7fff4b37be1cc69c7644b7 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50650 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Yoshi Automation Bot

commit sha 90176c53334792a9398997305a10aad645088be9

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/294 Change-Id: Ic38baeeb61c09dbb9fd5ef99c8ab1063cc3341ef Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50970 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

noahdietz

commit sha 2e6a3a7f40ebfea7261a8537f779cbdf3a72d1be

videointelligence: migrate v1beta2 to microgen Eval diff at: https://code-review.googlesource.com/c/gocloud/+/50930 Change-Id: If4282109a63717c53a8dab431a4e71ba2ee789e4 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50931 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Alex Hong

commit sha cd8954bea41b88f89f328ba294aea2cc7bda6649

pubsub: keep streams open unconditionally by sending ping every 30 seconds Currently, we keep StreamingPull streams alive only if there are messages that have not expired. This is inconsistent with other client libraries, which send pings/heartbeats to keep streams open every 30s. This will result in fewer connection open requests with clients with many idle subscriptions. Fixes #1671 Change-Id: I5cd3080f6d90b09c5548d4f557727db208a4f852 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50890 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Kamal Aboul-Hosn <aboulhosn@google.com> Reviewed-by: Seth Hollyman <shollyman@google.com>

view details

Tyler Bui-Palsulich

commit sha fb1f92920422b24f94637d3bf6deddbb637fe2ad

internal/gapicgen: generate a package manifest I output the file to internal/.repo-metadata-full.json, but I'm open to other paths or filenames. This only covers packages generated by the microgenerator. I left a TODO to include the other packages/clients. Where it makes sense, we may just wait for the microgenerator to pick the rest up. Change-Id: I29aa50103fce4d67cf9a0047a2eac5d6076609d9 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50990 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Noah Dietz <ndietz@google.com>

view details

Hengfeng Li

commit sha ad7cd32b39df6e142b24ab86b2cda03f21e1d708

spanner: release v1.2.0 Change-Id: I373c02d0b4c814510c59f8423437c95eaab1c651 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50950 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com> Reviewed-by: Shanika Kuruppu <skuruppu@google.com>

view details

David Symonds

commit sha 263f0b395d0e7abc789165ae2490b8ed906bbe9b

compute/metadata: add tracing info Bug: 147444210 Change-Id: Id708733f100cbf5f5f426e18a06fe06a1d755208

view details

push time in a month

push eventdsymonds/gocloud

Yoshi Automation Bot

commit sha 9234246c3391893ed118a8231c4b80f6a4e422a1

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/288 Change-Id: I4c762ebb251103d94d93c9d04049cff8ec9d917c Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50390 Reviewed-by: Cody Oss <codyoss@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Cody Oss

commit sha ee3c4a40d777d926467a5261c6d87c0f0dae31d1

internal: fix unnecessary genmgr commits Change-Id: I936d6f3f593973aa41a8963d1d15d6890b7bccf3 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50450 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

IlyaFaer

commit sha 8fdd8ca6f9991c1b04673f51bca068860201e602

firestore: fix serverTimestamp docs Add into serverTimestamp comment tip about that it's non-zero values are not affecting anything. Fixes #1562 Change-Id: I98b6aff755b4d68b86ef9935a3bdb153e27762e8 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49610 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: BenWhitehead <benwhitehead@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

IlyaFaer

commit sha 8cc1f110d43c32849b5d12c473a19b9300d9a559

storage: fix broken TestIndefiniteRetries test Extend mock server sentences to make test work in all possible cases. Closes #1641 Change-Id: I4922140938ca24e9863d4801f820f2be4e57cf26 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49871 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

Yoshi Automation Bot

commit sha 1b8ed81c0b372138f091b23f2359b6f1fd0a13a2

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/289 Change-Id: Ib1071b979bcf398dfbd734302e64ef4187838819 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50470 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Alex Hong

commit sha ba98f1882abb2e0078a23d925b105c90a2f71d65

pubsub: unskip TestIntegration_All TestIntegration_All and similar integration tests were failing, but I believe this was related to an internal issue that affected whitelisted projects for new pubsub features (see b/145546941). Unskipping this test for now since recent build triggers seem to be green. Fixes #1663 Change-Id: Ie0f6700a8bd0fb99e2dcee4c04470537246f191e Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50490 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Noah Dietz <ndietz@google.com>

view details

Tyler Bui-Palsulich

commit sha 460562cc84d9ce7460feef3bad77af9e3d7c6109

.github: add FR and PR templates Change-Id: I6acaf78be5f7f5bdd291ec9b0683141b73871626 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50530 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Broadfoot <cbro@google.com> Reviewed-by: Alex Hong <hongalex@google.com>

view details

shollyman

commit sha 62226378e4e23fe854d19b4a63df3eef1cb79264

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/291 Change-Id: I116ecc04e8d724bb9ea365065e73d7a22860105b Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50570 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Seth Hollyman

commit sha 8284950323a24d2dabdf5ec20f343f426823304d

bigquerystorage: add gapicgen configs for v1beta2 endpoint. This change was used to drive the recent genproto/gocloud changes here: https://github.com/googleapis/go-genproto/pull/291 https://code-review.googlesource.com/c/gocloud/+/50570 Change-Id: I2fb8c0d54246425496d32b7b3bea66ee8f43ce7c Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50571 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Alex Hong

commit sha c073518f1ae7511a72dff8bf673f51cdaed625ab

pubsub: unflake TestIntegration Change-Id: I7673e8b83ecdf7d3cf09c041fca4956a43e81fdb Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50590 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

noahdietz

commit sha d513fbfc76a1c1673b8c6084a125e657a5981325

longrunning: migrate to microgen * bump microgenerator version to v0.10.0 Evaluation diff: https://code-review.googlesource.com/c/gocloud/+/50610 Change-Id: Ibc36b588e60c342886d5779857cda2140e239c8e Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50630 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Seth Hollyman

commit sha 8003513d75d7416e63cfc550df055ab35a3a6c38

gapicgen: simplify setup and documentation. The cookie name used for gerrit authentication is standard, and so this change sets the default to that value ("o") and removes references to it in documentation. This PR also attempts to clarify what the relevant auth token from Gerrit code review looks like in the documentation, in hopes that future users don't get tripped on this as much. Change-Id: Ied4f780f1246b4269ba3f9c48e6958ec57593687 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50611 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Alex Hong <hongalex@google.com>

view details

Yuki Ito

commit sha 4c1e347d19f5d64f55bbbe44f19225cba395ec09

spanner: make ReadWriteTransaction retry on Session not found error Updates #1527 Ref: https://github.com/googleapis/google-cloud-go/issues/1527 Change-Id: Iea12342ca098c8056abc2206b91edbeda630e718 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/45910 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Aleksandra Bogoslavetc

commit sha 4f991931ec471a11950a060e5ee06dc93d0d1430

spanner: ReadOnlyTransaction().ReadRowUsingIndex Add ReadRowUsingIndex() method that returns a single row from the database by index Fixes #1035 Change-Id: If6c40e56ce19a79c9bd59723367b6892ae278f4f Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/48091 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Olav Loite

commit sha 4a4cd86bb8c4defa3fa51b9238242c4e4ad537bf

spanner: retry SessionNotFound on BeginTransaction for read-only tx 'Session not found' errors on BeginTransaction calls for a read-only transaction should be retried on a new session, and the invalid session should be removed from the session pool. Updates #1527. Change-Id: I49a6cb5e096c8b93c7aec76cdbd1c3d640f50c0d Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50510 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Olav Loite

commit sha 7a18dc1cf89176d57c4a4668d3a8aa1f7757effc

spanner: retry single use transactions on SessionNotFound Single use read-only transactions should be retried if the query returns a 'Session not found' error. These queries can safely be retried on a different session as there is no transaction atomicity that can be violated. The retry must be executed by the partial result sets stream, as the query is sent to the server at the first call to RowIterator.Next. Updates #1527. Change-Id: Ia3c77643e42adb2f88dba2cfd5d1bba7f9dbf3be Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50511 Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Seth Hollyman

commit sha afc0e24730f3c38dd2e8230adb02c20fcf11da8c

spanner: remove duplicate test method. Quick fix for https://github.com/googleapis/google-cloud-go/issues/1738, until Knut has a chance to review in more detail. Change-Id: I4ed5b3107fab5f9aa75312085dfa88703547293e Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50690 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Alex Hong <hongalex@google.com>

view details

Seth Hollyman

commit sha d9b4def41e2d0cdcf360dc6270a33a0c6d932bcd

gapicgen: add datacatalog/v1beta1, bigquerystorage/v1alpha2 Change-Id: I077e28e9f76a3ea14b8746778686607d75437a35 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50670 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Seth Hollyman

commit sha 6daa679260d92196ffca2362d652c924fdcb7a22

release: v0.52.0 This PR will be tagged v0.52.0. Change-Id: I1aa853cf1d439f4796733ca891f56d9033f729ff Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50711 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Hengfeng Li

commit sha bc929c812c6fe262a8c587725b5d0bb6c14b5466

spanner: fix the warning message for resource-based routing. Change-Id: I9d4050db6fec342903270eba41d7e3ea4aabc1ff Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50730 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

push time in a month

push eventdsymonds/gocloud

David Symonds

commit sha 889286401cc6d5a7af5b30e44e9da07fe166930d

spanner: adjust where trace span is created for Apply It should cover both regular and at-least-once applies, or else there is no span that covers the former. Change-Id: I2d60e74fe0c4ce6c5283fefcc551eda8f6ff21a3

view details

David Symonds

commit sha 1271592f290a45ae0754f5388839a0e55e7c5aac

compute/metadata: add tracing info Bug: 147444210 Change-Id: Id708733f100cbf5f5f426e18a06fe06a1d755208

view details

push time in a month

push eventdsymonds/gocloud

David Symonds

commit sha 13683e4370370d9ee994b5da3ddf7d0df1e30413

spanner: increase GetSession timeout during ping This may involve a metadata lookup? Maybe? I'm seeing a lot of frequent DeadlikeExceeded coming from this. Change-Id: I5413dc856ebee737326913b10452e13a2307946c

view details

push time in a month

push eventdsymonds/gocloud

David Symonds

commit sha b814ba7e934a96c0592dbc3e0c858772ad432b48

spanner: increase GetSession timeout during ping This may involve a metadata lookup? Maybe? I'm seeing a lot of frequent DeadlikeExceeded coming from this. Change-Id: I5413dc856ebee737326913b10452e13a2307946c

view details

push time in a month

create barnchdsymonds/gocloud

branch : old-master

created branch time in a month

push eventdsymonds/gocloud

Yoshi Automation Bot

commit sha 9234246c3391893ed118a8231c4b80f6a4e422a1

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/288 Change-Id: I4c762ebb251103d94d93c9d04049cff8ec9d917c Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50390 Reviewed-by: Cody Oss <codyoss@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Cody Oss

commit sha ee3c4a40d777d926467a5261c6d87c0f0dae31d1

internal: fix unnecessary genmgr commits Change-Id: I936d6f3f593973aa41a8963d1d15d6890b7bccf3 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50450 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

IlyaFaer

commit sha 8fdd8ca6f9991c1b04673f51bca068860201e602

firestore: fix serverTimestamp docs Add into serverTimestamp comment tip about that it's non-zero values are not affecting anything. Fixes #1562 Change-Id: I98b6aff755b4d68b86ef9935a3bdb153e27762e8 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49610 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: BenWhitehead <benwhitehead@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

IlyaFaer

commit sha 8cc1f110d43c32849b5d12c473a19b9300d9a559

storage: fix broken TestIndefiniteRetries test Extend mock server sentences to make test work in all possible cases. Closes #1641 Change-Id: I4922140938ca24e9863d4801f820f2be4e57cf26 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49871 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

Yoshi Automation Bot

commit sha 1b8ed81c0b372138f091b23f2359b6f1fd0a13a2

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/289 Change-Id: Ib1071b979bcf398dfbd734302e64ef4187838819 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50470 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Alex Hong

commit sha ba98f1882abb2e0078a23d925b105c90a2f71d65

pubsub: unskip TestIntegration_All TestIntegration_All and similar integration tests were failing, but I believe this was related to an internal issue that affected whitelisted projects for new pubsub features (see b/145546941). Unskipping this test for now since recent build triggers seem to be green. Fixes #1663 Change-Id: Ie0f6700a8bd0fb99e2dcee4c04470537246f191e Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50490 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Noah Dietz <ndietz@google.com>

view details

Tyler Bui-Palsulich

commit sha 460562cc84d9ce7460feef3bad77af9e3d7c6109

.github: add FR and PR templates Change-Id: I6acaf78be5f7f5bdd291ec9b0683141b73871626 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50530 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Broadfoot <cbro@google.com> Reviewed-by: Alex Hong <hongalex@google.com>

view details

shollyman

commit sha 62226378e4e23fe854d19b4a63df3eef1cb79264

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/291 Change-Id: I116ecc04e8d724bb9ea365065e73d7a22860105b Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50570 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Seth Hollyman

commit sha 8284950323a24d2dabdf5ec20f343f426823304d

bigquerystorage: add gapicgen configs for v1beta2 endpoint. This change was used to drive the recent genproto/gocloud changes here: https://github.com/googleapis/go-genproto/pull/291 https://code-review.googlesource.com/c/gocloud/+/50570 Change-Id: I2fb8c0d54246425496d32b7b3bea66ee8f43ce7c Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50571 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Alex Hong

commit sha c073518f1ae7511a72dff8bf673f51cdaed625ab

pubsub: unflake TestIntegration Change-Id: I7673e8b83ecdf7d3cf09c041fca4956a43e81fdb Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50590 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

noahdietz

commit sha d513fbfc76a1c1673b8c6084a125e657a5981325

longrunning: migrate to microgen * bump microgenerator version to v0.10.0 Evaluation diff: https://code-review.googlesource.com/c/gocloud/+/50610 Change-Id: Ibc36b588e60c342886d5779857cda2140e239c8e Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50630 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Seth Hollyman

commit sha 8003513d75d7416e63cfc550df055ab35a3a6c38

gapicgen: simplify setup and documentation. The cookie name used for gerrit authentication is standard, and so this change sets the default to that value ("o") and removes references to it in documentation. This PR also attempts to clarify what the relevant auth token from Gerrit code review looks like in the documentation, in hopes that future users don't get tripped on this as much. Change-Id: Ied4f780f1246b4269ba3f9c48e6958ec57593687 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50611 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Alex Hong <hongalex@google.com>

view details

Yuki Ito

commit sha 4c1e347d19f5d64f55bbbe44f19225cba395ec09

spanner: make ReadWriteTransaction retry on Session not found error Updates #1527 Ref: https://github.com/googleapis/google-cloud-go/issues/1527 Change-Id: Iea12342ca098c8056abc2206b91edbeda630e718 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/45910 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Aleksandra Bogoslavetc

commit sha 4f991931ec471a11950a060e5ee06dc93d0d1430

spanner: ReadOnlyTransaction().ReadRowUsingIndex Add ReadRowUsingIndex() method that returns a single row from the database by index Fixes #1035 Change-Id: If6c40e56ce19a79c9bd59723367b6892ae278f4f Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/48091 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Olav Loite

commit sha 4a4cd86bb8c4defa3fa51b9238242c4e4ad537bf

spanner: retry SessionNotFound on BeginTransaction for read-only tx 'Session not found' errors on BeginTransaction calls for a read-only transaction should be retried on a new session, and the invalid session should be removed from the session pool. Updates #1527. Change-Id: I49a6cb5e096c8b93c7aec76cdbd1c3d640f50c0d Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50510 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Olav Loite

commit sha 7a18dc1cf89176d57c4a4668d3a8aa1f7757effc

spanner: retry single use transactions on SessionNotFound Single use read-only transactions should be retried if the query returns a 'Session not found' error. These queries can safely be retried on a different session as there is no transaction atomicity that can be violated. The retry must be executed by the partial result sets stream, as the query is sent to the server at the first call to RowIterator.Next. Updates #1527. Change-Id: Ia3c77643e42adb2f88dba2cfd5d1bba7f9dbf3be Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50511 Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Seth Hollyman

commit sha afc0e24730f3c38dd2e8230adb02c20fcf11da8c

spanner: remove duplicate test method. Quick fix for https://github.com/googleapis/google-cloud-go/issues/1738, until Knut has a chance to review in more detail. Change-Id: I4ed5b3107fab5f9aa75312085dfa88703547293e Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50690 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Alex Hong <hongalex@google.com>

view details

Seth Hollyman

commit sha d9b4def41e2d0cdcf360dc6270a33a0c6d932bcd

gapicgen: add datacatalog/v1beta1, bigquerystorage/v1alpha2 Change-Id: I077e28e9f76a3ea14b8746778686607d75437a35 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50670 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Seth Hollyman

commit sha 6daa679260d92196ffca2362d652c924fdcb7a22

release: v0.52.0 This PR will be tagged v0.52.0. Change-Id: I1aa853cf1d439f4796733ca891f56d9033f729ff Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50711 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Hengfeng Li

commit sha bc929c812c6fe262a8c587725b5d0bb6c14b5466

spanner: fix the warning message for resource-based routing. Change-Id: I9d4050db6fec342903270eba41d7e3ea4aabc1ff Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50730 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

push time in a month

issue commentgoogleapis/google-cloud-go

spannertest: TIMESTAMP support

You’re welcome! I’m glad it is helping you out.

odsod

comment created time in a month

issue commentgoogleapis/google-cloud-go

Spanner: ` for special keywords not supported in cloud.google.com/go/spanner/spansql

Yes, this is a known TODO.

spanner/spansql/parser.go:	// TODO: backtick (`) for quoted identifiers.
geerttouquet

comment created time in a month

issue commentgoogleapis/google-cloud-go

spannertest: TIMESTAMP support

https://code-review.googlesource.com/c/gocloud/+/50791

odsod

comment created time in a month

issue commentgoogleapis/google-cloud-go

spannertest: TIMESTAMP support

Sorry, only just noticed this bug. I can likely tackle this today or tomorrow.

odsod

comment created time in a month

issue commentgoogleapis/google-cloud-go

spanner: Programmatically Calculating Spanner Max Mutation Set

I'm not on the backend team, but your formula is my understanding too. The mutation operation count of a single insertion is the number of columns, plus the sum of the columns in the secondary indexes.

jon-whit

comment created time in a month

pull request commentterraform-providers/terraform-provider-kubernetes

Fix namespacing on kubernetes_priority_class

Note that this'll break anyone using this resource under the old namespaced name. It's straightforward to deal with (terraform state rm on the old name, then re-import), but it seems like this should be called out in the release notes.

alexsomesan

comment created time in a month

push eventdsymonds/terraform-provider-kubernetes

Alex Somesan

commit sha 40db9534da854423fd7a83bfa98a1721e5148ba2

Fix namespacing issues on kubernetes_priority_class (#682)

view details

Patrick Decat

commit sha e0dcfc1928c542409df47b28ed7891a6d872ebe7

Update description to match other official providers (#699) See: - https://github.com/terraform-providers/terraform-provider-google/blob/master/README.md#terraform-provider-for-google-cloud-platform - https://github.com/terraform-providers/terraform-provider-helm/blob/master/README.md#terraform-provider-for-helm - https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/README.md#terraform-provider-for-azure-resource-manager

view details

Alex Somesan

commit sha 435fc18f729f2563c27187b231b535119979e33f

Fix GKE test infra attributes for Google provider v3.x.x (#700)

view details

Patrick Decat

commit sha 45d910a26f17f7b03d684221428b86f2f02b5be2

Fix (cluster-)role bindings and rules updates (#714) * Add test showcasing bug in role binding patch * Fix kubernetes_cluster_role_binding and kubernetes_role_binding updates when there are removals * Add test cases to reproduce bug on Cluster Role updates in presence of removals * Fix kubernetes_cluster_role updates when there are rule removals * Add test cases to reproduce bug on Cluster Role Reference updates * Fix bug on Cluster Role Reference updates doing nothing (requires binding replacement)

view details

John Houston

commit sha 3a84f2ae16e2eacd5f9c6be7873771ed6f521a54

Fix broken link in ResourceQuota documentation (#730)

view details

kmoe

commit sha b39a198c57badf0cdd76c613a2c84e8fca5cfa70

Go v1.13 module compatibility (#732) * Go v1.13 module compatibility fixes This commit uses a replace directive to correct an invalid pseudo-version in a transitive dependency on github.com/Azure/go-autorest. It also corrects an invalid pseudo-version in github.com/keybase/go-crypto. * Switch TravisCI build environment to Go 1.13.x Co-authored-by: Alex Somesan <alex.somesan@gmail.com>

view details

Alex Somesan

commit sha 5a8e9ab54375f34111146c85ffb28a7110f12141

go get -u github.com/hashicorp/terraform-plugin-sdk@v1.4.1 (#733)

view details

Alex Somesan

commit sha 3c00798739ec767475e92b6243f00ee9766848be

Revendor after plugin-sdk bump

view details

David Symonds

commit sha bfe95d2c82afb015b61fcab4cb00c50ddc6a8cdc

Don't wait for Deployment updates to fully roll out. This can take a long time, and we don't care to wait.

view details

push time in a month

push eventdsymonds/gocloud

Cody Oss

commit sha cca68827d1700019ecd6a99ce0c2710443bd5612

docs: fix kms link in readme Fixes #1722 Change-Id: I5e63db3a7e4e42b56108d43e2c4fa8323f7c844f Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50352 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Hengfeng Li

commit sha cec21c7d6a073617dc01668bb07c2800da8b70dd

spanner: update integration tests to run for the emulator. Change-Id: I23f422c761e629e145190aa2b6db0a57f1294384 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50091 Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

Olav Loite

commit sha 25b2b69aef1480130cc2b5335aed9f248276de6d

spanner: Support encoding custom types Support encoding custom types that point back to supported basic types. Fixes #853. Change-Id: I669a717dae021400ce3b5b2c3a441bdedd82cfc2 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49873 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Olav Loite

commit sha 06a25b07bc449e6b3b971b1325f192e6d5b32837

spanner: fix automatic retry of aborted dml DML and Batch DML statements that were aborted by Spanner were not automatically retried, as these did not return a Spanner, but a Status error. Fixes #1720. Change-Id: Ic3ba3e546f2ff02626b1175b4a7813a4dee461b9 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50230 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Olav Loite

commit sha f858c6cfaf84bbd03bc866238daccc3f066e3100

spanner: session client should return Spanner errors The session client would return non-Spanner errors to the session consumer when a context error or a gRPC error would occur. Updates #1719. Change-Id: Ife5b6cc503609404a9b8abed290fdb1932b29a56 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50231 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Shanika Kuruppu <skuruppu@google.com>

view details

Cody Oss

commit sha 4e7fb24f2973a4a8d59ff13c95859759b6506f95

bigtable: release v1.2.0 Change-Id: I332651a85265e8cef0cfa7124f6744b82e5122a4 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50351 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

Shihang Zhang

commit sha fbf2f5121ef6008eb9b7e5c67aa0c9abfa7ac7fc

compute/metadata: unset ResponseHeaderTimeout in defaultClient for customers who use workload identity in gke, this argument will sometimes prevent them from getting metadata credentials under heavy load. the roundtrip to mds usually takes longer than 2 seconds. we probably need to do the same thing to packages in java, c++, etc.. if there is such timeout parameter set. Change-Id: I284a0104a0b87a53dbbddca11b1468a31692ea97 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50350 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Cody Oss <codyoss@google.com>

view details

David Symonds

commit sha e90e19695567747b5a48dcdf4b66cf31aad3481e

compute/metadata: add tracing info Bug: 147444210 Change-Id: Id708733f100cbf5f5f426e18a06fe06a1d755208

view details

push time in a month

push eventdsymonds/gocloud

David Symonds

commit sha 87073de9b262036146b5b1a3f598b3018ebcf044

compute/metadata: increase timeout for metadata requests This is similar to https://code-review.googlesource.com/c/gocloud/+/50350, but keeping a timeout. Bug: 147444210 Change-Id: I9ed3af7dfad908f1431352b64a952970fc5d29d7

view details

push time in 2 months

push eventdsymonds/gocloud

Jean de Klerk

commit sha 8d0c25089224c076f4f5e9fff49ff671704440bb

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/281 Change-Id: I8ef33b51faa5fed9330f4a9b4ceec8682a59a592 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49750 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Jean de Klerk

commit sha cc3fae1a98d2fbd8c423fe98cc08fa1e038c35cd

internal/gapicgen: better genmgr error messaging This CL stops genmgr from conflating has-reviewers with wrong-author. Change-Id: I35b081546359d6b8b327666bbfd5eaf5ede6eaf8 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49770 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Yoshi Automation Bot

commit sha 66848db4f8b3fb507abfbd0d2363e712502b6f1a

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/282 Change-Id: If35ba5cab78a7554f79d875cb21e7b67ff092353 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49790 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

Jean de Klerk

commit sha eb4221c66024187678daa30fb58b56ed554b3552

internal/gapicgen: genmgr update go.mod frequently Currently if genmgr runs right after genbot, the go module proxies may not have picked up the latest version of genproto, resulting in go.mod not getting latest genproto BUT the CL is updated with reviewers. So, the only way to get the CL to have updated go.mod is to remove reviewers, run genmgr again, which will cause it get past its !hasReviewers check and update go.mod and add reviewers again. This CL changes that behavior such that it always tries to update go.mod regardless of if there are reviewers or not. Separately it will add reviewers if there are none. Also some formatting fixes and changes some exit 1s to exit 0s. Change-Id: I879feea18f77090a0fcddfea16147eaf694ffd44 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49810 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

David Symonds

commit sha 0d30a7e946876517143bb88c8dbe680ef16e6140

spanner/spannertest: implement storing data into BYTES columns Retrieval already worked; storage was the missing piece. Change-Id: Ia310bd2641cf4e38002c6c4481711763a6d09a91 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49690 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

Yoshi Automation Bot

commit sha a3cf1f68699faeab19784a843d6f4d5c471b8164

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/285 Change-Id: Ie144591da40d9ee427f69175b4e35db3475b1f83 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49850 Reviewed-by: Jean de Klerk <deklerk@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Olav Loite

commit sha 4fba433c5c50f4f80f83e43c239daef448309759

spanner: Stop prepare sessions on error The background process for preparing sessions for write transactions should stop on any server error except 'Session not found'. The process should automatically be re-enabled if a call to BeginTransaction succeeds. Fixes #1687. Change-Id: I1bcab4531f869da59ee0d9ecec3ecc2c419f9f72 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49030 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com> Reviewed-by: Jean de Klerk <deklerk@google.com>

view details

Olav Loite

commit sha 9f47821ebd7e01e6ff3fa65f57dcd8afe59e2e57

spanner: Use Go 1.13 error-unwrapping Use Go 1.13 error-unwrapping and the equivalent xerrors features for builds on versions < 1.13. This makes it possible to use wrapped errors with the Spanner client. This change also deprecates the gRPC code in the Spanner error struct. All functions that need the gRPC code will extract it from the wrapped error instead of reading this field. Fixes #1223 and #1608. Updates #1310. Change-Id: Iea914adb5ca78af5e78cc948d8b1180eb3d647d2 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/48730 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Cody Oss

commit sha 6a30bb6cd65455238a649b970859a190b1d1411a

internal: fix header evaluation order This change is being made so headers will be evaulted at the end of the chain. Non-chained interceptors are always evaultated first. With some recent changes in `bigtable` headers are being applied via a ChainInterceptor. This change is being made so that the headers will be checked after they have been applied. Related to internal bug 146574757 Change-Id: I77e92b4d27f8200688194268ff437060ae3c0dac Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49890 Reviewed-by: Jean de Klerk <deklerk@google.com>

view details

Seth Hollyman

commit sha aa359b4e5dfed9c2131657742c50eeb655c21bad

bigquery: add Location to TableMetadata. Location is available on table metadata from the encapsulating dataset. It cannot be set as part of table creation, nor updated. Change-Id: I0e37e013ba7fb015e1104a6fd069b49735f717de Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49910 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Cody Oss <codyoss@google.com>

view details

Hengfeng Li

commit sha 6be7f45c00087b144c7c632cfe4146b51011b844

spanner: increase the timeout in session preparation Periodically, DeadlineExceeded errors are reported in logs. But there seems to be no affect on performance and the errors are unactionable. The current timeout is very short (1 second), so we should consider to increase it. Fixes #1657. Change-Id: Ie6624795dccfc58877bbb1b5d1d7b688ad346b42 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49830 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Knut Olav Løite <koloite@gmail.com>

view details

Yoshi Automation Bot

commit sha a6c41e21a7218087388a68482e6eb91ab9c6be93

all: auto-regenerate gapics This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, autotogen will update this CL with a newer dependency to the newer version of genproto and assign reviewers to this CL. If you have been assigned to review this CL, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - +2 and submit this CL if you believe it's ready to ship. Corresponding genproto PR: https://github.com/googleapis/go-genproto/pull/286 Change-Id: Icaed6f18ea4a568375a67685116979faff41d8f3 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49930 Reviewed-by: Jean de Klerk <deklerk@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Jean de Klerk

commit sha 6782d5b2dfb77806bf1721667ced46bbabe746e4

internal/gapicgen: check if there are changes to be committed Currently, genbot always assumes that BOTH genproto and gocloud have changes to be committed. That is frequently not true. This CL makes genbot check first, and adjust PR/CL messages accordingly. Change-Id: I054bbd711467eb0f43de90701c0bfd84f1e41e66 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49851 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>

view details

IlyaFaer

commit sha 257fe64ad194f18ac7b12f237574882d2a78293f

pubsub: expose a Subscription.ReceiveSettings.MaxExtensionPeriod setting Add new setting into Subscription.ReceiveSettings to provide an ability to set upper bound of pause before message redelivery. Closes #1154 Change-Id: If5456a7eefa9b800126018abee173f79a3e1503a Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/48570 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Kamal Aboul-Hosn <aboulhosn@google.com> Reviewed-by: Alex Hong <hongalex@google.com>

view details

Chris Cotter

commit sha bd2d9b3866a6fc16f2d580bf0a1c9455ab3aca8b

storage: Add archive storage class For this library, it only requires a doc update. Change-Id: Id2b3f357c6864935a21e70bab1cd199c84d74fbf Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/48330 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Frank Natividad <franknatividad@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

Eli Bendersky

commit sha b7a6a74659f7344ceec012409f21300a574bd5ec

storage: Fix typos in some field names and add tests Change-Id: Ibd115c166da4c8a304129cb99299aefd14bfe7e1 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49970 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Jean de Klerk <deklerk@google.com> Reviewed-by: Chris Cotter <cjcotter@google.com>

view details

Alex Hong

commit sha 14bad1c0c503488ab30c5bc18594c62e11576aeb

pubsub: remove experimental notice for subscription expiry and authenticated push Change-Id: I64e7e3f8460b43e1ced6f1d7c29ddde09835eb76 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49991 Reviewed-by: Jean de Klerk <deklerk@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Cody Oss <codyoss@google.com>

view details

Olav Loite

commit sha fde6a89a45c25badc16223408dcc632f28c236f1

spanner: Quieten log during tests Quieten logs during tests that are expected to log a number of error messages. Change-Id: I7ca66ba4beab1abfb98a5c9bc06485afde0e37dc Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49870 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Hengfeng Li <hengfeng@google.com>

view details

Alex Hong

commit sha 5dc25acbe8302402c7d201d5ad6f1ada6a5a63d1

pubsub: standardize publish delay threshold and max extension As an effort to standardize client library defaults across languages for Pub/Sub, we're making the following changes: DefaultReceiveSettings.MaxExtension: 10min -> 60min DefalutPublishSettings.DelayThreshold: 1ms -> 10ms These changes should not have an adverse effect on users as they have been the default for the Java and Python client libraries for a while now. Change-Id: I5a0a940f97bb68dee2f893e55dbfc56966d7cc93 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49992 Reviewed-by: Cody Oss <codyoss@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

Cody Oss

commit sha 381bc79f924614d4d079e9c7d2e3a74848d79a4f

internal: fix service config path for kms This file appears to have been moved in googleapis/googleapis Change-Id: I1709b378d61eda873cc0fe9456e1e40fa3f974d3 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/50070 Reviewed-by: Jean de Klerk <deklerk@google.com>

view details

push time in 2 months

issue commentenvoyproxy/envoy

Certificates provided inline to Envoy linger even when replaced

I was bitten by this over the Christmas break. We have an Envoy setup with SDS and some monitoring that watches days_until_first_cert_expiring to alert us if it accidentally gets too low. Our certs actually did get automatically rotated, but the Envoy instances held onto the old certs too long, kept the days_until_first_cert_expiring metric dropping, and triggering our alert.

(Normally our CD system regularly restarts everything, including Envoy, so we didn't notice until the break when the CD was paused.)

cetanu

comment created time in 2 months

push eventdsymonds/gocloud

Seth Vargo

commit sha 9d16f5d51a9ff98675f5190d3c844fc692cde50d

secretmanager: add IAM helper for generic resource IAM handle Change-Id: I11a7ba281a658bbc2eba91c89320d18f96adef0f Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49650 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Broadfoot <cbro@google.com>

view details

noahdietz

commit sha 31b7e5d8c19e4b919ad4ae0391a640565639c0a0

chore: remove firestore artman configs from gen These artman configs were accidentally replaced via my poorly rebased CL. These API versions are on microgen. Change-Id: I05b3564c881079ab0efd81fbb53a2163d37a70d4 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49710 Reviewed-by: Cody Oss <codyoss@google.com> Reviewed-by: kokoro <noreply+kokoro@google.com>

view details

noahdietz

commit sha 55786e458880422594b04c3cb752a45c957cbe38

chore: migrate two API versions to microgen * dialogflow v2 * securitycenter v1beta1 Bump autogen microgenerator version to v0.9.8 Diffs staged at: https://code-review.googlesource.com/c/gocloud/+/49730 Change-Id: I94eea15e28502c4f09f546ad308d9445516345c1 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49731 Reviewed-by: Chris Broadfoot <cbro@google.com> Reviewed-by: Jean de Klerk <deklerk@google.com>

view details

David Symonds

commit sha fa7f8df942e37538c9605f9e0905d498abccdd6e

spanner/spannertest: implement storing data into BYTES columns Retrieval already worked; storage was the missing piece. Change-Id: Ia310bd2641cf4e38002c6c4481711763a6d09a91

view details

push time in 2 months

create barnchdsymonds/gocloud

branch : master

created branch time in 2 months

created repositorydsymonds/gocloud

fork of https://code.googlesource.com/gocloud

created time in 2 months

issue commentgoogleapis/google-cloud-go

Spanner: Support Custom Types that point back to supported types

39a127f added support for decoding to custom types, but does encoding from custom types (the other direction) work? Should this bug remain open for that?

hostirosti

comment created time in 2 months

issue commentgoogleapis/google-cloud-go

spannertest: Roadmap

I think we can close this bug since we don't have a "roadmap" per se, but feel free to open issues for specific missing features that you want.

ericwenn

comment created time in 2 months

issue commentgoogleapis/google-cloud-go

OPTIONS in create table statement is not supported in cloud.google.com/go/spanner/spansql

Yep, @neguse's patch seems like it'll be fine.

geerttouquet

comment created time in 2 months

issue commentgolang/lint

Duplicate/same names in package

It's a common pattern in Go code I've seen to do that, where the exported name is perhaps an interface, or maybe it is a struct that contains the unexported type as a field, wrapping it in some way. I don't think golint should be flagging a situation like this.

boyan-soubachov

comment created time in 3 months

issue commentgoogleapis/google-cloud-go

spannertest: Roadmap

Go for it. New types are fairly straightforward.

ericwenn

comment created time in 3 months

issue commentgolang/lint

Exported func with unexported interface parameter is not linted

I think the implementation only looked at return values because it was easy to miss (e.g. callers writing x := ... get away with it) but arguments are a bit more of an immediate stumbling block so I don't think people write code like this much.

Seems reasonable to me to have golint flag this if this pattern happens in practice.

voithos

comment created time in 3 months

issue commentgoogleapis/google-cloud-go

spannertest: Roadmap

There's no specific plans with spannertest. It is extended as desired. Any particular missing features that matter to you most?

ericwenn

comment created time in 3 months

pull request commentsrc-d/go-git

plumbing/object: avoid O(N^2) string building when decoding commit me…

Hey, any chance this'll get merged soon, @mcuadros @smola ?

dsymonds

comment created time in 3 months

PR opened src-d/go-git

plumbing/object: avoid O(N^2) string building when decoding commit me…

…ssage

Most commits have relatively small messages, so this was never noticeable. However, there are some repositories that have semi-automated messages that can get very large (e.g. github.com/riscv/riscv-clang and its riscv-trunk branch), on the order of 109k lines. Changing from string += to using a bytes.Buffer reduces the time for Commit.Decode for that specific case from 35s to 74ms.

Signed-off-by: David Symonds dsymonds@golang.org

+5 -2

0 comment

1 changed file

pr created time in 3 months

push eventdsymonds/go-git

David Symonds

commit sha 0f811def103f8384a840f137ebabc152c90d5e89

plumbing/object: avoid O(N^2) string building when decoding commit message Most commits have relatively small messages, so this was never noticeable. However, there are some repositories that have semi-automated messages that can get very large (e.g. github.com/riscv/riscv-clang and its riscv-trunk branch), on the order of 109k lines. Changing from string += to using a bytes.Buffer reduces the time for Commit.Decode for that specific case from 35s to 74ms. Signed-off-by: David Symonds <dsymonds@golang.org>

view details

push time in 3 months

push eventdsymonds/go-git

Robin Wood

commit sha 70bff14e55cf4758bc8afcb230c244adbf26aa08

Spelling mistake Signed-off-by: Robin Wood <robin@digi.ninja>

view details

Nao YONASHIRO

commit sha 509b128eadef10d52c5cb73b6f56d426d677ae6a

feat: avoid ioutil.ReadAll on ApplyDelta Signed-off-by: Nao YONASHIRO <owan.orisano@gmail.com>

view details

Nao YONASHIRO

commit sha f2fd9299c7529ad22c05e9d17dc3ceadcf22490c

feat: avoid memory allocation on resolveDeltas Signed-off-by: Nao YONASHIRO <owan.orisano@gmail.com>

view details

Nao YONASHIRO

commit sha c1086eafdf45fe85ce0050890da6b42a146c7ddc

refactor: use bufPool Signed-off-by: Nao YONASHIRO <owan.orisano@gmail.com>

view details

Nao YONASHIRO

commit sha d456ce9c8190f0e9d785a1e5729c75bec5890e6f

feat: avoid memory allocation on ApplyDelta, PatchDelta Signed-off-by: Nao YONASHIRO <owan.orisano@gmail.com>

view details

knqyf263

commit sha 0373247790c1dd490f6756697c9d89bed9f7c4bb

Add assertion for unhandled error in TestLogFile Signed-off-by: knqyf263 <knqyf263@gmail.com>

view details

knqyf263

commit sha d7c00b034ff5ce038c168ab16a943cc5f55aac3c

Handle io.EOF error in commitFileIter.ForEach Signed-off-by: knqyf263 <knqyf263@gmail.com>

view details

knqyf263

commit sha d1f089794aff17a78d5487d5e681d63fba17aad1

Add TestLogFileWithError for coverage Signed-off-by: knqyf263 <knqyf263@gmail.com>

view details

knqyf263

commit sha 1124ff89a63af3bae0c64967a5dac129feac7d0c

Add -coverpkg to fix test coverage Signed-off-by: knqyf263 <knqyf263@gmail.com>

view details

knqyf263

commit sha a2af865f9dbf292a9804c67abc2727551f7954dd

Remove else Signed-off-by: knqyf263 <knqyf263@gmail.com>

view details

Máximo Cuadros

commit sha 6f354807f63e3479e41e56d72866291eeac9251e

Merge pull request #1204 from knqyf263/fix/handle_eof_err Handle EOF error in commitFileIter.ForEach

view details

Máximo Cuadros

commit sha a0c8105a91910a022fe2b8d154f0a9ee777f7310

Merge pull request #1205 from knqyf263/fix/test_coverage Add -coverpkg to fix test coverage

view details

knqyf263

commit sha c7fc75ef6ebd7127e0918b1669d336ba39844201

Add limiting options to git log Signed-off-by: knqyf263 <knqyf263@gmail.com>

view details

Máximo Cuadros

commit sha 2661d86e26b9adb99ff37a82d6984030000639dd

Merge pull request #1206 from knqyf263/feature/add_log_limiting Add limiting options to git log

view details

Theodore Keloglou

commit sha e79f5331726d29c2f1213ffd942d2670d09cb40f

examples: Fix typo on pull example Signed-off-by: Theodore Keloglou <theodorekeloglou@gmail.com>

view details

Máximo Cuadros

commit sha 9feb9fe755bfd17e31c3949c01d187179103249b

Merge pull request #1208 from sirodoht/fix-example-pull Fix typo on pull example

view details

Máximo Cuadros

commit sha 883c226587bef98b0e30cd9b0d424f4cb08ebbec

Merge pull request #1180 from orisano/feat-improve-patch-delta feat: improve patch delta performance

view details

Máximo Cuadros

commit sha 3e42b8cd3f20dad073db846348418aa218c7d23c

Merge pull request #1195 from digininja/master Spelling mistake

view details

Chief

commit sha db0e226d48285a0ae8cda7db05d2ca20d9000dc6

Add numeric username support for SSH urls. Signed-off-by: Chief <admin@117.sh>

view details

Chief

commit sha 80d88d96cbbbef05054d53745b9488d864859fdd

Add tests for SSH url matching. Signed-off-by: Chief <admin@117.sh>

view details

push time in 3 months

push eventdsymonds/terraform-provider-kubernetes

Alex Somesan

commit sha ade5df62a862ec551bcf4520e99f0f655ba4361c

Adapt client calls and imports for client-go v12 (#663) * go mod tidy * Re-vendor modules * Adapt client package imports and usage for client-go v12

view details

renovate[bot]

commit sha 20574d206ba4f833501985c1a8404c0baaeb23bb

Update k8s.io/kube-aggregator commit hash to aa872b0 (#638) * Update k8s.io/kube-aggregator commit hash to aa872b0 * go mod tidy * Re-vendor modules

view details

Patrick Decat

commit sha 38cd40baa7389ea9d216b1261a61e038dfa8b713

Add support for kubernetes_api_service.spec.service.port (#665)

view details

jrlost

commit sha 971c21ee56509e9015ebf1bb9b54f114f41a45ea

Updated host_alias property name to host_aliases (#670) https://github.com/terraform-providers/terraform-provider-kubernetes/pull/367/files Added this support, currently it appears that the property name is `host_aliases` and not `host_alias`

view details

Patrick Decat

commit sha 56b543613dbbf4bb0b079349f57ffe2ea12fc243

Do not set default namespace for replication controller and deployment pod templates (#275)

view details

Jordan Pittier

commit sha 27d76adf7491f601d7722e0badbb8d6a4f9659ae

Add mount_propagation to volume mount (#552) Mount propagation allows for sharing volumes mounted by a Container to other Containers in the same Pod, or even to other Pods on the same node. See [1] MountPropagation has been GA since K8s 1.14. [1] https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation

view details

renovate[bot]

commit sha c6b206479320a2f7c64a607035c5a5ce797e8792

Update module hashicorp/terraform-plugin-sdk to v1.3.0 (#677)

view details

Alex Somesan

commit sha c7d0e315163892f0e0c120e68151dba2be957b28

go mod tidy

view details

Alex Somesan

commit sha aea0c9a279b858191441227d0d2f7bcb1177144a

go mod vendor

view details

Michael Barrientos

commit sha 4e93e5ea4a3e4f927e41698d63eb8d9e90ac263e

Add PodDisruptionBudget (closes #320) (#338) * Add support for PodDisruptionBudget

view details

Alex Somesan

commit sha 7ffc4da5c9a6ccc11c7b668c691e411368347b51

Prepare changelog for v1.9.1

view details

Alex Somesan

commit sha ff89c4e870cd66a54492f2b9c498a69e13606990

Fix changelog

view details

tf-release-bot

commit sha 126970365114b91ed5640cb5a07df1a816e4005e

v1.10.0

view details

tf-release-bot

commit sha 026e3f687494cc1f4f6ab4c68c3ed86b16f163a5

Cleanup after v1.10.0 release

view details

David Symonds

commit sha 542bebf9407ccfc094a6cc084c6739e5f466feab

go.mod: patch up to build under Go 1.13 This shouldn't matter if https://github.com/terraform-providers/terraform-provider-kubernetes/pull/609 gets merged.

view details

David Symonds

commit sha fd394680799b54de2b69e64dc894fefbf8a8903b

Don't wait for Deployment updates to fully roll out. This can take a long time, and we don't care to wait.

view details

push time in 3 months

issue commentterraform-providers/terraform-provider-kubernetes

Pod PriorityClassName attribute not supported

Can you try with the v1.10.0 release? I added support for this in #646.

justinas-b

comment created time in 3 months

issue commentgolang/geo

polylines match

Note that a polyline is a sequence of edges, but your example is only a pair of vectors.

You can take the dot product of two vectors to get the angle between them. The r3.Vector type has a Dot method for that. See https://en.wikipedia.org/wiki/Dot_product for more detail.

nakulmandal

comment created time in 4 months

issue commentgolang/geo

polylines match

Can you be more specific?

nakulmandal

comment created time in 4 months

push eventdsymonds/terraform-provider-kubernetes

David Symonds

commit sha 737d309ccea16c9f36fbcdf7c3d7734560c1f90e

go.mod: patch up to build under Go 1.13 This shouldn't matter if https://github.com/terraform-providers/terraform-provider-kubernetes/pull/609 gets merged.

view details

David Symonds

commit sha 6f2aff9ee45b0301aa11877f3464529d12ff5430

Don't wait for Deployment updates to fully roll out. This can take a long time, and we don't care to wait.

view details

push time in 4 months

push eventdsymonds/terraform-provider-kubernetes

renovate[bot]

commit sha de83f6b015e30f0896e2306311715dbd6de926d3

Update module hashicorp/terraform-plugin-sdk to v1.2.0 (#659)

view details

renovate[bot]

commit sha 02715b290ec00eddad3ba037797958d8527c4b11

Update module k8s.io/client-go to v12 (#648)

view details

David Symonds

commit sha a2ee84d51115fc0f3a365588754c917dd7c1d323

Support priorityClassName in PodSpec. (#646) This adds support for this field in PodSpec, part of Deployments, StatefulSets, CronJobs and anything else that embeds a PodSpec. The PriorityClass resource was added in #495. Fixes #506.

view details

David Symonds

commit sha 5f11b1221186d08147db07be3332f53e037dfabd

go.mod: patch up to build under Go 1.13 This shouldn't matter if https://github.com/terraform-providers/terraform-provider-kubernetes/pull/609 gets merged.

view details

David Symonds

commit sha 9255737931f22fc7174c39f3ea8c004018331645

Don't wait for Deployment updates to fully roll out. This can take a long time, and we don't care to wait.

view details

push time in 4 months

delete branch dsymonds/terraform-provider-kubernetes

delete branch : up

delete time in 4 months

pull request commentterraform-providers/terraform-provider-kubernetes

Support priorityClassName in PodSpec.

Ah, right, sorry. I didn't realise it was duplicated all over the place. Might be nice for those docs to be auto-generated.

PTAL.

dsymonds

comment created time in 4 months

push eventdsymonds/terraform-provider-kubernetes

David Symonds

commit sha 060926bd354bcd9e71cff349324193160424fa19

Support priorityClassName in PodSpec. This adds support for this field in PodSpec, part of Deployments, StatefulSets, CronJobs and anything else that embeds a PodSpec. The PriorityClass resource was added in #495. Fixes #506.

view details

push time in 4 months

pull request commentterraform-providers/terraform-provider-kubernetes

Support priorityClassName in PodSpec.

Sure. Docs update.

dsymonds

comment created time in 4 months

push eventdsymonds/terraform-provider-kubernetes

renovate[bot]

commit sha de83f6b015e30f0896e2306311715dbd6de926d3

Update module hashicorp/terraform-plugin-sdk to v1.2.0 (#659)

view details

renovate[bot]

commit sha 02715b290ec00eddad3ba037797958d8527c4b11

Update module k8s.io/client-go to v12 (#648)

view details

David Symonds

commit sha b7dfa99e0d8956738245f762d7d6d088eb2026ce

Support priorityClassName in PodSpec. This adds support for this field in PodSpec, part of Deployments, StatefulSets, CronJobs and anything else that embeds a PodSpec. The PriorityClass resource was added in #495. Fixes #506.

view details

push time in 4 months

push eventdsymonds/terraform-provider-kubernetes

Alex Somesan

commit sha 3871cf1614d066c12c3ce601b54a9ee2bf8ef910

Go 1.12.x in Travis

view details

Qingping Hou

commit sha 341f072fc3233f5942959ba49e143c39a3099874

set cascading delete policy to default delete option (#643)

view details

Radek Simko

commit sha 9b4bc876e79665ef1307dd37e49619ce637de136

deps: terraform-provider-aws@v2.32.0+incompatible

view details

Radek Simko

commit sha 9a7bd2f37f056eee84b85193563b6aab11b2248b

deps: terraform-provider-google@v2.17.0+incompatible

view details

Radek Simko

commit sha 2bfe98978cb84655dc3080dac8602bad3fac27ae

Migrate to SDK 1.1.1

view details

Radek Simko

commit sha 2c80accb5635246099d383af6cfb9f2811b548e2

Merge pull request #651 from terraform-providers/provider-bumps provider: Migrate to standalone plugin SDK v1.1.1

view details

David Symonds

commit sha aa1ff8448d952b413e126aadc970db7fc0f6a96d

go.mod: patch up to build under Go 1.13 This shouldn't matter if https://github.com/terraform-providers/terraform-provider-kubernetes/pull/609 gets merged.

view details

David Symonds

commit sha 5815af25461c333c887746c41053e0ae2fd81fa1

Don't wait for Deployment updates to fully roll out. This can take a long time, and we don't care to wait.

view details

David Symonds

commit sha ae1547712b08b35af0f3fbd35eeb2a4afc317f2f

Support priorityClassName in PodSpec. This adds support for this field in PodSpec, part of Deployments, StatefulSets, CronJobs and anything else that embeds a PodSpec. The PriorityClass resource was added in #495. Fixes #506.

view details

push time in 4 months

push eventdsymonds/terraform-provider-kubernetes

Alex Somesan

commit sha 3871cf1614d066c12c3ce601b54a9ee2bf8ef910

Go 1.12.x in Travis

view details

Qingping Hou

commit sha 341f072fc3233f5942959ba49e143c39a3099874

set cascading delete policy to default delete option (#643)

view details

Radek Simko

commit sha 9b4bc876e79665ef1307dd37e49619ce637de136

deps: terraform-provider-aws@v2.32.0+incompatible

view details

Radek Simko

commit sha 9a7bd2f37f056eee84b85193563b6aab11b2248b

deps: terraform-provider-google@v2.17.0+incompatible

view details

Radek Simko

commit sha 2bfe98978cb84655dc3080dac8602bad3fac27ae

Migrate to SDK 1.1.1

view details

Radek Simko

commit sha 2c80accb5635246099d383af6cfb9f2811b548e2

Merge pull request #651 from terraform-providers/provider-bumps provider: Migrate to standalone plugin SDK v1.1.1

view details

David Symonds

commit sha 2da65c8974118702e052767bfe4c3682c8631665

Support priorityClassName in PodSpec. This adds support for this field in PodSpec, part of Deployments, StatefulSets, CronJobs and anything else that embeds a PodSpec. The PriorityClass resource was added in #495. Fixes #506.

view details

push time in 4 months

pull request commentterraform-providers/terraform-provider-kubernetes

Support priorityClassName in PodSpec.

Hey @alexsomesan, can we get this change in for the next release? It's the obvious complement to #495.

dsymonds

comment created time in 4 months

push eventgoogle/licensecheck

David Symonds

commit sha 4292f3df2c724e76376da4ebb93e21b8e02fe7e6

Add ECL-2.0. This is a modified license based on the Apache 2.0 license. Downloaded from https://spdx.org/licenses/ECL-2.0.txt.

view details

push time in 4 months

PR merged google/licensecheck

Add ECL-2.0.

This is a modified license based on the Apache 2.0 license.

Downloaded from https://spdx.org/licenses/ECL-2.0.txt.

+197 -0

0 comment

2 changed files

dsymonds

pr closed time in 4 months

PR opened google/licensecheck

Add ECL-2.0.

This is a modified license based on the Apache 2.0 license.

Downloaded from https://spdx.org/licenses/ECL-2.0.txt.

+197 -0

0 comment

2 changed files

pr created time in 4 months

push eventdsymonds/licensecheck

David Symonds

commit sha 088e6c184c072e1b89dc42a392345aa4a3075987

Add ECL-2.0. This is a modified license based on the Apache 2.0 license. Downloaded from https://spdx.org/licenses/ECL-2.0.txt.

view details

push time in 4 months

pull request commentdgraph-io/dgraph

Add "set -e" to test script.

FYI, using an explicit set -e inside the script is generally considered better practice than relying on the shebang, since the latter is only applied when the script is invoked directly (e.g. ./foo.sh) but it is ignored when run by passing it to a shell as an argument (bash foo.sh). That can happen in a bunch of places, particularly in automation.

martinmr

comment created time in 4 months

PR opened terraform-providers/terraform-provider-kubernetes

Support priorityClassName in PodSpec.

This adds support for this field in PodSpec, part of Deployments, StatefulSets, CronJobs and anything else that embeds a PodSpec.

The PriorityClass resource was added in #495.

Fixes #506.

+14 -0

0 comment

2 changed files

pr created time in 4 months

create barnchdsymonds/terraform-provider-kubernetes

branch : up

created branch time in 4 months

push eventdsymonds/terraform-provider-kubernetes

David Symonds

commit sha 7194ca2021565954170d9feffb67e889b9db8fee

Support priorityClassName in PodSpec. This adds support for this field in PodSpec, part of Deployments, StatefulSets, CronJobs and anything else that embeds a PodSpec. The PriorityClass resource was added in #495. Fixes #506.

view details

push time in 4 months

push eventdsymonds/go-git

Alexandr Krylovskiy

commit sha ba267cb676e2ab06fc57e1612f7534d1d8501957

references: sort: compare author timestamps when commit timestamps are equal. Fixes #725 Signed-off-by: Alexandr Krylovskiy <alexandr.krylovskiy@gmail.com>

view details

Dustin Frisch

commit sha 2eb97fb44707bc122c53bf2ad8eaf24ad8d679f4

Use remote name in fetch while clone Fixes #827 Signed-off-by: Dustin Frisch <fooker@lab.sh>

view details

Mike Lundy

commit sha 5dd9376f01fd2c397607ac333683c0bd676bed6a

Teach ResolveRevision how to look up annotated tags Signed-off-by: Mike Lundy <mike@fluffypenguin.org>

view details

Morgan

commit sha 960fe7b668c7a0ebbd75f8898c95d5c4bdedf1f3

Fix documentation for Notes It previously said that it returned all references that are branches, but that's not true. Signed-off-by: Morgan Bazalgette <the@howl.moe>

view details

Mark Bartel

commit sha e1c269422ab209443b80f05095627c2795e32fd5

worktree: add test for correct tree sorting (issue #881) Signed-off-by: Mark Bartel <github@spottybenny.ca>

view details

Mark Bartel

commit sha 7ff71b5a66eea98983c610d33523041a5a829e2f

worktree: sort the tree object. Fixes #881 Signed-off-by: Mark Bartel <github@spottybenny.ca>

view details

Mark Bartel

commit sha f0c4318e7b8d5cbf91723c71a4ba20d1bd0cfaf5

worktree: address PR comments: sort imports appropriately Signed-off-by: Mark Bartel <github@spottybenny.ca>

view details

James Ravn

commit sha b304997a387a5106321fe87069a6f136d9fbd1f6

plumbing: object, expose ErrEntryNotFound in FindEntry. Fixes #883 FindEntry will return ErrDirNotFound if the directory doesn't exist. But it doesn't return a public error if the entry itself is missing. This exposes the internal error ErrEntryNotFound, so users can programmatically check for this condition. Signed-off-by: James Ravn <james@r-vn.org>

view details

Jerome Doucet

commit sha 54d8c38fd63feefe6c25c1ac2945a6fc0bc7f16a

plumbing/transport/internal: common, add support of Gogs for ErrRepositoryNotFound, avoiding to get an 'unknown error: '. Add some tests for existing supported services (github, gitlab, etc...) too. Signed-off-by: Jerome Doucet <jerdct@gmail.com>

view details

Máximo Cuadros

commit sha 400b083e49c5328776359e0df495f98b01efbf63

Merge pull request #888 from jeromedoucet/tech/add_gog_repository_not_found plumbing/transport/internal: common, support Gogs for ErrRepositoryNotFound

view details

Máximo Cuadros

commit sha 5b1d5370c36994851da002f76ae7cbd3b7bc9221

Merge pull request #885 from jsravn/findentry-return-file-not-found plumbing: object, return ErrFileNotFound in FindEntry. Fixes #883

view details

Máximo Cuadros

commit sha 9f00789688d26191a987fdec8bc2678362ec4453

Merge pull request #862 from thehowl/patch-1 git: fix documentation for Notes

view details

Javi Fontan

commit sha 8df413fe09e6cb2069a76b6df6715d0e610c8458

plumbing/object: fix pgp signature encoder/decoder The way of reading pgp signatures was searching for pgp begin line in the header. This caused problems when this string appeared and was not part of the signature. For example if it appears in the message as an example or is part of the author name the decoder starts treating it as a signature. In this state the code was not able to notice then the header ended so it entered in an infinite loop searching for pgp end string. Now it uses the same method as original git. Searches for gpgsig section in header and starts getting all lines until the next part. In encoder the string used to add signatures was incorrect. It is now changed to the proper "gpgsig" string instead of "pgpsig". Signed-off-by: Javi Fontan <jfontan@gmail.com>

view details

Miguel Molina

commit sha 009f1069a1248c1e9189a9e4c342f6d017156ec4

plumbing/format/idxfile: add new Index and MemoryIndex Signed-off-by: Miguel Molina <miguel@erizocosmi.co>

view details

Miguel Molina

commit sha a8ff3e599b3ee998a8b8626cd9fe9fa68490d354

Merge pull request #896 from erizocosmico/feature/new-index-decoder plumbing/format/idxfile: add new Index and MemoryIndex

view details

Javi Fontan

commit sha da5677f5ba3970d585d5955b15a6a1c3c262c07b

plumbing/packfile: add new packfile parser Signed-off-by: Javi Fontan <jfontan@gmail.com>

view details

Javi Fontan

commit sha ce91d71f96097ede2bb77d2af444aee6fff73183

plumbing/packfile: disable lookup by offset In one case it disables the cache and the other disables lookup when the scanner is not seekable. Could be added back later. Signed-off-by: Javi Fontan <jfontan@gmail.com>

view details

Javi Fontan

commit sha 355cfc3df3a64d1bd438e0e17e1c4ba21350badf

plumbing: idxfile, add idxfile.Writer with Observer interface It's still not complete: * 64 bit offsets * IdxChecksum Signed-off-by: Javi Fontan <jfontan@gmail.com>

view details

Javi Fontan

commit sha 4e3765aef344eae2fbcd977fefd66b6571638d59

plumbing/idxfile: use Entry to hold object data Signed-off-by: Javi Fontan <jfontan@gmail.com>

view details

Javi Fontan

commit sha 65e8359db00ae79838d19e19f69594f6a262c3d4

plumbing/idxfile: support offset64 generating indexes Signed-off-by: Javi Fontan <jfontan@gmail.com>

view details

push time in 4 months

push eventdsymonds/terraform-provider-kubernetes

David Symonds

commit sha 611292fcff9cfcf701bfa558a180f98327a12907

Don't wait for Deployment updates to fully roll out. This can take a long time, and we don't care to wait.

view details

push time in 4 months

push eventdsymonds/terraform-provider-kubernetes

David Symonds

commit sha 78bf6516e1985a2a7613e335f4fdef10dc52240f

go.mod: patch up to build under Go 1.13 This shouldn't matter if https://github.com/terraform-providers/terraform-provider-kubernetes/pull/609 gets merged.

view details

push time in 4 months

push eventdsymonds/terraform-provider-kubernetes

Patrick Decat

commit sha db2d274250d5e5bf4ea32b8b4a879d2c5e1daee3

Enable HTTP requests/responses tracing in debug mode (#630)

view details

Radek Simko

commit sha 8ab82ec0a8b722f779763e6c076411c46538b7c3

Bump random provider to v2.2.1 (#634)

view details

Cory Lucas

commit sha 97cdc9a2e870687b9e50c1e289e3034fbaa33aff

Allow 0 for backoff_limit on kubernetes_job (#632)

view details

Juraj Seffer

commit sha c685bc5afd6415ebe3c105d62b2961cb10b93acc

Updated Kubernetes links (#626) * Updated Kubernetes links * Updated all broken and specific commit links to point to master branch

view details

Bartosz Janda

commit sha 7de26850accde57100a8696a1577f1451d2ebff6

Parametrize all timeouts (#607)

view details

renovate[bot]

commit sha 8be0952f1882d7d6ec13bd0e57ee75cab0587953

Update module gogo/protobuf to v1.3.0 (#628)

view details

Qingping Hou

commit sha 399b7736e5bec15a9c82d0d7707065ecdddcc5b0

set option to cascade delete job resources (#635) This is also the default behavior from kubectl.

view details

renovate[bot]

commit sha ab8ca826f7d9f938f72dd5466f35678af1244623

Update module hashicorp/terraform to v0.12.10 (#639)

view details

renovate[bot]

commit sha ac186f1404b44828b1388ee35b7e985a5461086f

Update module google/go-cmp to v0.3.1 (#629)

view details

Ian L

commit sha e8360394f5d414f7eaf029de3ebed4bd8261249d

Support in-cluster configuration with service accounts (#497) Prior to this commit, the provider supports authenticating through a local `kubeconfig` or through various configuration provided directly to the provider or from the environment. The provider however, did not authenticate using a service account when running inside a Kubernetes pod. This commit provides support for loading in-cluster configuration so that the provider can be used inside a Kubernetes pod (with a service account) without much additional configuration. The use-case for this is running Terraform via Atlantis inside a Kubernetes pod. But, outside of Atlantis, there may be cases where we want to run some Terraform automation inside a pod (e.g. GitLab runner).

view details

Alex Somesan

commit sha 120501daf33c9801b2a00ae889662d967f1a4685

Bump Go to 1.12.10 and mod tidy.

view details

push time in 4 months

PR opened google/licensecheck

Reviewers
Add LGPL-2.0.

This is an older version of the LGPL, used in the wild. Without this an LGPL-2.0 license file gets detected as GPL2.

+981 -0

0 comment

3 changed files

pr created time in 5 months

push eventdsymonds/licensecheck

David Symonds

commit sha 4327c9918ff65e6ede7434ea3ce8e5852dbaf9b6

Add LGPL-2.0. This is an older version of the LGPL, used in the wild. Without this an LGPL-2.0 license file gets detected as GPL2.

view details

push time in 5 months

fork dsymonds/licensecheck

The licensecheck package classifies license files and heuristically determines how well they correspond to known open source licenses.

fork in 5 months

issue commentterraform-providers/terraform-provider-kubernetes

kubernetes_cron_job recreates resources on every execution

Hmmm. I traced a bunch of it back to 22f458f2e, but I don't understand why that added ForceNew: true to a bunch of the Job schema structs. @alexsomesan, can you explain what criteria you used there? Near as I can tell, Kubernetes will quite happily let you patch most parts of a CronJob's spec, including the job template.

caquino

comment created time in 5 months

issue commentterraform-providers/terraform-provider-kubernetes

kubernetes_cron_job recreates resources on every execution

I've tripped over this, but with the args for a container in the CronJob's job spec, so it looks like it isn't fully fixed. This is using v1.9.0 of the provider.

caquino

comment created time in 5 months

issue commentterraform-providers/terraform-provider-kubernetes

Wait for StatefulSet rollout status

Related, I'd like a way to avoid waiting for rollouts. I have some Deployments and StatefulSets that can take 30m to fully update, but I don't want terraform apply to wait that long. In other words, I'd like either a per-resource property or some provider-wide option to skip the whole waitForDeploymentReplicasFunc step, and exit with the status of the Patch.

yaman

comment created time in 5 months

issue commentgolang/go

net/http: support HTTP/3

Cloudflare now supports HTTP/3, and Chrome and Firefox will shortly start supporting it: https://blog.cloudflare.com/http3-the-past-present-and-future/

johanbrandhorst

comment created time in 5 months

push eventgolang/geo

Robert Snedegar

commit sha 660d2a73bbbccd0017149b89e67e8c450e2ee3a5

s2: Fix typo in CellID.Decode doc comment. Fixes #54. Signed-off-by: David Symonds <dsymonds@golang.org>

view details

David Symonds

commit sha 164346a1a83546b14122c0af990a49e08bb17d10

s2: Use binary search in ShapeIndexIterator.seek.

view details

David Symonds

commit sha de8c27bb4edd1d1d23a3660cee3b17ae8d243176

s2: Fix doc comment on PointVector.

view details

Robert Snedegar

commit sha 602b39b5392cb55d0370933f73b008a517536975

s2: Add EdgeQuery and necessary dependencies. This also includes the methods to use it as ClosestEdgeQuery and FurthestEdgeQuery. Signed-off-by: David Symonds <dsymonds@golang.org>

view details

Robert Snedegar

commit sha f02de5772c04c83588cb3a2f69a62c0b54149e47

s2: Add benchmark scaffolding for EdgeQuery. Comparing the Go version to the C++ version, the performance pattern matches the level pretty well as the size scales. Signed-off-by: David Symonds <dsymonds@golang.org>

view details

David Symonds

commit sha 5b978397cfecc7280e598e9ac5854e9534b0918b

s1: Fix comment typo. Fixes #55.

view details

push time in 5 months

issue closedgolang/geo

s1 documentation correction

https://github.com/golang/geo/blob/f41920e961ce9e1c93be256555de632767c35d12/s1/angle.go#L25

E7 of 3.1 Degree is 31000000, not 310000000

closed time in 5 months

djadala

PR closed golang/geo

Update cellid.go

Hello!

This PR fixes a minor typo in documentation for CellID.Decode. Previously it said that the function is used to encode cell IDs.

Thank you and hope this is helpful!

+1 -1

4 comments

1 changed file

rbrtmrtn

pr closed time in 5 months

pull request commentkubernetes/kubernetes

Fix description of diff flags

/assign @liggitt

Let's try someone else who might be a bit more active.

dsymonds

comment created time in 5 months

more