profile
viewpoint
Drummond Dawson drumonii Virginia, U.S.A.

drumonii/SpringBootTwoDataSources 9

Spring Boot with multiple (two) DataSources and JPA

drumonii/angular 0

One framework. Mobile & desktop.

drumonii/angular-cli 0

CLI tool for Angular

drumonii/assertj-core 0

AssertJ is a library providing easy to use rich typed assertions

drumonii/clarity 0

UX guidelines, HTML/CSS framework, and Angular components working together to craft exceptional experiences

drumonii/components 0

Component infrastructure and Material Design components for Angular

drumonii/easytable 0

Small table drawing library building upon Apache PDFBox

drumonii/h2database 0

H2 is an embeddable RDBMS written in Java.

drumonii/LeagueTrollBuild 0

League of Legends Build Randomizer

drumonii/nebular 0

:boom: Customizable Angular UI Library based on Eva Design System :new_moon_with_face::sparkles:Dark Mode

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 6ada8762b79048b9e29a4c0549d83aeec0f2aa76

Upgrade Clarity to 2.3.8

view details

drumonii

commit sha e43dbd2e6a4abe64c99a8ddcb2fe0f76f3d0ba5c

Supply eTag with ResponseEntity Instead of using a ShallowEtagHeaderFilter, simplify setting the etag with supplying it directly in the ResponseEntity builder.

view details

push time in 8 hours

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 20a575eb9d0eb3fc17fd625f0e54fdccbfa6538e

Apply security config to URLs that start with /admin Web security is applicable to the only admin portion and therefore should be limited to /admin URLs using the antMatcher.

view details

push time in a day

push eventdrumonii/SpringBootTwoDataSources

drumonii

commit sha a3203a945d018a707b16dc876136ae41329f4ed2

Convert repository tests to nested and parameterized

view details

push time in 12 days

push eventdrumonii/SpringBootTwoDataSources

drumonii

commit sha 1dda2546db33542668f4a29eecc4e400e5e84e84

Upgrade Angular to 9.0.1 and cli to 9.0.2

view details

drumonii

commit sha 3bfa168c6643c2950973a84985388f2a8037676f

Upgrade Angular material to 9.0.0

view details

drumonii

commit sha a89e65cc968448abd1a36e4f27c2ef80629d3f1f

Upgrade protractor to 5.4.3 for Chrome 80 support

view details

push time in 14 days

PR opened akveo/nebular

fix(docs): fix typo: librariws -> libraries

Fixes trivial typo in what-is-nebular.md: librariws -> libraries

Short description of what this resolves:

Resolves #2164

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchdrumonii/nebular

branch : fix-typo-in-what-is-nebular

created branch time in a month

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 1fadaa75d44f51386a157364883d22ce18febe74

Upgrade Angular cli to 8.3.24

view details

push time in a month

push eventdrumonii/SpringBootTwoDataSources

drumonii

commit sha 405ceb958c5a9176d9882b6b34b14853af9fa878

Upgrade Spring Boot to 2.2.4

view details

drumonii

commit sha 3d8f7ec626d8d04459e72688e41337e299f465dc

Upgrade Gradle to 5.6.4

view details

drumonii

commit sha 63a23fb42571cd3de429cda7d118aa3cbe9a6968

Merge branch 'backend-only' into with-frontend

view details

push time in a month

push eventdrumonii/SpringBootTwoDataSources

drumonii

commit sha 405ceb958c5a9176d9882b6b34b14853af9fa878

Upgrade Spring Boot to 2.2.4

view details

drumonii

commit sha 3d8f7ec626d8d04459e72688e41337e299f465dc

Upgrade Gradle to 5.6.4

view details

push time in a month

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha aa2846ffa9eb5f37f158addd9790481c9fa8f419

Upgrade Clarity to 2.3.6

view details

push time in a month

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha c7b860a55f445480003b09d8b18c72fc84bf63f0

Cache npmBuild task Avoid re-running npm run build-all if src files, node_modules, or package.json files are unchanged.

view details

drumonii

commit sha c1159d4138c65a4aebcc99e8d749dea399887924

Use archiveVersion instead of deprecated version

view details

push time in a month

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha f7dd6bdb978f6296f7873866204c879848472b8d

Upgrade Spring Boot to 2.2.4

view details

drumonii

commit sha b5f2bd9d33860000245ef6dc58f65b5a94eacd2f

Upgrade Gradle to 5.6.4

view details

push time in a month

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 7851a3c0ada3a7034ca9988bcc2ef734b068d3ef

Add e2e login page scenario Ensures that the admin login page is not able to be accessed when the admin is already logged in.

view details

push time in a month

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 29137519e5e318cc89cf10e90b59aff0c1626f08

Improve Champions filters e2e tests

view details

drumonii

commit sha c3eb1b163e4d93a1ea9f915cbbc92ecb65c52848

Upgrade Angular cli to 8.3.23

view details

drumonii

commit sha 880e6b74e734ab1ff12a6ab8394c598d91f56ded

Upgrade Clarity to 2.3.5

view details

drumonii

commit sha 361d32591f15191f027963428131deabf60fea90

toBe(true) -> toBeTrue(), toBe(false) -> toBeFalse()

view details

drumonii

commit sha 7e545ff7cf571f8c9271c1a75e6e711c08c3c9dc

e2e: toBe(true) -> toBeTruthy(), toBe(false) -> toBeFalsy()

view details

push time in a month

create barnchdrumonii/LeagueTrollBuild

branch : next

created branch time in a month

push eventdrumonii/SpringBootTwoDataSources

drumonii

commit sha cd80479ebd41bb7c702e56b2cd84a33809a48320

Upgrade Spring Boot to 2.2.2

view details

drumonii

commit sha 6182d92661c26d103ec5ecff8fddecd779b63dfc

Merge branch 'backend-only' into with-frontend

view details

push time in 3 months

push eventdrumonii/SpringBootTwoDataSources

drumonii

commit sha cd80479ebd41bb7c702e56b2cd84a33809a48320

Upgrade Spring Boot to 2.2.2

view details

push time in 3 months

created tagdrumonii/LeagueTrollBuild

tag2.5.17

League of Legends Build Randomizer

created time in 3 months

release drumonii/LeagueTrollBuild

2.5.17

released time in 3 months

delete branch drumonii/LeagueTrollBuild

delete branch : next

delete time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha b57a66545c645b9e8cb4c77631ee0fab73796200

Next snapshot version

view details

drumonii

commit sha 60e05dac29e26e4aac0e69e3ff09020f0b23000a

Add missing actuator endpoint tests from grouping metrics

view details

drumonii

commit sha 14acda5e57f49cac84e84e11c5b7f3a41be8afb9

Center Champion content on all viewpoints

view details

drumonii

commit sha 570adbd422e3a06c0b01fc944241215af0c28e3b

Move node scripts to their appropriate scripts folder

view details

drumonii

commit sha 5ff4dac7e6fe1390bbfd0d6b6a66d75e31bfc35b

Improve ltb forms styling to match those of ltb buttons

view details

drumonii

commit sha 3f105565f3f0c065e3d9529b20d5142fa9bc200f

Apply border bottom to ltb headers as .ltb-title

view details

drumonii

commit sha a0fa0fe15c0421967ecfa5abbdae4692dae0afad

Upgrade Nebular to 4.6.0

view details

drumonii

commit sha 33082b8a593811b7add08159cf9824c73f913cbc

Update test JSON files to 9.23.1

view details

drumonii

commit sha 0b975b52f52a03702fcd9e315cc87269b2c5c58f

Remove usage of Face of the Mountain item It has been removed.

view details

drumonii

commit sha dadee42bb4e554b35b7e7665b27a879b609f0eee

Fix trinkets for summoners rift fetching sellable items

view details

drumonii

commit sha 7c3621a2388e649b0f719efa67e462735a00b345

Nested security configs can set proxyBeanMethods as true

view details

drumonii

commit sha be83139c6c99cb772a23a61922235e87135f1c3b

Polish ItemsRepositoryTest

view details

drumonii

commit sha 076adf511076e834e9ffa7d2823aeb52d1cab2ec

footer component change detection can be OnPush

view details

drumonii

commit sha ce43d097553bac872d8452641a731ea88c741174

Upgrade Clarity to 2.3.3

view details

drumonii

commit sha 4b41be6c425e198b90a910b1ffd5fb76ec7b0d15

Upgrade Angular cli to 8.3.20

view details

drumonii

commit sha d93da897688362fd0a32f4a8697688e04ff392b9

Use gradle-node-plugin

view details

drumonii

commit sha caeb253b08a2d88c87fc42bc16e888cce9a14b3b

Upgrade Spring Boot to 2.2.2

view details

drumonii

commit sha 0f8e83c34123946bc5963d9769d31b48a1ae9b29

Release 2.5.17

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 0f8e83c34123946bc5963d9769d31b48a1ae9b29

Release 2.5.17

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha d93da897688362fd0a32f4a8697688e04ff392b9

Use gradle-node-plugin

view details

drumonii

commit sha caeb253b08a2d88c87fc42bc16e888cce9a14b3b

Upgrade Spring Boot to 2.2.2

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 14acda5e57f49cac84e84e11c5b7f3a41be8afb9

Center Champion content on all viewpoints

view details

drumonii

commit sha 570adbd422e3a06c0b01fc944241215af0c28e3b

Move node scripts to their appropriate scripts folder

view details

drumonii

commit sha 5ff4dac7e6fe1390bbfd0d6b6a66d75e31bfc35b

Improve ltb forms styling to match those of ltb buttons

view details

drumonii

commit sha 3f105565f3f0c065e3d9529b20d5142fa9bc200f

Apply border bottom to ltb headers as .ltb-title

view details

drumonii

commit sha a0fa0fe15c0421967ecfa5abbdae4692dae0afad

Upgrade Nebular to 4.6.0

view details

drumonii

commit sha 33082b8a593811b7add08159cf9824c73f913cbc

Update test JSON files to 9.23.1

view details

drumonii

commit sha 0b975b52f52a03702fcd9e315cc87269b2c5c58f

Remove usage of Face of the Mountain item It has been removed.

view details

drumonii

commit sha dadee42bb4e554b35b7e7665b27a879b609f0eee

Fix trinkets for summoners rift fetching sellable items

view details

drumonii

commit sha 7c3621a2388e649b0f719efa67e462735a00b345

Nested security configs can set proxyBeanMethods as true

view details

drumonii

commit sha be83139c6c99cb772a23a61922235e87135f1c3b

Polish ItemsRepositoryTest

view details

drumonii

commit sha 076adf511076e834e9ffa7d2823aeb52d1cab2ec

footer component change detection can be OnPush

view details

drumonii

commit sha ce43d097553bac872d8452641a731ea88c741174

Upgrade Clarity to 2.3.3

view details

drumonii

commit sha 4b41be6c425e198b90a910b1ffd5fb76ec7b0d15

Upgrade Angular cli to 8.3.20

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 8d94f0f2ff47c59d4466c011f73f8c189ad13e6b

Upgrade Clarity to 2.3.3

view details

drumonii

commit sha 931283170ecb0ec131f22251b8dfbc1fb6579e94

Upgrade Angular cli to 8.3.20

view details

push time in 3 months

PR opened vandeseer/easytable

Remove compile scope maven-gpg-plugin dependency

Running mvn dependency:tree on easytable yields:

[INFO] -------------------< com.github.vandeseer:easytable >-------------------
[INFO] Building easytable 0.5.3-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ easytable ---
[INFO] com.github.vandeseer:easytable:jar:0.5.3-SNAPSHOT
[INFO] +- org.apache.pdfbox:pdfbox:jar:2.0.17:compile
[INFO] |  +- org.apache.pdfbox:fontbox:jar:2.0.17:compile
[INFO] |  \- commons-logging:commons-logging:jar:1.2:compile
[INFO] +- org.projectlombok:lombok:jar:1.18.10:provided
[INFO] +- junit:junit:jar:4.12:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- org.hamcrest:hamcrest-library:jar:1.3:test
[INFO] +- org.mockito:mockito-core:jar:2.23.0:test
[INFO] |  +- net.bytebuddy:byte-buddy:jar:1.9.0:test
[INFO] |  +- net.bytebuddy:byte-buddy-agent:jar:1.9.0:test
[INFO] |  \- org.objenesis:objenesis:jar:2.6:test
[INFO] \- org.apache.maven.plugins:maven-gpg-plugin:maven-plugin:1.6:compile
[INFO]    +- org.apache.maven:maven-plugin-api:jar:2.2.1:compile
[INFO]    +- org.apache.maven:maven-project:jar:2.2.1:compile
[INFO]    |  +- org.apache.maven:maven-settings:jar:2.2.1:compile
[INFO]    |  +- org.apache.maven:maven-profile:jar:2.2.1:compile
[INFO]    |  +- org.apache.maven:maven-artifact-manager:jar:2.2.1:compile
[INFO]    |  |  +- org.apache.maven.wagon:wagon-provider-api:jar:1.0-beta-6:compile
[INFO]    |  |  \- backport-util-concurrent:backport-util-concurrent:jar:3.1:compile
[INFO]    |  +- org.apache.maven:maven-plugin-registry:jar:2.2.1:compile
[INFO]    |  +- org.codehaus.plexus:plexus-interpolation:jar:1.11:compile
[INFO]    |  \- org.codehaus.plexus:plexus-container-default:jar:1.0-alpha-9-stable-1:compile
[INFO]    |     \- classworlds:classworlds:jar:1.1-alpha-2:compile
[INFO]    +- org.apache.maven:maven-artifact:jar:2.2.1:compile
[INFO]    +- org.apache.maven:maven-repository-metadata:jar:2.2.1:compile
[INFO]    +- org.apache.maven:maven-model:jar:2.2.1:compile
[INFO]    +- org.codehaus.plexus:plexus-utils:jar:3.0.20:compile
[INFO]    \- org.sonatype.plexus:plexus-sec-dispatcher:jar:1.4:compile
[INFO]       \- org.sonatype.plexus:plexus-cipher:jar:1.4:compile

I was surprised to find org.apache.maven.plugins:maven-gpg-plugin listed as a compile scope dependency in the pom.

I ran mvn clean install and the maven-gpg-plugin:1.6:sign goal still executed as expected (of course with the key failing). So I'm unsure why it's needed as a dependency when it's defined as a plugin.

If I'm in error, please disregard!

Quick fix: add an <exclusion> for the maven-gpg-plugin

<dependency>
    <groupId>com.github.vandeseer</groupId>
    <artifactId>easytable</artifactId>
    <version>${easytable.version}</version>
    <exclusions>
        <exclusion>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-gpg-plugin</artifactId>
        </exclusion>
    </exclusions>
</dependency>

And the dependency tree becomes:

[INFO] -------------------< com.github.vandeseer:easytable >-------------------
[INFO] Building easytable 0.5.3-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ easytable ---
[INFO] com.github.vandeseer:easytable:jar:0.5.3-SNAPSHOT
[INFO] +- org.apache.pdfbox:pdfbox:jar:2.0.17:compile
[INFO] |  +- org.apache.pdfbox:fontbox:jar:2.0.17:compile
[INFO] |  \- commons-logging:commons-logging:jar:1.2:compile
[INFO] +- org.projectlombok:lombok:jar:1.18.10:provided
[INFO] +- junit:junit:jar:4.12:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- org.hamcrest:hamcrest-library:jar:1.3:test
[INFO] \- org.mockito:mockito-core:jar:2.23.0:test
[INFO]    +- net.bytebuddy:byte-buddy:jar:1.9.0:test
[INFO]    +- net.bytebuddy:byte-buddy-agent:jar:1.9.0:test
[INFO]    \- org.objenesis:objenesis:jar:2.6:test
+0 -7

0 comment

1 changed file

pr created time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 1ba0b70bf3fd5ef39dfcf7311368fc5cb3d5a48e

footer component change detection can be OnPush

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha df7e4c40881ae93faf4ef5afd85a1581fd4d7885

Polish ItemsRepositoryTest

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha a23e888cd14b663e50fad2c86d8d71aa731311e5

Update test JSON files to 9.23.1

view details

drumonii

commit sha 4bc69a151725cb9134c7f170adef3a7a9928fa3c

Remove usage of Face of the Mountain item It has been removed.

view details

drumonii

commit sha 1c6b83f65471dfe5df6150ee05442aaac1e3d696

Fix trinkets for summoners rift fetching sellable items

view details

drumonii

commit sha 2590cef0021c5a6394ee6a44da0cb347b55def4b

Nested security configs can set proxyBeanMethods as true

view details

push time in 3 months

push eventdrumonii/easytable

Drummond Dawson

commit sha 8b9723137095f4399108be780d499d185566081a

Remove compile scope maven-gpg-plugin dependency The maven-gpg-plugin is used strictly as a plugin and therefore its corresponding dependency declaration can be removed. This ensures no extra dependencies are pulled in from the maven-gpg-plugin when easytable itself is declared as a project dependency.

view details

push time in 3 months

create barnchdrumonii/easytable

branch : remove-maven-gpg-plugin-as-a-dependency

created branch time in 3 months

push eventdrumonii/SpringBootTwoDataSources

drumonii

commit sha 3681785ca2f4465afe24fa35a7a4ab7f024bbb1e

Remove application json utf8 usage

view details

drumonii

commit sha d08835d4c40a58df139c1f9305b46a617e36ce0c

Upgrade Angular to 8.2.14 and cli to 8.3.20

view details

drumonii

commit sha cbd8a595e3746f2b395607a77873298b67221aa6

Show primary/secondary flyway migrations

view details

push time in 3 months

push eventdrumonii/nebular

Drummond Dawson

commit sha 14e37e602c43ebbdb25537334375da8d8cb7979b

refactor: rxjs subscription management Previously, subscription management was done with takeWhile operator. However that was improperly unsubscribing causing a potential leak of the subscription.

view details

push time in 3 months

PR opened akveo/nebular

Rxjs subscription management refactor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

  • Add https://github.com/cartant/rxjs-tslint-rules package
  • Enable the https://github.com/cartant/rxjs-tslint-rules#rxjs-no-unsafe-takeuntil rule using the default configuration
  • Convert usages of takeWhile(() => this.alive) to lastly piped takeUntil(this.destroy$) with destroy$ defined as new Subject<void>() that is completed in the ngOnDestroy:
    this.destroy$.next();
    this.destroy$.complete();

Resolves https://github.com/akveo/nebular/issues/1059

+406 -219

0 comment

41 changed files

pr created time in 3 months

push eventdrumonii/nebular

Arthur Moura Carvalho

commit sha f8a1b327bbaf323074c890156d0885fe6f1e8d3c

feat(accordion): toggle via keyboard (#2085)

view details

Denis Strigo

commit sha 9ec661af979e5d0047680b746641db97d15b9a36

chore(gulp): update gulp to 4 version (#2065)

view details

Philipp Guerrero Mengana

commit sha e85830fd2ca5196ace0ae7180e3397f8c419cffd

fix(overlay): set position when content or context update (#2081)

view details

Sergey Andrievskiy

commit sha 2e61d8d683e3621779367ac7a0bccf2316fa0061

fix(radio): reverse order of elements in RTL (#2093)

view details

Sergey Andrievskiy

commit sha dd5f2b621bdb404de59f970505504c5d239950bb

fix(toggle): set correct ARIA role (#2097)

view details

Sergey Andrievskiy

commit sha 09bf0b715ff78556683a054b27f686e0a6f3e777

chore: fix bump version script to work with gulp 4 (#2098)

view details

Sergey Andrievskiy

commit sha 4cd3000b292b8b54fd89f9f8fa08484c0b9e9ef5

release: 4.6.0 (#2099)

view details

Sergey Andrievskiy

commit sha 729e8ce4644dc00744deff420e5877db5c44f657

chore(docs): add Eva black friday deal (#2100)

view details

Sergey Andrievskiy

commit sha 16ae5b27a5fb1fc0bf5714dde5541bafebcf6829

chore(docs): set Eva deal commit as current docs version (#2101)

view details

Drummond Dawson

commit sha 14737e338f5d3a8acdab3f8eb1adc51fdf86b176

chore(lint): add rxjs-tslint-rules Enable the 'rxjs-no-unsafe-takeuntil' rule with severity of error so that the takeUntil operator remains last in order to protect against potential subscription leaks.

view details

Drummond Dawson

commit sha 9c881120ab01bf508d4141dfda30fdf6f843b13b

refactor: rxjs subscription management Previously, subscription management was done with takeWhile operator. However that was improperly unsubscribing causing a potential leak of the subscription.

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha da2d4ef0b6b923d6311de7b06b68e68196d2e655

Upgrade Nebular to 4.6.0

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha d481d6b2d4e39becc75ebc44280922ceb8b3dd6c

Improve ltb forms styling to match those of ltb buttons

view details

drumonii

commit sha a10b9bc10650f82c689dc892f084a4def182a639

Apply border bottom to ltb headers as .ltb-title

view details

push time in 3 months

create barnchdrumonii/LeagueTrollBuild

branch : next

created branch time in 3 months

created tagdrumonii/LeagueTrollBuild

tag2.5.16

League of Legends Build Randomizer

created time in 3 months

release drumonii/LeagueTrollBuild

2.5.16

released time in 3 months

delete branch drumonii/LeagueTrollBuild

delete branch : next

delete time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 9af89191a799d9e836727bad67788f4f41b41fd6

Next snapshot version

view details

drumonii

commit sha 70628cdeb65ecec55e931bb0f0376f3cc0e07470

Update dependencies and npm audit fix

view details

drumonii

commit sha fe3bb228724180e188f976fad582602cae8fde74

Fix typo in README

view details

drumonii

commit sha 7a620d5c92c635428d52a2fd9ef97b68364f8484

Clarify admin login localhost URL

view details

drumonii

commit sha 73dd1370b4130f48e64b2d64b45dbbb8ab74157f

Update outdated portions of backend README

view details

drumonii

commit sha 13da35a80b9ca77fcb7b2f027bf7f8957eea3b9c

Update test JSON files to 9.16.1

view details

drumonii

commit sha e2a85b7d89ed77f75a2eac49832c0a4b6d2a3932

Set current page from state of refresh event

view details

drumonii

commit sha 430e454375d9fcc1e14e377319fcebb124fb3b97

Set default page size as 20

view details

drumonii

commit sha 2c9c95e6b11813f8e1b551f15a5e7646c5e4ee40

Upgrade Angular to 8.2.3

view details

drumonii

commit sha 08632504d2f329f3bdd3aae3c92d695cc5aeea7a

Upgrade Angular to 8.2.4

view details

drumonii

commit sha c0a869e7f41752b6ac0c30c65d8ebc5d62ccaaa5

Upgrade Spring Boot to 2.1.8

view details

drumonii

commit sha 61b5ce186c40c16021bd2a9a91628854e5e5261b

Make model classes as interfaces They were unnecessarily declared as classes.

view details

drumonii

commit sha 427571887e8a274752a1c9c475ad011210400407

Upgrade Angular to 8.2.5

view details

drumonii

commit sha 9ef5ab1981382782488e9960deb0011d51b20571

Upgrade commons collections4 to 4.4

view details

drumonii

commit sha 4a7ee2ffc41ae228fcc4a296dd1caf23ede97658

Initiate Sort using static method instead of constructor

view details

drumonii

commit sha 5f3bebe6e35de20a296901f7947662b8ede4b2bf

Introduce static patch method to create Versions from a patch

view details

drumonii

commit sha 5a66e6068deb1bbef9578c43abb9ebbf4688ba09

Upgrade Angular to 8.2.7

view details

drumonii

commit sha b823186cf1f9d36a6f0f43f06caa70ebaf51e656

Upgrade Angular to 8.2.8

view details

drumonii

commit sha 5ecfea67f4c6e4550d93dc3959882cae4a96e391

Upgrade Clarity to 2.2.0

view details

drumonii

commit sha 9efb0955e395cd1734f624e007ab8a06b46730c2

Upgrade Angular cli to 8.3.6

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 6bd0c880aa1da7d4d104595b31830bd3aeb17b82

Improve admin dashboard cards to group metrics

view details

drumonii

commit sha 3646288fb82016ed532b67aa458d5a4e3bd2b259

Simplify status code check in array of status codes with includes

view details

drumonii

commit sha dab723a99708b83c57d01a2aab332b1b4874b050

Remove message source properties They are all related to frontend so they should be removed. But will keep for ease of use and setup if needed in the future.

view details

drumonii

commit sha 5e6739dc35e7e8c0566446aa288b064b18f2b02b

Upgrade Angular to 8.2.14 and cli to 8.3.19

view details

drumonii

commit sha 5f2bf6653c0ce15a86fd031bd7ca15ed517839c0

Upgrade Clarity to 2.3.2

view details

drumonii

commit sha ac4d966dbe3774c83e1463ca5e256115c9bb27d2

Drop minor portion of Angular version in README

view details

drumonii

commit sha 8ea95db995f9c39aa3e8f4a4493feebe7a191578

Add instructions on running a PostreSQL container in backend README

view details

drumonii

commit sha ab2b3e25577008321f5d24cd63a9661fd87fe722

Simplify get AdminUserDetails from nullable UserDetails

view details

drumonii

commit sha 1b0ff381422a8a4bfd6da551f1e7b56f7ebb14d1

Simplify try catch assertion with assertThatExceptionOfType

view details

drumonii

commit sha 5d016c028dd30c680c09837f025706165a40874a

Simplify try catch assertion with assertThatCode doesNotThrowAnyException

view details

drumonii

commit sha 7fd43f302ed89f3c765f94cb59499036066167b4

Declare embedded profile use in building of README

view details

drumonii

commit sha ee6f239b8d8dd67042779f15f3538c9038854b05

Release 2.5.16

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 3af94ec82a87677a1714b0f0313d955d95d3a094

Release 2.5.16

view details

push time in 3 months

create barnchdrumonii/nebular

branch : rxjs-subscription-management-refactor

created branch time in 3 months

pull request commentakveo/nebular

fix(nbIsGranted): subscription memory leak

@yggg If you'd like, I can only take on the similar issue https://github.com/akveo/nebular/issues/1059 once this has been merged.

drumonii

comment created time in 3 months

PR opened akveo/nebular

fix(nbIsGranted): subscription memory leak

In order to prevent a memory leak in NbIsGrantedDirective, properly unsubscribe from the NbAccessChecker's isGranted subscription using a Subject and takeUntil operator.

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Resolves https://github.com/akveo/nebular/issues/1385

+7 -4

0 comment

1 changed file

pr created time in 3 months

push eventdrumonii/nebular

Drummond Dawson

commit sha 3d60c85c6d13ad3dfdcb79ef8d69cb8b05ccf24d

fix(nbIsGranted): subscription memory leak In order to prevent a memory leak in NbIsGrantedDirective, properly unsubscribe from the NbAccessChecker isGranted subscription using a Subject and takeUntil operator.

view details

push time in 3 months

push eventdrumonii/nebular

Drummond Dawson

commit sha e37089bdd696d2e40611af8e12b9b87f4f6b9af1

fix(nbIsGranted): subscription memory leak In order to prevent a memory leak, properly unsubscribe from the NbAccessChecker isGranted subscription using a Subject and takeUntil.

view details

push time in 3 months

push eventdrumonii/nebular

Drummond Dawson

commit sha cca1db8643afe77c3eec59330068b625cfbc0c76

fix(nbIsGranted): subscription memory leak Properly unsubscribe from the NbAccessChecker isGranted subscription using a Subject and takeUntil in order to prevent a memory leak.

view details

push time in 3 months

create barnchdrumonii/nebular

branch : fix-memory-leak-in-nbIsGranted

created branch time in 3 months

fork drumonii/nebular

:boom: Customizable Angular UI Library based on Eva Design System :new_moon_with_face::sparkles:Dark Mode

https://akveo.github.io/nebular

fork in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 66d2b84556706471c4be3b56214f3efb95749ecc

Simplify get AdminUserDetails from nullable UserDetails

view details

drumonii

commit sha 2a87d98713907e50be0ccdb2c4e50898e21ba8d3

Simplify try catch assertion with assertThatExceptionOfType

view details

drumonii

commit sha 08bbc726f546fc7d98ecf464adab70208f2e186d

Simplify try catch assertion with assertThatCode doesNotThrowAnyException

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha f79d545c8cf1294879babc884ed6c1e485193451

Drop minor portion of Angular version in README

view details

drumonii

commit sha 8b64a929ff7c36e60aaf21b2e1bd4d74d1e7792f

Add instructions on running a PostreSQL container in backend README

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 4cb2a0aa9339068ee6e76e0fd0e3894569ffa811

Upgrade Angular to 8.2.14 and cli to 8.3.19

view details

drumonii

commit sha 4d3bb9bc9aaf31712b28c3191373bfeb7aab964a

Upgrade Clarity to 2.3.2

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 6f07b95ee8c92e93d149d53267e984e5228b879a

Simplify status code check in array of status codes with includes

view details

drumonii

commit sha 6782d449030e50c8d1e886c9dc5392b1294e61cc

Remove message source properties They are all related to frontend so they should be removed. But will keep for ease of use and setup if needed in the future.

view details

push time in 3 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 56398c6ef6a25a6cb7bb920643ed438ab1581c59

Customize clarity components styling

view details

drumonii

commit sha 939909792f58bbc6d39ee881fccb2193fc29bc8f

Improve admin dashboard cards to group metrics

view details

push time in 3 months

push eventdrumonii/angular

Igor Minar

commit sha bb3c684b980990a2e13b2e216b114d4e4fdd56a8

ci: exclude the upstream g3 branch from building on CI (#32202) We don't need to build this branch as it's informative for the purposes of figuring out the diff between the master and what's synced into google3. PR Close #32202

view details

atscott

commit sha cfed0c0cf1238e5ad931598ce04c32f8c9a75143

fix(ivy): Support selector-less directive as base classes (#32125) Following #31379, this adds support for directives without a selector to Ivy. PR Close #32125

view details

Andrew Scott

commit sha 3dbc4ab572023fbf254dfc41c222fe54c70a7155

fix(ivy): get name directly from nativeNode (#32198) nativeElement can return null so an error can occur when accessing nodeName from nativeElement. PR Close #32198

view details

Kara Erickson

commit sha dd6070a49b48fa2605c1a50771cc6a62379119df

ci: update material commit we use to run integration tests (#32220) We need to update the commit so we can make Hammer support optional in 32203. PR Close #32220

view details

Kara Erickson

commit sha 388578fec946237e24521509bd887efc243a86d9

Revert "ci: remove material-unit-tests failure blocklist (#32138)" (#32226) This reverts commit 0660903784a32261f2ba5e057088166441779b75 so we can add some tests to the blocklist. PR Close #32226

view details

Alex Rickabaugh

commit sha 2b64031ddc1bb90b1e7a7da04937763c7a49b567

refactor(ivy): remove the tsc passthrough option (#32219) This option makes ngc behave as tsc, and was originally implemented before ngtsc existed. It was designed so we could build JIT-only versions of Angular packages to begin testing Ivy early, and is not used at all in our current setup. PR Close #32219

view details

Alex Rickabaugh

commit sha ec4381dd401f03bded652665b047b6b90f2b425f

feat: make the Ivy compiler the default for ngc (#32219) This commit switches the default value of the enableIvy flag to true. Applications that run ngc will now by default receive an Ivy build! This does not affect the way Bazel builds in the Angular repo work, since those are still switched based on the value of the --define=compile flag. Additionally, projects using @angular/bazel still use View Engine builds by default. Since most of the Angular repo tests are still written against View Engine (particularly because we still publish VE packages to NPM), this switch also requires lots of `enableIvy: false` flags in tsconfigs throughout the repo. Congrats to the team for reaching this milestone! PR Close #32219

view details

jenniferfell

commit sha 10ea3a9f4dd77e936cd21d3a82416dccdd5d6b9d

docs: change to global approvers (#31940) PR Close #31940

view details

Kara Erickson

commit sha c957dfc1674f9ff414fbed9ff11b3b5216b903fd

docs: update collaborators page (#32229) PR Close #32229

view details

Miško Hevery

commit sha 64770571b2a02cf6614672468e23c7dc8196fb18

perf: don't create holey arrays (#32155) Don't use `Array` constructor with the size value (ex. `new Array(5)`) - this will create a `HOLEY_ELEMENTS` array (even if this array is filled in later on!); https://v8.dev/blog/elements-kinds https://stackoverflow.com/questions/32054170/how-to-resize-an-array PR Close #32155

view details

Paul Gschwendtner

commit sha 62f41406348253b9aecd54a5a51753bd4a8fafd6

build: add blocklist for material unit tests (#32239) Initially the blocklist has been removed because there were no remaining disabled tests that failed. Also the blocklist logic didn't work anymore because the `material-unit-tests` CI job now runs against `angular/components#master` with Bazel. 388578fec946237e24521509bd887efc243a86d9 tried to revert the removal of the blocklist in favor of a new upcoming breaking change with HammerJS, but the revert doesn't help since the blocklist still doesn't work with Bazel. In order to make the blocklist work with the unit tests running with Bazel, a PR has been submitted on the components repository. See: https://github.com/angular/components/pull/16833. This commit updates the blocklist logic on the framework side to work with the new logic on the components repo side. PR Close #32239

view details

Alan

commit sha 424ab486722c8721fe3ffba76a8ae9d1aac66e5f

fix(compiler): return enableIvy true when using `readConfiguration` (#32234) PR Close #32234

view details

George Kalpakas

commit sha 8e1a7254623a8797001f56f495b53425aeda76fa

build(docs-infra): upgrade cli command docs sources to d2489aeda (#32236) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/6aae7f563...d2489aeda): **Modified** - help/generate.json ## PR Close #32236

view details

JoostK

commit sha 0db1b5d8f11b23d29ee1a4f2226cb95ef8748bc0

fix(ivy): handle empty bindings in template type checker (#31594) When a template contains a binding without a value, the template parser creates an `EmptyExpr` node. This would previously be translated into an `undefined` value, which would cause a crash downstream as `undefined` is not included in the allowed type, so it was not handled properly. This commit prevents the crash by returning an actual expression for empty bindings. Fixes #30076 Fixes #30929 PR Close #31594

view details

Paul Gschwendtner

commit sha daac386f4d756d24fc3d7680acc201873f027cc0

ci: update material-unit-tests commit (#32243) Updates the SHA that will be tested against in the `material-unit-tests` job to the latest commit in the components repository. SHA 18b9ef3f5529f0fa8f034944681486447af7b879 is needed in order to make the newly introduced material-ci test blocklist effective. PR Close #32243

view details

Alex Rickabaugh

commit sha bfc26bcd8c700a4ab89ad1cef69343a302c0527a

fix(ivy): run template type-checking for all components (#31952) PR Close #31952

view details

Alex Rickabaugh

commit sha 0287b234eac30dc454b46ccfc8223fdda5f74abb

feat(ivy): convert all ngtsc diagnostics to ts.Diagnostics (#31952) Historically, the Angular Compiler has produced both native TypeScript diagnostics (called ts.Diagnostics) and its own internal Diagnostic format (called an api.Diagnostic). This was done because TypeScript ts.Diagnostics cannot be produced for files not in the ts.Program, and template type- checking diagnostics are naturally produced for external .html template files. This design isn't optimal for several reasons: 1) Downstream tooling (such as the CLI) must support multiple formats of diagnostics, adding to the maintenance burden. 2) ts.Diagnostics have gotten a lot better in recent releases, with support for suggested changes, highlighting of the code in question, etc. None of these changes have been of any benefit for api.Diagnostics, which have continued to be reported in a very primitive fashion. 3) A future plugin model will not support anything but ts.Diagnostics, so generating api.Diagnostics is a blocker for ngtsc-as-a-plugin. 4) The split complicates both the typings and the testing of ngtsc. To fix this issue, this commit changes template type-checking to produce ts.Diagnostics instead. Instead of reporting a special kind of diagnostic for external template files, errors in a template are always reported in a ts.Diagnostic that highlights the portion of the template which contains the error. When this template text is distinct from the source .ts file (for example, when the template is parsed from an external resource file), additional contextual information links the error back to the originating component. A template error can thus be reported in 3 separate ways, depending on how the template was configured: 1) For inline template strings which can be directly mapped to offsets in the TS code, ts.Diagnostics point to real ranges in the source. This is the case if an inline template is used with a string literal or a "no-substitution" string. For example: ```typescript @Component({..., template: ` <p>Bar: {{baz}}</p> `}) export class TestCmp { bar: string; } ``` The above template contains an error (no 'baz' property of `TestCmp`). The error produced by TS will look like: ``` <p>Bar: {{baz}}</p> ~~~ test.ts:2:11 - error TS2339: Property 'baz' does not exist on type 'TestCmp'. Did you mean 'bar'? ``` 2) For template strings which cannot be directly mapped to offsets in the TS code, a logical offset into the template string will be included in the error message. For example: ```typescript const SOME_TEMPLATE = '<p>Bar: {{baz}}</p>'; @Component({..., template: SOME_TEMPLATE}) export class TestCmp { bar: string; } ``` Because the template is a reference to another variable and is not an inline string constant, the compiler will not be able to use "absolute" positions when parsing the template. As a result, errors will report logical offsets into the template string: ``` <p>Bar: {{baz}}</p> ~~~ test.ts (TestCmp template):2:15 - error TS2339: Property 'baz' does not exist on type 'TestCmp'. test.ts:3:28 @Component({..., template: TEMPLATE}) ~~~~~~~~ Error occurs in the template of component TestCmp. ``` This error message uses logical offsets into the template string, and also gives a reference to the `TEMPLATE` expression from which the template was parsed. This helps in locating the component which contains the error. 3) For external templates (templateUrl), the error message is delivered within the HTML template file (testcmp.html) instead, and additional information contextualizes the error on the templateUrl expression from which the template file was determined: ``` <p>Bar: {{baz}}</p> ~~~ testcmp.html:2:15 - error TS2339: Property 'baz' does not exist on type 'TestCmp'. test.ts:10:31 @Component({..., templateUrl: './testcmp.html'}) ~~~~~~~~~~~~~~~~ Error occurs in the template of component TestCmp. ``` PR Close #31952

view details

Kara Erickson

commit sha de8ebbdfd03feca36eb891e2cd3fb54c8279211f

feat(ivy): make Hammer support tree-shakable (#32203) Currently, it's not possible to tree-shake away the coordination layer between HammerJS and Angular's EventManager. This means that you get the HammerJS support code in your production bundle whether or not you actually use the library. This commit removes the Hammer providers from the default platform_browser providers list and instead provides them as part of a `HammerModule`. Apps on Ivy just need to import the `HammerModule` at root to turn on Hammer support. Otherwise all Hammer code will tree-shake away. View Engine apps will require no change. BREAKING CHANGE Previously, in Ivy applications, Hammer providers were included by default. With this commit, apps that want Hammer support must import `HammerModule` in their root module. PR Close #32203

view details

Pawel Kozlowski

commit sha 4d549f69f8913bf3633f69bf7930bc124f3756fa

perf(ivy): auto-call select(0) for non-empty views only (#32131) PR Close #32131

view details

Pawel Kozlowski

commit sha 10629600c561a1dfdbe5fba6768158b56b8bea5c

perf(ivy): split hooks processing into init and check phases (#32131) Angular hooks come after 2 flavours: - init hooks (OnInit, AfterContentInit, AfterViewInit); - check hooks (OnChanges, DoChanges, AfterContentChecked, AfterViewChecked). We need to do more processing for init hooks to ensure that those hooks are run once and only once for a given directive (even in case of errors). As soon as all init hooks execute to completion we are only left with the checks to execute. It turns out that keeping track of the remaining init hooks to execute is rather expensive (multiple LView flags reads, writes and checks). But we can observe that non of this tracking is needed as soon as all init hooks are completed. This PR takes advantage of the above observations and splits hooks processing functions into: - init-specific (slower but less common); - check-specific (faster and more common). NOTE: there is code duplication in this PR and it is left like this intentinally: hand-inlining this perf-critical code makes the view refresh process substentially faster. PR Close #32131

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha af88791810eb01d1ab21a231f12f815b37430239

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha 0e9ce76c7eb7c8a6698447bb9360f326d4bb2f3c

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha e96182d60d0946562c7a88e4711f72e67ff6b2da

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha 52470ede08c0da0f3af8ffb24421aba87786a303

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha 7fe603c1ea49c0ba6867b0a8d2530fba256c85e3

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 1d15d7676549f5db4c66d57a2673c8ec4007c2d3

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha 7b7ef3e492277d1fdd4e579903f0ea67cedb4332

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha 848f17400e9185b97fe73d2ca01154655e6bf5c0

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha 5126b4f72ac3b871b3277f98d41851a29cbd752d

Use ParameterizedTest where applicable

view details

drumonii

commit sha 2c230a423d57eeb6e83dea50b2d4efda304a5ba4

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha 67145cee1c2cff22e661c26a567aafc958b45cb3

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha fbb83caff3c6b76db793181228fbebb5c03d4775

Group service tests with Nested for readability

view details

drumonii

commit sha a6b62b106c3ccb43425b77a644ff476be6307c35

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

drumonii

commit sha 7c39aada0477ff27938bea0245831a0cf83f252d

Move API controller logic into API services

view details

drumonii

commit sha 720e12f698ecae0acd3957c9412e49958f608e48

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

drumonii

commit sha 97e67f0a9dc4c1a66b7e873910d3540942cf6d87

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

drumonii

commit sha 34b5cdedf0366178660b921c3d01e0907968ea8a

Update test JSON files to 9.21.1

view details

drumonii

commit sha 8a8d33adb4faac159500250bc6dd4d8ff1336d1f

Create JobLauncherTestUtils bean(s) for job tests Instead of declaring a JobLauncherTestUtils for each batch job config test, declare them programmatically in a BeanFactoryPostProcessor depending on the job being tested.

view details

drumonii

commit sha 682d19c908c61917e2d73f807101fe60cf2e79d2

Upgrade Angular to 8.2.12 and cli to 8.3.14

view details

drumonii

commit sha 2f8ef5c5e24c545a62b60ce586c271e8ac9639fc

Improve jsonPath assertions of qbe tests To ensure the QueryByExampleFromSpecificationPredicateBuilder is still needed and not replaced by Spring Data's own QueryByExamplePredicateBuilder, the qbe tests should enhance their jsonPath assertions with proper Hamcrest matchers.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 804da6fb5f7c37dae0e3b698d3eb6e8d00671f8e

Remove xsrf cookie on logout Instead of forcing a new xsrf token cookie on successful logout with a subscription to any GET request (the current one intentionally 404's which seems odd) as part of the auth service, simply remove the xsrf token cookie in the backend logout handler.

view details

drumonii

commit sha 4be80577d3dd00a6cfabf16ad5d582de2a4e6b59

Use the boolean type for clrLoading attribute

view details

drumonii

commit sha f07a34149809eae6786f84c1aed30c6e786d4eda

Remove webpack-bundle-analyzer as dev dependency Use webpack-bundle-analyzer with ngx instead of having as a managed dev dependency. Provide instructions in the frontend README.

view details

drumonii

commit sha 6323eb03018219262ff3e52f75115ed31d522b19

Provide getter for Example of ExampleSpecification

view details

drumonii

commit sha febbd042e7678e5109fb8e8037a35df146028ebf

Simplify creation of ExampleSpecification with static of

view details

drumonii

commit sha e860a0189f62f3d61713af310b72ddffd6e62364

Update test JSON files to 9.22.1

view details

drumonii

commit sha e9bf6c4986971a95be187b79211825cc761327a2

Use URI.create

view details

drumonii

commit sha ad359d10db84a11666d86d9f68f368b4a5b8fa55

Upgrade Clarity to 2.3.1

view details

drumonii

commit sha 0b1c3278519cf255165f9700120fa799407d3a8a

Use more functional style to create the ResponseEntity from the Image

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 463676e856a36db8682a7ef4efb302f313b832c6

Update test JSON files to 9.22.1

view details

drumonii

commit sha 34c47be1b8bd367de68ba0b429b951519b4cd88e

Use URI.create

view details

drumonii

commit sha 4e565d46da34b2a9575593758c7d4d9c1c00c876

Upgrade Clarity to 2.3.1

view details

drumonii

commit sha cb89bf27edb3b515e71c4fc298e5e4d20c8415c4

Use more functional style to create the ResponseEntity from the Image

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 2e200d56b4aafd2aa1d7d7f89753bc991c902e75

Update webdriver-manager to support Chrome 76+

view details

drumonii

commit sha d7d7dc474ace81e00cf99802c1dd45c4d97ba356

Upgrade Spring Boot to 2.2.1

view details

drumonii

commit sha 51451a776e15ffd9ec609e8aa8193de03af37615

Remove xsrf cookie on logout Instead of forcing a new xsrf token cookie on successful logout with a subscription to any GET request (the current one intentionally 404's which seems odd) as part of the auth service, simply remove the xsrf token cookie in the backend logout handler.

view details

drumonii

commit sha 53707763b01f065d3c0f9413b360177479aeec0d

Use the boolean type for clrLoading attribute

view details

drumonii

commit sha b50a4f90da3e73c7b3d4909a2968ebf8a1d6ce85

Remove webpack-bundle-analyzer as dev dependency Use webpack-bundle-analyzer with ngx instead of having as a managed dev dependency. Provide instructions in the frontend README.

view details

drumonii

commit sha 16d232947fe72256d618ed4b5c89a61f77ec37be

Provide getter for Example of ExampleSpecification

view details

drumonii

commit sha 4daf5ba1c7def92d6d158fff9ef9793c52bfc9b1

Simplify creation of ExampleSpecification with static of

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 684b5c031535b04c2aa39317f64ac862c45e2b76

Remove webpack-bundle-analyzer as dev dependency Use webpack-bundle-analyzer with ngx instead of having as a managed dev dependency. Provide instructions in the frontend README.

view details

drumonii

commit sha c0a10b8da0dbd2842bd1b2df240e7fb67be82251

Provide getter for Example of ExampleSpecification

view details

drumonii

commit sha 49b5b9254066976eed8daf74fbc017d3c0dc36b7

Simplify creation of ExampleSpecification with static of

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 45e369d4efeaf8d1fd001bc2b7ad330d71927038

Remove xsrf cookie on logout Instead of forcing a new xsrf token cookie on successful logout with a subscription to any GET request (the current one intentionally 404's which seems odd) as part of the auth service, simply remove the xsrf token cookie in the backend logout handler.

view details

drumonii

commit sha 4f148675539f3fb42c6e709e1dc40d59886ccee4

Use the boolean type for clrLoading

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 91c7435290885ac89821cf1653cabc6c3e6e6cb9

Upgrade Spring Boot to 2.2.1

view details

push time in 4 months

push eventdrumonii/SpringBootTwoDataSources

drumonii

commit sha 9b67af9416b760acddca47dd19121ce93f3150c7

Upgrade Spring Boot to 2.2.1

view details

drumonii

commit sha 37e901e35fccdf329144f9e965ebe3e8f3b37820

Merge branch 'backend-only' into with-frontend

view details

drumonii

commit sha 8ba0421c76e5527aa2a16f5f090cbd5d3f3787ee

Upgrade Angular to 8.2.13 and cli to 8.3.17

view details

drumonii

commit sha 0c4568ab2d7a796c514a6e7f5cc1ff69f70e01ae

Upgrade node to 12.13.0 (LTS)

view details

push time in 4 months

push eventdrumonii/SpringBootTwoDataSources

drumonii

commit sha 9b67af9416b760acddca47dd19121ce93f3150c7

Upgrade Spring Boot to 2.2.1

view details

push time in 4 months

push eventdrumonii/spring-security

Drummond Dawson

commit sha 5d570a81b9e0d5b66fecf1a16a43718163602455

Support URI vars in formLogin and logout MockMvc requests

view details

push time in 4 months

pull request commentspring-projects/spring-security

Support URI vars in formLogin and logout MockMvc requests

@eleftherias done! I too noticed the throws Exception was unnecessary but left it since the other tests had it declared despite being never thrown.

drumonii

comment created time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 1d27c4ece698336b0d9815d3be8accb855850029

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha 4e9e6c14e52d1d52c0e7665735fb9ea306b4084f

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha 2594c3822a88f038eb996c5148d1d79798ba9a12

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha f935894d9de7bc2618fea75b9c5bb00d3fd634e8

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha c3e7ba004d9470039bdd45e2ea191e13e3c9c565

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 65ab664f754b011d22004816ea1ed5711249d825

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha e34f41e4e95c9a6782cc9e1c50b587bc7ed46bf4

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha f1781322a1c5022c6a45d1af6c38b6d0083d477e

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha d0583bd80239e7e756c854ac0fbcb62ba28370f2

Use ParameterizedTest where applicable

view details

drumonii

commit sha 9f16e0526b202bbf7554f749687eef64cb2338f6

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha f3e5aee071721046c159349fc6c37afb3b0ae612

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha fbd9a4faa5b9517ea6ce1b826f8754f6d3d171a7

Group service tests with Nested for readability

view details

drumonii

commit sha bcf360c4c64d17dd98b74fc30c28a649ae2fec62

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

drumonii

commit sha d9855c705996a006319fb2749ce2d8585367db7f

Move API controller logic into API services

view details

drumonii

commit sha 9fa1ccd9a7c9f11a07da931ffe7a3e934c5a3dc1

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

drumonii

commit sha 02d43f2dcbe21b0e7f81998d5aadafb182b036a8

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

drumonii

commit sha e7411002e4af7696af3114e457691e25f1e76d44

Update test JSON files to 9.21.1

view details

drumonii

commit sha b67aa48f51980f8c860689c0091fb8df941720ef

Create JobLauncherTestUtils bean(s) for job tests Instead of declaring a JobLauncherTestUtils for each batch job config test, declare them programmatically in a BeanFactoryPostProcessor depending on the job being tested.

view details

drumonii

commit sha 5b4b997d76ef6773065158d95469771da15cf490

Upgrade Angular to 8.2.12 and cli to 8.3.14

view details

drumonii

commit sha 947524733954c0d028760c1aa826b3dfdb0f1c67

Improve jsonPath assertions of qbe tests To ensure the QueryByExampleFromSpecificationPredicateBuilder is still needed and not replaced by Spring Data's own QueryByExamplePredicateBuilder, the qbe tests should enhance their jsonPath assertions with proper Hamcrest matchers.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha f0c52273b5de8efbbc1e3c9989c1e0737f413e79

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha 3a00ae59f311eb3d58017ffb72250500d81e4b7d

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha 35fc9bd88d9c1b2d194d694ff566ad643ef6e881

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha bc0869d705426f4970dab7e2968d403b10befa68

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha 6c4b48f7d901a595366e6f9f9ec121a8fd85a8a3

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 35007dc0510ff4cbfdded3dc926a3bf0aaa39887

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha d53c3363b25ea1447a0d9bdf79e62b1469979a8b

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha 86e788399c243b7a8813fbe769ebfcd0fcc63479

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha c5ab19b5350d7a6525d7d3f9e36493058587344f

Use ParameterizedTest where applicable

view details

drumonii

commit sha f963eff28ab984a981f64e197aa89839ca5a9d87

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha 4712f9d9190a10158f509e9720ef21560a00cfce

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha 88ba6a4b9777763d438db50ec2f3939d75614478

Group service tests with Nested for readability

view details

drumonii

commit sha 99411c1200fab5bfadb20a71f169a832330430ce

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

drumonii

commit sha eb09bfd94c62d1e9151b4b9f46a2c3f63ca9929f

Move API controller logic into API services

view details

drumonii

commit sha 269910b999fd385860b5d64fb03f8af7b6bc782d

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

drumonii

commit sha 710baf61fe1829820af376b2e7e565d9fdff8d81

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

drumonii

commit sha 403404a31e23cfe2a78f7363939282c60b9e11ec

Update test JSON files to 9.21.1

view details

drumonii

commit sha 69b08c0a83e743ca6cb1eef2ac1accde1168d359

Create JobLauncherTestUtils bean(s) for job tests Instead of declaring a JobLauncherTestUtils for each batch job config test, declare them programmatically in a BeanFactoryPostProcessor depending on the job being tested.

view details

drumonii

commit sha 326aec810f3a59256afc86caeeca7f1bb6562dfd

Upgrade Angular to 8.2.12 and cli to 8.3.14

view details

drumonii

commit sha 3906696de871c18f4e952d0c9c382d29c87bc142

Improve jsonPath assertions of qbe tests To ensure the QueryByExampleFromSpecificationPredicateBuilder is still needed and not replaced by Spring Data's own QueryByExamplePredicateBuilder, the qbe tests should enhance their jsonPath assertions with proper Hamcrest matchers.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha a27a7d224629dd49fbd670457d20810ac27d95cd

Update webdriver-manager to support Chrome 78 Signed-off-by: drumonii <drumonii@users.noreply.github.com>

view details

drumonii

commit sha f633dcf2e188f98de2fed6763cf81255d3c67d78

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha 9891552e0ac825286e020c1ad52f036b8837e8f9

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha 3bf3929da795d539d5b3cb2ff6cb69565fc68ea6

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha a218695d9943c19ccf56a7504aa9e0cd582980b6

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 7755a0dadbe561bad1e122974b029b3f45b59132

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha dab437b2eb70c96113269c026db77bb3e026410d

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha 8a6c49cfa3f0af4f597f2b487d1852c175b80d34

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha 9655365bd1a560d4a96f6848e75b7f804fb47137

Use ParameterizedTest where applicable

view details

drumonii

commit sha df2f560e4f7edc3e4b05d3c522bfb6c0184cc0e6

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha fe160de1afebc79ef527108f122402e48cd0d861

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha c31e0f972bdd80a6957d829bee2a9d9011e2a9d1

Group service tests with Nested for readability

view details

drumonii

commit sha b4721c1be45d9803ba2a27765a1ff9b76b1ddbd7

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

drumonii

commit sha c6f5307be466eeb84edd2aeda85e40d6682bfc59

Move API controller logic into API services

view details

drumonii

commit sha 820bd8ebcb8cf9a87acdaaa40289638d8e466ea7

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

drumonii

commit sha 162790fb36f50f345753b678568f73a4ca4fe121

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

drumonii

commit sha c061b0820285769d462b9c85c248c9965ab481ab

Update test JSON files to 9.21.1

view details

drumonii

commit sha 9a41dc2f611cbae5426c7c1c94d4df97cde8ad10

Create JobLauncherTestUtils bean(s) for job tests Instead of declaring a JobLauncherTestUtils for each batch job config test, declare them programmatically in a BeanFactoryPostProcessor depending on the job being tested.

view details

drumonii

commit sha 209711b994c7ef845c31f65f3bf732f20fb8fc83

Upgrade Angular to 8.2.12 and cli to 8.3.14

view details

drumonii

commit sha 465703036f9b66c1fce020e72db9b63360fcdf27

Improve jsonPath assertions of qbe tests To ensure the QueryByExampleFromSpecificationPredicateBuilder is still needed and not replaced by Spring Data's own QueryByExamplePredicateBuilder, the qbe tests should enhance their jsonPath assertions with proper Hamcrest matchers.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha fb64f4a757a5115715a905036b411d7791c6e02d

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha 5dc0e42308f9865a666de28a1a88e9ff04a6e52d

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha 381ce69647ca83c2be27a253f10d3869c58b1da5

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha 06e3a6c9ea56e70adaf26e218529ba045a82609c

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha f20c1e9269668ec1d9d746c271520e20ba7ab08b

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 05daa1b401d368acc438496f6caeb3fe025f75dc

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha eedb287a5f1f535bea8112f08cc99fffec582389

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha 5fb5c55ed1d0acd94b38fa2f8db33ddf1816414c

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha f346a502de0c605d3f6c99dfdef64800d78f86f1

Use ParameterizedTest where applicable

view details

drumonii

commit sha 9b907fdfb24db48ae43892688133dee21be61b47

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha e30d4dc0ae128c10ee27566f78b38a53499eb61d

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha e57fdfcc36942131c47dc55db034dbed56856729

Group service tests with Nested for readability

view details

drumonii

commit sha 7f52e137dea21fcc132b5d92bf6a40e695677562

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

drumonii

commit sha fd14591bf6b439387bfb96a3e7b18dbe94b5e3cd

Move API controller logic into API services

view details

drumonii

commit sha 3ec500a2a531ab176e8be25c29b2758666c9eb7c

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

drumonii

commit sha 81bdc6466545aa493b06f2dca1a0f5d39936699d

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

drumonii

commit sha 9ff28eaa2d34c5a5506503001cd52aeb1cfa3bc1

Update test JSON files to 9.21.1

view details

drumonii

commit sha 8efca2bab00aab515eccc9f01923e975bb97a83a

Create JobLauncherTestUtils bean(s) for job tests Instead of declaring a JobLauncherTestUtils for each batch job config test, declare them programmatically in a BeanFactoryPostProcessor depending on the job being tested.

view details

drumonii

commit sha 391a72834bcd2ed59d3ea604e51d26b5280cbeaa

Upgrade Angular to 8.2.12 and cli to 8.3.14

view details

drumonii

commit sha 4b5e6361669d9a8b96fd00ddf1115634b4fe5a1e

Improve jsonPath assertions of qbe tests To ensure the QueryByExampleFromSpecificationPredicateBuilder is still needed and not replaced by Spring Data's own QueryByExamplePredicateBuilder, the qbe tests should enhance their jsonPath assertions with proper Hamcrest matchers.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 1c0cb739887e8ae9a0b858e9ed41914efffc1264

Upgrade Angular to 8.2.13 and cli to 8.3.17

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 76b5666b6e038b7ae4a4fc64f637b6724ee2de15

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha f71de2a03d5bb5707858729c8ed19321e8eefeab

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha 5bc98fdca55af41d55af11f93914476ee9a061cf

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha 8e6813f316283b4c30f18b2342d24848146166c4

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha 5a4d9d255676474fd0747acfe9011b3bc2b66fde

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 0b84ef520008f45b67d95c5c1dd2bd1b1e7a678b

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha cefd004c2e8644d46eb4134386f75ee1b10613e1

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha f0b699eec8c67a1570acea155e311a2003a1e72b

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha bf8df5ff4dd300a28cc33574935cc00e4a115558

Use ParameterizedTest where applicable

view details

drumonii

commit sha 708322afc217f00ee92bf43d21b8cf2cb4530a7f

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha 1a06089f87f0f8ea44c1f4857562477d30c97fac

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha 2a67ae7bc7ddf8f8830e9e798ea74958fe3614c5

Group service tests with Nested for readability

view details

drumonii

commit sha e22f2bc69cd2b98d5bcc81fb77910bcaf5c6b9af

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

drumonii

commit sha e0f2e4d86d3007aa2ef311274f00ab3a0f01ab9d

Move API controller logic into API services

view details

drumonii

commit sha b630dd297caa5e2cc4d82f6f3feb5f63faf11e1a

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

drumonii

commit sha 5ab0e8bbbd90e93766886da6a383d6e4b5982c23

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

drumonii

commit sha 307cbcea409bee391d6b23b5b05a189c3ca5c5d8

Update test JSON files to 9.21.1

view details

drumonii

commit sha cf9fc6518eeea16dac8392607bef4b70e8c585ca

Create JobLauncherTestUtils bean(s) for job tests Instead of declaring a JobLauncherTestUtils for each batch job config test, declare them programmatically in a BeanFactoryPostProcessor depending on the job being tested.

view details

drumonii

commit sha 2b51d98e9dc26b122ec026638dc5228a4c4ef7bc

Upgrade Angular to 8.2.12 and cli to 8.3.14

view details

drumonii

commit sha 314a38c28bde2b52225661ac4ac52cc2621d8c71

Improve jsonPath assertions of qbe tests To ensure the QueryByExampleFromSpecificationPredicateBuilder is still needed and not replaced by Spring Data's own QueryByExamplePredicateBuilder, the qbe tests should enhance their jsonPath assertions with proper Hamcrest matchers.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 0b18fba8192bd0a4c18f0bec152d64c90676fbe3

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha b7a41e0693dd41f170b0e56f28661d267e171ec4

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha 0083823534958104d6dbba92da3ad0fc101e1bf5

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha 55ed27cc855af34d112d354bfdaae9ab9723f3cd

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha ce98150d5a6f06d1d40e0e190e1602a92d582f02

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 639f40158b44c73b1e3a4bf058cc817557fbc2e0

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha 4e14c3a8752f082c08fe0089539c0397624c651c

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha 363a9c71998116b574b2c176ee43f33c377e01b2

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha 35189209cc14fa79355c8ceaa553f160cd958717

Use ParameterizedTest where applicable

view details

drumonii

commit sha 9619f5cedf873a74bb4bdc8ee112063abcf721e5

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha ea123b2c7985fa56e901c81781aa3dd6dd0218de

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha 3ef90c85fedae37ee53fe0b63c9ad6366a86a93a

Group service tests with Nested for readability

view details

drumonii

commit sha 768ba548f36fc656388e466d0c86d1d440c564d0

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

drumonii

commit sha 1b80bd48368f4f0bf6830a7da68fe9e9d6b95b50

Move API controller logic into API services

view details

drumonii

commit sha 7b99a423d3da22353b41c80746e60f8be42824da

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

drumonii

commit sha 50e4cb16a5897a953f7228d70e88ce33ecf6b2be

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

drumonii

commit sha 8d7e3bf0939b4f6a02bcb8f0625e6773ce9d9d1d

Update test JSON files to 9.21.1

view details

drumonii

commit sha 7503eada22514429a4d0978fef8c1fdfd01edd6c

Create JobLauncherTestUtils bean(s) for job tests Instead of declaring a JobLauncherTestUtils for each batch job config test, declare them programmatically in a BeanFactoryPostProcessor depending on the job being tested.

view details

drumonii

commit sha 4a4904650d99e3eabeacb0eb7f5ef2486dd8fab6

Upgrade Angular to 8.2.12 and cli to 8.3.14

view details

drumonii

commit sha cee0ee240be0305e9125c9d12418e7fe63856bf4

Improve jsonPath assertions of qbe tests To ensure the QueryByExampleFromSpecificationPredicateBuilder is still needed and not replaced by Spring Data's own QueryByExamplePredicateBuilder, the qbe tests should enhance their jsonPath assertions with proper Hamcrest matchers.

view details

push time in 4 months

push eventdrumonii/spring-security

Drummond Dawson

commit sha 5dadce97e46d349b89c1a5b5f925282693e67eb3

Support URI vars in formLogin and logout MockMvc requests

view details

push time in 4 months

pull request commentspring-projects/spring-security

Support URI vars in formLogin and logout MockMvc requests

@eleftherias sounds reasonable to me! I've force pushed those changes for formLogin and logout with their respective builders.

drumonii

comment created time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 8fe013ef9ed53702ff26a533cc2c8164d747eb9d

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha c8166c1e122bea90274ab32e34d705626e386aa1

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha 8439b5b6d16f07b7bccdfb6f7af17cb10c25c993

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha d32e8251e60a5abb6d542a85eab4e161e129a7c9

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha f097cad0946c535f075f178fa8ab4634441e08b0

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha a1a61c0ab01ccfd1dec8cc2e34a2621023413eef

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha a8c7ee7f79eec4383c512d55bebdab73beee71a8

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha 19b3fd7f2701871e58e12b09bd6cd8a1faf09689

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha 6da9309c0b67f8f3ec20b3116f557024776df226

Use ParameterizedTest where applicable

view details

drumonii

commit sha 4765933ab4c55fe5ad8ed2c4c06a7f0b163c344d

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha 19960474d4465d5ab6a5123b686d0b4acc328c19

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha b84fd8e0ca5867b948b443a75d7285d5dba0d3d7

Group service tests with Nested for readability

view details

drumonii

commit sha 071025ae5b5e2135bd09a5dde2ac51db15a6035e

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

drumonii

commit sha 8e596bceeadebc0da94f8accb79a0eebf58634fd

Move API controller logic into API services

view details

drumonii

commit sha 3ed6d2c5683167a2e4cebf9dc10e9c0287e1d0e2

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

drumonii

commit sha 220c34c7df57b59cac5d15bf2dcba4ab00f73c41

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

drumonii

commit sha d33f5ba7b11d5348eaa2b128e7c2a43c202ffb77

Update test JSON files to 9.21.1

view details

drumonii

commit sha bb96045c6db0604606cb51b746ce646fb190e503

Create JobLauncherTestUtils bean(s) for job tests Instead of declaring a JobLauncherTestUtils for each batch job config test, declare them programmatically in a BeanFactoryPostProcessor depending on the job being tested.

view details

drumonii

commit sha b688e5a5ab113eed630d53b1ef2245a56d0c3ba0

Upgrade Angular to 8.2.12 and cli to 8.3.14

view details

drumonii

commit sha d8e1cda4afdf12f86f426f4f15b166d1cdb93b5e

Improve jsonPath assertions of qbe tests To ensure the QueryByExampleFromSpecificationPredicateBuilder is still needed and not replaced by Spring Data's own QueryByExamplePredicateBuilder, the qbe tests should enhance their jsonPath assertions with proper Hamcrest matchers.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 79381b8428bc4a3c0e8278037cb33be5abace1c3

Move API controller logic into API services

view details

drumonii

commit sha 86d70a03cc901c2df3f5ed7cb352d354ec11ac52

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

drumonii

commit sha 7cb109df9f7283f9039c5c1af87003168a281aee

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

drumonii

commit sha 83d47c19deb4dc47e891f5a27e37f6eda24a65e7

Update test JSON files to 9.21.1

view details

drumonii

commit sha fca69f592993119a5f9264821c13f146a7d4bf72

Create JobLauncherTestUtils bean(s) for job tests Instead of declaring a JobLauncherTestUtils for each batch job config test, declare them programmatically in a BeanFactoryPostProcessor depending on the job being tested.

view details

drumonii

commit sha fa846c1f31d398578b07e239888834e9814e5b92

Upgrade Angular to 8.2.12 and cli to 8.3.14

view details

drumonii

commit sha c59c45555adc7d489bca432bcd740afe52d4dd01

Improve jsonPath assertions of qbe tests To ensure the QueryByExampleFromSpecificationPredicateBuilder is still needed and not replaced by Spring Data's own QueryByExamplePredicateBuilder, the qbe tests should enhance their jsonPath assertions with proper Hamcrest matchers.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 1cdba9eeaf1738b85fe88f23a62af6b5d4c1a826

Improve jsonPath assertions of qbe tests To ensure the QueryByExampleFromSpecificationPredicateBuilder is still needed and not replaced by Spring Data's own QueryByExamplePredicateBuilder, the qbe tests should enhance their jsonPath assertions with proper Hamcrest matchers.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha c8c3df74a45c1049d03d9e3a8936115600cc0cbb

Upgrade Angular to 8.2.12 and cli to 8.3.14

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 3637fc0841c6dda96d4235a9f281990ed959ed8a

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha 197d0ae1860ccec39a9b610519e9d94d7aa838e3

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha b3fbd31b6102f9b37360090795ece367443e816f

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha f65ee69a43b9f61337ec17f28bec746fec6573e3

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha e65c60fd799253f625916ca4809249d2703804ba

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 1e551a4a44d658f7468d33a78d9dc0b1e0d68d6c

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha 820b71dcf1d46bfdc2fbe05b3f25c0e5b69d00d1

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha b75fe66c784fef084c2d55546a3d8654f63774e2

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha 5ab05bc48950dce595186213ea4f674c22e2e8c0

Use ParameterizedTest where applicable

view details

drumonii

commit sha dd59d376023120f3d02ef7321c1a67ff543cb9bb

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha 100b2f15662d7a5347bf9020967cb166576b7454

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha 9244075b42d2671e6ec067a5292346e857c1b08b

Group service tests with Nested for readability

view details

drumonii

commit sha ae6d07bf468a8c1998f686c3aa3e932a87bb5ce9

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

drumonii

commit sha 54818fa1dc896e1baa6abf81c873e8a09ed9b82e

Move API controller logic into API services

view details

drumonii

commit sha e662dda9eb59f0d1c60be34eea2c5c261aacf053

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

drumonii

commit sha 1dbbe68905a0ae023450e1b8bbc0974f07e0e356

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

drumonii

commit sha 6e6a848c59c6436ee78be6f52e70bde00183d503

Update test JSON files to 9.21.1

view details

drumonii

commit sha 5698a7946bbaeffa7d39b445f8ed3557aa92f21d

Create JobLauncherTestUtils bean(s) for job tests Instead of declaring a JobLauncherTestUtils for each batch job config test, declare them programmatically in a BeanFactoryPostProcessor depending on the job being tested.

view details

push time in 4 months

pull request commentspring-projects/spring-security

Support URI vars in formLogin and logout MockMvc requests

Thanks for the feedback @eleftherias

This is essentially a convenience method that is modeled after mockMvc's perform actions such as get, post, etc. that all take Object... uriVars as the last method parameter. Since formLogin and logout are mockMvc perform actions, I would have expected them to act similar. So I thought it would be appropriate for them reciprocate with Object... uriVars in their method signatures. I have tried to mimick the uriVars MockHttpServletRequestBuilder logic for URI variables as part of formLogin and logout.

So I would presume those the existing mockMvc perform actions have the same issues as you pointed. But to answer your concerns:

  • given the incorrect number of parameters, an IAE is thrown
  • given there aren't placeholders but parameters passed, then the URL specified is used as is with no exception thrown
drumonii

comment created time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 3a0f0c66792c18dd7d4a13d9e3585d38f6a127c7

Remove unnecessary path attribute in mapping annotations Since only path is specified in the mapping annotation, it can be omitted.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha c2cf53b8cc02dd45f8b403d263c1e8e94e014ab2

Use the nested builder support in HttpSecurity DSL of WebSecurityConfig

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 658eb2b13b4dcfd7bfdd08f3cce0b9ec6a794534

Rename rest package to api Because the rest controllers reside under the api base path, it makes more sense for the rest package to become the api package.

view details

drumonii

commit sha 6b2a71e7cb473bf1a114883a5e22fa4d1cf047f4

Use sessionStorage for temporarily storing admin user details The admin user details was meant to be stored temporarily in browser storage as part of server side session, therefore sessionStorage is the better choice.

view details

drumonii

commit sha bb0237ff218b677c3351da075d4de8ddec25895e

Upgrade Angular to 8.2.11 and cli to 8.3.9

view details

drumonii

commit sha 05ee098a15441a28cb4b4064b0b2d38c54e95b86

Upgrade Angular cli to 8.3.12

view details

drumonii

commit sha 5f4d7c79dfb591c33b5a037829fabeccf1983b6e

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha e14d2a04a591031f3ff2e560fdbc13f5bdce3a2c

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha f0ad363e3dd77e26ab74349427ace9b52008fabe

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha 53139f3c89173dcaf7606efcd0fcba5769be9077

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha 96509c0fa8c3e6920dc388340d59c3e320090a96

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 423044c6a300e070e320e51e5ebe23e3154dcba6

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha b96db1b1f1143a0ab8d5d5f6e36fef9eb7db53b3

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha 8ecfd8ab09327c67ce370dc722ed9d4f47f221f8

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha f597fd480214f6fcb2ef9c13d6f7885599b44276

Use ParameterizedTest where applicable

view details

drumonii

commit sha 13301e136b260e73b0e4d00307c4b6de435cb6e5

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha 8c1d9de8c809f578dc4d04f8843738ed2e0b807d

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha c9b2ca00a1c000cc08e47106cf1b5dd5f1a5ac4a

Group service tests with Nested for readability

view details

drumonii

commit sha f2e42324d0f696e5e586b4416ebfd7c0fbf6a944

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

drumonii

commit sha 7b52c43f665ab8ce3101ab306626b07fcb42fb6f

Move API controller logic into API services

view details

push time in 4 months

fork drumonii/frontend-maven-plugin

"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins." A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.

fork in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha b5cd8729262471d817c7e50d0c51544de1a74577

Group service tests with Nested for readability

view details

drumonii

commit sha 5d228c4d1bc5db1e929bada95ea26eef279b77dc

Move EnableConfigurationProperties RiotApiProperties to RiotApiConfig

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 25ef8385f9a2587dbf911ab6b3e5c9bac8c3d298

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha 26989662a84e9b6312d6d377bd891fd575e7fd07

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha f32b6f47ec4713f1b1bddf8de5508715665f736b

Use ParameterizedTest where applicable

view details

drumonii

commit sha c78c3b100e07ae2803d239c5f43111820f8f44f3

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha 7ce8a0c5aa86abbf7fb614afbc71f89767f9db29

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

drumonii

commit sha 727c06a248af71b066e370378d50b9469d7af1c9

Group service tests with Nested for readability

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 8520826b42e1087cc6f571a4068c1eca5b48b873

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha 582665b62b2672aa75c1a029ad898d23adae3639

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha f417f050e64fa173b8d658f9910f8ad5de4ad516

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha 9b58ed1e3f330d83345be3f6f94bd89ad472452e

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha 01acca785cf8b61e6543b6796fcbe8e0d43cd9d0

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 31744641ad8483e9635d4f29fbb4a1664ffd7238

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha 38ecc2568becc68e23370764fb5a4b1798730556

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha c76933dd5629d1baa17503a74e10a861c7146560

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha f3a250a9057ff5debd87af797e0f82f420bc2680

Use ParameterizedTest where applicable

view details

drumonii

commit sha 23d6121d10d1432a2a5b63a80bf50abfee016eed

Upgrade node to latest LTS 12.13.0

view details

drumonii

commit sha c4a28670488ed9946611fd1ae3b27f4afb39d51f

Set proxyBeanMethods to true on @Configurations Since no beans defined in the configuration classes are referenced using their methods, it's safe to set proxyBeanMethods to false for performance improvements.

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 69cfde6af129602d25cc6c613dde7982628aeb86

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha d2ba2ed24ba0ed360cbe5dfc9f8c0733c27f74fb

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha 19fc741348ed018134e85e19d17677c84fbac689

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha 2f86f5fd7b0214b4b9340e3c2d1bee8916c57d07

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha 3a8a344763dc7ac73959c05b719b204ee0e782d0

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha a82d24095262e75cdc2cba8cd41a2155c6ce73cf

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha 4e31149ed65d12713359650921fbebe694374d22

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha b9c78879a82580fcb177be8da2f472bb4121a159

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha 4cce11a2e0873acff69246afcf42cd69a58896f7

Use ParameterizedTest where applicable

view details

drumonii

commit sha d6c8a8710fc10893209408b2bbf8213a41527fa8

Upgrade node to latest LTS 12.13.0

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 1e71e1cadf491d7e4dd65d12fa168bc7172fbc29

Upgrade node to latest LTS 12.13.0

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 0b159ce03a8becc170d4d607ecfaa66f9df3f54c

Restyle components using Nebular https://github.com/akveo/nebular/

view details

drumonii

commit sha 28ad0ebef52f71db14d1c67f418f237e9e6811ef

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha cf8247765b5c1fb5106658000ed8990efc456877

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha da0d48b7a0fc2ad0056c0d01ae4c271a27b4b892

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha 95e3e6b4d5ab258f8cc8108d7ef183526c110ef4

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 97ac7e22498e298c4cb8d84dacaecd53e3843d76

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha e6180a25d691f6e8933726bb37092f917e9591a2

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha 3c175a281f120fa93716f530e3b717b0e1a730cc

Build AdminUserDetails from UserDetails instead of User

view details

drumonii

commit sha b73b83c2c1d64f53dacf2b4b42b8ed25b1288b24

Use ParameterizedTest where applicable

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 7adc94292766b8bc737a40bd007b3866fb70d33d

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

drumonii

commit sha 623419c3c21ca73da9c73b4a9d8ba0b1c1fcc592

Build AdminUserDetails from UserDetails instead of User

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 258f8c8a1d9730aaeb9affecef786d0fd3db8111

Build AdminUserDetails from UserDetails instead of User

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 6c1e942a96888ed18800f8d4aa69214c882fb05c

Upgrade Spring Boot to 2.2.0

view details

drumonii

commit sha 463a5f1fa73a0bbbf8153e6e141e3fd844e020f6

Fix compile issues related to Hibernate 5.4

view details

drumonii

commit sha 06cdd99f30ac045b10f2e5b0c571ab35fb8422e4

Remove deprecated APPLICATION_JSON_UTF8 in favor of APPLICATION_JSON

view details

drumonii

commit sha f9d5e17094a1712c0d0f9b3798d77e9036ea0bbb

Remove disabling HttpHiddenMethodFilter as it's disabled by default In Spring Boot 2.2, HttpHiddenMethodFilter is disabled by default.

view details

drumonii

commit sha 5549bbd7de18cc37830d5212b6fa846ba8ca31a5

Remove disabling JMX as it's disabled by default In Spring Boot 2.2, JMX is disabled by default.

view details

drumonii

commit sha 04b2a6c486694e847643e15cf0eb2f2c3def742f

Update tests to run with JUnit 5 * Removed @RunWith(SpringRunner.class) * Removed @RunWith(JUnit4.class) * Replaced @Test imports * Replaced @Before with @BeforeEach * Replaced @Ignore with @Disabled * Made public @Tests package private * Made test classes package private * Added @ExtendWith(SpringExtension.class) to custom test slices * Replaced @RunWith(MockitoJUnitRunner.class) with @ExtendWith(MockitoExtension.class) - for MockitoJUnitRunner.Silent.class added @MockitoSettings(strictness = Strictness.LENIENT)

view details

push time in 4 months

push eventdrumonii/LeagueTrollBuild

drumonii

commit sha 1523121c8b909a8c0e81de93f3f8623a46c4fd16

Test with data-e2e attributes for admin Instead of using ids or classes that have no styling to select elements in tests, which are brittle and subject to to change easily, use data-e2e attributes for querying elements in the dom.

view details

drumonii

commit sha afeca3ea14d8ac9b63e93dd0bdc910f28a9c62dd

Upgrade Spring Boot to 2.1.9

view details

drumonii

commit sha ace6d4c3e969438216d8f761ca7d3399bca11cca

Migrate off deprecated ehcache configuration properties maxElementsInMemory -> maxEntriesLocalHeap maxElementsOnDisk -> maxEntriesLocalDisk

view details

drumonii

commit sha d1eca4335c27e9754f7b3f0409c6f7b4b9d54a06

Set cache max entries to unlimited disk where applicable For summoner spells and maps cache there are not enough entries to warrant a disk maximum for the caches.

view details

drumonii

commit sha 7015f93e7e986e327d891a89db2c2986a917637f

Upgrade Angular to 8.2.10 and cli to 8.3.8

view details

drumonii

commit sha 1bcc879d002933c21c7e4740999cb72a7a0d6fa2

Upgrade Clarity to 2.2.2

view details

drumonii

commit sha f0950dd6efe5dcd2532602e43be7adc9b9f91ed3

Support error HTML by forwarding to the appropriate index.html Depending on the path requested, forward to the appropriate index.html path on error HTML.

view details

drumonii

commit sha 84b582a1efe03af7c570c3e41f92b2f61b8520af

Simplify url creations with usage of TestRestTemplate The TestRestTemplate will automatically connect to the embedded server if the URL is not absolute.

view details

drumonii

commit sha 7241bc447d432d20995f2a94c9097aac7a8a3b7a

Rename controller package to routing Since the sole purpose of the controllers are to forward to index.html so that Angular can handle the route, routing is more suitable name for the package.

view details

drumonii

commit sha 6d33d77e845b42dfe59b7abb00594bdb6b684609

Rename rest package to api Because the rest controllers reside under the api base path, it makes more sense for the rest package to become the api package.

view details

drumonii

commit sha 37775bc29f69bf0c33dd9b2279e9573cc2c33af6

Use sessionStorage for temporarily storing admin user details The admin user details was meant to be stored temporarily in browser storage as part of server side session, therefore sessionStorage is the better choice.

view details

drumonii

commit sha 6c9445c394ea0688c46cf215631dfc26378f8663

Upgrade Angular to 8.2.11 and cli to 8.3.9

view details

drumonii

commit sha eed65a2178aa03fb4b1b8cf56fe4aae0689b3fa7

Upgrade Angular cli to 8.3.12

view details

drumonii

commit sha d904d7d167f2891ab1855626ad3b199148b711b6

Restyle components using Nebular https://github.com/akveo/nebular/

view details

push time in 4 months

delete branch drumonii/LeagueTrollBuild

delete branch : @nebular

delete time in 4 months

delete branch drumonii/LeagueTrollBuild

delete branch : sb-2.2

delete time in 4 months

more