profile
viewpoint

ciudadanointeligente/write-it 36

App to create and send messages to public persons. It's a component of POPLUS project.

dracos/check-pip-dependencies 8

Monkeypatch script to run pip install --no-install and highlight dependency conflict issues not otherwise caught.

dracos/bach.js 3

A JavaScript library that scans harmony for ‘rule’ “violations”.

dracos/abovebrum 2

Code that powers the abovebrum Twitter account.

dracos/alaveteli 1

Provide a Freedom of Information request system for your jurisdiction

dracos/ansible-server 1

Playbook for setting up a server (currently for Theatricalia)

ciudadanointeligente/writeit-django 0

writeit api client for django

dracos/accessible-autocomplete 0

An autocomplete component, built to be accessible.

dracos/annual-report 0

Simple static site describing my year in numbers

dracos/aws-blocker 0

A simple bash script to block all AWS IP ranges using iptables.

pull request commentmysociety/fixmystreet

[Hackney] Custom domain for email envelope

(well, vworp apart from the test failures)

davea

comment created time in 3 days

PR opened mysociety/fixmystreet

Reviewers
Fix duplicate asset selection message

Fixes https://github.com/mysociety/fixmystreet-commercial/issues/1920 And default as I found another type of street light not covered when I did https://github.com/mysociety/fixmystreet/pull/3070

+8 -3

0 comment

3 changed files

pr created time in 3 days

create barnchmysociety/fixmystreet

branch : fix-duplicate-asset-selection-message

created branch time in 3 days

PR opened mysociety/fixmystreet

HE/council category interaction fixes

Fixes https://github.com/mysociety/fixmystreet-commercial/issues/1927 [skip changelog]

Should fix both the issues in that ticket, and tidies some bits up in the middle to make the second fix easier.

+47 -80

0 comment

15 changed files

pr created time in 3 days

create barnchmysociety/fixmystreet

branch : he-category-interactions

created branch time in 3 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha d1c38a2bdbe5891fa63bde40e398e3cc33881566

Improve Bing geocoder results. Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.

view details

Dave Arter

commit sha c7cc69f6cd5e7f91a48223dd0194aeed39b8e59e

[Bromley] Use HTTPS scheme for bromley.gov.uk links/search form Also updates the search form URL as the old one had stopped working.

view details

Joe Siltberg

commit sha 655174d175e034b078141c33e5a5f848d255f7f9

Internationalization of the heatmap page. Fixes #3096

view details

Dave Arter

commit sha 3c98b8f4dbe7085d52887deff90681db552fb580

[BANES] Use HTTPS scheme for bathnes.gov.uk links/search form

view details

Matthew Somerville

commit sha 51eae76dd663d23c1f4bb1e809e9c258e800cb73

Only show access tokens once, and store hashed.

view details

M Somerville

commit sha 1909028b0956cbd0bf4ed17d8be942bd6f77e78c

[Docker] Specify MAPIT_URL. Letting the code pick a default MAPIT_URL means it picks port 8000, which will not work with the current Docker container setup.

view details

Matthew Somerville

commit sha e623594f10d74a8dfb5eaea801c43f4996b15a1e

Include file extensions in Dropzone acceptedFiles. In my Firefox on Windows, .jpeg files are not otherwise shown.

view details

Matthew Somerville

commit sha 47df99daf6371eb3d7cdbe1ac9170a7f88749dc1

Fix photo orientation in modern browsers. We use Dropzone (the photo upload library) to shrink photos client-side before uploading in the background and display thumbnails. For the resized upload, Dropzone restores the original Exif data, including orientation, so it can be correctly oriented server-side; for a thumbnail, it orients the image itself for immediate display. Recently, browsers have started honouring Exif orientation much more widely (Chrome 81+ and Firefox 77+ both now do it by default). This means the data Dropzone gets from a resize has already been oriented according to the Exif orientation data. Then Dropzone either looks at the orientation to correct for display (thumbnail), or adds back the Exif orientation data (upload) – in both cases, this leads to a double implementation of the orientation, and an incorrect display. To fix this, if we detect we are on a modern browser, we do not try and fix orientation ourself [1], and in all cases we do not add any Exif data back in (we only strip it server-side anyway). Conversely, that means on a non-modern browser, we always perform a manual orientation because no Exif data will be being sent server-side. Also includes a fix to the orientation code [2] which wouldn't be noticed in thumbnail generation as they are square, but could be now we may be orienting full size photos. [1] https://gitlab.com/meno/dropzone/-/merge_requests/80 [2] https://gitlab.com/meno/dropzone/-/merge_requests/45

view details

Matthew Somerville

commit sha 9ebc42d9fd06f0bbcc6ec7316bc7dc74d6eb603c

Merge remote-tracking branch 'Sambruk/internationalize_heatmap'

view details

Matthew Somerville

commit sha a400372142104ce0fcffbe62a3666f8e32e595c4

Merge branch 'fix-client-rotation'

view details

Matthew Somerville

commit sha dd8e2168b6f560dbbe08ee1c461db0d0bebf4326

[IoW] Small refactor of munging functions.

view details

Matthew Somerville

commit sha b4d15f3d19eb95cddd8ba8d8f8eb6c0aed61d0a3

[Hounslow] Factor non-map report creation calls.

view details

Matthew Somerville

commit sha f4691a8277478be5aa67957d2ce8b4fd91825673

Allow extra questions to use a textarea.

view details

Matthew Somerville

commit sha 781cfa1a7de21c5b2d39dbe047fee99e0b3b007c

[Bexley] Factor out BH code, fix offline test.

view details

Matthew Somerville

commit sha 7aefba8b252f48181a68da7b0fdc9b47178c8cbe

[Zurich] Factor out working days calculator.

view details

Martin Wright

commit sha 1df8b7274b1c912a6502f2aebf37eb2601dd9b67

[Bromley] Switch out header font Bromley's live site doesn't seem to have Gill Sans anywhere any more

view details

Matthew Somerville

commit sha 043025c3e1e589f04a21f0a3879fa0bb48a9c500

[Bromley] Add waste service lookup. This creates an integration to view bin collection days, and placeholders for the start of a non-map property-based reporting flow.

view details

Matthew Somerville

commit sha bcf7747c160b430f671d1c7957c19bac5cc00f03

[Bromley] Add waste reporting service. This creates a non-map property-based reporting flow for reporting missed collections and requesting new containers. Such reports are always private, in categories that are hidden from the map filters and never shown on .com.

view details

Matthew Somerville

commit sha 9cd0bfe691026b68253ef080b94f1e991ad8726b

[Bromley] Add general enquiries. This adds general enquiries to the reporting flow.

view details

Matthew Somerville

commit sha 5380e20b8be87ca9692b0af91921344e8cdd5ac9

[Bromley] Report missed bin within 2 working days.

view details

push time in 3 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha d1c38a2bdbe5891fa63bde40e398e3cc33881566

Improve Bing geocoder results. Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.

view details

Dave Arter

commit sha c7cc69f6cd5e7f91a48223dd0194aeed39b8e59e

[Bromley] Use HTTPS scheme for bromley.gov.uk links/search form Also updates the search form URL as the old one had stopped working.

view details

Joe Siltberg

commit sha 655174d175e034b078141c33e5a5f848d255f7f9

Internationalization of the heatmap page. Fixes #3096

view details

Dave Arter

commit sha 3c98b8f4dbe7085d52887deff90681db552fb580

[BANES] Use HTTPS scheme for bathnes.gov.uk links/search form

view details

Matthew Somerville

commit sha 51eae76dd663d23c1f4bb1e809e9c258e800cb73

Only show access tokens once, and store hashed.

view details

M Somerville

commit sha 1909028b0956cbd0bf4ed17d8be942bd6f77e78c

[Docker] Specify MAPIT_URL. Letting the code pick a default MAPIT_URL means it picks port 8000, which will not work with the current Docker container setup.

view details

Matthew Somerville

commit sha e623594f10d74a8dfb5eaea801c43f4996b15a1e

Include file extensions in Dropzone acceptedFiles. In my Firefox on Windows, .jpeg files are not otherwise shown.

view details

Matthew Somerville

commit sha 47df99daf6371eb3d7cdbe1ac9170a7f88749dc1

Fix photo orientation in modern browsers. We use Dropzone (the photo upload library) to shrink photos client-side before uploading in the background and display thumbnails. For the resized upload, Dropzone restores the original Exif data, including orientation, so it can be correctly oriented server-side; for a thumbnail, it orients the image itself for immediate display. Recently, browsers have started honouring Exif orientation much more widely (Chrome 81+ and Firefox 77+ both now do it by default). This means the data Dropzone gets from a resize has already been oriented according to the Exif orientation data. Then Dropzone either looks at the orientation to correct for display (thumbnail), or adds back the Exif orientation data (upload) – in both cases, this leads to a double implementation of the orientation, and an incorrect display. To fix this, if we detect we are on a modern browser, we do not try and fix orientation ourself [1], and in all cases we do not add any Exif data back in (we only strip it server-side anyway). Conversely, that means on a non-modern browser, we always perform a manual orientation because no Exif data will be being sent server-side. Also includes a fix to the orientation code [2] which wouldn't be noticed in thumbnail generation as they are square, but could be now we may be orienting full size photos. [1] https://gitlab.com/meno/dropzone/-/merge_requests/80 [2] https://gitlab.com/meno/dropzone/-/merge_requests/45

view details

Matthew Somerville

commit sha 9ebc42d9fd06f0bbcc6ec7316bc7dc74d6eb603c

Merge remote-tracking branch 'Sambruk/internationalize_heatmap'

view details

Matthew Somerville

commit sha a400372142104ce0fcffbe62a3666f8e32e595c4

Merge branch 'fix-client-rotation'

view details

Matthew Somerville

commit sha dd8e2168b6f560dbbe08ee1c461db0d0bebf4326

[IoW] Small refactor of munging functions.

view details

Matthew Somerville

commit sha b4d15f3d19eb95cddd8ba8d8f8eb6c0aed61d0a3

[Hounslow] Factor non-map report creation calls.

view details

Matthew Somerville

commit sha f4691a8277478be5aa67957d2ce8b4fd91825673

Allow extra questions to use a textarea.

view details

Matthew Somerville

commit sha 781cfa1a7de21c5b2d39dbe047fee99e0b3b007c

[Bexley] Factor out BH code, fix offline test.

view details

Matthew Somerville

commit sha 7aefba8b252f48181a68da7b0fdc9b47178c8cbe

[Zurich] Factor out working days calculator.

view details

Martin Wright

commit sha 1df8b7274b1c912a6502f2aebf37eb2601dd9b67

[Bromley] Switch out header font Bromley's live site doesn't seem to have Gill Sans anywhere any more

view details

Matthew Somerville

commit sha 043025c3e1e589f04a21f0a3879fa0bb48a9c500

[Bromley] Add waste service lookup. This creates an integration to view bin collection days, and placeholders for the start of a non-map property-based reporting flow.

view details

Matthew Somerville

commit sha bcf7747c160b430f671d1c7957c19bac5cc00f03

[Bromley] Add waste reporting service. This creates a non-map property-based reporting flow for reporting missed collections and requesting new containers. Such reports are always private, in categories that are hidden from the map filters and never shown on .com.

view details

Matthew Somerville

commit sha 9cd0bfe691026b68253ef080b94f1e991ad8726b

[Bromley] Add general enquiries. This adds general enquiries to the reporting flow.

view details

Matthew Somerville

commit sha 5380e20b8be87ca9692b0af91921344e8cdd5ac9

[Bromley] Report missed bin within 2 working days.

view details

push time in 3 days

PR merged mysociety/fixmystreet

Fix photo orientation in modern browsers.

( Example orientation photos can be found at https://github.com/recurser/exif-orientation-examples )

We use Dropzone (the photo upload library) to shrink photos client-side before uploading in the background and display thumbnails. For the resized upload, Dropzone restores the original Exif data, including orientation, so it can be correctly oriented server-side; for a thumbnail, it orients the image itself for immediate display.

Recently, browsers have started honouring Exif orientation much more widely (Chrome 81+ and Firefox 77+ both now do it by default). This means the data Dropzone gets from a resize has already been oriented according to the Exif orientation data. Then Dropzone either looks at the orientation to correct for display (thumbnail), or adds back the Exif orientation data (upload) – in both cases, this leads to a double implementation of the orientation, and an incorrect display.

To fix this, if we detect we are on a modern browser, we do not try and fix orientation ourself - https://gitlab.com/meno/dropzone/-/merge_requests/80 - and in all cases we do not add any Exif data back in (we only strip it server-side anyway). Conversely, that means on a non-modern browser, we always perform a manual orientation because no Exif data will be being sent server-side.

Also includes a fix to the orientation code - https://gitlab.com/meno/dropzone/-/merge_requests/45 -which wouldn't be noticed in thumbnail generation as they are square, but could be now we may be orienting full size photos.

Also also includes extensions in accepted photo upload, as otherwise I don't see .jpeg files in Firefox on Windows.

(PS Looked at upgrading dropzone at same time, but didn't seem to add/fix anything important plus would need CSS fix as they've made main text a button. Chunked uploading would need more work too)

+317 -41

1 comment

4 changed files

dracos

pr closed time in 4 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha e623594f10d74a8dfb5eaea801c43f4996b15a1e

Include file extensions in Dropzone acceptedFiles. In my Firefox on Windows, .jpeg files are not otherwise shown.

view details

Matthew Somerville

commit sha 47df99daf6371eb3d7cdbe1ac9170a7f88749dc1

Fix photo orientation in modern browsers. We use Dropzone (the photo upload library) to shrink photos client-side before uploading in the background and display thumbnails. For the resized upload, Dropzone restores the original Exif data, including orientation, so it can be correctly oriented server-side; for a thumbnail, it orients the image itself for immediate display. Recently, browsers have started honouring Exif orientation much more widely (Chrome 81+ and Firefox 77+ both now do it by default). This means the data Dropzone gets from a resize has already been oriented according to the Exif orientation data. Then Dropzone either looks at the orientation to correct for display (thumbnail), or adds back the Exif orientation data (upload) – in both cases, this leads to a double implementation of the orientation, and an incorrect display. To fix this, if we detect we are on a modern browser, we do not try and fix orientation ourself [1], and in all cases we do not add any Exif data back in (we only strip it server-side anyway). Conversely, that means on a non-modern browser, we always perform a manual orientation because no Exif data will be being sent server-side. Also includes a fix to the orientation code [2] which wouldn't be noticed in thumbnail generation as they are square, but could be now we may be orienting full size photos. [1] https://gitlab.com/meno/dropzone/-/merge_requests/80 [2] https://gitlab.com/meno/dropzone/-/merge_requests/45

view details

Matthew Somerville

commit sha a400372142104ce0fcffbe62a3666f8e32e595c4

Merge branch 'fix-client-rotation'

view details

push time in 4 days

push eventmysociety/fixmystreet

Joe Siltberg

commit sha 655174d175e034b078141c33e5a5f848d255f7f9

Internationalization of the heatmap page. Fixes #3096

view details

Matthew Somerville

commit sha 9ebc42d9fd06f0bbcc6ec7316bc7dc74d6eb603c

Merge remote-tracking branch 'Sambruk/internationalize_heatmap'

view details

push time in 4 days

issue closedmysociety/fixmystreet

Internationalization of the heatmap

Some of the text strings in the heatmap are not possible to translate.

closed time in 4 days

joesiltberg

push eventmysociety/fixmystreet

M Somerville

commit sha 1909028b0956cbd0bf4ed17d8be942bd6f77e78c

[Docker] Specify MAPIT_URL. Letting the code pick a default MAPIT_URL means it picks port 8000, which will not work with the current Docker container setup.

view details

Matthew Somerville

commit sha e623594f10d74a8dfb5eaea801c43f4996b15a1e

Include file extensions in Dropzone acceptedFiles. In my Firefox on Windows, .jpeg files are not otherwise shown.

view details

Matthew Somerville

commit sha 47df99daf6371eb3d7cdbe1ac9170a7f88749dc1

Fix photo orientation in modern browsers. We use Dropzone (the photo upload library) to shrink photos client-side before uploading in the background and display thumbnails. For the resized upload, Dropzone restores the original Exif data, including orientation, so it can be correctly oriented server-side; for a thumbnail, it orients the image itself for immediate display. Recently, browsers have started honouring Exif orientation much more widely (Chrome 81+ and Firefox 77+ both now do it by default). This means the data Dropzone gets from a resize has already been oriented according to the Exif orientation data. Then Dropzone either looks at the orientation to correct for display (thumbnail), or adds back the Exif orientation data (upload) – in both cases, this leads to a double implementation of the orientation, and an incorrect display. To fix this, if we detect we are on a modern browser, we do not try and fix orientation ourself [1], and in all cases we do not add any Exif data back in (we only strip it server-side anyway). Conversely, that means on a non-modern browser, we always perform a manual orientation because no Exif data will be being sent server-side. Also includes a fix to the orientation code [2] which wouldn't be noticed in thumbnail generation as they are square, but could be now we may be orienting full size photos. [1] https://gitlab.com/meno/dropzone/-/merge_requests/80 [2] https://gitlab.com/meno/dropzone/-/merge_requests/45

view details

push time in 4 days

PR merged mysociety/fixmystreet

[Docker] Specify MAPIT_URL.

Letting the code pick a default MAPIT_URL means it picks port 8000, which will not work with the current Docker container setup. Fixes https://github.com/mysociety/fixmystreet/issues/3090

+1 -1

1 comment

1 changed file

dracos

pr closed time in 4 days

issue closedmysociety/fixmystreet

Have 500 error on admin/bodies for docker version installation

Describe the bug install docker version of the project, and I navigate to' http://localhost:8000/admin/bodies', error code 500 without any response message in the terminal.

To Reproduce Steps to reproduce the behavior:

  1. clone the repo
  2. pull the latest tag image
  3. docker-compose up
  4. navigate to admin/bodies, then error code 500

Expected behavior A clear and concise description of what you expected to happen.

Screenshots Capture

closed time in 4 days

biill

push eventmysociety/fixmystreet

M Somerville

commit sha 1909028b0956cbd0bf4ed17d8be942bd6f77e78c

[Docker] Specify MAPIT_URL. Letting the code pick a default MAPIT_URL means it picks port 8000, which will not work with the current Docker container setup.

view details

push time in 4 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 251acf7799e78fd46a39154f0381c7470d5542a9

Skip accounts without email for inactive emails.

view details

Matthew Somerville

commit sha 56d6d1524b4559ca407bcaf33f47a12960e83576

Merge branch 'skip-accounts-without-email'

view details

Matthew Somerville

commit sha 9553c8daac73f06af704a87ace7294f751a77b8f

Add lazy image loading on list items.

view details

Matthew Somerville

commit sha 89bfe7226a2c2202e8151aa32c7648dad9f9f038

[Buckinghamshire] Spot lights e.g. ending with "A"

view details

Matthew Somerville

commit sha dae0ca4686c5613800df5bb792fe803b952f6bde

Small refactor of asset message display. Wherever asset_item_message is checked/used, make sure it does the text replacement and falls back to the default.

view details

Matthew Somerville

commit sha a2b1c1a19327fea4c9a0688cf67affb34ce08726

[UK Councils] Config matches default. With the refactor to make sure asset message always uses the default, no need for these specific config lines any more.

view details

Matthew Somerville

commit sha cd639b946ef6954730e7b027149f21e8561e4582

[East Sussex] Tidy up named select actions.

view details

Matthew Somerville

commit sha 6d3ab9722b91e4929d01d168dfc0dc0916a8b542

Include -p in systemd mkdir command.

view details

Matthew Somerville

commit sha 948338c4cfa30885f552f775a8727bf3b34859f1

Prevent uninitialized value warnings.

view details

Dave Arter

commit sha cbe3e9a5af21cef3774585dd489aaedbe7a564bc

Map should respect cobrand default zoom, if set. This brings the behaviour of the code in line with the comment on Cobrand:Default::default_map_zoom

view details

Matthew Somerville

commit sha 37a2eba471761281039f9078d17123badcf9b40c

[Peterborough] Increase default map zoom.

view details

Matthew Somerville

commit sha f92be47d9b6383dcb2a6a5ac3bc68ad644307ee0

Merge branch 'tiny-bobs'

view details

Matthew Somerville

commit sha 32ad0501c46816b3e6b28b53c0df5bccc5fa057a

Merge branch 'peterborough-zoom'

view details

Matthew Somerville

commit sha 04d217ae31c156c17d95e757842693caa31c06ed

[Hounslow] Closed as well as fixed on front page.

view details

abimysoc

commit sha a7d5e06b1ecd6c356e1d0c9292ad706cebf2a144

Change UKCOD to mySociety

view details

abimysoc

commit sha 230882043f4e9eabb01f12251e4a6b961df08353

Change UKCOD to mySociety Inevitably, missed one reference with first PR...

view details

Matthew Somerville

commit sha 58a7df7603b657e8b56bae9b46a0451b4534e9ad

[Hounslow] Allow two email categories to be shown. By default, devolved categories are not shown.

view details

Matthew Somerville

commit sha 4b780de3e34128a4581dbc4daead30be00ceadb4

[Open311] Use devolved data on update sending.

view details

Joe Siltberg

commit sha b6e026aad3424a966ac449bcacab7335731bad7f

Upgrades the Mozilla::CA module to 20200520. LWP::UserAgent (used by MapIt and Open311 integrations) uses this cert bundle by default to verify peers. Fixes #3088

view details

Matthew Somerville

commit sha 2b462f20d2479649c14efead2680a49543ca32d0

Merge branch 'open311-post-devolved-update'

view details

push time in 4 days

issue closedmysociety/mapit.mysociety.org

Update Stripe statement descriptor

When I export a CSV file of recent payments from Stripe, the Statement Descriptor column for MapIt payments contains mySociety and it should now be SocietyWorks.

I don't think this is something that I can change through Stripe admin, though I could be wrong; my reason for thinking it's in the code is that the other services we charge for don't have a statement descriptor.

closed time in 4 days

abimysoc

issue commentmysociety/mapit.mysociety.org

Update Stripe statement descriptor

Found bit in admin that did it

abimysoc

comment created time in 4 days

push eventmysociety/fixmystreet

Dave Arter

commit sha 3c98b8f4dbe7085d52887deff90681db552fb580

[BANES] Use HTTPS scheme for bathnes.gov.uk links/search form

view details

Matthew Somerville

commit sha 51eae76dd663d23c1f4bb1e809e9c258e800cb73

Only show access tokens once, and store hashed.

view details

M Somerville

commit sha 1909028b0956cbd0bf4ed17d8be942bd6f77e78c

[Docker] Specify MAPIT_URL. Letting the code pick a default MAPIT_URL means it picks port 8000, which will not work with the current Docker container setup.

view details

push time in 5 days

PR opened mysociety/fixmystreet

Reviewers
Fix photo orientation in modern browsers.

We use Dropzone (the photo upload library) to shrink photos client-side before uploading in the background and display thumbnails. For the resized upload, Dropzone restores the original Exif data, including orientation, so it can be correctly oriented server-side; for a thumbnail, it orients the image itself for immediate display.

Recently, browsers have started honouring Exif orientation much more widely (Chrome 81+ and Firefox 77+ both now do it by default). This means the data Dropzone gets from a resize has already been oriented according to the Exif orientation data. Then Dropzone either looks at the orientation to correct for display (thumbnail), or adds back the Exif orientation data (upload) – in both cases, this leads to a double implementation of the orientation, and an incorrect display.

To fix this, if we detect we are on a modern browser, we do not try and fix orientation ourself - https://gitlab.com/meno/dropzone/-/merge_requests/80 - and in all cases we do not add any Exif data back in (we only strip it server-side anyway). Conversely, that means on a non-modern browser, we always perform a manual orientation because no Exif data will be being sent server-side.

Also includes a fix to the orientation code - https://gitlab.com/meno/dropzone/-/merge_requests/45 -which wouldn't be noticed in thumbnail generation as they are square, but could be now we may be orienting full size photos.

Also also includes extensions in accepted photo upload, as otherwise I don't see .jpeg files in Firefox on Windows.

+317 -41

0 comment

4 changed files

pr created time in 5 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 2626eb617df2f4fead96a8c98549e45353904501

Include extensions in accepted photo upload. In my Firefox on Windows, .jpeg files are not otherwise shown.

view details

Matthew Somerville

commit sha 8c6bb74b7b28fb2f0ad6dea7ccbe839e5e35d60e

Fix photo orientation in modern browsers. We use Dropzone (the photo upload library) to shrink photos client-side before uploading in the background and display thumbnails. For the resized upload, Dropzone restores the original Exif data, including orientation, so it can be correctly oriented server-side; for a thumbnail, it orients the image itself for immediate display. Recently, browsers have started honouring Exif orientation much more widely (Chrome 81+ and Firefox 77+ both now do it by default). This means the data Dropzone gets from a resize has already been oriented according to the Exif orientation data. Then Dropzone either looks at the orientation to correct for display (thumbnail), or adds back the Exif orientation data (upload) – in both cases, this leads to a double implementation of the orientation, and an incorrect display. To fix this, if we detect we are on a modern browser, we do not try and fix orientation ourself [1], and in all cases we do not add any Exif data back in (we only strip it server-side anyway). Conversely, that means on a non-modern browser, we always perform a manual orientation because no Exif data will be being sent server-side. Also includes a fix to the orientation code [2] which wouldn't be noticed in thumbnail generation as they are square, but could be now we may be orienting full size photos. [1] https://gitlab.com/meno/dropzone/-/merge_requests/80 [2] https://gitlab.com/meno/dropzone/-/merge_requests/45

view details

push time in 5 days

create barnchmysociety/fixmystreet

branch : fix-client-rotation

created branch time in 5 days

issue closedmysociety/mapit

Importing new boundary lines data failing

I'm trying to import the new boundary lines data but it seems like it is in a single .gpkg file and the mapit_UK_import_boundary_line script expects a different format (.shp).

Does the script need to be updated?

Thank you

closed time in 5 days

MuriloDalRi

issue commentmysociety/mapit

Importing new boundary lines data failing

Hi, a number of issues fall out of your simple question, I'm afraid.

Firstly, ignoring your question, the important point is - do you want to import the new Boundary-Line data? Ordnance Survey appear to have included the changes to boundaries that would have been made due to the 2020 elections, but the 2020 elections were postponed to 2021 by section 60 of the Coronavirus Act 2020. Therefore the current Boundary-Line product, as I understand it, is for all intents and purposes incorrect and corrupt (given it mixes current, new, and pending data). Importing the new boundaries when they are not in force, depending on your application, may cause confusion.

Now to answer your actual question - it would be good if the script could support Geopackage, but yes, I imagine the script would need updating to support it. Ordnance Survey still supply the data also as Shapefiles, so there shouldn't be an issue - https://www.ordnancesurvey.co.uk/opendatadownload/products.html lets you ask for whatever type of data you want.

If you're talking about the cache mySociety has of some Ordnance Survey products, I've now uploaded the Shapefile version of the data there now too, but I don't really want to hold multiple copies of the same data simply in different formats, we don't have infinite disc space. Hopefully we can get the script to work with Geopackages and then never look at Shapefiles again.

MuriloDalRi

comment created time in 5 days

PR merged mysociety/fixmystreet

Only show access tokens once, and store hashed. Awaiting approval
+46 -46

1 comment

9 changed files

dracos

pr closed time in 5 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 51eae76dd663d23c1f4bb1e809e9c258e800cb73

Only show access tokens once, and store hashed.

view details

push time in 5 days

push eventmysociety/mapit

abimysoc

commit sha 947443bbab9b816cee603df6fb1aa696f92463c7

New footer wording and ampersands

view details

M Somerville

commit sha 67491cea916d2c8f5e59377be174f161fe9d2ff2

Fix for flake8 E741.

view details

push time in 5 days

push eventmysociety/fixmystreet

Martin Wright

commit sha 4d0a57b172c44d4f880bb560f7a876aff3ccae27

[Bexley] Redesign. Make sure spans in navbar are legible at all times.

view details

Matthew Somerville

commit sha 251acf7799e78fd46a39154f0381c7470d5542a9

Skip accounts without email for inactive emails.

view details

Dave Arter

commit sha b39b8dd5d579b195da2bb2e81bbacea552e09216

[UK Councils] Enable private photo uploading on cobrands whose backend supports it For https://github.com/mysociety/fixmystreet-commercial/issues/1778

view details

Matthew Somerville

commit sha 0a675d24f0210a97018c96b47504d1b346f74f75

Merge branch 'issues/freshdesk-470-bexley-redesign'

view details

Matthew Somerville

commit sha 7ad5744b93c680e9dc641f4286c20dc5df5e2685

Merge branch 'issues/commercial/1778-private-photos-upload'

view details

Matthew Somerville

commit sha 56d6d1524b4559ca407bcaf33f47a12960e83576

Merge branch 'skip-accounts-without-email'

view details

Matthew Somerville

commit sha 9553c8daac73f06af704a87ace7294f751a77b8f

Add lazy image loading on list items.

view details

Matthew Somerville

commit sha 89bfe7226a2c2202e8151aa32c7648dad9f9f038

[Buckinghamshire] Spot lights e.g. ending with "A"

view details

Matthew Somerville

commit sha dae0ca4686c5613800df5bb792fe803b952f6bde

Small refactor of asset message display. Wherever asset_item_message is checked/used, make sure it does the text replacement and falls back to the default.

view details

Matthew Somerville

commit sha a2b1c1a19327fea4c9a0688cf67affb34ce08726

[UK Councils] Config matches default. With the refactor to make sure asset message always uses the default, no need for these specific config lines any more.

view details

Matthew Somerville

commit sha cd639b946ef6954730e7b027149f21e8561e4582

[East Sussex] Tidy up named select actions.

view details

Matthew Somerville

commit sha 6d3ab9722b91e4929d01d168dfc0dc0916a8b542

Include -p in systemd mkdir command.

view details

Matthew Somerville

commit sha 948338c4cfa30885f552f775a8727bf3b34859f1

Prevent uninitialized value warnings.

view details

Dave Arter

commit sha cbe3e9a5af21cef3774585dd489aaedbe7a564bc

Map should respect cobrand default zoom, if set. This brings the behaviour of the code in line with the comment on Cobrand:Default::default_map_zoom

view details

Matthew Somerville

commit sha 37a2eba471761281039f9078d17123badcf9b40c

[Peterborough] Increase default map zoom.

view details

Matthew Somerville

commit sha f92be47d9b6383dcb2a6a5ac3bc68ad644307ee0

Merge branch 'tiny-bobs'

view details

Matthew Somerville

commit sha 32ad0501c46816b3e6b28b53c0df5bccc5fa057a

Merge branch 'peterborough-zoom'

view details

Matthew Somerville

commit sha 04d217ae31c156c17d95e757842693caa31c06ed

[Hounslow] Closed as well as fixed on front page.

view details

abimysoc

commit sha a7d5e06b1ecd6c356e1d0c9292ad706cebf2a144

Change UKCOD to mySociety

view details

abimysoc

commit sha 230882043f4e9eabb01f12251e4a6b961df08353

Change UKCOD to mySociety Inevitably, missed one reference with first PR...

view details

push time in 5 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 765571e8d67bbcc0066824ddd022ed6fba5e925a

[Bromley] Add waste service lookup. This creates an integration to view bin collection days, and placeholders for the start of a non-map property-based reporting flow.

view details

Matthew Somerville

commit sha 44a3abd8168b31e70b324e922b251948a4331f90

[Bromley] Add waste reporting service. This creates a non-map property-based reporting flow for reporting missed collections and requesting new containers. Such reports are always private, in categories that are hidden from the map filters and never shown on .com.

view details

Matthew Somerville

commit sha 7cc89dbe5f3453427fbfe98b61ccc98c39302ee1

[Bromley] Add general enquiries. This adds general enquiries to the reporting flow.

view details

Matthew Somerville

commit sha 453973931bbf780dc5725e70905a7f7cdf3f15f7

[Bromley] Report missed bin within 2 working days.

view details

Matthew Somerville

commit sha a70627330116b118141c26347de251eaa2eb45b9

Add Data::ICal.

view details

Matthew Somerville

commit sha 05b3eb9e1b2cf8a6ab83e23a76b69c8822ee3ea7

[Bromley] ICal generation.

view details

Matthew Somerville

commit sha 9d53b762454452e7612c448340fc7791ef74f1ec

[Bromley] Send sent confirmation for waste reports

view details

Matthew Somerville

commit sha b15f1faa9c37b15ce34c458e3a7ce038eef068bd

[Bromley] No updates on closed waste reports.

view details

Matthew Somerville

commit sha 0c8abc4bf0bc4253bbc0d49a46cf3e61822ec1fb

[Bromley] Restrict waste lookups per day.

view details

Matthew Somerville

commit sha d0006e81a02af0eeffe922cf968bdd9c2c0523f7

[Bromley] Look for open events.

view details

Matthew Somerville

commit sha f964e0f96ccd531d260925abb1a1aa7dfc85ae8d

[Bromley] Treat some enquiries same as missed. In terms of within-two-day and no existing open event.

view details

Matthew Somerville

commit sha 96d13e9a6d710e78047c0657df390940fd3b7026

[Bromley] Only change endpoint config when needed.

view details

Matthew Somerville

commit sha 69a455a8e78132ae96f99446fc486ebc5c292dee

[Bromley] Hide fixed checkbox from waste update form.

view details

Matthew Somerville

commit sha d95509a09b2647081529f369af3b7425ef645d19

[Bromley] Script to update open waste reports.

view details

Matthew Somerville

commit sha 8a2ec2bd7a04f8f443ec822644fe2b9effb83be2

[Bromley] Push notification from Echo.

view details

Matthew Somerville

commit sha 1135b3c57255d0c329dc6215915c6c2e4d447fb6

fixup! [Bromley] Add waste service lookup.

view details

Matthew Somerville

commit sha 7185c72c9ca592b321b38f78b47120877ef221bd

Merge branch 'bromley-reviewed' into commercial-staging

view details

push time in 6 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 1135b3c57255d0c329dc6215915c6c2e4d447fb6

fixup! [Bromley] Add waste service lookup.

view details

push time in 6 days

push eventmysociety/mapit.mysociety.org

M Somerville

commit sha baa039b54bf8ebd5f9a74c5c45c1355728f1aada

Update Stripe email when account email changes.

view details

push time in 6 days

push eventmysociety/petitions

M Somerville

commit sha 58eb0e45a4736264385282a918111a19cafb5c70

Remove email sender, use Email::Sender.

view details

push time in 6 days

pull request commentmysociety/petitions

Simplify petemaild

"It looks fine - although this is a pretty large program, and I'm not hugely familiar with all its parts." - yeah, that's one good reason to do this, I think, as I find it pretty hard to follow too!

dracos

comment created time in 6 days

Pull request review commentmysociety/petitions

Simplify petemaild

 sub requeue ($$) {     } } -# thing_bad WHAT THING DB MIN MAX-#-sub thing_bad ($$$$$$) {-    my Queue $self = shift;-    my ($what, $thing, $db, $minint, $maxint) = @_;-    if (!exists($db->{$thing})) {-        return 0;-    } else {-        my $l = $db->{$thing};-Log::print('noise', "$what $thing marked as bad ", join(', ', map { int(time() - $_) } @$l), " s ago");-        # Only one observation, so try again as soon as a short interval-        # has passed.-        if (1 == @$l) {-            if (time() > $l->[0] + $minint) {-                return 0;-            } else {-                return 1;-            }-        }--        # Otherwise check after half as long as the thing has been bad already,-        # or after $maxint, whichever is sooner.-        my $lastcheck = $l->[@$l - 1];-        my $interval = ($lastcheck - $l->[0]) / 2;-        $interval = $maxint if ($interval > $maxint);-        if ($lastcheck + $interval > time()) {-            return 1;-        } else {-            return 0;-        }-    }-}--# host_bad ADDRESS-# Should we assume that the host at ADDRESS is bad, or should it be tried-# again?-sub host_bad ($$) {-    my Queue $self = shift;-    my $addr = shift;-    return $self->thing_bad('host', $addr, $self->{badhosts},-                        MIN_HOST_BAD_INTERVAL, MAX_HOST_BAD_INTERVAL);-}--# domain_bad DOMAIN-# Should we assume that resolution of the DOMAIN is failing, or should it be-# tried again?-sub domain_bad ($$) {-    my Queue $self = shift;-    my $domain = shift;-    return $self->thing_bad('domain', $domain, $self->{baddomains},-                        MIN_DOMAIN_BAD_INTERVAL, MAX_DOMAIN_BAD_INTERVAL);-}- # pre_select RDS WRS # sub pre_select ($$$) {     my Queue $self = shift;     my IO::Select $rds = shift;     my IO::Select $wrs = shift; -    # Do pre-select handling for domain resolver and individual SMTP clients.-    $self->r()->pre_select($rds, $wrs);-    foreach my $smtp (@{$self->{ss}}) {-        $smtp->pre_select($rds, $wrs);-    }-     # Hash of IP addresses to which to send messages to messages to send to

Weird, how did I miss that.

dracos

comment created time in 6 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 765571e8d67bbcc0066824ddd022ed6fba5e925a

[Bromley] Add waste service lookup. This creates an integration to view bin collection days, and placeholders for the start of a non-map property-based reporting flow.

view details

Matthew Somerville

commit sha 44a3abd8168b31e70b324e922b251948a4331f90

[Bromley] Add waste reporting service. This creates a non-map property-based reporting flow for reporting missed collections and requesting new containers. Such reports are always private, in categories that are hidden from the map filters and never shown on .com.

view details

Matthew Somerville

commit sha 7cc89dbe5f3453427fbfe98b61ccc98c39302ee1

[Bromley] Add general enquiries. This adds general enquiries to the reporting flow.

view details

Matthew Somerville

commit sha 453973931bbf780dc5725e70905a7f7cdf3f15f7

[Bromley] Report missed bin within 2 working days.

view details

Matthew Somerville

commit sha a70627330116b118141c26347de251eaa2eb45b9

Add Data::ICal.

view details

Matthew Somerville

commit sha 05b3eb9e1b2cf8a6ab83e23a76b69c8822ee3ea7

[Bromley] ICal generation.

view details

Matthew Somerville

commit sha 9d53b762454452e7612c448340fc7791ef74f1ec

[Bromley] Send sent confirmation for waste reports

view details

Matthew Somerville

commit sha b15f1faa9c37b15ce34c458e3a7ce038eef068bd

[Bromley] No updates on closed waste reports.

view details

Matthew Somerville

commit sha 0c8abc4bf0bc4253bbc0d49a46cf3e61822ec1fb

[Bromley] Restrict waste lookups per day.

view details

Matthew Somerville

commit sha d0006e81a02af0eeffe922cf968bdd9c2c0523f7

[Bromley] Look for open events.

view details

Matthew Somerville

commit sha f964e0f96ccd531d260925abb1a1aa7dfc85ae8d

[Bromley] Treat some enquiries same as missed. In terms of within-two-day and no existing open event.

view details

Matthew Somerville

commit sha 96d13e9a6d710e78047c0657df390940fd3b7026

[Bromley] Only change endpoint config when needed.

view details

Matthew Somerville

commit sha 69a455a8e78132ae96f99446fc486ebc5c292dee

[Bromley] Hide fixed checkbox from waste update form.

view details

Matthew Somerville

commit sha d95509a09b2647081529f369af3b7425ef645d19

[Bromley] Script to update open waste reports.

view details

Matthew Somerville

commit sha 8a2ec2bd7a04f8f443ec822644fe2b9effb83be2

[Bromley] Push notification from Echo.

view details

push time in 6 days

push eventmysociety/theyworkforyou

M Somerville

commit sha 6c1a97c4eb50b5bd567ccab9a7af80ca8da539ee

Update Stripe email when account email changes.

view details

push time in 6 days

Pull request review commentmysociety/fixmystreet

Rewrite open311-update-reports

 sub local_coords {     } } -=head2 update_from_open311_service_request--    $p->update_from_open311_service_request( $request, $body, $system_user );--Updates the problem based on information in the passed in open311 request-(standard, not the extension that uses GetServiceRequestUpdates) . If the-request has an older update time than the problem's lastupdate time then-nothing happens.--Otherwise a comment will be created if there is status update text in the-open311 request. If the open311 request has a state of closed then the problem-will be marked as fixed.--NB: a comment will always be created if the problem is being marked as fixed.--Fixed problems will not be re-opened by this method.--=cut--sub update_from_open311_service_request {-    my ( $self, $request, $body, $system_user ) = @_;--    my ( $updated, $status_notes );--    if ( ! ref $request->{updated_datetime} ) {-        $updated = $request->{updated_datetime};-    }--    if ( ! ref $request->{status_notes} ) {-        $status_notes = $request->{status_notes};-    }--    my $update = $self->new_related(comments => {-        state => 'confirmed',-        created => $updated || \'current_timestamp',-        confirmed => \'current_timestamp',-        text => $status_notes,-        mark_open => 0,-        mark_fixed => 0,-        user => $system_user,-        anonymous => 0,-        name => $body->name,-    });--    my $w3c = DateTime::Format::W3CDTF->new;-    my $req_time = $w3c->parse_datetime( $request->{updated_datetime} );--    # set a timezone here as the $req_time will have one and if we don't-    # use a timezone then the date comparisons are invalid.-    # of course if local timezone is not the one that went into the data-    # base then we're also in trouble-    my $lastupdate = $self->lastupdate;-    $lastupdate->set_time_zone( FixMyStreet->local_time_zone );--    # update from open311 is older so skip-    if ( $req_time < $lastupdate ) {-        return 0;-    }--    if ( $request->{status} eq 'closed' ) {-        if ( $self->state ne 'fixed' ) {-            $self->state('fixed');-            $update->mark_fixed(1);--            if ( !$status_notes ) {-                # FIXME - better text here-                $status_notes = _('Closed by council');

The update left will still lead to the default "State changed to: fixed" being displayed as the update, so think should be okay.

dracos

comment created time in 6 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 0ed4c35af211618e1f7db4daf682b19b650d0181

Link to open events.

view details

Matthew Somerville

commit sha 17f853c9e37437da771797424c6eee167af458cf

Merge branch 'improve-when-links-shown' into commercial-staging

view details

push time in 6 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 4570022d5af81b2fbd747091575beb13ce3bc08d

Link to open events.

view details

Matthew Somerville

commit sha 9a67eb8261d021886e87d4203f01415ba1cc91b5

Merge branch 'bromley-reviewed' into commercial-staging

view details

push time in 6 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 90bb02a949da3fca125f7099deeb986419603c19

[Bromley] Add waste service. This creates a non-map property-based reporting flow for reporting missed collections, requesting new containers, and general enquiries, plus an integration to view bin collection days. Such reports are always prviate, in categories that are hidden from the map filters, and never shown on .com.

view details

Matthew Somerville

commit sha 286e19bac68f9b703264853333042f25458fd09d

[Bromley] Report missed bin within 2 working days.

view details

Matthew Somerville

commit sha 70a08c857bf16cbb1f80721e2a16e0180f980725

Add Data::ICal.

view details

Matthew Somerville

commit sha 72a8be0dc5484d404c12eb8d26fc8f34d9ba38c6

[Bromley] ICal generation.

view details

Matthew Somerville

commit sha e566d0b72095b9b6f7d9ccc784346118634f154e

[Bromley] Send sent confirmation for waste reports

view details

Matthew Somerville

commit sha 505371cbe3339857de0ba3c0781d5cbf6c43be93

[Bromley] No updates on closed waste reports.

view details

Matthew Somerville

commit sha 571612b47117559c52ca24ddfbfa04028ad1e391

[Bromley] Restrict waste lookups per day.

view details

Matthew Somerville

commit sha f9eeacfe03bdbfae1a6436c584a4bb4549597aac

[Bromley] Look for open events.

view details

Matthew Somerville

commit sha b4573b3b0801df987d014ad9f9b81a5c271f16f4

[Bromley] Treat some enquiries same as missed. In terms of within-two-day and no existing open event.

view details

Matthew Somerville

commit sha 68d2a91473ed74a7631a9087f629554f4152e326

[Bromley] Only change endpoint config when needed.

view details

Matthew Somerville

commit sha 642bb7105013c1cfba116c99818b7e784e86cd84

[Bromley] Hide fixed checkbox from waste update form.

view details

Matthew Somerville

commit sha 5b68cbf836abd8f5ab194c8293eff06193a444d0

[Bromley] Script to update open waste reports.

view details

Matthew Somerville

commit sha 95cac666abeeddf66a37b71222c02d07442e78d4

[Bromley] Push notification from Echo.

view details

Matthew Somerville

commit sha f9a77c6da6311711f75197aaaaeffdf2e0d613d1

Merge branch 'bromley-reviewed' into commercial-staging

view details

Matthew Somerville

commit sha b964aca7a39d3f2d8d18f47c7a7c3185253f3d1e

[Bromley] Look for open events.

view details

Matthew Somerville

commit sha 56d7e31e9ff8d6d1807ab18c5404f9ba2b8d279e

[Bromley] Treat some enquiries same as missed. In terms of within-two-day and no existing open event.

view details

Matthew Somerville

commit sha 554a540f70db7c392803fdd317e6e2adadf51bb5

[Bromley] Only change endpoint config when needed.

view details

Matthew Somerville

commit sha 8f61aabfb70190c036eeff00b96c9e028388709c

[Bromley] Hide fixed checkbox from waste update form.

view details

Matthew Somerville

commit sha 936112d75e5a9dd33f4faa95d754dec546a9f10c

[Bromley] Script to update open waste reports.

view details

Matthew Somerville

commit sha 65bf7e2bb782d9b985d26db40b96ae077ec7731a

[Bromley] Push notification from Echo.

view details

push time in 6 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha d1c38a2bdbe5891fa63bde40e398e3cc33881566

Improve Bing geocoder results. Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.

view details

Dave Arter

commit sha c7cc69f6cd5e7f91a48223dd0194aeed39b8e59e

[Bromley] Use HTTPS scheme for bromley.gov.uk links/search form Also updates the search form URL as the old one had stopped working.

view details

Matthew Somerville

commit sha 55e243e813423c9f28560be82ae88acebb8d8bb8

Rewrite open311-update-reports to share code. Make GetUpdates and GetServiceRequestUpdates share a common base; spot all visible states.

view details

Matthew Somerville

commit sha 5fd8c7dc3f9e0716520d56dbca1f6189b7f280ee

Factor out/default Open311 construction object. This simplifies the code wherever used.

view details

push time in 6 days

push eventmysociety/theyworkforyou

M Somerville

commit sha e9545976b04ed463011f2208b4b1df12906ac2e3

Update Stripe email when account email changes.

view details

push time in 9 days

PR opened mysociety/mapit.mysociety.org

Reviewers
Update Stripe email when account email changes.

Fixes https://github.com/mysociety/mapit.mysociety.org/issues/109

+23 -0

0 comment

3 changed files

pr created time in 9 days

create barnchmysociety/mapit.mysociety.org

branch : stripe-update-email

created branch time in 9 days

push eventmysociety/open311-adapter

Struan Donald

commit sha f2eb3ec3b36123fe1d1aff8f141158d9fc5392ee

[Oxfordshire] accept new feature_id attribute

view details

Struan Donald

commit sha 30a78863becc7552dacaf4f37b1aa68c51e0c016

[Northamptonshire] add user's details to updates Adds the user's name and any contact details in to the update message

view details

Struan Donald

commit sha b7126db301684346d02456cd0bfc7172158eab48

[Northamptonshire] further investigation state We don't send it as a state but use the external_status_code to mark an investigating state as under further investigation.

view details

M Somerville

commit sha 9ef06a6a2f7c418db9c99d534133fc65768ddb59

Merge remote-tracking branches 'origin/hackney-reviewed', 'origin/bromley-reviewed', 'origin/occ-assets', 'origin/issues/freshdesk/422-ncc-include-commenter-details' and 'origin/bartec' into staging

view details

push time in 9 days

push eventmysociety/open311-adapter

M Somerville

commit sha 42f75f6bfc361e61247c4f95cc3a419630387a28

[Confirm] Allow ignoring of particular status logs You can specify IGNORE in the reverse status mapping and then any status log entry with the relevant status code will not be output.

view details

M Somerville

commit sha 46eca77870db5141b65d7c4e3d3c4447b491e859

[Uniform] Skip unneeded requests fetching updates.

view details

Struan Donald

commit sha be2d61de3e2edd57ae4ff5fb6d7f9f19ea8b0c35

[EastSussex] fetch service list from salesforce Only fetch groups we've whitelisted and additionally skip any categories that are blacklisted. This also includes the auth code.

view details

Struan Donald

commit sha 8846facd58bf2ea7b62079453393e21e23be4023

[EastSussex] basic report posting to salesforce POST a new report into Salesforce by creatign a new Case. Also searches for an Account using the email address and creates a new one for the user if it doesn't find one.

view details

Struan Donald

commit sha 1c49e030dc92dafa85bb40dbcdadc9475efc298f

[EastSussex] example conf file

view details

Struan Donald

commit sha fd7df3a29afed0f70ec6d356dc0a0c65a7623abf

[EastSussex] get service extra questions from config Lookup extra questions for a service in the config based on the name of the service.

view details

Struan Donald

commit sha e1b5fe13105d26cbc81cbebaa6b2da5a05d000e0

[EastSusex] add photo upload

view details

Struan Donald

commit sha 9c9408ba20add6809c385696286cce4de5b7d129

[EastSussex] use CaseNumber for external id This is what people will need to quote to East Sussex on the phone so makes sense to store this rather than the Salesforce id.

view details

Struan Donald

commit sha 0e8a72881a8f9217acfee3aed3bf6bfa5c6f3c12

[EastSussex] allow groups to be renamed for display Some of the internal Salesforce names aren't especially user facing so allow them to be renamed on the way out and then reversed on the way back in

view details

Struan Donald

commit sha 8f59b981530fedc29807f0ebc2c76c1a634a7331

[EastSussex] filter groups at a service level Some service names appear under multiple groups but we don't want to display all of them. Add a blacklist that filters out groups from services.

view details

Struan Donald

commit sha abe69a1ef5229524644e54513ab27e0c2d319ed6

[EastSussex] remove non whitelisted groups from service We not only need to check that a service has a group in the whitelist, we also need to remove any groups that aren't in it.

view details

Struan Donald

commit sha 5afe97e4da5d462a9c3507e05fc8980e3d1c5fb8

[EastSussex] update case with contact id Add the contact id to the case as this is required by east sussex

view details

Struan Donald

commit sha 0fad1d2382624e2f48327aed79dd92524f036fd2

[EastSussex] hidden fields should be set to variable Otherwise the front end does not save them.

view details

Struan Donald

commit sha 2d22da792f8fb6d09aaa581ccb2e7041196cbfef

[EastSussex] send asset ids over open311

view details

Struan Donald

commit sha 4c11ded84419ac8715f55f0ca2ae64634a4d50d9

allow sort order to be specified for attribute values Add a values_sorted property to Attribute that is an array ref with the order the keys of values should be returned in. If that's present then use that to sort the values, otherwise remain alphabetical.

view details

Struan Donald

commit sha 2ba23634d358c48bd5ddf57ff3c7bfb5b9966110

[EastSussex] optionally set a sort order on question answers if the question has an order key then use that to sort the list of answers

view details

Struan Donald

commit sha 8488bb07b7492269976d59666e3ff954782657c3

[EastSussex] add closest address attribute and use it Strip out the extra text we put in and just leave the address as it's not required in this case.

view details

M Somerville

commit sha d8c206d5e68f3849b8cea0cd6fd9e1fea041bd66

[Uniform] Compare updates with differing newlines.

view details

M Somerville

commit sha 1fc16baf58de6d8adeff3e8be5ee75954100f484

Switch a few attributes from text to string. In case they are displayed as text inputs.

view details

Dave Arter

commit sha 7c45639834a5d848d75615afd0aeb2ff10d82014

[Confirm] Warn loudly if photo can’t be fetched when uploading to Confirm

view details

push time in 9 days

push eventmysociety/open311-adapter

Chris Mytton

commit sha 1df5af42f8218d3dca003cf40b6a4f50c34fb6ae

[Peterborough] Switch to Multi backend

view details

Chris Mytton

commit sha 33b54e1c0959b2e280bfadaa3a05e77e7290410b

[Peterborough] Ezytreev integration

view details

Chris Mytton

commit sha fd4aba2222d7b75c23d07424ef2cd0ce57e81484

[Ezytreev] Get update notes for certain status codes We want to pass the update notes for certain status codes through to FMS. This change adds a whitelist of codes that we allow the notes for and then checks that list when retrieving updates and shows the notes if it's in the whitelist, otherwise it just shows the enquiry status description.

view details

Chris Mytton

commit sha 0e727c52204c26047d1d5fbb54ad9f0b9059d102

[Ezytreev] Extract status_code into a separate variable This is used quite a bit in this sub, so pull it into a variable to make things slightly easier to read.

view details

Chris Mytton

commit sha ea21ea6c89466cec671d9b567611e6927a1b251c

[Ezytreev] Ignore duplicate status updates When an enquiry is attached to an order item it results in two status updates being generated for one status code. Ignore the update that has the order item ID in it, since this ID will be meaningless to the user anyway.

view details

Chris Mytton

commit sha e35f6287d384e50b279b8c9d5841b98a6e35223b

[Ezytreev] Leave description blank by default In FMS automated response templates are only used if the description from open311 is blank or the response template contains the text `{{description}}`, which is then replaced with the actual description from open311. In this case the ezytreev description is just the ezytreev internal status description, which isn't relevant to the end user, and could cause confusion since the wording is different from FMS statuses, so leave it blank and let the automated response template take priority.

view details

Chris Mytton

commit sha ccc79da2bda5e8097270f4b212f90b0965d31c3b

[Ezytreev] Ignore updates with unmapped status codes These are producing random re-openings at the moment where an unmapped status code that FMS doesn't need to worry about is used. Rather than re-opening the report we just want to ignore the update.

view details

Struan Donald

commit sha f617530eb9c7f0f254e4c743f4bdf3939a4d9fe1

[WDM] enable statuses to be mapped add a status_map key to the config and use that to map from WDM statuses in fetched updates to FixMyStreet statuses

view details

Dave Arter

commit sha ebd8e335ec7b9220c65b3a1511210e93ad39ca9c

[Confirm] Don’t bail out of upload script if dir isn’t present

view details

Struan Donald

commit sha a4b30f333bbf8b8fc49a166c179269b85b31f128

add an optional extras attribute to updates To enable including non standard data in updates add an extras property to updates. This is a hashref which can contain arbitrary keys.

view details

Struan Donald

commit sha c1f4208a3308429387d92a25af9707c533752570

[Alloy] include alloy priority in extras for defects If a defect has a priority then include that in the extras attribute of updates so we can use it on FixMyStreet

view details

Struan Donald

commit sha 495eb9f9dc69da944c40dbf97823136c7f60075d

[Northamptonshire] use defect priority to generate description when we fetch a defect from Alloy, if it has a priority automatically generate a description of the defect using that.

view details

M Somerville

commit sha 42f75f6bfc361e61247c4f95cc3a419630387a28

[Confirm] Allow ignoring of particular status logs You can specify IGNORE in the reverse status mapping and then any status log entry with the relevant status code will not be output.

view details

M Somerville

commit sha 46eca77870db5141b65d7c4e3d3c4447b491e859

[Uniform] Skip unneeded requests fetching updates.

view details

Struan Donald

commit sha be2d61de3e2edd57ae4ff5fb6d7f9f19ea8b0c35

[EastSussex] fetch service list from salesforce Only fetch groups we've whitelisted and additionally skip any categories that are blacklisted. This also includes the auth code.

view details

Struan Donald

commit sha 8846facd58bf2ea7b62079453393e21e23be4023

[EastSussex] basic report posting to salesforce POST a new report into Salesforce by creatign a new Case. Also searches for an Account using the email address and creates a new one for the user if it doesn't find one.

view details

Struan Donald

commit sha 1c49e030dc92dafa85bb40dbcdadc9475efc298f

[EastSussex] example conf file

view details

Struan Donald

commit sha fd7df3a29afed0f70ec6d356dc0a0c65a7623abf

[EastSussex] get service extra questions from config Lookup extra questions for a service in the config based on the name of the service.

view details

Struan Donald

commit sha e1b5fe13105d26cbc81cbebaa6b2da5a05d000e0

[EastSusex] add photo upload

view details

Struan Donald

commit sha 9c9408ba20add6809c385696286cce4de5b7d129

[EastSussex] use CaseNumber for external id This is what people will need to quote to East Sussex on the phone so makes sense to store this rather than the Salesforce id.

view details

push time in 9 days

push eventmysociety/open311-adapter

M Somerville

commit sha d5c172dffd5f0284cda7f19a0c4e5f00af2edbad

Add option to pass through any sent attributes.

view details

M Somerville

commit sha cdb68bccea2e18bc4b58873ab73f85ea65dcbe28

[Bromley] Add Echo support.

view details

Dave Arter

commit sha 5c54c49592d6460f5fa512c34207c023030e6ffc

fixup! fixup! [Alloy] V2 basis by copying all V1 files

view details

Dave Arter

commit sha 8085a35bf1da73220b027bf096f36eddb2a9af2d

fixup! [Hackney] Add extra configuration for fetching defects

view details

M Somerville

commit sha 84503050ad59e62612957d8ce884a1421441a2a4

[Echo] Add post update support.

view details

M Somerville

commit sha abeca56eefc02688f6fdde4dedc1f5c296018136

Merge remote-tracking branches 'origin/hackney-reviewed', 'origin/bromley-reviewed', 'origin/occ-assets', 'origin/issues/freshdesk/422-ncc-include-commenter-details' and 'origin/bartec' into staging

view details

push time in 9 days

PR opened mysociety/theyworkforyou

Reviewers
Update email in Stripe if changed on TWFY

If someone updates their email address and has a Stripe subscription, also update the email we hold for them there. Fixes https://github.com/mysociety/theyworkforyou/issues/1506

+32 -23

0 comment

5 changed files

pr created time in 9 days

create barnchmysociety/theyworkforyou

branch : stripe-update-email

created branch time in 9 days

push eventmysociety/fixmystreet

Martin Wright

commit sha 4ab86ed4666a5bed87bbf6d9d69e47eb051b9dc6

fixup Style changes to bin day page to make sure the button for services can be seen. Add styles to status message that replaces service link in some cases

view details

Matthew Somerville

commit sha 9a4637da34514f92e733a99ca74be53687b85e98

Merge branch 'bromley-reviewed' into commercial-staging

view details

push time in 9 days

push eventmysociety/fixmystreet

Martin Wright

commit sha 4ab86ed4666a5bed87bbf6d9d69e47eb051b9dc6

fixup Style changes to bin day page to make sure the button for services can be seen. Add styles to status message that replaces service link in some cases

view details

push time in 9 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 95e9d4893a6f169579044ed569500b6b1d98ffaf

Hackney branch changes get_body_sender signature.

view details

push time in 9 days

push eventmysociety/fixmystreet

abimysoc

commit sha a7d5e06b1ecd6c356e1d0c9292ad706cebf2a144

Change UKCOD to mySociety

view details

abimysoc

commit sha 230882043f4e9eabb01f12251e4a6b961df08353

Change UKCOD to mySociety Inevitably, missed one reference with first PR...

view details

Matthew Somerville

commit sha 58a7df7603b657e8b56bae9b46a0451b4534e9ad

[Hounslow] Allow two email categories to be shown. By default, devolved categories are not shown.

view details

Matthew Somerville

commit sha 4b780de3e34128a4581dbc4daead30be00ceadb4

[Open311] Use devolved data on update sending.

view details

Joe Siltberg

commit sha b6e026aad3424a966ac449bcacab7335731bad7f

Upgrades the Mozilla::CA module to 20200520. LWP::UserAgent (used by MapIt and Open311 integrations) uses this cert bundle by default to verify peers. Fixes #3088

view details

Matthew Somerville

commit sha 2b462f20d2479649c14efead2680a49543ca32d0

Merge branch 'open311-post-devolved-update'

view details

Matthew Somerville

commit sha 13913fa01909342828ea734bf51621f79c7f378d

[IoW] Small refactor of munging functions.

view details

Matthew Somerville

commit sha 2938ef2b2a56246f1d0ab5bd0b753dc51d7db664

[Hounslow] Factor non-map report creation calls.

view details

Matthew Somerville

commit sha 1d02b147a7f5aad09444552586a65433223815d4

Allow extra questions to use a textarea.

view details

Matthew Somerville

commit sha 14c16948f688a7e029dfe07f6183a1bc997f54a1

[Bexley] Factor out BH code, fix offline test.

view details

Matthew Somerville

commit sha e725bc10c963f5b3c8405b80528172359d22eaeb

[Zurich] Factor out working days calculator.

view details

Martin Wright

commit sha 601dd4627e6f2bc381d1f6743b83356035150907

[Bromley] Switch out header font Bromley's live site doesn't seem to have Gill Sans anywhere any more

view details

Matthew Somerville

commit sha e9d016cdbb7a476862d1bcb42961d1328e554534

[Bromley] Add waste service. This creates a non-map property-based reporting flow for reporting missed collections, requesting new containers, and general enquiries, plus an integration to view bin collection days. Such reports are always prviate, in categories that are hidden from the map filters, and never shown on .com.

view details

Matthew Somerville

commit sha 7418d68a2f0cc12e05d03aea0fa1058d70c98a73

[Bromley] Report missed bin within 2 working days.

view details

Matthew Somerville

commit sha 5220954abd5c277c154eed91832f7457466fc104

Add Data::ICal.

view details

Matthew Somerville

commit sha e18b46c70eb56b14818e8d0b99a1a4def796ff12

[Bromley] ICal generation.

view details

Matthew Somerville

commit sha afac07909d5d2e89e6abc67b627444ab6c09d67f

[Bromley] Send sent confirmation for waste reports

view details

Matthew Somerville

commit sha f8cb372f73390f7a2f06ebe8565e8883407ef6f0

[Bromley] No updates on closed waste reports.

view details

Matthew Somerville

commit sha ed6118e87bb89792fcc8d65ac749e3c4624a5ac1

[Bromley] Restrict waste lookups per day.

view details

Matthew Somerville

commit sha 5f4158e3c8531d4198c5fd2fffc6243dd92d6407

[Bromley] Look for open events.

view details

push time in 9 days

PR merged mysociety/fixmystreet

[Bromley] Code for fetching updates

Fixes https://github.com/mysociety/fixmystreet-commercial/issues/1898. [skip changelog] As we already had an Echo integration present here, seemed easier to use it directly rather than go via open311-adapter requesting all the IDs. Also given I was here anyway and it didn't seem to take much longer, wrote the push-notification way of doing it should we use that method. Wondered about having a F::C::Bromley;:Waste package for all this maybe, what do you think?

+438 -12

1 comment

6 changed files

dracos

pr closed time in 9 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha f581751803a155e4aa1d1bde29f809ceb1c98e0e

[Bromley] Script to update open waste reports.

view details

Matthew Somerville

commit sha 538310058ef840b35dfc602e2d6cdc9f4c70281e

[Bromley] Push notification from Echo.

view details

push time in 9 days

push eventmysociety/fixmystreet

Dave Arter

commit sha c7cc69f6cd5e7f91a48223dd0194aeed39b8e59e

[Bromley] Use HTTPS scheme for bromley.gov.uk links/search form Also updates the search form URL as the old one had stopped working.

view details

Matthew Somerville

commit sha 3daecf77221aecba74f1c09cdfbdc19fce0a87eb

Add option to check password on Have I Been Pwned. If switched on, sends first five letters of the SHA1 hash of the entered password to HIBP's API, which then returns all matching hashes in their database of breached passwords. If we find a match, tell the user they need to pick a different password.

view details

push time in 9 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha d1c38a2bdbe5891fa63bde40e398e3cc33881566

Improve Bing geocoder results. Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.

view details

Dave Arter

commit sha c7cc69f6cd5e7f91a48223dd0194aeed39b8e59e

[Bromley] Use HTTPS scheme for bromley.gov.uk links/search form Also updates the search form URL as the old one had stopped working.

view details

Matthew Somerville

commit sha 587095b2fa8a585ae71977127ce2e42a747d59da

[UK] Show data from StreetManager.

view details

push time in 9 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 1f093dd0b29be168b66f51d571462cc245c748f2

fixup! [Bromley] Restrict waste lookups per day.

view details

Matthew Somerville

commit sha 3869c600e935b3bf5bfa7a43d950fd8ddaaa3848

fixup catching some things that might not be arrays that we assume are

view details

Matthew Somerville

commit sha 0ccb899f5404df77781261ad17449697b751daa2

[Bromley] Only change endpoint config when needed.

view details

Matthew Somerville

commit sha 5cb5dd2100cc4ace7a3a339b9404652518915ce5

[Bromley] Hide fixed checkbox from waste update form.

view details

Matthew Somerville

commit sha f581751803a155e4aa1d1bde29f809ceb1c98e0e

[Bromley] Script to update open waste reports.

view details

Matthew Somerville

commit sha 538310058ef840b35dfc602e2d6cdc9f4c70281e

[Bromley] Push notification from Echo.

view details

push time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 1f093dd0b29be168b66f51d571462cc245c748f2

fixup! [Bromley] Restrict waste lookups per day.

view details

Matthew Somerville

commit sha 3869c600e935b3bf5bfa7a43d950fd8ddaaa3848

fixup catching some things that might not be arrays that we assume are

view details

Matthew Somerville

commit sha 0ccb899f5404df77781261ad17449697b751daa2

[Bromley] Only change endpoint config when needed.

view details

Matthew Somerville

commit sha 5cb5dd2100cc4ace7a3a339b9404652518915ce5

[Bromley] Hide fixed checkbox from waste update form.

view details

push time in 10 days

PR merged mysociety/fixmystreet

[Bromley] waste update tweaks

First fixup is to stop the bromley tests requesting gov.uk bank holiday live, whoops. Second is because if one entry in a list is returned to SOAP, it's auto-promoted to the single entry directly, which we don't want, we want to always loop.

Then the other two are to only change the Bromley endpoint for the main endpoint, so waste updates will be posted correctly to the right endpoint, and hide the fixed checkbox because users can leave updates but can't do that.

[skip changelog]

+116 -83

1 comment

5 changed files

dracos

pr closed time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 3b6c87e983e2e1e6e6b8aeb3987c951fef742a89

[UK] Show data from StreetManager.

view details

push time in 10 days

PR opened mysociety/fixmystreet

Add option to check password on Have I Been Pwned.

If switched on, sends first five letters of the SHA1 hash of the entered password to HIBP's API, which then returns all matching hashes in their database of breached passwords. If we find a match, tell the user they need to pick a different password.

+62 -14

0 comment

4 changed files

pr created time in 10 days

create barnchmysociety/fixmystreet

branch : hibp

created branch time in 10 days

issue commentmysociety/fixmystreet

Have 500 error on admin/bodies for docker version installation

I've put in a PR at https://github.com/mysociety/fixmystreet/pull/3094 to change the default for Docker to use port 9000 here for initial installation, thanks for letting us know.

biill

comment created time in 10 days

PR opened mysociety/fixmystreet

Reviewers
[Docker] Specify MAPIT_URL.

Letting the code pick a default MAPIT_URL means it picks port 8000, which will not work with the current Docker container setup.

+1 -1

0 comment

1 changed file

pr created time in 10 days

create barnchmysociety/fixmystreet

branch : docker-mapit-default

created branch time in 10 days

issue commentmysociety/fixmystreet

Have 500 error on admin/bodies for docker version installation

Aha, that's much more useful, thanks. That looks like a bug somewhere in our Docker setup in that the default MAPIT_URL within Docker needs to be set to something to work correctly, which it clearly isn't at preent. If you changed MAPIT_URL from '' to http://localhost:9000/fakemapit/ (so with the port number of the app server) – hopefully that would work.

I suggest that because please note commenting out/in the lines you reference only makes sense to do if you are developing a site for the UK, because you are now pointing your installation at our live UK installation of MapIt (which also only has a small free tier). The documentation on this setup can be found at https://fixmystreet.org/customising/fms_and_mapit/ hope that's helpful.

biill

comment created time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha a77edc9ad8cab303911f19240455ecbef012da86

fixup! [Bromley] Script to update open waste reports.

view details

Matthew Somerville

commit sha ba5bf17dfc647eaad38891ac25ffb18871a9aefb

fixup! [Bromley] Script to update open waste reports.

view details

push time in 10 days

Pull request review commentmysociety/fixmystreet

[Bromley] Code for fetching updates

 sub setup_categories_and_bodies : Private {     @$contacts = grep { grep { $_ eq 'Waste' } @{$_->groups} } @$contacts; } +sub receive_echo_event_notification : Path('/waste/echo') : Args(0) {+    my ($self, $c) = @_;+    $c->response->header(Content_Type => 'text/xml');++    require SOAP::Lite;++    $c->detach('soap_error', [ 'POST' ]) unless $c->req->method eq 'POST';

I wanted to use SOAP::Transport::HTTP (which does checks like this) but then it wants to generate the output and captures the $c->detaches and so on. So, yes, will do.

dracos

comment created time in 10 days

issue commentmysociety/fixmystreet

Have 500 error on admin/bodies for docker version installation

Alternatively, if you set your STAGING_SITE configuration variable to 1 and restart the app server so that it runs in development mode, you should get a much fuller error message to the browser instead of the multi-language default.

biill

comment created time in 10 days

issue commentmysociety/fixmystreet

Have 500 error on admin/bodies for docker version installation

Is /admin/bodies the only page that errors? Are other admin pages okay? Are you logged in or out? If you're not logged in, all that going to admin/bodies should do is redirect you to the login page, bit odd if that isn't working. Is the front end (non-admin) okay? If you'

The server logs its errors to /var/www/fixmystreet/logs/error.log in the container, so that is where the actual error will be shown if it's not shown on the terminal. Not sure why it wouldn't be showing there - but the bit you quote e.g. doesn't include a line fetching "GET /admin/bodies" so that implies something odd is going on, not sure whether that's with your system or not at this stage though.

biill

comment created time in 10 days

PR merged mysociety/fixmystreet

Improve Bing geocoder results.

Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.

Sometimes (I think with results with less information?), Bing is including no information beyond the country in the result string. Make sure the locality is included if not already present. Also ignore our server IP, and ask for 10 results (default was changed to 5 at some point).

Helps with this example query, at least, and I don't think it could harm any other.

Before: image

After: image

+64 -1

1 comment

4 changed files

dracos

pr closed time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha d1c38a2bdbe5891fa63bde40e398e3cc33881566

Improve Bing geocoder results. Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.

view details

push time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha b6a2426561e39be1d744eea512f31da12411a4c2

Add script to export/import body data. This covers response templates, roles, and staff users.

view details

Matthew Somerville

commit sha 6d8ed1e8ce76a13100a390beaf70e69588682916

[Buckinghamshire] Fix flytipping closure script. The ex-districts are not associated with areas any more, and the Bucks body will be associated with a different area ID once the generation is updated. The names are fixed, so use them instead.

view details

Struan Donald

commit sha da34e853a28592dcb556c94c2f0d7594ba352b6a

[HE] fix opengraph tags Add title, image and also favicon Fixes mysociety/commercial-staging#1834

view details

Matthew Somerville

commit sha 0e06def3a2dcefebc0793f7b855b37024cced9bd

Merge branch 'bucks-flytipping-id-fix'

view details

Matthew Somerville

commit sha d44c06c213bc73632893ab58421ab98b7058b913

Merge branch 'export-import-data'

view details

Matthew Somerville

commit sha 1f0473c9844b6e32338d1c1af6e368f3387e8890

Combine and improve fetch-comments/reports scripts Make them take start/end hour arguments, cope if only one given, optional body, and combine them together in one `fetch` script.

view details

Matthew Somerville

commit sha 46300feaf7481ef4dac67ee312becf856c184135

Parallelize fetching updates. Allow a configurable number of bodies to fetch updates simultaneously.

view details

Matthew Somerville

commit sha 592d52838f3d1cd1824f6a37e273705112a7011a

Allow slow processes to spin up new ones.

view details

Struan Donald

commit sha 4590344c558a925408499be5a977b1ed94a22b1b

[HE] add a how did you hear about us question

view details

Matthew Somerville

commit sha 9ff04868ea123b8b309f1c5f22493bddff756c3a

Merge branch 'improve-fetch-scripts'

view details

Matthew Somerville

commit sha 9a355329fe7e3012e3ca50b96329b277aff412d6

[Cheshire East] COVID-19 message.

view details

Joe Siltberg

commit sha 0faec74a02c6ae436fdbfbe587e13b08befe9810

Removes documentation about restricting access to /admin Fixes #2937

view details

Matthew Somerville

commit sha 12b045dffaa981709739d5bdd04c8d1294664934

[Westminster] Explicitly return no extra data. Otherwise something can be passed back, confusing the parent Open311 sending code. Missed in 7ed37641.

view details

Matthew Somerville

commit sha 836201a3e6b4a54256ac63716eecad982b9abd65

Merge branch 'admin-access-doc-2937' of git://github.com/Sambruk/fixmystreet

view details

Matthew Somerville

commit sha 99043455d12b3d7952d21bff0538539a9601ebf0

Tidy up verbose/debug handling of send-reports. Use verbose for all log output, and debug only for overriding the should_skip check.

view details

Matthew Somerville

commit sha b892ef1ce69ec4aaa1c3e961c08d00a75877575c

Ignore sending failures within the database query. This means the code can assume it should be trying to send a report.

view details

Matthew Somerville

commit sha 7a6f6b5adbd33bd2b1a9aa4e51120801b270f7aa

[Highways England] Allow lookup with “FMS” prefix. This form of reference is shown on a report confirmation page.

view details

Matthew Somerville

commit sha cd392865eb87d8eef5f9c57e64d00acc7a9bbac1

[Bexley] Use other P1 email for Confirm reports.

view details

Matthew Somerville

commit sha e829a7bc83c886de76cd3f03ed6d65f067c45ae4

[Bexley] Treat any oil spillage report as P1.

view details

Matthew Somerville

commit sha f1d0814c8689d3dff2d6793b13a097568d9518ee

[UK] Show Highways England categories on cobrands. Without allowing through the Highways England body, clicking on a Highways England road in these cobrands would leave no categories to be selected.

view details

push time in 10 days

issue openedperliedman/reproject

SpatialReference site is https only

$ cat works.json | reproject --from=EPSG:27700 --to=EPSG:4326 --sr
[...]
Error: spatialreference.org responded with HTTP 301 when looking up "EPSG:27700".

The 301 redirect to https returned for the http request throws an error. The basic answer of switching the URL to https does not work because the http fetcher included only appears to support http.

created time in 10 days

Pull request review commentmysociety/fixmystreet

[Bromley] Code for fetching updates

 sub setup_categories_and_bodies : Private {     @$contacts = grep { grep { $_ eq 'Waste' } @{$_->groups} } @$contacts; } +sub receive_echo_event_notification : Path('/waste/echo') : Args(0) {

Yeah I assume we'll move it all to something, and this was in case I had to give it to someone prior to that :)

dracos

comment created time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha d1c38a2bdbe5891fa63bde40e398e3cc33881566

Improve Bing geocoder results. Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.

view details

push time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 3869c600e935b3bf5bfa7a43d950fd8ddaaa3848

fixup catching some things that might not be arrays that we assume are

view details

Matthew Somerville

commit sha 0ccb899f5404df77781261ad17449697b751daa2

[Bromley] Only change endpoint config when needed.

view details

Matthew Somerville

commit sha 5cb5dd2100cc4ace7a3a339b9404652518915ce5

[Bromley] Hide fixed checkbox from waste update form.

view details

push time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 1f093dd0b29be168b66f51d571462cc245c748f2

fixup! [Bromley] Restrict waste lookups per day.

view details

Matthew Somerville

commit sha 0e81c4f2960644d1ac1d989f093c12906f4a93c4

fixup catching some things that might not be arrays that we assume are

view details

Matthew Somerville

commit sha a302fd8f0f08553f522ab17c3200f0d31002246a

[Bromley] Only change endpoint config when needed.

view details

Matthew Somerville

commit sha 8a5252308c0cca856d42102bc1b1cc551d585947

[Bromley] Hide fixed checkbox from waste update form.

view details

push time in 10 days

PR opened mysociety/fixmystreet

Reviewers
[Bromley] Code for fetching updates

Fixes https://github.com/mysociety/fixmystreet-commercial/issues/1898. [skip changelog] As we already had an Echo integration present here, seemed easier to use it directly rather than go via open311-adapter requesting all the IDs. Also given I was here anyway and it didn't seem to take much longer, wrote the push-notification way of doing it should we use that method. Wondered about having a F::C::Bromley;:Waste package for all this maybe, what do you think?

+373 -11

0 comment

6 changed files

pr created time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 463310980c1a6a8f308e9bfdf92157c9bcb1abf9

[Bromley] Script to update open waste reports.

view details

Matthew Somerville

commit sha b7e5cbe30e1d6fe9574e352a85a71281c45489d7

Push notification from Echo.

view details

push time in 10 days

PR opened mysociety/fixmystreet

Reviewers
Rewrite open311-update-reports

This rewrites the standard fetch-reports way of updating reports to use the same code as the extension which fetches updates directly. This means it gains access to all the functionality concerning e.g. response templates. Also factor out the Open311 construction because that simplifies it everywhere used.

+391 -493

0 comment

12 changed files

pr created time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 731c557c81af2eb7f8ee7704aec83be00b179aa3

Rewrite open311-update-reports to share code. Make GetUpdates and GetServiceRequestUpdates share a common base; spot all visible states.

view details

Matthew Somerville

commit sha 4af5e730f9e9849b481d2c1501e161779eded874

Factor out/default Open311 construction object. This simplifies the code wherever used.

view details

push time in 10 days

PR opened mysociety/fixmystreet

Reviewers
[Bromley] waste update tweaks

First fixup is to stop the bromley tests requesting gov.uk bank holiday live, whoops. Second is because if one entry in a list is returned to SOAP, it's auto-promoted to the single entry directly, which we don't want, we want to always loop.

Then the other two are to only change the Bromley endpoint for the main endpoint, so waste updates will be posted correctly to the right endpoint, and hide the fixed checkbox because users can leave updates but can't do that.

[skip changelog]

+114 -83

0 comment

5 changed files

pr created time in 10 days

issue commentmysociety/fixmystreet

Have 500 error on admin/bodies for docker version installation

Thanks for your report; the actual error will have been logged to the server error log, please could you look and include that as otherwise it will be hard to help you.

biill

comment created time in 10 days

push eventmysociety/fixmystreet

abimysoc

commit sha 230882043f4e9eabb01f12251e4a6b961df08353

Change UKCOD to mySociety Inevitably, missed one reference with first PR...

view details

Matthew Somerville

commit sha 58a7df7603b657e8b56bae9b46a0451b4534e9ad

[Hounslow] Allow two email categories to be shown. By default, devolved categories are not shown.

view details

Matthew Somerville

commit sha 4b780de3e34128a4581dbc4daead30be00ceadb4

[Open311] Use devolved data on update sending.

view details

Joe Siltberg

commit sha b6e026aad3424a966ac449bcacab7335731bad7f

Upgrades the Mozilla::CA module to 20200520. LWP::UserAgent (used by MapIt and Open311 integrations) uses this cert bundle by default to verify peers. Fixes #3088

view details

Matthew Somerville

commit sha 2b462f20d2479649c14efead2680a49543ca32d0

Merge branch 'open311-post-devolved-update'

view details

Matthew Somerville

commit sha 13913fa01909342828ea734bf51621f79c7f378d

[IoW] Small refactor of munging functions.

view details

Matthew Somerville

commit sha 2938ef2b2a56246f1d0ab5bd0b753dc51d7db664

[Hounslow] Factor non-map report creation calls.

view details

Matthew Somerville

commit sha 1d02b147a7f5aad09444552586a65433223815d4

Allow extra questions to use a textarea.

view details

Matthew Somerville

commit sha 14c16948f688a7e029dfe07f6183a1bc997f54a1

[Bexley] Factor out BH code, fix offline test.

view details

Matthew Somerville

commit sha e725bc10c963f5b3c8405b80528172359d22eaeb

[Zurich] Factor out working days calculator.

view details

Martin Wright

commit sha 601dd4627e6f2bc381d1f6743b83356035150907

[Bromley] Switch out header font Bromley's live site doesn't seem to have Gill Sans anywhere any more

view details

Matthew Somerville

commit sha e9d016cdbb7a476862d1bcb42961d1328e554534

[Bromley] Add waste service. This creates a non-map property-based reporting flow for reporting missed collections, requesting new containers, and general enquiries, plus an integration to view bin collection days. Such reports are always prviate, in categories that are hidden from the map filters, and never shown on .com.

view details

Matthew Somerville

commit sha 7418d68a2f0cc12e05d03aea0fa1058d70c98a73

[Bromley] Report missed bin within 2 working days.

view details

Matthew Somerville

commit sha 5220954abd5c277c154eed91832f7457466fc104

Add Data::ICal.

view details

Matthew Somerville

commit sha e18b46c70eb56b14818e8d0b99a1a4def796ff12

[Bromley] ICal generation.

view details

Matthew Somerville

commit sha afac07909d5d2e89e6abc67b627444ab6c09d67f

[Bromley] Send sent confirmation for waste reports

view details

Matthew Somerville

commit sha f8cb372f73390f7a2f06ebe8565e8883407ef6f0

[Bromley] No updates on closed waste reports.

view details

Matthew Somerville

commit sha ed6118e87bb89792fcc8d65ac749e3c4624a5ac1

[Bromley] Restrict waste lookups per day.

view details

Matthew Somerville

commit sha 5f4158e3c8531d4198c5fd2fffc6243dd92d6407

[Bromley] Look for open events.

view details

Matthew Somerville

commit sha db11b3a11a88e304142bd18f745bb1113e2efb7f

[Bromley] Treat some enquiries same as missed. In terms of within-two-day and no existing open event.

view details

push time in 10 days

delete branch mysociety/fixmystreet

delete branch : bromley-no-duplicates

delete time in 10 days

create barnchmysociety/fixmystreet

branch : rewrite-open311-update-reports

created branch time in 10 days

create barnchmysociety/fixmystreet

branch : bromley-waste-update-tweaks

created branch time in 10 days

push eventmysociety/fixmystreet

abimysoc

commit sha 230882043f4e9eabb01f12251e4a6b961df08353

Change UKCOD to mySociety Inevitably, missed one reference with first PR...

view details

Matthew Somerville

commit sha 58a7df7603b657e8b56bae9b46a0451b4534e9ad

[Hounslow] Allow two email categories to be shown. By default, devolved categories are not shown.

view details

Matthew Somerville

commit sha 4b780de3e34128a4581dbc4daead30be00ceadb4

[Open311] Use devolved data on update sending.

view details

Joe Siltberg

commit sha b6e026aad3424a966ac449bcacab7335731bad7f

Upgrades the Mozilla::CA module to 20200520. LWP::UserAgent (used by MapIt and Open311 integrations) uses this cert bundle by default to verify peers. Fixes #3088

view details

Matthew Somerville

commit sha 2b462f20d2479649c14efead2680a49543ca32d0

Merge branch 'open311-post-devolved-update'

view details

Matthew Somerville

commit sha 13913fa01909342828ea734bf51621f79c7f378d

[IoW] Small refactor of munging functions.

view details

Matthew Somerville

commit sha 2938ef2b2a56246f1d0ab5bd0b753dc51d7db664

[Hounslow] Factor non-map report creation calls.

view details

Matthew Somerville

commit sha 1d02b147a7f5aad09444552586a65433223815d4

Allow extra questions to use a textarea.

view details

Matthew Somerville

commit sha 14c16948f688a7e029dfe07f6183a1bc997f54a1

[Bexley] Factor out BH code, fix offline test.

view details

Matthew Somerville

commit sha e725bc10c963f5b3c8405b80528172359d22eaeb

[Zurich] Factor out working days calculator.

view details

Martin Wright

commit sha 601dd4627e6f2bc381d1f6743b83356035150907

[Bromley] Switch out header font Bromley's live site doesn't seem to have Gill Sans anywhere any more

view details

Matthew Somerville

commit sha e9d016cdbb7a476862d1bcb42961d1328e554534

[Bromley] Add waste service. This creates a non-map property-based reporting flow for reporting missed collections, requesting new containers, and general enquiries, plus an integration to view bin collection days. Such reports are always prviate, in categories that are hidden from the map filters, and never shown on .com.

view details

Matthew Somerville

commit sha 7418d68a2f0cc12e05d03aea0fa1058d70c98a73

[Bromley] Report missed bin within 2 working days.

view details

Matthew Somerville

commit sha 5220954abd5c277c154eed91832f7457466fc104

Add Data::ICal.

view details

Matthew Somerville

commit sha e18b46c70eb56b14818e8d0b99a1a4def796ff12

[Bromley] ICal generation.

view details

Matthew Somerville

commit sha afac07909d5d2e89e6abc67b627444ab6c09d67f

[Bromley] Send sent confirmation for waste reports

view details

Matthew Somerville

commit sha f8cb372f73390f7a2f06ebe8565e8883407ef6f0

[Bromley] No updates on closed waste reports.

view details

Matthew Somerville

commit sha ed6118e87bb89792fcc8d65ac749e3c4624a5ac1

[Bromley] Restrict waste lookups per day.

view details

Matthew Somerville

commit sha 5f4158e3c8531d4198c5fd2fffc6243dd92d6407

[Bromley] Look for open events.

view details

Matthew Somerville

commit sha db11b3a11a88e304142bd18f745bb1113e2efb7f

[Bromley] Treat some enquiries same as missed. In terms of within-two-day and no existing open event.

view details

push time in 10 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 3c7bdbc6428b7c726decf5cdfef8856128a4d5a6

Factor out/default Open311 construction object. This simplifies the code wherever used.

view details

Matthew Somerville

commit sha ca83c51ba715f3f0afe045c1e8acad86e55c55f6

[Bromley] Script to update open waste reports.

view details

push time in 11 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 572a791943432fe6cc861f37dd1b2897b40aa51b

[Bromley] Script to update open waste reports.

view details

push time in 11 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha ce841b76d90a901c67827143e6f653d50df58097

Factor out/default Open311 construction object. This simplifies the code wherever used.

view details

Matthew Somerville

commit sha 61f62591363bd8f85f4925deea1545ef2bcc66df

[Bromley] Script to update open waste reports.

view details

push time in 11 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha e367e62e6202a49ddc7d266ea67fa797a512cc46

Rewrite open311-update-reports to share code. Make GetUpdates and GetServiceRequestUpdates share a common base; spot all visible states.

view details

Matthew Somerville

commit sha 5db7eec666653529ce5417a16ded27ccde85ec7a

Factor out open311 construction of UpdatesBase.

view details

Matthew Somerville

commit sha 07dfff4594b4948bccae329b4f4c2ff10ddbb5e7

[Bromley] Script to update open waste reports.

view details

push time in 11 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 2842dc2439bdf6ee5d35f0ef619a82442e464e20

Improve Bing geocoder results. Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.

view details

push time in 11 days

push eventmysociety/fixmystreet

Matthew Somerville

commit sha 4b780de3e34128a4581dbc4daead30be00ceadb4

[Open311] Use devolved data on update sending.

view details

Joe Siltberg

commit sha b6e026aad3424a966ac449bcacab7335731bad7f

Upgrades the Mozilla::CA module to 20200520. LWP::UserAgent (used by MapIt and Open311 integrations) uses this cert bundle by default to verify peers. Fixes #3088

view details

Matthew Somerville

commit sha 2b462f20d2479649c14efead2680a49543ca32d0

Merge branch 'open311-post-devolved-update'

view details

Matthew Somerville

commit sha 5c0e120b7eb1e02fc67b87be89fef484338f3158

Improve Bing geocoder results. Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.

view details

push time in 11 days

PR merged mysociety/fixmystreet

Upgrades the Mozilla::CA module to 20200520.

LWP::UserAgent (used by MapIt and Open311 integrations) uses this cert bundle by default to verify peers.

Fixes #3088

+7 -3

2 comments

2 changed files

joesiltberg

pr closed time in 11 days

more