profile
viewpoint
Json Choi dolsup @Ecube-Labs Seoul, South Korea a software engineer making silly things sometimes

dolsup/BanmalMode 54

짧고 명료하고 자유롭게 반말 쓰자.

dolsup/cli-fireplace 17

🎉Enjoy your 🎁Christmas🎅 watching digital fireplace🔥 on your own terminal🖥

dolsup/fontler 9

fontler is a node.js module using sfntly for font subsetting

dolsup/hyeongnya 8

A transpiler between 혀엉 and 야옹

dolsup/nano-shinonome-2.5.3 7

a fork of GNU nano 2.5.3 with Nano-chan! (IT'S SO KAWAII !)

dolsup/gulim 6

a new esoteric scripting language based on Korean, in Hangul, in Gulim

dolsup/node-markov-kor 3

무작위 텍스트 생성을 위한 마르코프 체인

dolsup/actac.js 2

아스키를 아희 코드로! Convert ASCII characters into Aheui print code

dolsup/ASCII-to-Aheui-herokuapp 1

아스키 문자를 아희 코드로 변환

startedEngHyu/til-ros

started time in 12 days

startedParkSB/daily-news-for-trainee

started time in 13 days

startedParkSB/the-camp-lib

started time in 13 days

startedopenai/gpt-3

started time in 14 days

startedgithub/gh-ost

started time in 15 days

startedhill/recursive-github-profile

started time in 16 days

startedantfu/reactivue

started time in 19 days

startedMakeNowJust/sushi-ware

started time in 22 days

started738/awesome-sushi

started time in 22 days

started20chan/github-now

started time in 23 days

startedyou-dont-need/You-Dont-Need-Momentjs

started time in 24 days

starteddiego3g/rocketredis

started time in a month

startedmildsunrise/protobuf-inspector

started time in a month

starteduditalias/timeline

started time in a month

startedfemiwiki/femiwiki

started time in a month

issue commentgoogle/or-tools

TimeLimit with RoutingModel?

a note for people see: https://github.com/google/or-tools/commit/3bc57f1aec91a31cb9c34c7a7a6d7a69986225d6

tgsmith61591

comment created time in a month

startedRyuaNerin/only-stackoverflow

started time in 2 months

startedaholstenson/miio

started time in 2 months

startednlpodyssey/spago

started time in 2 months

PR opened stephenh/ts-proto

fix typo in README

--ts_proto_out=env=node -> --ts_proto_opt=env=node

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchdolsup/ts-proto

branch : dolsup-patch-1

created branch time in 2 months

push eventdolsup/ts-proto

Philipp von Weitershausen

commit sha 77c807b38606bd49144edd22c500e2e7c49388b5

repeated google.protobuf.FoobarValue fields should translate to Foobar[], not Array<Foobar | undefined> (#81) addresses https://github.com/stephenh/ts-proto/issues/80

view details

Stephen Haberman

commit sha c235a948c993a13f8da1ba7948f0378866952651

v1.21.4.

view details

Stephen Haberman

commit sha 7b839834dfa176850132c87322623f5348487704

Don't drop falsey values in maps. Fixes #79.

view details

Stephen Haberman

commit sha 6ce103a9a3c50fc1c5556468fe9608297a86d1e3

v1.21.5

view details

Jiwon Choi

commit sha 7b8b3b1dccf0d8bcd90f09ed4bab4552b5e2f11d

support bytes as Buffer by Env option

view details

Stephen Haberman

commit sha b9eeae89891e8a10ff152e6b18ecd8440babee84

Add test output and an 'as' fix for Buffer support.

view details

Stephen Haberman

commit sha 31bfaf5a7db1aecd6acea2481badb508d9c0ed2e

Merge branch 'bytes-as-buffer' * bytes-as-buffer: Add test output and an 'as' fix for Buffer support. support bytes as Buffer by Env option

view details

Stephen Haberman

commit sha 19c1838079aad8bc4f9d054752a20c1e2cad3025

v1.22.0

view details

Stephen Haberman

commit sha 28e57f48dc30c0cb60fecfc2a118e1ce5f264e11

Add env=both as the default, fix unnecessary 'as Buffer'.

view details

Stephen Haberman

commit sha dc6fe35acb8015b2b4f4a8aa40d18d308a226689

v1.23.0

view details

Ciaran Liedeman

commit sha b54c5aefb4396d392b59eb82f425a38419bb8c84

Add Github actions (#83)

view details

Stephen Haberman

commit sha 7a00bd2279c65c55d8bc4dc62a1dd6f9fc1a4534

Fix github actions badge.

view details

Ciaran Liedeman

commit sha 4d3f7e9e07ade65afb3260ba9699cf142faee1cf

Upgraded prettier and added to CI (#84)

view details

Stephen Haberman

commit sha 20436d67b641162e6538ccb62af944462811e9c9

Send initial yarn install stderr to /dev/null to avoid false warnings. (#87)

view details

Ciaran Liedeman

commit sha c4227fca9871ace528a0a372a8c62b5cd7ac0055

Feat/remove prototype (#86) * Replaced Object.create with rest spread * fixed tests * fix review feedback

view details

Stephen Haberman

commit sha 52ee1017de4ca2ff215e57364d8d2b98548be9c1

v1.24.0

view details

Stephen Haberman

commit sha d230f32acd6defe5b40af00844b56179c0eb192d

Fix wrong versions.

view details

Philipp von Weitershausen

commit sha cff3718f18cabf7be0c22ceb8e88847b1b693d31

Compiler flag useOptionals=true turns non-scalar fields into optional properties (#88) * Don't generate default entries in the base object when the value would be undefined * Compiler flag useOptionals=true turns non-scalar fields into optional properties Addresses first part of https://github.com/stephenh/ts-proto/issues/74 * Make messageToTypeName 'options' parameter required

view details

Stephen Haberman

commit sha 630a8031eb8fb6d7ac0c28362536ec870f97a5eb

v1.25.0

view details

Stephen Haberman

commit sha d27bb88098c9772d5624175d70c682894c15ba74

Remove note about prototype-driven defaults.

view details

push time in 2 months

PR merged dolsup/ts-proto

pull master
+4275 -914

0 comment

63 changed files

dolsup

pr closed time in 2 months

PR opened dolsup/ts-proto

pull master
+4275 -914

0 comment

63 changed files

pr created time in 2 months

startednhn/tui.image-editor

started time in 2 months

pull request commentstephenh/ts-proto

support bytes as Buffer by Env option

Great! Thanks to your efforts ☺️

dolsup

comment created time in 2 months

starteddivy-work/autopilot-deno

started time in 2 months

startedw0lfschild/Flashlight

started time in 2 months

startednate-parrott/Flashlight

started time in 2 months

startedthoughtbot/rcm

started time in 2 months

startedstjepang/smol

started time in 2 months

startediptv-org/iptv

started time in 2 months

startedYoctol/bottender

started time in 2 months

startedhotire/turnover-story

started time in 2 months

PR opened stephenh/ts-proto

support bytes as Buffer by Env option

it solves #65.

  • added options.env (browser | node)
  • protobuf bytes is Buffer on node or Uint8Array on browsers.

We need to discuss which of 'browser' and 'node' is proper to the default value for options.env.

+32 -15

0 comment

3 changed files

pr created time in 2 months

create barnchdolsup/ts-proto

branch : bytes-as-buffer-on-node

created branch time in 2 months

fork dolsup/ts-proto

An idiomatic protobuf generator for TypeScript

fork in 2 months

startedParkSB/magic-conch-shell

started time in 2 months

startedgaeulbyul/Komposer

started time in 3 months

PR opened Ecube-Labs/prettier-config

Reviewers
remove tabWidth:2 override

depth가 깊은 파일들이 아니라서 tabWidth: 2로 지정할 이유가 없습니다. back-end, front-end config의 tabWidth 설정을 따르도록 합시다.

+0 -6

0 comment

1 changed file

pr created time in 3 months

create barnchEcube-Labs/prettier-config

branch : remove-tab-width-2-override

created branch time in 3 months

create barnchEcube-Labs/prettier-config

branch : fix-glob

created branch time in 3 months

PR opened Ecube-Labs/prettier-config

Reviewers
fix glob pattern

*.js?(on)과 같은 표기법은 extended glob입니다. 셸 설정에 따라 지원하지 않는 경우가 있습니다. (저 안됨..) 그래서 표준 glob만을 사용하게끔 변경했습니다.

근데 .js, .json, .md 스페이스 두칸 설정은 루트 디렉토리에만 적용하는 거 맞죠?

+1 -1

0 comment

1 changed file

pr created time in 3 months

issue commentstephenh/ts-proto

Support bytes as Buffer (optimal under node)

Yes, that is right. Buffer extends Uint8Array so the casting itself gets no error but still we cannot use Uint8Array type directly. We have to manually cast every single Uint8Array type to Buffer in codes because Uint8Array has a different interface from Buffer's one.

dolsup

comment created time in 3 months

issue openedprotobufjs/protobuf.js

Type incompatibility between protobuf.Buffer and Buffer

protobuf.js version: 6.9, minimal

I got protobuf.Buffer type from BufferReader.bytes(). But Interface protobuf.Buffer is not compatible with Node.js Buffer type.

스크린샷 2020-05-21 오후 1 57 02 Type protobuf.Buffer is not assignable to type Buffer.

Reproduction:

import { BufferReader } from 'protobufjs/minimal';

const bufferReader: BufferReader = BufferReader.create(new Uint8Array());
const buf: Buffer = bufferReader.bytes();
$ tsc test.ts
test.ts:4:7 - error TS2740: Type 'Buffer' is missing the following properties from type 'Buffer': write, toJSON, equals, compare, and 40 more.

4 const buf: Buffer = bufferReader.bytes();
        ~~~

created time in 3 months

issue commentstephenh/ts-proto

Support bytes as Buffer (optimal under node)

@stephenh Yes I do. I've setup the project and now reading some codes.

dolsup

comment created time in 3 months

issue openedstephenh/ts-proto

Support bytes as Buffer (optimal under node)

https://github.com/protobufjs/protobuf.js#usage

protobufjs parses protobuf bytes as Buffer on Node.js on default behavior. So there is some incompatibility between imported ts interface created by protoc-gen-ts_proto and actual type parsed by protobufjs on node runtime.

created time in 3 months

delete branch dolsup/typeorm

delete branch : dolsup-fix-typo

delete time in 3 months

PR opened typeorm/typeorm

docs: fix typo

"plan javascript object" -> "plain javascript object"

+8 -8

0 comment

3 changed files

pr created time in 3 months

create barnchdolsup/typeorm

branch : dolsup-fix-typo

created branch time in 3 months

fork dolsup/typeorm

ORM for TypeScript and JavaScript (ES7, ES6, ES5). Supports MySQL, PostgreSQL, MariaDB, SQLite, MS SQL Server, Oracle, SAP Hana, WebSQL databases. Works in NodeJS, Browser, Ionic, Cordova and Electron platforms.

http://typeorm.io

fork in 3 months

startedDalgona/neodgm

started time in 3 months

startedsharkdp/fd

started time in 3 months

startedandywer/leakage

started time in 3 months

startedTerminus2049/Terminus2049.github.io

started time in 3 months

startedimazen/imageflow

started time in 3 months

more