profile
viewpoint
Daniele Belardi dnlup @immobiliare Rome, Italy https://twitter.com/_dnlup_ Need Input.

dnlup/aedes 0

Barebone MQTT broker that can run on any stream server, the node way

dnlup/ansible-for-devops 0

Ansible examples from Ansible for DevOps.

dnlup/autocannon 0

fast HTTP/1.1 benchmarking tool written in Node.js

dnlup/ava 0

🚀 Testing can be a drag. AVA helps you get it done.

dnlup/awesome-ava 0

Awesome AVA resources

dnlup/BangleApps 0

Bangle.js App Loader (and Apps)

dnlup/circular-dependency-plugin 0

Detect circular dependencies in modules compiled with Webpack

dnlup/css-modules-require-hook 0

A require hook to compile CSS Modules in runtime

pull request commentconventional-changelog/standard-version

feat(changelog): allow to pass a custom context

I am trying to figure out why the test fails on Windows. It will take a bit since I have to setup an environment for that. Any feedback is greatly appreciated in the meantime 🙏.

dnlup

comment created time in 4 days

push eventdnlup/node

Daniele Belardi

commit sha 8ba1cc895e7500dbb5b8c6410273b990cc99fc1e

esm: better error message using commonjs hint When a module is not found, the CommonJS resolver is run to try to resolve it and eventually the error message is enriched with its path.

view details

push time in 4 days

push eventdnlup/node

Daniele Belardi

commit sha 9ba10892dfc7367edc3779528624edaa99f5ce75

esm: better error message using commonjs hint When a module is not found, the CommonJS resolver is run to try to resolve it and eventually the error message is enriched with its path.

view details

push time in 4 days

pull request commentnodejs/node

[WIP] esm: better error message using commonjs hint

Thanks @Himself65 , there was a typo in the module path I was requiring. I can't reproduce the error message you posted in your last comment.

dnlup

comment created time in 4 days

push eventdnlup/node

Daniele Belardi

commit sha e37665c917d8ba6379e8c309c7098c797e05e71e

esm: better error message using commonjs hint When a module is not found, the CommonJS resolver is run to try to resolve it and eventually the error message is enriched with its path.

view details

push time in 4 days

PR opened nodejs/node

[WIP] esm: better error message using commonjs hint

When a module is not found, the CommonJS resolver is run to try to resolve it and eventually the error message is enriched with its path.

It is a work in progress because I still haven't figure out why the test fails. If the test script is run manually it throws an error with the expected message. In the meantime, any feedback or pointer is greatly appreciated :smile: .

<!-- Thank you for your pull request. Please provide a description above and review the requirements below. Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+45 -3

0 comment

4 changed files

pr created time in 5 days

push eventdnlup/node

Daniele Belardi

commit sha d1d88cff9f090af9369a1b48e56d44065c0e4576

esm: better error message using commonjs hint When a module is not found, the CommonJS resolver is run to try to resolve it and eventually the error message is enriched with its path.

view details

push time in 5 days

push eventdnlup/node

Daniele Belardi

commit sha 6c563f535a5729a085e85adfdc782b5cb43c789c

esm: better error message using commonjs hint When a module is not found, the CommonJS resolver is run to try to resolve it and eventually the error message is enriched with its path.

view details

push time in 5 days

push eventdnlup/node

Daniele Belardi

commit sha faabbb823b36ff0c3a85ec796c0ecaf99c03998b

esm: better error message using commonjs hint When a module is not found the CommonJS resolver is run to return the one that would have been resolved, if any.

view details

push time in 5 days

push eventdnlup/node

Daniele Belardi

commit sha 05bc9b7b9269453b6cb4ac8212a8810ad8e48ec1

esm: better error message using commonjs hint In case of extensionless requests, the CommonJS resolver is run to return the module that would have been resolved, if any.

view details

push time in 5 days

create barnchdnlup/node

branch : esm/better_not_found_message

created branch time in 5 days

push eventdnlup/node

Anna Henningsen

commit sha e460f8cf43863a5a8d73273ce311135ad3245699

src: keep main-thread Isolate attached to platform during Dispose This works around a situation in which the V8 WASM code calls into the platform while the Isolate is being disposed. This goes against the V8 API constract for `v8::Platform`. In lieu of a proper fix, it should be okay to keep the Isolate registered; the race condition fixed by 25447d82d cannot occur for the `NodeMainInstance`’s Isolate, as it is the last one to exit in any given Node.js process. This partially reverts 25447d82d. Refs: https://github.com/nodejs/node/pull/30909 Refs: https://github.com/nodejs/node/issues/31752 PR-URL: https://github.com/nodejs/node/pull/31795 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Shelley Vohr

commit sha 3a2254959b9e8c5177289ab1c1259f18ceaf9449

src: use hex not decimal in IsArrayIndex PR-URL: https://github.com/nodejs/node/pull/31758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Michael Dawson

commit sha 79296dc2d02c0b9872bbfcbb89148ea036a546d0

doc: guide - using valgrind to debug memory leaks Add doc for using valgrind to debug native memory leaks. Started writing this up as part of an effort in the Diagnostic WG but think it's better to have it in the core guides and then be referenced by the docs in the Diagnostic WG repo. For more details on the Diagnostic WG effort see https://github.com/nodejs/diagnostics/issues/254#issuecomment-538853390 This guide is related to `/step3 - using_native_tools.md` PR-URL: https://github.com/nodejs/node/pull/31501 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha a7c523e26df468782691c7e16b2e033c6256beb3

src: prefer 3-argument Array::New() This is nicer, because: 1. It reduces overall code size, 2. It’s faster, because `Object::Set()` calls are relatively slow, and 3. It helps avoid invalid `.Check()`/`.FromJust()` calls. PR-URL: https://github.com/nodejs/node/pull/31775 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Robert Nagy

commit sha c776a37791007e0d570355b731647e58ea5885be

http: end with data can cause write after end Calling end() with data while ending should trigger a write after end error. PR-URL: https://github.com/nodejs/node/pull/28666 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha 568fdfb1658bfcaa7832759e03661f2cb958c155

fs: fix WriteStream autoClose order WriteStream autoClose was implemented by manually calling .destroy() instead of using autoDestroy and callback. This caused some invariants related to order of events to be broken. Fixes: https://github.com/nodejs/node/issues/31776 PR-URL: https://github.com/nodejs/node/pull/31790 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Samuel Attard

commit sha 093639614fa1cea7a1bc3493d28119a924c97bc9

doc: claim ABI version 82 for Electron 10 PR-URL: https://github.com/nodejs/node/pull/31778 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 26e49d83323c78e89b2664b6eeaee90757d52868

worker: unroll file extension regexp Refs: https://github.com/nodejs/node/pull/31662#discussion_r377016190 PR-URL: https://github.com/nodejs/node/pull/31779 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Jeff

commit sha e028ea0291b845e4bec3c7cff7319a027b8c815e

doc: fix typos in doc/api/https.md PR-URL: https://github.com/nodejs/node/pull/31793 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Jeremiah Senkpiel

commit sha 4d6c861800cc6ac1dc6a0fd9d3a8b0053baec62a

doc: move @Fishrock123 to a previous releaser I have not done a release in well over a year, maybe even two. I also don't really plan to do more, as Node.js releases are very tedious. PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Jeremiah Senkpiel

commit sha 928c210a611fb6b4575843708e7cb921f311ebde

doc: move @Fishrock123 to TSC Emeriti It was a good run. Almost 5 years. I haven't really been involved in the last 3+? months though, so it's time I call it and 'retire'. I think it is unlikely that I'll be on the TSC again, as node is unfortunately becoming increasingly disinteresting (& frustrating) to me. (So long and thanks for all the fish!) PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Jeremiah Senkpiel

commit sha 30e6049c75590dec8d5edbf033edbc20e79efcb7

doc: pronouns for @Fishrock123 might as well while I'm at it feels a bit weird being the first person on this list with '/they' but I guess someone's gota do it PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Gireesh Punathil

commit sha 4c746a6cfda980c1cd0de6246781c0083d9e416c

doc: move gireeshpunathil to TSC emeritus PR-URL: https://github.com/nodejs/node/pull/31770 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

James M Snell

commit sha 5bef2ccf20cceda7975f8bce860e0f60595482fc

test: add known issue test for sync writable callback If the write callbacks are invoked synchronously with an error, onwriteError would cause the error event to be emitted synchronously, making it impossible to attach an error handler after the call that triggered it. PR-URL: https://github.com/nodejs/node/pull/31756 Refs: https://github.com/nodejs/quic/commit/b0d469c69c49c9186c1a581a7cebce4c5d398947 Refs: https://github.com/nodejs/quic/pull/341 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha 85c6fcd1cd11ec6ee22891e48a67cc97f60880e8

stream: avoid writing to writable A remainder from a previous refactoring. Refs: https://github.com/nodejs/node/pull/31197 PR-URL: https://github.com/nodejs/node/pull/31805 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 99428e0858bb3cce820190770ca8217460d95c80

doc: reword possessive form of Node.js in debugger.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha d40c648e884bd64028fa0a67122a0af87c60f467

doc: reword possessive form of Node.js in process.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha d25fcb0c201286d18c07653347258ce02951ddf8

doc: reword possessive form of Node.js in http.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha eb0ade10a7af855ecdaa822dea028d661664cd43

doc: reword possessive form of Node.js in adding-new-napi-api.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha fab3eff2e53eb9bfbb890e5ac45523ae68ae95e5

src: inform callback scopes about exceptions in HTTP parser Refs: https://github.com/nodejs/node/commit/4aca277f16b8649b5fc21d41f340fad0a47c2e61 Refs: https://github.com/nodejs/node/pull/30236 Fixes: https://github.com/nodejs/node/issues/31796 PR-URL: https://github.com/nodejs/node/pull/31801 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

push time in 6 days

startedmafintosh/pumpify

started time in 6 days

PR opened conventional-changelog/standard-version

feat(changelog): allow to pass a custom context

In repositories that are self-hosted most of the time the changelogis genereated with broken links that are missing the owner and the repository in the path. Allowing to pass a custom context to conventionalChangelog mitigates this.

.versionrc.js example configuration

module.exports = {
//...
context: {
  owner: 'some repo owner',
  repository: 'foo'
}

I saw #174 after opening this, sorry.

+47 -2

0 comment

4 changed files

pr created time in 6 days

create barnchdnlup/standard-version

branch : feat/context

created branch time in 6 days

create barnchdnlup/standard-version

branch : fix/context

created branch time in 6 days

fork dnlup/standard-version

:trophy: Automate versioning and CHANGELOG generation, with semver.org and conventionalcommits.org

fork in 7 days

fork dnlup/worker-plugin

👩‍🏭 Adds native Web Worker bundling support to Webpack.

https://npm.im/worker-plugin

fork in 9 days

PublicEvent

startedlibvips/libvips

started time in 10 days

startedindutny/json-stream-sanitizer

started time in 10 days

push eventdnlup/node

Robert Nagy

commit sha 0c7ff7fcfb221310f5b560202ff0f256c5a9781f

stream: simplify Writable.write Slightly refactors Writable.write for minor perf and readability improvements. PR-URL: https://github.com/nodejs/node/pull/31146 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Robert Nagy

commit sha df1592d2e9935305539c909fecabcb96e3dd8aee

test: async iterate destroyed stream PR-URL: https://github.com/nodejs/node/pull/28995 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

legendecas

commit sha 75311dbc2f5fbd1c81dbab94e1372b55e0dbb1ac

async_hooks: ensure event after been emitted on runInAsyncScope The exception handler user-defined will not automatically emit after for the async resource. Also removes a duplicated case `test-emit-after-uncaught-exception-runInAsyncScope.js` which is identical to test-emit-after-uncaught-exception.js. Refs: https://github.com/nodejs/node/pull/30965 PR-URL: https://github.com/nodejs/node/pull/31784 Fixes: https://github.com/nodejs/node/issues/31783 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 12 days

push eventdnlup/undici

Matteo Collina

commit sha 9e97ca763056eb106019f9f7f872e3642a9fce23

Update deps (#10)

view details

Matteo Collina

commit sha 22f6b787a9e155ff47dcfda8d917fb8ad4a71d0b

Bumped v0.5.0

view details

push time in 12 days

PR opened nodejs/node

Refactor benchmark and add no-var eslint rule

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

This removes all the remaining var in benchmark and adds a rule for no-var in benchmark/.eslintrc.yaml as proposed in https://github.com/nodejs/node/pull/31592#issuecomment-581189810.

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+63 -61

0 comment

24 changed files

pr created time in 12 days

push eventdnlup/node

Daniele Belardi

commit sha 0991d53be9ee5b04a8f2c349f428211721a206a9

benchmark: use let instead of var in tls

view details

Daniele Belardi

commit sha 98849b8fea5f7fbb87157376aa329a61d52bec94

benchmark: use let instead of var in url

view details

Daniele Belardi

commit sha 4444d3b08d21120c6866d0c080d5239919986216

benchmark: use let instead of var in util

view details

Daniele Belardi

commit sha 58ab2547ce3cc9d513e6b4644371c9ab483eae59

benchmark: use let instead of var in worker

view details

Daniele Belardi

commit sha ce9f93e8ab8e5ff7ffaca00c536009b462ea494e

benchmark: use let instead of var in zlib

view details

push time in 12 days

push eventdnlup/node

Daniele Belardi

commit sha 7acb1b17b13781346ca2591546966753b3f067f0

benchmark: add `no-var` rule in .eslintrc.yaml

view details

Daniele Belardi

commit sha 425373722c56c0e80aebea6e6e9680dab3b2e0a5

benchmark: use const instead of var in async_hooks

view details

Daniele Belardi

commit sha 1162d9c847fd0458887dffd319b79ee80e5de87b

benchmark: use let instead of var in common.js

view details

Daniele Belardi

commit sha 3e0e71b1a30de3d2d164f2602b82972cda8b9725

benchmark: use let instead of var in dns

view details

Daniele Belardi

commit sha 295111d62af9551d2bc8f282a1def97c3d8f014d

benchmark: use let instead of var in run.js

view details

Daniele Belardi

commit sha 08cf2390dd2eaf6e513d7414d56b75fc4a121a0b

benchmark: use let instead of var in timers

view details

push time in 13 days

push eventdnlup/node

Swagat Konchada

commit sha a733c18e2854eac4afbb3d82e451b0ddac871d15

doc: add note in BUILDING.md about running `make distclean` Fixes: https://github.com/nodejs/node/issues/28675 PR-URL: https://github.com/nodejs/node/pull/31542 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Joyee Cheung

commit sha e2a3a87060af4c48b2551d20dfede33183b1931d

doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect. PR-URL: https://github.com/nodejs/node/pull/31656 Refs: https://github.com/nodejs/node/pull/31611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha a555be2e45b283a201de21350c0115680a7d4e7c

worker: improve MessagePort performance Use a JS function as the single entry point for emitting `.onmessage()` calls, avoiding the overhead of manually constructing each message event object in C++. confidence improvement accuracy (*) (**) (***) worker/echo.js n=100000 sendsPerBroadcast=1 payload='object' workers=1 *** 16.34 % ±1.16% ±1.54% ±1.99% worker/echo.js n=100000 sendsPerBroadcast=1 payload='string' workers=1 *** 24.41 % ±1.50% ±1.99% ±2.58% worker/echo.js n=100000 sendsPerBroadcast=10 payload='object' workers=1 *** 26.66 % ±1.54% ±2.05% ±2.65% worker/echo.js n=100000 sendsPerBroadcast=10 payload='string' workers=1 *** 32.72 % ±1.60% ±2.11% ±2.73% worker/messageport.js n=1000000 payload='object' *** 40.28 % ±1.48% ±1.95% ±2.52% worker/messageport.js n=1000000 payload='string' *** 76.95 % ±2.19% ±2.90% ±3.75% Also fix handling exceptions returned from `MessagePort::New`. PR-URL: https://github.com/nodejs/node/pull/31605 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Tobias Nießen

commit sha 2db1c8df25db40a909a8ada75ae6da4caa34ed46

doc: update TSC name in "Release Process" PR-URL: https://github.com/nodejs/node/pull/31652 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

James M Snell

commit sha aee3e2bc4ca40538c9f470cbf67fed20de9f6dc0

src: various minor improvements to node_url Went hunting for possible performance improvements. Didn't find anything significant but did manage to make a number of style improvements that bring more in line with style guidelines and good pratice. PR-URL: https://github.com/nodejs/node/pull/31651 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha 7df429808ca336b6aa868a9ae1ceb6117c68e7c4

doc: clarify Worker exit/message event ordering Motivated by the fact that getting this wrong has led to flaky tests in our test suite. Refs: https://github.com/nodejs/node/pull/31637 PR-URL: https://github.com/nodejs/node/pull/31642 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ben Noordhuis

commit sha d394dd78de600e89ceea02b3582435e50f249aa4

src: fix OOB reads in process.title getter The getter passed a stack-allocated, fixed-size buffer to uv_get_process_title() but neglected to check the return value. When the total length of the command line arguments exceeds the size of the buffer, libuv returns UV_ENOBUFS and doesn't modify the contents of the buffer. The getter then proceeded to return whatever garbage was on the stack at the time of the call, quite possibly reading beyond the end of the buffer. Add a GetProcessTitle() helper that reads the process title into a dynamically allocated buffer that is resized when necessary. Fixes: https://github.com/nodejs/node/issues/31631 PR-URL: https://github.com/nodejs/node/pull/31633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ben Noordhuis

commit sha 3271c40ab102841735aa55f6489fe9df2cd47fcc

src: remove fixed-size GetHumanReadableProcessName Remove the version of GetHumanReadableProcessName() that operates on a fixed-size buffer. The only remaining caller is Assert() which might get called in contexts where dynamically allocating memory isn't possible but as Assert() calls printf(), which also allocates memory when necessary, this commit is unlikely to make matters much worse. PR-URL: https://github.com/nodejs/node/pull/31633 Fixes: https://github.com/nodejs/node/issues/31631 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha f3682102dca1d24959e93de918fbb583f19ee688

src: give Http2Session JS fields their own backing store It looks like it’s virtually impossible at this point to create “fake” backing stores for objects that don’t fully own their memory allocations, like the sub-field `js_fields_` of `Http2Session`. In particular, it turns out that an `ArrayBuffer` cannot always be easily separated from its backing store in that situation through by detaching it. This commit gives the JS-exposed parts of the class its own memory allocation and its own backing store, simplifying the code a bit and fixing flakiness coming from it, at the cost of one additional layer of indirection when accessing the data. Refs: https://github.com/nodejs/node/pull/30782 Fixes: https://github.com/nodejs/node/issues/31107 PR-URL: https://github.com/nodejs/node/pull/31648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Rich Trott

commit sha 8c18e91c8afc0629a097ecb193e41eab058d02bb

process: remove undocumented `now` argument from emitWarning() process.emitWarning() "now" option is undocumented and a Boolean trap. Remove it before people start adopting it. We only need it in one place internally. Replace it with an internal-only emitWarningSync() function. PR-URL: https://github.com/nodejs/node/pull/31643 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha 0279c2f28bedae92a7be3e1c67794e66432cf4b7

test: fix flaky test-inspector-connect-main-thread Previously, the test waited for a (any) message from the workers, and then attached another event listener to a specific kind of message. However, it was possible that the second listener was attached after the Worker had already exited, thus never receiving the message it was supposed to receive. (This is the race condition here – usually, the Worker thread would exit *after* the second listener was attached.) Solve this by keeping a single `'message'` event listener attached to the worker instance during its entire lifetime. Fixes: https://github.com/nodejs/node/issues/31226 PR-URL: https://github.com/nodejs/node/pull/31637 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 8a14884babdcfaaf0571c95830b3e7478c18afdb

test: fix test-benchmark-http fe3975783cc4fdba47c2e25442ca891aab31e805 added a setting to a benchmark which needs to be reflected in the test. PR-URL: https://github.com/nodejs/node/pull/31686 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Anna Henningsen

commit sha 9111e02360a4bda5c5323aa3f64d36f17f692d3a

worker: reset `Isolate` stack limit after entering `Locker` It turns out that using `v8::Locker` undoes the effects of passing an explicit stack limit as part of the `Isolate`’s resource constraints. Therefore, reset the stack limit manually after entering a Locker. Refs: https://github.com/nodejs/node/pull/26049#issuecomment-580668530 PR-URL: https://github.com/nodejs/node/pull/31593 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha 7a63d76a54b03884de25a1d561ab76386ff31f7a

src: remove dead code in InternalMakeCallback Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: https://github.com/nodejs/node/pull/31622 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha 7cbec42178ca2919c045f1120e2318d3ceaea658

doc: simplify async_hooks overview Explain the purpose of async_hooks simply in the overview. PR-URL: https://github.com/nodejs/node/pull/31660 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 375c7649ec8a67aaf5524df762f221168716a523

build: add configure option to debug only Node.js part of the binary Building Node.js with `--debug` takes a long time and generates binaries that can be hard to work with due to their size, in particular because debug builds of V8 are large. Sometimes, it’s sufficient to build the Node.js parts with native debugging options enabled. Add an option for that. PR-URL: https://github.com/nodejs/node/pull/31644 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Yuhanun Citgez

commit sha 9c753b3dc2b465496a94d7ccffc3c9438c3ce325

src: modernized unique_ptr construction PR-URL: https://github.com/nodejs/node/pull/31654 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

view details

Robert Nagy

commit sha e559842188f541b884abff2ffad4d2d3e1b841a6

stream: make readable & writable computed This makes readable and writable automatically computed based on the stream state. Effectivly deprecating/discouraging manual management of this. Makes the properties more consistent and easier to reason about. Fixes: https://github.com/nodejs/node/issues/29377 PR-URL: https://github.com/nodejs/node/pull/31197 Refs: https://github.com/nodejs/node/issues/29377 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha d016b9d70897b7702e7862252d768ecdde89bc48

stream: finished callback for closed streams Previously finished(stream, cb) would not invoke the callback for streams that have already finished, ended or errored before being passed to finished(stream, cb). PR-URL: https://github.com/nodejs/node/pull/31509 Refs: https://github.com/nodejs/node/pull/31508 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 93c4c1a273736027439d087b0a52aa33df6a2b13

doc: consolidate introductory text PR-URL: https://github.com/nodejs/node/pull/31667 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 13 days

push eventdnlup/node

Swagat Konchada

commit sha a733c18e2854eac4afbb3d82e451b0ddac871d15

doc: add note in BUILDING.md about running `make distclean` Fixes: https://github.com/nodejs/node/issues/28675 PR-URL: https://github.com/nodejs/node/pull/31542 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Joyee Cheung

commit sha e2a3a87060af4c48b2551d20dfede33183b1931d

doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect. PR-URL: https://github.com/nodejs/node/pull/31656 Refs: https://github.com/nodejs/node/pull/31611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha a555be2e45b283a201de21350c0115680a7d4e7c

worker: improve MessagePort performance Use a JS function as the single entry point for emitting `.onmessage()` calls, avoiding the overhead of manually constructing each message event object in C++. confidence improvement accuracy (*) (**) (***) worker/echo.js n=100000 sendsPerBroadcast=1 payload='object' workers=1 *** 16.34 % ±1.16% ±1.54% ±1.99% worker/echo.js n=100000 sendsPerBroadcast=1 payload='string' workers=1 *** 24.41 % ±1.50% ±1.99% ±2.58% worker/echo.js n=100000 sendsPerBroadcast=10 payload='object' workers=1 *** 26.66 % ±1.54% ±2.05% ±2.65% worker/echo.js n=100000 sendsPerBroadcast=10 payload='string' workers=1 *** 32.72 % ±1.60% ±2.11% ±2.73% worker/messageport.js n=1000000 payload='object' *** 40.28 % ±1.48% ±1.95% ±2.52% worker/messageport.js n=1000000 payload='string' *** 76.95 % ±2.19% ±2.90% ±3.75% Also fix handling exceptions returned from `MessagePort::New`. PR-URL: https://github.com/nodejs/node/pull/31605 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Tobias Nießen

commit sha 2db1c8df25db40a909a8ada75ae6da4caa34ed46

doc: update TSC name in "Release Process" PR-URL: https://github.com/nodejs/node/pull/31652 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

James M Snell

commit sha aee3e2bc4ca40538c9f470cbf67fed20de9f6dc0

src: various minor improvements to node_url Went hunting for possible performance improvements. Didn't find anything significant but did manage to make a number of style improvements that bring more in line with style guidelines and good pratice. PR-URL: https://github.com/nodejs/node/pull/31651 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha 7df429808ca336b6aa868a9ae1ceb6117c68e7c4

doc: clarify Worker exit/message event ordering Motivated by the fact that getting this wrong has led to flaky tests in our test suite. Refs: https://github.com/nodejs/node/pull/31637 PR-URL: https://github.com/nodejs/node/pull/31642 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ben Noordhuis

commit sha d394dd78de600e89ceea02b3582435e50f249aa4

src: fix OOB reads in process.title getter The getter passed a stack-allocated, fixed-size buffer to uv_get_process_title() but neglected to check the return value. When the total length of the command line arguments exceeds the size of the buffer, libuv returns UV_ENOBUFS and doesn't modify the contents of the buffer. The getter then proceeded to return whatever garbage was on the stack at the time of the call, quite possibly reading beyond the end of the buffer. Add a GetProcessTitle() helper that reads the process title into a dynamically allocated buffer that is resized when necessary. Fixes: https://github.com/nodejs/node/issues/31631 PR-URL: https://github.com/nodejs/node/pull/31633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ben Noordhuis

commit sha 3271c40ab102841735aa55f6489fe9df2cd47fcc

src: remove fixed-size GetHumanReadableProcessName Remove the version of GetHumanReadableProcessName() that operates on a fixed-size buffer. The only remaining caller is Assert() which might get called in contexts where dynamically allocating memory isn't possible but as Assert() calls printf(), which also allocates memory when necessary, this commit is unlikely to make matters much worse. PR-URL: https://github.com/nodejs/node/pull/31633 Fixes: https://github.com/nodejs/node/issues/31631 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha f3682102dca1d24959e93de918fbb583f19ee688

src: give Http2Session JS fields their own backing store It looks like it’s virtually impossible at this point to create “fake” backing stores for objects that don’t fully own their memory allocations, like the sub-field `js_fields_` of `Http2Session`. In particular, it turns out that an `ArrayBuffer` cannot always be easily separated from its backing store in that situation through by detaching it. This commit gives the JS-exposed parts of the class its own memory allocation and its own backing store, simplifying the code a bit and fixing flakiness coming from it, at the cost of one additional layer of indirection when accessing the data. Refs: https://github.com/nodejs/node/pull/30782 Fixes: https://github.com/nodejs/node/issues/31107 PR-URL: https://github.com/nodejs/node/pull/31648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Rich Trott

commit sha 8c18e91c8afc0629a097ecb193e41eab058d02bb

process: remove undocumented `now` argument from emitWarning() process.emitWarning() "now" option is undocumented and a Boolean trap. Remove it before people start adopting it. We only need it in one place internally. Replace it with an internal-only emitWarningSync() function. PR-URL: https://github.com/nodejs/node/pull/31643 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha 0279c2f28bedae92a7be3e1c67794e66432cf4b7

test: fix flaky test-inspector-connect-main-thread Previously, the test waited for a (any) message from the workers, and then attached another event listener to a specific kind of message. However, it was possible that the second listener was attached after the Worker had already exited, thus never receiving the message it was supposed to receive. (This is the race condition here – usually, the Worker thread would exit *after* the second listener was attached.) Solve this by keeping a single `'message'` event listener attached to the worker instance during its entire lifetime. Fixes: https://github.com/nodejs/node/issues/31226 PR-URL: https://github.com/nodejs/node/pull/31637 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 8a14884babdcfaaf0571c95830b3e7478c18afdb

test: fix test-benchmark-http fe3975783cc4fdba47c2e25442ca891aab31e805 added a setting to a benchmark which needs to be reflected in the test. PR-URL: https://github.com/nodejs/node/pull/31686 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Anna Henningsen

commit sha 9111e02360a4bda5c5323aa3f64d36f17f692d3a

worker: reset `Isolate` stack limit after entering `Locker` It turns out that using `v8::Locker` undoes the effects of passing an explicit stack limit as part of the `Isolate`’s resource constraints. Therefore, reset the stack limit manually after entering a Locker. Refs: https://github.com/nodejs/node/pull/26049#issuecomment-580668530 PR-URL: https://github.com/nodejs/node/pull/31593 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha 7a63d76a54b03884de25a1d561ab76386ff31f7a

src: remove dead code in InternalMakeCallback Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: https://github.com/nodejs/node/pull/31622 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha 7cbec42178ca2919c045f1120e2318d3ceaea658

doc: simplify async_hooks overview Explain the purpose of async_hooks simply in the overview. PR-URL: https://github.com/nodejs/node/pull/31660 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 375c7649ec8a67aaf5524df762f221168716a523

build: add configure option to debug only Node.js part of the binary Building Node.js with `--debug` takes a long time and generates binaries that can be hard to work with due to their size, in particular because debug builds of V8 are large. Sometimes, it’s sufficient to build the Node.js parts with native debugging options enabled. Add an option for that. PR-URL: https://github.com/nodejs/node/pull/31644 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Yuhanun Citgez

commit sha 9c753b3dc2b465496a94d7ccffc3c9438c3ce325

src: modernized unique_ptr construction PR-URL: https://github.com/nodejs/node/pull/31654 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

view details

Robert Nagy

commit sha e559842188f541b884abff2ffad4d2d3e1b841a6

stream: make readable & writable computed This makes readable and writable automatically computed based on the stream state. Effectivly deprecating/discouraging manual management of this. Makes the properties more consistent and easier to reason about. Fixes: https://github.com/nodejs/node/issues/29377 PR-URL: https://github.com/nodejs/node/pull/31197 Refs: https://github.com/nodejs/node/issues/29377 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha d016b9d70897b7702e7862252d768ecdde89bc48

stream: finished callback for closed streams Previously finished(stream, cb) would not invoke the callback for streams that have already finished, ended or errored before being passed to finished(stream, cb). PR-URL: https://github.com/nodejs/node/pull/31509 Refs: https://github.com/nodejs/node/pull/31508 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 93c4c1a273736027439d087b0a52aa33df6a2b13

doc: consolidate introductory text PR-URL: https://github.com/nodejs/node/pull/31667 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 13 days

create barnchdnlup/node

branch : refactor/benchmark_eslint_rule

created branch time in 19 days

push eventdnlup/node

Ruben Bridgewater

commit sha f9a27ea510c6b89f8d4791b2eb51e359297ac193

readline: make tab size configurable This adds the `tabSize` option to readline to allow different tab sizes. PR-URL: https://github.com/nodejs/node/pull/31318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 19 days

push eventdnlup/node

bcoe

commit sha 13fe56bbbbc290cbc16804994ce0ec1d25729775

fs: return first folder made by mkdir recursive mkdir('/foo/bar', { recursive: true }) and mkdirSync will now return the path of the first folder created. This matches more closely mkdirp's behavior, and is useful for setting folder permissions. PR-URL: https://github.com/nodejs/node/pull/31530 Refs: https://github.com/nodejs/node/issues/31481 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Harshitha KP

commit sha 25c3f7c61a167c152c10afda68a2d39161179e77

test: remove --experimental-worker flag comment worker is stable in the master branch. The flag is no longer required. PR-URL: https://github.com/nodejs/node/pull/31563 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Michael Lumish

commit sha 470511ae781f152ac53a192c7bb0f395c972d200

doc: add protocol option in http2.connect() This option is used here: https://github.com/nodejs/node/blob/70c32a6d190e2b5d7b9ff9d5b6a459d14e8b7d59/lib/internal/http2/core.js#L3010 PR-URL: https://github.com/nodejs/node/pull/31560 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Michael Perrotte

commit sha 54c1a09202e68517d826104bad3e8e787d358197

deps: upgrade npm to 6.13.7 PR-URL: https://github.com/nodejs/node/pull/31558 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Denys Otrishko

commit sha be6596352b2a1b8648dc266b5be81b6a1be180d6

doc: clarify require() OS independence PR-URL: https://github.com/nodejs/node/pull/31571 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 023ecbccc8b1e492234e769894fde2967d4a5677

src: remove preview for heap dump utilities At least `createHeapSnapshotStream()` and `triggerHeapSnapshot()` do have side effects, and more importantly, they should not be run transparently. Without this, typing e.g. `v8.getHeapSnapshot()` into the REPL will result in a crash or infinite loop while the REPL evaluates the expression for a preview. PR-URL: https://github.com/nodejs/node/pull/31570 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

ConorDavenport

commit sha d10927b687858224558dbe0f10f5c57b4139ad96

build: ignore all the "Debug","Release" folders Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: https://github.com/nodejs/node/pull/27210 PR-URL: https://github.com/nodejs/node/pull/31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Dylan Coakley

commit sha cb210110e9c7e4b8d7c64af4a45d4b1e7d429a0e

test: verify threadId in reports PR-URL: https://github.com/nodejs/node/pull/31556 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha ab9e89439e8f8699efe6c7786d5a3ba9be2a16a6

benchmark: add MessagePort benchmark Add a raw `MessagePort` benchmark that does not ping back and forth between different threads, unlike the `echo.js` benchmark, as there are some performance differences between single-threaded and multi- threaded operation, and a single-threaded Environment can be somewhat easier to work with when profiling. PR-URL: https://github.com/nodejs/node/pull/31568 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 22724894c99845755dfdafc2a87236fc311343f1

doc: list largepage values in --help This commit adds the supported --use-largepages values to the --help menu. PR-URL: https://github.com/nodejs/node/pull/31537 Fixes: https://github.com/nodejs/node/issues/31533 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rusty Conover

commit sha 0fe810168bef2a53e5ff6b2f7832e372f850e5f3

doc: clarify socket.setNoDelay() explanation Change the description of socket.setNoDelay() to make it clear that sockets have Nagle's algorithm enabled by default. Better document the tradeoff of having the algorithm enabled. Explain the behavior of the function based on the passed arguments. PR-URL: https://github.com/nodejs/node/pull/31541 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Steffen

commit sha d80c40047bedbf829bc1854a720b40e63bdb76fc

doc: fix numbering PR-URL: https://github.com/nodejs/node/pull/31575 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ben Noordhuis

commit sha 938abd9535663d45a8ec88d5fa6acc0af8e8fd13

src: use __executable_start for linux hugepages `__executable_start` is provided by GNU's and LLVM's default linker scripts, obviating the need to plug in a custom linker script. The problem with our bespoke linker script is that it works with ld.bfd but not ld.gold and cannot easily be ported because the latter linker doesn't understand the `INSERT BEFORE` directive. The /proc/self/maps scanner is updated to account for the fact that there are a number of sections between `&__executable_start` and the start of the .text section. Fortunately, those sections are all mapped into the same memory segment so we only need to look at the next line to find the start of our text segment. Fixes: https://github.com/nodejs/node/issues/31520 PR-URL: https://github.com/nodejs/node/pull/31547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha 06deb94714ddb5e18a803c517e9272a8fe657995

test: fix flaky test-memory-usage abe6a2e3d1c268f introduced a test that verifies that ArrayBuffer allocations are tracked. However, V8 supports concurrent freeing of such allocations on background threads, meaning that the results may be subject to race conditions sometimes. Disabling concurrent freeing makes the test pass consistently. Refs: https://github.com/nodejs/node/pull/31550 PR-URL: https://github.com/nodejs/node/pull/31602 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 9528f953360c34a75b3a89839e71884908c2fe6e

test: mark additional tests as flaky on Windows Basically, any of the tests that failed in the runs for https://github.com/nodejs/node/pull/31602 which was not already marked as flaky. PR-URL: https://github.com/nodejs/node/pull/31606 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Ben Noordhuis

commit sha dbe881b64ce74f437ace5c6a884dfac5df597df2

test: show child stderr output in largepages test The test starts child processes. A recent change is suspected of causing flaky crashes on one of the alpine buildbots but we can't know for sure because the test hides the child's stderr. Refs: https://github.com/nodejs/node/pull/31547#issuecomment-581076515 PR-URL: https://github.com/nodejs/node/pull/31612 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Denys Otrishko

commit sha aec9ad8f6c8a75518d81279ec5e7188348e508de

src: fix console debug output on Windows The FWrite function on Windows assumed that MultiByteToWideChar automatically null-terminates the resulting string, but it will only do so if the size of the source was passed as -1 or null character was explicitly counted in the size. The FWrite uses std::string and its `.size()` method which doesn't count the null character even though the `.data()` method adds it to the resulting string. https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-multibytetowidechar#remarks > MultiByteToWideChar does not null-terminate an output string if the input string length is explicitly specified without a terminating null character. To null-terminate an output string for this function, the application should pass in -1 or explicitly count the terminating null character for the input string. PR-URL: https://github.com/nodejs/node/pull/31580 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

ConorDavenport

commit sha 99c8c6d80ff97ac7d53e01722142ac37756aabf1

src: remove duplicate field env in CryptoJob class Removed field env from cryptojob class, replaced with function env() inherited from ThreadPoolWork PR-URL: https://github.com/nodejs/node/pull/31554 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Sam Roberts

commit sha dbaa4ca166a5da08f933ec99eee5f41b740bd13c

test: simplify test-https-simple.js It had an unused `Agent` option (no such option exists), and some code that common.must(Not)Call makes redundant. PR-URL: https://github.com/nodejs/node/pull/31584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Denys Otrishko

commit sha f7a1ef6fb51f814223e3c26fffb9d39b08f91b1b

benchmark: clean up config resolution in multiple benchmarks This removes 'to Number' casting in multiple benchmarks (which is handled by the benchmark runner) and cleans up some var usage in changed benchmarks. PR-URL: https://github.com/nodejs/node/pull/31581 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 20 days

pull request commentmcollina/autocannon

test(runMultipart): validate form payload in all cases

Is there anything I can do here?

dnlup

comment created time in 20 days

fork dnlup/kubernetes-client

Simplified Kubernetes API client for Node.js.

fork in 21 days

startedwycats/handlebars.js

started time in 23 days

pull request commentnodejs/node

benchmark: use let instead of var

@Trott @richardhoehn this still doesn' get rid of all the var. I could continue the removal in this PR and then add the rule if it's ok or, given the overlap with #28958, open a new PR (sorry I missed that PR).

dnlup

comment created time in 24 days

PR opened nodejs/node

benchmark: use let instead of var

Use let in module, napi, net, os, path, process, querystring, streams and string_decoder.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+106 -111

0 comment

54 changed files

pr created time in a month

push eventdnlup/node

Daniele Belardi

commit sha af8dccacc2246cf31f726797ee7709afaf6a2dcf

benchmark: use let instead of var Use `let` in module, napi, net, os, path, process, querystring, streams and string_decoder.

view details

push time in a month

push eventdnlup/node

Daniele Belardi

commit sha c5ff3c73023ce2f32e21d6b1565e64d8776f676c

benchmark: use let instead of var Use `let` in module, napi, net, os, path, process, querystring, streams and string_decoder..

view details

push time in a month

create barnchdnlup/node

branch : refactor/benchmark

created branch time in a month

delete branch dnlup/node

delete branch : refactor/benchmark

delete time in a month

push eventdnlup/node

Rich Trott

commit sha d32a71542e883c0273ef6fed612f63ac57d20eff

doc: fix code display in header glitch Fixes: https://github.com/nodejs/node/issues/31451 PR-URL: https://github.com/nodejs/node/pull/31460 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

cjihrig

commit sha 748eae93c6c27087113c22f43c9690ee573162d1

test: add tests for main() argument handling This test provides missing coverage for __wasi_args_get() and __wasi_args_sizes_get(), which translate to argc and argv in WASI applications. PR-URL: https://github.com/nodejs/node/pull/31426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha d6f1e395ca74c34c3729d5089f9dbe5e41eab3da

http: make --insecure-http-parser configurable per-stream or per-server From the issue: > Some servers deviate from HTTP spec enougth that Node.js can't > communicate with them, but "work" when `--insecure-http-parser` > is enabled globally. It would be useful to be able to use this > mode, as a client, only when connecting to known bad servers. This is largely equivalent to https://github.com/nodejs/node/pull/31446 in terms of code changes. Fixes: https://github.com/nodejs/node/issues/31440 Refs: https://github.com/nodejs/node/pull/31446 PR-URL: https://github.com/nodejs/node/pull/31448 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha 8d14a8cbcee313591138d233e9944664ea6186bc

doc: add ronag to collaborators PR-URL: https://github.com/nodejs/node/pull/31498 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Robert Nagy

commit sha 4fefd181c759f3e8a7297bb3f9203d2c7841b14a

doc: further fix async iterator example Further fixes an issue with the async iterator example where an incorrect assumption was made in regards that drain or error is always invoked after !write(). Fixes: https://github.com/nodejs/node/issues/31365 PR-URL: https://github.com/nodejs/node/pull/31367 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Eran Levin

commit sha 67e067eb0658281b647ff68a5a9e64ea2cfdb706

fs: watch signals for recursive incompatibility This pull request makes fs.watch throw exception, whenever it is used in an incompatible platform. For this change following changes were made to api: 1.a new error type has been introduced. 2.fs.watch has been changed accordingly. Users who use recursive on non-windows and osx platforms, will face a new exception. For this reason, it's a breaking change. Fixes: https://github.com/nodejs/node/issues/29901 PR-URL: https://github.com/nodejs/node/pull/29947 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 725682cc509527cfaff0c25450d17ed92c470024

util: fix inspection of typed arrays with unusual length This makes sure `util.inspect()` does not throw in case the typed array's length property was set to something invalid. Instead, always use the original information. PR-URL: https://github.com/nodejs/node/pull/31458 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 278d37d90d8cd208ee9cd402c3f256b192460f09

test: fix test-heapdump-worker This test was broken by de2c68c7dd17a217a818ea881e433034006fdb4b. Refs: https://github.com/nodejs/node/pull/31386 PR-URL: https://github.com/nodejs/node/pull/31494 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Denys Otrishko

commit sha 08f57265b5c58c16af9e93510cda39462ecf2713

src: reduce code duplication in BootstrapNode PR-URL: https://github.com/nodejs/node/pull/31465 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Alexander Smarus

commit sha 3188afebf472976460f54559e205b6e18af0343f

src: define noreturn attribute for windows PR-URL: https://github.com/nodejs/node/pull/31467 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 05d350a3605299b2394f346cecc2d02b644698c5

deps: upgrade to libuv 1.34.2 Notable changes: - SetApplicationDaemon() is no longer called on macOS. - uv_interface_addresses() is implemented on IBMi. - The return value of uv__open_cloexec() is now handled properly. - A race condition in fsevents has been fixed. Fixes: https://github.com/nodejs/node/issues/31328 Fixes: https://github.com/nodejs/help/issues/2099 PR-URL: https://github.com/nodejs/node/pull/31477 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Denys Otrishko

commit sha f2d5173b9deb7980b6f90d68c4d7a7b132422070

doc: clean up and streamline vm.md examples PR-URL: https://github.com/nodejs/node/pull/31474 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Daniel Bevenius

commit sha 3ff2aeceba88928f1aa33fe3ff1cc9bf84da739b

src: ignore GCC -Wcast-function-type for v8.h This commit suggests that cast-function-type warnings be ignored from v8.h. Currently, GCC reports a number of warnings like this: In file included from ../src/util.h:27, from ../src/aliased_buffer.h:7, from ../src/memory_tracker.h:5, from ../src/base_object.h:27, from ../src/async_wrap.h:27, from ../src/req_wrap.h:6, from ../src/req_wrap-inl.h:6, from ../src/connect_wrap.h:6, from ../src/connect_wrap.cc:1: ../deps/v8/include/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak( P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::BaseObject; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)]’: ../src/base_object-inl.h:123:42: required from here ../deps/v8/include/v8.h:10374:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<node::BaseObject>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type] reinterpret_cast<Callback>(callback), type); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The motivation for doing this that it makes it difficult to spot other warnings that might be important. Since it is v8 that performs this cast I was not able to find a way around it. PR-URL: https://github.com/nodejs/node/pull/31475 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gabriel Schulhof

commit sha 42995a3a116fd40e54b7f594ea60dd60163ae0c4

test: cover property n-api null cases Add test coverage for passing `NULL` to each parameter of `napi.*(propert|element)` and `napi_set_prototype`. In the case of `napi_define_properties` also test setting various initializer fields to `NULL`. PR-URL: https://github.com/nodejs/node/pull/31488 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 97ac66130294aa112e587c86d2cd28a94bbe4ecd

doc: enable visual code indication in headers This enables the grey background for inline code in headers. Refs: https://github.com/nodejs/node/pull/31460#issuecomment-577154740 PR-URL: https://github.com/nodejs/node/pull/31493 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Robert Nagy

commit sha 90e6e18f33d1f0f9e4d9775ee283b9a5f2642959

stream: add async iterator support for v1 streams PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha a6d63c44a2b3273d4e09576c52011e3197d6a4b3

stream: normalize async iterator stream destroy PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha 2c54459378039199d8362b3109908a0dd29aa2b3

stream: implement throw for async iterator PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha c6bf9539cc1645fe768bff6ce2eee85636d341a7

stream: simplify pipeline PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha 07915db233dcb03ea9586086cc4f599b96fa9000

stream: re-use legacy destroyer PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

push time in a month

PR opened mcollina/autocannon

test(runMultipart): validate form payload in all cases

Validate the parsed form returned by the test server in all test cases.

+12 -4

0 comment

1 changed file

pr created time in a month

push eventdnlup/autocannon

Daniele Belardi

commit sha c1c8da4d563a958f7c2809be33e3dd06ca8601bf

test(runMultipart): validate form payload in all cases Validate the parsed form returned by the test server in all test cases.

view details

push time in a month

create barnchdnlup/autocannon

branch : tests_improvements

created branch time in a month

push eventdnlup/autocannon

Daniele Belardi

commit sha 72b88a03e24313bed11dce57e4181ab9d9721a6d

fix: multipart form handling (#241) Fix Content-Disposition header writing by exposing `form-data` `.append()` method options in the `options` key of the form object when the type is `file`. This allows passing a custom `filename` or `filepath` for a file. By default the `filename` is set to the file name passed in the `path` key. See: * https://github.com/form-data/form-data/tree/v2.5.1#alternative-submission-methods * https://github.com/form-data/form-data/tree/v2.5.1#void-append-string-field-mixed-value--mixed-options-

view details

Matteo Collina

commit sha 02a9a7132d0ff3e00c10d7d853f267e9e2f60374

Bumped v4.5.2

view details

push time in a month

starteddavidmarkclements/0x

started time in a month

issue commentmcollina/autocannon

Allow specifying a filename when uploading a file through form

@kim0 Yes it can. You can try something like:

autocannon({
  url: 'http://localhost:3000',
  connections: 10, //default
  pipelining: 1, // default
  duration: 10 // default,
  form: {
    fieldName: { type: 'file', path: '/some/path/file.ext', options: { filename: 'test_[<id>].ext' } }
 },
 idReplacement: true
}, console.log)
kim0

comment created time in a month

delete branch dnlup/autocannon

delete branch : fix/form

delete time in a month

push eventdnlup/autocannon

Daniele Belardi

commit sha 5670bb392d53eaeeb74a5349a82e67764aaf526f

fix: multipart form handling Fix Content-Disposition header writing by exposing `form-data` `.append()` method options in the `options` key of the form object when the type is `file`. This allows passing a custom `filename` or `filepath` for a file. By default the `filename` is set to the file name passed in the `path` key. See: * https://github.com/form-data/form-data/tree/v2.5.1#alternative-submission-methods * https://github.com/form-data/form-data/tree/v2.5.1#void-append-string-field-mixed-value--mixed-options-

view details

push time in a month

PR opened mcollina/autocannon

fix: multipart form handling

Fix Content-Disposition header writing by exposing form-data .append() method options in the options key of the form object when the type is file. This allows passing a custom filename or filepath for a file. By default the filename is set to the file name passed in the path key.

See:

  • https://github.com/form-data/form-data/tree/v2.5.1#alternative-submission-methods
  • https://github.com/form-data/form-data/tree/v2.5.1#void-append-string-field-mixed-value--mixed-options-

Fix #240

@mcollina I don't know if this is clear enough. Maybe I should add some examples.

+133 -10

0 comment

5 changed files

pr created time in a month

create barnchdnlup/autocannon

branch : fix/form

created branch time in a month

push eventdnlup/autocannon

Alexander Papageorgiou

commit sha 7a8c4f9d7c489706ba394448ff33ea87612f4787

feat: add setupRequest per request for requests array (#239) * feat: add setupRequest per request for requests array * fix: removed tracking of package-lock.json

view details

Matteo Collina

commit sha 09a7f315091df37dd5376679f60c5481b1e1abe5

updated dependencies

view details

Matteo Collina

commit sha 56a0565793685a1b83a1e84e92659ecb07423b0b

Bumped v4.5.0

view details

Matteo Collina

commit sha 620b6c7c33d77255c1da04c1fa6858cd92b323f6

npmignore .nyc_output

view details

Matteo Collina

commit sha e30a77abd917e28c83849f65f84d716abac19689

Bumped v4.5.1

view details

push time in a month

issue commentmcollina/autocannon

Allow specifying a filename when uploading a file through form

Thanks @kim0 , my work has been adding bugs so far :laughing: . I will try to work on it this week.

kim0

comment created time in a month

PR opened nodejs/node

benchmark: use let and const instead of var

Use let and const in domain, es, events, fixtures, fs, http, http2 and misc.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

I tried to run the modified benchmarks and a few of them are failing:

http benchmark

Screenshot from 2020-01-26 12-13-30

http2 benchmark

Screenshot from 2020-01-26 12-14-44

misc benchmark

Screenshot from 2020-01-26 12-15-27

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+105 -111

0 comment

35 changed files

pr created time in a month

push eventdnlup/node

Daniele Belardi

commit sha aff86f9e4d105b9d735918046544edd6f55d89d3

benchmark: use let and const instead of var Use let and const in domain, es, events, fixtures, fs, http, http2 and misc.

view details

push time in a month

push eventdnlup/node

Daniele Belardi

commit sha fa5aa82a134ae11eb50c82060bd149830417eb4d

benchmark: use let and const instead of var Use let and const in domain, es, events, fixtures, fs.

view details

push time in a month

create barnchdnlup/node

branch : refactor/benchmark

created branch time in a month

push eventdnlup/node

Geoffrey Booth

commit sha 3bcb2e17f81ad08b94eb541560fc01fded154e0b

doc: add GeoffreyBooth to collaborators PR-URL: https://github.com/nodejs/node/pull/31306 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Alexander Wang

commit sha 4524c115e0219912441401adc9fd06157fff8417

doc: fix a code example in zlib.md PR-URL: https://github.com/nodejs/node/pull/31264 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Shelley Vohr

commit sha a3d8de956ed5043d9bbbc09d30ed9d5b1e54186b

src: include uv.h in node_binding header This was removed in https://github.com/nodejs/node/commit/3bb085dbad4d23030c731834e35b2804c8a50b23 but is needed by Electron on Windows, as otherwise compilation errors will occur as a result of unknown libuv types. PR-URL: https://github.com/nodejs/node/pull/31265 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

carterbancroft

commit sha 6d443083e8b2057cca0b52e58cd332fc030aa87a

doc: update README to make Node.js description clearer Fixes: https://github.com/nodejs/node/issues/24872 PR-URL: https://github.com/nodejs/node/pull/31266 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha f4797ff1ef7304659d747d181ec1e7afac408d50

process: allow monitoring uncaughtException Installing an uncaughtException listener has a side effect that process is not aborted. This is quite bad for monitoring/logging tools which tend to be interested in errors but don't want to cause side effects like swallow an exception or change the output on console. There are some workarounds in the wild like monkey patching emit or rethrow in the exception if monitoring tool detects that it is the only listener but this is error prone and risky. This PR allows to install a listener to monitor uncaughtException without the side effect to consider the exception has handled. PR-URL: https://github.com/nodejs/node/pull/31257 Refs: https://github.com/nodejs/node/pull/30932 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Shelley Vohr

commit sha be055d103c85d4b716f3013f8c63b39c7dc0425b

test: allow disabling crypto tests PR-URL: https://github.com/nodejs/node/pull/31268 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha 679eb3e7d56e36215f57f22b67be8a60c40be4bb

fs: add missing HandleScope to FileHandle.close Fixes: https://github.com/nodejs/node/issues/31202 PR-URL: https://github.com/nodejs/node/pull/31276 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

dev-313

commit sha 2a94c9fa6a434f44d0941431b975f617cfe43152

doc: improve doc v8.getHeapSpaceStatistics() 'GetHeapSpaceStatistics' Link replaced in v8 getHeapSpaceStatistics function because it was showing 404 page not found. Fixes: https://github.com/nodejs/node/issues/31181 PR-URL: https://github.com/nodejs/node/pull/31274 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha a52328310c2c7a399a701c8c78dc4f1fda654c95

http2: skip creating native ShutdownWrap `ShutdownWrap` instances are being used to carry context between the start and the asynchronous end of shutting down the writable side of a `StreamBase`. HTTP/2 streams always perform this action synchronously, so no such object is necessary. PR-URL: https://github.com/nodejs/node/pull/31283 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 5baae143c7be58e7ea64f15ccab5c2e09afd7e0b

readline: improve unicode support and tab completion 1. This reduces the number of write operations used during tab completion. 2. The tab completion calculated the string width using the length of the string instead of using the actual width. That is fixed. 3. The key decoder is now capable of handling characters composed out of two code points. That reduces the number of "keypress" events that are emitted which again lowers the amount of writes triggered. PR-URL: https://github.com/nodejs/node/pull/31288 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha fe058188a158cea61656b6ecb4517abf4a679353

repl,readline: clean up code This simplifies code that was more complicated than it had to be and removes code that should never be reached. PR-URL: https://github.com/nodejs/node/pull/31288 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

gengjiawen

commit sha a42dcbeb43ab22c0db07c4e0a9eab5e0f44578f4

tools: add clang-tidy rule in src PR-URL: https://github.com/nodejs/node/pull/26840 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cclauss

commit sha 57351b628cae6167f03c0417a5e2334da574a743

build: test Python 3 using GitHub Actions-based CI PR-URL: https://github.com/nodejs/node/pull/29474 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

himself65

commit sha 6219f1fb447042106177efcb61e75b6e89bd0e03

n-api: add napi_get_all_property_names Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/30006 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rod Vagg

commit sha 625a81dea39b6698f3dd7b52978f821929d18073

tools: ensure consistent perms of signed release files Fixes: https://github.com/nodejs/build/issues/1904 PR-URL: https://github.com/nodejs/node/pull/29350 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anatoli Papirovski

commit sha 4de31d517f75dd91e64f71df7cc9d2baa3e435c2

async_hooks: remove internal only error checking This error checking is mostly unnecessary and is just a Node core developer nicety, rather than something that is needed for the user-land. It can be safely removed without any practical impact while making nextTick, timers, immediates and AsyncResource substantially faster. PR-URL: https://github.com/nodejs/node/pull/30967 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Chetan Karande

commit sha f9c16b87eff60858efa0b6977fa1d253be538589

child_process: remove unnecessary use of inner state PR-URL: https://github.com/nodejs/node/pull/29358 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha be46a7257b36ce5519d56e50db12f91b82d194f4

tools: update JSON header parsing for backticks Methods, events, and so on in headers in our documentation may (and should) be set off with backticks in the raw markdown. When that happens, the headers is misinterpreted by tools/json.js as not being a method or event. Update the JSON tool generator to accommodate backticks in this situation and add a test for this situation. Fixes: https://github.com/nodejs/node/issues/31290 PR-URL: https://github.com/nodejs/node/pull/31294 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ruben Bridgewater

commit sha 79524673c0b7045343bdf5e74455274cd3ad66dc

test: stricten readline keypress failure test condition This verifies that the thrown error is the expected one. That was not tested before. PR-URL: https://github.com/nodejs/node/pull/31300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha af5ddf21234a4508d7889c8dd172245cf7d4c422

repl: fix preview cursor position The cusor position was off in case the preview was exactly as long as the current terminal was wide. PR-URL: https://github.com/nodejs/node/pull/31293 Fixes: https://github.com/nodejs/node/issues/31291 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a month

create barnchdnlup/autocannon

branch : fix/multipart

created branch time in a month

issue commentmcollina/autocannon

Request multipart/form-data

@kim0 After some investigation I found that when the buffer is passed to form-data .append method, a filepath/name should be explicitly passed (because a Buffer is passed) in order to get the filename on the server:

  • https://github.com/mcollina/autocannon/blob/7c55bd7d862e62d5090ebe7c9ad7502dfb8b8003/lib/multipart.js#L33

See https://www.npmjs.com/package/form-data#void-append-string-field--mixed-value--mixed-options--

So as @mcollina suggested you should open a new issue because it is something that should be fixed. Given that I provided the PR for this I will try to work on it as soon as possible if there's no problem with that.

mrbatista

comment created time in a month

push eventdnlup/autocannon

Matteo Collina

commit sha 2eba13724f366abc05b847d059ad27f4e219024a

Update chalk (#226) * use strict * Update chalk to v3. Fixes #225.

view details

Matteo Collina

commit sha 89c306c0cbe5e2fae085cff37504f294f2f9ef59

Bumped v4.4.0

view details

Artem Abzanov

commit sha be88920298e9128c24d86b103f7eefe22b80639e

Fix bug with \r\n tail in requests with body (#231)

view details

Matteo Collina

commit sha 847d0f7feed919f99179e709e4d9f58bc252e862

Bumped v4.4.1

view details

legendecas

commit sha 3344f3514275d8c41eaf376e94060269f5534ca4

fix: parse argument with ":" in value header (#237) As documented header parsing should support arguments like `-H "Date=Wed Jan 01 2020 20:02:36 GMT+0800 (Hong Kong Time)"`.

view details

Matteo Collina

commit sha 7c55bd7d862e62d5090ebe7c9ad7502dfb8b8003

Bumped v4.4.2

view details

push time in a month

issue commentmcollina/autocannon

Request multipart/form-data

Hi @kim0, it should have been injected here:

https://github.com/mcollina/autocannon/blob/7c55bd7d862e62d5090ebe7c9ad7502dfb8b8003/lib/run.js#L116

by form-data. Can you share the command you ran?

mrbatista

comment created time in a month

issue openeddnlup/vue-cli-plugin-unit-ava

Ava 3.0

Test and use ava latest version.

created time in a month

push eventdnlup/undici

Daniele Belardi

commit sha 2e284f03aaf14171e86a29136ba6c34111943856

fix(client): skip body if method is `head` (#9) In case of HEAD method `client.parser.[HTTPParser.kOnHeadersComplete]` should tell the http parser to skip the body by returning 1 or true. Also `this._lastBody` assignment is skipped. See https://github.com/creationix/http-parser-js/blob/master/http-parser.js#L362

view details

push time in a month

delete branch dnlup/undici

delete branch : fix_head_method

delete time in a month

pull request commentmcollina/undici

fix(client): skip body if method is `head`

WIP removed

dnlup

comment created time in a month

push eventdnlup/undici

Daniele Belardi

commit sha 6f3ea85e14c901425960db719587557e99b86650

fix(client): skip body if method is `head` In case of HEAD method `client.parser.[HTTPParser.kOnHeadersComplete]` should tell the http parser to skip the body by returning 1 or true. Also `this._lastBody` assignment is skipped. See https://github.com/creationix/http-parser-js/blob/master/http-parser.js#L362

view details

push time in a month

Pull request review commentmcollina/undici

[WIP] fix(client): skip body if method is `head`

 class Client extends EventEmitter {       // TODO move this[kCallbacks] from being an array. The array allocation       // is showing up in the flamegraph.       const cb = this[kCallbacks].shift()+      const request = this[kRequests].shift()+      let skipBody       this._needHeaders---      this._lastBody = new Readable({ read: this[kRead].bind(this) })-      this._lastBody.push = this[kRequests].shift().wrapSimple(this._lastBody, this._lastBody.push)-+      if (request.method === 'HEAD') {+        skipBody = 1

Because of this comment in the snippet I posted

      // For older versions of node (v6.x and older?), that return skipBody=1 or skipBody=true,
      //   need this "return true;" if it's an upgrade request.
dnlup

comment created time in a month

Pull request review commentmcollina/undici

[WIP] fix(client): skip body if method is `head`

 class Client extends EventEmitter {       // TODO move this[kCallbacks] from being an array. The array allocation       // is showing up in the flamegraph.       const cb = this[kCallbacks].shift()+      const request = this[kRequests].shift()+      let skipBody

maybe this part would be better written like this

const skipBody = request.method === 'HEAD'
if (!skipBody) {
// assign lastBody
}
// logic...
return skipBody
dnlup

comment created time in a month

Pull request review commentmcollina/undici

[WIP] fix(client): skip body if method is `head`

 class Client extends EventEmitter {       // TODO move this[kCallbacks] from being an array. The array allocation       // is showing up in the flamegraph.       const cb = this[kCallbacks].shift()+      const request = this[kRequests].shift()+      let skipBody       this._needHeaders---      this._lastBody = new Readable({ read: this[kRead].bind(this) })-      this._lastBody.push = this[kRequests].shift().wrapSimple(this._lastBody, this._lastBody.push)-+      if (request.method === 'HEAD') {+        skipBody = 1

Could this be node version dependent? https://github.com/creationix/http-parser-js/blob/8a81c92201e49fda4668386263fdce284789ed73/http-parser.js#L362

dnlup

comment created time in a month

Pull request review commentmcollina/undici

[WIP] fix(client): skip body if method is `head`

 class Client extends EventEmitter {       // TODO move this[kCallbacks] from being an array. The array allocation       // is showing up in the flamegraph.       const cb = this[kCallbacks].shift()+      const request = this[kRequests].shift()       this._needHeaders--       this._lastBody = new Readable({ read: this[kRead].bind(this) })-      this._lastBody.push = this[kRequests].shift().wrapSimple(this._lastBody, this._lastBody.push)+      this._lastBody.push = request.wrapSimple(this._lastBody, this._lastBody.push)

I did skip the assignment, however the problem could have been the parser. It wasn't calling kOnMessageComplete and kOnHeadersComplete. By changing the skipBody value to 1 or true it seems fixed.

See https://github.com/mcollina/undici/pull/9#discussion_r367902840

dnlup

comment created time in a month

Pull request review commentmcollina/undici

[WIP] fix(client): skip body if method is `head`

 class Client extends EventEmitter {       // TODO move this[kCallbacks] from being an array. The array allocation       // is showing up in the flamegraph.       const cb = this[kCallbacks].shift()+      const request = this[kRequests].shift()+      let skipBody       this._needHeaders---      this._lastBody = new Readable({ read: this[kRead].bind(this) })-      this._lastBody.push = this[kRequests].shift().wrapSimple(this._lastBody, this._lastBody.push)-+      if (request.method === 'HEAD') {+        skipBody = 1

So by returning 1 or true the parser finishes all the requests

dnlup

comment created time in a month

push eventdnlup/undici

Daniele Belardi

commit sha 204c09ecae38eaa4a5108b3833ce290e1df193b1

fix(client): skip body if method is `head` In case of HEAD method `client.parser.[HTTPParser.kOnHeadersComplete]` should tell the http parser to skip the body by returning 1 or true. Also `this._lastBody` assignment is skipped. See https://github.com/creationix/http-parser-js/blob/master/http-parser.js#L362

view details

push time in a month

Pull request review commentmcollina/undici

[WIP] fix(client): skip body if method is `head`

 function makeRequestAndExpectUrl (client, i, t, cb) {   }) } +test('20 times HEAD with pipelining 10', (t) => {+  const num = 20+  t.plan(3 * num + 1)++  let count = 0+  let countGreaterThanOne = false+  const server = createServer((req, res) => {+    count+++    setTimeout(function () {+      countGreaterThanOne = countGreaterThanOne || count > 1+      res.end(req.url)+    }, 10)

I investigated a bit further and I don't think it is something correlated to use of timers. First, the example I posted before was wrong. Sorry about that. The client was not being initialized with pipelining. I am much more inclined to think I am causing an issue with pipelining because using the server in benchmark/origin.js to test even something simple like

const client = new Client('http://localhost:3000', {
    pipelining: 2
})

for (let i = 0; i < 4; i++) {
    client.request({
        path: '/',
        method: 'HEAD',
    }, (error, data) => {
        console.log(i)
        console.error(error)
        console.log(data)
        console.log()
    })
}

causes the last n requests to fail with the error Error: other side closed - ended from undici/lib/client.js:47:23. In this case is n = 1 (the last request fails). If I try 100 requests with a pipelining factor of 10 the last 9 requests fail with the same error and so on...

This is the output of the server in debug mode responding to 4 HEAD requests with pipelining 2

Screen Shot 2020-01-16 at 17 47 37

While this is 4 GET requests with pipelining 2

Screen Shot 2020-01-16 at 17 47 01

I did try to remove the use of timers in the test, but I think the problem relies in my changes.

dnlup

comment created time in a month

startedlearnk8s/templating-kubernetes

started time in a month

startedlearnk8s/templating-kubernetes

started time in a month

Pull request review commentmcollina/undici

[WIP] fix(client): skip body if method is `head`

 function makeRequestAndExpectUrl (client, i, t, cb) {   }) } +test('20 times HEAD with pipelining 10', (t) => {+  const num = 20+  t.plan(3 * num + 1)++  let count = 0+  let countGreaterThanOne = false+  const server = createServer((req, res) => {+    count+++    setTimeout(function () {+      countGreaterThanOne = countGreaterThanOne || count > 1+      res.end(req.url)+    }, 10)

You mean something like:

    const interval = setInterval(() => {
      countGreaterThanOne = countGreaterThanOne || count > 1
      if (countGreaterThanOne) {
        clearInterval(interval)
        res.end(req.url)
      }
    }, 50)

Because neither this is working. It actually fails even if I disable all the checks and the count logic. The error is always Screen Shot 2020-01-13 at 18 38 07

I need to investigate further... Now I have no clue 😢

dnlup

comment created time in a month

startedsindresorhus/is-docker

started time in a month

startedJoeKarlsson/data-structures

started time in a month

startedpikapkg/snowpack

started time in 2 months

PR closed nodejs/node

benchmark: use let instead of var in dns benchmark dns

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

2 comments

1 changed file

dnlup

pr closed time in 2 months

PR closed nodejs/node

benchmark: use let instead of var in domain benchmark domain

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

1 comment

1 changed file

dnlup

pr closed time in 2 months

pull request commentnodejs/node

benchmark: use let instead of var in domain

Closing. See https://github.com/nodejs/node/pull/31295#issuecomment-573082465

dnlup

comment created time in 2 months

pull request commentnodejs/node

benchmark: use let instead of var in dns

@BridgeAR Of course!

dnlup

comment created time in 2 months

PR opened nodejs/node

benchmark: use let instead of var in domain

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchdnlup/node

branch : benchmark_domain

created branch time in 2 months

Pull request review commentmcollina/undici

[WIP] fix(client): skip body if method is `head`

 function makeRequestAndExpectUrl (client, i, t, cb) {   }) } +test('20 times HEAD with pipelining 10', (t) => {

I used the server in benchmarks/origins.js to test.

dnlup

comment created time in 2 months

Pull request review commentmcollina/undici

[WIP] fix(client): skip body if method is `head`

 function makeRequestAndExpectUrl (client, i, t, cb) {   }) } +test('20 times HEAD with pipelining 10', (t) => {

This test fails and I still can't figure out why. If I run manually a client with pipelining = 10 I have no issues.

For example:

const { Client } = require('/path/to/undici')

const client = new Client('http://localhost:3000')

for (let i = 0; i < 100; i++) {
    client.request({
        path: '/',
        method: 'HEAD',
        pipelining: 10
    }, (error, { statusCode, body }) => {
        console.error(error)
        console.log(statusCode)
    })
}

works fine.

dnlup

comment created time in 2 months

push eventdnlup/undici

Daniele Belardi

commit sha e35e191c3e2c91e65e6e77555756c52d1ef0fa3a

fix(client): skip body if method is `head` In case of HEAD method `client.parser.[HTTPParser.kOnHeadersComplete]` should tell the parser to skip the body by returning 2. See https://github.com/creationix/http-parser-js/blob/master/http-parser.js#L357

view details

push time in 2 months

push eventdnlup/undici

Daniele Belardi

commit sha 6f7cd2141fc77f7184f90e53e55955fc7fe06437

fix(client): skip body if method is `head` In case of HEAD method `client.parser.[HTTPParser.kOnHeadersComplete]` should tell the parser to skip the body by returning 2. See https://github.com/creationix/http-parser-js/blob/master/http-parser.js#L357

view details

push time in 2 months

PR opened mcollina/undici

fix(client): skip body if method is `head`

In case of HEAD method client.parser.[HTTPParser.kOnHeadersComplete] should tell the parser to skip the body by returning 2.

See https://github.com/creationix/http-parser-js/blob/master/http-parser.js#L357

I ran tests multiple times and on my machine the lib/pool.js tests failed once in the git precommit hook.

+5 -1

0 comment

1 changed file

pr created time in 2 months

create barnchdnlup/undici

branch : fix_head_method

created branch time in 2 months

push eventdnlup/fastq

Daniele Belardi

commit sha 95b0a02d82f0ad3e871ef4fb529f2b7c8c60ba50

Fix broken links in README toc.

view details

push time in 2 months

delete branch dnlup/fastq

delete branch : fix_readme

delete time in 2 months

PR opened mcollina/fastq

Fix broken links in readme toc.

Some links in the TOC were broken.

+2 -2

0 comment

1 changed file

pr created time in 2 months

create barnchdnlup/fastq

branch : fix_readme

created branch time in 2 months

PR opened nodejs/node

benchmark: use let instead of var in dns

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchdnlup/node

branch : benchmark_dns

created branch time in 2 months

delete branch dnlup/node

delete branch : util_tls_wrap

delete time in 2 months

delete branch dnlup/node

delete branch : util_dgram

delete time in 2 months

more