profile
viewpoint
Daniele Belardi dnlup Rome, Italy https://twitter.com/_dnlup_ From MCUs to ⬡.js - Master of typos

dnlup/aedes 0

Barebone MQTT broker that can run on any stream server, the node way

dnlup/ansible-for-devops 0

Ansible examples from Ansible for DevOps.

dnlup/autocannon 0

fast HTTP/1.1 benchmarking tool written in Node.js

dnlup/ava 0

🚀 Testing can be a drag. AVA helps you get it done.

dnlup/avvio 0

Asynchronous bootstrapping of Node applications

dnlup/awesome-ava 0

Awesome AVA resources

dnlup/BangleApps 0

Bangle.js App Loader (and Apps)

dnlup/circular-dependency-plugin 0

Detect circular dependencies in modules compiled with Webpack

dnlup/conventional-changelog-config-spec 0

a spec describing the config options supported by conventional-config for upstream tooling

startedbrightcove/hot-shots

started time in 20 hours

startedpanva/jose

started time in a day

delete branch dnlup/doc

delete branch : tooling

delete time in a day

push eventdnlup/doc

Daniele Belardi

commit sha 6ceeb0afaec4926b4d4a73ee0cd0b0149eedf8ba

chore(package): remove commitizen

view details

Daniele Belardi

commit sha 35c6ea7da8a639258cb750421604d4aa35cc03cd

chore(package): update deps + standard@14.3.4 + lint-staged@10.2.6 + husky@4.2.5

view details

Daniele Belardi

commit sha 4553f0f4120cf323c06ab8866f88b79e0597ca80

chore(package): update standard-version to 8.0.0

view details

Daniele Belardi

commit sha 27985c14a3d91a8aa02d89db666b3bd71c9181ae

chore(package): fix automatic security warns

view details

Daniele Belardi

commit sha 21c5fcbc9942f77bdfdb724bc8e536442bac0c07

Merge pull request #14 from dnlup/tooling Tooling

view details

push time in a day

PR merged dnlup/doc

Tooling

Remove commitizen and update deps

+1288 -2184

0 comment

3 changed files

dnlup

pr closed time in a day

PR opened dnlup/doc

Tooling

Remove commitizen and update deps

+1288 -2184

0 comment

3 changed files

pr created time in a day

create barnchdnlup/doc

branch : tooling

created branch time in a day

startedDataDog/dd-trace-js

started time in a day

delete branch dnlup/doc

delete branch : ci_no_tests_on_tags

delete time in a day

push eventdnlup/doc

Daniele Belardi

commit sha 58a40764c0b12619b1b747c398bc80e2e8f6a4fa

ci(tests): disable job on tags push fix #11

view details

Daniele Belardi

commit sha c2c6a44b25ae382c6957e28ec730c187cf4cbc5e

Merge pull request #13 from dnlup/ci_no_tests_on_tags ci(tests): disable job on tags push

view details

push time in a day

PR merged dnlup/doc

ci(tests): disable job on tags push

fix #11

+6 -1

0 comment

1 changed file

dnlup

pr closed time in a day

issue closeddnlup/doc

Exclude tests from releases

closed time in a day

dnlup

push eventdnlup/doc

Daniele Belardi

commit sha 58a40764c0b12619b1b747c398bc80e2e8f6a4fa

ci(tests): disable job on tags push fix #11

view details

push time in a day

PR opened dnlup/doc

ci(tests): disable job on tags push

fix #11

+4 -1

0 comment

1 changed file

pr created time in a day

create barnchdnlup/doc

branch : ci_no_tests_on_tags

created branch time in a day

create barnchdnlup/doc

branch : next

created branch time in a day

delete branch dnlup/doc

delete branch : tests_improvements

delete time in a day

delete branch dnlup/doc

delete branch : node_14

delete time in a day

issue openeddnlup/docker-sharp

Add PDFium as pdf loader

created time in a day

issue openeddnlup/doc

Add github releases

created time in 2 days

issue openeddnlup/doc

Exclude tests from releases

created time in 2 days

push eventdnlup/doc

Daniele Belardi

commit sha 0a401c3b71e1d452d82e0580c868c9482cc906bf

chore(release): 1.0.3

view details

push time in 2 days

created tagdnlup/doc

tagv1.0.3

Get usage and health data about your Node.js process

created time in 2 days

PR closed dnlup/doc

ci(actions): add Node 14 to the matrix
+1 -1

1 comment

1 changed file

dnlup

pr closed time in 2 days

pull request commentdnlup/doc

ci(actions): add Node 14 to the matrix

Added in #9

dnlup

comment created time in 2 days

push eventdnlup/doc

Daniele Belardi

commit sha 84dda1294d16092d8c3f7c76b9da13e5206dbf65

test: perform strict checks only locally and on linux CI runners To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if: * running locally * running on a linux runner in CI fix #2

view details

Daniele Belardi

commit sha fb6c5c6dd18205756ee8f49ca7c143f79248a866

Merge pull request #9 from dnlup/tests_improvements test: perform strict checks only locally and on linux CI runners

view details

push time in 2 days

PR merged dnlup/doc

test: perform strict checks only locally and on linux CI runners

To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if:

  • running locally
  • running on a linux runner in CI

fix #2

+137 -11

0 comment

4 changed files

dnlup

pr closed time in 2 days

issue closeddnlup/doc

Flaky tests

Tests are flaky right now.

The only platform where they run consistently is Linux. On one side, I would prefer to don't limit the checks on metrics values on just being greater than zero; on the other, I should find a good balance to avoid these random errors.

closed time in 2 days

dnlup

push eventdnlup/doc

Daniele Belardi

commit sha 84dda1294d16092d8c3f7c76b9da13e5206dbf65

test: perform strict checks only locally and on linux CI runners To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if: * running locally * running on a linux runner in CI fix #2

view details

push time in 2 days

push eventdnlup/doc

Daniele Belardi

commit sha a453cbe50233952f3f2dfe4cade6dc1a3c36c1e9

test: perform strict checks only locally and on linux CI runners To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if: * running locally * running on a linux runner in CI fix #2

view details

push time in 2 days

push eventdnlup/doc

Daniele Belardi

commit sha e9dfc975dceb918f18c484b65c721e777adebf57

test: perform strict checks only locally and on linux CI runners To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if: * running locally * running on a linux runner in CI fix #2

view details

push time in 2 days

push eventdnlup/doc

Daniele Belardi

commit sha e92da649e0f1ddd7f1c4e69aace2a57d47956117

test: perform strict checks only locally and on linux CI runners To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if: * running locally * running on a linux runner in CI fix #2

view details

push time in 2 days

push eventdnlup/doc

Daniele Belardi

commit sha 40d203e59b9ac459cbed837d4d3165f8c6068ede

test: perform strict checks only locally and on linux CI runners To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if: * running locally * running on a linux runner in CI fix #2

view details

push time in 2 days

push eventdnlup/doc

Daniele Belardi

commit sha 37cd499be06da4248806b1c596ecd53b1c321d19

test: perform strict checks only locally and on linux CI runners To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if: * running locally * running on a linux runner in CI fix #2

view details

push time in 2 days

startedobsproject/obs-studio

started time in 3 days

startedcube-js/cube.js

started time in 4 days

issue openeddnlup/doc

Stream interface

It might be useful to have a stream api also.

created time in 4 days

push eventdnlup/doc

Daniele Belardi

commit sha 4c9d2fa3c88d5f71cc6a601c4676698f2c27186f

test: perform strict checks only locally and on linux CI runners To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if: * running locally * running on a linux runner in CI fix #2

view details

push time in 4 days

push eventdnlup/doc

Daniele Belardi

commit sha 27a4cbae7d0f106331423f15c02da6307c4a1480

test: perform strict checks only locally and on linux CI runners To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if: * running locally * running on a linux runner in CI fix #2

view details

push time in 4 days

PR opened dnlup/doc

test: perform strict checks only locally and on linux CI runners

To balance the need of more detailed tests and the fact that the CI runners are not a reliable env for that on platforms other than linux, perform those kind of tests only if:

  • running locally
  • running on a linux runner in CI

fix #2

+62 -8

0 comment

4 changed files

pr created time in 4 days

create barnchdnlup/doc

branch : tests_improvements

created branch time in 4 days

delete branch dnlup/doc

delete branch : fix_readme

delete time in 5 days

push eventdnlup/doc

Daniele Belardi

commit sha f558c114ba16cb74a71bc1d2d86b73488b770f99

docs(readme): add installation instructions

view details

Daniele Belardi

commit sha cf5e55999d051a3950344c9afcc2e0e22ead3992

Merge pull request #8 from dnlup/fix_readme docs(readme): add installation instructions

view details

push time in 5 days

PR merged dnlup/doc

docs(readme): add installation instructions

Fix #3

+7 -0

0 comment

1 changed file

dnlup

pr closed time in 5 days

PR opened dnlup/doc

docs(readme): add installation instructions
+7 -0

0 comment

1 changed file

pr created time in 5 days

create barnchdnlup/doc

branch : fix_readme

created branch time in 5 days

startedmiddyjs/middy

started time in 5 days

PR opened piscinajs/piscina-priority-queue

fix(package): install piscina from npm

Hi :smile: while I was trying this project, I could not install its dependencies because the package.json declares piscina as a local dependency. I changed this to use the version 1.5.1 from npm, feel free to ignore this if there is another reason for having it as a local dep.

+2 -15

0 comment

2 changed files

pr created time in 5 days

create barnchdnlup/piscina-priority-queue

branch : minor_fixes

created branch time in 5 days

startedtuananh/camaro

started time in 5 days

startedpiscinajs/piscina-priority-queue

started time in 5 days

startedpiscinajs/fastify-piscina

started time in 5 days

startedbenweet/stackedit

started time in 6 days

issue commentlovell/sharp

Feature Request: Support Worker Threads using Sharp

Hi, Would anybody know by any chance if worker threads have their own libuv threadpool? In my tests, worker threads share the exact same sharp job queue, which is limited to 4 concurrent images (without setting UV_THREADPOOL_SIZE) and can even be queried from the main thread (sharp.counters()). Is there any way to give each thread its own set of processing threads? I have a code sample if someone is interested.

My current solution is to spawn more Node.js process, but threads would be lighter. I don't want to bug my user to set UV_THREADPOOL_SIZE either for a CLI tool.

@MarcusCemes worker threads all share the same thread pool, you can't much about it. You could try to use N workers, and in each worker set sharp concurrency to 1, but I don't think the performance would be better.

metabench

comment created time in 7 days

startedfastify/fastify-helmet

started time in 7 days

pull request commentnodejs/node

http: use `autoDestroy: true` in incoming message

The changes made here are overriding the ones you made recently, @ronag . I don't know if this approach is the best.

dnlup

comment created time in 7 days

push eventdnlup/node

Pranshu Srivastava

commit sha 2cd79700c028f99f76f5b124b30009a838019b2b

stream: add null check in Readable.from Throws `ERR_STREAM_NULL_VALUES` error if a null value is passed to `Readable.from`. Also added docs for the same. Co-Authored-By: 扩散性百万甜面包 <himself65@outlook.com> Fixes: https://github.com/nodejs/node/issues/32845 PR-URL: https://github.com/nodejs/node/pull/32873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Nick Schonning

commit sha 7171d7e41b11dae70424cef169f27ca42ec1b01d

doc: correct Nodejs to Node.js spelling PR-URL: https://github.com/nodejs/node/pull/33088 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Beth Griggs

commit sha 49db211846cb984c4f8955cd1bb2c9be374311ae

2020-04-29, Version 14.1.0 (Current) Notable changes: - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) [#32971](https://github.com/nodejs/node/pull/32971) - doc: add juanarbol as collaborator (Juan José Arboleda) [#32906](https://github.com/nodejs/node/pull/32906) - http: doc deprecate abort and improve docs (Robert Nagy) [#32807](https://github.com/nodejs/node/pull/32807) - module: do not warn when accessing `__esModule` of unfinished exports (Anna Henningsen) [#33048](https://github.com/nodejs/node/pull/33048) - n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) [#32860](https://github.com/nodejs/node/pull/32860) - src: deprecate embedder APIs with replacements (Anna Henningsen) [#32858](https://github.com/nodejs/node/pull/32858) - stream: - don't emit end after close (Robert Nagy) [#33076](https://github.com/nodejs/node/pull/33076) - don't wait for close on legacy streams (Robert Nagy) [#33058](https://github.com/nodejs/node/pull/33058) - pipeline should only destroy un-finished streams (Robert Nagy) [#32968](https://github.com/nodejs/node/pull/32968) - vm: add importModuleDynamically option to compileFunction (Gus Caplan) [#32985](https://github.com/nodejs/node/pull/32985) PR-URL: https://github.com/nodejs/node/pull/33103

view details

James M Snell

commit sha 1d69c6f47415949a2a46b72506383c2f6fc5131b

src: separate out NgLibMemoryManagerBase Extracted from the [QUIC PR](https://github.com/nodejs/node/pull/32379) So far, this is only used by the QUIC PR directly but the change itself is independent of QUIC, even if not used directly by anything else yet. Separated out per request. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33104 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

James M Snell

commit sha 80b9777888d7af1a20195d1e0393b31a520a8345

lib: cosmetic change to builtinLibs list for maintainability This is a largely cosmetic change suggested for easier maintainability of the builtinLibs list. While the QUIC PR no longer modifies this list, the original version of the PR did and the fact that all of the entries were bundled up into the same lines meant that adding one forced a larger change to all. With this PR, when we want to add a new built-in, it won't impact any of the others. PR-URL: https://github.com/nodejs/node/pull/33106 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 7acaf4ed505bc16f01fbdc3e7b1638a05621e5ef

src: crypto::UseSNIContext to use BaseObjectPtr Extracted from the QUIC PR. Not specific to QUIC. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

James M Snell

commit sha ac8dba32247a2f074f820ceff5f627b1d1a0bd06

src: return undefined when validation err == 0 Extracted from the QUIC PR. Not specific to QUIC even if the behavior is currently only used there. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Ruben Bridgewater

commit sha d7b02c3cadb9f725579df30aa6bb082399961fbf

2020-04-29, Version 13.14.0 (Current) Notable Changes: * async_hooks**: * Merge `run` and `exit` methods (Andrey Pechkurov) https://github.com/nodejs/node/pull/31950 * Prevent sync methods of async storage exiting outer context (Stephen Belanger) https://github.com/nodejs/node/pull/31950 * vm: * Add `importModuleDynamically` option to compileFunction (Gus Caplan) https://github.com/nodejs/node/pull/32985 New core collaborators: With this release, we welcome two new Node.js core collaborators: * Juan José Arboleda @juanarbol https://github.com/nodejs/node/pull/32906 * Andrey Pechkurov @puzpuzpuz https://github.com/nodejs/node/pull/32817 PR-URL: https://github.com/nodejs/node/pull/33122

view details

Anna Henningsen

commit sha 526ff86aa947253734270d0138c01c5c631ae2ec

wasi: use free() to release preopen array As this is allocated with `Calloc()`, we cannot use `delete[]` here. PR-URL: https://github.com/nodejs/node/pull/33110 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha e0ba4b1592b037491fae2a2c8802d4d8c47f1463

src: use unique_ptr for CachedData in ContextifyScript::New This closes a memory leak. PR-URL: https://github.com/nodejs/node/pull/33113 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

Anna Henningsen

commit sha ff38ec0471f075e3f9c08ac5b803649f6e7e4ac2

test: add missing calls to napi_async_destroy PR-URL: https://github.com/nodejs/node/pull/33114 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Anna Henningsen

commit sha 8698dd98bbc53ca8da90697e6fbd04a0d04a9580

test: fix out-of-bound reads from invalid sizeof usage `sizeof(data)` does not return the correct result here, as it measures the size of the `data` variable, not what it points to. PR-URL: https://github.com/nodejs/node/pull/33115 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha a7ae7aab597a874cb0087e8e333e8f7765ded88c

build: add --error-on-warn configure flag This commit adds a configuration time flag named error-on-warn: $ ./configure --help | grep -A1 error-on-warn --error-on-warn Turn compiler warnings into errors for node core sources. The motivation for this is that CI jobs can use this flag to turn warnings into errors. PR-URL: https://github.com/nodejs/node/pull/32685 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Daniel Bevenius

commit sha 2e441e152fdda36a8ae9d97e2a312e024494456f

tools: fix redundant-move warning in inspector Currently, the following warning is generated from the inspector protocol: /out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp: In member function ‘virtual std::unique_ptr<node::inspector::protocol::Value> node::inspector::protocol::ListValue::clone() const’: /out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:739:21: error: redundant move in return statement [-Werror=redundant-move] 739 | return std::move(result); | ~~~~~~~~~^~~~~~~~ This commit removes the move for DictionaryValue and ListValue. PR-URL: https://github.com/nodejs/node/pull/32685 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Guy Bedford

commit sha 2496db8e0946de58911cac7b495d854cb18c179d

module: no type module resolver side effects PR-URL: https://github.com/nodejs/node/pull/33086 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

view details

himself65

commit sha 0bd24a6e563f92e67f582dbd470355acc74f7792

stream: simplify Readable push/unshift logic PR-URL: https://github.com/nodejs/node/pull/32899 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha 5f2c4ce74f33cf7da5628f6a28c2c06841e16c90

vm: fix vm.measureMemory() and introduce execution option https://github.com/nodejs/node-v8/pull/147 broke the `vm.measureMemory()` API. It only created a `MeasureMemoryDelegate` and without actually calling `v8::Isolate::MeasureMemory()` so the returned promise will never resolve. This was not caught by the tests because the promise resolvers were not wrapped with `common.mustCall()`. This patch migrates the API properly and also introduce the newly added execution option to the API. It also removes support for specifying contexts to measure - instead we'll just return the measurements for all contexts in the detailed mode, which is what the `performance.measureMemory()` prototype in V8 currently does. We can consider implementing our own `v8::MeasureMemoryDelegate` to select the target context in `ShouldMeasure()` in the future, but then we'll also need to implement `MeasurementComplete()` to assemble the result. For now it's probably too early to do that. Since this API is still experimental (and guarded with a warning), such breakage should be acceptable. Refs: https://github.com/nodejs/node-v8/pull/147 PR-URL: https://github.com/nodejs/node/pull/32988 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha d84f1312915fe45fe0febe888db692c74894c382

stream: fix stream.finished on Duplex finished would incorrectly believe that a Duplex is already closed if either the readable or writable side has completed. Fixes: https://github.com/nodejs/node/issues/33130 PR-URL: https://github.com/nodejs/node/pull/33133 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Robert Nagy

commit sha e10e292c5eb82e1bbe22b597c0be0d219de5556d

stream: remove unused _transformState _transformState is no longer used since Transform was simplified. Refs: https://github.com/nodejs/node/pull/32763 PR-URL: https://github.com/nodejs/node/pull/33105 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Anna Henningsen

commit sha ab41b9808edadc034a4da60ab0f71e527d288892

test: move test-process-title to sequential This test can fail when run in parallel with test-process-title-cli, which also sets the process title, which is global state on Windows. Example failure (note that `foo` does not appear in test-process-title but in test-process-title-cli): not ok 1727 parallel/test-process-title --- duration_ms: 0.156 severity: fail exitcode: 1 stack: |- assert.js:103 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: + actual - expected + 'foo' - 'd:\\a\\node\\node\\out\\Release\\node.exe' at Object.<anonymous> (d:\a\node\node\test\parallel\test-process-title.js:22:1) at Module._compile (internal/modules/cjs/loader.js:1176:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10) at Module.load (internal/modules/cjs/loader.js:1040:32) at Function.Module._load (internal/modules/cjs/loader.js:929:14) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) at internal/main/run_main_module.js:17:47 { generatedMessage: true, code: 'ERR_ASSERTION', actual: 'foo', expected: 'd:\\a\\node\\node\\out\\Release\\node.exe', operator: 'strictEqual' } ... (from https://github.com/nodejs/node/runs/628144750?check_suite_focus=true) PR-URL: https://github.com/nodejs/node/pull/33150 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

push time in 7 days

push eventdnlup/node

Joyee Cheung

commit sha 8b0bdc918ec2731db34cebc934b96e0e4ad2b1a6

doc: clarify about the Node.js-only extensions in perf_hooks - Add clarifications for Node.js-only extensions - Explain the Web Performance APIs implemented in Node.js and clarify that perf_hooks also include other non-Web APIs. - Prefix exposed interfaces with `perf_hooks.` to distinguish them from internal classes. PR-URL: https://github.com/nodejs/node/pull/33199 Refs: https://github.com/nodejs/node/issues/28635 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Shelley Vohr

commit sha ed9be3ab477e977f973504955897c23d578b276c

deps: update icu to include tzdata2020a PR-URL: https://github.com/nodejs/node/pull/33362 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>

view details

cjihrig

commit sha 227ad25cc684d3dcde82c2f370ab25d3d06364b3

deps: upgrade to libuv 1.38.0 Notable changes: - `uv_library_shutdown()` has been added. - `uv_udp_init_ex()` now accepts `UV_UDP_RECVMMSG`, although it is a no-op. - Obsolete `MAX_PATH` restrictions have been removed on Windows, and Windows is now long path aware. - Windows environment variables longer than 32,767 characters are now supported. - Linux `cpu_times` are now reported as milliseconds to match other platforms. - A memory leak resulting from `uv_loop_init()` failures has been fixed. PR-URL: https://github.com/nodejs/node/pull/33446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

cjihrig

commit sha 3abb52fdb683c9c9ade1b2c7d16d0f640bbaacfd

deps: update to uvwasi 0.0.9 Notable changes: - A `DEBUG()` macro and `UVWASI_DEBUG_LOG` build option have been added to improve debugging. - Path length restrictions have been removed across the codebase. - Initial support for `poll_oneoff()` has been added on all platforms. The implementation is based on `uv_poll_t`'s. - A new `uvwasi_size_t` has been introduced across the WASI system call API. This provides consistent 32-bit `size_t`'s. - The cmake test targets are now only generated if uvwasi is the root project to avoid conflicts with targets from embedders. - `uv.h` has been removed from the public headers. - A serialization/deserialization API has been added to simplify the process of working with WASM memory. This also hides many WASI <--> WASM interfacing implementation details from embedders. - A memory corruption bug on Windows related to path resolution has been fixed. PR-URL: https://github.com/nodejs/node/pull/33445 Fixes: https://github.com/nodejs/node/issues/33403 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Benjamin Gruenbaum

commit sha b51d1cfbf27529346c7134f8fc4a855229543cc2

doc: add comment about highWaterMark limit Add a comment regarding memory limits and setting highWaterMark PR-URL: https://github.com/nodejs/node/pull/33432 Reviewd-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Jonathan Buhacoff

commit sha d093e788d188d0affffebb016ef8e50fda678ab6

doc: update function description for `decipher.setAAD` According to the [NodeJS CCM example](https://nodejs.org/docs/latest-v14.x/api/crypto.html#crypto_ccm_mode], when decrypting the `plaintextLength` parameter actually refers to the ciphertext length, not the plaintext length: ``` decipher.setAAD(aad, { plaintextLength: ciphertext.length }); ``` The same can be seen in the [OpenSSL docs](https://wiki.openssl.org/index.php/EVP_Authenticated_Encryption_and_Decryption) where a call to `EVP_DecryptUpdate` passes the ciphertext length: ``` /* Provide the total ciphertext length */ if(1 != EVP_DecryptUpdate(ctx, NULL, &len, NULL, ciphertext_len)) handleErrors(); ``` This parameter probably should have been called `inputLength` or `bufferLength` instead of `plaintextLength`, so that it makes sense both when encrypting and decrypting, but at least we can correct the sentence in the documentation for now to refer to the correct value. PR-URL: https://github.com/nodejs/node/pull/33095 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Richard Townsend

commit sha 66807e995de9a16b1cfe035f76958a178c381854

tools,gyp: add support for MSVC cross-compilation This change means that GYP can now generate two sets of projects: one exclusively for a host x64 machine and one containing a mix of x64 and Arm targets. The names of host targets are fixed up to end with _host.exe, and any actions involving them are fixed up. This allows compilation of Node on an x64 server for a Windows on Arm target. PR-URL: https://github.com/nodejs/node/pull/32867 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com>

view details

Richard Townsend

commit sha 883355125766e35126006507d1d8a09c149fc71d

build,win: add support for MSVC cross-compilation * Fixes cases in icutools where commands were issued without .exe * Changes to build scripts * Add /fp:strict flag so that MSVC's floating point behaves correctly * Enables marmasm PR-URL: https://github.com/nodejs/node/pull/32867 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com>

view details

Shelley Vohr

commit sha c841f516d530f31328b1f734428561d93bb14f4c

2020-05-19, Version 14.3.0 (Current) Notable changes: async_hooks: * (SEMVER-MINOR) move PromiseHook handler to JS (Stephen Belanger) https://github.com/nodejs/node/pull/32891 cli: * (SEMVER-MINOR) add `--trace-atomics-wait` flag (Anna Henningsen) https://github.com/nodejs/node/pull/33292 fs: * (SEMVER-MINOR) add .ref() and .unref() methods to watcher classes (rickyes) https://github.com/nodejs/node/pull/33134 http: * (SEMVER-MINOR) expose http.validate-header-name/value (osher) https://github.com/nodejs/node/pull/33119 repl: * (SEMVER-MINOR) deprecate repl._builtinLibs (Ruben Bridgewater) https://github.com/nodejs/node/pull/33294 * (SEMVER-MINOR) deprecate repl.inputStream and repl.outputStream (Ruben Bridgewater) https://github.com/nodejs/node/pull/33294 * (SEMVER-MINOR) show reference errors during preview (Ruben Bridgewater) https://github.com/nodejs/node/pull/33282 * (SEMVER-MINOR) improve repl preview (Ruben Bridgewater) https://github.com/nodejs/node/pull/33282 src: * add support for TLA (Gus Caplan) https://github.com/nodejs/node/pull/30370 PR-URL: https://github.com/nodejs/node/pull/33452

view details

Anna Henningsen

commit sha 7c755b06cee4cf3c3e3841fb891670122f50ee24

build: run full test suite in ASAN action Refs: https://github.com/nodejs/node/pull/32776 PR-URL: https://github.com/nodejs/node/pull/33170 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Daniel Bevenius

commit sha 61189d3981ef49885f8d98eef2ac0207b6e59f40

src: reduce duplication in RegisterHandleCleanups This commit suggest using a lambda for the RegisterHandlerCleanup calls in RegisterHandleCleanups. The motivation is to reduce some duplication and to make it a little easier to read as all of the calls pass in the same arguments, apart from casting the uv handle. PR-URL: https://github.com/nodejs/node/pull/33421 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha 0e92ae64f01140bc527b5a02d7f154dca882ef09

worker: fix race condition in node_messaging.cc `AddToIncomingQueue()` relies on `owner_` only being modified with `mutex_` being locked, but in these two places, that didn’t happen. Modify them to use `Detach()` instead, which has the same effect as setting `owner_ = nullptr` here, but does it with proper locking. This race condition probably only shows up in practice when Node.js is compiled in debug mode, because the compiler eliminates the duplicate load in `AddToIncomingQueue()` when compiling with optimizations enabled. PR-URL: https://github.com/nodejs/node/pull/33429 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Pranshu Srivastava

commit sha ee8756760cf788a7a22091613597c03dceeb3e24

http2: comment on usage of `Object.create(null)` Refs: https://github.com/nodejs/node/issues/29829 PR-URL: https://github.com/nodejs/node/pull/33183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Tobias Nießen

commit sha 1786504afa068b2b6591f23799dadd4e867cc529

doc: fix typos in handle scope descriptions PR-URL: https://github.com/nodejs/node/pull/33267 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ethan Arrowood

commit sha 38f444060b0527afe5dccc44ee2db55c73c62e57

doc: add fs.open() multiple constants example PR-URL: https://github.com/nodejs/node/pull/33281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Antoine du Hamel

commit sha a82001a387afa133590420c98efb6b87ad320bfb

doc: document module.path Refs: https://github.com/nodejs/node/pull/26970 Fixes: https://github.com/nodejs/node/issues/33270 PR-URL: https://github.com/nodejs/node/pull/33323 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 7 days

push eventdnlup/node

Daniele Belardi

commit sha 62e8aec1bc762da1b078ef792c5acd8ec152dc09

http: use `autoDestroy: true` in incoming message Use the default `autoDestroy: true` option in IncomingMessage.

view details

push time in 7 days

push eventdnlup/node

Robert Nagy

commit sha 15cc2b652b3199e8bf625c641a72b4233e176ac3

stream: update comment to indicate unused API destroy w/ callback was previously used by node core. This is no longer the case and the comments should reflect this to avoid confusion. PR-URL: https://github.com/nodejs/node/pull/32808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Robert Nagy

commit sha 4a6a5c34530e008258c9f603b71504b7ab733292

stream: improve comments regarding end() errors Cleans up comments and TODOs and tries to provide a more detail description in regards to error behavior of end(). PR-URL: https://github.com/nodejs/node/pull/32839 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

daemon1024

commit sha a9da65699a43f81076a1560e09ae97ad5630c35f

test: replace console.log/error() with debuglog PR-URL: https://github.com/nodejs/node/pull/32692 Fixes: https://github.com/nodejs/node/issues/32678 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Gabriel Schulhof

commit sha d3d5eca657474f25fab47036fef9469efc211d8a

Revert "n-api: detect deadlocks in thread-safe function" This reverts commit aeb7084fe6446350ec032e9819746126811bf44f. The solution creates incorrect behaviour on Windows. Re: https://github.com/nodejs/node-addon-api/pull/697#issuecomment-612993476 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/32880 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Richard Lau

commit sha 6d77df840c4a38a95d8218322b6e92ee5cf3a7b2

build: remove .git folders when testing V8 When running `make test-v8` V8's `gclient sync` converts folders under `deps/v8/third_party` into git repositories. Unfortunately the files that were checked in under `deps/v8/third_party/zlib` have been modified from the upstream Chromium repository (some files have been deleted and there are whitespace differences in some of the files that were kept) so whenever the Node.js source tree is hard reset/checked out `gclient sync` notices there are unstaged changes as the files in the Node.js source tree do not match those of the upstream Chromium third party zlib commit. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32877 Refs: https://github.com/nodejs/build/issues/2256 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Michael Dawson

commit sha 5a4f24e7e1d96af39a75c70eaacb14e28fed5341

doc: improve consistency in usage of NULL - add backticks around use of NULL - convert from null to NULL where we mean NULL Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32726 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>

view details

Daniel Bevenius

commit sha 88560ce593f87da3e869813b98edad3330ddac72

src: remove unused using in node_worker.cc This commit removes unused using declarations in src/node_worker.cc. PR-URL: https://github.com/nodejs/node/pull/32840 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Qinhui Chen

commit sha 6bcf96840121f2de61def5ad99700fb7eb6ac905

module: fix memory leak when require error occurs Delete useless module in parent module: parent.children array when error occurs, so that it can be garbage collected. Fixes: https://github.com/nodejs/node/issues/32836 PR-URL: https://github.com/nodejs/node/pull/32837 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

William Bonawentura

commit sha 5e807c1fd26912d86952222e4265ebc1a680eaa7

doc: missing brackets PR-URL: https://github.com/nodejs/node/pull/32657 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Guy Bedford

commit sha 22b6997abae339202d77877368f50ae52b890c44

module: remove experimental modules warning PR-URL: https://github.com/nodejs/node/pull/31974 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Juan José Arboleda

commit sha 8e55c277bf428c27c4b5d6abb21fcb1709fea0b0

doc: add juanarbol as collaborator PR-URL: https://github.com/nodejs/node/pull/32906 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Michael Dawson

commit sha 2abec128381b81581ab9590e4aa4ff0e868b0806

doc: add N-API version 6 to table We missed adding version 6 to the compatibility table when we defined version 6. Add it along with the versions that we know will include version 6. PR-URL: https://github.com/nodejs/node/pull/32829 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Juan José Arboleda

commit sha 392bba4ec586a3b5adfbd243aada711114afcc2d

src: remove redundant v8::HeapSnapshot namespace PR-URL: https://github.com/nodejs/node/pull/32854 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Anna Henningsen

commit sha 1ce906c16ba09885fb372962a3a56ce64ef06a20

tools: decrease timeout in test.py This fixes the following crash on Windows for me. I don't know why this I only started to see this now, but anyway, the new timeout value is still longer than a week and a half. File "tools/test.py", line 1725, in <module> sys.exit(Main()) File "tools/test.py", line 1701, in Main if RunTestCases(cases_to_run, options.progress, \ options.j, options.flaky_tests): File "tools/test.py", line 923, in RunTestCases return progress.Run(tasks) File "tools/test.py", line 145, in Run thread.join(timeout=10000000) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1015, in join self._wait_for_tstate_lock(timeout=max(timeout, 0)) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1027, in _wait_for_tstate_lock elif lock.acquire(block, timeout): OverflowError: timeout value is too large PR-URL: https://github.com/nodejs/node/pull/32868 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

view details

Nimit

commit sha e231e1a0d8857c70d6569f39d8d2e5b1955562b5

src: elevate v8 namespaces elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: https://github.com/nodejs/node/pull/32872 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Nimit

commit sha 498628644645d58a9655af71633900dd3ef159cc

test: changed function to arrow function Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required. PR-URL: https://github.com/nodejs/node/pull/32875 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha f67601cd772b9dbcc94cbf9939b0e229b815e939

doc: add `tsc-agenda` to onboarding labels list PR-URL: https://github.com/nodejs/node/pull/32832 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Robert Nagy

commit sha 73f3072ffb1256f013ffd75f479060029675b7a3

stream: simplify Writable.end() Simplifies Writable.end() by inlining and de-duplicating code. PR-URL: https://github.com/nodejs/node/pull/32882 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Robert Nagy

commit sha fd10be4b5456c867dd68bb9b3c16ed53a68c461f

stream: inline unbuffered _write PR-URL: https://github.com/nodejs/node/pull/32886 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Vadzim Zieńka

commit sha 8a3fa32a1f2a24b7e6bd6c33723a3ce226cce6a6

stream: close iterator in Readable.from Call iterator.return() if not all of its values are consumed. Fixes: https://github.com/nodejs/node/issues/32842 PR-URL: https://github.com/nodejs/node/pull/32844 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

push time in 8 days

push eventdnlup/node

Pranshu Srivastava

commit sha 2cd79700c028f99f76f5b124b30009a838019b2b

stream: add null check in Readable.from Throws `ERR_STREAM_NULL_VALUES` error if a null value is passed to `Readable.from`. Also added docs for the same. Co-Authored-By: 扩散性百万甜面包 <himself65@outlook.com> Fixes: https://github.com/nodejs/node/issues/32845 PR-URL: https://github.com/nodejs/node/pull/32873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Nick Schonning

commit sha 7171d7e41b11dae70424cef169f27ca42ec1b01d

doc: correct Nodejs to Node.js spelling PR-URL: https://github.com/nodejs/node/pull/33088 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Beth Griggs

commit sha 49db211846cb984c4f8955cd1bb2c9be374311ae

2020-04-29, Version 14.1.0 (Current) Notable changes: - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) [#32971](https://github.com/nodejs/node/pull/32971) - doc: add juanarbol as collaborator (Juan José Arboleda) [#32906](https://github.com/nodejs/node/pull/32906) - http: doc deprecate abort and improve docs (Robert Nagy) [#32807](https://github.com/nodejs/node/pull/32807) - module: do not warn when accessing `__esModule` of unfinished exports (Anna Henningsen) [#33048](https://github.com/nodejs/node/pull/33048) - n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) [#32860](https://github.com/nodejs/node/pull/32860) - src: deprecate embedder APIs with replacements (Anna Henningsen) [#32858](https://github.com/nodejs/node/pull/32858) - stream: - don't emit end after close (Robert Nagy) [#33076](https://github.com/nodejs/node/pull/33076) - don't wait for close on legacy streams (Robert Nagy) [#33058](https://github.com/nodejs/node/pull/33058) - pipeline should only destroy un-finished streams (Robert Nagy) [#32968](https://github.com/nodejs/node/pull/32968) - vm: add importModuleDynamically option to compileFunction (Gus Caplan) [#32985](https://github.com/nodejs/node/pull/32985) PR-URL: https://github.com/nodejs/node/pull/33103

view details

James M Snell

commit sha 1d69c6f47415949a2a46b72506383c2f6fc5131b

src: separate out NgLibMemoryManagerBase Extracted from the [QUIC PR](https://github.com/nodejs/node/pull/32379) So far, this is only used by the QUIC PR directly but the change itself is independent of QUIC, even if not used directly by anything else yet. Separated out per request. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33104 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

James M Snell

commit sha 80b9777888d7af1a20195d1e0393b31a520a8345

lib: cosmetic change to builtinLibs list for maintainability This is a largely cosmetic change suggested for easier maintainability of the builtinLibs list. While the QUIC PR no longer modifies this list, the original version of the PR did and the fact that all of the entries were bundled up into the same lines meant that adding one forced a larger change to all. With this PR, when we want to add a new built-in, it won't impact any of the others. PR-URL: https://github.com/nodejs/node/pull/33106 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 7acaf4ed505bc16f01fbdc3e7b1638a05621e5ef

src: crypto::UseSNIContext to use BaseObjectPtr Extracted from the QUIC PR. Not specific to QUIC. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

James M Snell

commit sha ac8dba32247a2f074f820ceff5f627b1d1a0bd06

src: return undefined when validation err == 0 Extracted from the QUIC PR. Not specific to QUIC even if the behavior is currently only used there. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Ruben Bridgewater

commit sha d7b02c3cadb9f725579df30aa6bb082399961fbf

2020-04-29, Version 13.14.0 (Current) Notable Changes: * async_hooks**: * Merge `run` and `exit` methods (Andrey Pechkurov) https://github.com/nodejs/node/pull/31950 * Prevent sync methods of async storage exiting outer context (Stephen Belanger) https://github.com/nodejs/node/pull/31950 * vm: * Add `importModuleDynamically` option to compileFunction (Gus Caplan) https://github.com/nodejs/node/pull/32985 New core collaborators: With this release, we welcome two new Node.js core collaborators: * Juan José Arboleda @juanarbol https://github.com/nodejs/node/pull/32906 * Andrey Pechkurov @puzpuzpuz https://github.com/nodejs/node/pull/32817 PR-URL: https://github.com/nodejs/node/pull/33122

view details

Anna Henningsen

commit sha 526ff86aa947253734270d0138c01c5c631ae2ec

wasi: use free() to release preopen array As this is allocated with `Calloc()`, we cannot use `delete[]` here. PR-URL: https://github.com/nodejs/node/pull/33110 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha e0ba4b1592b037491fae2a2c8802d4d8c47f1463

src: use unique_ptr for CachedData in ContextifyScript::New This closes a memory leak. PR-URL: https://github.com/nodejs/node/pull/33113 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

Anna Henningsen

commit sha ff38ec0471f075e3f9c08ac5b803649f6e7e4ac2

test: add missing calls to napi_async_destroy PR-URL: https://github.com/nodejs/node/pull/33114 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Anna Henningsen

commit sha 8698dd98bbc53ca8da90697e6fbd04a0d04a9580

test: fix out-of-bound reads from invalid sizeof usage `sizeof(data)` does not return the correct result here, as it measures the size of the `data` variable, not what it points to. PR-URL: https://github.com/nodejs/node/pull/33115 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha a7ae7aab597a874cb0087e8e333e8f7765ded88c

build: add --error-on-warn configure flag This commit adds a configuration time flag named error-on-warn: $ ./configure --help | grep -A1 error-on-warn --error-on-warn Turn compiler warnings into errors for node core sources. The motivation for this is that CI jobs can use this flag to turn warnings into errors. PR-URL: https://github.com/nodejs/node/pull/32685 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Daniel Bevenius

commit sha 2e441e152fdda36a8ae9d97e2a312e024494456f

tools: fix redundant-move warning in inspector Currently, the following warning is generated from the inspector protocol: /out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp: In member function ‘virtual std::unique_ptr<node::inspector::protocol::Value> node::inspector::protocol::ListValue::clone() const’: /out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:739:21: error: redundant move in return statement [-Werror=redundant-move] 739 | return std::move(result); | ~~~~~~~~~^~~~~~~~ This commit removes the move for DictionaryValue and ListValue. PR-URL: https://github.com/nodejs/node/pull/32685 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Guy Bedford

commit sha 2496db8e0946de58911cac7b495d854cb18c179d

module: no type module resolver side effects PR-URL: https://github.com/nodejs/node/pull/33086 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

view details

himself65

commit sha 0bd24a6e563f92e67f582dbd470355acc74f7792

stream: simplify Readable push/unshift logic PR-URL: https://github.com/nodejs/node/pull/32899 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha 5f2c4ce74f33cf7da5628f6a28c2c06841e16c90

vm: fix vm.measureMemory() and introduce execution option https://github.com/nodejs/node-v8/pull/147 broke the `vm.measureMemory()` API. It only created a `MeasureMemoryDelegate` and without actually calling `v8::Isolate::MeasureMemory()` so the returned promise will never resolve. This was not caught by the tests because the promise resolvers were not wrapped with `common.mustCall()`. This patch migrates the API properly and also introduce the newly added execution option to the API. It also removes support for specifying contexts to measure - instead we'll just return the measurements for all contexts in the detailed mode, which is what the `performance.measureMemory()` prototype in V8 currently does. We can consider implementing our own `v8::MeasureMemoryDelegate` to select the target context in `ShouldMeasure()` in the future, but then we'll also need to implement `MeasurementComplete()` to assemble the result. For now it's probably too early to do that. Since this API is still experimental (and guarded with a warning), such breakage should be acceptable. Refs: https://github.com/nodejs/node-v8/pull/147 PR-URL: https://github.com/nodejs/node/pull/32988 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha d84f1312915fe45fe0febe888db692c74894c382

stream: fix stream.finished on Duplex finished would incorrectly believe that a Duplex is already closed if either the readable or writable side has completed. Fixes: https://github.com/nodejs/node/issues/33130 PR-URL: https://github.com/nodejs/node/pull/33133 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Robert Nagy

commit sha e10e292c5eb82e1bbe22b597c0be0d219de5556d

stream: remove unused _transformState _transformState is no longer used since Transform was simplified. Refs: https://github.com/nodejs/node/pull/32763 PR-URL: https://github.com/nodejs/node/pull/33105 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Anna Henningsen

commit sha ab41b9808edadc034a4da60ab0f71e527d288892

test: move test-process-title to sequential This test can fail when run in parallel with test-process-title-cli, which also sets the process title, which is global state on Windows. Example failure (note that `foo` does not appear in test-process-title but in test-process-title-cli): not ok 1727 parallel/test-process-title --- duration_ms: 0.156 severity: fail exitcode: 1 stack: |- assert.js:103 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: + actual - expected + 'foo' - 'd:\\a\\node\\node\\out\\Release\\node.exe' at Object.<anonymous> (d:\a\node\node\test\parallel\test-process-title.js:22:1) at Module._compile (internal/modules/cjs/loader.js:1176:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10) at Module.load (internal/modules/cjs/loader.js:1040:32) at Function.Module._load (internal/modules/cjs/loader.js:929:14) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) at internal/main/run_main_module.js:17:47 { generatedMessage: true, code: 'ERR_ASSERTION', actual: 'foo', expected: 'd:\\a\\node\\node\\out\\Release\\node.exe', operator: 'strictEqual' } ... (from https://github.com/nodejs/node/runs/628144750?check_suite_focus=true) PR-URL: https://github.com/nodejs/node/pull/33150 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

push time in 8 days

push eventdnlup/node

Daniele Belardi

commit sha 336478c2c58e91472c39882b69121e43f7ddd656

http: use `autoDestroy: true` in incoming message Use the default `autoDestroy: true` option in IncomingMessage.

view details

push time in 8 days

startedfastify/fastify-kafka

started time in 13 days

push eventdnlup/node

Daniele Belardi

commit sha 6c5e38dbeb8843958b171d21a4a269c0c26710f4

http: use `autoDestroy: true` in incoming message Use the default `autoDestroy: true` option in IncomingMessage.

view details

push time in 13 days

startedprivate-octopus/picoquic

started time in 14 days

startedibmruntimes/yieldable-json

started time in 15 days

pull request commentfastify/fastify-cli

feat: pass custom plugin options from cli

I added all the files from the test folder.

dnlup

comment created time in 16 days

startedjasnell/notare

started time in 17 days

pull request commentnodejs/node

esm: better error message using commonjs hint

@targos could you post a link of the failing build? I am not sure I found the right one.

dnlup

comment created time in 19 days

push eventdnlup/fastify-cli

Daniele Belardi

commit sha 085c7ae3c32917a12d495e70dbbf203010c5a8da

feat: pass custom plugin options from cli Allow passing custom options for the app plugin using additional arguments from the cli. All the args passed after `--` will be parsed and passed to the plugin as options. Add test/*.test.js files to `unit` test script.

view details

push time in 19 days

issue commentlovell/sharp

Cache or memory leak

@rustam87 the Alpine image should have an allocator that return free RSS as @lovell suggested.

rustam87

comment created time in 20 days

pull request commentfastify/fastify-cli

feat: pass custom plugin options from cli

I was expecting tests to fail with my changes, but they didn't. Looking at the unit script it seems that test/start.test.js and test/args.test.js, which are the one that I was expecting to fail, are not included. I tested them manually, and I was wondering if it was the case to add them, but there's also must be a reason that I am missing for them not being there, I think.

dnlup

comment created time in 20 days

push eventdnlup/fastify-cli

Daniele Belardi

commit sha 498f76ac44dbfceb37e704ef26c803c81307671e

feat: pass custom plugin options from cli Allow passing custom options for the app plugin using additional arguments from the cli. All the args passed after `--` will be parsed and passed to the plugin as options.

view details

push time in 20 days

pull request commentfastify/fastify-cli

feat: pass custom plugin options from cli

args.js and start.js are not tested when running npm test. Should I add them?

dnlup

comment created time in 20 days

push eventdnlup/fastify-cli

Daniele Belardi

commit sha e827ab0609c3ed801c2af1678a1c45e505f49a8f

feat: pass custom plugin options from cli Allow passing custom options for the app plugin using additional arguments from the cli. All the args passed after `--` will be parsed and passed to the plugin as options.

view details

push time in 20 days

push eventdnlup/fastify-cli

Daniele Belardi

commit sha 9353f18b20c3bb099062d12da7722ac6cf5c03ce

feat: pass custom plugin options from cli Allow passing custom options for the app plugin using additional arguments from the cli. All the args passed after `--` will be parsed and passed to the plugin as options.

view details

push time in 21 days

push eventdnlup/fastify-cli

Daniele Belardi

commit sha f3585c3dda5fc1d59430b6dac3cb4da5a1e67770

feat: pass custom plugin options from cli Allow to pass custom options for the app plugin using additional arguments from the cli. All the args passed after `--` will be parsed and passed to the plugin as options.

view details

push time in 21 days

PR opened fastify/fastify-cli

feat: pass custom plugin options from cli

Allow to pass custom options for the app plugin using positional arguments from the cli.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Tip: npm run bench to compare branches interactively.

Contributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md -->

Checklist

  • [x] run npm run test and npm run benchmark
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message and code follows Code of conduct
+9 -3

0 comment

2 changed files

pr created time in 21 days

create barnchdnlup/fastify-cli

branch : feat/custom_plugin_options

created branch time in 21 days

fork dnlup/fastify-cli

Run a Fastify application with one command!

fork in 21 days

pull request commentnodejs/node

http: use `autoDestroy: true` in incoming message

Sorry if this is taking a long time, but I am trying to figure out what's wrong :pray:

Removing the override of destroy() resolves the EECONRESET errors, fewer tests are failing, but request is emitting close twice, and some connections seem to hang.

dnlup

comment created time in 21 days

push eventdnlup/node

Daniele Belardi

commit sha 28da8143bac5775c388f315f09b5e230a4b96179

http: use `autoDestroy: true` in incoming message Use the default `autoDestroy: true` option in IncomingMessage.

view details

push time in 23 days

delete branch dnlup/node

delete branch : esm/better_not_found_message

delete time in 24 days

pull request commentnodejs/node

esm: better error message using commonjs hint

Thank you all for your help!

dnlup

comment created time in 24 days

issue commentfastify/fastify-cli

Custom plugin options

@mcollina I will work on it then, thanks 🙂

dnlup

comment created time in 24 days

issue commentfastify/fastify-cli

Custom plugin options

The target is clear, I'm not pro to the module.exports.pluginOptions because it is app.js that loads -using env-schema or other logic- the value of this option and so it is not decoupled: the test must know how app.js implemented the loading logic to change the options. So it should be a different actor that exposes those parameters.

I understand your point, and I agree that it should be a different actor. I thought that exposing the options this way would have been more in line with how fastify options are exposed, and I was wrong. Just to be clear, though, I wasn't suggesting using pluginOptions in tests, but the opposite. I would have used custom objects without knowing how app.js implemented the loading part. Anyway, I agree with you.

For this reason, I'm pro to a powerful -- because the app.js receives the options without knowing how they are loaded at all.

I like this approach too.

(I say powerful because #208 simply decorate the process.argv and this could be optimized as you suggested, in order to be the input options )

Ok, so we can say that after #208 is merged, there is the groundwork for supporting this and that we would like to support it?

If the answer is yes, should I keep this issue open at this point, or should I open a new one?

Thank you again for the feedback.

dnlup

comment created time in 25 days

startedjasnell/piscina

started time in 25 days

issue commentfastify/fastify-cli

Custom plugin options

Thank you for the feedback and for taking the time to respond to this :pray:

I don't understand the benefit from the example above to this one

I think that the main benefit is that when writing tests, you decouple app.js and its config. You also might use a separate module for loading configuration when running your app, like env-schema. In this way, you can export its result value to let the cli inject it if needed, and if you need to require just the function for testing purposes, you can discard those options.

It would be different instead of this usage: # args after the double dash define the `options` input for the app.js fastify start app.js -- --active=true

That would be very useful indeed, is it supported? I honestly couldn't tell from the docs. I saw a PR open addressing this.

dnlup

comment created time in a month

pull request commentnodejs/node

http: use `autoDestroy: true` in incoming message

IncomingMessage overrides destroy() which kind of blocks any effort in this regards. That needs to IMO be fixed first.

Thanks, @ronag, for the suggestion. I'll look into it. There is an issue with destroy for sure. When using keep-alive, we don't want to destroy the socket, and that's what's happening by just setting the option to true.

dnlup

comment created time in a month

issue commentfastify/fastify-cli

Custom plugin options

Would module.exports.pluginOptions = {} be like options to create the Fastify instance, but injected via the cli?

Yes, exactly, and contains specific options for the user app/plugin.

who should be the reader of those options?

fastify-cli would read that object and pass it to the exported function, which in turn will consume it.

app.js

module.exports = function (fastify, options, next) {
  console.log(options)
  next()
}

module.exports.pluginOptions = { active: true }

Then fastify-cli pass the specified options object to the function

$ fastify start app.js
{ active: true }
...
dnlup

comment created time in a month

issue openedfastify/fastify-cli

Custom plugin options

<!-- Before you submit an issue we recommend you visit Fastify Help and ask any questions you have or mention any problems you've had getting started with Fastify.

Please read this entire template before posting any issue. If you ignore these instructions and post an issue here that does not follow the instructions, your issue might be closed, locked, and assigned the missing discussion label. -->

🚀 Feature Proposal

I think it could be useful to allow passing custom options to the plugin defined by the app.js. After reading the discussion at https://github.com/fastify/fastify-cli/issues/26 I would like to propose an alternative approach: exposing a pluginOptions property in app.js, the same way the custom options for Fastify are passed using the options property.

Motivation

In some cases, you might need to define custom options for the app.js and you might want to be able to pass them directly through the options object or let fastify-cli inject them.

Example

app.js

module.exports = function (fastify, options, next) {
  ...
  next()
})

module.exports.options = {} // Cusom Fastify options

module.exports.pluginOptions = {} //Custom plugins options injected by fastify-cli

created time in a month

startedsystemd/systemd

started time in a month

startedfastify/fastify-cli

started time in a month

issue openeddnlup/doc

Add active handles

Add process active handles. Since this uses an undocumented private API of the process, it should be optional, and the docs should report this.

created time in a month

push eventdnlup/node

himself65

commit sha d01a06a916efd30844e1e0a38e79dc0054fc4451

lib: simplify function process.emitWarning PR-URL: https://github.com/nodejs/node/pull/32992 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha a6c57cc66d0ecc6f566fa2622a0ae663180be62f

src: deprecate embedder APIs with replacements Implement a number of TODO comments aiming at the eventual removal of some embedder APIs that now have replacements available. PR-URL: https://github.com/nodejs/node/pull/32858 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Anna Henningsen

commit sha ac3714637e81f65f615c7ebb5e4c0be53ea0dfd0

src: remove unused CancelPendingDelayedTasks PR-URL: https://github.com/nodejs/node/pull/32859 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Adrian Estrada

commit sha cea853cb02f909301d40177e10ed614f26ad5af0

test: refactor events tests for invalid listeners PR-URL: https://github.com/nodejs/node/pull/32769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Eileen

commit sha ff622a2b2bada0b908d63a39bc5e6915977917d2

doc: updated directory entry information Fixes: https://github.com/nodejs/node/issues/25595 subdirectory updated def PR-URL: https://github.com/nodejs/node/pull/32791 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Adrian Estrada

commit sha cd4052c9df0dbb10354f3e3638d9a9a61c2532c6

test: better error validations for event-capture PR-URL: https://github.com/nodejs/node/pull/32771 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Robert Nagy

commit sha 802edb1d6a4c752c27e040a3a24859e631435110

stream: consistent punctuation Cleanup comments to use consistent punctuation. PR-URL: https://github.com/nodejs/node/pull/32934 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Daniel Bevenius

commit sha 654c0ace7b44da722b313bae2e7cb0ae6a9341a4

src: fix compiler warnings in node_http2.cc Currently, the following compiler warnings are generated: ../src/node_http2.cc: In static member function ‘static int node::http2::Http2Session::OnStreamClose(nghttp2_session*, int32_t, uint32_t, void*)’: ../src/node_http2.cc:994:16: warning: variable ‘def’ set but not used [-Wunused-but-set-variable] 994 | Local<Value> def = v8::False(env->isolate()); | ^~~ ../src/node_http2.cc: In static member function ‘static void node::http2::Http2Session::Ping( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_http2.cc:2755:16: warning: unused variable ‘env’ [-Wunused-variable] 2755 | Environment* env = Environment::GetCurrent(args); | ^~~ ../src/node_http2.cc: In static member function ‘static void node::http2::Http2Session::Settings( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_http2.cc:2774:16: warning: unused variable ‘env’ [-Wunused-variable] 2774 | Environment* env = Environment::GetCurrent(args); | ^~~ This commit removes these unused variables. PR-URL: https://github.com/nodejs/node/pull/33014 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Juan José Arboleda

commit sha 1b2988a5da964f23c7de2fb6508791f81948d2da

src: delete MicroTaskPolicy namespace PR-URL: https://github.com/nodejs/node/pull/32853 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Yash Ladha

commit sha 0d7638e2cccd4fc6e0fda99c15b66c5491c4b393

lib: unnecessary const assignment for class PR-URL: https://github.com/nodejs/node/pull/32962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Joyee Cheung

commit sha c61b388c29dc73ef3c94aef0f790e012683d24ef

inspector: only write coverage in fully bootstrapped Environments The NODE_V8_COVERAGE folder and the source map computation are setup during pre-execution since they rely on environment variables as well as JS states. Therefore, we need to give up serialization of JS coverage profiles for Environments that have not go through pre-execution. Currently this is only possible for Environments created using the embedder API CreateEnvironment(). As a result we won't have JS coverage data for most cctests, but if that proves to be necessary we could just run lib/internal/main/environment.js for these Environments created for cctests. Fixes: https://github.com/nodejs/node/issues/32912 Refs: https://github.com/nodejs/node/commit/65e18a8e9f912dfa04a804124b6a19514bb45165 Refs: https://github.com/nodejs/node/commit/5bf43729a403b992cc90b5cdbbaaf505769d1107 https://github.com/nodejs/node/commit/8aa7ef7840ef5f7161f3195e51a3fa6783290160 PR-URL: https://github.com/nodejs/node/pull/32960 Refs: https://github.com/nodejs/node/commit/8aa7ef7840ef5f7161f3195e51a3fa6783290160 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Jesus Hernandez

commit sha 24a4e6153dae01cc7d5b28a21a105d680e9a5037

stream: removes unnecessary params Removes the state param in the onFinished function since it's never used within it. PR-URL: https://github.com/nodejs/node/pull/32936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Gus Caplan

commit sha 74c393dd93cc0e461e3796fbcc09545fcacdecaf

vm: add importModuleDynamically option to compileFunction Fixes: https://github.com/nodejs/node/issues/31860 PR-URL: https://github.com/nodejs/node/pull/32985 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Yash Ladha

commit sha 658cae06846877a16308b100931c7c8d6f1ed27c

src: assignment to valid type We are converting the argument to a uint32_t value but the lvalue is not consistent with the casting. PR-URL: https://github.com/nodejs/node/pull/32879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Robert Nagy

commit sha 003fb53c9a38520e84bd18beb7719f1a47af8c43

stream: avoid drain for sync streams Previously a sync writable receiving chunks larger than highwatermark would unecessarily ping pong needDrain. PR-URL: https://github.com/nodejs/node/pull/32887 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha ab7d9db36cbf5510272ffe4b8e37c8da8e915067

stream: fix sync write perf regression While https://github.com/nodejs/node/pull/31046 did make async writes faster it at the same time made sync writes slower. This PR corrects this while maintaining performance improvements. PR-URL: https://github.com/nodejs/node/pull/33032 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Jeremiah Senkpiel

commit sha f8d5474839707bb4dbb57e10c48ef592f4dba892

test: remove timers-blocking-callback If the bug this test is intented to catch is reintroduced, or if 5aac4c42da104c30d8f701f1042d61c2f06b7e6c is effectively reverted, many (50+) tests time out, rendering this test redundant and unnecessary. in particular, the following timer tests catch an effective revert of 5aac4c42da104c30d8f701f1042d61c2f06b7e6c: not ok 21 parallel/test-timers-api-refs not ok 22 parallel/test-timers-args not ok 23 parallel/test-timers-destroyed not ok 25 parallel/test-timers-nested not ok 26 parallel/test-timers-interval-throw not ok 28 parallel/test-timers-non-integer-delay not ok 32 parallel/test-timers-ordering not ok 33 parallel/test-timers-refresh not ok 34 parallel/test-timers-refresh-in-callback not ok 35 parallel/test-timers-reset-process-domain-on-throw not ok 40 parallel/test-timers-timeout-to-interval not ok 41 parallel/test-timers-uncaught-exception not ok 42 parallel/test-timers-timeout-with-non-integer not ok 43 parallel/test-timers-unenroll-unref-interval not ok 44 parallel/test-timers-unref not ok 45 parallel/test-timers-unref-active not ok 46 parallel/test-timers-unrefd-interval-still-fires not ok 47 parallel/test-timers-unrefed-in-callback not ok 48 parallel/test-timers-user-call not ok 49 parallel/test-timers-zero-timeout Refs: https://github.com/nodejs/node/issues/21781 PR-URL: https://github.com/nodejs/node/pull/32870 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ishaan Jain

commit sha 53b8133656132b1f899fbf3b8ae6c0c82ae5296b

doc: avoid tautology in README Changed "UTC time" on Line 82 to "UTC" as it created a tautology. PR-URL: https://github.com/nodejs/node/pull/33005 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

Robert Nagy

commit sha 5ee1e31e38c9b7d79f119b0a6d6ae857df33462c

http: doc deprecate abort and improve docs Doc deprecates ClientRequest.abort in favor of ClientRequest.destroy. Also improves event order documentation for abort and destroy. Refs: https://github.com/nodejs/node/issues/32225 PR-URL: https://github.com/nodejs/node/pull/32807 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 36993c05667bbfda66d84329278b82887771cc94

buffer,n-api: fix double ArrayBuffer::Detach() during cleanup These calls could fail if the `ArrayBuffer` had already been explicitly detached at some point in the past. The necessary test changes already came with 4f523c2c1a1c and could be ported back to v12.x with a backport of this PR. Fixes: https://github.com/nodejs/node/issues/33022 Refs: https://github.com/nodejs/node/pull/30551 PR-URL: https://github.com/nodejs/node/pull/33039 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

push time in a month

push eventdnlup/node

himself65

commit sha d01a06a916efd30844e1e0a38e79dc0054fc4451

lib: simplify function process.emitWarning PR-URL: https://github.com/nodejs/node/pull/32992 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha a6c57cc66d0ecc6f566fa2622a0ae663180be62f

src: deprecate embedder APIs with replacements Implement a number of TODO comments aiming at the eventual removal of some embedder APIs that now have replacements available. PR-URL: https://github.com/nodejs/node/pull/32858 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Anna Henningsen

commit sha ac3714637e81f65f615c7ebb5e4c0be53ea0dfd0

src: remove unused CancelPendingDelayedTasks PR-URL: https://github.com/nodejs/node/pull/32859 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Adrian Estrada

commit sha cea853cb02f909301d40177e10ed614f26ad5af0

test: refactor events tests for invalid listeners PR-URL: https://github.com/nodejs/node/pull/32769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Eileen

commit sha ff622a2b2bada0b908d63a39bc5e6915977917d2

doc: updated directory entry information Fixes: https://github.com/nodejs/node/issues/25595 subdirectory updated def PR-URL: https://github.com/nodejs/node/pull/32791 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Adrian Estrada

commit sha cd4052c9df0dbb10354f3e3638d9a9a61c2532c6

test: better error validations for event-capture PR-URL: https://github.com/nodejs/node/pull/32771 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

Robert Nagy

commit sha 802edb1d6a4c752c27e040a3a24859e631435110

stream: consistent punctuation Cleanup comments to use consistent punctuation. PR-URL: https://github.com/nodejs/node/pull/32934 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Daniel Bevenius

commit sha 654c0ace7b44da722b313bae2e7cb0ae6a9341a4

src: fix compiler warnings in node_http2.cc Currently, the following compiler warnings are generated: ../src/node_http2.cc: In static member function ‘static int node::http2::Http2Session::OnStreamClose(nghttp2_session*, int32_t, uint32_t, void*)’: ../src/node_http2.cc:994:16: warning: variable ‘def’ set but not used [-Wunused-but-set-variable] 994 | Local<Value> def = v8::False(env->isolate()); | ^~~ ../src/node_http2.cc: In static member function ‘static void node::http2::Http2Session::Ping( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_http2.cc:2755:16: warning: unused variable ‘env’ [-Wunused-variable] 2755 | Environment* env = Environment::GetCurrent(args); | ^~~ ../src/node_http2.cc: In static member function ‘static void node::http2::Http2Session::Settings( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_http2.cc:2774:16: warning: unused variable ‘env’ [-Wunused-variable] 2774 | Environment* env = Environment::GetCurrent(args); | ^~~ This commit removes these unused variables. PR-URL: https://github.com/nodejs/node/pull/33014 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Juan José Arboleda

commit sha 1b2988a5da964f23c7de2fb6508791f81948d2da

src: delete MicroTaskPolicy namespace PR-URL: https://github.com/nodejs/node/pull/32853 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Yash Ladha

commit sha 0d7638e2cccd4fc6e0fda99c15b66c5491c4b393

lib: unnecessary const assignment for class PR-URL: https://github.com/nodejs/node/pull/32962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Joyee Cheung

commit sha c61b388c29dc73ef3c94aef0f790e012683d24ef

inspector: only write coverage in fully bootstrapped Environments The NODE_V8_COVERAGE folder and the source map computation are setup during pre-execution since they rely on environment variables as well as JS states. Therefore, we need to give up serialization of JS coverage profiles for Environments that have not go through pre-execution. Currently this is only possible for Environments created using the embedder API CreateEnvironment(). As a result we won't have JS coverage data for most cctests, but if that proves to be necessary we could just run lib/internal/main/environment.js for these Environments created for cctests. Fixes: https://github.com/nodejs/node/issues/32912 Refs: https://github.com/nodejs/node/commit/65e18a8e9f912dfa04a804124b6a19514bb45165 Refs: https://github.com/nodejs/node/commit/5bf43729a403b992cc90b5cdbbaaf505769d1107 https://github.com/nodejs/node/commit/8aa7ef7840ef5f7161f3195e51a3fa6783290160 PR-URL: https://github.com/nodejs/node/pull/32960 Refs: https://github.com/nodejs/node/commit/8aa7ef7840ef5f7161f3195e51a3fa6783290160 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Jesus Hernandez

commit sha 24a4e6153dae01cc7d5b28a21a105d680e9a5037

stream: removes unnecessary params Removes the state param in the onFinished function since it's never used within it. PR-URL: https://github.com/nodejs/node/pull/32936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Gus Caplan

commit sha 74c393dd93cc0e461e3796fbcc09545fcacdecaf

vm: add importModuleDynamically option to compileFunction Fixes: https://github.com/nodejs/node/issues/31860 PR-URL: https://github.com/nodejs/node/pull/32985 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Yash Ladha

commit sha 658cae06846877a16308b100931c7c8d6f1ed27c

src: assignment to valid type We are converting the argument to a uint32_t value but the lvalue is not consistent with the casting. PR-URL: https://github.com/nodejs/node/pull/32879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Robert Nagy

commit sha 003fb53c9a38520e84bd18beb7719f1a47af8c43

stream: avoid drain for sync streams Previously a sync writable receiving chunks larger than highwatermark would unecessarily ping pong needDrain. PR-URL: https://github.com/nodejs/node/pull/32887 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha ab7d9db36cbf5510272ffe4b8e37c8da8e915067

stream: fix sync write perf regression While https://github.com/nodejs/node/pull/31046 did make async writes faster it at the same time made sync writes slower. This PR corrects this while maintaining performance improvements. PR-URL: https://github.com/nodejs/node/pull/33032 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Jeremiah Senkpiel

commit sha f8d5474839707bb4dbb57e10c48ef592f4dba892

test: remove timers-blocking-callback If the bug this test is intented to catch is reintroduced, or if 5aac4c42da104c30d8f701f1042d61c2f06b7e6c is effectively reverted, many (50+) tests time out, rendering this test redundant and unnecessary. in particular, the following timer tests catch an effective revert of 5aac4c42da104c30d8f701f1042d61c2f06b7e6c: not ok 21 parallel/test-timers-api-refs not ok 22 parallel/test-timers-args not ok 23 parallel/test-timers-destroyed not ok 25 parallel/test-timers-nested not ok 26 parallel/test-timers-interval-throw not ok 28 parallel/test-timers-non-integer-delay not ok 32 parallel/test-timers-ordering not ok 33 parallel/test-timers-refresh not ok 34 parallel/test-timers-refresh-in-callback not ok 35 parallel/test-timers-reset-process-domain-on-throw not ok 40 parallel/test-timers-timeout-to-interval not ok 41 parallel/test-timers-uncaught-exception not ok 42 parallel/test-timers-timeout-with-non-integer not ok 43 parallel/test-timers-unenroll-unref-interval not ok 44 parallel/test-timers-unref not ok 45 parallel/test-timers-unref-active not ok 46 parallel/test-timers-unrefd-interval-still-fires not ok 47 parallel/test-timers-unrefed-in-callback not ok 48 parallel/test-timers-user-call not ok 49 parallel/test-timers-zero-timeout Refs: https://github.com/nodejs/node/issues/21781 PR-URL: https://github.com/nodejs/node/pull/32870 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ishaan Jain

commit sha 53b8133656132b1f899fbf3b8ae6c0c82ae5296b

doc: avoid tautology in README Changed "UTC time" on Line 82 to "UTC" as it created a tautology. PR-URL: https://github.com/nodejs/node/pull/33005 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

Robert Nagy

commit sha 5ee1e31e38c9b7d79f119b0a6d6ae857df33462c

http: doc deprecate abort and improve docs Doc deprecates ClientRequest.abort in favor of ClientRequest.destroy. Also improves event order documentation for abort and destroy. Refs: https://github.com/nodejs/node/issues/32225 PR-URL: https://github.com/nodejs/node/pull/32807 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 36993c05667bbfda66d84329278b82887771cc94

buffer,n-api: fix double ArrayBuffer::Detach() during cleanup These calls could fail if the `ArrayBuffer` had already been explicitly detached at some point in the past. The necessary test changes already came with 4f523c2c1a1c and could be ported back to v12.x with a backport of this PR. Fixes: https://github.com/nodejs/node/issues/33022 Refs: https://github.com/nodejs/node/pull/30551 PR-URL: https://github.com/nodejs/node/pull/33039 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

view details

push time in a month

issue commentlovell/sharp

Multi Page pdf conversion

@brecke Last thing, you might find this useful

dnlup

comment created time in a month

delete branch dnlup/fastify

delete branch : 2.x

delete time in a month

more