profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/dmarcoux/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Dany Marcoux dmarcoux @SUSE Full Stack Web Developer - Open Build Service @openSUSE

dmarcoux-archives/dotfiles-arch_linux 4

My Arch Linux config files

dmarcoux/dotfiles-nixos 2

My NixOS config files

dmarcoux/ruby_templates 2

Templates for common files/configs I use in Ruby projects

dmarcoux-archives/dotfiles-openSUSE 1

My OpenSUSE config files

dmarcoux-archives/haskell-programming-from-first-principles 1

Going through the book "Haskell Programming from First Principles"

dmarcoux/ansible-obs 0

Some playbooks to operate OBS

dmarcoux/aws_templates 0

Amazon Web Services templates I use in various projects

dmarcoux/cloud-configs 0

Cloud-config files to initialize servers with cloud-init

dmarcoux/obs-deployment-tool 0

OBS deployment tool

PullRequestReviewEvent

create barnchdmarcoux/open-build-service

branch : add-.obs-to-test-suite-ci-label

created branch time in 10 minutes

push eventdmarcoux/open-build-service

Henne Vogelsang

commit sha 1a9d85ed38e38981497ea6f8b3aab419afabc8a3

Consistently use User.get_default_admin

view details

Henne Vogelsang

commit sha 45299cf7fd171f125c87bf3c4050d823a1460dc5

Merge pull request #11471 from hennevogel/bugfix/default-admin Consistently use User.get_default_admin

view details

push time in an hour

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentopenSUSE/open-build-service

Unify containers images used by CI and development environment

     end      scenario 'Add non existent group' do+      skip_on_mobile

Done!

eduardoj

comment created time in an hour

PullRequestReviewEvent

push eventeduardoj/open-build-service

Eduardo Navarro

commit sha cc0710715c76063a08be58f50287f0bd28731f4a

After upgrading Chromium, fix specs on mobile ... ... by scrolling to the link. Upgrading Chromium fixed a false positive in feature package tests, when adding a user or adding a group, making the tests fail. The bad behavior was that clicking the links 'Add User' or 'Add Group' was possible, even if the link was outside the visual area. Scroll to those links in these failing tests in mobile. This makes feature tests to pass again. Co-authored-by: Dany Marcoux <dmarcoux@suse.com>

view details

push time in an hour

push eventdmarcoux/open-build-service

Dany Marcoux

commit sha 0a30d7ab5459e058c3f8e5bdc845bc21371641dd

Add GitHub workflow to apply labels to PRs I totally forgot this part in #11461. That PR configured the pull request labeler, but it didn't run since there was no GitHub workflow... Oopsie!

view details

Henne Vogelsang

commit sha 472633d4538f13861eddb3a8ffb21f1fbf30adec

Merge pull request #11472 from dmarcoux/add-missing-github-workflow-to-apply-labels-to-PRs Add GitHub workflow to apply labels to PRs

view details

push time in an hour

delete branch dmarcoux/open-build-service

delete branch : add-missing-github-workflow-to-apply-labels-to-PRs

delete time in an hour

PullRequestReviewEvent

Pull request review commentopenSUSE/open-build-service

Consistently use User.get_default_admin

     # For feature test we use deletion instead of transactions because the     # test suite and the capybara driver do not use the same server thread.     DatabaseCleaner.strategy = if example.metadata[:type] == :feature || example.metadata[:type] == :migration || example.metadata[:thinking_sphinx] == true-                                 # Omit truncating what we have set up in db/seeds.rb except users and roles_user

This comment wasn't true or it changed? I don't see how this changed.

hennevogel

comment created time in an hour

Pull request review commentopenSUSE/open-build-service

Add GitHub workflow to apply labels to PRs

+name: "Pull Request Labeler"+on:+- pull_request_target++jobs:+  pull_request_labeler:+    runs-on: ubuntu-latest+    steps:+    - uses: actions/labeler@v3+      with:+        repo-token: "${{ secrets.GITHUB_TOKEN }}"

Wait, this should work!

If this workflow ran on pull_request instead of pull_request_target, then it wouldn't work. With pull_request_target though, it works since it's executing this workflow in the context of the PR target, so openSUSE/open-build-service. See the following quote from this GitHub blog post:

Emphasis is mine...

(...) we’ve added a new pull_request_target event, which behaves in an almost identical way to the pull_request event with the same set of filters and payload. However, instead of running against the workflow and code from the merge commit, the event runs against the workflow and code from the base of the pull request. This means the workflow is (...) given access to a read/write token as well as secrets enabling the maintainer to (...) label a pull request. (...)

dmarcoux

comment created time in 2 hours

PullRequestReviewEvent

Pull request review commentopenSUSE/open-build-service

Add GitHub workflow to apply labels to PRs

+name: "Pull Request Labeler"+on:+- pull_request_target++jobs:+  pull_request_labeler:+    runs-on: ubuntu-latest+    steps:+    - uses: actions/labeler@v3+      with:+        repo-token: "${{ secrets.GITHUB_TOKEN }}"

I tested this and it worked, but I didn't test with PRs coming from a fork. You're right :disappointed:, see the official docs for GITHUB_TOKEN.

dmarcoux

comment created time in 2 hours

PullRequestReviewEvent

Pull request review commentopenSUSE/open-build-service

Unify containers images used by CI and development environment

     end      scenario 'Add non existent group' do+      skip_on_mobile

This part of the commit message isn't true anymore: Or skip the test in mobile. It should be removed.

eduardoj

comment created time in 2 hours

PullRequestReviewEvent

PR opened openSUSE/open-build-service

Add GitHub workflow to apply labels to PRs

I totally forgot this part in #11461. That PR configured the pull request labeler, but it didn't run since there was no GitHub workflow... Oopsie!

+11 -0

0 comment

1 changed file

pr created time in 2 hours

push eventdmarcoux/open-build-service

depfu[bot]

commit sha 6ffca981cced9999a35c4f900cb5baa8a3c976eb

Update ruby_parser to version 3.17.0

view details

Dany Marcoux

commit sha a0b22fea1cb2965719b0a948857a1fc59a3d51dc

Merge pull request #11467 from openSUSE/depfu/update/srcapi/ruby_parser-3.17.0 [src/api] Update ruby_parser: 3.16.0 → 3.17.0 (minor)

view details

push time in 2 hours

Pull request review commentopenSUSE/open-build-service

Unify containers images used by CI and development environment

     end      scenario 'Add non existent group' do+      skip_on_mobile

We can do the same here as in the examples with Add User, just switching Add User to Add Group and it should work.

eduardoj

comment created time in 2 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentopenSUSE/open-build-service

Unify containers images used by CI and development environment

     end      scenario 'Add non existent user' do+      skip_on_mobile

I found a solution for this, scrolling to the element will work. See the commit I pushed.

eduardoj

comment created time in 3 hours

PullRequestReviewEvent

push eventeduardoj/open-build-service

Dany Marcoux

commit sha 2baf952f2c89bde6cf1ccb6449be1c4a169ae0a9

SQUASH ME - Fix specs on mobile by scrolling to the link

view details

push time in 3 hours

pull request commentopenSUSE/obs_rails_template

Create contribution guide

Nice work @danidoni! I've made a few suggestions to address some small issues, but it's already good!

danidoni

comment created time in 3 hours

Pull request review commentopenSUSE/obs_rails_template

Create contribution guide

+# How Can I Contribute?++You can contribute to the project basically by fixing bugs or by suggesting enhancements.++## Reporting bugs++This section guides you through submitting a bug report for ObsRailsTemplate. Following these guidelines helps maintainers and the community understand your report, reproduce the behaviour, and find related reports.++Before creating bug reports, please:+- **Check the [issues page](https://github.com/openSUSE/obs_rails_template/issues)** as you may find that you don't need to create one. If you find the issue already reported **and it is still open**, add a comment to the existing issue instead of opening a new one.+- **Check the [mailing list](https://link-to-your-repositors-mailing-list)** to see if there is already a discussion going on.++To create a bug report, fill out the [required template](https://github.com/openSUSE/obs_rails_template/issues/new?assignees=&labels=&template=Bug_report.md), the information it asks for helps us resolve issues faster.++## Suggesting Enhancements++This section guides you through submitting an enhancement suggestion for ObsRailsTemplate, including completely new features and minor improvements to existing functionality. Following these guidelines helps maintainers and the community understand your suggestion and find related suggestions.++Before creating enhancement suggestions, please check if there's already [an issue](https://github.com/openSUSE/obs_rails_templates/issues) which provides that enhancement.++When you are creating an enhancement suggestion, please [include as many details as possible](https://github.com/openSUSE/obs_rails_template/blob/main/CONTRIBUTING.md#how-do-i-submit-a-good-enhancement-suggestion). Fill in [the template](https://github.com/openSUSE/obs_rails_template/issues/new?assignees=&labels=&template=feature_request.md), including the steps that you imagine you would take if the feature you're requesting existed.++## How Do I Submit A (Good) Enhancement Suggestion?++Enhancement suggestions are tracked as [GitHub issues](https://guides.github.com/features/issues/) in our [issues page](https://github.com/openSUSE/obs_rails_template/issues). Create an issue on that repository and provide the following information:++-   **Use a clear and descriptive title** for the issue to identify the suggestion.+-   **Provide a step-by-step description of the suggested enhancement** in as many details as possible.+-   **Provide specific examples to demonstrate the steps**. Include copy/pasteable snippets which you use in those examples, as [Markdown code blocks](https://help.github.com/articles/markdown-basics/#multiple-lines).+-   **Describe the current behavior** and **explain which behavior you expected to see instead** and why.+-   **Include screenshots and animated GIFs** which help you demonstrate the steps or point out the part which the suggestion is related to.++## Your First Code Contribution++Unsure where to begin contributing to ObsRailsTemplate? You can start by looking through these `beginner` and `help-wanted` issues:++- [Beginner issues](https://github.com/openSUSE/obs_rails_template/issues?q=is%3Aopen+label%3A%22good+first+issue%22+sort%3Acomments-desc) - issues which should only require a few lines of code, and a test or two.+- [Help wanted issues](https://github.com/openSUSE/obs_rails_template/issues?q=is%3Aopen+label%3A%22help+wanted+sort%3Acomments-desc) - issues which should be a bit more involved than `beginner` issues.++Both issue lists are sorted by total number of comments. While not perfect, number of comments is a reasonable proxy for impact a given change will have.++## Styleguides++Below are some style guides that may be useful in order to ensure your contribution to the project is accepted:++- [Example Git Commit Message styleguides](https://github.com/openSUSE/open-build-service/wiki/Commit-Style)+- [Example Programming Language styleguides](https://rubystyle.guide/)+- [Example Documentation styleguides](https://docs.gitlab.com/ee/development/documentation/styleguide/)++## Talk with us
## Talk with Us
danidoni

comment created time in 3 hours