profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/diederich/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

diederich/AFNetworking 3

A delightful iOS and OS X networking framework

diederich/git-achievements 3

Aquire achievements while using git.

diederich/InAppSettingsKit 3

This iPhone framework allows settings to be in-app in addition to being in the Settings app

diederich/moneymoney-monzo 2

Extension for MoneyMoney.app to query data from Monzo UK

diederich/QuincyKit 2

Live crash report management for iOS and Mac OS X. AppStore ready! Follow news on Twitter via @hockeyapp

diederich/Charter 1

Client libraries for the Charter App (available on the Mac App Store)

diederich/DCIntrospect 1

Small library of visual debugging tools for iOS.

diederich/MacounADNWall 1

Demo project for Macoun talk about Cocoapods

create barnchthebrowsercompany/PathKit

branch : feature/fix-build-Xcode-13-RC

created branch time in 5 days

delete branch thebrowsercompany/PathKit

delete branch : feature/fix-build-Xcode-13-RC

delete time in 5 days

pull request commentkylef/PathKit

fix build on Xcode 13 RC

#80 LGTM! Thanks @chrisballinger :pray: Closing this..

diederich

comment created time in 5 days

PR closed kylef/PathKit

fix build on Xcode 13 RC

This fixes the build of PathKit on Xcode 13 RC.

strdup returns an implicitly unwrapped optional, which seems to loose its "implicit" via the assignment. I couldn't find anything in the Xcode release notes, but I guess it's a fair change :-) Let's treat the returned pointers as true optionals and instead of crashing, return defaults.

+2 -3

7 comments

1 changed file

diederich

pr closed time in 5 days

pull request commentkylef/PathKit

fix build on Xcode 13 RC

#80 LGTM! Thanks @chrisballinger :pray: Closing this..

diederich

comment created time in 5 days

release futuretap/InAppSettingsKit

3.3.5

released time in 6 days

push eventthebrowsercompany/swift-composable-architecture

Stephen Celis

commit sha a554b00ff46a4903b31230ff0a095f3fd122022f

Remove old deprecations (#795) * Remove old deprecations * wip

view details

Stephen Celis

commit sha d715300cd4156dbc002df96fddaf5e6110b85bcc

Thread messaging (#803) * Use thread dictionary for check instead * Improve thread check messaging for Store.scope * typo fix Co-authored-by: Brandon Williams <mbrandonw@hey.com>

view details

iampatbrown

commit sha 64997d85f3a85e2f5c5c941afdab3db11c5b90a5

Clean up `Store.ifLet` (#754) * Clean up Store.ifLet * changed nil coalescing * use .scope for publisherScope * Revert "use .scope for publisherScope" This reverts commit 74dc57bc06cf30ddace2b74a94fb4ea4816b0ccd. * fixed localState coalescing * put extract logic inside scope * Revert "put extract logic inside scope" This reverts commit 3862c5b0f238e15346ae46ac22268bc46dee84e2. * Revert "fixed localState coalescing" This reverts commit 0f9f27ce3c9daa513db33c181b84f9e4a27c6d51.

view details

stephencelis

commit sha c5f2089100e38df3fe6a85e80ca1a357a69258b9

Run swift-format

view details

Stephen Celis

commit sha c0c95c5bab58a83f46cba567054e3e610b3f1b9e

Deprecate dynamic member lookup on view stores in favor of ViewStore.binding (#810) * wip * wip

view details

Stephen Celis

commit sha 4bdcaafcd0d4c34b7438ec02f28988b468c4f870

Deprecate Store.publisherScope (#758) * Deprecate Store.publisherScope * wip * fix * wip

view details

stephencelis

commit sha e80da5cb0f728967f4a579df53818daf622323bb

Run swift-format

view details

Brandon Williams

commit sha caa10bc74d260e3d017eab61030cea3ff46c6065

Clean up speech recognition case study. (#812) * Clean up speech recognition case study. * fix tests * clean up;

view details

iampatbrown

commit sha 4b8db86edb7033b4ef1731e24eac81d2feb3302f

Alternative to `CurrentValueSubject` in `ViewStore` (#755) * Replaced CurrentValueSubject with CurrentValueRelay * Added final to DemandBuffer Co-authored-by: Brandon Williams <mbrandonw@hey.com>

view details

stephencelis

commit sha 71421c6e3935dc57300620c553fbbe186ce96755

Run swift-format

view details

Stephen Celis

commit sha 8260a1ab8de358fdfbb74694707dd6ab2196f025

Fix bindable deprecations (#815) * Fix Bindable Deprecations * More CI * wip * wip * wip * wip

view details

mbrandonw

commit sha bb5da6a0a4db7dd59c317ba4ca3533c7f0447565

Run swift-format

view details

iampatbrown

commit sha 46d0ca40fba4eed302e0499cea0d4c281326aaf1

ObservedViewStore for projectedBindings (#770) * Added observedSelf property to ViewStore * Created ObservedViewStore * Try projectedBinding first for ViewStore bindings * Replaced @ObservedObject with @ObservedViewStore * Revert "Replaced @ObservedObject with @ObservedViewStore" This reverts commit 6aadf373db58a2320c582741a76794ac3d6bfc43. * Revert "Try projectedBinding first for ViewStore bindings" This reverts commit 0e2fae1cbf53e84194a6fb3a5eb077021110c395. * Revert "Created ObservedViewStore" This reverts commit 7f99a718b96d186324627ef6d016a882e83e9f8e. * Revert "Added observedSelf property to ViewStore" This reverts commit 65dc3837b37d8251c2d1e2916c94894b8eb93db0. * Replaced self.binding with projectedValue * Revert "Replaced self.binding with projectedValue" This reverts commit cc2b69777e63a8b8cee40df5d5db9557302177cd. * Derive bindings using WrappedState helper * wip * wip * wip * avoid potential retain cycle * Revert "Derive bindings using WrappedState helper" This reverts commit f3fb18f4458f47d28905e8b346c767fbd05b7f99. Co-authored-by: Stephen Celis <stephen@stephencelis.com>

view details

Stephen Celis

commit sha 0cd0c3eccea97111154827bb59c5d6f34e3fa6f4

Update AlertState to use new APIs (#794) * Update AlertState to use new APIs * fix * Feedback * wip * Fix * wip * wip * wip * wip

view details

stephencelis

commit sha f92c2aec7824b1c33667e9cfd72a7d37f240d418

Run swift-format

view details

Brandon Williams

commit sha 1c0dfbc98bd3a5529c204ea5866ef3d781ef4f3c

Perform thread check only when store is created on main queue. (#811) * Perform thread check only when store is created on main thread. * clean up * Update Sources/ComposableArchitecture/Store.swift * clean up * Update Sources/ComposableArchitecture/Store.swift * clean up * execute setSpecific only once. * logic fix * added a test * typo * wip * docs * fix test * Update Sources/ComposableArchitecture/Store.swift Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com> * Run swift-format * Clean up speech recognition case study. (#812) * Clean up speech recognition case study. * fix tests * clean up; * Alternative to `CurrentValueSubject` in `ViewStore` (#755) * Replaced CurrentValueSubject with CurrentValueRelay * Added final to DemandBuffer Co-authored-by: Brandon Williams <mbrandonw@hey.com> * Run swift-format * Fix bindable deprecations (#815) * Fix Bindable Deprecations * More CI * wip * wip * wip * wip * Run swift-format * beef up test * expectation * fix Co-authored-by: Stephen Celis <stephen@stephencelis.com> Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com> Co-authored-by: stephencelis <stephencelis@users.noreply.github.com> Co-authored-by: iampatbrown <mrpatbrown@gmail.com> Co-authored-by: mbrandonw <mbrandonw@users.noreply.github.com>

view details

mbrandonw

commit sha 0a39f4c7a33eb71baef936fb5d6e249c49961eb8

Run swift-format

view details

Stephan Diederich

commit sha 258efc5adb9f3f498cb8a71ff957212bf9961a71

Merge remote-tracking branch 'upstream/main' into develop

view details

push time in 6 days

push eventfuturetap/InAppSettingsKit

Stephan Diederich

commit sha e4cc96b35a1970e85eff8cb291030d7d4031e816

flip order of "how to include" - make SPM the first, and thus default

view details

push time in 6 days

PR closed futuretap/InAppSettingsKit

Changes to structure to better support SPM when used with Tuist

Using the current version (3.3.3) of InAppSettingsKit with Xcode's Swift Package Manager integration, things work as expected. I ran into issues when trying to use it via Tuist's SPM integration though, stemming from the way the Objective-C headers were being included into the package.

Primarily what I've done is just move files around into the default locations that SPM expects for Objective-C libraries (and then some small changes to support the file moves in the included Xcode projects and .podspec). All code goes in Sources/InAppSettingsKit/, and Objective-C headers go in Sources/InAppSettingsKit/include/. Doing it this way removes the need for the InAppSettingsKit.h header file, and allows for simplifying the Package.swift file by removing the need for custom target settings.

I understand this is somewhat of an edge case, but I believe the change is not breaking, and conforming to Apple's defaults is generally easier in the long run anyway.

Note: I am not using this library via CocoaPods, so I cannot test that. pod spec lint does succeed though, so conceivably that means the changes will work fine.

Any thoughts on this change?

+195 -214

3 comments

76 changed files

hisaac

pr closed time in 6 days

pull request commentfuturetap/InAppSettingsKit

Changes to structure to better support SPM when used with Tuist

Thanks @hisaac !

Good question on the Resources bit. Since I moved them to the default path that SPM expects — Sources/<package name>/Resources/ — you don't need to define them manually in the Package.swift file.

Close! :-) It's the defaultLocalization that makes it work: https://developer.apple.com/documentation/swift_packages/localizing_package_resources Once that's part of the Package.swift file, SPM expects the localized resource directories in the Resources/*.lproj folders.

As for dropping Carthage, I personally would continue to support it if it isn't too much work. It's definitely falling out of fashion, but I think there are still a fair amount of people using it. Obviously up to y'all though!

Fair :-) We've kept it for now, but the sample app's not using the xcodeproj anymore, but is now also based on SPM. I've also moved the Tests over to the default location.

I've kept your commits as-is, and pushed one more on top: #462

hisaac

comment created time in 6 days

PR opened futuretap/InAppSettingsKit

Reviewers
Changes to structure to better support SPM when used with Tuist

This includes #460 +

  • also move tests to SPM default location
  • make sample app based on SPM package (vs. the xcodeproject) & cleanup bridging setup
  • modernize imports
  • verify Carthage is still working via the test script
+188 -309

0 comment

99 changed files

pr created time in 6 days

create barnchfuturetap/InAppSettingsKit

branch : fix-imports

created branch time in 6 days

pull request commentfuturetap/InAppSettingsKit

Changes to structure to better support SPM when used with Tuist

hey @hisaac - thanks for the PR! 🙏 We like the direction! I'll look into this early next week. My hunch is to clean things up a little, completely drop the xcodeproj for the static library & the framework build (and thus also Carthage), and just rely on SPM. WDYT?

The SPM setup looks good - the resources might gone missing though?

hisaac

comment created time in 9 days

pull request commentkylef/PathKit

fix build on Xcode 13 RC

I dont know if this is worse but in my PR I just safely unwrapped them to free them, given that if they come back as nil, they probably were already freed?

My hunch is it would crash a few lines down. e.g. fnmatch gets imported into Swift as: public func fnmatch(_: UnsafePointer<CChar>!, _: UnsafePointer<CChar>!, _: Int32) -> Int32

So my hunch is it would just crash there then :-/

diederich

comment created time in 10 days

pull request commentkylef/PathKit

fix build on Xcode 13 RC

The reasons that strdup will return NULL are when insufficient memory is available.

Right right, the return value has always been an implicitly unwrapped optional.

[snip]

I would imagine that in the past Swift would have caused a crash in this case, the change to the compiler exposes strdups error case to to caller.

Did a bit more reading, and it's actually one of the examples from https://swift.org/blog/iuo/ While the return value carried the "!", it gets lost in the assignment in the next step: let notAnImplicitOptions = somethingThatReturnsAnImplicitOptional()

So either a bug was fixed that this now works as expected, or free changed in that it took an optional before (which would also be fair I guess, given in C a free(0) is also fine )

​I'd suggest we retain the existing behaviour because silently handling errors and returning false information is unexpected behaviour.

Fair, thanks for the feedback. Happy to put up a change!

It feels like a preconditionFailure isn't the right call, given it's not really a programmer error. Would you wanna change the signature to return optionals / throw, or just hard crash with the a force unpack?

diederich

comment created time in 11 days

PR opened kylef/PathKit

fix build on Xcode 13 RC

This fixes the build of PathKit on Xcode 13 RC.

strdup returns an implicitly unwrapped optional, which seems to loose its "implicit" via the assignment. I couldn't find anything in the Xcode release notes, but I guess it's a fair change :-) Let's treat the returned pointers as true optionals and instead of crashing, return defaults.

+2 -3

0 comment

1 changed file

pr created time in 12 days

create barnchthebrowsercompany/PathKit

branch : feature/fix-build-Xcode-13-RC

created branch time in 12 days

push eventthebrowsercompany/swift-composable-architecture

Ian Keen

commit sha c77c6054c8591adc17d3b8b9d64c7cc8beec7b65

Add threading warning to Store.send (#772) * Add threading warning to Store.send Any async Effect (including fireAndForget) could result in a runtime crash when updating internal state like `effectCancellables` This adds a debug warning to let users know * Remove comment

view details

Stephen Celis

commit sha aac63d7e180e602ecc8184000c44bb6aea251dd1

Add documentation for `BindingAction.pullback` (#771) * Add documentation for `BindingAction.pullback` * wip * motivate

view details

stephencelis

commit sha 7d15362de9aad205fb6840132ca90ef71ebe6515

Run swift-format

view details

Stephen Celis

commit sha 7ede19f9b5ad4075cd927cc1068bf9e0f5941949

Improve deprecation warnings for old binding helpers (#774) * Improve deprecation warnings for old binding helpers * wip * wip * wip * esc * wip

view details

Brandon Williams

commit sha 33279f4c38106ae5c623ad7be4c968e61c41e2bc

Update to thread warnings. (#773) * Update to thread warnings. * fix tests * clean up * rename variable

view details

Brandon Williams

commit sha 90e97411c8408a2d21442b8eef7933d55feb1984

Change initialThread to a let. (#778)

view details

Luke Redpath

commit sha e2795c1789c8f44fe62301892d585e44772ff880

Conform BindableState to CustomDebugStringConvertible (#777) This ensures that bindable state properties are displayed in a useful way when using `.dump` snapshot tests on your app state.

view details

stephencelis

commit sha cb5150f57e254f039986f1d81a8e34d980098a09

Run swift-format

view details

filblue

commit sha 0715ba0c618c98c7e8a4fc4f0efc319fe476a714

Fix unfunctional cancel button handlers in AlertsAndActionSheets case study (#779) * Fix unfunctional cancel button handlers in AlertsAndActionSheets case study * Fix tests * Removes *CancelTapped actions from AlertsAndActionSheets case study

view details

Stephen Celis

commit sha 69b3605e3acf31e8a341f8b40ddd8ed760b45302

Fix BindableState: Codable strategies (#781)

view details

Stephen Celis

commit sha 03a814d0d35474efdc5114cbcd8db4965758587a

Update bindable helpers docs (#783) * Update bindable helpers docs * wip

view details

Andrey

commit sha 86bcd083a1048452007561e28b6adf97c81fba2d

Remove #if DEBUG/#endif surrounding `Effect.failing` (#786)

view details

Brandon Williams

commit sha d15101d7b6e07f7b4160b3483564ee1ff1c2abae

Update threading messaging. (#789)

view details

Stephen Celis

commit sha a1aac6cfd654051d0ab5e626462afff36c399219

Fix macOS <11 builds with Xcode 13 RC (#797) * Fix macOS <11 builds with Xcode 13 RC Fixes #796. * wip * Update Tests/ComposableArchitectureTests/ViewStoreTests.swift Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com> Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com>

view details

Stephan Diederich

commit sha e9ace4b4723b54a6efdd9cfb90952d3bb7b7c1c3

Merge tag '0.27.1' into develop

view details

push time in 12 days

push eventthebrowsercompany/swift-composable-architecture

Adam Roben

commit sha d4b438a61f9940bc7319f8a18ead0a8d30c2ddaf

Fix a redundant conformance constraint warning in ForEachStore (#738) The warning was: Sources/ComposableArchitecture/SwiftUI/ForEachStore.swift:141:28: warning: redundant conformance constraint 'EachContent' : 'View' public init<EachContent: View>( ^ Sources/ComposableArchitecture/SwiftUI/ForEachStore.swift:146:16: note: conformance constraint 'EachContent' : 'View' implied here EachContent: View, ^ I fixed the warning by removing the redundant constraint from the type parameter.

view details

Stephen Celis

commit sha 21c8b4d8ef8ff7a462295ebde0a9eef5bfcbef01

Update tests to use `XCTAssertNoDifference` (#739)

view details

Stephen Celis

commit sha 68664c144e0d49d2fff1f45081f1bb57203b88fd

Use proportional diffing for TestStore failures (#742) * Use proportional diffing for TestStore failures * wip * wip

view details

iampatbrown

commit sha 7fec6a4df76a4cabcacfc424507ac4d9becb97e0

Pass attemptToFulfill directly to Future (#743)

view details

Brandon Williams

commit sha bc5c510c7bece63910d262d40293bfd264370e9f

Update readme to reflect new diff format (#744) * Update README.md * Update README.md

view details

Ken Grigsby

commit sha 682e2902c276afc200f7109fc09c3c19841b70b3

Correct Store documentation (#746)

view details

Brandon Williams

commit sha 1f2f6124be52d094b20ed510de9c6fdf5a977fcf

Update Exports.swift (#749)

view details

Stephen Celis

commit sha 161abda3b7b63490faa432fb991c19e9ad30c524

Restore formatting

view details

Stephen Celis

commit sha bf9ab75f9dce30c510c5c7bf284225335f6a24a0

Add CI for DocC warnings (#750) * Add CI for DocC warnings * More specific grep

view details

stephencelis

commit sha 3c51885b983b623f0cc506660d79b02d45a8ffc1

Run swift-format

view details

Stephen Celis

commit sha 83e7557d7b2de1cfb878ae3a182320d03b6a3826

Simplify Reusable Download Component (#756)

view details

filblue

commit sha dacd3de63f2617ba718224064a7562c6748a117c

NavigateAndLoad: Cancel loading on dismiss (#757) * NavigateAndLoad: Cancel loading on dismiss * Update Examples/CaseStudies/SwiftUICaseStudies/03-Navigation-NavigateAndLoad.swift Co-authored-by: Stephen Celis <stephen.celis@gmail.com> * Update Examples/CaseStudies/SwiftUICaseStudies/03-Navigation-Sheet-PresentAndLoad.swift Co-authored-by: Stephen Celis <stephen.celis@gmail.com> * Add cancellation to UIKitCaseStudies/NavigateAndLoad.swift * Add cancellation to LoadThenNavigate studies Co-authored-by: Stephen Celis <stephen.celis@gmail.com>

view details

Stephen Celis

commit sha af88fe4c7908e529b2e979b7f1f0107928edac7d

Safer, Conciser Bindings (#765) * Better binding tools. * make everything public * deprecate * update * clean up * wip * dml * wip * wip * Fix a redundant conformance constraint warning in ForEachStore (#738) The warning was: Sources/ComposableArchitecture/SwiftUI/ForEachStore.swift:141:28: warning: redundant conformance constraint 'EachContent' : 'View' public init<EachContent: View>( ^ Sources/ComposableArchitecture/SwiftUI/ForEachStore.swift:146:16: note: conformance constraint 'EachContent' : 'View' implied here EachContent: View, ^ I fixed the warning by removing the redundant constraint from the type parameter. * wip * wip * wip * wip * wip * wip * wip Co-authored-by: Brandon Williams <mbrandonw@hey.com> Co-authored-by: Adam Roben <aroben@apple.com>

view details

stephencelis

commit sha 60dc8067185b3e1fb29237f5a4548bff005b0fec

Run swift-format

view details

Stephan Diederich

commit sha c1c05130e6988aad8397e7c5f61830973f28e527

Merge tag '0.26.0' into develop

view details

push time in 20 days

Pull request review commentpointfreeco/swift-identified-collections

bump swift-collections dependency to 0.0.7

 let package = Package(     )   ],   dependencies: [-    .package(url: "https://github.com/apple/swift-collections", from: "0.0.1"),+    .package(url: "https://github.com/apple/swift-collections", from: "0.0.7"),

Good call! Thank you 🙏 Didn't see this was there all along

diederich

comment created time in a month

PullRequestReviewEvent

push eventthebrowsercompany/swift-identified-collections

Stephan Diederich

commit sha c39e1dc0039e68011ec29f1c271f8861e96aa11d

bump swift-collections dependency to 0.0.7 bump dependency and adapt new API

view details

push time in a month

PR opened pointfreeco/swift-identified-collections

bump swift-collections dependency to 0.0.7

This bumps the dependency swift-collections dependency to 0.0.7 and adapt to the new API to fix build warnings

+3 -3

0 comment

3 changed files

pr created time in a month

push eventthebrowsercompany/swift-identified-collections

Stephan Diederich

commit sha 0f0b693ff18843c6518e9f1140ad52ec6fc354c7

bump swift-collections dependency to 0.0.7 bump dependency and adapt new API

view details

push time in a month

push eventthebrowsercompany/sentry-cocoa

dependabot[bot]

commit sha 5b09ea828138e6201c3ac9e94b41c8eeed39e2ad

build(deps): bump fastlane from 2.184.0 to 2.184.1 (#1140) Bumps [fastlane](https://github.com/fastlane/fastlane) from 2.184.0 to 2.184.1. - [Release notes](https://github.com/fastlane/fastlane/releases) - [Commits](https://github.com/fastlane/fastlane/compare/fastlane/2.184.0...fastlane/2.184.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Philipp Hofmann

commit sha a7241f23d008db6b3259015c4b06bf32af085607

test: Add XCScheme for tvOS and iOS-Ojbective-C (#1145) tvOS-Swift.xcscheme and iOS-ObjectiveC.xcscheme were missing.

view details

Philipp Hofmann

commit sha 368bd86ac6d78e9571eeca48351e6408f5359fd1

ref: Serialization for SentrySpanContext (#1148) Remove not needed check for nil for nonnullable field operation.

view details

Burak Yigit Kaya

commit sha f173dcdc0449799e0cc1d3deb68cf5f7c52b1ba5

ref(craft): Modernize Craft config (#1151)

view details

Philipp Hofmann

commit sha cac88010e23c3b4f687148b4c9701420a812abf5

test: Make SentrySDK.setCurrentHub nullable (#1153) It's handy to set the currentHub of the SentrySDK back to nil in the tearDown of a test.

view details

dependabot[bot]

commit sha d4560c941622d13bdadf2147d046ebeacb19d632

build(deps): bump fastlane from 2.184.1 to 2.185.0 (#1154) Bumps [fastlane](https://github.com/fastlane/fastlane) from 2.184.1 to 2.185.0. - [Release notes](https://github.com/fastlane/fastlane/releases) - [Commits](https://github.com/fastlane/fastlane/compare/fastlane/2.184.1...fastlane/2.185.0) --- updated-dependencies: - dependency-name: fastlane dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Philipp Hofmann

commit sha 9e25633ccaab2d90bef4980cb21cc093bd57db63

test: Nullable fields for SentrySpanContext (#1147) Add a test to verify that the serialization of SentrySpanContext handles nil values.

view details

Philipp Hofmann

commit sha 4191bcb85048bed85ba6691dc11ef820de541421

feat: Auto Performance Instrumentation (#1136) Add automatic performance instrumentation for ViewControllers. This PR adds spans for the different phases of the lifecycle of ViewControllers. Co-authored-by: Dhiogo Brustolin <dhiogorb@gmail.com> Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>

view details

Philipp Hofmann

commit sha 4cfddd5ec8b48c2086f9aa4b1c5d409d8f524597

feat: Measure app start time (#1111) Measure app start time for cold and warm starts. Add spans and measurement to the first auto-generated transaction after the app start. Co-authored-by: Dhiogo Brustolin <dhiogorb@gmail.com> Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>

view details

Dhiogo Brustolin

commit sha 83cc79791af52447ea268638606530a95787b4ab

ref: SentryPerformanceTracker (#1144) Refactor SentryPerformanceTracker and add missing tests.

view details

Philipp Hofmann

commit sha 238bc48c5fc73d90d2641ac51c11d7013afd00af

release: 7.2.0-beta.0

view details

Philipp Hofmann

commit sha 17456ec50835c95c8e0b92151d6fc7be032d0d3e

Merge branch 'release/7.2.0-beta.0'

view details

Philipp Hofmann

commit sha 1141391255b4fa31200706ac96ec3acb7df03ce8

fix: Operation names for auto instrumentation (#1164) Rename app start to app.start.warm or app.start.cold and ui.rendering to ui.load. Fixes GH-1129

view details

Philipp Hofmann

commit sha 3ad091361339f5074fd6eb54de8690dd2522bd9c

ref: Make DefaultCurrentDateProvider a singleton (#1157)

view details

Philipp Hofmann

commit sha fdbd402ad2265139a57736b49048a8a51fcb109e

ref: Make SentryCrashAdapter a singleton (#1158) The SDK uses several instances of SentryCrashAdapter. This is fixed now, by making it a singleton.

view details

Philipp Hofmann

commit sha 7c20e71b181cd9e1cbc431769a5b7f9ca094c22a

feat: Measure slow and frozen frames (#1123) Measure slow, frozen, and total frames and attach these as measurements to every transaction for iOS, tvOS, and Mac Catalyst.

view details

Philipp Hofmann

commit sha ef7ba5fedd7afc40710567fdb7427375a3d52f29

meta: Fix Changelog

view details

Philipp Hofmann

commit sha b00c91008a7ced0038e37133445a293e4851bbe4

release: 7.2.0-beta.1

view details

Philipp Hofmann

commit sha 5e964a18d32981336b1b030c637ed4cce9f8cc72

Merge branch 'release/7.2.0-beta.1'

view details

Jonathan Downing

commit sha 4b817c7a61651ae15f64a9642eb9a879d3dcc1e1

Remove invalid excludes from Package.swift (#1169)

view details

push time in a month

push eventthebrowsercompany/swift-composable-architecture

Brandon Williams

commit sha 92c75a17b7334e2f2db60c076ad93d16b3d0df5d

Fix typo.

view details

Brandon Williams

commit sha c9653cf57bd52b4aa2b6957ced74c12f265618d0

Cancel multiple effects with a variadic list. (#676) * Cancel multiple effects with a variadic list. * genericize * doc fix * use array

view details

Stephen Celis

commit sha 1b8c019e32974bf4ef945625c34ec1fab9382a99

Update swift-format for Swift 5.5 (#677) * wip * Update format.yml * wip * Fix * wip

view details

stephencelis

commit sha a4f544e892f04822def9f5934ff4d7ecfdf1329e

Run swift-format

view details

Bernhard Loibl

commit sha 71be9d96761b86314b6c381baa2fb003dd0b02d1

Enables animations for alert button actions (#680) * Enables animations for alert button actions. * Updates alert button api and previews. Co-authored-by: Bernhard Loibl <bernhard.loibl@intive.com>

view details

stephencelis

commit sha 14ced811f8cb88dbb2e60c11b0709b9ed663a44d

Run swift-format

view details

Stephen Celis

commit sha 5209f47b03937ca4227fb10e572019e4a4adb55e

Update AlertState.Button APIs for animation (#681) * Update AlertState.Button APIs for animation * fix * wip * deprecate

view details

André Pacheco Neves

commit sha d42b471cbddf70e445d40f7462dbaca31832348f

Fix `Effect.throttle` delayed value shared state cleanup (#683) Effect.throttle didn't clean up `throttleValues` shared state on the delayed values path, leading to the first value strategy (`latest: false`) to return incorrect (old) values on some scenarios. ## Changes - Add missing `throttleValues[id]` clean up in `Effect.throttle` delayed value path.

view details

stephencelis

commit sha b3edfcd3a4f5272ea8f969f9fe4112ecf61abd0d

Run swift-format

view details

Stephen Celis

commit sha 026482d270d4a903c97d2ea1544077bef8ba3931

tic-tac-toe package (#684) * tic-tac-toe package * Update Package.swift * Tests * wip * wip * wip * Update Package.swift

view details

stephencelis

commit sha 55cf912712035930311e786bf3372b1447eb58b4

Run swift-format

view details

Stephen Celis

commit sha 7a19bd63f5fb089dc51358ed636e6ecbd877c81e

Clean up for Tic-Tac-Toe updates (#685)

view details

Stephen Celis

commit sha 68a688304520581eb87ac66ad4435bd58500ab1f

Use `modify` helper in Tic-Tac-Toe integration test (#687) * Use `modify` helper * Clean up breakpoint warnings

view details

Adam Roben

commit sha 5c925e39cb2b11db03b0d2c4aedc97be7f15db93

Fix build error when minimum target is macOS 11.0 (#686) macOS 11.0 introduced an overload of Publisher.flatMap(maxPublishers:_:) for when the failure type is Never, documented here: https://developer.apple.com/documentation/combine/publisher/flatmap(maxpublishers:_:)-qxf This causes a compiler error in Effect.fireAndForget when the minimum deployment target is 11.0 or later: Sources/ComposableArchitecture/Effect.swift:364:7: error: ambiguous use of 'flatMap(maxPublishers:_:)' self ^ Combine.Publisher:3:17: note: found this candidate public func flatMap<T, P>(maxPublishers: Subscribers.Demand = .unlimited, _ transform: @escaping (Self.Output) -> P) -> Publishers.FlatMap<P, Self> where T == P.Output, P : Publisher, Self.Failure == P.Failure ^ Combine.Publisher:3:17: note: found this candidate public func flatMap<P>(maxPublishers: Subscribers.Demand = .unlimited, _ transform: @escaping (Self.Output) -> P) -> Publishers.FlatMap<Publishers.SetFailureType<P, Self.Failure>, Self> where P : Publisher, P.Failure == Never ^ We can fix this by adding explicit type parameters to the Empty publisher used in the flatMap().

view details

Andrey

commit sha 494a2a83c78456960481dde6a3fe36bb73ecbb77

UIKit helpers generating UIAlertController from AlertState & ActionSheetState (#563) * UIKit helpers generating UIAlertController from AlertState & ActionSheetState * Exclude helpers from platforms not supporting UIKit (macOS) * Exclude watchOS * Update public API * Update AlertStateUIKit.swift Co-authored-by: Stephen Celis <stephen.celis@gmail.com>

view details

stephencelis

commit sha fbb931303f2c48fa403f1c6b45cf9f108cc8f99d

Run swift-format

view details

Brandon Williams

commit sha 8ae8a60770042095a48801ef0e6cc1af8db08055

@FocusState case study. (#690) * @FocusState case study. * compiler version

view details

mbrandonw

commit sha c24ea6e7ab93ac626a2144d9165e60ebd4ac08fc

Run swift-format

view details

Stephen Celis

commit sha 6cd32e6e66a3bedec42ffcf8256cc06818247fc0

Also run CI on Big Sur (#691) * Also run CI on Big Sur * Update ci.yml * Fix * fix

view details

Stephen Celis

commit sha b6ce7143cc2bafffdc2814d708b6b62c6bfd4768

Clarify view store thread safety (#692) * Update ViewStore.swift * Update ViewStore.swift * wip * Update ViewStore.swift

view details

push time in a month

push eventthebrowsercompany/sentry-cocoa

Philipp Hofmann

commit sha 4c8d25c5016e622887efc37425f35e660aa3e79b

Merge release/7.1.3 into master

view details

Philipp Hofmann

commit sha 73b4831a83e02651538ec1be53d5d9d0d0e124fc

fix: Compile failure with C99 (#1224) Added an extra import to fix build failure for C99. Fixes GH-1210 Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>

view details

Philipp Hofmann

commit sha d9b37a6664cf2467efda861e1383ec806a221b18

release: 7.1.4

view details

Stephan Diederich

commit sha bce3d08a5ce2c6578511a2bae95dbd8621c30bb8

Merge tag '7.1.4' into development Tag for release: 7.1.4

view details

push time in 2 months

push eventthebrowsercompany/swift-composable-architecture

stephencelis

commit sha 040cfa01b1635003d0c202c1ab67051dc7c2f751

Run swift-format

view details

Olli Tapaninen

commit sha 30f3027cf79a9975479b04c5a7a6565a6eb425b9

Fix IfLetStore so that it does not replay first seen state on nil-value (#667)

view details

André Pacheco Neves

commit sha 65f1fa043f9eeb5e0567f4f80f33a42d6ae797b8

Fix `Effect.throttle` data races and scheduler value return (#669) * Fix `Effect.throttle` data races and scheduler value return The `Effect.throttle` operator had multiple data races when updating `throttleTimes` and `throttleValues` shared state, because: 1. `Effect.throttle` can be called from any scheduler. 2. The internal `flatMap` runs on the current chain scheduler, but the throttled (delayed) value runs on the passed in `scheduler` parameter (which can be different). By protecting shared state with a lock (similar to the cancellables'), these data races should be addressed. Additionally, the `Effect.throttle` should return all values in the `scheduler` passed in, so that the API contract is honored and values come from where callers expect them to. ## Changes - Add new `throttleLock` `recursive lock to protect `throttleTimes` and `throttleValues` shared state in `Effect.throttle` operator. - Ensure all values in `Effect.throttle` come from the passed in `scheduler`. * Fix `Effect.throttle` tests, Use `sync` lock helper

view details

Stephen Celis

commit sha 0978dde24a83590391a08df8c0f46ea71e9db189

Keep last non-nil value around for ForEachStore (#668)

view details

stephencelis

commit sha b809888a5b8b6db9f02068fa3b96842a66f0ebe7

Run swift-format

view details

konomae

commit sha 60fbb6601639004b5295aefe08089e3e55a61719

Fix minor typo (#671) * Fix typo: iff → if * Add missing `>`

view details

Brandon Williams

commit sha d4c0ff35dee6e24cb922d748782d9e55be96192e

Add an async/await aware .send method to View Store. (#673) * wip * case study * docs * clean up * more compiler directives. * xcode 12 fixes Co-authored-by: Stephen Celis <stephen@stephencelis.com>

view details

Brandon Williams

commit sha d6d7ca6109fdfbf0e7c6b43757c27220bae844cf

Add some tests to ViewStore.send(_:while:) and ViewStore.suspend. (#674)

view details

Stephen Celis

commit sha 0d27c3c79cbbc7aaff86f5976d8fa98967163d00

Fix swift-format (#675) * wip * fix * fix

view details

Stephen Celis

commit sha 4e7930f97f5b6fabe185b3eaf235dbfd5ab94ad6

Update Makefile

view details

stephencelis

commit sha 4223ffbf97cfe030617b95b713bb5d6b6503567d

Run swift-format

view details

Stephan Diederich

commit sha 6ec676d33b118ebc581b79e0d9493304cdfb0a5b

Merge tag '0.23.0' into develop

view details

push time in 2 months