profile
viewpoint
Michał Ordon designorant @tehidea London, UK https://designorant.com Web/App Consultant at @Tehidea

designorant/leveluptuts__react-for-everyone 4

Code for "React For Everyone" tutorial on LevelUpTuts by Scott Tolinski

designorant/30-days-of-react-native 0

30 days of React Native demos

designorant/addon-adguard-home 0

AdGuard Home - Home Assistant Community Add-ons

designorant/addon-unifi 0

UniFi Controller - Home Assistant Community Add-ons

designorant/advanced-react-patterns-v2 0

Created with CodeSandbox

designorant/AlgorithmVisualizer 0

Algorithm Visualizer

designorant/atom-es6-javascript 0

Commands and snippets for faster Javascript with Atom

designorant/atom-react-snippets 0

React snippets using ES6 syntax

designorant/awesome-react 0

A collection of awesome things regarding React ecosystem.

PullRequestReviewEvent

pull request commentONSdigital/census-atlas

Feature/add change area overlay

Blocked by #1761.

vmilitaru

comment created time in 6 days

delete branch ONSdigital/census-atlas

delete branch : feature/svelte-kit

delete time in 10 days

push eventONSdigital/census-atlas

Michał Ordon

commit sha e1bc0b57d0b0af40ccb008e76f94db37af02a68c

Use yarn temporarily

view details

Michał Ordon

commit sha ef100ac7fd3f1a503edbd7d947b9107c8d60d766

Convert to SvelteKit No SSR for now

view details

Michał Ordon

commit sha f5c50eaf266d3b8b630ebcc6c9e0a9935eff0193

Convert to SvelteKit router and fix relative paths

view details

Michał Ordon

commit sha 0bf144b573f8efdbca44b010d504bbf013c8427e

Rename components route This extra silly commit is purely to trick non case sensitive filesystems into lowercasing the filename

view details

Michał Ordon

commit sha 67631431d221854d2dad2ebcbf3ab78a0d0004b3

Add Netlify adapter

view details

Michał Ordon

commit sha aeea4c7c3e24f491c3fbc7d44daa12ca9ba45cea

Clean up ONS Design System scripts

view details

Michał Ordon

commit sha bf855f7dec871ac87416f71ee72127f14c6bee72

Cleanup

view details

Michał Ordon

commit sha 61a0cae51fd8dbc98d1c8f397491b7a901a0af79

Bump ONS Design System It's [still buggy](https://github.com/ONSdigital/design-system/issues/1761#issuecomment-978044472) though

view details

Michał Ordon

commit sha a6bcdb8675ffc84727b989d3c7fbfd173cdd03ac

Add a nasty workaround for loading ONS Design System on each route A.M.A.

view details

Michał Ordon

commit sha 7444bfb8f927ae4de6b958e55596bcd2e117c9f0

Stick to SvelteKit default structure

view details

Michał Ordon

commit sha 804185b3686fcbd800fd3c5cfae9290e9e514764

Bump dependencies No breaking changes that affect us

view details

Michał Ordon

commit sha 76ab8407c4349afde2df05aa830da14ab8ddf333

Bump SvelteKit

view details

Michał Ordon

commit sha b7d5e47e091d8c918b42aa3765e5c737bb66acf1

Remove Storybook Whew

view details

Michał Ordon

commit sha 81b2463b8025abd5fcc7a22ee8f9c2c380c37768

Bring back `npm`

view details

Michał Ordon

commit sha 152e28b444da95d8ed08b1dcb16b0634390da763

Clean up Late night cleaning is the best type of cleaning

view details

Michał Ordon

commit sha 8cfd94e92b74687ba1f9537d20044d97f5c044d4

Try to make Netlify happy

view details

Michał Ordon

commit sha d2ff99bb64739621544a99fefa70434373f85220

Use SCSS only and fix fonts paths This was fun (-:

view details

Michał Ordon

commit sha 6277d6cc1252463f77f2684e2837cb3a66377033

Make Netlify happy

view details

Michał Ordon

commit sha 10b632413d3d3a7b87ce6a2fedf6bf9e001c112c

Help with debugging

view details

Michał Ordon

commit sha d42d64b7515cf9e62fe1931696168166cd99fb0c

Reword and a clean up

view details

push time in 10 days

PR merged ONSdigital/census-atlas

Reviewers
Move to Svelte Kit

This was fun. Came across this fun issue, found a bug in Svelte, a bug in ONS Design System, almost lost my sanity on this bug / lack of feature thanks to the magical "client side routing" that intercepts everything, and ended up using a nasty workaround that adds a <script /> tag on each route, literally.

The SSR isn't enabled just yet, need some fixes for accessing Window object, but will get there.

Cut into logical chunks for easy merging, and rebased on master; all seems fine but let's wait for the Netlify bot to confirm. 🤞

Edit: Netlify bot disagrees even though yarn preview seems to work just fine locally.

+12939 -19675

3 comments

80 changed files

designorant

pr closed time in 10 days

PullRequestReviewEvent

Pull request review commentONSdigital/design-system

Design System - Move scss imports to the correct location

 @import '../components/timeline/timeline'; @import '../components/upload/upload'; @import '../components/video/video';-@import '../patterns/help-users-to/see-important-information/src/_highlight';

No really my place to comment but @import '../components/highlight/highlight'; on L:31 tells me that there's a big chance ../patterns/help-users-to/see-important-information/ might be missing from src/scss/patternlib.scss.

boxadesign

comment created time in 11 days

push eventONSdigital/census-atlas

Michał Ordon

commit sha d42d64b7515cf9e62fe1931696168166cd99fb0c

Reword and a clean up

view details

push time in 11 days

push eventONSdigital/census-atlas

Michał Ordon

commit sha 10b632413d3d3a7b87ce6a2fedf6bf9e001c112c

Help with debugging

view details

push time in 11 days

push eventONSdigital/census-atlas

Patrick Fleming

commit sha 2281aad6ca5e953abd2d4ff99c86fac05fa3f84e

refactors explore by area component

view details

Valentina

commit sha 1acc5db47776925c577aef1cfe61b7b2d37e7a56

styles the autosuggest input

view details

Valentina

commit sha 0929075486a3de8fb919272271fc21130f17ab8c

refactores the ONSAutosuggest component so that is conditionally rendering the input label

view details

Valentina

commit sha ff490908e47205355c55e7c1e8e8f71cf379d659

styles autosuggest text color at the ons ds component level

view details

Valentina

commit sha 4e51b63e32ebd0cc670ee6599a5e3dbf431b4646

adds autosuggest data to explore census page

view details

Patrick Fleming

commit sha 474e83b05b3202cfaf83f5a9d5c6a5a3cd8a358f

conditionally styles autosuggest input container

view details

Patrick Fleming

commit sha 95ae981eac9bf93a28d85ed699736bf7b9c37fd1

npm run format

view details

Patrick Fleming

commit sha 6f64657a1d3ea85fad2afe7c797da6de65703f8c

Merge pull request #76 from ONSdigital/feature/adds-lad-search-autosuggest Feature/adds lad search autosuggest

view details

Michał Ordon

commit sha e1bc0b57d0b0af40ccb008e76f94db37af02a68c

Use yarn temporarily

view details

Michał Ordon

commit sha ef100ac7fd3f1a503edbd7d947b9107c8d60d766

Convert to SvelteKit No SSR for now

view details

Michał Ordon

commit sha f5c50eaf266d3b8b630ebcc6c9e0a9935eff0193

Convert to SvelteKit router and fix relative paths

view details

Michał Ordon

commit sha 0bf144b573f8efdbca44b010d504bbf013c8427e

Rename components route This extra silly commit is purely to trick non case sensitive filesystems into lowercasing the filename

view details

Michał Ordon

commit sha 67631431d221854d2dad2ebcbf3ab78a0d0004b3

Add Netlify adapter

view details

Michał Ordon

commit sha aeea4c7c3e24f491c3fbc7d44daa12ca9ba45cea

Clean up ONS Design System scripts

view details

Michał Ordon

commit sha bf855f7dec871ac87416f71ee72127f14c6bee72

Cleanup

view details

Michał Ordon

commit sha 61a0cae51fd8dbc98d1c8f397491b7a901a0af79

Bump ONS Design System It's [still buggy](https://github.com/ONSdigital/design-system/issues/1761#issuecomment-978044472) though

view details

Michał Ordon

commit sha a6bcdb8675ffc84727b989d3c7fbfd173cdd03ac

Add a nasty workaround for loading ONS Design System on each route A.M.A.

view details

Michał Ordon

commit sha 7444bfb8f927ae4de6b958e55596bcd2e117c9f0

Stick to SvelteKit default structure

view details

Michał Ordon

commit sha 804185b3686fcbd800fd3c5cfae9290e9e514764

Bump dependencies No breaking changes that affect us

view details

Michał Ordon

commit sha 76ab8407c4349afde2df05aa830da14ab8ddf333

Bump SvelteKit

view details

push time in 11 days

startedvitejs/vite

started time in 11 days

delete branch ONSdigital/census-atlas

delete branch : feature/design-system-select

delete time in 11 days

delete branch ONSdigital/census-atlas

delete branch : feature/design-system-checkboxes

delete time in 11 days

delete branch ONSdigital/census-atlas

delete branch : feature/design-system-autosuggest

delete time in 11 days

delete branch ONSdigital/census-atlas

delete branch : feature/forgotten-changes-on-ds-components

delete time in 11 days

delete branch ONSdigital/census-atlas

delete branch : feature/design-system-share-page

delete time in 11 days

delete branch ONSdigital/census-atlas

delete branch : feature/census-atlas-dataheader-1-2

delete time in 11 days

delete branch ONSdigital/census-atlas

delete branch : feature/census-atlas-dataheader-3

delete time in 11 days

pull request commentONSdigital/census-atlas

Move to Svelte Kit

It's not a job, it's a journey. Ready for review.

Some background to the latest fixes and workarounds:

  • https://github.com/sveltejs/kit/issues/2687
  • https://github.com/ONSdigital/design-system/issues/1750#issuecomment-978808765

Also removed Storybook for quicker deploy times. Locally this thing flies compared to the original now.

designorant

comment created time in 11 days

push eventONSdigital/census-atlas

Michał Ordon

commit sha 46c8a044b52b1077c46a2b94210872f71d324f9d

Make Netlify happy

view details

push time in 11 days

issue commentONSdigital/design-system

Improve docs to cover importing SCSS styles fully with potential gotchas

Turned out #1757 had some bugs:

Please remove the following from main.scss (unless I'm missing something):

@import '../patterns/help-users-to/see-important-information/src/_highlight';
@import '../patterns/pages/question/examples/question-anatomy/pl-question-anatomy';
@import '../foundations/layout/page-template/examples/block-areas/block-areas';
@import '../foundations/style/colours/colours';
@import '../foundations/style/icons/icon-swatch';

Please also kindly add !default to the $static variable so it can be overridden on import for correct font paths without recreating the whole main.scss: $static: '..' !default

Much thanks!

designorant

comment created time in 11 days

IssuesEvent

push eventONSdigital/census-atlas

Michał Ordon

commit sha 80c236e58db53b2cf3f60abfcbbcd1fdb5d5e9ab

Use SCSS only and fix fonts paths This was fun (-:

view details

push time in 11 days

push eventONSdigital/census-atlas

Michał Ordon

commit sha c6fcd2892c439a16e205a442ca6156664a9380e0

Clean up Late night cleaning is the best type of cleaning

view details

Michał Ordon

commit sha 0560922a3d7f46838bdd21b2ca3b9246cda3a5df

Try to make Netlify happy

view details

push time in 11 days

push eventONSdigital/census-atlas

Michał Ordon

commit sha 1a5bba39b9ac5d59c9c2c2c21ccf1072f7ab993a

Try to make Netlify happy

view details

Michał Ordon

commit sha 02b89a2977f3b906b8630c0122e637e1e4614315

Cleanup

view details

push time in 11 days

push eventONSdigital/census-atlas

Michał Ordon

commit sha 336b203862961871faa84c909963895c77839960

Clean up Late night cleaning is the best type of cleaning

view details

Michał Ordon

commit sha a49d9c3263bbfa84d5dddbf777f5945db14ef5e1

Try to make Netlify happy

view details

push time in 11 days

push eventONSdigital/census-atlas

Michał Ordon

commit sha ad2401c00fe7ef3f77efe085ea811418e75f4549

Bump SvelteKit

view details

Michał Ordon

commit sha 653e8520ab87677ba77c3f553bab75cdc7781406

Remove Storybook Whew

view details

Michał Ordon

commit sha 40de2a81c0815c941df8b2e371b1bcb935ab9beb

Bring back `npm`

view details

push time in 11 days

push eventONSdigital/census-atlas

Michał Ordon

commit sha 3b97d52427f8bbe84bce1423379a64e35375434f

Bump dependencies No breaking changes that affect us

view details

push time in 11 days

pull request commentONSdigital/census-atlas

Move to Svelte Kit

Looks like it reads the config file just fine:

6:41:19 PM: Different publish path detected, going to use the one specified in the Netlify configuration file: 'build' versus 'public' in the Netlify UI
6:41:19 PM: Different build command detected, going to use the one specified in the Netlify configuration file: 'yarn build' versus 'npm run build' in the Netlify UI

but chokes on the D3 packages:

6:42:07 PM: > Using @sveltejs/adapter-netlify
6:42:08 PM:  > .svelte-kit/output/server/chunks/original-5947e2b1.js:3:7: warning: Ignoring this import because "node_modules/d3-scale/dist/d3-scale.js" was marked as having no side effects
6:42:08 PM:      3 │ import "d3-scale";
6:42:08 PM:        ╵        ~~~~~~~~~~
6:42:08 PM:    node_modules/d3-scale/package.json:35:2: note: "sideEffects" is false in the enclosing "package.json" file
6:42:08 PM:     35 │   "sideEffects": false,
6:42:08 PM:        ╵   ~~~~~~~~~~~~~
6:42:08 PM:  > .svelte-kit/output/server/chunks/original-5947e2b1.js:4:7: warning: Ignoring this import because "node_modules/d3-array/dist/d3-array.js" was marked as having no side effects
6:42:08 PM:      4 │ import "d3-array";
6:42:08 PM:        ╵        ~~~~~~~~~~
6:42:08 PM:    node_modules/d3-array/package.json:39:2: note: "sideEffects" is false in the enclosing "package.json" file
6:42:08 PM:     39 │   "sideEffects": false,
6:42:08 PM:        ╵   ~~~~~~~~~~~~~
6:42:08 PM:  > .svelte-kit/output/server/chunks/original-5947e2b1.js:5:7: warning: Ignoring this import because "node_modules/d3-shape/dist/d3-shape.js" was marked as having no side effects
6:42:08 PM:      5 │ import "d3-shape";
6:42:08 PM:        ╵        ~~~~~~~~~~
6:42:08 PM:    node_modules/d3-shape/package.json:40:2: note: "sideEffects" is false in the enclosing "package.json" file
6:42:08 PM:     40 │   "sideEffects": false,
6:42:08 PM:        ╵   ~~~~~~~~~~~~~
6:42:08 PM:   ✔ done

Google-fu give some pointers.

designorant

comment created time in 12 days

push eventONSdigital/census-atlas

Michał Ordon

commit sha 41b47a6e7967734a91fd6164ac124811e8dafdbc

Stick to SvelteKit default structure

view details

push time in 12 days

more