profile
viewpoint

deluxe/discovery 1

Tool for discovering object content.

deluxe/bashtop 0

Linux resource monitor

deluxe/gebbdoom 0

Game Engine Black Book: Doom

deluxe/gebbwolf3 0

Book about wolfenstein 3D

startedhhannine/superpaper

started time in a day

startedImpedimenta/Suitcase

started time in a month

startedjstrieb/urlpages

started time in 2 months

startedjstrieb/link-lock

started time in 2 months

startedarcticicestudio/nord

started time in 2 months

startedjan-warchol/selenized

started time in 2 months

startedprometheus/jmx_exporter

started time in 2 months

issue openedfabiensanglard/gebbwolf3

Compilation script does not work for Inkscape 0.92 or older

Compilation script make.sh defines Inkscape executable path as /Applications/Inkscape.app/Contents/MacOS/inkscape. This path does not work for Inkscape 0.92 or older with executable in /Applications/Inkscape.app/Contents/Resources/bin/inkscape.

Either adapt the path to manage Inkscape 0.92 (with PATH system variable) or specify 1.0 as Inkscape minimum version.

Steps to reproduce

  1. Install Inkscape 0.92
  2. Remove PNG already converted from SVG drawings to force conversion calls to Inkscape:
rm src/screenshots/386_layout_drawing.png src/screenshots/386_packaging_die.png src/screenshots/bsp_map.png src/screenshots/clear_screen_pixels.png src/screenshots/lines.png
rm src/screenshots_300dpi/386_layout_drawing.png src/screenshots_300dpi/386_packaging_die.png src/screenshots_300dpi/bsp_map.png src/screenshots_300dpi/clear_screen_pixels.png src/screenshots_300dpi/lines.png
  1. Remove 2>&1 from Inkscape command lines (make.sh lines 52 and 60) to display errors
  2. Launch the compilation with:
cd gebbwolf3/ && ./make.sh 
# or, see issue #7:
cd gebbwolf3/src/ && ../make.sh

Result The script outputs an error message (and launch Inkscape GUI) for each call to Inkscape:

Convert screenshots_svg/bsp_map.svg to PNG (100dpi).
/BuildRoot/Library/Caches/com.apple.xbs/Sources/AppleFSCompression/AppleFSCompression-96.200.3/Common/ChunkCompression.cpp:49: Error: unsupported compressor 8
/BuildRoot/Library/Caches/com.apple.xbs/Sources/AppleFSCompression/AppleFSCompression-96.200.3/Libraries/CompressData/CompressData.c:353: Error: Unknown compression scheme encountered for file '/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/Exceptions.plist'
/BuildRoot/Library/Caches/com.apple.xbs/Sources/AppleFSCompression/AppleFSCompression-96.200.3/Common/ChunkCompression.cpp:49: Error: unsupported compressor 8
/BuildRoot/Library/Caches/com.apple.xbs/Sources/AppleFSCompression/AppleFSCompression-96.200.3/Libraries/CompressData/CompressData.c:353: Error: Unknown compression scheme encountered for file '/System/Library/CoreServices/CoreTypes.bundle/Contents/Library/AppExceptions.bundle/Exceptions.plist'
[...]

Expected result The script should convert SVG images to PNG without error(s).

Infos MacOS 10.14.6 Inkscape 0.92.2

created time in 3 months

issue openedfabiensanglard/gebbwolf3

Compilation script does not check properly for Inkscape executable

Compilation script make.sh does not check properly for Inkscape executable presence.

The check (make.sh lines 9-15) checks for $INKSCAKE which does not exist instead of $INKSCAPE

if [ ! -f $INKSCAKE ]; then
  echo "Inkscape executable is invalid"
  echo "Was expected at $INKSCAPE"
  exit 1
fi

but the condition is written with simple brackets [ ] which do not properly manage empty variables without double quotes, thus not detecting missing argument to -f test.

  • Steps to reproduce
  1. Do not install Inkscape, uninstall Inkscape, or change INKSCAPE variable value (make.sh line 4) to point to a non-existent path
  2. Remove PNG already converted from SVG drawings to force conversion calls to Inkscape:
rm src/screenshots/386_layout_drawing.png src/screenshots/386_packaging_die.png src/screenshots/bsp_map.png src/screenshots/clear_screen_pixels.png src/screenshots/lines.png
rm src/screenshots_300dpi/386_layout_drawing.png src/screenshots_300dpi/386_packaging_die.png src/screenshots_300dpi/bsp_map.png src/screenshots_300dpi/clear_screen_pixels.png src/screenshots_300dpi/lines.png
  1. Remove 2>&1 from Inkscape command lines (make.sh lines 52 and 60) to display errors
  2. Launch the compilation with:
cd gebbwolf3/ && ./make.sh 
# or, see issue #7:
cd gebbwolf3/src/ && ../make.sh
  • Result The script does not stop at Inkscape check, continue and outputs an error message for each call to Inkscape:
Convert screenshots_svg/bsp_map.svg to PNG (100dpi).
../make.sh: line 53: /Applications/Inkscape.app/Contents/MacOS/inkscape: No such file or directory
[...]
  • Expected result The script should have stopped at Inkscape check and display:
Inkscape executable is invalid
Was expected at /Applications/Inkscape.app/Contents/MacOS/inkscape

created time in 3 months

issue openedfabiensanglard/gebbwolf3

Script make.sh does not convert SVG images when launched from its root directory

Script does not convert SVG images when launched from its root directory and outputs an error message instead.

  • Steps to reproduce Launch the compilation with:
cd gebbwolf3/ && ./make.sh 
  • Result The script outputs an error message:
find: screenshots_svg: No such file or directory
  • Expected result The script should walk through src/screenshots_svg and compile SVG images in PNG (if newer)

created time in 3 months

create barnchdeluxe/gebbdoom

branch : cleanup

created branch time in 3 months

create barnchdeluxe/gebbwolf3

branch : cleanup

created branch time in 3 months

startedremkop/picocli

started time in 3 months

more