profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/dbarnett/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

aliafshar/a8 52

a8, the Abominade IDE

BrianODell/py-openzwave 3

py-openzwave is a python wrapper around the open-zwave c++ project.

dbarnett/cyberpyg 2

CyberPyg syntax highlighting / lexing framework

dbarnett/a8 1

a8, the Abominade IDE

dbarnett/Arduino 1

open-source electronics prototyping platform

dbarnett/bugfree 1

plaintext based bugtracker

issue commentgoogle/vim-maktaba

Poetry/pipenv support?

Oh, I wasn't getting how python package dependencies were relevant until I saw the specific example with coverage. But are you imagining cases where there's no system-wide install of python & coverage, or what?

Lilja

comment created time in 5 hours

PR merged bazelbuild/vim-ft-bzl

Add missing options to b:undo_ftplugin cla: yes

The bzl ftplugin inherits this variable from the sourced python ftplugin but doesn't restore the options it exclusively sets.

+4 -0

3 comments

1 changed file

dkearns

pr closed time in a day

push eventbazelbuild/vim-ft-bzl

Doug Kearns

commit sha 6b41860d8418384926b338a8f19beb344c386f68

Add missing options to b:undo_ftplugin (#15)

view details

push time in a day

pull request commentbazelbuild/vim-ft-bzl

Add missing options to b:undo_ftplugin

Looks good, thanks! Merging.

dkearns

comment created time in a day

Pull request review commentbazelbuild/vim-ft-bzl

Add missing options to b:undo_ftplugin

 let &l:tabstop = s:save_tabstop  setlocal formatoptions-=t +let b:undo_ftplugin .= " | setlocal fo<"

Oh, right! Could you put a comment above this line to note it's initially defined in ftplugin/python.vim?

dkearns

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentbazelbuild/vim-ft-bzl

Add missing options to b:undo_ftplugin

 let &l:tabstop = s:save_tabstop  setlocal formatoptions-=t +let b:undo_ftplugin .= " | setlocal fo<"

Isn't b:undo_ftplugin not necessarily defined yet, in which case this would fail?

dkearns

comment created time in 4 days

PullRequestReviewEvent

issue commentgoogle/vim-ft-go

Pull request syntax to vim/vim

Yeah, one way or another I'd love to have a good go syntax file built into vim. I set up this repo just as a staging area for upstreaming changes, but moving to fatih's repo and obsoleting this one simplifies some things. Definitely worth getting issues filed to track the shortcomings there, though.

89z

comment created time in 5 days

issue commentgoogle/vim-ft-go

Pull request syntax to vim/vim

Interesting, didn't they pull the one currently in vim from https://github.com/fatih/vim-go? Happy to help improve things, but if they're accepting PRs to get the best of both, that might be simpler.

Did you close this because you changed your mind, or something else?

89z

comment created time in 5 days

issue commentgoogle/vim-codefmt

Support passing `--srcdir` to goimports

BTW, despite its name, --srcdir accepts the full file path including filename, not just the dir (at least since 2016). We should make it invoke goimports --srcdir=foo/bar.go instead of goimports --srcdir=foo/.

dbarnett

comment created time in 9 days

issue commentgoogle/vim-codefmt

Support passing `--srcdir` to goimports

Another idea is to cd before running goimports (or whatever tool is configured in gofmt_executable), but it's a bit of a hack when there's already a --srcdir option supported and might have corner case issues (like if you're writing a new file in a subdirectory that doesn't exist yet).

dbarnett

comment created time in 9 days

push eventgoogle/vroom

Andrey Feofilaktov

commit sha abd0e4ad98254e7c245c58ce22bd1635179494f0

Improve shell errors handling (#121) Improve shell errors reporting, so that vroom prints the actual shell errors.

view details

push time in 20 days

PR merged google/vroom

Improve shell errors handling cla: yes

Make sure FakeShellNotWorking is treated as any other Vroom failure and that its string representation contains enough debugging information.

+3 -2

0 comment

1 changed file

snu5mumr1k

pr closed time in 20 days

PR merged google/vim-colorscheme-primary

Support truecolor and background transparency cla: yes

Fixes #10

Option: let g:colorscheme_primary_bg_transparency = 1

Before: dark background

After: dark background transparency

+98 -87

5 comments

2 changed files

windvalley

pr closed time in 21 days

push eventgoogle/vim-colorscheme-primary

noone

commit sha 5a5e05a960d7fe4ec6efa27099fd1eff8c479da0

Support truecolor and background transparency (#11) Fixes #10

view details

push time in 21 days

issue closedgoogle/vim-colorscheme-primary

True color support and background transparency support

Hi,

If 'set termguicolors' is set in .vimrc, the colors will not be displayed normally.

In additon, could you consider supporting background transparency feature?

Thanks~

closed time in 21 days

windvalley

pull request commentgoogle/vim-colorscheme-primary

Support truecolor and background transparency

Looks good! Merging…

Thanks for contributing!

windvalley

comment created time in 21 days

Pull request review commentgoogle/vim-colorscheme-primary

Support truecolor and background transparency

 endif   " Colors for Syntax Highlighting.-exe 'hi String       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'='.s:I-exe 'hi Character    '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'='.s:I-exe 'hi Conditional  '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'-exe 'hi Label        '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'-exe 'hi Repeat       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'-exe 'hi Statement    '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'-exe 'hi Keyword      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'-exe 'hi Exception    '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'--exe 'hi Normal       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:BLUE .' '.s:M.'=none'-exe 'hi Identifier   '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:BLUE .' '.s:M.'=bold'-exe 'hi Function     '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:BLUE .' '.s:M.'=bold'--exe 'hi Comment      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=none'-exe 'hi Typedef      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'='.s:I-exe 'hi PreProc      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'-exe 'hi Include      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'-exe 'hi Define       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'-exe 'hi Macro        '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'-exe 'hi Precondit    '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'-exe 'hi SpecialComment '.s:M.'bg='.s:BG.' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'--exe 'hi Special      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY0.' '.s:M.'=none'-exe 'hi Delimiter    '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY0.' '.s:M.'=none'-exe 'hi Debug        '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY0.' '.s:M.'=none'-exe 'hi SpecialChar  '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY0.' '.s:M.'=bold'-exe 'hi Title        '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY0.' '.s:M.'=bold'--exe 'hi Constant     '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=none'-exe 'hi Boolean      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=none'-exe 'hi Number       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=none'-exe 'hi Float        '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=none'-exe 'hi Operator     '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=bold'-exe 'hi Tag          '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=bold'-exe 'hi Ignore       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=none'-exe 'hi Underlined   '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1 .' '.s:M.'=underline'+if (s:enable_bg_transparency == 1)+  exe 'hi Normal       '.s:M.'bg=NONE '.s:M.'fg='.s:BLUE .' '.s:M.'=none'+  exe 'hi NonText      '.s:M.'bg=NONE '.s:M.'fg='.s:GREY1.' '.s:M.'=bold'+else+  exe 'hi Normal       '.s:M.'bg='.s:BG .' '.s:M.'fg='.s:BLUE .' '.s:M.'=none'+  exe 'hi NonText      '.s:M.'bg='.s:BG   .' '.s:M.'fg='.s:GREY1.' '.s:M.'=bold'

Looks good to me!

windvalley

comment created time in 21 days

PullRequestReviewEvent

Pull request review commentgoogle/vim-colorscheme-primary

Support truecolor and background transparency

 endif   " Colors for Syntax Highlighting.-exe 'hi String       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'='.s:I-exe 'hi Character    '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'='.s:I-exe 'hi Conditional  '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'-exe 'hi Label        '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'-exe 'hi Repeat       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'-exe 'hi Statement    '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'-exe 'hi Keyword      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'-exe 'hi Exception    '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:RED  .' '.s:M.'=bold'--exe 'hi Normal       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:BLUE .' '.s:M.'=none'-exe 'hi Identifier   '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:BLUE .' '.s:M.'=bold'-exe 'hi Function     '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:BLUE .' '.s:M.'=bold'--exe 'hi Comment      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=none'-exe 'hi Typedef      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'='.s:I-exe 'hi PreProc      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'-exe 'hi Include      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'-exe 'hi Define       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'-exe 'hi Macro        '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'-exe 'hi Precondit    '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'-exe 'hi SpecialComment '.s:M.'bg='.s:BG.' '.s:M.'fg='.s:GREEN.' '.s:M.'=bold'--exe 'hi Special      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY0.' '.s:M.'=none'-exe 'hi Delimiter    '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY0.' '.s:M.'=none'-exe 'hi Debug        '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY0.' '.s:M.'=none'-exe 'hi SpecialChar  '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY0.' '.s:M.'=bold'-exe 'hi Title        '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY0.' '.s:M.'=bold'--exe 'hi Constant     '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=none'-exe 'hi Boolean      '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=none'-exe 'hi Number       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=none'-exe 'hi Float        '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=none'-exe 'hi Operator     '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=bold'-exe 'hi Tag          '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=bold'-exe 'hi Ignore       '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1.' '.s:M.'=none'-exe 'hi Underlined   '.s:M.'bg='.s:BG  .' '.s:M.'fg='.s:GREY1 .' '.s:M.'=underline'+if (s:enable_bg_transparency == 1)+  exe 'hi Normal       '.s:M.'bg=NONE '.s:M.'fg='.s:BLUE .' '.s:M.'=none'+  exe 'hi NonText      '.s:M.'bg=NONE '.s:M.'fg='.s:GREY1.' '.s:M.'=bold'+else+  exe 'hi Normal       '.s:M.'bg='.s:BG .' '.s:M.'fg='.s:BLUE .' '.s:M.'=none'+  exe 'hi NonText      '.s:M.'bg='.s:BG   .' '.s:M.'fg='.s:GREY1.' '.s:M.'=bold'

I didn't see a change here. Strange spacing still on 'bg='.s:BG .' ' here and farther down on the hi Underlined line.

Sorry for the back-and-forth. If it's a pain to update now, I might do a pass over the file later to make a few overall readability tweaks.

windvalley

comment created time in 23 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgoogle/vim-colorscheme-primary

Support truecolor and background transparency

 does not support 256 colors. No problem - just remove that line and consult If you want to disable italic font, add this line to your .vimrc: >   let g:colorscheme_primary_disable_italic = 1 <+                                        *g:colorscheme_primary_bg_transparency*

Update this tag to match the updated variable name.

windvalley

comment created time in 23 days

Pull request review commentgoogle/vim-colorscheme-primary

Support truecolor and background transparency

 does not support 256 colors. No problem - just remove that line and consult If you want to disable italic font, add this line to your .vimrc: >   let g:colorscheme_primary_disable_italic = 1 <+                                        *g:colorscheme_primary_bg_transparency*+If you want to enable background transparency, add this line to your .vimrc: >+  let g:colorscheme_primary_bg_transparency = 1

Syntax nit: Isn't this missing the < to explicitly mark the end of the block?

windvalley

comment created time in 24 days

PullRequestReviewEvent

Pull request review commentgoogle/vim-colorscheme-primary

Support truecolor and background transparency

 if exists('syntax_on') endif let g:colors_name = 'primary' let s:disable_italic = get(g:,'colorscheme_primary_disable_italic', 0)+let s:enable_bg_transparency = get(g:,'colorscheme_primary_bg_transparency', 0)

Yep, this works for me, and the cross-references are really helpful, thanks!

windvalley

comment created time in 24 days

PullRequestReviewEvent

pull request commentgoogle/vim-colorscheme-primary

Support truecolor and background transparency

Changes look reasonable (and nice screenshot!). Could you detail for the PR how the specific changes work since colorscheme mechanics can be a little cryptic? It looks like you've pulled out the bg color to only be defined on Normal and NonText (while making them conditional), and then they get inherited by all the other syntax types?

@LisieRae Could you take a look as well?

windvalley

comment created time in 25 days

Pull request review commentgoogle/vim-colorscheme-primary

Support truecolor and background transparency

 if exists('syntax_on') endif let g:colors_name = 'primary' let s:disable_italic = get(g:,'colorscheme_primary_disable_italic', 0)+let s:enable_bg_transparency = get(g:,'colorscheme_primary_bg_transparency', 0)

For the variable name here, I'm wondering, have you seen any other colorschemes do similar, and do they have any existing variable name we could adopt as a convention? If not, this is fine as-is.

windvalley

comment created time in 25 days