profile
viewpoint
Denis Davidyuk davidyuk @aeternity Russia, Vladivostok https://www.upwork.com/freelancers/~01df9ec96e07862b14 I'm on LinkedIn: https://www.linkedin.com/in/denis-davidyuk-9a9330141/

aeternity/aepp-sdk-js 90

Javascript SDK for the æternity blockchain

aeternity/aepp-base 43

Base æpp

aeternity/aepp-prototypes 20

Concepts of apps that will work on the top ouf æterenity blockchain

aeternity/aeternal 13

Æterrnal--the caching and reporting layer for the æternity blockchain

aeternity/ledger-app-before-release 3

æternity wallet application for Ledger Nano S

aeternity/hd-wallet-js 2

HD Wallet for the æternity blockchain

aeternity/superhero-ui 2

Superhero UI

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

Pull request review commentaeternity/aepp-sdk-js

Refactor state channels

 const PING_TIMEOUT_MS = 10000 // Close connection if pong message is not received within 5 seconds const PONG_TIMEOUT_MS = 5000 -const options = new WeakMap()-const status = new WeakMap()-const state = new WeakMap()+export const options = new WeakMap()+export const status = new WeakMap()+export const state = new WeakMap() const fsm = new WeakMap() const websockets = new WeakMap()-const eventEmitters = new WeakMap()+export const eventEmitters = new WeakMap() const messageQueue = new WeakMap() const messageQueueLocked = new WeakMap() const actionQueue = new WeakMap() const actionQueueLocked = new WeakMap() const sequence = new WeakMap()-const channelId = new WeakMap()+export const channelId = new WeakMap() const rpcCallbacks = new WeakMap() const pingTimeoutId = new WeakMap() const pongTimeoutId = new WeakMap()-const fsmId = new WeakMap()+export const fsmId = new WeakMap() -function channelURL (url, params) {-  const paramString = R.join('&', R.values(R.mapObjIndexed((value, key) =>-    `${pascalToSnake(key)}=${encodeURIComponent(value)}`, params)))--  return `${url}?${paramString}`-}

It is used only in this file, in initialize function, otherwise, it will be rejected by linter.

davidyuk

comment created time in 2 hours

pull request commentaeternity/aepp-sdk-js

Refactor contract, oracle, chain

I have rebased this PR on develop and fixed tests.

I didn't notice the minor breaking changes

The only one was a making pollForQueries to run in sync, I have made it return a dumb promise to be able to merge it earlier.

davidyuk

comment created time in 2 hours

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha 179f59f6f7d92b8019f691c1fede3b548024bbed

oraclePostQueryTx: Make consistent output

view details

Denis Davidyuk

commit sha 86d079b6579903d8b4c1afb76835d31b883d1927

sendTransaction: Don't recreate error object To persist stack trace

view details

Denis Davidyuk

commit sha 01bc9bfe66c791b54b5fba645c192fe4ce411c5a

topBlock: Rewrite not using ramda

view details

Denis Davidyuk

commit sha 2a4352007b8dcfc5f81b934aecbd6833a81c4597

getTxInfo: Prefer 'await' instead of 'then'

view details

Denis Davidyuk

commit sha cd695c1b54e4a00738d8c5ec9f1b7a5364b1d650

awaitHeight, poll: Avoid unnecessary recursion To get rid of long stack traces and avoid possible stack overflow in `poll`

view details

Denis Davidyuk

commit sha df93448824e543cf0b00d285e8d37c84ddd81cd7

Refactor chain module

view details

Denis Davidyuk

commit sha 3deb5a8fafef81e9c75d1412df1c5c409f979f12

pollForQueries: Improve naming

view details

Denis Davidyuk

commit sha 01909f43fafa31a38013c6f056983c56153cf12a

pollForQueries: Return promise as it was before

view details

push time in 2 hours

Pull request review commentaeternity/aepp-sdk-js

Refactor contract, oracle, chain

 async function getQueryObject (oracleId, queryId) {  * @return {Promise<Object>} OracleQuery object  */ export async function pollForQueryResponse (oracleId, queryId, { attempts = 20, interval = 5000 } = {}) {-  const emptyResponse = 'or_Xfbg4g=='-  async function pause (duration) {-    await new Promise(resolve => setTimeout(resolve, duration))-  }-  async function probe (left) {-    const query = await this.getOracleQuery(oracleId, queryId)-    if (query.response !== emptyResponse) {-      return { response: query.response, decode: () => decodeBase64Check(query.response.slice(3)) }-    }-    if (left > 0) {-      await pause(interval)-      return probe.bind(this)(left - 1)+  for (let i = 0; i < attempts; i++) {

are you sure the for correctly awaits the promise here for each iteration?

Yes, I think so. Actually, I'm rarely writing a for cycle, but I think it is a good place to use it. I prefer this because it uses just plain js.

davidyuk

comment created time in 2 hours

Pull request review commentaeternity/aepp-sdk-js

Refactor contract, oracle, chain

 async function getOracleObject (oracleId) {  * @alias module:@aeternity/aepp-sdk/es/ae/oracle  * @instance  * @function- * @category async  * @param {String} oracleId Oracle public key  * @param {Function} onQuery OnQuery callback  * @param {Object} [options] Options object  * @param {Number} [options.interval] Poll interval(default: 5000)  * @return {Function} stopPolling - Stop polling function  */-async function pollForQueries (oracleId, onQuery, { interval = 5000 } = {}) {-  const queries = (await this.getOracleQueries(oracleId)).oracleQueries || []-  let quriesIds = queries.map(q => q.id)-  await onQuery(queries)--  async function pollQueries () {-    const { oracleQueries: q } = await this.getOracleQueries(oracleId)-    const newQueries = q.filter(({ id }) => !quriesIds.includes(id))-    if (newQueries.length) {-      quriesIds = [...quriesIds, ...newQueries.map(a => a.id)]-      onQuery(newQueries)-    }+function pollForQueries (oracleId, onQuery, { interval = 5000 } = {}) {+  const sentQueryIds = new Set()+  const fetchQueries = async () => {+    const queries = ((await this.getOracleQueries(oracleId)).oracleQueries || [])+      .filter(({ id }) => !sentQueryIds.has(id))+    queries.forEach(({ id }) => sentQueryIds.add(id))

It looks like we don't need to store all previous queries, just the last one instead, and pass it as from parameter to GetOracleQueriesByPubkey. I would like to check it later, proposing to leave as it is now. https://github.com/aeternity/aepp-sdk-js/issues/1055

davidyuk

comment created time in 2 hours

Pull request review commentaeternity/aepp-sdk-js

Refactor contract, oracle, chain

 async function getOracleObject (oracleId) {  * @alias module:@aeternity/aepp-sdk/es/ae/oracle  * @instance  * @function- * @category async  * @param {String} oracleId Oracle public key  * @param {Function} onQuery OnQuery callback  * @param {Object} [options] Options object  * @param {Number} [options.interval] Poll interval(default: 5000)  * @return {Function} stopPolling - Stop polling function  */-async function pollForQueries (oracleId, onQuery, { interval = 5000 } = {}) {-  const queries = (await this.getOracleQueries(oracleId)).oracleQueries || []-  let quriesIds = queries.map(q => q.id)-  await onQuery(queries)--  async function pollQueries () {-    const { oracleQueries: q } = await this.getOracleQueries(oracleId)-    const newQueries = q.filter(({ id }) => !quriesIds.includes(id))-    if (newQueries.length) {-      quriesIds = [...quriesIds, ...newQueries.map(a => a.id)]-      onQuery(newQueries)-    }+function pollForQueries (oracleId, onQuery, { interval = 5000 } = {}) {+  const sentQueryIds = new Set()+  const fetchQueries = async () => {

I'm proposing a better naming in 5164358a931215ef629608c6d1369f302d966c75

davidyuk

comment created time in 2 hours

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha 4c2b3534ed8bb2a98c670e6630624bff9aeec053

pollForQueries: Return promise as it was before

view details

push time in 2 hours

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha 5d8958b24d178581d10f4d2bca38a775ed44dcaa

test-else: Exclude aens tests

view details

Denis Davidyuk

commit sha 2047ea8a67ef101fcc6cdde9ac3b11b22fad73a8

Speedup jobs by building once

view details

Denis Davidyuk

commit sha e91f4acf85b3c1cb2cb54d570c1027f7774a05f9

Make tests configuration more flexible - don't require keypair defined in env variables - allow to use a different keypair without changing keys

view details

Denis Davidyuk

commit sha a10f3405974797f3f472128e842fa7e82c6daa72

Merge pull request #1037 from aeternity/feature/make-tests-configs-more-flexible Make tests configuration more flexible

view details

Denis Davidyuk

commit sha e3e63149e10d8c61bb2e229a10cf2dbda5c44bc9

Merge pull request #1040 from aeternity/feature/test-else-exclude-aens test-else: Exclude aens tests and speedup jobs

view details

Denis Davidyuk

commit sha e4e391a8155eaaa5be1c0aacda557f27ad1cc9ab

Avoid unnecessary eslint-disable

view details

Denis Davidyuk

commit sha 6db2285842cfc853ed36851bc204986fab052c51

Merge pull request #1043 from aeternity/feature/avoid-unnecessary-eslint-disable Avoid unnecessary eslint-disable

view details

Denis Davidyuk

commit sha 4d87de26b1a96b5ef702f1cff1b08ad614cfb5b8

Add a 'lint' script instead of running linter on build

view details

Denis Davidyuk

commit sha 7949ec8140b8558958732ccdd37c677ac7682042

Fix linter errors automatically

view details

Denis Davidyuk

commit sha c3e5920cfab61ba92b10da7c7cc044e654fae285

Fix linter errors manually

view details

Denis Davidyuk

commit sha 2c4d73ade6d6a9faafe9975beae6af412e01671a

Update standard package to 14.3.4

view details

Denis Davidyuk

commit sha 3ded444bcb3ae2e04746b7881a66f3fe01a8e844

Merge pull request #1045 from aeternity/feature/linter-script Add lint script

view details

Denis Davidyuk

commit sha 0cdd19db8bfed8387298f65b4ef2bbe40a6a2894

rpc tests: Inline dependency used in one place

view details

Denis Davidyuk

commit sha 4827ecbbc32f973e01aa0633c53a69b5c4a7e45b

integration tests: Remove unused account2

view details

Denis Davidyuk

commit sha 78ced6c0367b308d32f3242ebf0d5823ab26503d

Refactor integration/index

view details

Denis Davidyuk

commit sha 74d25cd89bf42ea3287f8879bd29db9a52eb65a2

randomName: Generate only .chain names

view details

Denis Davidyuk

commit sha eed46480bbf5c3fe87cea2556c640dbd5b80df03

aens tests: Drop pre lima compatibility

view details

Denis Davidyuk

commit sha 3e98d59d94a228f78db04b8b76ed314d29b36633

Extract Mocha configuration, reduce timeout

view details

Denis Davidyuk

commit sha 56f3cac7864480eb02c1866ddaeb2f2547a1b2d6

Consistent import of BigNumber

view details

Denis Davidyuk

commit sha 6a5eaa18187460f13caf8563b684a18c7b81d8a5

integration tests: Rename ready to getSdk

view details

push time in 2 hours

CommitCommentEvent

push eventaeternity/aepp-base

Denis Davidyuk

commit sha 9bd25466d8e2736123a9ce83215e0cf29e47999b

TransactionList: Fix infinite load when page is zoomed

view details

push time in 4 hours

pull request commentaeternity/superhero-ui

TipsPagination: Simplify infinite loading

I have made detection a less accurate by 100 pixels, I think it should fix the issue. Also, I made it work the same as in MDN guide. For some reason, I don't have overscrolling in Firefox on my MacBook. @mradkov can you check it again?

davidyuk

comment created time in 4 hours

push eventaeternity/superhero-ui

Yury Shapkarin

commit sha dfd949d13ca6e5bb6072e0d6657e68a960f34c04

add the meet icon and make it a little bit smaller

view details

Yury Shapkarin

commit sha 2ae5b50c9962167e835cd88815228e511486193d

meet icon dynamic color as used with others icons

view details

Yury Shapkarin

commit sha 01898d455d5d44493c989cf5a40d0850657d5671

svgo svg optimization npm task

view details

Stanislav Slavov

commit sha 977f91f6bd81dbc54ddb034278224c654bb09fe4

Removed redundant top margin style

view details

Yury Shapkarin

commit sha 22e1a1180730e82977618a864da3849f7bd1d56d

fix meet icon with css

view details

Milen Radkov

commit sha 6c015ed4571aae5e5da6a54a24dea8e13ce00b0c

Merge pull request #687 from aeternity/meet_icon Add meet icon for meet menu item

view details

Milen Radkov

commit sha 31bf393c267715132c856d6a619d620817960ea8

Merge pull request #695 from aeternity/issue/content_shown_above_sticky_position Sticky position has 1px off the top

view details

Denis Davidyuk

commit sha 81e4f8d537a06f0f213441254534a52b2e9f7c66

TipsPagination: Simplify infinite loading This reverts commit 5f548bbd33b1e0e6750707f32aab9816fd390fc6.

view details

Denis Davidyuk

commit sha 65bb3edbea8d2a3f4029e8cfcd9a1a080f26e73b

TipsPagination: Don't load multiple pages at the same time

view details

push time in 4 hours

Pull request review commentaeternity/superhero-ui

Optimized base.scss styles

+<template>+  <div+    class="filter-button"+    @click="$emit('click', $event)"+  >+    <template>+      <slot />+    </template>

I can't get why do you need an empty template

    <slot />
stanislav-slavov

comment created time in 10 hours

Pull request review commentaeternity/superhero-ui

Optimized base.scss styles

+<template>+  <a+    :disabled="disabled"+    class="button-link"+    :href="href"+    :target="target"+    :title="title"+    @click="$emit('click', $event)"+  >+    <template>+      <slot />+    </template>+  </a>+</template>++<script>++export default {+  props: {+    disabled: Boolean,+    href: { type: String, default: '' },+    target: { type: String, default: '_self' },+    title: { type: String, default: '' },+  },+};+</script>++<style lang="scss" scoped>+.button-link {+  background: transparent;+  border: 0.05rem solid $standard_font_color;+  border-radius: 0.25rem;+  color: $standard_font_color;+  display: inline-block;+  font-size: 0.75rem;+  font-weight: 600;+  padding: 0.6rem;+  text-align: center;+  min-width: 8rem;++  &:hover {+    border: 0.05rem solid $custom_links_color;+    color: $custom_links_color;+    cursor: pointer;+    text-decoration: none;+  }++  &.blue {+    color: $secondary_color;+    border: 0.05rem solid $secondary_color;+  }++  &.green {+    color: $custom_links_color;+    border: 0.05rem solid $custom_links_color;+  }++  &.blue:hover,+  &.green:hover {+    color: $standard_font_color;+    border: 0.05rem solid $standard_font_color;
    border-color: $standard_font_color;
stanislav-slavov

comment created time in 5 hours

Pull request review commentaeternity/superhero-ui

Optimized base.scss styles

+<template>+  <a+    :disabled="disabled"+    class="button-link"+    :href="href"+    :target="target"+    :title="title"+    @click="$emit('click', $event)"+  >+    <template>+      <slot />+    </template>+  </a>+</template>++<script>++export default {+  props: {+    disabled: Boolean,+    href: { type: String, default: '' },+    target: { type: String, default: '_self' },+    title: { type: String, default: '' },+  },+};+</script>++<style lang="scss" scoped>+.button-link {+  background: transparent;

Do links have some background by default? 🤔

stanislav-slavov

comment created time in 5 hours

Pull request review commentaeternity/superhero-ui

Optimized base.scss styles

+<template>+  <a+    :disabled="disabled"+    class="button-link"+    :href="href"+    :target="target"+    :title="title"+    @click="$emit('click', $event)"+  >+    <template>+      <slot />+    </template>+  </a>+</template>++<script>++export default {+  props: {+    disabled: Boolean,+    href: { type: String, default: '' },+    target: { type: String, default: '_self' },+    title: { type: String, default: '' },+  },+};+</script>++<style lang="scss" scoped>+.button-link {+  background: transparent;+  border: 0.05rem solid $standard_font_color;+  border-radius: 0.25rem;+  color: $standard_font_color;+  display: inline-block;+  font-size: 0.75rem;+  font-weight: 600;+  padding: 0.6rem;+  text-align: center;+  min-width: 8rem;++  &:hover {+    border: 0.05rem solid $custom_links_color;+    color: $custom_links_color;+    cursor: pointer;+    text-decoration: none;+  }++  &.blue {+    color: $secondary_color;+    border: 0.05rem solid $secondary_color;
    border-color: $secondary_color;
stanislav-slavov

comment created time in 5 hours

Pull request review commentaeternity/superhero-ui

Optimized base.scss styles

+<template>+  <a+    :disabled="disabled"+    class="button-link"+    :href="href"+    :target="target"+    :title="title"+    @click="$emit('click', $event)"+  >+    <template>+      <slot />+    </template>+  </a>+</template>++<script>++export default {+  props: {+    disabled: Boolean,+    href: { type: String, default: '' },+    target: { type: String, default: '_self' },+    title: { type: String, default: '' },+  },+};+</script>++<style lang="scss" scoped>+.button-link {+  background: transparent;+  border: 0.05rem solid $standard_font_color;+  border-radius: 0.25rem;+  color: $standard_font_color;+  display: inline-block;+  font-size: 0.75rem;+  font-weight: 600;+  padding: 0.6rem;+  text-align: center;+  min-width: 8rem;++  &:hover {+    border: 0.05rem solid $custom_links_color;
    border-color: $custom_links_color;
stanislav-slavov

comment created time in 5 hours

Pull request review commentaeternity/superhero-ui

Optimized base.scss styles

+<template>+  <a+    :disabled="disabled"+    class="button-link"+    :href="href"+    :target="target"+    :title="title"+    @click="$emit('click', $event)"+  >+    <template>+      <slot />+    </template>+  </a>+</template>++<script>++export default {+  props: {+    disabled: Boolean,+    href: { type: String, default: '' },+    target: { type: String, default: '_self' },+    title: { type: String, default: '' },+  },+};+</script>++<style lang="scss" scoped>+.button-link {+  background: transparent;+  border: 0.05rem solid $standard_font_color;+  border-radius: 0.25rem;+  color: $standard_font_color;+  display: inline-block;+  font-size: 0.75rem;+  font-weight: 600;+  padding: 0.6rem;+  text-align: center;+  min-width: 8rem;++  &:hover {+    border: 0.05rem solid $custom_links_color;+    color: $custom_links_color;+    cursor: pointer;+    text-decoration: none;+  }++  &.blue {+    color: $secondary_color;+    border: 0.05rem solid $secondary_color;+  }++  &.green {+    color: $custom_links_color;+    border: 0.05rem solid $custom_links_color;
    border-color: $custom_links_color;
stanislav-slavov

comment created time in 5 hours

Pull request review commentaeternity/superhero-ui

Optimized base.scss styles

+<template>+  <a+    :disabled="disabled"+    class="button-link"+    :href="href"+    :target="target"+    :title="title"+    @click="$emit('click', $event)"+  >+    <template>+      <slot />+    </template>+  </a>+</template>++<script>++export default {+  props: {+    disabled: Boolean,+    href: { type: String, default: '' },+    target: { type: String, default: '_self' },+    title: { type: String, default: '' },+  },+};+</script>++<style lang="scss" scoped>+.button-link {+  background: transparent;+  border: 0.05rem solid $standard_font_color;+  border-radius: 0.25rem;+  color: $standard_font_color;+  display: inline-block;+  font-size: 0.75rem;+  font-weight: 600;+  padding: 0.6rem;+  text-align: center;+  min-width: 8rem;++  &:hover {+    border: 0.05rem solid $custom_links_color;+    color: $custom_links_color;+    cursor: pointer;

This shouldn't be necessary because it is already a link

stanislav-slavov

comment created time in 5 hours

pull request commentaeternity/superhero-ui

Aligned vertically activity buttons on user profile

Ok, I got it. Another approach would be to use display: flex; align-items: center; at the root node, but I'm not sure which one is more obvious.

stanislav-slavov

comment created time in 5 hours

PR opened aeternity/superhero-ui

Store search query in URL

blocked by #664

+27 -55

0 comment

6 changed files

pr created time in 6 hours

create barnchaeternity/superhero-ui

branch : feature/search-query-in-url

created branch time in 6 hours

PR opened aeternity/aepp-sdk-js

Disable Travis on all branches except master, develop

This PR partially reverts 51c661dc4ece4235a1fb4dd71b0a28f323e1f668. The goal is to avoid double-checking of all RPs. Initially, I wanted to disable the testing of PRs and keep branch testing, but as we checked in https://github.com/aeternity/aepp-sdk-js/pull/1053 disabling of PR builds will complicate test running on third-party PRs.

+5 -0

0 comment

1 changed file

pr created time in 7 hours

create barnchaeternity/aepp-sdk-js

branch : feature/travis-disable-branches

created branch time in 7 hours

push eventaeternity/aepp-sdk-js

Shutov Roman

commit sha 418000f283c1567934f0a16737d131df668bd185

Fix typo in Readme.md

view details

Denis Davidyuk

commit sha 3fb48d2eaf2e05c8d5092a6e9c687d8ad0e12291

Merge pull request #1053 from RShutov/patch-1 Fix typo in Readme.md

view details

push time in 7 hours

PR merged aeternity/aepp-sdk-js

Fix typo in Readme.md
+2 -2

2 comments

1 changed file

RShutov

pr closed time in 7 hours

delete branch davidyuk/global-diff

delete branch : patch-1

delete time in 10 hours

push eventdavidyuk/global-diff

Denis Davidyuk

commit sha c36b28648d592862dd3636f923478ee27b52d047

Update src/index.js Co-authored-by: Yury Shapkarin <yury@shapkarin.me>

view details

push time in 21 hours

PR opened shapkarin/global-diff

Refactor index.js
+6 -9

0 comment

1 changed file

pr created time in 21 hours

push eventdavidyuk/global-diff

Denis Davidyuk

commit sha b11421f67823374f3168fe8d5ba183ea8d6212b4

Refactor index.js

view details

push time in 21 hours

fork davidyuk/global-diff

Compare yours window with the list of default scope.

fork in 21 hours

pull request commentaeternity/superhero-ui

Aligned vertically activity buttons on user profile

The vertical alignment of text is a tricky topic and I would like to discuss it. As I know vertical-align: middle aligns properly a string like "Xy", but "Xx" would look misaligned and I don't know a way better than defining some constant value for vertical-align. And I can't get how an extra span can help in this case.

stanislav-slavov

comment created time in a day

issue commentaeternity/superhero-ui

Reduce the amount of styles in base.scss

I have not checked the whole base.scss, maybe there is something like this. In general, I would suggest reducing the amount of global styles and to put them in corresponding components instead (marking them with scoped).

davidyuk

comment created time in a day

IssuesEvent

issue commentaeternity/superhero-ui

Reduce bundle size [lodash]

I propose to keep it open until we find the package that imported lodash into our bundle and consider an alternative to that package.

shapkarin

comment created time in a day

delete branch aeternity/superhero-wallet

delete branch : feature/move-aepp-to-tests

delete time in a day

CommitCommentEvent

issue commentaeternity/superhero-ui

Reduce bundle size

Well, as I see superhero-ui explicitly imports only lodash-es.

shapkarin

comment created time in a day

pull request commentaeternity/aepp-sdk-js

Build docs automatically using Travis

Here it is deployed on my fork: http://davidyuk.github.io/aepp-sdk-js/ Can we unbind aeternity.com from GitHub pages of this repo? Probably we will have issues because of it.

davidyuk

comment created time in a day

issue commentaeternity/superhero-ui

Reduce bundle size [lodash babel plugin]

avataaars package depends on lodash, probably because of it lodash is in our bundle

shapkarin

comment created time in a day

CommitCommentEvent

issue commentaeternity/superhero-ui

Reduce bundle size [lodash babel plugin]

why don't use lodash-es instead? it uses es6 imports/exports that can be tree shaked. So import { times } from 'lodash-es' should work fine.

shapkarin

comment created time in a day

push eventdavidyuk/aepp-sdk-js

Deployment Bot (from Travis CI)

commit sha f81ecf2ba1b272716b2156ee997045fd8fd15cfc

Deploy davidyuk/aepp-sdk-js to github.com/davidyuk/aepp-sdk-js.git:gh-pages

view details

push time in a day

issue commentaeternity/superhero-ui

Reduce the amount of styles in base.scss

Ok, does it have the sense to extract it into a separate component? I think to track component usage is easier than globally-defined classes (also unused components will be tree-shaked).

davidyuk

comment created time in a day

push eventdavidyuk/aepp-sdk-js

Denis Davidyuk

commit sha 5d8958b24d178581d10f4d2bca38a775ed44dcaa

test-else: Exclude aens tests

view details

Denis Davidyuk

commit sha 55645a9ccdbb01753c44ad75e00423aa7265a03d

Use external version of json-bigint

view details

Denis Davidyuk

commit sha 2047ea8a67ef101fcc6cdde9ac3b11b22fad73a8

Speedup jobs by building once

view details

Milen Radkov

commit sha c7a2c1332db18095786f4d2c35fc4805654d3400

Merge pull request #1033 from aeternity/feature/use-external-json-bigint Use external version of json-bigint

view details

Milen Radkov

commit sha b00d781445cc5c6c25a027aff0cbb05dfca3c30c

Merge pull request #1049 from aeternity/master Realign 7.5.0

view details

Denis Davidyuk

commit sha e91f4acf85b3c1cb2cb54d570c1027f7774a05f9

Make tests configuration more flexible - don't require keypair defined in env variables - allow to use a different keypair without changing keys

view details

Denis Davidyuk

commit sha a10f3405974797f3f472128e842fa7e82c6daa72

Merge pull request #1037 from aeternity/feature/make-tests-configs-more-flexible Make tests configuration more flexible

view details

Denis Davidyuk

commit sha e3e63149e10d8c61bb2e229a10cf2dbda5c44bc9

Merge pull request #1040 from aeternity/feature/test-else-exclude-aens test-else: Exclude aens tests and speedup jobs

view details

Denis Davidyuk

commit sha e4e391a8155eaaa5be1c0aacda557f27ad1cc9ab

Avoid unnecessary eslint-disable

view details

Denis Davidyuk

commit sha 6db2285842cfc853ed36851bc204986fab052c51

Merge pull request #1043 from aeternity/feature/avoid-unnecessary-eslint-disable Avoid unnecessary eslint-disable

view details

Denis Davidyuk

commit sha 4d87de26b1a96b5ef702f1cff1b08ad614cfb5b8

Add a 'lint' script instead of running linter on build

view details

Denis Davidyuk

commit sha 7949ec8140b8558958732ccdd37c677ac7682042

Fix linter errors automatically

view details

Denis Davidyuk

commit sha c3e5920cfab61ba92b10da7c7cc044e654fae285

Fix linter errors manually

view details

Denis Davidyuk

commit sha 2c4d73ade6d6a9faafe9975beae6af412e01671a

Update standard package to 14.3.4

view details

Denis Davidyuk

commit sha 3ded444bcb3ae2e04746b7881a66f3fe01a8e844

Merge pull request #1045 from aeternity/feature/linter-script Add lint script

view details

Denis Davidyuk

commit sha 0cdd19db8bfed8387298f65b4ef2bbe40a6a2894

rpc tests: Inline dependency used in one place

view details

Denis Davidyuk

commit sha 4827ecbbc32f973e01aa0633c53a69b5c4a7e45b

integration tests: Remove unused account2

view details

Denis Davidyuk

commit sha 78ced6c0367b308d32f3242ebf0d5823ab26503d

Refactor integration/index

view details

Denis Davidyuk

commit sha 74d25cd89bf42ea3287f8879bd29db9a52eb65a2

randomName: Generate only .chain names

view details

Denis Davidyuk

commit sha eed46480bbf5c3fe87cea2556c640dbd5b80df03

aens tests: Drop pre lima compatibility

view details

push time in a day

fork davidyuk/aepp-sdk-js

Javascript SDK for the æternity blockchain

https://dev.aepps.com/

fork in a day

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha f91faba16e94a700b4bc139d5623dcff8d499096

travis: Run linter and unit tests firstly

view details

Denis Davidyuk

commit sha 15b80756cf8f340f4b73013e5f69cfe36bdc3e09

Rebalance integration tests

view details

Denis Davidyuk

commit sha b7e0311f2ec05181c4dfdedf1b36b312f6c7313a

Merge pull request #1051 from aeternity/feature/optimise-travis travis: Run linter and unit tests firstly

view details

Denis Davidyuk

commit sha 91968df1f14d39f03dcc3c641c2b7dfa64dbc59b

Fix api docs generation

view details

Denis Davidyuk

commit sha 08706fb48d6d3b2909dd50bd41b7956739cdd5a9

Remove generated docs

view details

Denis Davidyuk

commit sha aea6ac86255d87d7b06a9a3b1a3089bc54306b9a

Move outdated disclaimer to the root readme

view details

Denis Davidyuk

commit sha b0e89594f64c6c064b5cee31e24697f7c6e94ca8

Docs root: Add link to API reference

view details

Denis Davidyuk

commit sha b49b3a11388452e713180407e31714e9bca4e091

travis: Build docs to gh-pages

view details

push time in a day

delete branch aeternity/aepp-sdk-js

delete branch : feature/optimise-travis

delete time in a day

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha f91faba16e94a700b4bc139d5623dcff8d499096

travis: Run linter and unit tests firstly

view details

Denis Davidyuk

commit sha 15b80756cf8f340f4b73013e5f69cfe36bdc3e09

Rebalance integration tests

view details

Denis Davidyuk

commit sha b7e0311f2ec05181c4dfdedf1b36b312f6c7313a

Merge pull request #1051 from aeternity/feature/optimise-travis travis: Run linter and unit tests firstly

view details

push time in a day

PR merged aeternity/aepp-sdk-js

travis: Run linter and unit tests firstly no breaking changes

The idea is to run the fastest tests firstly: linter, unit tests, and ensure that package can be built. And only if they succeed to run more heavy integration tests.

+16 -12

1 comment

2 changed files

davidyuk

pr closed time in a day

pull request commentaeternity/superhero-ui

Sticky position has 1px off the top

@stanislav-slavov for me this issue fixes after removing of this line: https://github.com/aeternity/superhero-ui/blob/cfd50e9545a63a15e205d88b3956b391452028a3/src/views/TipsList.vue#L99 what is the purpose of it?

stanislav-slavov

comment created time in a day

pull request commentaeternity/superhero-ui

Sticky position has 1px off the top

This issue should be investigated in detail. Probably it is because of overcomplicated markup.

stanislav-slavov

comment created time in a day

issue openedaeternity/superhero-ui

Reduce the amount of styles in base.scss

For instance, there defined a .filter-button that is used only in ListOfTipsAndComments

created time in a day

Pull request review commentaeternity/superhero-ui

Aligned vertically activity buttons on user profile

           @click="activity = 'channel'; activeTab = 'tips'"         >           <IconChannel />-          {{ $t('components.ListOfTipsAndComments.Channel') }}+          <span>{{ $t('components.ListOfTipsAndComments.Channel') }}</span>         </div>         <div           :class="['filter-button', { active: activity === 'activity' }]"           @click="activity = 'activity'"         >           <IconActivity />-          {{ $t('components.ListOfTipsAndComments.Activity') }}+          <span>{{ $t('components.ListOfTipsAndComments.Activity') }}</span>

is there any reason why additional span needed to enable middle alignment?

stanislav-slavov

comment created time in a day

pull request commentaeternity/aepp-sdk-js

Refactor state channels

@mradkov @thepiwo I think this one is ready for review

davidyuk

comment created time in a day

CommitCommentEvent
CommitCommentEvent

PR opened aeternity/superhero-ui

TipsPagination: Simplify infinite loading

I'm not sure that I have tested it enough carefully SImilar PR: https://github.com/aeternity/aepp-base/pull/1400

+12 -28

0 comment

1 changed file

pr created time in a day

create barnchaeternity/superhero-ui

branch : feature/simplify-infinite-load

created branch time in a day

push eventaeternity/aepp-base

Denis Davidyuk

commit sha afd4d49debc2baa531d829a21829cddfdc40a0b2

TransactionList: Fix infinite load when page is zoomed

view details

push time in a day

CommitCommentEvent

push eventaeternity/superhero-ui

Denis Davidyuk

commit sha 76929b02b84badb9a364a2c6fbece7172c6a6bcc

TipsPagination: Combine data fetching, fetch simultaneously

view details

push time in a day

create barnchaeternity/aepp-base

branch : feature/fix-zoom-scroll

created branch time in a day

Pull request review commentaeternity/superhero-ui

TipsPagination: Combine data fetching, fetch simultaneously

 export default {         this.loadingMoreTips = false;       }     },-    async reloadData() {-      this.loadingTips = true;--      this.tips = await Util.range(1, this.page)-        .asyncMap(async (page) => Backend-          .getCacheTips(this.tipSortBy, page, this.address, this.search, this.blacklist));

@thepiwo Was it intentional to make these requests one by one instead of doing them at the same time? I don't think that something can go wrong if the client will request them at the same time, except it has 100 pages opened or so. Also, it can be handled by the backend allowing to accept page range.

davidyuk

comment created time in a day

create barnchaeternity/superhero-ui

branch : feature/refactor-tips-pagination

created branch time in a day

issue openedaeternity/superhero-ui

Add Not found (404) page

Currently, it is just a black screen

created time in a day

issue openedaeternity/superhero-ui

Navigation: Avoide useless div wrappers

https://github.com/aeternity/superhero-ui/blob/73e379eb40d49758a8d3dd87b0219aaaeec8515b/src/components/layout/Navigation.vue#L3-L52

created time in a day

CommitCommentEvent

create barnchaeternity/superhero-wallet

branch : feature/move-aepp-to-tests

created branch time in 2 days

delete branch aeternity/aepp-sdk-js

delete branch : release/7.5.0

delete time in 2 days

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha 15b80756cf8f340f4b73013e5f69cfe36bdc3e09

Rebalance integration tests

view details

push time in 2 days

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha 42f27284b1247af468cba468e3e4b337bc05b721

Rebalance integration tests

view details

push time in 2 days

delete branch aeternity/aepp-sdk-js

delete branch : test-exec-time

delete time in 2 days

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha 787caeb8ab7657359a56fc21e6810c672b056b45

Rebalance integration tests

view details

push time in 2 days

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha 5f96843775e3a89c6d28fa4dc78e6250ff72038c

Integration tests execution time

view details

push time in 2 days

create barnchaeternity/aepp-sdk-js

branch : test-exec-time

created branch time in 2 days

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha a02f0c2bb0ad33e01fc5853e367180d7abfeb02c

Remove generated docs

view details

Denis Davidyuk

commit sha 2f8de690494a9622c1587ed302c6bf4f4f774d90

Move outdated disclaimer to the root readme

view details

Denis Davidyuk

commit sha 34967355c23a8beb737535dbf9c5503c1336d0f1

Docs root: Add link to API reference

view details

Denis Davidyuk

commit sha 790597c5ee2338f3b14a37fdb135943c2012bd4e

travis: Build docs to gh-pages

view details

push time in 2 days

create barnchaeternity/aepp-sdk-js

branch : gh-pages

created branch time in 2 days

create barnchaeternity/aepp-sdk-js

branch : feature/build-docs-automatically

created branch time in 2 days

push eventdavidyuk/aepp-sdk-js

push time in 2 days

push eventdavidyuk/aepp-sdk-js

Denis Davidyuk

commit sha 7efdcce7211b08607cd1c724c47b85a9be6034b2

travis: Build docs to gh-pages

view details

push time in 2 days

push eventaeternity/aepp-sdk-js

Denis Davidyuk

commit sha f1915b907a7ea908ddcffa73d1be496f666daaf6

Rebalance integration tests

view details

push time in 2 days

push eventdavidyuk/aepp-sdk-js

Deployment Bot (from Travis CI)

commit sha b3c8bbe9852c896b8c968418ad1b609e8ceec209

Deploy davidyuk/aepp-sdk-js to github.com/davidyuk/aepp-sdk-js.git:gh-pages

view details

push time in 2 days

push eventdavidyuk/aepp-sdk-js

Denis Davidyuk

commit sha 285c7cec85023840a9da8a943872721cac5aa92d

travis: Build docs to gh-pages

view details

push time in 2 days

create barnchaeternity/aepp-sdk-js

branch : feature/optimise-travis

created branch time in 2 days

push eventdavidyuk/aepp-sdk-js

Denis Davidyuk

commit sha be6b1fd01542efc38c724c0026fceaada8c33fe5

travis: Build docs to gh-pages

view details

push time in 2 days

push eventdavidyuk/aepp-sdk-js

Denis Davidyuk

commit sha 5d8958b24d178581d10f4d2bca38a775ed44dcaa

test-else: Exclude aens tests

view details

Denis Davidyuk

commit sha 55645a9ccdbb01753c44ad75e00423aa7265a03d

Use external version of json-bigint

view details

Denis Davidyuk

commit sha 2047ea8a67ef101fcc6cdde9ac3b11b22fad73a8

Speedup jobs by building once

view details

Milen Radkov

commit sha c7a2c1332db18095786f4d2c35fc4805654d3400

Merge pull request #1033 from aeternity/feature/use-external-json-bigint Use external version of json-bigint

view details

Milen Radkov

commit sha b00d781445cc5c6c25a027aff0cbb05dfca3c30c

Merge pull request #1049 from aeternity/master Realign 7.5.0

view details

Denis Davidyuk

commit sha e91f4acf85b3c1cb2cb54d570c1027f7774a05f9

Make tests configuration more flexible - don't require keypair defined in env variables - allow to use a different keypair without changing keys

view details

Denis Davidyuk

commit sha a10f3405974797f3f472128e842fa7e82c6daa72

Merge pull request #1037 from aeternity/feature/make-tests-configs-more-flexible Make tests configuration more flexible

view details

Denis Davidyuk

commit sha e3e63149e10d8c61bb2e229a10cf2dbda5c44bc9

Merge pull request #1040 from aeternity/feature/test-else-exclude-aens test-else: Exclude aens tests and speedup jobs

view details

Denis Davidyuk

commit sha e4e391a8155eaaa5be1c0aacda557f27ad1cc9ab

Avoid unnecessary eslint-disable

view details

Denis Davidyuk

commit sha 6db2285842cfc853ed36851bc204986fab052c51

Merge pull request #1043 from aeternity/feature/avoid-unnecessary-eslint-disable Avoid unnecessary eslint-disable

view details

Denis Davidyuk

commit sha 4d87de26b1a96b5ef702f1cff1b08ad614cfb5b8

Add a 'lint' script instead of running linter on build

view details

Denis Davidyuk

commit sha 7949ec8140b8558958732ccdd37c677ac7682042

Fix linter errors automatically

view details

Denis Davidyuk

commit sha c3e5920cfab61ba92b10da7c7cc044e654fae285

Fix linter errors manually

view details

Denis Davidyuk

commit sha 2c4d73ade6d6a9faafe9975beae6af412e01671a

Update standard package to 14.3.4

view details

Denis Davidyuk

commit sha 3ded444bcb3ae2e04746b7881a66f3fe01a8e844

Merge pull request #1045 from aeternity/feature/linter-script Add lint script

view details

Denis Davidyuk

commit sha 0cdd19db8bfed8387298f65b4ef2bbe40a6a2894

rpc tests: Inline dependency used in one place

view details

Denis Davidyuk

commit sha 4827ecbbc32f973e01aa0633c53a69b5c4a7e45b

integration tests: Remove unused account2

view details

Denis Davidyuk

commit sha 78ced6c0367b308d32f3242ebf0d5823ab26503d

Refactor integration/index

view details

Denis Davidyuk

commit sha 74d25cd89bf42ea3287f8879bd29db9a52eb65a2

randomName: Generate only .chain names

view details

Denis Davidyuk

commit sha eed46480bbf5c3fe87cea2556c640dbd5b80df03

aens tests: Drop pre lima compatibility

view details

push time in 2 days

push eventdavidyuk/aepp-sdk-js

Denis Davidyuk

commit sha affa4afe395f3a62a29381c2c2e3d6ee683f1c5c

Set theme jekyll-theme-architect

view details

push time in 2 days

push eventdavidyuk/aepp-sdk-js

Denis Davidyuk

commit sha df2419c2120e8b63b9c9b5d754dc73888bd29a45

Set theme jekyll-theme-leap-day

view details

push time in 2 days

push eventdavidyuk/aepp-sdk-js

Denis Davidyuk

commit sha 99ed844412d9bf7fe92005706f5874f0dc56ee9d

Set theme jekyll-theme-hacker

view details

push time in 2 days

create barnchdavidyuk/aepp-sdk-js

branch : gh-pages

created branch time in 2 days

more