profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/davidhemphill/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
David Hemphill davidhemphill Laravel Nova Springfield, MO http://davidhemphill.com Co-created Laravel Nova and Tailwind CSS.

adamwathan/sublime-phpunit 278

Run individual unit test files directly from Sublime

bdkjones/CodeKit2 100

CodeKit 2 Beta

andrewdelprete/babel-plugin-tailwind 53

Transform TailwindCSS classes to CSS-in-JS at build time

davidhemphill/postcss-verthorz 18

PostCSS plugin to add vertical and horizontal spacing rules

andrewdelprete/neckbeard 6

An Atomic CSS in JS framework for people with better things to do

monarkee/postcss-copy-class 1

PostCSS plugin to allow a class to copy another's declarations into itself

issue closedlaravel/nova-issues

New Relation::enforceMorphMap causes error when attaching resource via pivot

  • Laravel Version: 5.60.0
  • Nova Version: 3.29.0
  • PHP Version: 7.4
  • Database Driver & Version: MySql 8

TL;DR

Getting this exception on a belongsToMany relation via pivot after switching to Relation::enforceMorphMap as there isn't a mapping for Illuminate\Database\Eloquent\Relations\Pivot?!

Illuminate\Database\ClassMorphViolationException: No morph map defined for model 
[Illuminate\Database\Eloquent\Relations\Pivot]. 
in /vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasRelationships.php:736
Stack trace:
#0 /vendor/laravel/nova/src/Actions/ActionEvent.php(132): Illuminate\Database\Eloquent\Model->getMorphClass()
#1 /vendor/laravel/nova/src/Http/Controllers/ResourceAttachController.php(41): Laravel\Nova\Actions\ActionEvent::forAttachedResource(Object(Laravel\Nova\Http\Requests\NovaRequest), Object(App\Models\Admin), Object(Illuminate\Database\Eloquent\Relations\Pivot))
#2 /vendor/laravel/framework/src/Illuminate/Database/Concerns/ManagesTransactions.php(29): Laravel\Nova\Http\Controllers\ResourceAttachController->Laravel\Nova\Http\Controllers\{closure}(Object(Illuminate\Database\MySqlConnection))
#3 /vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php(388): Illuminate\Database\Connection->transaction(Object(Closure))
#4 /vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php(261): Illuminate\Database\DatabaseManager->__call('transaction', Array)
#5 /vendor/laravel/nova/src/Http/Controllers/ResourceAttachController.php(46): Illuminate\Support\Facades\Facade::__callStatic('transaction', Array)

Description:

Laravel PR of change merged: https://github.com/laravel/framework/pull/38656 Laravel version released in 8.59.0

Docs were changed to suggest only using this method: https://laravel.com/docs/8.x/eloquent-relationships#custom-polymorphic-types

If you use the old Relation::morphMap this works fine still, however, to be strict about morph types it seems that it is now recommended to switch to Relation::enforceMorphMap

Detailed steps to reproduce the issue on a fresh Nova installation:

See the example structure and code below taken from laravel docs: https://laravel.com/docs/8.x/eloquent-relationships#many-to-many

If you try and attach a role to the user in nova with this setup you will get the above error.

Structure

users
    id - integer
    name - string

roles
    id - integer
    name - string

role_user
    user_id - integer
    role_id - integer

Model

class User extends Model
{
    public function roles()
    {
        return $this->belongsToMany(Role::class);
    }
}

AppServiceProvider@register - Relation::enforceMorphMap:

Relation::enforceMorphMap([]);

App/Nova/UserResource@fields

BelongsToMany::make('Roles', 'roles', RoleResource::class)

Workaround

Add pivot classes to morph map:

Relation::enforceMorphMap([
    MorphPivot::class => MorphPivot::class,
    Pivot::class => Pivot::class,
]);

Note: I believe that a polymorphic pivot will have the same error with resolving the MorphPivot class and will need to have the same fix as this error.

Conclusion

It seems that the ActionEvent::forAttachedResource is getting Illuminate\Database\Eloquent\Relations\Pivot as the $pivot rather than a model and calls getMorphClass() on it which errors as it doesn't exist in the enforced morph map.

closed time in 3 days

dmason30

issue commentlaravel/nova-issues

New Relation::enforceMorphMap causes error when attaching resource via pivot

👋 Hi there! In order to keep this repository focused on bug reports, we auto-close feature requests and requests for help. Feel free to post your feature requests so others can discuss and add reactions. We'll keep an eye on them for later planning.

dmason30

comment created time in 3 days

fork davidhemphill/candy-machine-mint

Fork, config, customize and ship your own candy machine mint app on your own domain, ultra fast.

fork in 4 days

push eventdavidhemphill/metaplex

Alice

commit sha a2c2c7eb7e1eafbeed6cfcd6f12be32ebb972391

remove eth package

view details

B

commit sha ac567992202e00a88bdc5244c8909f38c5dfe801

Merge pull request #369 from 21e8/remove-eth-use-wallet remove `use-wallet` eth package

view details

Rad

commit sha 76de057a0ce0c436f42cdd1027fef1469daf4bb2

another overhaul (#337) * another overhaul - added backend signing for a single metadata id - some small refactoring - extracted upload from the CLI (maybe will do the same with other methods) * optimized logging in the CLI - logging now has levels - added more readme content * eslint update

view details

push time in 5 days

issue commentlaravel/nova-issues

Please show "Your session expired!" when I hit create a resource button and not after I hit submit button.

👋 Hi there! In order to keep this repository focused on bug reports, we auto-close feature requests and requests for help. Feel free to post your feature requests so others can discuss and add reactions. We'll keep an eye on them for later planning.

hasnatwe

comment created time in 5 days

issue closedlaravel/nova-issues

Please show "Your session expired!" when I hit create a resource button and not after I hit submit button.

So my web browser remains open most of the time with hibernation. Is there a way to show session expired when I hit submit button during resource creation? After filling long list of fields when I see I need to reload then all effort is just gone.

closed time in 5 days

hasnatwe

startedtextury/permaweb-dropper

started time in 7 days

issue commentlaravel/nova-issues

Boolean field shows as `false` when the underlying column is `null`

👋 Hi there! In order to keep this repository focused on bug reports, we auto-close feature requests and requests for help. Feel free to post your feature requests so others can discuss and add reactions. We'll keep an eye on them for later planning.

chescos

comment created time in 9 days

push eventdavidhemphill/metaplex

Jordan Prince

commit sha 0b064b6df49eb5b94f21796a1b04d223a921f16d

Fix 10k error (#287)

view details

Jordan Prince

commit sha 14401e878d36cac16c0ba4e6b606420c29eeed08

feat: mint editions into wallet (#289) feat(ArtMinting): add mint destination address validation feat(ArtMinting): add cofetti feat(ArtMinting): add remounting logic chore(mint editions): upodate types chore(art minting): update imports Co-authored-by: shotgunofdeath <42133844+shotgunofdeath@users.noreply.github.com>

view details

Jordan Prince

commit sha 2bcd97ac04bcb70e36bc3de0bbfb22e552863393

minor fix to type declaration (#291)

view details

Jordan Prince

commit sha 0ba4954762c8ad7a7802cbb03268fce5de932b40

Wallet adapter fix (#292) * minor fix to type declaration * Some more typescript fixes

view details

Jordan Prince

commit sha 40cfa295117d50dbf2593b81b9c63f0fcf22a17b

A few candy machine fixes - to uploader and program (#304)

view details

Armani Ferrante

commit sha e0f2c1b0689178585517e6c6dd080104887f9955

Update candy machine with anchor v0.14.0 (#283)

view details

Efremov Alexey

commit sha f27ffb39a7386e25b8ec78037c49a9a37d176c69

Fix: eslint configuration + fix and reformat existing code + eslint as step for lint-staged I

view details

Efremov Alexey

commit sha b3e2808e7a2dcb206b8ab3ac5a0d06463873f79a

Add: github action for linting

view details

Efremov Alexey

commit sha ba7bd508dca80e28126b76b5b9648eafe8237ece

Add: github action for linting

view details

Efremov Alexey

commit sha 91b613dbc7cc102bd900c3f31f47dbcc1bef7f29

Add: github action for linting

view details

Efremov Alexey

commit sha 908ece91b6a7184e8d8782be1ccaca3587f8d0d8

Add: github action for linting

view details

Efremov Alexey

commit sha 137ff3baf7451efa6e320483c290e693eb4cd803

Update .github/workflows/lint.yml Co-authored-by: Sergey Ponomarev <me@sergey-ponomarev.ru>

view details

Efremov Alexey

commit sha baa8d36117b2705e0ad3bf5b50c412bc16921ad7

Turn on lint for PR and master

view details

Efremov Alexey

commit sha 542d2a7b0fce29701033891100fd6656e8ea731d

change working dirs paths

view details

Efremov Alexey

commit sha c0bba430b865d28fac1cec6a8ea0c5cb2ad8970e

update

view details

B

commit sha 9d5a5c6d668cd9c597cff8c63dfba00dee2f72f0

Merge pull request #253 from lexich/lexich/fix-eslint

view details

B

commit sha e529eee3d5a823965eea603b267777f2e8c1a995

Add env option to bundler (#320) * feature: add env to cli * fix: format

view details

Bertrand

commit sha 929a5e269736147b58d846c0398c9804ddb407a4

allow float price (#321)

view details

Jordan Prince

commit sha 4a1b7d2f674013bc8bd3149294c66b03b27120d0

Feat/metaplex cli overhaul merged (#334) * feat: candy-machine cli overhaul, so it's more readable - extracted constants - separated some helpers out - removed duplication of crucial parts (like cache management, instruction creation, etc) - renamed some variables to make them more accurate - added `env` option and removed `url` option - used env in all operations - added some error handling * more cleanups * Add env option to bundler (#320) * feature: add env to cli * fix: format * more cleanups * added error checking * eslint updates * Some small bugfixes Co-authored-by: Radoslaw Domanski <woohaas@gmail.com> Co-authored-by: B <264380+bartosz-lipinski@users.noreply.github.com>

view details

push time in 10 days

push eventdavidhemphill/metaplex

Jordan Prince

commit sha f11659cb43f65effae2f471d5c9b09266cdd4fa8

H (#260) * Adding candy machine * Still working on stuff * Commit where is top using anchor * Working on candy machine * Continue working on candy machine * Still working * Completely reasonable failure * Completely unreasonable failure * Finally, we have uploading configs and tests * Add uuid support to candy machines so candy machine can rerun with same config * feat: init cli * Got minting now bro. All downhill from here. * All done * Chang eaddress * Minor fix to anchor settings * feat: integrate candy * feat: cli upload * Heck yeah. Switch out the pda for a non pda to allow for alrger allocs * Send authority to candy machine authority if retain authority is true * feat: add add congif lines * Forgotten conflict * Rewire CLI to chunkify and add verification * Current changes * Client finished * Fuckin bitmasks bro * Fix metadata client * Working on cli * Fixed the healing loop * here we go. * Fix the error that caused price to be 1 instead of 5 Co-authored-by: bartosz-lipinski <264380+bartosz-lipinski@users.noreply.github.com>

view details

adamjeffries

commit sha 1a9c20008275cbe5487be8c87f7363554f3fd57a

Accept SVG image upload

view details

Adam Jeffries

commit sha 5bd305339b5b2e87a877dc423d121436dbb13b98

Update README.md

view details

nftintern

commit sha e2acaae9f22d521cbd63246f288cce61f38e52ca

correction: tx -> tx['txid']; also remove duplicate @solana/web3.js package that was causing name collision (#270)

view details

Kelvin Jayanoris

commit sha 7225e58ffacaca8f479a7bfac9346a396d71cabe

Make the payer writeable in create_metadata_accounts (#248) This wallet (the payer) needs to be mutable because funds are going to be drawn from it during the processing of the instruction.

view details

0xsolsurfer

commit sha 06534bf5bec431a4b43dfeff95b0e84e69fc420d

Update deploy.md for Vercel deploys (#247) Updates deploy.md to include a missing step, enabling Vercel deploys using next.js.

view details

Jordan Prince

commit sha f98142b182aa4c1c5895cebd3430b564da2b567b

Update .env

view details

Slavomir

commit sha c09c96e58c5ec9fc5bb66b49f626192956c96aae

Fix Anchor.toml (#272)

view details

lpeace

commit sha 9d9d9d93b105bb3aa441bb7295ed5540cb3749f2

Fix example link (#252)

view details

Koenrad MacBride

commit sha 617d197e8433322a6e625929f6c9402c642247d2

Fix/candy machine cli (#280) * fix: stringify tx object * add: log the CM publicKey * mod: mine_one_token ty Dad! * remove: built js file (i m smurt)

view details

push time in 15 days

issue closedlaravel/nova-issues

BelongsToMany allowDuplicateRelations rule "NotExactlyAttached" doesn't filter out computed fields

  • Laravel Version: 8.58
  • Nova Version: 3.29.0
  • PHP Version: 7.4

Description:

BelongsToMany field has a method "allowDuplicateRelations" which adds the rule "NotExactlyAttached" to the field.

The rules passes() method gets the fields like so:

$resource->resolvePivotFields($this->request, $this->request->relatedResource)
  ->each(function ($field) use ($query) {
    $query->wherePivot($field->attribute, $this->request->input($field->attribute));
  });

But it does not filter out fields that are computed, so the final query will contain clauses like table_name.ComputedField IS NULL and the query will fail as the column ComputedField does not exist.

Detailed steps to reproduce the issue on a fresh Nova installation:

Create a BelongsToMany relationship with a computed field.

BelongsToMany::make('Attributes', 'productAttributes')
    ->fields(function () {
        return [
            Text::make('Value', function ($resource) {
                return $resource->value;
            })->onlyOnIndex(),
        ];
    })
    ->allowDuplicateRelations(),

closed time in 15 days

Tarpsvo

issue commenttighten/nova-package-development

Clone Feature Package Idea

This is coming in the next series.

tvoitik

comment created time in 16 days

push eventlaravel/nova-js

dependabot[bot]

commit sha c15600b63901486577218c01d0bb935fd995647b

Bump lodash from 4.17.19 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.19...4.17.21) --- updated-dependencies: - dependency-name: lodash dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

David Hemphill

commit sha bb099df7cffdae4a8a4a31eec9babd03b34b932d

Merge pull request #54 from laravel/dependabot/npm_and_yarn/lodash-4.17.21 Bump lodash from 4.17.19 to 4.17.21

view details

push time in 16 days

PR merged laravel/nova-js

Bump lodash from 4.17.19 to 4.17.21 dependencies

Bumps lodash from 4.17.19 to 4.17.21. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/f299b52f39486275a9e6483b60a410e06520c538"><code>f299b52</code></a> Bump to v4.17.21</li> <li><a href="https://github.com/lodash/lodash/commit/c4847ebe7d14540bb28a8b932a9ce1b9ecbfee1a"><code>c4847eb</code></a> Improve performance of <code>toNumber</code>, <code>trim</code> and <code>trimEnd</code> on large input strings</li> <li><a href="https://github.com/lodash/lodash/commit/3469357cff396a26c363f8c1b5a91dde28ba4b1c"><code>3469357</code></a> Prevent command injection through <code>_.template</code>'s <code>variable</code> option</li> <li><a href="https://github.com/lodash/lodash/commit/ded9bc66583ed0b4e3b7dc906206d40757b4a90a"><code>ded9bc6</code></a> Bump to v4.17.20.</li> <li><a href="https://github.com/lodash/lodash/commit/63150ef7645ac07961b63a86490f419f356429aa"><code>63150ef</code></a> Documentation fixes.</li> <li><a href="https://github.com/lodash/lodash/commit/00f0f62a979d2f5fa0287c06eae70cf9a62d8794"><code>00f0f62</code></a> test.js: Remove trailing comma.</li> <li><a href="https://github.com/lodash/lodash/commit/846e434c7a5b5692c55ebf5715ed677b70a32389"><code>846e434</code></a> Temporarily use a custom fork of <code>lodash-cli</code>.</li> <li><a href="https://github.com/lodash/lodash/commit/5d046f39cbd27f573914768e3b36eeefcc4f1229"><code>5d046f3</code></a> Re-enable Travis tests on <code>4.17</code> branch.</li> <li><a href="https://github.com/lodash/lodash/commit/aa816b36d402a1ad9385142ce7188f17dae514fd"><code>aa816b3</code></a> Remove <code>/npm-package</code>.</li> <li>See full diff in <a href="https://github.com/lodash/lodash/compare/4.17.19...4.17.21">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~bnjmnt4n">bnjmnt4n</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -5

0 comment

1 changed file

dependabot[bot]

pr closed time in 16 days

push eventlaravel/nova-js

dependabot[bot]

commit sha 88e48ed620bb988c220f74787128e79da3a6dbb6

Bump ws from 5.2.2 to 5.2.3 Bumps [ws](https://github.com/websockets/ws) from 5.2.2 to 5.2.3. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/5.2.2...5.2.3) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

David Hemphill

commit sha 115efcf67668d02caafdd9d6399008d65cba65d0

Merge pull request #53 from laravel/dependabot/npm_and_yarn/ws-5.2.3 Bump ws from 5.2.2 to 5.2.3

view details

push time in 16 days

PR merged laravel/nova-js

Bump ws from 5.2.2 to 5.2.3 dependencies

Bumps ws from 5.2.2 to 5.2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/websockets/ws/releases">ws's releases</a>.</em></p> <blockquote> <h2>5.2.3</h2> <h1>Bug fixes</h1> <ul> <li>Backported 00c425ec to the 5.x release line (76d47c14).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/websockets/ws/commit/6dd88e7e968ef2416445d8f8620c17d99b15c77c"><code>6dd88e7</code></a> [dist] 5.2.3</li> <li><a href="https://github.com/websockets/ws/commit/76d47c1479002022a3e4357b3c9f0e23a68d4cd2"><code>76d47c1</code></a> [security] Fix ReDoS vulnerability</li> <li>See full diff in <a href="https://github.com/websockets/ws/compare/5.2.2...5.2.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 16 days

push eventlaravel/nova-js

dependabot[bot]

commit sha 6d6502e173fc09697a71234bb34a564f3a488a4e

Bump path-parse from 1.0.6 to 1.0.7 Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

David Hemphill

commit sha 6f1a71b13079fea1ae8cec6cc3f163467368bb4c

Merge pull request #51 from laravel/dependabot/npm_and_yarn/path-parse-1.0.7 Bump path-parse from 1.0.6 to 1.0.7

view details

push time in 16 days

PR merged laravel/nova-js

Bump path-parse from 1.0.6 to 1.0.7 dependencies

Bumps path-parse from 1.0.6 to 1.0.7. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/jbgutierrez/path-parse/commits/v1.0.7">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 16 days

PR merged laravel/nova-js

Bump dns-packet from 1.3.1 to 1.3.4 dependencies

Bumps dns-packet from 1.3.1 to 1.3.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mafintosh/dns-packet/commit/ebdf849da5dc0d96836e87628349776c623c5be7"><code>ebdf849</code></a> 1.3.4</li> <li><a href="https://github.com/mafintosh/dns-packet/commit/ac578722f2707310b841b65aae61d6332f8882a1"><code>ac57872</code></a> move all allocUnsafes to allocs for easier maintenance</li> <li><a href="https://github.com/mafintosh/dns-packet/commit/c64c9507e51532c9e9a3cbefa146a134ecc025fd"><code>c64c950</code></a> 1.3.3</li> <li><a href="https://github.com/mafintosh/dns-packet/commit/0598ba19d18da4568b32415e60a9629061b3c45c"><code>0598ba1</code></a> fix .. in encodingLength</li> <li><a href="https://github.com/mafintosh/dns-packet/commit/010aedb33c1ee8c3f558db5249c1d46e2bd7a101"><code>010aedb</code></a> 1.3.2</li> <li><a href="https://github.com/mafintosh/dns-packet/commit/0d0d593f8df4e2712c43957a6c62e95047f12b2d"><code>0d0d593</code></a> backport encodingLength fix to v1</li> <li>See full diff in <a href="https://github.com/mafintosh/dns-packet/compare/v1.3.1...v1.3.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -2

0 comment

1 changed file

dependabot[bot]

pr closed time in 16 days

push eventlaravel/nova-js

dependabot[bot]

commit sha 38143084aa5f04573cdf02a0af063e1136e90f3f

Bump dns-packet from 1.3.1 to 1.3.4 Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4. - [Release notes](https://github.com/mafintosh/dns-packet/releases) - [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md) - [Commits](https://github.com/mafintosh/dns-packet/compare/v1.3.1...v1.3.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

David Hemphill

commit sha 2906e1a5c7d63973acf4c9e2f538ce46241c558e

Merge pull request #49 from laravel/dependabot/npm_and_yarn/dns-packet-1.3.4 Bump dns-packet from 1.3.1 to 1.3.4

view details

push time in 16 days

issue closedlaravel/nova-issues

Pivot fields are not shown on overview when using multiple BelongsToMany relationships for same model

  • Laravel Version: 8.56.0
  • Nova Version: 3.29.0
  • PHP Version: 7.3.29
  • Database Driver & Version: mysql 10.2.33 MariaDB
  • Operating System and Version: MacOS Big Sur 11.5.2
  • Browser type and version: Google Chrome 92.0.4515.159
  • Reproduction Repository: https://github.com/sgerritsen/nova-multiple-belongsToMany-relations-bug

Description:

I have 2 models (Application and PartnerSchool) which are connected via two BelongsToMany relationships (partnerSchools() and selectedDestination()). Each relationship has its own pivot table (application_partner_schools and selected_destinations) and therefore its own pivot fields.

Model/Application relationships: image

Model/PartnerSchool relationship: image

1

The first problem is that the pivot fields of the relationships shown on the Nova/Application are determined by the fields() method on the Nova/PartnerSchool model. This is counterintuitive, since I would expect the fields() method on the Nova/Application model to determine which pivot fields are shown on the Application detail page, not the fields() method on the Nova/PartnerSchool.

Nova/Application model: image

Nova/PartnerSchool model: image

Result on Nova/Application detail: image

2

The second issue is that when I add the second BelongToMany relationship (selectedDestination()) to the Nova/Application detail page, that it only the pivot field from the partnerSchools() (order). When I then try to add the relationship to the Nova/PartnerSchool and add the pivot field (selected) in the fields() method, then none of the pivot fields are shown on the Application detail page.

Nova/Application model: image

Nova/PartnerSchool model: image

Result on Nova/Application detail for selected destination: image

Result on Nova/Application detail for partner schools: image

PS: The fact that selectedDestination() is singular is intentional.

Detailed steps to reproduce the issue on a fresh Nova installation:

  1. Create 2 models.
  2. Make 2 BelongsToMany relationships using separate pivot tables, each with their own pivot fields.
  3. Add the BelongsToMany relationships to the Nova models fields() methods.
  4. Watch the bug unfold.

closed time in 16 days

sgerritsen

push eventlaravel/nova-js

dependabot[bot]

commit sha fb6b0862262b1a28c97b1e9ba64bf1a12cf6cad1

Bump tar from 4.4.4 to 4.4.19 Bumps [tar](https://github.com/npm/node-tar) from 4.4.4 to 4.4.19. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/node-tar/compare/v4.4.4...v4.4.19) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

David Hemphill

commit sha 57a6f706e9b79725bc0f2ec2bf86eed315e0d807

Merge pull request #52 from laravel/dependabot/npm_and_yarn/tar-4.4.19 Bump tar from 4.4.4 to 4.4.19

view details

push time in 16 days

PR merged laravel/nova-js

Bump tar from 4.4.4 to 4.4.19 dependencies

Bumps tar from 4.4.4 to 4.4.19. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/node-tar/commit/9a6faa017ca90538840f3ae2ccdb4550ac3f4dcf"><code>9a6faa0</code></a> 4.4.19</li> <li><a href="https://github.com/npm/node-tar/commit/70ef812593184cc54ea1bc74c5dae2d22995002d"><code>70ef812</code></a> drop dirCache for symlink on all platforms</li> <li><a href="https://github.com/npm/node-tar/commit/3e35515c09da615ac268254bed85fe43ee71e2f0"><code>3e35515</code></a> 4.4.18</li> <li><a href="https://github.com/npm/node-tar/commit/52b09e309bcae0c741a7eb79a17ef36e7828b946"><code>52b09e3</code></a> fix: prevent path escape using drive-relative paths</li> <li><a href="https://github.com/npm/node-tar/commit/bb93ba243746f705092905da1955ac3b0509ba1e"><code>bb93ba2</code></a> fix: reserve paths properly for unicode, windows</li> <li><a href="https://github.com/npm/node-tar/commit/2f1bca027286c23e110b8dfc7efc10756fa3db5a"><code>2f1bca0</code></a> fix: prune dirCache properly for unicode, windows</li> <li><a href="https://github.com/npm/node-tar/commit/9bf70a8cf725c3af5fe2270f1e5d2e06d1559b93"><code>9bf70a8</code></a> 4.4.17</li> <li><a href="https://github.com/npm/node-tar/commit/6aafff0a8621ba9509b63654bde28762be373d58"><code>6aafff0</code></a> fix: skip extract if linkpath is stripped entirely</li> <li><a href="https://github.com/npm/node-tar/commit/5c5059a69c2aaaedfe4e9766e102ae9fb79e8255"><code>5c5059a</code></a> fix: reserve paths case-insensitively</li> <li><a href="https://github.com/npm/node-tar/commit/fd6accba697070560f301604b8f5f7e2995a2a8b"><code>fd6accb</code></a> 4.4.16</li> <li>Additional commits viewable in <a href="https://github.com/npm/node-tar/compare/v4.4.4...v4.4.19">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+44 -36

0 comment

1 changed file

dependabot[bot]

pr closed time in 16 days

issue closedlaravel/nova-issues

DateTime field 24 hour issue.

  • Laravel Version: 8x
  • Nova Version: 2x
  • PHP Version: 8x

I've seen an old issue relating to this with a solution but it was closed due to them not having a registered version of nova. However I believe the issue still exists as I don't see any mention of it in the documentation.

Here is the issue: https://github.com/laravel/nova-issues/issues/1069

Basically there is no way to set the calendar popup to display as 24hours even when the format for the dates shown in the field can be set to 24 hours which is a little unusual from a users perspective. Please allows us to pass the variables to the picker so we have full control of the date format in the picker modal.

closed time in 17 days

latwelve

issue commentlaravel/nova-issues

DateTime field 24 hour issue.

👋 Hi there! In order to keep this repository focused on bug reports, we auto-close feature requests and requests for help. Feel free to post your feature requests so others can discuss and add reactions. We'll keep an eye on them for later planning.

latwelve

comment created time in 17 days

issue commentlaravel/nova-issues

Upload/Attach file button in Trix always appears

Please open a new issue and fill out the required details in the issue template. Thanks!

XternalSoft

comment created time in 17 days

issue commentlaravel/nova-issues

Mongodb: Broken search

Your best course of action is to take it up with https://github.com/laravel/framework. We only plan on supporting Laravel's official database drivers for the foreseeable future. If Mongo makes it into core, we'd be glad to make whatever changes we need to make it work with Nova. 👍

simonschaufi

comment created time in 19 days

issue closedlaravel/nova-issues

Customisable currency in Currency action field

Hi there,

Apologies if duplicate. I think this is different to #2534 if I'm reading correctly.

With currency fields, you can specify the display currency for an action in the form of

Currency::make('Price')->currency('EUR'),

or leave currency() empty and it'll default to the nova.currency value (USD otherwise). There don't seem to be any options to be able to customise the currency in this field, e.g.

$currencies = ['EUR', 'GBP', 'USD'];
Currency::make('Price')->currency($currencies);

A workaround I'm using now is have a separate Select for the currencies and then overriding the currency based on that selection, but in the UI the currency symbol won't update because of this.

Could this be done, or something like having a dynamically updating currency field based on another field?

closed time in 21 days

nikolaos-spyratos