profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/danielbankhead/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Daniel Bankhead danielbankhead @Google San Francisco https://danielbankhead.com Entrepreneur. Engineer. Photographer.

danielbankhead/bronze 9

Collision-resistant ids for distributed systems

danielbankhead/jetta 6

A powerful, multi-protocol request library and toolkit ✈️

danielbankhead/curl 0

A command line tool and library for transferring data with URL syntax, supporting HTTP, HTTPS, FTP, FTPS, GOPHER, TFTP, SCP, SFTP, SMB, TELNET, DICT, LDAP, LDAPS, FILE, IMAP, SMTP, POP3, RTSP and RTMP. libcurl offers a myriad of powerful features

danielbankhead/danielbankhead 0

Daniel Bankhead

danielbankhead/git-branching-model 0

A welcoming git branching model.

danielbankhead/shields 0

Shields badge specification, website and default API server

PR merged googleapis/nodejs-storage

Reviewers
refactor: Unify precondition retry logic cla: yes api: storage
+28 -14

0 comment

1 changed file

danielbankhead

pr closed time in 4 days

push eventgoogleapis/nodejs-storage

Daniel Bankhead

commit sha 746420ec1a4d0c39a4becddb0d5dba26fe812f8a

refactor: Unify precondition retry logic (#1660) * refactor: Unify retry logic * refactor: Use `PreconditionOptions` for determining if a request should be retried * refactor: Rename `shouldRetryRequest` to `shouldRetryBasedOnPreconditionAndIdempotencyStrat` * docs: Method should be used for `ifGenerationMatch` We can extend the function when we require `IfMetagenerationMatch` checking in this class

view details

push time in 4 days

delete branch googleapis/nodejs-storage

delete branch : unify-retry-logic

delete time in 4 days

push eventgoogleapis/nodejs-storage

Denis DelGrosso

commit sha 760231ca520f4eedf878c245489cb07f95e153af

fix: check generation on source files not metageneration on bucket (#1654)

view details

release-please[bot]

commit sha b9bda1e89bf24a3acb8f36d3f8a36f35a23bccd2

chore: release 5.15.1 (#1655) :robot: I have created a release \*beep\* \*boop\* --- ### [5.15.1](https://www.github.com/googleapis/nodejs-storage/compare/v5.15.0...v5.15.1) (2021-10-12) ### Bug Fixes * check generation on source files not metageneration on bucket ([#1654](https://www.github.com/googleapis/nodejs-storage/issues/1654)) ([760231c](https://www.github.com/googleapis/nodejs-storage/commit/760231ca520f4eedf878c245489cb07f95e153af)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

view details

Denis DelGrosso

commit sha 6b7a06defe1a3cadc6fad9258ff3fb01a2ecce0a

fix: remove bucket preconditions from deleteFiles, it is a file operation not bucket (#1661)

view details

release-please[bot]

commit sha 5ede98dad8b3589e75734565e1b9f859d183c9ce

chore: release 5.15.2 (#1662) :robot: I have created a release \*beep\* \*boop\* --- ### [5.15.2](https://www.github.com/googleapis/nodejs-storage/compare/v5.15.1...v5.15.2) (2021-10-13) ### Bug Fixes * remove bucket preconditions from deleteFiles, it is a file operation not bucket ([#1661](https://www.github.com/googleapis/nodejs-storage/issues/1661)) ([6b7a06d](https://www.github.com/googleapis/nodejs-storage/commit/6b7a06defe1a3cadc6fad9258ff3fb01a2ecce0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

view details

Denis DelGrosso

commit sha 678ae77dfb2c1eb2272734f34315b4d0ec726076

fix: do not use src precondition options in copy. (#1666) * fix: do not use src precondition options in copy. * add new line

view details

release-please[bot]

commit sha 25c67a1f7e875779cf043cc1cb3cc6ba8fe92a51

chore: release 5.15.3 (#1667) :robot: I have created a release \*beep\* \*boop\* --- ### [5.15.3](https://www.github.com/googleapis/nodejs-storage/compare/v5.15.2...v5.15.3) (2021-10-14) ### Bug Fixes * do not use src precondition options in copy. ([#1666](https://www.github.com/googleapis/nodejs-storage/issues/1666)) ([678ae77](https://www.github.com/googleapis/nodejs-storage/commit/678ae77dfb2c1eb2272734f34315b4d0ec726076)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

view details

Daniel Bankhead

commit sha 8f1c4c06f768750da56de6a3e2947cacb20e9d1a

Merge branch 'main' of https://github.com/googleapis/nodejs-storage into unify-retry-logic

view details

push time in 6 days

push eventgoogleapis/nodejs-storage

Daniel Bankhead

commit sha 87d47d79fe3e5f5f88c972bf0af1b80a08c6f28e

docs: Method should be used for `ifGenerationMatch` We can extend the function when we require `IfMetagenerationMatch` checking in this class

view details

push time in 8 days

Pull request review commentgoogleapis/nodejs-storage

refactor: Unify precondition retry logic

 class File extends ServiceObject<File> {     this.instancePreconditionOpts = options?.preconditionOpts;   } +  /**+   * A helper method for determining if a request should be retried based on preconditions+   *+   * A request should not be retried under the following conditions:+   * - if precondition option `ifGenerationMatch` is not set OR

Good point - I'll make a note. Perhaps we can extend the function when we require IfMetagenerationMatch checking in this class.

Refs:

  • #1642
  • https://cloud.google.com/storage/docs/retry-strategy#idempotency-operations
danielbankhead

comment created time in 8 days

PullRequestReviewEvent

push eventgoogleapis/nodejs-storage

Daniel Bankhead

commit sha 8c0fb72b2e55c0fd8b501325943503570af18aaf

refactor: Rename `shouldRetryRequest` to `shouldRetryBasedOnPreconditionAndIdempotencyStrat`

view details

push time in 8 days

PullRequestReviewEvent

Pull request review commentgoogleapis/nodejs-storage

refactor: Unify precondition retry logic

 class File extends ServiceObject<File> {     this.instancePreconditionOpts = options?.preconditionOpts;   } +  /**+   * A helper method for determining if a request should be retried based on preconditions+   *+   * A request should not be retried under the following conditions:+   * - if precondition option `ifGenerationMatch` is not set OR+   * - if `idempotencyStrategy` is set to `RetryNever`+   */+  private shouldRetryRequest(options?: PreconditionOptions): boolean {

Sure

danielbankhead

comment created time in 8 days

Pull request review commentgoogleapis/nodejs-storage

refactor: Unify precondition retry logic

 class File extends ServiceObject<File> {       }     } -    if (-      (options?.preconditionOpts?.ifGenerationMatch === undefined &&-        this.instancePreconditionOpts?.ifGenerationMatch === undefined &&-        this.storage.retryOptions.idempotencyStrategy ===-          IdempotencyStrategy.RetryConditional) ||-      this.storage.retryOptions.idempotencyStrategy ===-        IdempotencyStrategy.RetryNever-    ) {+    if (!this.shouldRetryRequest(options.preconditionOpts)) {

options is defined on line 1035

danielbankhead

comment created time in 8 days

PullRequestReviewEvent

push eventgoogleapis/nodejs-storage

Daniel Bankhead

commit sha 10cf076784a4732d2a56108df5a495722b842895

refactor: Use `PreconditionOptions` for determining if a request should be retried

view details

push time in 9 days

PR opened googleapis/nodejs-storage

Reviewers
refactor: Unify retry logic
+25 -26

0 comment

1 changed file

pr created time in 9 days

push eventgoogleapis/nodejs-storage

Daniel Bankhead

commit sha 2c1ebb6d022dd41bbb2a0f2a4877c9c9b90c91b5

refactor: Unify retry logic

view details

push time in 9 days

create barnchgoogleapis/nodejs-storage

branch : unify-retry-logic

created branch time in 9 days

startedbcoe/conventional-release-labels

started time in 11 days

Pull request review commentgoogleapis/repo-automation-bots

fix: make owl-bot ignore archived repos

 export class FakeConfigsStore implements ConfigsStore {     }   } +  clearConfigs(repo: string): Promise<void> {+    this.configs.delete(repo);+    return Promise.resolve();+  }

Minor: you can add the async keyword which always returns a promise (even if the contents are synchronous)

  async clearConfigs(repo: string): Promise<void> {
    this.configs.delete(repo);
  }
SurferJeffAtGoogle

comment created time in 14 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventgoogleapis/nodejs-common

Sameena Shaffeeullah

commit sha f15b02dca69dd487df241b36a50e6a06efbfb697

fix: updated instance id to match returned metadata id (#696) * deps: updated auth library version * fix: update id on object * revert auth library change * renamed test * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

view details

push time in 15 days

delete branch googleapis/nodejs-common

delete branch : shaffeeullah/updateInstanceId

delete time in 15 days

PR merged googleapis/nodejs-common

fix: updated instance id to match returned metadata id cla: yes

Fixes bug where deleting, getting, and getting metadata for notifications in nodejs-storage would always 404 (because it was looking for the wrong id)

+25 -0

0 comment

2 changed files

shaffeeullah

pr closed time in 15 days

PullRequestReviewEvent

push eventdanielbankhead/picture-playlist

Daniel Bankhead

commit sha 4c95f22bf54fe47d74e486f034da5d953bc7e1f3

chore: Add license Added via `addlicense`

view details

push time in 18 days

push eventdanielbankhead/picture-playlist

Daniel Bankhead

commit sha d0dfd8b66af60057dc40a1219e0575d60c578d6a

chore: OCD This is the only file that qualifies as 'JavaScript' rather than 'TypeScript' on GitHub... gotta change that

view details

push time in 18 days

create barnchdanielbankhead/picture-playlist

branch : main

created branch time in 18 days

created repositorydanielbankhead/picture-playlist

created time in 18 days