profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/danidoni/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Dani Donisa danidoni Granollers, Barcelona, Spain

danidoni/gorogue 1

A Roguelike made in Go

danidoni/Anno2018-godot 0

Rewriting Anno 1602 from scratch, using extracted assets from the original game.

danidoni/ansible-obs 0

Some playbooks to operate OBS

danidoni/awesomewm-config 0

My AwesomeWM configuration

danidoni/dotfiles 0

A collection of configuration files used in my *nixes

danidoni/dwm 0

Dynamic Window Manager

danidoni/EmacsKeys 0

Emacs key bindings for Visual Studio

danidoni/gogb 0

Another Gameboy emulator

danidoni/hello_world 0

simplest hello_world rpm in the world

PullRequestReviewEvent
PullRequestReviewEvent

push eventkrauselukas/open-build-service

Dani Donisa

commit sha be1a11394ce6962b594a48df3776dd036659bf76

Remove unnecessary cassettes from Workflow specs

view details

push time in a day

push eventkrauselukas/open-build-service

Dani Donisa

commit sha 7e53c7e9a52daec86d201adcda5a6a846e694a95

Use stubs to avoid testing Workflow Steps We were indirectly testing the branch package step in the token workflow specs. We only need to ensure the workflow gets called and ignore the workflow implementation as it is already tested elsewhere.

view details

push time in a day

delete branch danidoni/open-build-service

delete branch : implement-workflow-branches-filter

delete time in a day

push eventdanidoni/open-build-service

Dani Donisa

commit sha f2f95024982a8feed97c89999a457fe74777d6ef

Implement branches filter for workflows Co-authored-by: Dany Marcoux <dmarcoux@suse.com>

view details

push time in 2 days

push eventdanidoni/open-build-service

Dani Donisa

commit sha fba280912b916aebb91a4c3ab8ced1b4224ca21f

Implement Workflow's branch filters

view details

push time in 2 days

push eventdanidoni/open-build-service

depfu[bot]

commit sha 2be75820850dbd7f21d1d4b209e78a91b78e6b35

Update puma to version 5.5.0

view details

Rubhan Azeem

commit sha 6009951e69fe3bd1dec3cf3bb8fd95b48c58659d

Merge pull request #11644 from openSUSE/depfu/update/srcapi/puma-5.5.0 [src/api] Update puma: 5.4.0 → 5.5.0 (minor)

view details

Lukas Krause

commit sha 00fc18fe682e177fee55fac756a3c964aade43de

Remove duplicated validation in branch and link package step The super class of the steps already takes care of validating the presence of the source package and source project names through the REQUIRED_KEYS constant. Additionally we have to add a validation to check for the presence of the value for a required key.

view details

Lukas Krause

commit sha 2133c65f316185d15a85256d34bc6a8a9bc94553

Remove duplicated validation of the project key in configure repository step The presence of the key is already ensured through the validation in the step super class.

view details

Dany Marcoux

commit sha 87ef9b8fe85d6a559deb3cee0813b515e08c0388

Merge pull request #11640 from krauselukas/workflows/remove_duplicated_validation Remove duplicated validation in branch and link package step

view details

depfu[bot]

commit sha 778527bb26a21a3fe0a31cf6353f409079914fbe

Update marcel to version 1.0.2

view details

Adrian Schröter

commit sha 84a473b3009a02aafb7bf52123625d8be0d7c30f

[backend] bs_repserver: deliver path url in buildinfo for foreign partitions This is fixing the osc download from mirrors.

view details

Rubhan Azeem

commit sha 731f9bf7ca292cc1083d3bd32f3dbe0432620bbf

Merge pull request #11648 from openSUSE/depfu/update/srcapi/marcel-1.0.2 [src/api] Update marcel: 1.0.1 → 1.0.2 (patch)

view details

Adrian Schröter

commit sha 6720f6cbe8dcbb907f47d719a587cdf83f48c524

Merge pull request #11649 from adrianschroeter/fix_path_url [backend] bs_repserver: deliver path url in buildinfo for foreign partitions

view details

Michael Schroeder

commit sha 568561f2c50586efa3d73353cadf102d6254ecdb

[backend] BuildJob/Aggregate: add aggregated rpms to modulemd data if we build a module But make sure that the rpms belong to the same module/stream, ignore them if this is not the case.

view details

Michael Schroeder

commit sha 290f34083c881cc7d3c36fa6cacc77552502a81b

Merge pull request #11650 from mlschroe/master [backend] BuildJob/Aggregate: also aggregate modulemd data if present

view details

Dani Donisa

commit sha 4e13f942c594565d839e888d591bdd1c4363fc08

Adapt ScmExtractor to support push events Co-authored-by: Daniel Donisa <daniel.donisa@suse.com>

view details

Dany Marcoux

commit sha ee08576162c5b660e4c8955824a92211188c5d45

Merge pull request #11641 from danidoni/adapt-scm-extractor-to-support-push-events Adapt ScmExtractor to support push events

view details

Dani Donisa

commit sha 2e5471fa23b3cff09ca7e4cc88fc3f7bf961b46e

Implement Workflow's branch filters

view details

push time in 2 days

push eventdanidoni/open-build-service

Dani Donisa

commit sha 32c7afab073e97508a6293e4afcd8beed3552661

Implement Workflow's branch filters

view details

push time in 2 days

push eventdanidoni/open-build-service

Dani Donisa

commit sha 2b17adca0f4b133e631545ae8e9993630cc2ecf9

Implement Workflow's branch filters

view details

push time in 2 days

push eventdanidoni/open-build-service

Dani Donisa

commit sha 4e955b1dd568e4052568efe884e5b009f2e209aa

Implement Workflow's branch filters

view details

push time in 2 days

push eventdanidoni/open-build-service

Dani Donisa

commit sha 52ee4034a6ed035736b30b656c3d214e66bd5ec6

Implement Workflow's branch filters

view details

push time in 2 days

Pull request review commentopenSUSE/open-build-service

Implement Workflow's branch filters

 def call     private      def github_extractor_payload-      {+      payload = {         scm: 'github',-        commit_sha: @payload.dig(:pull_request, :head, :sha),-        pr_number: @payload[:number],-        source_branch: @payload.dig(:pull_request, :head, :ref),-        target_branch: @payload.dig(:pull_request, :base, :ref),-        action: @payload[:action], # TODO: Names may differ, maybe we need to find our own naming (defer to service?)-        source_repository_full_name: @payload.dig(:pull_request, :head, :repo, :full_name),-        target_repository_full_name: @payload.dig(:pull_request, :base, :repo, :full_name),         event: @event,         api_endpoint: github_api_endpoint       }+      case @event+      when 'pull_request'+        payload.merge!({ commit_sha: @payload.dig(:pull_request, :head, :sha),+                         pr_number: @payload[:number],+                         source_branch: @payload.dig(:pull_request, :head, :ref),+                         target_branch: @payload.dig(:pull_request, :base, :ref),+                         action: @payload[:action], # TODO: Names may differ, maybe we need to find our own naming (defer to service?)+                         source_repository_full_name: @payload.dig(:pull_request, :head, :repo, :full_name),+                         target_repository_full_name: @payload.dig(:pull_request, :base, :repo, :full_name) })+      when 'push'+        payload.merge!({ commit_sha: @payload[:after],+                         branch: @payload[:ref].split('/').last,

In the end, those changes are landing here so I've removed them from this PR.

danidoni

comment created time in 3 days

PullRequestReviewEvent

push eventdanidoni/open-build-service

Dani Donisa

commit sha 9272924b6c49af3e465cfb48337e4b0844dad312

Implement Workflow's branch filters

view details

push time in 3 days

push eventdanidoni/open-build-service

Dani Donisa

commit sha 3133a4a9842e7a6d9db7946d628ee14f4a39dca5

Implement Workflow's branch filters

view details

push time in 3 days

Pull request review commentopenSUSE/open-build-service

Implement Workflow's branch filters

 def call     private      def github_extractor_payload-      {+      payload = {         scm: 'github',-        commit_sha: @payload.dig(:pull_request, :head, :sha),-        pr_number: @payload[:number],-        source_branch: @payload.dig(:pull_request, :head, :ref),-        target_branch: @payload.dig(:pull_request, :base, :ref),-        action: @payload[:action], # TODO: Names may differ, maybe we need to find our own naming (defer to service?)-        source_repository_full_name: @payload.dig(:pull_request, :head, :repo, :full_name),-        target_repository_full_name: @payload.dig(:pull_request, :base, :repo, :full_name),         event: @event,         api_endpoint: github_api_endpoint       }+      case @event+      when 'pull_request'+        payload.merge!({ commit_sha: @payload.dig(:pull_request, :head, :sha),+                         pr_number: @payload[:number],+                         source_branch: @payload.dig(:pull_request, :head, :ref),+                         target_branch: @payload.dig(:pull_request, :base, :ref),+                         action: @payload[:action], # TODO: Names may differ, maybe we need to find our own naming (defer to service?)+                         source_repository_full_name: @payload.dig(:pull_request, :head, :repo, :full_name),+                         target_repository_full_name: @payload.dig(:pull_request, :base, :repo, :full_name) })+      when 'push'+        payload.merge!({ commit_sha: @payload[:after],+                         branch: @payload[:ref].split('/').last,

Fixed

danidoni

comment created time in 3 days

PullRequestReviewEvent

push eventdanidoni/open-build-service

Dani Donisa

commit sha bdab2e8df55bd6ba83a2df34b97b57bd3b5ee064

Implement Workflow's branch filters

view details

push time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentopenSUSE/open-build-service

Rebuild package step model triggerable

 module Triggerable   def set_project     # By default we operate on the package association     @project = @token.package.try(:project)-    # If the token has no package, let's find one from the parameters-    @project ||= Project.get_by_name(params[:project])+    # If the token has no package, let's find one from the parameters or the step intructions+    @project ||= Project.get_by_name(@project_name)

:thought_balloon: You could just call the methods that get those values instead of relying in instance variables that will be nil if someone forgets to fill them in. Calling methods that do not exist will throw a nice error that the programmer would notice faster. You could even write some default ones that throw NotImplementedError to make even more clear that they should be overriden.

saraycp

comment created time in 3 days

pull request commentopenSUSE/open-build-service

Use SignUpComponent instead of custom sign up form

LGTM!

vpereira

comment created time in 3 days

Pull request review commentopenSUSE/open-build-service

Implement event filter for workflows

 def supported_filters     @supported_filters ||= workflow_instructions[:filters]&.select { |key, _value| SUPPORTED_FILTERS.include?(key.to_sym) }   end +  def event_matches_event_filter?+    return true unless supported_filters.key?(:event) # TODO: This will break if supported_filters is nil

Make supported_filters return {} if it does not work.

dmarcoux

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventdanidoni/open-build-service

Dani Donisa

commit sha 7d0694c8c0a1599f0dfd5b6f4190be3d22b0fc5b

Implement Workflow's branch filters

view details

push time in 3 days

push eventdanidoni/open-build-service

Dani Donisa

commit sha be2c61e84b9dad464d79aa718863dee7b0d5d90d

Adapt ScmExtractor to support push events

view details

push time in 3 days

push eventdanidoni/open-build-service

Dani Donisa

commit sha a25952960c75a6a214371f759e7254c170faf393

Adapt ScmExtractor to support push events

view details

push time in 3 days