profile
viewpoint
Danny Koppenhagen d-koppenhagen DB Systel GmbH Berlin, Germany http://d-koppenhagen.de 👨🏻‍💻 Developer 🚀, Author 📖, Engineer ⚙️ ❤️ 📦 nodejs 🅰️ Angular, 🔰 Vue.js 💡 TypeScript, ⚡️ RxJS and ♻️ NgRx

d-koppenhagen/latex-rechnung 86

Eine LaTeX-Rechnungsvorlage.

d-koppenhagen/angular-tag-cloud-module 27

This angular module contains a component which generates tag clouds. The module requires a peer dependency to @angular/core >= Version 6.0.0.

d-koppenhagen/d-koppenhagen.de 8

My personal websites repo: https://d-koppenhagen.de

d-koppenhagen/latex-dirtree-generator 5

This is a Perl-script for generating directory trees in LaTeX documents by procesing all files from a given directory.

d-koppenhagen/.dotfiles 3

This repository contains some common dotfiles I am using for my local dev environment

d-koppenhagen/bootstrap-folder-scan-gallery 2

A simple gallery which scans automatically a folder (recursive) for media files. Using a bootstrap theme for displaying contents.

d-koppenhagen/auth-backend-example 1

A simple backend which will provide a secured REST API

d-koppenhagen/Infoscreen-2.0 1

A new version of my infoscreen created with AngularJS

d-koppenhagen/logwatch-html 1

a script for updating html the logwatch html files

d-koppenhagen/a-mail-signature 0

📧 Generate and modify Apple Mail E-Mail signatures

issue commentnathanreyes/v-calendar

Semantic Version bump

Awesome, thanks 🙏

d-koppenhagen

comment created time in 16 hours

push eventd-koppenhagen/vscode-code-review

elazarcoh

commit sha fffdc6f2d99dc1b4d0b59e062fbae6e3b87d5067

fix: incorrect behavior when the correct comment isn't found use "> -1" instead leads to incorrect behavior when the correct comment isn't found

view details

Danny Koppenhagen

commit sha 083dccc62d2acea795e63c91d75104aa1375ebbe

chore(release): 1.19.5

view details

push time in a day

created tagd-koppenhagen/vscode-code-review

tagv1.19.5

Create a code review with all your comments in one file

created time in a day

push eventd-koppenhagen/vscode-code-review

elazarcoh

commit sha d2f17b496f443f8cad1929f935aad4b9ddf015a9

use "> -1" instead leads to incorrect behavior when the correct comment isn't found

view details

push time in a day

PR merged d-koppenhagen/vscode-code-review

use "> -1" instead

leads to incorrect behavior when the correct comment isn't found.

BTW it might prove wiser to use a dedicated CSV reader & writer for those tasks. See #60 for more details

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Removes incorrect lines, because -1 is considered as successful "fileIndex" results

What is the new behavior?

-1 is considered as an error, the error indicator will appear when the correct row is not found

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

+2 -2

0 comment

1 changed file

elazarcoh

pr closed time in a day

PullRequestReviewEvent

push eventd-koppenhagen/vscode-code-review

Danny Koppenhagen

commit sha 9e5c4f92344e43fc86a4ee1535bcf203308e9425

chore(release): 1.19.4

view details

push time in a day

created tagd-koppenhagen/vscode-code-review

tagv1.19.4

Create a code review with all your comments in one file

created time in a day

push eventd-koppenhagen/combine-schematics-playground

push time in 2 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 279012c4b1c0f5d9eca12743f24ed5f1e9fe7b82

chore: add scm-info.yml file

view details

push time in 2 days

push eventd-koppenhagen/vscode-code-review

Danny Koppenhagen

commit sha 4b7d4adfb8897b507d3c12b660f9d61af3b384fe

fix: the position is zero-based on the csv The previous fix (#56) was partly incorrect. Only the lines are saved as one-based on the csv. The position in the line was zero-based.

view details

push time in 2 days

push eventd-koppenhagen/vscode-code-review

elazarcoh

commit sha 9850d435348d583c1c7cade58803a7600711f6e5

The position is zero-based on the csv The previous fix was partly incorrect. Only the lines are saved as one-based on the csv. The position in the line was zero-based.

view details

push time in 2 days

PR merged d-koppenhagen/vscode-code-review

The position is zero-based on the csv

The previous fix was partly incorrect. Only the lines are saved as one-based on the csv. The position in the line was zero-based.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

+3 -3

0 comment

1 changed file

elazarcoh

pr closed time in 2 days

push eventd-koppenhagen/vscode-code-review

allcontributors[bot]

commit sha 4e6f0a61d2b3ed27a6004b779e8ebb54b8fbf0a3

docs: update README.md [skip ci]

view details

allcontributors[bot]

commit sha a79d01ff407c52c171d8f5b82738489c74cbb884

docs: update .all-contributorsrc [skip ci]

view details

push time in 2 days

PR merged d-koppenhagen/vscode-code-review

docs: add elazarcoh as a contributor

Adds @elazarcoh as a contributor for code.

This was requested by d-koppenhagen in this comment

+11 -1

0 comment

2 changed files

allcontributors[bot]

pr closed time in 2 days

pull request commentd-koppenhagen/vscode-code-review

`Position` expects a zero-based index, but the CSV saved as one-based…

@all-contributors please add @elazarcoh for code

elazarcoh

comment created time in 2 days

issue commentd-koppenhagen/vscode-code-review

[bug] Off by one error on HTML report generation

please check out version 1.19.3 which will fix this issue. This was caused a a side effect of #56

bluenick2k17

comment created time in 2 days

push eventd-koppenhagen/vscode-code-review

Danny Koppenhagen

commit sha dd9f5afd74f06b7cec4b5a7767822c66640cd721

fix: off by one error on HTML report generation issue was a side effect cause by #56 closes #57

view details

Danny Koppenhagen

commit sha ca757780927118dff4bab091d31c50c164193ddc

chore(release): 1.19.3

view details

push time in 2 days

issue closedd-koppenhagen/vscode-code-review

[bug] Off by one error on HTML report generation

🐞 Bug report

Description

When I select lines 3:0-3:44 for example, it shows up in the CSV as 3:0-3:44 but the report generates it as if I selected the whole 2:0 line. I have also seen where multi-line selections shift up one line when generating the code snippet.

Reproduction

Create a file that contains multiple lines, select a line with text above it (I selected the whole line of text if that helps), and then produce an HTML report with code snippets enabled.

Error message

<pre><code> none </code></pre>

🌍 Your Environment

Running extension version 1.19.2

closed time in 2 days

bluenick2k17

created tagd-koppenhagen/vscode-code-review

tagv1.19.3

Create a code review with all your comments in one file

created time in 2 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 9c010647ffa20150e2753b7c45ede716b459acc3

docs: add ng update

view details

push time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 9ae705035e59e4806d760cb7f47413dd86b5c8e5

docs: update README

view details

Danny Koppenhagen

commit sha aadaceeb1eec31a8dc489a4dcc29a21f3f861143

chore(release): 0.0.2

view details

push time in 3 days

created tagd-koppenhagen/combine-schematics-playground

tagv0.0.2

created time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 54a29434c806420ec243bfda45218d207e07e71f

chore(release): 0.0.1

view details

push time in 3 days

created tagd-koppenhagen/combine-schematics-playground

tagv0.0.1

created time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha da6dbfb025f99bf31c8216035e334031a63d1f5e

refactor: return promise<void>

view details

Danny Koppenhagen

commit sha 85f18ae7ded2b0cd3544c641887c8422c2f1e456

test: add basi ng-add test case

view details

push time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha f5110e5174d4482c8403623937d1e39491b1d3d2

feat: apply header template files

view details

push time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 9a1bc8c46e7fcca00c5666d84243293afdaf29b5

chore: add tooling

view details

Danny Koppenhagen

commit sha f44facb66840b6102ab3205fda16d691718c2576

style: format code

view details

Danny Koppenhagen

commit sha cbfb376fac7873c7f0ce567ce8e6f137d2f4ffdf

test: remove test hook temporarily

view details

push time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha dff43623596fb8609ee2c9493c311ebe08db1a25

style: re-apply tsconfig rules

view details

push time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha c545a3d602891a5f9b5c8b4ecd4d267bf467afa4

style: remove unused import

view details

push time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha d81e174aaf30d23b3f60157898613549ea88dd19

feat: call more schematics

view details

push time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 45d1d75c22cdb103b44118e9b8bc11ebfc9695e1

fix: fix launch file

view details

push time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 22b6f2b17cdf217c9addcb24da707e4a2bd89fcf

fix: move files to correct dir

view details

push time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 168c886826f2b466f99a318059ffd72997e8f431

feat: add vscode settings

view details

push time in 3 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 122500ae30696a19e930ef2b9dae96eaa191ec54

fix: header component schematic

view details

Danny Koppenhagen

commit sha efdadb9cafd6caea4c076de89b2e30315403e1d2

feat: cleanup temp package

view details

push time in 4 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha ed797fd4a71bd99a28e566a7142d14c8ede37315

refactor: split ng new setup into smaller functions

view details

push time in 4 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 1228124e8adaa85c446056d96581f24edd433d0e

fix: correctly combin ng new from @angular/cli with other

view details

push time in 4 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha f5d9c2683d13d736b37e0e1eb093a6cc7bf6fb7d

initial commit temp cleanup re-add uncommented stuff re-add other schematics, cleanup

view details

push time in 5 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha 8885c371a573c922951d5afbb15e06911a6a9db8

re-add other schematics, cleanup

view details

push time in 5 days

push eventd-koppenhagen/combine-schematics-playground

Danny Koppenhagen

commit sha a268c6b89dcf42b1df7841fbae1bfa65086f0a06

re-add uncommented stuff

view details

push time in 5 days

issue openednathanreyes/v-calendar

Semantic Version bump

Version 1.1.1 has been released recently and introduces lots of breaking changes: https://github.com/nathanreyes/v-calendar/releases

As this breaking changes will cause code breaks for all dependent projects that are defined with a caret in the package.json file, it would be better to bump the major version part and unrelease 1.1.1 In favor of 2.0.0:

{
  // ...
  "dependencies": {
    "v-calendar": "^1.0.0" // will introduce unwanted breaking changes on npm install
  }
}

Suggestion:

  1. bump version to 2.0.0
  2. Release version 2.0.0
  3. npm unpublish 1.1.1

With this changes most developers will be aware of the breaking change and they can migrate their code safely when updating by intention to 2.0.0.

created time in 5 days

create barnchd-koppenhagen/combine-schematics-playground

branch : main

created branch time in 6 days

created repositoryd-koppenhagen/combine-schematics-playground

created time in 6 days

push eventd-koppenhagen/vscode-code-review

Danny Koppenhagen

commit sha 47322491b36a80b78dd9ab6d950852abd5480bf3

chore(release): 1.19.2

view details

push time in 6 days

created tagd-koppenhagen/vscode-code-review

tagv1.19.2

Create a code review with all your comments in one file

created time in 6 days

push eventd-koppenhagen/vscode-code-review

elazarcoh

commit sha 0855213d1c4f82b057ef475703df6c7cd78f2bb4

fix: `Position` expects a zero-based index, but the CSV saved as one-based index

view details

Danny Koppenhagen

commit sha 22fccc07351e6d911958dceeefd431938664e727

fix: handle values under 0, provide tests

view details

Danny Koppenhagen

commit sha a8e6377f5f4491b6a25a1ec4de78e39d9d5cbd24

chore: update dependencies

view details

push time in 6 days

push eventd-koppenhagen/vscode-code-review

elazarcoh

commit sha 0cafe58f2aecb6851789675f99e2165b71952f57

`Position` expects a zero-based index, but the CSV saved as one-based index

view details

push time in 6 days

PR merged d-koppenhagen/vscode-code-review

`Position` expects a zero-based index, but the CSV saved as one-based…

… index

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

+3 -2

1 comment

1 changed file

elazarcoh

pr closed time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

PR merged d-koppenhagen/vscode-code-review

don't use Uri.parse, it fails on Windows

Opening the review-comment fails in Windows. I suggest use the

openTextDocument(fileName: string): Thenable<TextDocument>

overload instead.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

+1 -1

0 comment

1 changed file

elazarcoh

pr closed time in 6 days

push eventd-koppenhagen/vscode-code-review

elazarcoh

commit sha 6cdfc366efb12d4d3b3d73a386f582918b726314

don't use Uri.parse, it fails on Windows Opening the review-comment fails in Windows. I suggest use the ``` openTextDocument(fileName: string): Thenable<TextDocument> ``` overload instead.

view details

push time in 6 days

issue commentangular/angular-cli

Library schematic conflicts with itself when used with applyToSubtree

Same issue here.

@pfeileon you wrote:

When I don't add a scope and instead hack getWorkspace(...) to add the project name to the path for the component schematic, only, there is no error and it works.

Would you mind to share your "hacked" getWorkspace() solution that works for you? I didn't manage to solve the issue locally by trying out lot's of things with pathes and handing over options etc.

CobusKruger

comment created time in 6 days

issue commentangular/angular-cli

Library schematic does not support path property

Same here. I think the problem is that after running externalSchematic('@schematics/angular', 'ng-new', optionsNew), the workspace is just present as a virtual tree and not entered. So the next Rule can't determine that it's in a valid Angular workspace. Is there a way to tell the schematics, to either:

  • enter the target workspace within the virtual representation and use this as new base
  • save the changes made by externalSchematic('@schematics/angular', 'ng-new', optionsNew) from virtual tree to the file system and then run the next Rule afterwards?
CobusKruger

comment created time in 6 days

pull request commentangular-buch/website-articles

buch3

Sehr gut. Keine weiteren Anmerkungen

fmalcher

comment created time in 11 days

push eventd-koppenhagen/d-koppenhagen.de

d-koppenhagen

commit sha f3574a8f814941156f5d53c65305c6729aa59d6b

deployed via Scully Publish Action 🎩 for 52973d9bb3852d23819c7553c53cb76026653074

view details

push time in 15 days

push eventd-koppenhagen/d-koppenhagen.de

Danny Koppenhagen

commit sha 52973d9bb3852d23819c7553c53cb76026653074

content(dev-setup): add Aqua Buddy

view details

push time in 15 days

push eventd-koppenhagen/d-koppenhagen.de

d-koppenhagen

commit sha 74facffb1c6248d5227c3549f13f1ab9f553d50c

deployed via Scully Publish Action 🎩 for ab2f4a6d41e28d569a9e276d97e7f3226c0bab55

view details

push time in 15 days

issue commentd-koppenhagen/vscode-code-review

[feature] send review to gerrit

Okay. I like the Idea but I think I am still not familiar using gerrit. Also I won't find time for the implementation during the next months I think. Would you like to try it by yourself and send me a PR once it's ready? I can help you when you have questions in terms of how to develop and run the extension locally. But basically all you need is described in the READMEs

robgal519

comment created time in 15 days

push eventd-koppenhagen/d-koppenhagen.de

Danny Koppenhagen

commit sha ab2f4a6d41e28d569a9e276d97e7f3226c0bab55

content(scully): update scully blog posts

view details

push time in 15 days

issue commentd-koppenhagen/vscode-code-review

[feature] send review to gerrit

Hey, actually I don't know gerrit. Would you mind to explain a bit more in detail how the implementation could look like and what API to use etc?

robgal519

comment created time in 15 days

push eventangular-buch/website-articles

Danny Koppenhagen

commit sha cf825e8cd37435e9b8cace586554bacc327b86f9

use correct link and link text for available book

view details

push time in 19 days

push eventangular-buch/website-articles

Danny Koppenhagen

commit sha fec67aa4c7e9c277a52388faac984dae4f0542e9

Update Inhalt

view details

push time in 19 days

push eventangular-buch/website-articles

Danny Koppenhagen

commit sha 1da56a09bd49d2541fa3135dce7863c445815655

Kleine Anpassungen

view details

push time in 19 days

push eventangular-buch/website-articles

Danny Koppenhagen

commit sha c741ba9c57c76a93434958396959e2f5c0e261db

Danksagung

view details

push time in 19 days

startedniklas-wortmann/rxjs-web

started time in 21 days

push eventd-koppenhagen/d-koppenhagen.de

d-koppenhagen

commit sha 9c98a6f8e7f7b29c10235a0364c6ab8a6a230834

deployed via Scully Publish Action 🎩 for 3b6d6069ea4dbdd95af4e86daaba17e7959b7e0e

view details

push time in 21 days

push eventd-koppenhagen/d-koppenhagen.de

Danny Koppenhagen

commit sha 3b6d6069ea4dbdd95af4e86daaba17e7959b7e0e

content(schematic-helpers): move article to inDepth

view details

push time in 21 days

issue commentangular-schule/angular-cli-ghpages

Deployment with Scully.io?

I think if there should be an option, it should be configurable, so one can choose the folder to deploy

fireflysemantics

comment created time in 25 days

fork d-koppenhagen/ngx-deploy-starter

Starter repository to create a new builder to utilize the `ng deploy` command 🚀

https://www.npmjs.com/package/@angular-schule/ngx-deploy-starter

fork in 25 days

issue commentangular-schule/angular-cli-ghpages

Deployment with Scully.io?

Hey, if you want to deploy your scully static site on github pages, the easiest way is to use this Github action:

https://github.com/marketplace/actions/scully-publish

Here is an example of how to use it:

https://github.com/d-koppenhagen/d-koppenhagen.de/blob/master/.github/workflows/nodejs.yml#L21-L25

fireflysemantics

comment created time in a month

push eventd-koppenhagen/d-koppenhagen.de

d-koppenhagen

commit sha 97d9c7eb1fe9bd7c89fc7128a9b8b5916cfb1a3e

deployed via Scully Publish Action 🎩 for 058617bc8015a78916d273397145761fda8ead94

view details

push time in a month

issue closedscullyio/scully

Plugin "googleAnalytics" of type "undefined" is not found, can not store config

🐞 Bug report

When I will try to update some package in my Angular Scully project for my personal website (Repo here), the update is proceeded but there is a side effect that update also some part of the Scully plugin goolge analytics and the package-lock.json file is changed.

Description

When I install all packages exactly as currently defined in the packlage-lock.json file, the scully plugin @scullyio/scully-plugin-google-analytics works (You can reproduce this by running npm ci on the console as it will not update the lock file and it will install the exact locked versions. ✅

But when I install the packages running npm i, there is some update proceeded that causes the following error message on the console when running npm run scully:

Plugin "googleAnalytics" of type "undefined" is not found, can not store config

After the npm i ran, the package-lock.json file contains the following change that causes the update and in fact the error when running Scully:

// somewhere in line 2681
    "@scullyio/scully-plugin-google-analytics": {
      // ...
      "requires": {
        "@scullyio/scully": "1.0.0-beta.0",
        // ...
      },
      "dependencies": {
        "@scullyio/scully": {
          "version": "1.0.0-beta.0",
          "resolved": "https://registry.npmjs.org/@scullyio/scully/-/scully-1.0.0-beta.0.tgz",
          "integrity": "sha512-NH6RVuXLlptNtE9mnEXjA4oVtvWx4hYQpnzOFhyoW/uo2pGVpqHNE4GojeEn4DEJt9KujFageJq+DlwwN8c8qQ==",
          "requires": {
            "asciidoctor.js": "^1.5.9",
            "chalk": "^4.1.0",
            "chokidar": "^3.4.0",
            "compression": "^1.7.4",
            "cors": "^2.8.5",
            "express": "^4.17.1",
            "front-matter": "^4.0.2",
            "fs-extra": "^9.0.1",
            "guess-parser": "^0.4.18",
            "highlight.js": "^10.1.0",
            "http-proxy-middleware": "^1.0.4",
            "jsdom": "^16.2.2",
            "jsonc": "2.0.0",
            "marked": "^1.1.0",
            "open": "^7.0.3",
            "puppeteer": "^3.3.0",
            "rxjs": "^6.5.5",
            "selfsigned": "^1.10.7",
            "tslib": "^1.13.0",
            "typescript": "^3.8.3",
            "ws": "^7.3.0",
            "yamljs": "^0.3.0",
            "yargs": "^15.3.1"
          }
        },
        // ...
        "tslib": {
          "version": "1.13.0",
          "resolved": "https://registry.npmjs.org/tslib/-/tslib-1.13.0.tgz",
          "integrity": "sha512-i/6DQjL8Xf3be4K/E6Wgpekn5Qasl1usyw++dAA35Ue5orEn65VIxOA+YvNNl9HV3qv70T7CNwjODHZrLwvd1Q=="
        }
      }
    },
// ...

🔬 Minimal Reproduction

  1. Copy / Fork my repo: Repo here
  2. Run npm i
  3. Run npm run scully:all (Or separate: an Angular Build, the Scully build)
  4. The package-lock.json file is adjusted and the Google Analytics plugin doesn't work anymore

💻Your Environment

Angular Version:

<pre><code> Angular CLI: 10.0.8 Node: 14.8.0 OS: darwin x64

Angular: 10.0.14 ... animations, common, compiler, compiler-cli, core, forms ... language-service, platform-browser, platform-browser-dynamic ... router, service-worker Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.1000.8 @angular-devkit/build-angular 0.1000.8 @angular-devkit/build-optimizer 0.1000.8 @angular-devkit/build-webpack 0.1000.8 @angular-devkit/core 10.0.8 @angular-devkit/schematics 10.0.8 @angular/cdk 10.2.0 @angular/cli 10.0.8 @angular/youtube-player 10.2.0 @ngtools/webpack 10.0.8 @schematics/angular 10.0.8 @schematics/update 0.1000.8 rxjs 6.5.5 typescript 3.9.7 webpack 4.43.0 </code></pre> Scully Version:

{
  "name": "d-koppenhagen-website",
  "version": "0.0.0",
  "description": "d-koppenhagen.de website",
  "scripts": {
    "dev": "npm-run-all --parallel build:watch scully:watch",
    "release": "standard-version",
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "build:watch": "ng build --watch",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e",
    "scully": "scully",
    "scully:watch": "scully --watch",
    "scully:serve": "scully serve",
    "scully:all": "npm run build -- --prod && npm run scully -- --scanRoutes && npm run scully:serve",
    "post": "ng g @scullyio/init:post --metaDataFile='templates/blog-meta.yaml' --target='blog'",
    "project": "ng g @scullyio/init:post --metaDataFile='templates/project-meta.yaml' --target='projects'"
  },
  "private": true,
  "author": "Danny Koppenhagen <mail@d-koppenhagen.de> (https://d-koppenhagen.de)",
  "homepage": "https://github.com/d-koppenhagen/d-koppenhagen-website",
  "bugs": {
    "url": "https://github.com/d-koppenhagen/d-koppenhagen-website/issues",
    "email": "mail@d-koppenhagen.de"
  },
  "license": "SEE LICENSE IN LICENSE",
  "dependencies": {
    "@angular/animations": "~10.0.2",
    "@angular/cdk": "^10.0.1",
    "@angular/common": "~10.0.2",
    "@angular/compiler": "~10.0.2",
    "@angular/core": "~10.0.2",
    "@angular/forms": "~10.0.2",
    "@angular/platform-browser": "~10.0.2",
    "@angular/platform-browser-dynamic": "~10.0.2",
    "@angular/router": "~10.0.2",
    "@angular/service-worker": "~10.0.2",
    "@angular/youtube-player": "^10.0.0",
    "@fortawesome/angular-fontawesome": "^0.7.0",
    "@fortawesome/fontawesome-free": "^5.14.0",
    "@fortawesome/fontawesome-svg-core": "^1.2.30",
    "@fortawesome/free-brands-svg-icons": "^5.14.0",
    "@fortawesome/free-solid-svg-icons": "^5.14.0",
    "@ngneat/transloco": "^2.19.1",
    "@scullyio/ng-lib": "1.0.0-beta.2",
    "@scullyio/scully-plugin-google-analytics": "1.0.0-beta.0",
    "animate.css": "^4.1.0",
    "ng-navigator-share": "^1.0.4",
    "ng2-animate-on-scroll": "^2.0.0",
    "ngx-sharebuttons": "^8.0.1",
    "ngx-twitter-timeline": "^0.1.5",
    "prismjs": "^1.21.0",
    "rxjs": "~6.5.5",
    "tslib": "~2.0.0",
    "zone.js": "~0.10.3"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^0.1000.1",
    "@angular/cli": "~10.0.1",
    "@angular/compiler-cli": "~10.0.2",
    "@angular/language-service": "~10.0.2",
    "@commitlint/cli": "^9.1.2",
    "@commitlint/config-angular-type-enum": "^9.1.2",
    "@commitlint/config-conventional": "^9.1.2",
    "@gammastream/scully-plugin-sitemap": "1.0.4",
    "@scullyio/init": "1.0.0-beta.3",
    "@scullyio/scully": "1.0.0-beta.5",
    "@types/jasmine": "~3.5.11",
    "@types/jasminewd2": "~2.0.8",
    "@types/node": "^14.0.14",
    "codelyzer": "^5.2.2",
    "commitizen": "^4.2.1",
    "cz-conventional-changelog": "^3.3.0",
    "fast-xml-parser": "^3.17.4",
    "husky": "^4.2.5",
    "jasmine-core": "~3.5.0",
    "jasmine-spec-reporter": "~5.0.0",
    "jsdom": "^16.2.2",
    "karma": "~5.0.0",
    "karma-chrome-launcher": "~3.1.0",
    "karma-coverage-istanbul-reporter": "~3.0.2",
    "karma-jasmine": "~3.3.0",
    "karma-jasmine-html-reporter": "^1.5.0",
    "ngx-semantic-version": "^2.2.0",
    "npm-run-all": "^4.1.5",
    "prettier": "^2.1.1",
    "pretty-quick": "^3.0.0",
    "protractor": "~7.0.0",
    "scully-plugin-mermaid": "0.0.9",
    "scully-plugin-minify-html": "^3.2.0",
    "scully-plugin-toc": "^1.4.1",
    "standard-version": "^9.0.0",
    "ts-node": "~8.10.2",
    "tslint": "~6.1.0",
    "typescript": "~3.9.5"
  },
  "husky": {
    "hooks": {
      "pre-commit": "pretty-quick --staged",
      "commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
    }
  },
  "config": {
    "commitizen": {
      "path": "./node_modules/cz-conventional-changelog"
    }
  }
}

🔥 Exception or Error

<pre><code> npm run scully:watch -- --scanRoutes

d-koppenhagen-website@0.0.0 scully:watch /Users/dannykoppenhagen/dev/d-koppenhagen/d-koppenhagen-website scully --watch "--scanRoutes"

using plugins from folder "./scully" Plugin "googleAnalytics" of type "undefined" is not found, can not store config ⠹ npm ERR! code ELIFECYCLE npm ERR! errno 15 npm ERR! d-koppenhagen-website@0.0.0 scully:watch: scully --watch "--scanRoutes" npm ERR! Exit status 15 npm ERR! npm ERR! Failed at the d-koppenhagen-website@0.0.0 scully:watch script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! /Users/dannykoppenhagen/.npm/_logs/2020-09-13T07_43_14_781Z-debug.log </code></pre>

closed time in a month

d-koppenhagen

issue commentscullyio/scully

Plugin "googleAnalytics" of type "undefined" is not found, can not store config

Hey @jorgeucano , I juts update to scully version 1.0.0. Now the issue has gone away. I also notices that I added the GA plugin to the dependencies instead of devDependencies. Maybe that was part of the problem? .. anyway, with 1.0.0 everything work as expected.

d-koppenhagen

comment created time in a month

push eventd-koppenhagen/d-koppenhagen.de

Danny Koppenhagen

commit sha 058617bc8015a78916d273397145761fda8ead94

chore: update scully

view details

push time in a month

startedgenesy/dotfiles

started time in a month

issue commentgenesy/auto-correct

Correct words with "-" or "_"

Yes, same problem. My provided PR will fix this too 🙂

d-koppenhagen

comment created time in a month

issue commentscullyio/scully

Plugin "googleAnalytics" of type "undefined" is not found, can not store config

Tomorrow I will try to update all scully packages to the latest versions and then I can tell you if it still happens after updating to 1.0.0

d-koppenhagen

comment created time in a month

push eventd-koppenhagen/d-koppenhagen.de

Danny Koppenhagen

commit sha c77bc42a20c9c9183da8500fa274fdeeb78fc1e2

content(external-schematics): add `schematic` and `externalSchematic` to summary table

view details

push time in a month

push eventd-koppenhagen/d-koppenhagen.de

d-koppenhagen

commit sha a8d921b21f43a824ac5eaf8f8d7b9b19f280f528

deployed via Scully Publish Action 🎩 for bf17a650b8883c10e589da3c4501d7d9b9284327

view details

push time in a month

push eventd-koppenhagen/d-koppenhagen.de

Danny Koppenhagen

commit sha bf17a650b8883c10e589da3c4501d7d9b9284327

content(schematic-helpers): add `externalSchematic` (#11) * content(schematic-helpers): add `externalSchematic` content(schematic-helpers): fix schema content(schematic-helpers): add output after ng new content(schematic-helpers): show how to use after deploying it Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> content(schematic-helper): makeover content(schematic-helpers): makeover2 * content(schematic-helpers): set new update date

view details

push time in a month

push eventd-koppenhagen/d-koppenhagen.de

Danny Koppenhagen

commit sha 9ef735b7c7c7f9239368e4ec86dedf581433e616

content(schematic-helpers): set new update date

view details

push time in a month

push eventd-koppenhagen/d-koppenhagen.de

Danny Koppenhagen

commit sha 1da4a35c7ba2fbd223b43e8cc8e0dbd06faa13ab

content(dev-setup): add extensions `Indented Block Highlighting` and `DotENV`

view details

Danny Koppenhagen

commit sha d609e0677007826f88d7c2046ce123519e382233

feat: use better copy button style

view details

Danny Koppenhagen

commit sha 2b6e3134346cf195d65d493f7375bc27af708a6b

fix: update scully-plugin-mermaid

view details

Danny Koppenhagen

commit sha 23a7c09fe38dcaffbfa10233a9efba290e058e3e

content(schematic-helpers): add `externalSchematic` content(schematic-helpers): fix schema content(schematic-helpers): add output after ng new content(schematic-helpers): show how to use after deploying it Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> Update blog/2020-09-angular-schematics-common-helpers.md Co-authored-by: Ferdinand Malcher <ferdinand@malcher.media> content(schematic-helper): makeover content(schematic-helpers): makeover2

view details

push time in a month

push eventd-koppenhagen/d-koppenhagen.de

d-koppenhagen

commit sha e97be5edc5e2f9755c8cf7179ae682939918f1a7

deployed via Scully Publish Action 🎩 for 2b6e3134346cf195d65d493f7375bc27af708a6b

view details

push time in a month

push eventd-koppenhagen/d-koppenhagen.de

Danny Koppenhagen

commit sha 2b6e3134346cf195d65d493f7375bc27af708a6b

fix: update scully-plugin-mermaid

view details

push time in a month

push eventd-koppenhagen/scully-plugin-mermaid

Danny Koppenhagen

commit sha fd8c59d09edac1da04f52d20181a526aac393ab0

feat: allow to define the selector for mermaid content use `.language-mermaid` by default. BREAKING CHANGE: The configuration no longer only passes through the `MermaidAPI.Config`. This is now wrapped into the `config` key in the new interface `MermaidPluginConfig` that holds more options. **Old**: ``` import MermaidAPI from 'mermaid/mermaidAPI'; // ... const mermaidOptions: MermaidAPI.Config = { theme: 'dark', }; ``` **New**: ``` import { /* ... */, MermaidPluginConfig } from 'scully-plugin-mermaid'; // ... const mermaidOptions: MermaidPluginConfig = { // ... other config options config: { theme: 'dark' } }; ``` closes #2

view details

Danny Koppenhagen

commit sha 3209e0ca39e1e7e9c1bd33aeadc8d65ed54bffcb

feat: allow to define the wrapper-element option can also be set to `false` to completely disable using a wrapper element. closes #3

view details

Danny Koppenhagen

commit sha 6f94fe4dffd788a5e053adb2bdaf048e8387a15f

fix: make config params optional

view details

Danny Koppenhagen

commit sha c5066ac3f0fbd82c5e419accb121e2f162250471

chore(release): 0.0.10

view details

Danny Koppenhagen

commit sha fed8729e2dddc8abfb89af0fea35b623f0935e9d

fix: export MermaidPluginConfig

view details

Danny Koppenhagen

commit sha e6db600cd5e4a911e86a8889a8da9b6e41998931

refactor: outsource `getSvg` function

view details

Danny Koppenhagen

commit sha 071680c82a20b5a7a244d103806cd9f42a596555

test: provide first simple test

view details

Danny Koppenhagen

commit sha 342c366cbd88b98f55114f30c04db684ad3529a2

chore(release): 1.0.0

view details

push time in a month

created tagd-koppenhagen/scully-plugin-mermaid

tagv1.0.0

A Scully.io postRenderer to generate a SVGs from mermaid source code sections in markdown files

created time in a month

created tagd-koppenhagen/scully-plugin-mermaid

tagv0.0.10

A Scully.io postRenderer to generate a SVGs from mermaid source code sections in markdown files

created time in a month

push eventd-koppenhagen/scully-plugin-mermaid

Danny Koppenhagen

commit sha a03679f452e97852b7da98a7eaff0bb8694ea2c9

feat: allow to define the wrapper-element option can also be set to `false` to completely disable using a wrapper element. closes #3

view details

Danny Koppenhagen

commit sha bdbea04a87ffd64deff4604048b6ad4b15d200b9

fix: make config params optional

view details

Danny Koppenhagen

commit sha dcaff24eda21506bf555db056899ca06e9cd9c14

chore(release): 0.0.10

view details

push time in a month

issue closedd-koppenhagen/scully-plugin-mermaid

allow to define the wrapper-elements class

Currently the SVG is wrapped into a div with the classname: .mermaid-svg. This should be configurable:

{ // optional - no wrapper when set to 'false', 'true' uses defaults
  tagName: 'div' // default
  className: '.mermaid-svg' // default
}

closed time in a month

d-koppenhagen

push eventd-koppenhagen/scully-plugin-mermaid

Danny Koppenhagen

commit sha 29e4afade0d3c922e529db0cd9d799ce204f2ea1

feat: allow to define the selector for mermaid content use `.language-mermaid` by default. BREAKING CHANGE The configuration no longer anly passes through the `MermaidAPI.Config`. This is now wrapped into the `config` key in the new interface `MermaidPluginConfig` that holds more options. **Old**: ``` import MermaidAPI from 'mermaid/mermaidAPI'; // ... const mermaidOptions: MermaidAPI.Config = { theme: 'dark', }; ``` **New**: ``` import { /* ... */, MermaidPluginConfig } from 'scully-plugin-mermaid'; // ... const mermaidOptions: MermaidPluginConfig = { // ... other config options config: { theme: 'dark' } }; ``` closes #2

view details

push time in a month

issue closedd-koppenhagen/scully-plugin-mermaid

Make selector configurable

make the selector for the mermaid-content configurable

currently hard-coded as:

const selector = '.language-mermaid';

closed time in a month

d-koppenhagen

created tagd-koppenhagen/scully-plugin-mermaid

tagv0.0.8

A Scully.io postRenderer to generate a SVGs from mermaid source code sections in markdown files

created time in a month

created tagd-koppenhagen/scully-plugin-mermaid

tagv0.0.9

A Scully.io postRenderer to generate a SVGs from mermaid source code sections in markdown files

created time in a month

push eventd-koppenhagen/scully-plugin-mermaid

Danny Koppenhagen

commit sha 469acba181b481ac7319f5c601c13e7ccacdaf6b

fix: replace whole `pre` element

view details

Danny Koppenhagen

commit sha b8daf79af9c42aff19bf1b11d83e9b8bfcd864e7

chore(release): 0.0.8

view details

Danny Koppenhagen

commit sha cc53d26286cfd4479d4a973af7ce0c24c13bad33

Revert "fix: replace whole `pre` element" This reverts commit 469acba181b481ac7319f5c601c13e7ccacdaf6b.

view details

Danny Koppenhagen

commit sha 0fb8a822eb7ab3f374edb04bffc01df8a2fbc0e8

chore(release): 0.0.9

view details

Danny Koppenhagen

commit sha 5f7915aa10c168fd1e1bc0a35366e6cebe06c794

fix: replace the whole `pre`-Element closes #1

view details

push time in a month

issue closedd-koppenhagen/scully-plugin-mermaid

Replace whole `pre` element

Currently the resulting SVG is inserted inside the code / pre HTML element. The whole element should be replaced after post-rendering.

closed time in a month

d-koppenhagen

issue openedd-koppenhagen/scully-plugin-mermaid

allow to define the wrapper-elements class

Currently the SVG is wrapped into a div with the classname: .mermaid-svg. This should be configurable:

{ // optional - no wrapper when set to 'false', 'true' uses defaults
  tagName: 'div' // default
  className: '.mermaid-svg' // default
}

created time in a month

more