profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/cscheffauer/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Christoph Scheffauer cscheffauer Ross Video, Canada Salzburg, Austria https://cscheffauer.github.io/about React Frontend Dev, mainly focusing on React JS, Redux, Typescript, ...

cscheffauer/evening_routine 1

With this app you can create your own evening routine and end the day the right way 😴 🔜 🛌

cscheffauer/about 0

This Portfolio Page will give you insights about Christoph's journey to mastery in React, Redux and more. 💻

cscheffauer/book-tracker 0

"Tracks the amount of books that you've read, the ones you want to read and the progress on the ones you're reading."

cscheffauer/chat-app 0

With this chat app you can chat with your friends, edit and remove your sent messages every time and also send pictures in the chat room. Anyone with the url where the app is hosted can join. 💬

cscheffauer/keiko-corp 0

The greatest startup ever created

cscheffauer/pokedex 0

ϞϞ(๑⚈ ․̫ ⚈๑)

cscheffauer/react-resize-detector 0

A Cross-Browser, Event-based, Element Resize Detection for React

cscheffauer/utopia 0

Design ❤️ Code

startedmicrosoft/playwright-vscode

started time in a month

issue commentatomiks/tippyjs-react

Never fully hiding in Jest tests

@KubaJastrz just wanted to check in - is someone of you guys actively working on it? I can also take a closer look at it if u like :) cheers

skrivanos

comment created time in a month

issue commentatomiks/tippyjs-react

Suggestion - lazy load Tippy instances by default

@atomiks is someone actively working on that? I could take it on :)

rodrigofariow

comment created time in 2 months

push eventcscheffauer/about

cscheffauer

commit sha e871d2c3aef905ae88b9cf36839c8a218e5d00d7

styled skills

view details

push time in 2 months

push eventcscheffauer/about

cscheffauer

commit sha 5c6320fe19f41933e7ff8ee55b3446b3eeae0512

added skills constant

view details

cscheffauer

commit sha 69781dc470f36acd061c26e63a00bfe88f819fa2

updated skills

view details

push time in 2 months

push eventcscheffauer/about

cscheffauer

commit sha fb4f9e9bd068b53114dd2a71fab4ae2b06ce5b68

position content wrapper

view details

push time in 2 months

push eventcscheffauer/about

cscheffauer

commit sha c211cb7b1db5da58b246d742fabb06d15a4bb976

added background opt and social media

view details

push time in 2 months

push eventcscheffauer/about

cscheffauer

commit sha 617be735cc3ed7c5f1c7d4e65e467c497d64b93f

refactored to new design v1

view details

push time in 2 months

PullRequestReviewEvent

startedbgrins/TinyColor

started time in 3 months

issue closedconcrete-utopia/utopia

Dark mode / Theming for the editor

It would be really awesome if a dark mode for the whole app could be added, or even theming support?

I would be free for working on this :)

closed time in 3 months

cscheffauer

pull request commentconcrete-utopia/utopia

feat: added theme toggle to project settings

Thank you for this! Amazing work!

Heads up, I have just made the following changes so that we can merge this today:

  • I've reverted the changes to the styled components in documentation-components.tsx - these changes actually broke the components since it changed them from styled components to regular functional components without props
  • repositionable-control.tsx and yoga-control.tsx were updated to become functional components so that they could use the new useColorTheme hook, as they called a function that now required a colorTheme param
  • I extracted the themeOptions from the ProjectPane component in left-pane.tsx so that we weren't creating a new object each render there
  • Also in left-pane.tsx I reverted a change to the logic checking the user's login state (which looked to have been committed in error?)
  • I added some memoisation of 3 components that you had converted into functional components (thank you!)

Thanks a lot, @Rheeseyb. Regarding the styled-components - we should create functional components for all of them and use styled-components within them. This will give us more flexibility when we want to pass in props, add state or hooks (like i was trying to).

Oh thank u, the logic for the user login state was a mistake :)

cscheffauer

comment created time in 3 months

PR opened concrete-utopia/utopia

feat: added theme toggle to project settings

Fixes #[1417]

Problem: Toggling the theme of the editor

Fix: See commit details below

Commit Details:

  • added theme toggle component to project settings
  • added set_current_theme action
  • added theme to editor state
  • exported useColorTheme hook from theme
  • consumed useColorTheme in functional components
+657 -316

0 comment

68 changed files

pr created time in 3 months

create barnchcscheffauer/utopia

branch : feat-theme-toggle

created branch time in 3 months

startedgaearon/react-lag-radar

started time in 3 months

issue commentconcrete-utopia/utopia

Dark mode / Theming for the editor

@maltenuhn definitely interested in working on this. Can we discuss it further on Discord? (same username as here)

cscheffauer

comment created time in 3 months

issue commentmicrosoft/playwright

[BUG][TypeScript] Hidden state does not get proposed in Visual Studio Code

Gotcha - so we would need to change this line to include all 4 states? https://github.com/microsoft/playwright/blob/master/utils/generate_types/overrides.d.ts#L22

I could take a look at this if u like.

mxschmitt

comment created time in 3 months

issue closedmicrosoft/playwright

[Feature] Test Runner - One snapshot for all browsers

At the moment if

expect(await page.screenshot()).toMatchSnapshot('Login.png');

will be used, 3 screenshots will be created (per browser one): image

This is happening because I've used the 3 browsers in the playwright config as projects.

Is there a way to just have 1 screenshot file to compare against, so the naming ("Login") keeps persistent and cross browser comparisons can be done?

Related issue: https://github.com/microsoft/playwright/issues/7182

closed time in 3 months

cscheffauer

issue commentmicrosoft/playwright

[Feature] Test Runner - One snapshot for all browsers

Ok thanks, @aslushnikov :)

cscheffauer

comment created time in 3 months

issue commentmicrosoft/playwright

[BUG][TypeScript] Hidden state does not get proposed in Visual Studio Code

Just tried to understand it and found out that in this line: https://github.com/microsoft/playwright/blob/master/src/client/page.ts#L268 the channels.FrameWaitForSelectorOptions have & { state: 'attached' | 'visible' } attached (which is a Typescript intersection).

In the FrameWaitForSelectorOptions all 4 states (including hidden) are already defined properly: https://github.com/microsoft/playwright/blob/master/src/protocol/channels.ts#L1798

Would it be fine to remove the intersection at the page definition? Any idea why this intersection is there?

mxschmitt

comment created time in 3 months

issue openedconcrete-utopia/utopia

Dark mode / Theming

It would be really awesome if a dark mode for the whole app could be added, or even theming support?

I would be up working on this :)

created time in 3 months

issue commentmicrosoft/playwright

[Feature] Test Runner - One snapshot for all browsers

Gotcha - so you think the snapshot functionality can't be used for cross browser visual testing?

cscheffauer

comment created time in 3 months

issue commentmicrosoft/playwright

[Feature] Test Runner - One snapshot for all browsers

Right - the intention of this test is that the UI doesn't break / look different across browsers. But I guess therefore the threshold option by underlying pixelmatch library is not smart enough to ignore a bit of spacing here and there right?

cscheffauer

comment created time in 3 months

issue openedmicrosoft/playwright

[Feature] Test Runner - One snapshot for all browsers

At the moment if

expect(await page.screenshot()).toMatchSnapshot('Login.png');

will be used, 3 screenshots will be created (per browser one): image

This is happening because I've used the 3 browsers in the playwright config as projects.

Is there a way to just have 1 screenshot file to compare against, so the naming ("Login") keeps persistent and cross browser comparisons can be done?

Related issue: https://github.com/microsoft/playwright/issues/7182

created time in 3 months