profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/coreyfarrell/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

akheron/jansson 2454

C library for encoding, decoding and manipulating JSON data

cfware/node-preload 5

Request that Node.js child processes preload modules

cfware/no-webcomponents 4

An element that displays only when webcomponents are unsupported.

cfware/eslint-config-node 0

ESLint configuration for scripts to be loaded by node.js

cfware/ncu-walk 0

Generate a fake package.json with dependencies for all packages in node_modules

coreyfarrell/acorn-private-class-elements 0

Helpers for supporting private class methods and fields in acorn

coreyfarrell/append-transform 0

handle multiple require hooks

coreyfarrell/arborist-issues 0

Demonstrate arborist issues

coreyfarrell/asterisk 0

Mirror of the Asterisk Project repository on https://gerrit.asterisk.org

coreyfarrell/asterisk-ci 0

Asterisk testing

Pull request review commenttapjs/libtap

fix: do not break if global.process missing

 const Module = require('module') const { isAbsolute } = require('path')+const process = require('./process.js')+const { platform } = process

As before it seems like we could just keep using process.platform in the rest of the code but not a blocker.

isaacs

comment created time in 2 days

Pull request review commenttapjs/libtap

fix: do not break if global.process missing

 'use strict' +const { versions = { node: '' }, stdout } = require('./lib/process.js')

Same comment as other places we could just const process = require('./lib/process.js'); and mostly leave the rest of the file as it was.

isaacs

comment created time in 2 days

Pull request review commenttapjs/libtap

fix: do not break if global.process missing

 class Snapshot {     this.indexes = new Map()     // name them .test.cjs so that nyc ignores them     // base on main test filename, with sanitized argv-    const args = process.argv.slice(2)+    const args = argv.slice(2)

Potentially a breaking change? Someone could change process.argv before we get here and that currently would impact this function.

isaacs

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenttapjs/libtap

fix: do not break if global.process missing

 'use strict' +const process = require('./process.js')+const { hrtime } = process

Not sure why we don't just keep using process.hrtime() where we previously did but not a blocker.

isaacs

comment created time in 2 days