profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/coolreader18/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Noa coolreader18 https://coolreader18.github.io RustPython core contributor. Chicode member. Embedded Rust software engineering intern @Dwelo. they/them.

chicode/lisa 2

A Lisp dialect designed for codingworkshops

coolreader18/asdf-wasi-sdk 2

An asdf plugin for the WASI sdk

coolreader18/bookmarklet-loader 2

DEPRECATED. Please use https://github.com/coolreader18/legume-loader/        A bookmarklet loader that allows for updating your bookmarklet remotely

coolreader18/audio-bookmarklet 1

A tool to make audio-playing bookmarks

coolreader18/bashed 1

Parses bash into an AST

coolreader18/betterfunction 1

An alternate language for Minecraft functions.

chicode/lisa-repl 0

A repl for Lisa

coolreader18/30-seconds-of-code 0

Curated collection of useful Javascript snippets that you can understand in 30 seconds or less.

coolreader18/adm-zip 0

A Javascript implementation of zip for nodejs. Allows user to create or extract zip files both in memory or to/from disk

pull request commenttermux/termux-packages

rust: update to 1.55.0

well, I guess we'll see if 1.55 fixes the issue since CI's running anyway :upside_down_face:

coolreader18

comment created time in 19 minutes

pull request commenttermux/termux-packages

rust: update to 1.55.0

Ah, shoot, nevermind, I didn't realize that #7339 was still stuck.

coolreader18

comment created time in 29 minutes

PR opened termux/termux-packages

rust: update to 1.55.0
+3 -4

0 comment

1 changed file

pr created time in 30 minutes

create barnchcoolreader18/termux-packages

branch : rust-1.55

created branch time in 30 minutes

push eventcoolreader18/termux-packages

Yaksh Bariya

commit sha 1ef9ed16d59b3b98b0d290d553771ea99ea214db

`proton-bridge`: Do not cache Golang dependencies for now

view details

Termux Github Actions

commit sha 8d286409e4856aafdeec5e1198cb5919293ec8b8

slides: update to 0.4.1 This commit has been automatically submitted by Github Actions.

view details

Yaksh Bariya

commit sha c676093cf6b0a5a9d1be7a7480128d9efd4e4b42

`geth`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha e0d69cae4275d7b7a4a955b0a27795b528933d89

`git-lfs`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha b930bd7f909677cc52d7410ea3e7da5c4e3deb95

`gitea`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 6f2e2aa4b8e680b0a9927028800980fb5c62bd52

`gogs`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha ebf7d0958d5a6499210b7cd35853d8dc184e83a6

`gopass`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 7f9d3c00be99343fa20feed2771e7a81eaf7b56c

`gotty`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 1b865424ceaa449ced811d877725442d1279c54c

`helm`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 43acfd21d3a1f06ad7a143c3d88f3a85e7a16e3e

`hub`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 745a61f21925a1253d47e27d868747f066851d97

`hydroxide`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha eaad52ef4b0ba32d4af02a53653bd2b2f81e0120

`ipfs`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 906c841dab6089e8dfe86e32f21e4c2cfa82e636

`jfrog-cli`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 7cfd21460c04cb0cc6cd8ee85ad04b741b3ff349

`k9s`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 6462ad200d653a56f796e91540be508d54d1e1a8

`keybase`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 38644b9a5e109afe89c85aebbd5b6c42426fb156

`kubectl`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 31b5ca4353bff9edbf9e38d7c74650c410de2619

`vegeta`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha aa94aaf5ff5116cdc0088dc5e2dc78ae6860b5d5

`virustotal-cli`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 0fab4c6c949e76ce3415066fac4ae6c506cd7b9f

`wuzz`: Cache Golang dependencies

view details

Yaksh Bariya

commit sha 76c5b974174e3f519a877b9d6147c4bc72f78c53

`ylutubedr`: Cache Golang dependencies

view details

push time in 32 minutes

issue commentnix-rust/nix

Change Sockaddr to a union

Would this be pre or post 0.23?

asomers

comment created time in an hour

issue commentnix-rust/nix

Change Sockaddr to a union

But SockaddrLike and a wrapper type for sockaddr_storage do seem like good ideas!

asomers

comment created time in an hour

issue commentnix-rust/nix

Change Sockaddr to a union

That seems like a good idea! The one concern I'd have is that it makes it harder to introspect a SockAddr, since you can't match on a union. Also, a union would just make it slightly easier to cast to the desired types, you could just do &self.sockaddr_storage as *const _ as *const sockaddr_foo, and I'd guess the public API would be the same no matter the inner casting strategy used. To me, SockAddr is useful because it allows one to match on the sockaddr family, and making it opaque seems like a dowgrade. Though I agree, the duplicate discriminant in the current enum is sorta dumb, but iirc size_of::<SockAddr>() <= size_of::<sockaddr_storage>() since there's only a certain set of sockaddr types nix supports (with sockaddr_un being the biggest one).

asomers

comment created time in an hour

Pull request review commentRustPython/RustPython

vm::utils::ascii! -> common::ascii!

 pub fn to_ascii(value: &str) -> String {     ascii } +#[doc(hidden)]+pub const fn bytes_is_ascii(x: &str) -> bool {+    let x = x.as_bytes();+    let mut i = 0;+    while i < x.len() {+        if !x[i].is_ascii() {+            return false;+        }+        i += 1;+    }+    true+}++#[macro_export]+macro_rules! ascii {+    ($x:literal) => {{+        const _: () = {+            ["not ascii"][!::rustpython_common::str::bytes_is_ascii($x) as usize];

This can be $crate::str::...

youknowone

comment created time in 12 hours

Pull request review commentRustPython/RustPython

vm::utils::ascii! -> common::ascii!

 pub fn to_ascii(value: &str) -> String {     ascii } +#[doc(hidden)]+pub const fn bytes_is_ascii(x: &str) -> bool {+    let x = x.as_bytes();+    let mut i = 0;+    while i < x.len() {+        if !x[i].is_ascii() {+            return false;+        }+        i += 1;+    }+    true+}++#[macro_export]+macro_rules! ascii {+    ($x:literal) => {{+        const _: () = {+            ["not ascii"][!::rustpython_common::str::bytes_is_ascii($x) as usize];+        };+        unsafe { ::ascii::AsciiStr::from_ascii_unchecked($x.as_bytes()) }

Oh wait sorry this should probably also be a $crate:: reference and the ascii crate should be pub use'd somewhere

youknowone

comment created time in 12 hours

PullRequestReviewEvent
PullRequestReviewEvent

issue commentRustPython/RustPython

Error compiling RustPython to wasi

There should be better documentation for this, I'll work on it at some point.

owenthereal

comment created time in 16 hours

issue commentRustPython/RustPython

Error compiling RustPython to wasi

IIRC you have to manually point the C compiler at a wasi-sdk toolchain

owenthereal

comment created time in 16 hours

push eventcoolreader18/evdev

Noah

commit sha a458675fb8b89097d41db0a1526bc3f48b82d3b1

Update to nix 0.22, remove custom conversion from nix::Error -> io::Error

view details

Taiki Sugawara

commit sha ecd7d1a7e4084b6a30c8d50b00f41d783923d682

Implement grab and ungrab

view details

push time in 19 hours

issue commentRustPython/RustPython

get-pip.py no longer works on rustpython.

This currently works on my machine as well, there are just some warnings which I fixed in #3158

andrew-ld

comment created time in 20 hours

create barnchRustPython/RustPython

branch : pip-warnings

created branch time in 20 hours

PR opened RustPython/RustPython

Miscellaneous pip fixes

Fix pip warnings about inconsistency between distutils' sysconfig and the actual sysconfig; fix error when installing package it would say something like __env_pip__.zip is not a file

+185 -164

0 comment

7 changed files

pr created time in 20 hours

Pull request review commentRustPython/RustPython

vm::utils::ascii! -> common::ascii!

 pub fn to_ascii(value: &str) -> String {     ascii } +pub const fn bytes_is_ascii(x: &str) -> bool {

This could be #[doc(hidden)], since it's an implementation detail

youknowone

comment created time in 21 hours

PullRequestReviewEvent
PullRequestReviewEvent

issue commentRustPython/RustPython

[RFC] split rustpython_stdlib from rustpython_vm

Maybe the distinction we could have, if we kept these in rustpython-vm, is corelib instead of stdlib? Obviously a different set of priorities than Rust's core vs std, but a similar concept imo.

youknowone

comment created time in a day

issue commentRustPython/RustPython

[RFC] split rustpython_stdlib from rustpython_vm

Oh, right - like sys.builtin_module_names. These all seem preeetty core to the interpreter, except for things like functools/itertools but those are still very heavily used in all kinds of python code, they aren't like zlib which is domain-specific.

('_abc', '_ast', '_codecs', '_collections', '_functools', '_imp', '_io',
 '_locale', '_operator', '_peg_parser', '_signal', '_sre', '_stat', '_string',
 '_symtable', '_thread', '_tracemalloc', '_warnings', '_weakref', 'atexit',
 'builtins', 'errno', 'faulthandler', 'gc', 'itertools', 'marshal', 'posix',
 'pwd', 'sys', 'time', 'xxsubtype')
youknowone

comment created time in a day

issue commentRustPython/RustPython

[RFC] split rustpython_stdlib from rustpython_vm

Something I've been thinking about - oh which it seems also @DimitrisJim - some things should be core to the interpreter, right? Like _signal, or _weakref, or _codecs - imo, anything that's required to start up rustpython (and to be honest, I thought it was a given that sys/builtins would stay in the vm). CPython makes this distinction via "built-in" modules vs dlls. _io is <module 'io' (built-in)>, but zlib is <module 'zlib' from '/usr/lib/python3.9/lib-dynload/zlib.cpython-39-x86_64-linux-gnu.so'>. Obviously we don't have extension modules, but I think it's more productive/useful to put those ancillary modules in a separate crate while keeping the actually core ones in rustpython-vm.

youknowone

comment created time in a day

issue commentRustPython/RustPython

ssl load_verify_locations cadata can't work

Oh, yea, I've known about this for a while and I've tried a couple times to figure out why it doesn't work. No luck so far; I last tried a couple months ago iirc.

cn-kali-team

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentRustPython/RustPython

Refactor ssl module

 impl PySocket {         PyRwLockReadGuard::try_map(self.sock.read(), |sock| sock.get()).ok()     } -    fn sock_io(&self) -> io::Result<PyMappedRwLockReadGuard<'_, Socket>> {+    pub(crate) fn sock_io(&self) -> io::Result<PyMappedRwLockReadGuard<'_, Socket>> {

(and flush() for sockets is a no-op)

youknowone

comment created time in 2 days

Pull request review commentRustPython/RustPython

Refactor ssl module

 impl PySocket {         PyRwLockReadGuard::try_map(self.sock.read(), |sock| sock.get()).ok()     } -    fn sock_io(&self) -> io::Result<PyMappedRwLockReadGuard<'_, Socket>> {+    pub(crate) fn sock_io(&self) -> io::Result<PyMappedRwLockReadGuard<'_, Socket>> {

Maybe it would make sense to expose a pub send(&[u8]) -> io::Result<usize> and recv(&mut [u8]) -> io::Result<usize> for once the stdlib gets moved out of rustpython-vm oh I guess socket is also in stdlib. But the above still seems like a better abstraction than exposing ReadGuard.

youknowone

comment created time in 2 days