profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/computingfreak/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Milind Shah computingfreak Mumbai, India http://computingfreak.net Computer-Enthusiast, Software Developer, Technology-Evangelist, I ♥ 💻, 📱, 🎵, ✈️, ☁, 🚴 , 🍔, 🍕 !

computingfreak/dropbox.io 1

private online storage for hackers

computingfreak/now-github-starter 1

Starter project to demonstrate a project whose pull requests get automatically deployed

computingfreak/AndroidRTC 0

1on1 audio call

computingfreak/CFTest 0

Testing Custom AlertDialog on Android with Hyperlinks

computingfreak/CropTool 0

Select Area For clipping

computingfreak/device.js 0

Device.js makes it easy to write conditional CSS and/or JavaScript based on device operating system (iOS, Android, Blackberry, Windows, Firefox OS), orientation (Portrait vs. Landscape), and type (Tablet vs. Mobile).

computingfreak/english-words 0

A text file containing 355k English words

issue commentfreeCodeCamp/freeCodeCamp

TypeScript migration

@ojeytonwilliams looked at the list and my assigned files mixed up with @thecodingaviator /client/src/components/formHelpers/ and my /client/src/components/helpers/**. Just want to make sure my changes matter lol.

ojeytonwilliams

comment created time in a few seconds

PR opened JuliaLang/julia

fix excess array object padding arrays performance

We seem to be wasting space currently by excessively padding Array objects. Even though array data is only aligned to 16 bytes, we for some reason align the object size to 64 bytes, then add more (un-aligned) space anyway. Hence the smallest array object is 80 bytes when it could be 48 (or 96 -> 64 when there are some elements). I can't think of a reason to do that, but maybe I'm missing something.

before:

julia> f() = for _ in 1:10^6; []; end

julia> @btime f()
  19.540 ms (1000000 allocations: 76.29 MiB)

after:

julia> @btime f()
  18.020 ms (1000000 allocations: 45.78 MiB)
+7 -7

0 comment

1 changed file

pr created time in 4 minutes

issue commenttensorflow/tensorflow

Cannot convert a symbolic Tensor ({}) to a numpy array

Can you print out what self.embed(self.vocab) returns? If its a SymbolicTensor, then this is indeed unsupported and we should figure out if getting back a Symbolic Tensor is expected. I looked at the code and from https://github.com/ddangelov/Top2Vec/blob/master/top2vec/Top2Vec.py#L803 its a bit unclear which self.embed case is this failing for.

dbl001

comment created time in 5 minutes

issue openedcrystal-lang/crystal

Function return type to be automatically typecasted similar to assignment/function args

With Crystal:1.0.0 LLVM:10.0.0, Assignment is automatically typecasted c : Float64 = 0_i32

Function argument is automatically typecasted

def func1 ( a : Float64 )
  a
end
func1(0_i32)

But, return type casting is not done automatically. This causes compilation error - "Error: method top-level func2 must return Float64 but it is returning Int32" def func2 : Float64

Return type as Float64 is not accepted; Compilation error for func2

0 end

@asterite have clarified that the behavior is as expected with the current version. But it would be logical to have same rules applied for all these cases. While it is valid point that user would expect same type that is being enforced for the return type, then the same rule would be expected to be applied for assignment and function arg cases as well.

https://forum.crystal-lang.org/t/integer-return-type-not-typecasted-only-when-returning-from-function/3402

created time in 9 minutes

PR closed redis/redis

masterport is not allowed to be set to 0.

Since we can not start a redis server on port 0. See https://github.com/redis/redis/blob/unstable/src/server.c#L3192

Also masterport is an int. It seems better to use atoi. It's more intuitive and reduces the code. (Minor cleanup)

ref link: https://github.com/redis/redis/pull/7842

+3 -3

1 comment

1 changed file

enjoy-binbin

pr closed time in 10 minutes

push eventmoby/moby

Sebastiaan van Stijn

commit sha 888e75dfc93d6f3ecb535729a55f9c4673cf5fd0

netutils: remove unused ErrNoDefaultRoute Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha ff141d366fd7bb46a4e382e04ac84f61444fe5bb

netutils: minor cleanups Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Samuel Karp

commit sha bdd90773efe1ad7a9bd0a568a60efaa21bbb0491

Merge pull request #42502 from thaJeztah/netutils_cleanup

view details

push time in 10 minutes

PR merged moby/moby

libnetwork/netutils: minor cleanups and fixes area/networking status/2-code-review

replaces https://github.com/moby/libnetwork/pull/2590 closes https://github.com/moby/libnetwork/pull/2590

+5 -11

0 comment

2 changed files

thaJeztah

pr closed time in 11 minutes

PR opened capistrano/capistrano

Allow access to SCM::Plugin instance from deploy scripts

Accessible via scm_plugin method.

Summary

Provides a way to access the deployment's Capistrano::SCM::Plugin instance from within a deploy script. (via an scm_plugin method)

My use case for this was that I wanted to invoke git:check on my local machine, from which I trigger the deployment. As my local machine does not have a release role, it isn't possible to simply invoke the built-in rake task.

Short checklist

  • [x] Did you run bundle exec rubocop -a to fix linter issues?
  • [x] If relevant, did you create a test?
  • [x] Did you confirm that the RSpec tests pass?
+19 -1

0 comment

4 changed files

pr created time in 11 minutes

create barnchJuliaLang/julia

branch : jb/arrayalign

created branch time in 11 minutes

pull request commentkovidgoyal/calibre

Update Atlantic Recipes

Oh and the issue with the empty articles should be already fixed by https://github.com/kovidgoyal/calibre/commit/6c3f1ebb5f060895bd8dc79f193479ee07d0a26e

thekabistro

comment created time in 11 minutes

issue commentamitshekhariitbhu/Fast-Android-Networking

Unable to Build with Latest Android Studio and Kotlin (Duplicate Class)

android.useAndroidX=true

is already there by default

android.enableJetifier=true

Yes! that's solve the problem. Signs that Fast Android Networking library need to be modernized to androidX

Thank you

tohizma

comment created time in 12 minutes

push eventkovidgoyal/calibre

Kovid Goyal

commit sha 6c3f1ebb5f060895bd8dc79f193479ee07d0a26e

Fix #1933004 [TheAtlantic.com recipe not downloading article text](https://bugs.launchpad.net/calibre/+bug/1933004)

view details

push time in 12 minutes

issue commentgolang/go

runtime: finalizers not consistently run when package reflect imported

It fails often, but not 100% reliably.

FWIW, I tried it locally 50 times. It passed always. :man_shrugging:

seebs

comment created time in 13 minutes

starteddiffplug/spotless

started time in 13 minutes

PR closed kovidgoyal/calibre

Update Atlantic Recipes
  • Fix processing of Atlantic recipes as they were producing blank articles
  • Seperate out magazine & website logic to respective recipes
+130 -246

1 comment

2 changed files

thekabistro

pr closed time in 18 minutes

pull request commentkovidgoyal/calibre

Update Atlantic Recipes

I keep them identical deliberately, so changes to one can be made to the other easily. Apart from the index processing the actual article markup processing should be identical in the two recipes. Could you please resubmit your PR with just the changes you need without splitting out the magazine/web parts.

thekabistro

comment created time in 18 minutes

Pull request review commentRocketChat/Rocket.Chat

Regression: Enable unregistered servers to use their own push gateway

 settings.addGroup('Push', function() { 				_id: 'Push_enable', 				value: true, 			},-			{

Ok, did it! But with this change I had to modify one validation in server > lib > pushConfig.js, otherwise the custom certificates wouldn't work in unregistered servers.

lucassartor

comment created time in 18 minutes

push eventRocketChat/Rocket.Chat

lucassartor

commit sha 5d92b27d135125743c67ddaeeaef7bd88b8479b8

fix requested changes

view details

push time in 18 minutes

issue commentpsf/requests

Allow for other JSON packages

You can call ujson.loads(resp.text)?

achapkowski

comment created time in 18 minutes

issue commentJuliaLang/julia

Greater than 100% compilation time reported by @time

Maybe I'm barking up the wrong tree. This seems like a fix https://github.com/JuliaLang/julia/pull/41286

CameronBieganek

comment created time in 19 minutes

PR opened JuliaLang/julia

Reviewers
Ensure `@time`'s inner timing operations are compiled. Fixes >100% compilation time reports

Fixes https://github.com/JuliaLang/julia/issues/41281

It seems like the case in https://github.com/JuliaLang/julia/issues/41281 that results in @time reporting >100% compilation time is fixed by pre-running the timing sampling lines within @time to ensure they're compiled(?)

Perhaps instead of this PR, I wondered if there's some type instability/invalidation going on that could be fixed, given that @time 1+1 is baked into the sysimage? Or, perhaps this PR is a failsafe solution?

Master

julia> @time map(x -> 2x, 1:3);
  0.035300 seconds (52.03 k allocations: 3.258 MiB, 107.03% compilation time)

julia> @time map(x -> 2x, 1:3);
  0.028745 seconds (49.72 k allocations: 3.057 MiB, 99.36% compilation time)
julia> x = rand(2,2);

julia> @time x * x;
  0.651758 seconds (2.54 M allocations: 140.827 MiB, 5.07% gc time, 99.95% compilation time)

julia> @time x * x;
  0.000006 seconds (1 allocation: 112 bytes)

This PR

julia> @time map(x -> 2x, 1:3);
  0.032076 seconds (52.04 k allocations: 3.241 MiB, 98.54% compilation time)

julia> @time map(x -> 2x, 1:3);
  0.029221 seconds (49.72 k allocations: 3.057 MiB, 99.45% compilation time)
julia> x = rand(2,2);

julia> @time x * x;
  0.632906 seconds (2.54 M allocations: 140.827 MiB, 7.51% gc time, 99.94% compilation time)

julia> @time x * x;
  0.000005 seconds (1 allocation: 112 bytes)

If anyone has any other @time calls that result in >100% I'd happily test them with this

+12 -0

0 comment

1 changed file

pr created time in 19 minutes

issue commentnotepad-plus-plus/notepad-plus-plus

Removing Google Search due to censorship and ethical concerns

I'll be switching to Visual Studio Code.

You don't see the irony here on this subject that Bing and VSCode are developed by the same company?

@marekr That's... kind of the point. I love Bing, I use it as my primary search engine. I'm a huge Microsoft fan. I love almost all of their products and the way they run their business is exceptional compared to others (because I've put much research into it and I've learned each alternative and product and know what I like, as compared to blindly following what's been given to me). I know that me leaving doesn't make a hint of difference, but, after all, the removal of this feature didn't make a hint of difference either did it? Or any of this complaining? Or, heck, what's even the point of talking about it? Like you said, the dev can do whatever he wants. As such, we can also do whatever we want.

I mean, if we're going to ignore the vocal part of the userbase, why even bother having opinions, right? Sorry, that's jumping to conclusions, but you can see where I'm going. It's a huge pet peeve of mine that a developer would make something open source, allow the community to contribute and discuss, and then when the community actually does that, they get shunned and pushed away like we're not supposed to talk about it or something.

ocdtrekkie

comment created time in 22 minutes

Pull request review commentminio/minio

Use multipart call for replication

 func replicateObject(ctx context.Context, ri ReplicateObjectInfo, objectAPI Obje 	} } +func replicateObjectWithMultipart(ctx context.Context, c *miniogo.Core, bucket, object string, r io.Reader, objInfo ObjectInfo, opts miniogo.PutObjectOptions) (uploadID string, err error) {+	var uploadedParts []miniogo.CompletePart+	uploadID, err = c.NewMultipartUpload(context.Background(), bucket, object, opts)+	if err != nil {+		return+	}+	var (+		hr    *hash.Reader+		pInfo miniogo.ObjectPart+	)+	for _, partInfo := range objInfo.Parts {+		hr, err = hash.NewReader(r, partInfo.Size, "", "", partInfo.Size)+		if err != nil {+			return+		}+		pInfo, err = c.PutObjectPart(ctx, bucket, object, uploadID, partInfo.Number, hr, partInfo.Size, "", "", opts.ServerSideEncryption)+		if err != nil {+			return+		}+		if pInfo.Size != partInfo.Size {+			return uploadID, fmt.Errorf("Part size mismatch: got %d, want %d", pInfo.Size, partInfo.Size)+		}+		uploadedParts = append(uploadedParts, miniogo.CompletePart{+			PartNumber: pInfo.PartNumber,+			ETag:       pInfo.ETag,+		})+	}+	_, err = c.CompleteMultipartUpload(ctx, bucket, object, uploadID, uploadedParts, miniogo.CompleteMultipartUploadOptions{Internal: miniogo.AdvancedCompleteMultipartOptions{+		SourceMTime:        objInfo.ModTime,+		ReplicationRequest: true, // always set this to distinguish between `mc mirror` replication and serverside+	}})+	return

Instead of taking in a new struct CompleteMultipartUploadOptions we should take just PutObjectOptions{} all the necessary fields are already present.

poornas

comment created time in 26 minutes

issue commentrust-lang/rust

error: internal compiler error: encountered incremental compilation error with predicates_of(bitpacking[28cc]::BitPacker)

That's interesting. The fact that you were getting the ICE consistently would seem to rule out any kind of transient I/O issue - Rust would need to fail to open /home/rana/.cargo/registry/src/github.com-1ecc6299db9ec823/bitpacking-0.8.4/src/lib.rs each time you got the ICE.

I've opened https://github.com/rust-lang/rust/issues/86480 to track an issue that I've discovered from investigation this. It's possible that these two issues are actually the same, but I'm not certain.

rana

comment created time in 30 minutes

pull request commentohmyzsh/ohmyzsh

docs(aliases): clarify usage

Apart from this PR that I made after seeing the new plugin in the update from ohmyzsh, I'm wondering if it's not over-engineering for a basic functionality provided by grep ?

image

So we actually have 2 plugins to do that:

cmalard

comment created time in 31 minutes

PR opened kovidgoyal/calibre

Update Atlantic Recipes
  • Fix processing of Atlantic recipes as they were producing blank articles
  • Seperate out magazine & website logic to respective recipes
+130 -246

0 comment

2 changed files

pr created time in 33 minutes

issue openedrust-lang/rust

`guess_head_span` depends on untracked state when used with an imported file

guess_head_span ends up calling ensure_source_file_source_present, which calls add_external_src. If the source file of the span is an imported file, then whether or not this method succeeds depends on the current file on disk:

https://github.com/rust-lang/rust/blob/0f6ba39fd89cff295067d974c49fc64b0b52ad18/compiler/rustc_span/src/lib.rs#L1447-L1451

However, the hash of the external crate depends on the hash of the file at the time the external crate was compiled, not the time the current crate is compiled. If the external crate is a Cargo dependency (in ~/.cargo/registry), then changing a file in the dependency will not cause it to be re-built, allowing a new compilation session to read in a different file than the one used to originally compile the external crate.

Since guess_head_span falls back to the passed-in span if reading the source file fails, the span that we end up using depends on global untracked state (the current contents of an external crate's file on disk).

created time in 33 minutes

push eventTheFinestArtist/FinestWebView-Android

noobietubie

commit sha def74c438a9a3cb3ba83e4d2456a11fd19ab691f

Fix Webview Error in Sample App with Higher API I did it! :)

view details

push time in 34 minutes

issue commentrust-lang/rust

error: internal compiler error: encountered incremental compilation error with predicates_of(bitpacking[28cc]::BitPacker)

No change to /home/rana/.cargo/registry/src/github.com-1ecc6299db9ec823/bitpacking-0.8.4/src/lib.rs. That's stable. I don't edit it.

/home/rana/.cargo is on an ordinary partition as well. Here is the output from lsblk.

rana@aum:~$ lsblk
NAME        MAJ:MIN RM   SIZE RO TYPE MOUNTPOINT
sda           8:0    0 238.5G  0 disk 
└─sda1        8:1    0 238.5G  0 part 
sr0          11:0    1  1024M  0 rom  
nvme0n1     259:0    0   1.1T  0 disk 
├─nvme0n1p1 259:1    0   512M  0 part /boot/efi
└─nvme0n1p2 259:2    0   1.1T  0 part /

The workflow was only to add new tests, and use the in-IDE "Run test" link shown in the snapshot.

image

The current output window command (that's currently working) shows:

> Executing task: cargo test -- --nocapture num_bits_pkg <

    Finished test [unoptimized + debuginfo] target(s) in 0.09s
     Running unittests (target/debug/deps/tsr-6150d47f1fc41f28)

running 3 tests
num_bits_sorted 13
num_bits_sorted 13
num_bits_sorted 13
test pck::test::num_bits_pkg_2 ... ok
test pck::test::num_bits_pkg_3 ... ok
test pck::test::num_bits_pkg ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 15 filtered out; finished in 0.00s

When I get back to that workflow of adding new tests and code I expect it to crash as consistently as it did before. But I also plan to stop using nightly because of it.

rana

comment created time in 35 minutes

PR opened Homebrew/homebrew-cask

Add shimonote v1.5.2

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • [x] Named the cask according to the token reference.
  • [x] Checked the cask was not already refused.
  • [x] Checked the cask is submitted to the correct repo.
  • [x] brew audit --new-cask <cask> worked successfully.
  • [x] brew install --cask <cask> worked successfully.
  • [x] brew uninstall --cask <cask> worked successfully.
+18 -0

0 comment

1 changed file

pr created time in 39 minutes