profile
viewpoint
Sergey Ryabov colriot @facebook London, UK

colriot/GsonKotgen 3

Kotlin codegen support for Gson TypeAdapters

colriot/QTreeClustering 3

Quad-tree clustering for GMaps

colriot/litho 1

A declarative framework for building efficient UIs on Android.

colriot/poc-kotlinx-metadata 1

POC for kotlinx-metadata lib

PR opened facebook/litho

Fix unreachable links to fix public docs publishing

Differential Revision: D32677034

+5 -0

0 comment

1 changed file

pr created time in 2 months

create barnchcolriot/litho

branch : export-D32677034

created branch time in 2 months

push eventcolriot/litho

Sergey Ryabov

commit sha a499bed9f5609610faba6304e445ab811c6ad502

Skip tests execution for OSS CI (#879) Summary: Pull Request resolved: https://github.com/facebook/litho/pull/879 tests are taking too long to execute rn, and there is this native libs loading issue and classloader forking magic. Since tests are running on internal CI, let's skip OSS one and make the CI green and enable snapshot publishing again Reviewed By: astreet Differential Revision: D32431389 fbshipit-source-id: 0f054848c1794b4e31b2b10d54f78c69dfef73cb

view details

push time in 2 months

push eventcolriot/litho

Andy Street

commit sha 9a3afaf1647513606347bb1f43773af60b8ad919

Remove event dispatch instrumentation Reviewed By: SidharthGuglani Differential Revision: D32461667 fbshipit-source-id: 419c2e635d9cfcf07fbeecbc7f85c7e8289d852b

view details

Aditya Sharat

commit sha 5fa7adec425b896d3356dce32cac91913d53b23a

Unsets the measure function when cloning YogaNode Summary: Unsets the measure function when cloning YogaNode Reviewed By: SidharthGuglani Differential Revision: D32459246 fbshipit-source-id: 38af6e44053b5a2b3061d0a92ba5fd6177550497

view details

Michal Karpinski

commit sha e44c2046f3a618e45395b76d746f936b87ce9e27

Add test for useErrorBoundary catching exceptions from a child with @OnCreateLayoutWithSizeSpec Summary: We got a support request around this, so this test makes sure things work as they should. Differential Revision: D32489700 fbshipit-source-id: 4b6c5647958d306bc063c00e96cd97d82d65e456

view details

Gil Moshayof

commit sha 993c16200405dc1d9e26d33c9794605cffb73c4f

Fix boundary condition for scrolling down Summary: IncrementalMountExtension had an issue with the scrolling down boundary condition wherein if an item is exactly out-of-screen (item bottom = visible bounds top), it would be unmounted in the 1st loop, and then immediately mounted again in the 2nd loop. Since the item is fully offscreen, the correct behaviour is for the item to be unmounted and not mounted again. Since both condition were checking for the "equals" condition in the boundary, the 2nd loop that mounts item again no longer checks for equality. Reviewed By: astreet Differential Revision: D32493895 fbshipit-source-id: ac62a0650c8de79f236469abf6aebf6aee68aa53

view details

Andy Street

commit sha d45753a9184561a2cc2687a50a15d4f224a9a62d

Update Flexbox Container docs to give more specific info about migrating from Spec API Differential Revision: D32492811 fbshipit-source-id: 61799c456a934000785ff7f92955c9074c21af00

view details

Nichole Clarke

commit sha 7e8b4897975868f003fb32e9ece76f2ef323de86

Confine Interaction Methods to Act only Summary: This diff only exposes various interaction/action functions from within `act` by moving them to a receiver that is only exposed via the `act` method. Differential Revision: D32406847 fbshipit-source-id: 352420fd3ef239525f94397877159f65ebb302bd

view details

Noah Shamash

commit sha 0e76731a3ebef9008c20aeab35d048b484ecf099

Bug Fix in PsiDiffSectionSpecModelFactory Summary: Previously props were incorrectly showing errors as they were not added correctly to the factory with the OnDiff Function. This diff fixes the error. Reviewed By: Katalune Differential Revision: D32463506 fbshipit-source-id: 8b56ef43809066bd236b4e12720298cb9be8c3d6

view details

Noah Shamash

commit sha 9475cd08325a87a6bb69390991b34fd76373cdfc

Added more tests for DiffSectionSpec Summary: This diff increases test coverage of for adding navigation with DiffSectionSpec. Reviewed By: Katalune Differential Revision: D32429494 fbshipit-source-id: bbc6b26ca1cf0f9fde7addb049437c3a64b819d0

view details

Noah Shamash

commit sha 3c6b25ccfea69dd082233f66f8e522053e7e885e

Bug fix in DiffSectionSpecModel Summary: Fixes bug where updateStateWithTransitionMethods was not defined and therefore was returning null. This caused the litho structure view to not render. Reviewed By: Katalune Differential Revision: D32460719 fbshipit-source-id: 3ec8deaf26760fde93e50db66bff34090dab3a03

view details

Noah Shamash

commit sha a9b62d908c8f1d7581b6beea910c0a6a43c85bbe

Updating Javadocs for GenerateComponentAction and ComponentStructureView Summary: updated docs to reflect new functionality with the DiffSectionSpec Reviewed By: Katalune Differential Revision: D32460895 fbshipit-source-id: f2454287ee8296dbb34d373a64b929652d79138b

view details

Nicolas Palermo

commit sha 9814f12d067fddd7a377a7978cbcf036082f1972

Release version 0.41.0 Summary: Removed the build sample kotlin. Reviewed By: passy, colriot Differential Revision: D32436517 fbshipit-source-id: cc5939e81595f359ae97dff6c81f3d917a66bdc8

view details

Michal Karpinski

commit sha 92856f0fd0e47193bb5b29fa8ed78b8032bb573f

Add missing coverage for @OnCreateMountContentPool Reviewed By: adityasharat Differential Revision: D32510152 fbshipit-source-id: ba3e5bfdbb45278625a2171ee692c7d109305546

view details

Thomas Nardone

commit sha be98f0402ace77d648ee3dac5b0e478ff280104a

Make accessibility styles nullable Summary: Allow nulls for string-like values. Reviewed By: astreet Differential Revision: D32503541 fbshipit-source-id: 0371655566a5f3504744f5c19f7dd9c24de6eb47

view details

Andy Street

commit sha 2abd168270ebf59b10bc7e1d1894034bca1da888

Correctly implement equals and hashCode for LithoTestRunConfiguration robolectric test methods Summary: Otherwise we'll crash when specifying multiple configurations because all the RobolectricFrameworkMethods evaluate as equal. Differential Revision: D32532467 fbshipit-source-id: 9ee007b5bfa46efb4d6b5290f8df48689d3b7f15

view details

Anna Powolny

commit sha f37fe6688e7da4f62db54186087c0767a53c8125

Add idle() call for testing Summary: $title Reviewed By: astreet Differential Revision: D32492230 fbshipit-source-id: c276dcbb584254b2ec414e99a64240dd3c7a8768

view details

Gil Moshayof

commit sha 1f5f090edf11f5290656d76e9b652d65f2512985

Fix MountDelegate update sequence ordering Summary: Previously, MountDelegate was iterating over all extensions, and any extension that should update would execute all lifecycle methods in a batch. This meant that if one extension setup some values during onBind, another extension might override those values in onUnbind (as happened in the task attached). To solve this, MountDelegate's update sequence now adopts the paradigm of render-unit extensions where all extensions execute a single lifecycle method before progressing to the next lifecycle method. Reviewed By: adityasharat Differential Revision: D32530788 fbshipit-source-id: e3ea735db601ecf7309f04150687562f4344b3c3

view details

Anna Powolny

commit sha e99379155661b7c77b967ad2b903142824d35793

Deprecate methods from ComponentAssert Summary: deprecating ComponentAssert methods that are using old and not the greatest way of mounting the component. Adding all of the assertions to the LithoViewAssert. (Exposed ComponentFinder class to not duplicate code as in LithoViewRule we are using some of the shared functionality) Reviewed By: astreet Differential Revision: D32431984 fbshipit-source-id: 92725a8b317c44cbe1dd2a652470e8ec2dcb85ba

view details

Nicolas Palermo

commit sha d5bc23bbea85e6ef4f37a1f41ece4d94ebcc0da1

Prepare for the next dev version Summary: Snapshots 41.1 Reviewed By: colriot Differential Revision: D32394211 fbshipit-source-id: e111c1f07f401c3ba88c4467605e79916eb12e01

view details

Gil Moshayof

commit sha e44ccbf3dad260955dfb1ed011b199b0e4ef8593

Add test runner for RCMS, and add test to ensure DynamicValues and Attributes are working well together Summary: 1. To ensure RenderCore MountState is accounted for in all tests, added a new LithoTestRunConfiguration for it. 2. Added test in DynamicPropsTest.java to ensure attributes don't get overridden by dynamic-value extension (as solved in the diff below this one in the stack) Note: Since now all litho tests run with RCMS test runner, some Litho-Mount-State specific tests have been adjusted to early return when RCMS is enabled as they are irrelevant in this case (components-pools-test). Reviewed By: astreet Differential Revision: D32532133 fbshipit-source-id: 97a5e541ff893ce2c63bbf05d491a88ed2c835a3

view details

Noah Shamash

commit sha f75188de3ff5f247b426d53cf5babf9a7a327624

Fix KComponent Template bug not generating Summary: This diff fixes an issue introduced in D32099036 (https://github.com/facebook/litho/commit/bcb6ad2423b4ee25f6f9950aed948f30b4851a84) where KComponent template files would not generate due to a name conflict between the file and the code. Differential Revision: D32534619 fbshipit-source-id: 3f24c7c9cf7cae148e6893871483663a9876e124

view details

push time in 2 months

release facebook/litho

v0.41.1

released time in 2 months

release facebook/litho

v0.41.0

released time in 2 months

created tagfacebook/litho

tagv0.41.0

A declarative framework for building efficient UIs on Android.

created time in 2 months

push eventcolriot/litho

Sergey Ryabov

commit sha fcba31b1b42c48b00d4411f5e6cd3a71ccb65982

Skip tests execution for OSS CI (#879) Summary: Pull Request resolved: https://github.com/facebook/litho/pull/879 tests are taking too long to execute rn, and there is this native libs loading issue and classloader forking magic. Since tests are running on internal CI, let's skip OSS one and make the CI green and enable snapshot publishing again Reviewed By: astreet Differential Revision: D32431389 fbshipit-source-id: 320f0b9ea3629c8c7f01b76792e36e552f7055a0

view details

push time in 2 months

push eventcolriot/litho

Sergey Ryabov

commit sha fd00f97893a81b2937202ed6cd7d55de297f0e72

Skip tests execution for OSS CI (#879) Summary: Pull Request resolved: https://github.com/facebook/litho/pull/879 tests are taking too long to execute rn, and there is this native libs loading issue and classloader forking magic. Since tests are running on internal CI, let's skip OSS one and make the CI green and enable snapshot publishing again Reviewed By: astreet Differential Revision: D32431389 fbshipit-source-id: 346e191b09d51ccd66c4a52a167517eb239196b5

view details

push time in 2 months

push eventcolriot/litho

Sergey Ryabov

commit sha caaa5c05dc45b3f0c3997476978bebf214dc29cd

Skip tests execution for OSS CI (#879) Summary: Pull Request resolved: https://github.com/facebook/litho/pull/879 tests are taking too long to execute rn, and there is this native libs loading issue and classloader forking magic. Since tests are running on internal CI, let's skip OSS one and make the CI green and enable snapshot publishing again Reviewed By: astreet Differential Revision: D32431389 fbshipit-source-id: 5bfbd7fe3ef3a0ff0192ff5f5ddf84acaa1fad16

view details

push time in 2 months

push eventcolriot/litho

Sergey Ryabov

commit sha 4a8a6f80827deca908da65042c7314d9aeaa0353

Skip tests execution for OSS CI (#879) Summary: Pull Request resolved: https://github.com/facebook/litho/pull/879 tests are taking too long to execute rn, and there is this native libs loading issue and classloader forking magic. Since tests are running on internal CI, let's skip OSS one and make the CI green and enable snapshot publishing again Reviewed By: astreet Differential Revision: D32431389 fbshipit-source-id: c1326c4ffd758cf8c2761d4442b10667cdf4e4a2

view details

push time in 2 months

push eventcolriot/litho

Sergey Ryabov

commit sha b3ad61bc950f7ef3f4c1ba87439f3e2227aaef8e

Skip tests execution for OSS CI (#879) Summary: Pull Request resolved: https://github.com/facebook/litho/pull/879 tests are taking too long to execute rn, and there is this native libs loading issue and classloader forking magic. Since tests are running on internal CI, let's skip OSS one and make the CI green and enable snapshot publishing again Reviewed By: astreet Differential Revision: D32431389 fbshipit-source-id: 0f191c385f79a131484eae79c6b4ed1d1f883b0e

view details

push time in 2 months

push eventcolriot/litho

Sergey Ryabov

commit sha 8aca8aa9f537627fb8f4e19bb02d5a74b00c4754

Skip tests execution for OSS CI (#879) Summary: Pull Request resolved: https://github.com/facebook/litho/pull/879 tests are taking too long to execute rn, and there is this native libs loading issue and classloader forking magic. Since tests are running on internal CI, let's skip OSS one and make the CI green and enable snapshot publishing again Reviewed By: astreet Differential Revision: D32431389 fbshipit-source-id: 417e751ded5e55eb9b863ff9a16e10f4770bfc89

view details

push time in 2 months

push eventcolriot/litho

Sergey Ryabov

commit sha 25ee7a020e21eb8f51f166b5d87226abab716b85

Skip tests execution for OSS CI (#879) Summary: Pull Request resolved: https://github.com/facebook/litho/pull/879 tests are taking too long to execute rn, and there is this native libs loading issue and classloader forking magic. Since tests are running on internal CI, let's skip OSS one and make the CI green and enable snapshot publishing again Reviewed By: astreet Differential Revision: D32431389 fbshipit-source-id: 35e0071b8aeee3e8b92a4431e0cdae02b7cb8fb1

view details

push time in 2 months

push eventcolriot/litho

Nicolas Palermo

commit sha 0ba8f029d21d805559c204977a36edf1a817a3d7

Fix release yml Summary: The last ubuntu version seems to default to jdk9 which does not support Jvm.current().getToolsJar(). Reviewed By: passy, colriot Differential Revision: D32408692 fbshipit-source-id: b0a606569f0103dfabe6f8dd1d2ab6702cd88d3c

view details

Nicolas Palermo

commit sha ffde3d6fb13a64e8905df7d973fe76e7237f97a7

Release version 0.41.0 Summary: Release Reviewed By: colriot Differential Revision: D32432088 fbshipit-source-id: 3cc8835f9c12ced353e5cd454d3f1763d9c0f898

view details

Gil Moshayof

commit sha c2d030d96ae5460a80af778fc90b54f1e23c2541

Move HostComponent check to Binder-specific shouldUpdate Summary: Previously, the early return in should-update sequence for HostComponents was being used by both the binder and the AttributesExtension. This meant that the AttributesExtension was not triggering an update for HostComponents when it should have been. The early return for HostComponent should only be relevant for the mount binder to avoid unmount / mount - and it should not prevent the attributes from being applied. Reviewed By: astreet Differential Revision: D32429732 fbshipit-source-id: c4645ca9299d805d4a14d11f1e86b88a6e0e46ae

view details

Sergey Ryabov

commit sha d838e9a50de52e32a30d4171d4d86a2990735bac

Skip tests execution for OSS CI (#879) Summary: Pull Request resolved: https://github.com/facebook/litho/pull/879 tests are taking too long to execute rn, and there is this native libs loading issue and classloader forking magic. Since tests are running on internal CI, let's skip OSS one and make the CI green and enable snapshot publishing again Reviewed By: astreet Differential Revision: D32431389 fbshipit-source-id: 9d9d43dafa347dd9c38adca45b5db700ccc7ee66

view details

push time in 2 months

create barnchcolriot/litho

branch : export-D32431389

created branch time in 2 months

PR opened facebook/litho

Skip tests execution for OSS CI

Summary: tests are taking too long to execute rn, and there is this native libs loading issue and classloader forking magic. Since tests are running on internal CI, let's skip OSS one and make the CI green and enable snapshot publishing again

Differential Revision: D32431389

+2 -1

0 comment

1 changed file

pr created time in 2 months

issue closedfacebook/litho

ClickEvent beyond recycler

Version

master

Hi! I have a Recycler component like a viewpager: the first screen is transparent and under it there are some components with click events; obviously the touch events are intercepted by recycler , but how can i bypass the recycler and send touch event to the underlying components ?

closed time in 3 months

FunnyDevs

issue commentfacebook/litho

ClickEvent beyond recycler

Closing this one for no activity. Please, reopen if needed

FunnyDevs

comment created time in 3 months

more