profile
viewpoint

cocoahero/android-geojson 152

A complete GeoJSON implementation for Android.

cocoahero/android-gmaps-addons 105

A collection of add-ons for the Android Google Maps API v2 framework.

cocoahero/MapKitPlus 9

A lightweight, static library that extends MapKit adding useful features such as MapBox and OpenStreetMap support.

cocoahero/gitio 8

A ruby gem to shorten github links using git.io

cocoahero/android-essentials 7

An android library containing many helpful classes and utilities for use in development.

cocoahero/pubg-swift 6

A Swift library for working with the PUBG Developer API.

cocoahero/android-tron-clock 2

Simple Tron Legacy™ inspired, Android clock app.

cocoahero/campusgps-ios 0

The iOS companion app for CampusGPS: my undergraduate capstone project.

cocoahero/campusgps-web 0

Web application component of my undergraduate capstone project.

cocoahero/guides.cocoahero.com 0

A collection of tutorials on all things programming.

PullRequestReviewEvent

push eventShopify/mobile-buy-sdk-ios

Jonathan Baker

commit sha 7bd2a2288d63d792674ee9916f291fb1894936a6

poke

view details

push time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentShopify/mobile-buy-sdk-ios

Pin API versions to appropriate months.

  • We should probably rename Scripts/get_version to get_sdk_version to avoid confusion
  • Perhaps we can look into adding an argument when the build workflow is invoked manually: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#example-workflow-configuration
dbart01

comment created time in a month

delete branch Shopify/mobile-buy-sdk-ios

delete branch : jbaker/fix-incorrect-podspec-platforms

delete time in a month

push eventShopify/mobile-buy-sdk-ios

Jonathan Baker

commit sha 08b3049cf1b851aa868c5d1bb93490cf9a043505

Update Mobile-Buy-SDK.podspec

view details

Jonathan Baker

commit sha 226c52281a8ceb718928da003f93c17554e06181

Merge pull request #1114 from Shopify/jbaker/fix-incorrect-podspec-platforms Fix Podspec Platform Versions

view details

push time in a month

PR merged Shopify/mobile-buy-sdk-ios

Fix Podspec Platform Versions

Updates the platform attributes to match Xcode and Package.swift.

+3 -3

0 comment

1 changed file

cocoahero

pr closed time in a month

PR opened Shopify/mobile-buy-sdk-ios

Reviewers
Fix Podspec Platform Versions

Updates the platform attributes to match Xcode and Package.swift.

+3 -3

0 comment

1 changed file

pr created time in a month

delete branch Shopify/mobile-buy-sdk-ios

delete branch : jbaker/fix-build-increment-version

delete time in a month

push eventShopify/mobile-buy-sdk-ios

Jonathan Baker

commit sha 273fb8cc35f59055650f091f1e13bdea718cd14c

Create release branch prior to changes.

view details

Jonathan Baker

commit sha 8a09a0ee5b1ce924b1824083ca06db2c5b46b83a

Commit version bumps.

view details

Jonathan Baker

commit sha 20ec56a0cda9f57a41acf9cd0cb8a5048c1ea448

Reset CURRENT_PROJECT_VERSION and DYLIB_CURRENT_VERSION to valid values.

view details

Jonathan Baker

commit sha 67d00f3d9963bce2e949bf8bd59dbf766a49f676

Reset patch version to 0 when incrementing.

view details

Jonathan Baker

commit sha b0dbf3eace0f81f64206d0d42281c87d34cc8712

Also update CFBundleShortVersionString when incrementing version.

view details

Jonathan Baker

commit sha feacf6a0e471bd0b9f039f5f8561b4cb90f77ebb

Commit Info.plist changes when bumping version.

view details

Jonathan Baker

commit sha c51444235eb646cda53da655832805dd9ad3fdc7

Merge pull request #1113 from Shopify/jbaker/fix-build-increment-version Version Bumping Improvements

view details

push time in a month

PR merged Shopify/mobile-buy-sdk-ios

Version Bumping Improvements
  • Resets the patch version when incrementing the version.
  • Ensures CFBundleShortVersionString is updated to match the newly incremented version.
  • Commits changed files.
+30 -42

0 comment

3 changed files

cocoahero

pr closed time in a month

PR opened Shopify/mobile-buy-sdk-ios

Reviewers
Version Bumping Improvements
  • Resets the patch version when incrementing the version.
  • Ensures CFBundleShortVersionString is updated to match the newly incremented version.
  • Commits changed files.
+30 -42

0 comment

3 changed files

pr created time in a month

push eventShopify/mobile-buy-sdk-ios

Jonathan Baker

commit sha feacf6a0e471bd0b9f039f5f8561b4cb90f77ebb

Commit Info.plist changes when bumping version.

view details

push time in a month

create barnchShopify/mobile-buy-sdk-ios

branch : jbaker/fix-build-increment-version

created branch time in a month

delete branch Shopify/mobile-buy-sdk-ios

delete branch : jbaker/synchronize-podspec-version

delete time in a month

push eventShopify/mobile-buy-sdk-ios

Jonathan Baker

commit sha 77db8e9c76b3e560dbbcc1ff58351bd3fd71c84b

Increment podspec's version automatically.

view details

Jonathan Baker

commit sha 2b56e1ed032a0732896dde1d7a391f01f0e68c0d

Clean up ruby a little bit.

view details

Jonathan Baker

commit sha e809ce86d6550053a8580938ef6e50178ed2e156

Merge pull request #1112 from Shopify/jbaker/synchronize-podspec-version Increment Podspec Version Automatically

view details

push time in a month

PR opened Shopify/mobile-buy-sdk-ios

Reviewers
Increment Podspec Version Automatically

What This Does

This is a small update to the increment_version script that also handles updating the .podspec.

+28 -12

0 comment

1 changed file

pr created time in a month

create barnchShopify/mobile-buy-sdk-ios

branch : jbaker/synchronize-podspec-version

created branch time in a month

PullRequestReviewEvent

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

 Pod::Spec.new do |s|    s.name                = 'Mobile-Buy-SDK'-  s.version             = '5.0.0'+  s.version             = '5.1.0'

Perhaps this can also be auto-generated in Scripts/increment_version?

dbart01

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

 class Global {     //  MARK: - Versions -     //     static var frameworkVersion: String {-        return self.frameworkBundle.object(forInfoDictionaryKey: "CFBundleShortVersionString") as! String+        return "\(Storefront.Schema.version)\(SDK.version)"

Ah, I didn't see the User-Agent established format. My opinion would be for using the SemVer approach of 5.1.0+2020-07 as the framework version really is a composite of the two versions, but I am also not strongly held in that regard.

dbart01

comment created time in a month

PullRequestReviewEvent

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

+//+//  SHA256.swift+//  Buy+//+//  Created by Shopify.+//  Copyright (c) 2017 Shopify Inc. All rights reserved.+//+//  Permission is hereby granted, free of charge, to any person obtaining a copy+//  of this software and associated documentation files (the "Software"), to deal+//  in the Software without restriction, including without limitation the rights+//  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell+//  copies of the Software, and to permit persons to whom the Software is+//  furnished to do so, subject to the following conditions:+//+//  The above copyright notice and this permission notice shall be included in+//  all copies or substantial portions of the Software.+//+//  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR+//  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,+//  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE+//  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER+//  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,+//  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN+//  THE SOFTWARE.+//++import Foundation+import CommonCrypto++enum SHA256 {

Probably fair to say it would be premature. I always will suggest using a system framework provided implementation of crypto whenever possible. Maybe we can just wait until we drop iOS 12 and switch entirely and save the polyfill headache.

dbart01

comment created time in a month

PullRequestReviewEvent

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

 class Global {     //  MARK: - Versions -     //     static var frameworkVersion: String {-        return self.frameworkBundle.object(forInfoDictionaryKey: "CFBundleShortVersionString") as! String+        return "\(Storefront.Schema.version)\(SDK.version)"

actually, if we wanted to follow SemVer, it should be a +. https://semver.org/#spec-item-10

dbart01

comment created time in a month

PullRequestReviewEvent

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

 class Global {     //  MARK: - Versions -     //     static var frameworkVersion: String {-        return self.frameworkBundle.object(forInfoDictionaryKey: "CFBundleShortVersionString") as! String+        return "\(Storefront.Schema.version)\(SDK.version)"

nitpick: should it be the other way around? 5.1.0/2020-07?

dbart01

comment created time in a month

PullRequestReviewEvent

pull request commentShopify/mobile-buy-sdk-ios

Swift Package Manager

Since the support files were moved out of /Dependencies, does this line need to be updated? https://github.com/Shopify/mobile-buy-sdk-ios/blob/spm/Mobile-Buy-SDK.podspec#L28

dbart01

comment created time in a month

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

+#!/usr/bin/env ruby++parent_path = File.expand_path('..', __dir__)+file_path = File.join(parent_path, 'Buy', 'Utilities', 'SDK.swift')+src = File.read(file_path)+if !src +    puts "Could not read file."+    exit(false)+end++version = src.match(/static let version = "([0-9.]+)"/i).captures[0]++components = version.split('.')+components[1] = components[1].to_i + 1

Are you meaning to be updating the major or minor version here? X.0.0 or 5.X.0? I noticed you used [1], but the current history of releases have been major version bumps.

dbart01

comment created time in a month

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

 class Global {     //  MARK: - Versions -     //     static var frameworkVersion: String {-        return self.frameworkBundle.object(forInfoDictionaryKey: "CFBundleShortVersionString") as! String+        return "\(Storefront.Schema.version)\(SDK.version)"

Should there be some sort of delimiter between these two values? Not sure if it matters for potential server-side reporting.

dbart01

comment created time in a month

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

 internal struct Header {     static var sdkVersion    = "X-SDK-Version"     static var sdkVariant    = "X-SDK-Variant"     static var queryTag      = "X-Query-Tag"-    static var language     = "Accept-Language"+    static var language      = "Accept-Language"

🎉

dbart01

comment created time in a month

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

+//+//  Log.swift+//  Pay+//+//  Created by Shopify.+//  Copyright (c) 2017 Shopify Inc. All rights reserved.+//+//  Permission is hereby granted, free of charge, to any person obtaining a copy+//  of this software and associated documentation files (the "Software"), to deal+//  in the Software without restriction, including without limitation the rights+//  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell+//  copies of the Software, and to permit persons to whom the Software is+//  furnished to do so, subject to the following conditions:+//+//  The above copyright notice and this permission notice shall be included in+//  all copies or substantial portions of the Software.+//+//  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR+//  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,+//  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE+//  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER+//  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,+//  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN+//  THE SOFTWARE.+//++import Foundation++func Log(_ string: String) {+#if DEBUG+    print(string)

nitpick: should we switch to os_log?

dbart01

comment created time in a month

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

+//+//  SHA256.swift+//  Buy+//+//  Created by Shopify.+//  Copyright (c) 2017 Shopify Inc. All rights reserved.+//+//  Permission is hereby granted, free of charge, to any person obtaining a copy+//  of this software and associated documentation files (the "Software"), to deal+//  in the Software without restriction, including without limitation the rights+//  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell+//  copies of the Software, and to permit persons to whom the Software is+//  furnished to do so, subject to the following conditions:+//+//  The above copyright notice and this permission notice shall be included in+//  all copies or substantial portions of the Software.+//+//  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR+//  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,+//  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE+//  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER+//  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,+//  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN+//  THE SOFTWARE.+//++import Foundation+import CommonCrypto++enum SHA256 {

I realize we need this for iOS 12 support, but should we add a polyfill and use CryptoKit on iOS 13+?

dbart01

comment created time in a month

Pull request review commentShopify/mobile-buy-sdk-ios

Swift Package Manager

+//+//  SHA256.swift

I don't think this file got renamed correctly as it still mentions MD5.

dbart01

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
more