profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/circulon/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

circulon/yii2-columnlistview 5

Yii 2.x List view allowing multi column layout

circulon/yii2-flag-behavior 4

Yii 2.x behavior for managing bitwise flags/settings in models

circulon/yii2-images 1

Yii2-images - behavior-based module for resizing, storing, caching and attaching images.

circulon/Absolute-Series-Scanner 0

Seasons, absolute mode, Subfolders and plexignore support...

circulon/fatfree 0

A powerful yet easy-to-use PHP micro-framework designed to help you build dynamic and robust Web applications - fast!

circulon/heroku-buildpack-ssh 0

Heroku buildpack for setting the server's ssh private key from an environment variable

circulon/homebrew 0

The missing package manager for OS X.

circulon/JODL 0

Java OpenDocument Library

circulon/Kint 0

A Yii 1.1.x extension for the Kint debugging tool

circulon/Manage-Engine-Rest-API 0

A python based interpretation of the Manage Engine Rest API, normally written in xml, used with the Service Desk Plus product.

push eventcirculon/orm

Kieren Eaton

commit sha 2b6e645eb4f1af847707d275518fc13766c9dd87

Use UUID datatype for column validation

view details

Kieren Eaton

commit sha 8ac296b4dade18bfc0805dd6703550e4f7d6d2f2

add deafult for use with primary key to auto-genetare uuid Requires the 'uuid-ossp' extension to be available to the schema

view details

Kieren Eaton

commit sha 1a35cf09610536ac182efa62750ece8e16552533

Fixed linting in helper

view details

Kieren Eaton

commit sha f510763fd0cc13cb606d4dc945477ea84b060f94

Removed premapped garmmar specific default

view details

Kieren Eaton

commit sha 13258687ccf76149282526fb982f244a221079a6

Added option to use default value as unquoted raw sql This allows functions and other grammar specific command to be utilised

view details

Kieren Eaton

commit sha 6502a0bb498cb37922f0d063aef5c5a10c6e8646

Merge branch '1.0' into patch/postgres_use_uuid_datatype

view details

Kieren Eaton

commit sha f508a5bf56b0f4e45684b60938b4ab2461fc7df5

Merge branch '1.0' of https://github.com/circulon/orm into patch/postgres_use_uuid_datatype # Conflicts: # src/masoniteorm/helpers.py

view details

Kieren Eaton

commit sha d3e5908c90742258bd0dec8259eb645d7e8b77a1

Added default_raw method

view details

Kieren Eaton

commit sha f136d6a2692be62514422c83502554950a900780

Updated all platforms to handle raw defaults

view details

Kieren Eaton

commit sha 79f842f3ed111d2b0f4a5d4401b37257228dfcdf

Added assorted tests to verify default and default_raw

view details

Kieren Eaton

commit sha 0cf63c88b07336a529cab52269309ef889651d85

Added method for wrapping column identifiers

view details

Kieren Eaton

commit sha 0c2cfda397b21778e9f59d9fa268609539cf9d92

Added wrapping of table and column identifiers for foreign key definitions

view details

Kieren Eaton

commit sha 9726299bcfa446a3cd704c7b521fbce9b1bc1425

Updated tests for foreign keys

view details

Kieren Eaton

commit sha f903548704a3e9bbc11f90c693fa0d1fd963c585

Updated SQLlite identifiers

view details

Kieren Eaton

commit sha 21b0328ef370651bf78679f415574ad3872d0f44

wrap Postgres Identifiers

view details

Kieren Eaton

commit sha 8a6f55701d6b0250db74f169fa79a893bb4408e6

Fixed TypeError when cast column value is NULL

view details

Kieren Eaton

commit sha 3c399de786c07000d999b1c5e2d9ccf86b7ce116

Fixed not trying to cast None value

view details

Kieren Eaton

commit sha a92a53a8a6df57047b7d76e243db7b5c988e9cc6

Removed unused format specifier

view details

Kieren Eaton

commit sha 75ddec47a65cf209e5e608794ddbea5e7d60cd97

Fix Postgres dattime column not having timezone

view details

Kieren Eaton

commit sha d9671670778d0f213e65c71ce934dfb323ff89f0

Use datetime type for timestamps columns This aligns the created_at and updated_at columns to have the same column type as deleted_at

view details

push time in 14 days

pull request commentMasoniteFramework/orm

Fix migration timestamps() not using datetime

@circulon conflicts here

Done

circulon

comment created time in 16 days

push eventcirculon/orm

Kieren Eaton

commit sha 2b6e645eb4f1af847707d275518fc13766c9dd87

Use UUID datatype for column validation

view details

Kieren Eaton

commit sha 8ac296b4dade18bfc0805dd6703550e4f7d6d2f2

add deafult for use with primary key to auto-genetare uuid Requires the 'uuid-ossp' extension to be available to the schema

view details

Kieren Eaton

commit sha 1a35cf09610536ac182efa62750ece8e16552533

Fixed linting in helper

view details

Kieren Eaton

commit sha f510763fd0cc13cb606d4dc945477ea84b060f94

Removed premapped garmmar specific default

view details

Kieren Eaton

commit sha 13258687ccf76149282526fb982f244a221079a6

Added option to use default value as unquoted raw sql This allows functions and other grammar specific command to be utilised

view details

Kieren Eaton

commit sha 6502a0bb498cb37922f0d063aef5c5a10c6e8646

Merge branch '1.0' into patch/postgres_use_uuid_datatype

view details

Kieren Eaton

commit sha f508a5bf56b0f4e45684b60938b4ab2461fc7df5

Merge branch '1.0' of https://github.com/circulon/orm into patch/postgres_use_uuid_datatype # Conflicts: # src/masoniteorm/helpers.py

view details

Kieren Eaton

commit sha d3e5908c90742258bd0dec8259eb645d7e8b77a1

Added default_raw method

view details

Kieren Eaton

commit sha f136d6a2692be62514422c83502554950a900780

Updated all platforms to handle raw defaults

view details

Kieren Eaton

commit sha 79f842f3ed111d2b0f4a5d4401b37257228dfcdf

Added assorted tests to verify default and default_raw

view details

Kieren Eaton

commit sha f04895018d1d87a88d3275f57c6644941b25bf1f

Merge branch '1.0' of https://github.com/MasoniteFramework/orm into patch/postgres_use_uuid_datatype # Conflicts: # tests/postgres/schema/test_postgres_schema_builder.py # tests/sqlite/schema/test_sqlite_schema_builder.py

view details

Joseph Mancuso

commit sha 8d8384ef891bfb451f1d2f7ea2e7182d184000b6

Merge pull request #499 from circulon/patch/postgres_use_uuid_datatype postgres use UUID datatype

view details

Kieren Eaton

commit sha 4b8756c330e404217f01e9793f070a9cf0e658e0

Merge branch '1.0' of https://github.com/MasoniteFramework/orm into patch/fix_timestamps_not_using_datetime # Conflicts: # tests/mysql/schema/test_mysql_schema_builder.py # tests/sqlite/schema/test_sqlite_schema_builder.py

view details

push time in 16 days

push eventcirculon/orm

Kieren Eaton

commit sha 0cf63c88b07336a529cab52269309ef889651d85

Added method for wrapping column identifiers

view details

Kieren Eaton

commit sha 0c2cfda397b21778e9f59d9fa268609539cf9d92

Added wrapping of table and column identifiers for foreign key definitions

view details

Kieren Eaton

commit sha 9726299bcfa446a3cd704c7b521fbce9b1bc1425

Updated tests for foreign keys

view details

Kieren Eaton

commit sha f903548704a3e9bbc11f90c693fa0d1fd963c585

Updated SQLlite identifiers

view details

Kieren Eaton

commit sha 21b0328ef370651bf78679f415574ad3872d0f44

wrap Postgres Identifiers

view details

Kieren Eaton

commit sha 8a6f55701d6b0250db74f169fa79a893bb4408e6

Fixed TypeError when cast column value is NULL

view details

Kieren Eaton

commit sha 3c399de786c07000d999b1c5e2d9ccf86b7ce116

Fixed not trying to cast None value

view details

Kieren Eaton

commit sha a92a53a8a6df57047b7d76e243db7b5c988e9cc6

Removed unused format specifier

view details

Joseph Mancuso

commit sha 57b97406d92f4c30d65fe997b5cc504c2779c6a9

Merge pull request #505 from circulon/patch/wrap_all_migration_identifiers Wrap all migration identifiers

view details

Joseph Mancuso

commit sha b68833841c5421ca421a90eae6b45707e43afab1

Merge pull request #504 from circulon/patch/fix_do_not_cast_null_value Fixed TypeError when cast column value is NULL

view details

Kieren Eaton

commit sha 210a2f5e2399a11e4a10255afc14e89ecf3156ca

Merge branch '1.0' of https://github.com/MasoniteFramework/orm into patch/fix_timestamps_not_using_datetime # Conflicts: # tests/mysql/schema/test_mysql_schema_builder.py # tests/postgres/schema/test_postgres_schema_builder.py # tests/sqlite/schema/test_sqlite_schema_builder.py

view details

push time in 16 days

pull request commentMasoniteFramework/orm

postgres use UUID datatype

Can you fix the conflicts here?

Done and Done

circulon

comment created time in 16 days

push eventcirculon/orm

Kieren Eaton

commit sha 0cf63c88b07336a529cab52269309ef889651d85

Added method for wrapping column identifiers

view details

Kieren Eaton

commit sha 0c2cfda397b21778e9f59d9fa268609539cf9d92

Added wrapping of table and column identifiers for foreign key definitions

view details

Kieren Eaton

commit sha 9726299bcfa446a3cd704c7b521fbce9b1bc1425

Updated tests for foreign keys

view details

Kieren Eaton

commit sha f903548704a3e9bbc11f90c693fa0d1fd963c585

Updated SQLlite identifiers

view details

Kieren Eaton

commit sha 21b0328ef370651bf78679f415574ad3872d0f44

wrap Postgres Identifiers

view details

Kieren Eaton

commit sha 8a6f55701d6b0250db74f169fa79a893bb4408e6

Fixed TypeError when cast column value is NULL

view details

Kieren Eaton

commit sha 3c399de786c07000d999b1c5e2d9ccf86b7ce116

Fixed not trying to cast None value

view details

Kieren Eaton

commit sha a92a53a8a6df57047b7d76e243db7b5c988e9cc6

Removed unused format specifier

view details

Joseph Mancuso

commit sha 57b97406d92f4c30d65fe997b5cc504c2779c6a9

Merge pull request #505 from circulon/patch/wrap_all_migration_identifiers Wrap all migration identifiers

view details

Joseph Mancuso

commit sha b68833841c5421ca421a90eae6b45707e43afab1

Merge pull request #504 from circulon/patch/fix_do_not_cast_null_value Fixed TypeError when cast column value is NULL

view details

Kieren Eaton

commit sha f04895018d1d87a88d3275f57c6644941b25bf1f

Merge branch '1.0' of https://github.com/MasoniteFramework/orm into patch/postgres_use_uuid_datatype # Conflicts: # tests/postgres/schema/test_postgres_schema_builder.py # tests/sqlite/schema/test_sqlite_schema_builder.py

view details

push time in 16 days

PR opened MasoniteFramework/orm

Fix timestamps not using datetime

This PR aligns the created_at and updated_at columns to use the same datatype as the deleted_at column.

It also adjusts the pstgres datetime datatype to use the TIMESTAMPTZ which includes timezone data

+20 -14

0 comment

5 changed files

pr created time in 23 days

push eventcirculon/orm

Kieren Eaton

commit sha 8a7b34abaf846e227846e370898f3e2596375082

Add using current _timestamp to datetime columns

view details

Kieren Eaton

commit sha 03c541bd30cf7146720c25c07fd9bc1fe6d158d1

Updated Tests

view details

push time in 23 days

create barnchcirculon/orm

branch : patch/fix_timestamps_not_using_datetime

created branch time in 23 days

Pull request review commentMasoniteFramework/orm

Wrap all migration identifiers

 def compile_alter_sql(self, table):                 sql.append(                     f"ALTER TABLE {self.wrap_table(table.name)} ADD "                     + self.get_foreign_key_constraint_string().format(-                        clean_column=column,+                        clean_column=self.wrap_column(column),

@josephmancuso Hmm interesting...

As it turns out the clean_column specifier is not actually used in any of the platforms get_foreign_key_constraint_string() method. looks like an oversight that crept in, so I haave removed it from both the locations it appears.

I Missed that when I was going through all of the tests.

circulon

comment created time in 23 days

PullRequestReviewEvent

push eventcirculon/orm

Kieren Eaton

commit sha a92a53a8a6df57047b7d76e243db7b5c988e9cc6

Removed unused format specifier

view details

push time in 23 days

push eventcirculon/orm

Kieren Eaton

commit sha 3c399de786c07000d999b1c5e2d9ccf86b7ce116

Fixed not trying to cast None value

view details

push time in 24 days

issue commentMasoniteFramework/orm

Migrations not wrapping table/column names

@josephmancuso I have added a PR #505 to address this issue

circulon

comment created time in 25 days

PR opened MasoniteFramework/orm

Wrap all migration identifiers

This PR fixes issues where table and column identifiers which are not wrapped (for the grammar) would be incorrectly interpreted as keywords (eg USER)

+180 -170

0 comment

14 changed files

pr created time in 25 days

create barnchcirculon/orm

branch : patch/wrap_all_migration_identifiers

created branch time in 25 days

PR opened MasoniteFramework/orm

Fixed TypeError when cast column value is NULL

We should not attempt to cast a NULL column value

+1 -1

0 comment

1 changed file

pr created time in 25 days

create barnchcirculon/orm

branch : patch/fix_do_not_cast_null_value

created branch time in 25 days

issue commentMasoniteFramework/orm

Migrations not wrapping table/column names

Alter queries should wrap the table. Anywhere really there is a table, it should be using self.wrap_table(table_name)

This is specifically for the use case where you name the table keyword or something

Thanks @josephmancuso Yeah that makes sense. After thinking about this further I realised that the format strings are a command layout vs a specific formatting per grammar for the values to be input.

ok so I will put a PR together to make this more robust. This will then bring them inline with how the QueryBuilder wraps tables and columns.

Cheers for the input

circulon

comment created time in a month

issue openedMasoniteFramework/orm

Migrations not wrapping column names

Describe the bug When using migrations the alter queries are not wrapping table and column names correctly. This causes an issue when using a table name that is also a reserved keyword.

eg the following will produce a syntax error in postgres and possibly other engines. In this example there is already a table created called "user"

        with self.schema.create("user_profile") as table:
            table.uuid("id").default_raw("uuid_generate_v4()").primary()
            table.uuid("user_id").add_foreign("user_id.id.user").on_update('cascade').on_delete("restrict")

This throws a syntax error from psycopg2 like this

psycopg2.errors.SyntaxError: syntax error at or near "user"
LINE 1: ..._user_id_foreign FOREIGN KEY (user_id) REFERENCES user(id) O...
                                                                                                         ^

My initial thought was to update the "get_foreign_key_constraint_string()" to include the '"' in the appropriate spots but then looking at the other Platforms format strings none of them have their respective table/column identifiers (eg mssql is []) either.

So the other option is to use the self.wrap_table() in all the appropriate places but this makes the code slightly less readable.

@josephmancuso I would appreciate your input for a direction on this as it will affect all platforms at some point and I would like to put another PR to fix this in.

Expected behavior The alter query that is built should have appropriately wrapped table and column identifiers

What database are you using?

  • Type: Postgres
  • Version 10
  • Masonite ORM latest

created time in a month

Pull request review commentMasoniteFramework/orm

postgres use UUID datatype

 def after(self, after):         self.after = after         return self -    def default(self, value):+    def default(self, value, raw=False):

@josephmancuso

Added the default_raw() method as suggested Added variations across all grammars tests for both .default("value", True) and .default_raw("value")

circulon

comment created time in a month

PullRequestReviewEvent

push eventcirculon/orm

Kieren Eaton

commit sha d3e5908c90742258bd0dec8259eb645d7e8b77a1

Added default_raw method

view details

Kieren Eaton

commit sha f136d6a2692be62514422c83502554950a900780

Updated all platforms to handle raw defaults

view details

Kieren Eaton

commit sha 79f842f3ed111d2b0f4a5d4401b37257228dfcdf

Added assorted tests to verify default and default_raw

view details

push time in a month

push eventcirculon/orm

Kieren Eaton

commit sha 7b0741b8099ae9216c3e81aa59bb90c05a5bfee4

Fixed multiple null and not null clauses not separated correctly

view details

Kieren Eaton

commit sha c3cbe3704585c8534e6f3fc307cdc2cacc498f1a

Removed where clause The where clause is not a valid part of a join

view details

Kieren Eaton

commit sha 478621cc316c00aa9243c04bed3fd2305676d4fb

Implement on_value and friends Implementoed: on_value() on_null() on_not_null() and the 'OR' alternatives or_on_value() or_on_null() or_on_not_null()

view details

Kieren Eaton

commit sha 66822cc100bed8b344a011e3b4396d43998a9089

Simplified loop structure

view details

Kieren Eaton

commit sha 417e80ab2b8f01bbd0f9f3c5ddf58b85fce84fdf

Fixed iteration over clauses

view details

Kieren Eaton

commit sha 257909fe1da5ce1ea0e1a267f5f7a4c32fd870ac

Updated Tests

view details

Kieren Eaton

commit sha 89194a26a1e21f12e9f76d35255361e800948e86

Fixed Linting

view details

Kieren Eaton

commit sha 87a61ef7eed300f51e3fc95e5c3d35c2bdf863a9

Fixed more linting issues

view details

Kieren Eaton

commit sha 080465a168b4a2c66fb6be5b10c8ae38304577a7

Blacked helpers linting issues

view details

Kieren Eaton

commit sha bb029ab7db18db1ac326c3a56d68a33a764ad078

Removed where from BaseGrammar

view details

Kieren Eaton

commit sha fa9a90c2c32482f30ae34edaa7bd6d0314f09fda

Fixed bindings order issue

view details

Kieren Eaton

commit sha 66b77b2ad5197d79a4f0c7e6b8b36bed749b4c80

Added where clause back as an alias of on_value Added deprecation warning to the where method

view details

Kieren Eaton

commit sha 00a2bece42cfce3aa4bcce13d0008c4fa8bc0be6

Fixed Tests Helpers was defined as a module and a file

view details

Kieren Eaton

commit sha 8d96cdf858b73c49684ca6cafef7a7639ec9a722

Merge branch '1.0' into patch/fix_join_on_value

view details

Kieren Eaton

commit sha ad97d5815cee2af44310082dee1ef58295c16a0b

Refined tests Updated on_value and on_null tests to prove that an 'on' (aka column comparison) is not actually required

view details

Kieren Eaton

commit sha 45aff32dad6ae6414896afa596ea3decf4ef4589

Updated method doctoring

view details

Kieren Eaton

commit sha 68821f59959e37cb7a4c1f82c6922e8fe39c4f67

Merge branch 'patch/fix_join_on_value' of https://github.com/circulon/orm into patch/fix_join_on_value

view details

Joseph Mancuso

commit sha f6fe981d9f0ae7125cc8b618e0eead6567621756

Merge pull request #495 from circulon/patch/fix_join_on_value

view details

Kieren Eaton

commit sha 7a0d40ce7ba26c5409e81544af0d33ab7262e7e5

Fix left & right joins could not use lambda

view details

Kieren Eaton

commit sha 96a45cd15f4f4981d128f85072a1ec41907a83c3

Updated tests

view details

push time in a month

push eventcirculon/orm

Kieren Eaton

commit sha 7a0d40ce7ba26c5409e81544af0d33ab7262e7e5

Fix left & right joins could not use lambda

view details

Kieren Eaton

commit sha 96a45cd15f4f4981d128f85072a1ec41907a83c3

Updated tests

view details

Joseph Mancuso

commit sha c7917d1a3ce9b19514004cdfb328dd0fa762ff21

Merge pull request #502 from circulon/patch/other_joins_use_lambda Fix other joins cannot use lambda

view details

push time in a month

Pull request review commentMasoniteFramework/orm

postgres use UUID datatype

 def after(self, after):         self.after = after         return self -    def default(self, value):+    def default(self, value, raw=False):

Yep NP Will work on these this afternoon

circulon

comment created time in a month

PullRequestReviewEvent

PR opened MasoniteFramework/orm

Patch/other joins use lambda

This PR enables lambda usage for left and right joins

+129 -3

0 comment

6 changed files

pr created time in a month

create barnchcirculon/orm

branch : patch/other_joins_use_lambda

created branch time in a month

push eventcirculon/orm

Kieren Eaton

commit sha 7b0741b8099ae9216c3e81aa59bb90c05a5bfee4

Fixed multiple null and not null clauses not separated correctly

view details

Kieren Eaton

commit sha c3cbe3704585c8534e6f3fc307cdc2cacc498f1a

Removed where clause The where clause is not a valid part of a join

view details

Kieren Eaton

commit sha 478621cc316c00aa9243c04bed3fd2305676d4fb

Implement on_value and friends Implementoed: on_value() on_null() on_not_null() and the 'OR' alternatives or_on_value() or_on_null() or_on_not_null()

view details

Kieren Eaton

commit sha 66822cc100bed8b344a011e3b4396d43998a9089

Simplified loop structure

view details

Kieren Eaton

commit sha 417e80ab2b8f01bbd0f9f3c5ddf58b85fce84fdf

Fixed iteration over clauses

view details

Kieren Eaton

commit sha 257909fe1da5ce1ea0e1a267f5f7a4c32fd870ac

Updated Tests

view details

Kieren Eaton

commit sha 89194a26a1e21f12e9f76d35255361e800948e86

Fixed Linting

view details

Kieren Eaton

commit sha 87a61ef7eed300f51e3fc95e5c3d35c2bdf863a9

Fixed more linting issues

view details

Kieren Eaton

commit sha 080465a168b4a2c66fb6be5b10c8ae38304577a7

Blacked helpers linting issues

view details

Kieren Eaton

commit sha bb029ab7db18db1ac326c3a56d68a33a764ad078

Removed where from BaseGrammar

view details

Kieren Eaton

commit sha fa9a90c2c32482f30ae34edaa7bd6d0314f09fda

Fixed bindings order issue

view details

Kieren Eaton

commit sha 66b77b2ad5197d79a4f0c7e6b8b36bed749b4c80

Added where clause back as an alias of on_value Added deprecation warning to the where method

view details

Kieren Eaton

commit sha 00a2bece42cfce3aa4bcce13d0008c4fa8bc0be6

Fixed Tests Helpers was defined as a module and a file

view details

Kieren Eaton

commit sha 8d96cdf858b73c49684ca6cafef7a7639ec9a722

Merge branch '1.0' into patch/fix_join_on_value

view details

Kieren Eaton

commit sha ad97d5815cee2af44310082dee1ef58295c16a0b

Refined tests Updated on_value and on_null tests to prove that an 'on' (aka column comparison) is not actually required

view details

Kieren Eaton

commit sha 45aff32dad6ae6414896afa596ea3decf4ef4589

Updated method doctoring

view details

Kieren Eaton

commit sha 68821f59959e37cb7a4c1f82c6922e8fe39c4f67

Merge branch 'patch/fix_join_on_value' of https://github.com/circulon/orm into patch/fix_join_on_value

view details

Joseph Mancuso

commit sha f6fe981d9f0ae7125cc8b618e0eead6567621756

Merge pull request #495 from circulon/patch/fix_join_on_value

view details

push time in a month