profile
viewpoint

chungy/reflac 29

Shell script to recompress FLAC files

chungy/cmdpack 11

mirror/fork of cmdpack by Neill Corlett

chungy/diveintopython 9

Dive Into Python 5.4, for Python2

chungy/Dive-Into-Python-3 5

Push of Mark Pilgrim's DIP3 after his disappearance

chungy/ex-vi 3

lift of the ex-vi CVS repo

chungy/chocolate-doom 2

Chocolate Doom is a Doom source port that is conservative and historically accurate.

chungy/CssGitHubWindows 2

(UserStyle) GitHub Windows Edition [MIT]

chocolatiers/ChocoRenderLimits 1

This is ChocoRenderLimits which is used to assist vanilla mappers in testing and keeping within vanilla limits.

chungy/doom-pwads 1

Make PWADs of Doom's levels

chungy/doomretro 1

The classic, refined DOOM source port. For Windows PC.

push eventchungy/dolphin

PEmu2

commit sha 84e3078307b73715d2b69cb48514d7fc31fe0e04

Change "Wiimote" to "Wii Remote" in interface

view details

JosJuice

commit sha 6fe96d12c6a281a93e5bb0c877f26fc0318e3568

Jits: Don't use fast double-to-single when input is double precision The fast path of using CVTSD2SS/FCVTN rounds the significand if it can't be exactly represented as a single, whereas the accurate path instead truncates the significand. So we should only use the fast path if we know that the lower bits of the significand are not set. This is not known to affect any games.

view details

Dentomologist

commit sha cb127509e1e55f31bc55cd72676de421f904cdb0

WiimoteReal: Fix Dolphin shutdown crash Clear m_scan_thread_running later to avoid accessing m_backends after it has been cleared.

view details

Sepalani

commit sha 0b0bab11d8fadf1a36bf7f4ef8c3358fd68eedb4

PPCSymbolDB: Improve symbol map column detection

view details

Pokechu22

commit sha 3a4d8379bf16e61348dafc1750a8e4b65394f7a9

Convert NaN to 1 when generating texture coordinates This fixes eyelids in Shadow the Hedgehog during cutscenes (https://bugs.dolphin-emu.org/issues/11458)

view details

Simonx22

commit sha 9a33fd3f7fb0e468394a44250fe1306bbb55d19b

Android: update dependencies

view details

OatmealDome

commit sha 46e331d000e0af8986189fb937f2b68f7dcb9bd1

VideoBackendBase: Prefer Vulkan over OGL on macOS Mojave and newer

view details

Tillmann Karras

commit sha f45bb89e971b578719ce3ef2313680e0ad633ed1

DSPHLE: report games that use unimplemented AX features Not including GC DPL2 mixing here since it's easy to find games that use it.

view details

Tilka

commit sha dba1e1e9f7db3cac13a324b226385b0117323976

Merge pull request #9982 from Tilka/ax DSPHLE: report games that use unimplemented AX features

view details

JosJuice

commit sha 56057c3deadf110de615fd551f95874cdfc1f3ff

Merge pull request #9961 from Simonx22/update-dependencies Android: update dependencies

view details

Pokechu22

commit sha 3b752c4d5d46cfda50a51c47c346e94257e9c3d9

UberShaderPixel: Rename ApiType to api_type

view details

Pokechu22

commit sha f46fe77264f8668fc06190cc09d498918d6165a6

GeometryShaderGen: Rename ApiType to api_type

view details

Tilka

commit sha 8a078ea43ad9bb2e5f6adc41294d94dd5521f3c8

Merge pull request #9984 from Pokechu22/ApiType-to-api_type VideoCommon: Rename ApiType to api_type

view details

Léo Lam

commit sha 35bf5e38392670b3b86a4926437d01157363ba4a

Merge pull request #9962 from OatmealDome/macos-vulkan-default VideoBackendBase: Prefer Vulkan over OGL on macOS Mojave and newer

view details

JMC47

commit sha 5bf1a8af8e3a88bf90a2851942a3047fbe190e56

GameINI: Add Safe Texture Cache to SpongebobToS Text in SpongeBob's Truth of Square needs Safe Texture Cache in order to render properly.

view details

JMC47

commit sha 20c7edff8a0403b351eccd59f01f5811d3236cef

Merge pull request #9985 from JMC47/spongetruthini GameINI: Add Safe Texture Cache to SpongeBob's Truth or Square

view details

Tilka

commit sha 4b022a4bb15b4ac9f2c48f7116e44753a9787645

Merge pull request #9948 from Dentomologist/fix_wiimotescanner_shutdown_crash WiimoteReal: Fix Dolphin shutdown crash

view details

Pokechu22

commit sha 0b86a03438933f6391a2d14e97b91937a6cd39d9

FilesystemWidget: Show more information about partitions

view details

Filippo Tarpini

commit sha a99932da1258a3793ddc06a53b54b927c989de4a

Preserve spaces in mapping preview of control names PR https://github.com/dolphin-emu/dolphin/pull/9700 removed spaces from within control names, which some user complained about, and their point of view is kind of understandable: https://bugs.dolphin-emu.org/issues/12605 with this change, only spaces outside (between) control names are trimmed, which are the ones we wanted to trim in the first place. This will still retain the major advantages from 9700. Basically, "`Button 1` + `Button 2`" was showing as "`Button1`+`Button2`", while it will now show as "`Button 1`+`Button 2`".

view details

JMC47

commit sha 7b070377232b1302638f692db48e82daf112b8c8

GameINI: SpongeBob SquarePants: BFBB QoL This enables Vertex Rounding Hack and has a game patch for two bugs resulting from game choices. The game draws an efb copy at coordinate 0.00195313 to 1.00195 repeating which only works due to how the numbers work out at low resolution. The Vertex Rounding Hack is a null operation on 1x IR, so there should be no concern enabling it by default since higher resolutions are completely broken without it.

view details

push time in 2 days

issue commentfreedoom/freedoom

Fist cutting off in ultra-wide ports

Bottom of the screen is probably the best idea.

colinmahns

comment created time in a month

pull request commentreactos/reactos

[SYSDM] Make Environment dialog box resizable

Does it really need the new size, especially when the properties do not allow it to go smaller than the initial size? on 640×480 screens, it almost becomes unusable, the original size was designed to keep it workable even on the lowest end of display.

arnavbhatt288

comment created time in 2 months

issue commentTookmund/Swapspace

Warning: Could not disable COW '1': Invalid argument

Basic question: is that directory actually on btrfs?

axet

comment created time in 2 months

push eventchungy/zfs

Serapheim Dimitropoulos

commit sha 48df24d4ce7bbf14fedc10c5f33396d6cb42f5db

Remove zdb and libzpool from initramfs image = Motivation At Delphix we are heavy users of kernel crash dumps that are captured through a crash kernel that is spawned whenever the main kernel panics. The way that this works internally is that a certain amount of memory is reserved while the main system is running so the initramfs of the crash kernel can be loaded when a panic occurs. In order to keep reserved memory at minimum we've been historically trying to identify the binaries that are part of the kernel's initramfs that are big and finding ways of either making them smaller or do not include them in the initramfs image. An example is always stripping the DWARF info of the ZFS kernel module copy that is included in the initramfs image of both our running and our crash kernel (the difference in size there is 76MB vs 4MB). We've recently identified that libzpool has been the largest binary in our initramfs images - currently sized around 17MB. = This Patch The ZFS scripts do not explicitly copy libzpool to initramfs. They copy zdb which pulls in libzpool as a dependency. Given that both zdb and libzpool are not really essential for initramfs (e.g. we'll still have access to the once the root filesystem is unpacked) this patch removes them from initramfs. Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Serapheim Dimitropoulos <serapheim@delphix.com> Closes #12616

view details

Brian Behlendorf

commit sha 514498fef6977e4d1d6dc676710567384d6f6b39

Simplify and document OpenZFS library dependencies For those not already familiar with the code base it can be a challenge to understand how the libraries are laid out. This has sometimes resulted in functionality being added in the wrong place. To help avoid that in the future this commit documents the high-level dependencies for easy reference in lib/Makefile.am. It also simplifies a few things. - Switched libzpool dependency on libzfs_core to libzutil. This change makes it clear libzpool should never depend on the ioctl() functionality provided by libzfs_core. - Moved zfs_ioctl_fd() from libzutil to libzfs_core and renamed it lzc_ioctl_fd(). Normal access to the kmods should all be funneled through the libzfs_core library. The sole exception is the pool_active() which was updated to not use lzc_ioctl_fd() to remove the libzfs_core dependency. - Removed libzfs_core dependency on libzutil. - Removed the lib/libzfs/os/freebsd/libzfs_ioctl_compat.c source file which was all dead code. - Removed libzfs_core dependency from mkbusy and ctime test utilities. It was only needed for some trivial wrapper functions and that code is easy to replicate to shed the unneeded dependency. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Don Brady <don.brady@delphix.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #12602

view details

Valmiky Arquissandas

commit sha 2d02bba23d83ae8fede8d281edc255f01ccd28e9

arcstat: Fix integer division with python3 The arcstat script requests compatibility with python2 and python3, but PEP 238 modified the / operator and results in erroneous output when run under python3. This commit replaces instances of / with //, yielding the expected result in both versions of Python. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Signed-off-by: Valmiky Arquissandas <foss@kayvlim.com> Closes #12603

view details

Rich Ercolani

commit sha 9d1407e8f24825d74ba7cf228de545c0d1a0ce8f

Correct refcount_add in dmu_zfetch refcount_add_many(foo,N) is not the same as for (i=0; i < N; i++) { refcount_add(foo); } Unfortunately, this is only actually true with debug kernels and reference_tracking_enable=1. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes #12589 Closes #12602

view details

Ryan Moeller

commit sha 97bbeeb9380385ce5541d0be9ec3fd6f9c9f1d00

Fail invalid incremental recursive send gracefully zfs send -R -i snap1 pool/ds@snap1 is an invalid invocation of zfs send because the incremental source and target snapshots are the same. We have an error message for this condition, but we don't make it there because of a failed assert while iterating through the dataset's snapshots. Check for NULL to avoid the assert so we can make it to the error message. Test this form of invalid send invocation in rsend tests. Fix the rsend_016_neg test while here: log_neg itself doesn't fail the test, and writing to /dev/null is not supported on all Linux kernels. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Paul Dagnelie <pcd@delphix.com> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11121 Closes #12533

view details

nachtgeist

commit sha a5b464263bc1f9fd833272a9e691cd479bf47d5d

initramfs: use correct dataset for rootfs on rollback=1 When booting with root=zfs:rpool/myrootfs@foosnapshot rollback=1, myrootfs and its descendants get rolled back to foosnapshot, however ZFS_BOOTFS still contains myrootfs@foosnapshot instead of the actually desired value of myrootfs. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Signed-off-by: Daniel Reichelt <hacking@nachtgeist.net> Closes #12585 Closes #12586

view details

Brian Behlendorf

commit sha 72f06d01b555503245b45690ec645d4bfc43c939

ZTS: deadman_sync fix In the CI environment it's possible for events to be slightly delayed resulting in 4, instead of 5, events appearing in the log file. This isn't a problem and should be considered a success to avoid false positive test results. Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #12625

view details

Brian Behlendorf

commit sha 648445e0078ee6190d9546049e4339d8f9711a35

ZTS: Add known exceptions Add the following test failures to the exception list for FreeBSD to ensure we notice new unexpected failures. pool_checkpoint/checkpoint_big_rewind pool_checkpoint/checkpoint_indirect And the following for Linux. zvol/zvol_misc/zvol_misc_snapdev Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue #12621 Issue #12622 Issue #12623 Closes #12624

view details

Brian Behlendorf

commit sha 280d0f0ce45aeb5832038c589deabd1bf53bcd6c

Export minimal zfs_refcount interfaces Lustre makes light use of the zfs_refcount interfaces which isn't a problem when using a non-debug build of OpenZFS. However, when debugging is enabled the required symbols are not exported. Reviewed-by: Olaf Faaland <faaland1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #12613

view details

Teodor Spæren

commit sha d785245857b82bf045c3a411751da1fad87faf9e

zio: use unsigned values for enum cppcheck complains about the use of 1 << 31, because enums are signed ints which cannot represent this. As discussed in issue #12611, it appears that with C99, we can use an unsiged int for the enum, on most platforms. I've crafted this commit for just the include/sys/zio.h header, as it's the only one with a shift of 31. If this is something we want to adopt in the rest of the project, I will go through and apply it to the rest of the project. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Jorgen Lundman <lundman@lundman.net> Signed-off-by: Teodor Spæren <teodor@sparen.no> Closes #12611 Closes #12615

view details

Mike Swanson

commit sha 5ef3a7e797b227723caaeef6d20695d41db9b2da

Disable normalization implicitly when setting "utf8only=off". When a parent dataset has normalization set to any value other than "none", and a file system is created with the property "utf8only=off", implicitly also set "normalization=none" instead of overriding the desire for a non-UTF8 enforcing file system. Signed-off-by: Mike Swanson <mikeonthecomputer@gmail.com> Closes #11892

view details

Mike Swanson

commit sha c70a3cc644831245e6b0f3f53bfc88e4c758a5f4

ZFS: Check that utf8only=off respects user setting Based on the prior commit, utf8only=off should maintain its status even when a parent dataset has normalization!=none.

view details

push time in 2 months

issue closedfreedoom/freedoom.github.io

Have you considered including this game in the "DOOM" menu of the RetroArch/libretro Content Downloader?

All it has at the moment is the ShareWare version of the Original DOOM and a WAD for PrBoom.

Screenshot_20211005-182032

I just think it would be great to have more direct access to it...

closed time in 2 months

SecularSteve

issue commentfreedoom/freedoom.github.io

Have you considered including this game in the "DOOM" menu of the RetroArch/libretro Content Downloader?

Yeah I don't think we have any ability to control what's in retroarch. Go ask their upstream :)

SecularSteve

comment created time in 2 months

pull request commentchocolate-doom/chocolate-doom

Hexen: Support two variations of v1.1 with -gameversion

Hexen engine variants are down the obscurity hole enough, I don't think it's worth changing the PHILOSOPHY document to note the peculiarity. Doom is a different case: being fairly well-known that shareware/Doom2, Ultimate, and Final Doom are different revisions with distinct behavior.

I'd also recommend not using a commit I made in another repository to claim that "1.1r2" is an official moniker anywhere, it just happened to be a convenient disambiguation for community purposes. I think -gameversion 1.1 is fine for the original and apparently more common release of Hexen; demos are more likely to have been made with this version and I believe it's a sane default. "1.1r2" (or whatever else it might be called) should be explicitly asked for.

This is also consistent with the way our Doom gameversion works: does the right thing by default for any particular IWAD, while still allowing for an override.

NY00123

comment created time in 2 months

pull request commentopenzfs/zfs

Disable normalization implicitly when setting "utf8only=off".

I've written a test case where I thought appropriate and ran it with both my code change and without, seems to work without issue.

chungy

comment created time in 2 months

push eventchungy/zfs

Mike Swanson

commit sha fe77bc647a9fbeb666d60929a10e7f10618feace

ZFS: Check that utf8only=off respects user setting Based on the prior commit, utf8only=off should maintain its status even when a parent dataset has normalization!=none.

view details

push time in 2 months

push eventchungy/zfs

наб

commit sha 37086897b06a070d957226dbf860b4673906dc70

libzfs: add keylocation=https://, backed by fetch(3) or libcurl Add support for http and https to the keylocation properly to allow encryption keys to be fetched from the specified URL. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Issue #9543 Closes #9947 Closes #11956

view details

наб

commit sha 618a65cd7a77b0b5a27ccdd3e0ff4f80cd14404f

Widen mancheck target to all pages, fix them mandoc: ./man/man8/zfs-mount-generator.8.in:188:2: ERROR: skipping end of block that is not open: RE mandoc: ./man/man8/zfs_ids_to_path.8:38:2: ERROR: skipping unknown macro: .LP mandoc: ./man/man8/zfs_ids_to_path.8:48:2: ERROR: inserting missing end of block: Sh breaks Bl mandoc: ./man/man8/zfs-wait.8:69:2: ERROR: skipping end of block that is not open: El mandoc: ./man/man8/zfs-program.8:460:2: ERROR: inserting missing end of block: It breaks Bd mandoc: ./man/man8/zfs-mount-generator.8:188:2: ERROR: skipping end of block that is not open: RE mandoc: ./man/man8/zstream.8:43:2: ERROR: skipping unknown macro: .LP mandoc: ./man/man8/zstream.8:107:2: ERROR: inserting missing end of block: Sh breaks Bl mandoc: ./man/man8/zstream.8:107:2: ERROR: inserting missing end of block: Sh breaks Bl make: *** [Makefile:1529: mancheck] Error 1 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Issue #12017

view details

Brian Behlendorf

commit sha 6217656da33c0920cb9f213742fd51dd215bc455

Revert "Fix raw sends on encrypted datasets when copying back snapshots" Commit d1d4769 takes into account the encryption key version to decide if the local_mac could be zeroed out. However, this could lead to failure mounting encrypted datasets created with intermediate versions of ZFS encryption available in master between major releases. In order to prevent this situation revert d1d4769 pending a more comprehensive fix which addresses the mount failure case. Reviewed-by: George Amanakis <gamanakis@gmail.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue #11294 Issue #12025 Issue #12300 Closes #12033

view details

Scott Colby

commit sha da124ad8ec1b3b0f18057a6b0ff3160ca6053800

zed: Add Pushover notifier Add zed_notify_pushover to zed-functions.sh, along with the necessary configuration variables in zed.rc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Signed-off-by: Scott Colby <scott@scolby.com> Closes #12012

view details

Ryan Moeller

commit sha 099ca8186b071ad6db4f8d5fab66baa1be8877b0

FreeBSD: Don't force xattr mount option The kernel will use the xattr property by default when not overridden by a mount option. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11997

view details

Ryan Moeller

commit sha d86debf5762c0d18574af67407f4c99fd9aaec3a

FreeBSD: Use SET_ERROR to trace xattr name errors Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11997

view details

Ryan Moeller

commit sha 210231ede0ecef5aa2c49db0366742bafaecde2c

FreeBSD: Implement xattr=sa FreeBSD historically has not cared about the xattr property; it was always treated as xattr=on. With xattr=on, xattrs are stored as files in a hidden xattr directory. With xattr=sa, xattrs are stored as system attributes and get cached in nvlists during xattr operations. This makes SA xattrs simpler and more efficient to manipulate. FreeBSD needs to implement the SA xattr operations for feature parity with Linux and to ensure that SA xattrs are accessible when migrated or replicated from Linux. Following the example set by Linux, refactor our existing extattr vnops to split off the parts handling dir style xattrs, and add the corresponding SA handling parts. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11997

view details

Paul Zuchowski

commit sha fce29d6aa4b4067cd5f0d6cd7481cce469dca3e8

Fix dmu_recv_stream test for resumable Use dsl_dataset_has_resume_receive_state() not dsl_dataset_is_zapified() to check if stream is resumable. Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Alek Pinchuk <apinchuk@axcient.com> Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Closes #12034

view details

наб

commit sha 5236eafdcdf5e9e4e4d276f3c91391cdf5d97589

i-t: rewrite hooks This produces a leaner image, doesn't fail if zdb doesn't exist, properly handles hostnameless systems, doesn't mention crypto modules for no reason, doesn't add useless empty executable in hopes an eight-year-old PR is merged, uses i-t builtins for all copies Also optimize the checkbashisms filter to spawn one (or a few) awks instead of one per regular file and remove initramfs/hooks therefrom due to a command -v false positive Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12017

view details

Brian Behlendorf

commit sha 6a13add5596b1390fe79b3d1ba94b07283805f73

ZTS: Increase redundancy test timeout The redundancy_draid.ksh and redundancy_raidz.ksh tests were updated by commit 93c8e91fe to additionally verify self-healing. This additional check increased the run time which can now occasionally exceed the default maximum timeout in the CI environment. To prevent this from causing failures increase the default timeout for the redundancy test cases. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #12043

view details

Alexander Motin

commit sha 7457b024ba2be2cf742e07239c20a1c3f3fa9c72

Scale worker threads and taskqs with number of CPUs While use of dynamic taskqs allows to reduce number of idle threads, hardcoded 8 taskqs of each kind is a big overkill for small systems, complicating CPU scheduling, increasing I/O reorder, etc, while providing no real locking benefits, just not needed there. On another side, 12*8 worker threads per kind are able to overload almost any system nowadays. For example, pool of several fast SSDs with SHA256 checksum makes system barely responsive during scrub, or with dedup enabled barely responsive during large file deletion. To address both problems this patch introduces ZTI_SCALE macro, alike to ZTI_BATCH, but with multiple taskqs, depending on number of CPUs, to be used in places where lock scalability is needed, while request ordering is not so much. The code is made to create new taskq for ~6 worker threads (less for small systems, but more for very large) up to 80% of CPU cores (previous 75% was not good for rounding down). Both number of threads and threads per taskq are now tunable in case somebody really wants to use all of system power for ZFS. While obviously some benchmarks show small peak performance reduction (not so big really, especially on systems with SMT, where use of the second threads does not give as much performance as the first ones), they also show dramatic latency reduction and much more smooth user- space operation in case of high CPU usage by ZFS. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alexander Motin <mav@FreeBSD.org> Sponsored-By: iXsystems, Inc. Closes #11966

view details

Rich Ercolani

commit sha 1d106ab57a53dced72d0798c62635f11b8242bd1

Simple change to fix building in recent environments Renamed _fini too for symmetry. Suggested-by: @ensch Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes #12059 Closes: #11987 Closes: #12056

view details

наб

commit sha 2ca77988a5584440b9d322ebb26ab55c730637bf

Fix SC2181 ("[ $?") outside tests/ Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12042

view details

наб

commit sha 6fc3099248f04591d7d7bf05078482f794b38eaa

Trim excess shellcheck annotations. Widen to all non-Korn scripts Before, make shellcheck checked scripts/{commitcheck,make_gitrev,man-dates,paxcheck,zfs-helpers,zfs, zfs-tests,zimport,zloop}.sh cmd/zed/zed.d/{{all-debug,all-syslog,data-notify,generic-notify, resilver_finish-start-scrub,scrub_finish-notify, statechange-led,statechange-notify,trim_finish-notify, zed-functions}.sh,history_event-zfs-list-cacher.sh.in} cmd/zpool/zpool.d/{dm-deps,iostat,lsblk,media,ses,smart,upath} now it also checks contrib/dracut/{02zfsexpandknowledge/module-setup, 90zfs/{export-zfs,parse-zfs,zfs-needshutdown, zfs-load-key,zfs-lib,module-setup, mount-zfs,zfs-generator}}.sh.in cmd/zed/zed.d/{pool_import-led,vdev_attach-led, resilver_finish-notify,vdev_clear-led}.sh contrib/initramfs/{zfsunlock,hooks/zfs.in,scripts/local-top/zfs} tests/zfs-tests/tests/perf/scripts/prefetch_io.sh scripts/common.sh.in contrib/bpftrace/zfs-trace.sh autogen.sh Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12042

view details

наб

commit sha 359b6cca0f858808790023c5c5a562dcd92cbf43

zgenhostid: use argument path directly Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12042

view details

наб

commit sha 9627bdc6970558c9d59e0f9a0a2b4397cd6170e7

contrib/bash_completion.d: fix obvious shellcheck problems Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12042

view details

наб

commit sha adc851d9f83579f31903007e3ce0af24faceb21b

d/zfsutils.zfs.init derivatives: shellcheck, fix header Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12042

view details

Lauri Tirkkonen

commit sha 6ac2d7f76f8b56f0d5869c60c0b49b15018d1a53

zfs-allow.8: mention 'bookmark' permission Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Lauri Tirkkonen <lauri@hacktheplanet.fi> Closes #12064

view details

Brian Behlendorf

commit sha 8fb577ae6da03ed72edca9adad027779e69db146

Fix dRAID sequential resilver silent damage handling This change addresses two distinct scenarios which are possible when performing a sequential resilver to a dRAID pool with vdevs that contain silent unknown damage. Which in this circumstance took the form of the devices being intentionally overwritten with zeros. However, it could also result from a device returning incorrect data while a sequential resilver was in progress. Scenario 1) A sequential resilver is performed while all of the dRAID vdevs are ONLINE and there is silent damage present on the vdev being resilvered. In this case, nothing will be repaired by vdev_raidz_io_done_reconstruct_known_missing() because rc->rc_error isn't set on any of the raid columns. To address this vdev_draid_io_start_read() has been updated to always mark the resilvering column as ESTALE for sequential resilver IO. Scenario 2) Multiple columns contain silent damage for the same block and a sequential resilver is performed. In this case it's impossible to generate the correct data from parity unless all of the damaged columns are being sequentially resilvered (and thus only good data is used to generate parity). This is as expected and there's nothing which can be done about it. However, we need to be careful not to make to situation worse. Since we can't verify the data is actually good without a checksum, we must only repair the devices which are being sequentially resilvered. Otherwise, an incorrect repair to a device which previously contained good data could effectively lock in the damage and make reconstruction impossible. A check for this was added to vdev_raidz_io_done_verified() along with a new test case. Lastly, this change updates the redundancy_draid_spare1 and redundancy_draid_spare3 test cases to be more representative of normal dRAID replacement operation. Specifically, what we care about is that the scrub run after a sequential resilver does not find additional blocks which need repair. This would indicate the sequential resilver failed to rebuild a section of one of the devices. Note also the tests were switched to using the verify_pool() function which still checks for checksum errors. Reviewed-by: Mark Maybee <mark.maybee@delphix.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #12061

view details

Rich Ercolani

commit sha 0b1b66b4735f13d826ece675ea5568a7d3ca316c

Update tmpfile() existence detection Linux changed the tmpfile() signature again in torvalds/linux@6521f89, which in turn broke our HAVE_TMPFILE detection in configure. Update that macro to include the new case, and change the signature of zpl_tmpfile as appropriate. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes: #12060 Closes: #12087

view details

push time in 2 months

pull request commentopenzfs/zfs

Disable normalization implicitly when setting "utf8only=off".

Has there been any progress on looking after this PR?

chungy

comment created time in 2 months

more