profile
viewpoint
Christian Moritz chrmoritz Dresden, Germany

chrmoritz/qr3d 2

a WebGL based 3D QR code renderer which can be used to test QR code scanners ability to read them under high angles, bad light conditions etc.

chrmoritz/asura-chess 0

GW2 Asura Chess Game (hmtl5, javascript, css)

chrmoritz/brew 0

:beer: The missing package manager for OS X

chrmoritz/cargo_gn 0

Cargo GN integration

chrmoritz/chromium_build 0

Deno floats patches to //build here (they will be sent upstream eventually)

chrmoritz/deno 0

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

chrmoritz/dns.js.org 0

Free and short JS.ORG domains for GitHub Pages

chrmoritz/formula-patches 0

:hospital: Patches for Homebrew formulae

chrmoritz/fritzapi 0

Home automation API for Fritz!Box, Fritz!DECT and FRITZ!Powerline devices

issue commentdenoland/rusty_v8

unknown argument: '-gno-inline-line-tables'

@hayd: Are you setting V8_FROM_SOURCE=1, otherwise you're getting the prebuilt rusty_v8 binary instead of building rusty_v8 from source. This would explain why -gno-inline-line-tables isn't an issue anymore and doesn't need to be a bad thing for your use case, if it doesn't break something.

hayd

comment created time in 2 days

Pull request review commentHomebrew/homebrew-core

deno 0.38.0

 def install      # env args for building a release build with our clang, ninja and gn     ENV["GN"] = buildpath/"gn/out/gn"+    # Ensure build rust_v8 from the source+    ENV["V8_FROM_SOURCE"] = "1"+    # Chromium has decided to require the 10.15 sdk in their build config+    ENV["FORCE_MAC_SDK_MIN"] = "10.13"+    # Set no_inline_line_tables to false as required for custom (non-Chromium) `clang` builds.+    ENV["GN_ARGS"] = "no_inline_line_tables=false"

This is now supported by the newly released llvm 10 and we don't need it with it anymore. Also the 'unknown warning option'-warnings are down to only complaining about -Wno-non-c-typedef-for-linkage, which is a big improvement over llvm 9 and even current system clang (on Catalina).

So we either should consider building with Homebrew llvm everywhere and dropping this workaround completly OR at least move this down to the else # build with system clang, if we want to continue using system clang on Catalina.

waldyrious

comment created time in 2 days

issue commentdenoland/rusty_v8

unknown argument: '-gno-inline-line-tables'

@hayd FYI: The newly released llvm 10 now supports -gno-inline-line-tables out of the box. Also with it the unknown warning options are down to only complaining about -Wno-non-c-typedef-for-linkage, which is a big improvement over llvm 9 (or 8).

hayd

comment created time in 2 days

issue commentdenoland/rusty_v8

gn gen failure on macOS

@ry This would help Homebrew to continue supporting High Sierra for deno, because the binary bottles are build on the macOS version they should run on and currently it's not possible to build it on High Sierra because of a too old libtool.

chrmoritz

comment created time in 4 days

issue commentdenoland/rusty_v8

gn gen failure on macOS

It comes from the V8 upgrade to 8.2 and more specific this commit: denoland/chromium_build@8a57822. Google has just decided to drop supporting building V8 on High Sierra (it will still run on it however). The libtool shipped with HighSierra (CLT or the max possible XCode 10.1) isn't new enough and doesn't support the -D flag, only the ZERO_AR_DATE env var from which they've moved in said commit.

I don't think we can do anything about it except dropping support for building on High Sierra too (or reverting said commit of course).

chrmoritz

comment created time in 4 days

issue commentdenoland/rusty_v8

gn gen failure on macOS

@ry FYI: The last remaining issue with the v8 upgrade in Homebrew is, that https://github.com/denoland/chromium_build/commit/8a57822b3fdbf7164ccce5703691de28b91663d2 breaks support for High Sierra, because libtool -D isn't available there.

chrmoritz

comment created time in 4 days

pull request commentHomebrew/homebrew-core

deno 0.38.0

The -D option was added in cctools 927.0.2 which first shipped in Xcode 10.2. High Sierra can only go up to Xcode 10.1.

Thanks, this explains why it doesn't work on High Sierra. The usage of the -D options comes likely from the gn upgrade, because the relevant line in the BUILD.gn didn't change for ages. (The -D is passed in with the {{arflags}})

Unfortunately we need a recent gn version now for the updated v8 8.2 in deno, because of the usage of {{framework_dirs}}, which was just added in gn@a09ec161. I don't know when the change to the {{arflags}} was introduced, bit it looks like it was before the framework change.

As this is tightly coupled to v8 complex build system I don't see a reasonable way to work around this issue for High Sierra. So we might have to bump the XCode dependency to 10.2 and drop support for High Sierra unfortunately.

waldyrious

comment created time in 4 days

Pull request review commentHomebrew/homebrew-core

deno 0.38.0

 def install      # env args for building a release build with our clang, ninja and gn     ENV["GN"] = buildpath/"gn/out/gn"+    # Ensure build rust_v8 from the source+    ENV["V8_FROM_SOURCE"] = "1"+    # Chromium has decided to require the 10.15 sdk in their build config+    ENV["FORCE_MAC_SDK_MIN"] = "10.13"

Maybe, but I think it doesn't really matter here, as this only specify until which version it should complain with the 'macOS SDK not new enough'-error. It will still use the SDK provided by homebrew based on the current macOS version anyway.

waldyrious

comment created time in 4 days

pull request commentHomebrew/homebrew-core

deno 0.38.0

On High Sierra:

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static -D  -o obj/third_party/zlib/libchrome_zlib.a -filelist obj/third_party/zlib/libchrome_zlib.a.rsp
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: unknown option character `D' in: -D
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols]
Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load]

Is libtool -D (for deterministic output) something new, that was introduced with the version shipped with XCode 11?

waldyrious

comment created time in 4 days

issue closeddenoland/rusty_v8

gn gen failure on macOS

I'm not able to build versions after the V8 upgrade to 8.2.308 (https://github.com/denoland/rusty_v8/commit/8a3c19ece4cc0ed1a7b116ce5005864ca3472fee) from source on macOS, because of a failure in the gn gen command:

[rusty_v8 0.3.9] Downloading https://github.com/denoland/ninja_gn_binaries/archive/20200313.tar.gz... Done.
[rusty_v8 0.3.9] using Chromiums clang
[rusty_v8 0.3.9] clang_base_path /Users/chrmoritz/Documents/git/rusty_v8/target/debug/clang
[rusty_v8 0.3.9] Downloading https://commondatastorage.googleapis.com/chromium-browser-clang/Mac/clang-n344329-9284abd0-5.tgz .......... Done.
[rusty_v8 0.3.9] cargo:warning=Not using sccache
[rusty_v8 0.3.9] cargo:rustc-env=GN_OUT_DIR=/Users/chrmoritz/Documents/git/rusty_v8/target/debug/gn_out
[rusty_v8 0.3.9] running: "/Users/chrmoritz/Documents/git/rusty_v8/target/debug/ninja_gn_binaries-20200313/mac/ninja" "-C" "/Users/chrmoritz/Documents/git/rusty_v8/target/debug/gn_out" "rusty_v8"
[rusty_v8 0.3.9] ninja: Entering directory `/Users/chrmoritz/Documents/git/rusty_v8/target/debug/gn_out'
[rusty_v8 0.3.9] ninja: error: rebuilding 'build.ninja': subcommand failed
[rusty_v8 0.3.9] [1/1] Regenerating ninja files
[rusty_v8 0.3.9] FAILED: build.ninja 
[rusty_v8 0.3.9] ../build/rusty_v8-55982c004f00657d/out/gn_ninja_binaries/mac/gn --root=../../.. -q gen .
[rusty_v8 0.3.9] ERROR at //build/toolchain/mac/BUILD.gn:236:17: Unknown substitution pattern
[rusty_v8 0.3.9]       command = "$cc -MMD -MF $depfile {{defines}} {{include_dirs}} {{framework_dirs}} {{cflags}} {{cflags_objc}} -c {{source}} -o {{output}}"
[rusty_v8 0.3.9]                 ^-----------------------------------------------------------------------------------------------------------------------------
[rusty_v8 0.3.9] Found a {{ at offset 106 and did not find a known substitution following it.
[rusty_v8 0.3.9] See //build/toolchain/mac/BUILD.gn:484:1: whence it was called.
[rusty_v8 0.3.9] mac_toolchain("clang_arm") {
[rusty_v8 0.3.9] ^---------------------------
[rusty_v8 0.3.9] See //v8/gni/v8.gni:266:3: which caused the file to be included.
[rusty_v8 0.3.9]   static_library(target_name) {
[rusty_v8 0.3.9]   ^----------------------------
[rusty_v8 0.3.9] thread 'main' panicked at '
[rusty_v8 0.3.9] command did not execute successfully, got: exit code: 1
[rusty_v8 0.3.9] 
[rusty_v8 0.3.9] build script failed, must exit now', /Users/chrmoritz/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo_gn-0.0.15/src/lib.rs:203:3
[rusty_v8 0.3.9] note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
error: failed to run custom build command for `rusty_v8 v0.3.9 (/Users/chrmoritz/Documents/git/rusty_v8)`

Relevant chromium/build commit, which has introduced the {{framework_dirs}} at offset 70, which it's complaining about: https://github.com/denoland/chromium_build/commit/62dad5c5423c78f7ea2cf02cc535dcffe52a0734#diff-0448a2a05f9be285643f46f44cc31272.

This also blocks us in Homebrew from upgrading deno past 0.36.0 (Refs: https://github.com/Homebrew/homebrew-core/pull/52095)

closed time in 5 days

chrmoritz

issue commentdenoland/rusty_v8

gn gen failure on macOS

@ry: Thx, updating gn fixes the issue.

I did the test from above in an old checkout with the old binaries still laying around and it didn't update them. Also we need to update gn in homebrew.

chrmoritz

comment created time in 5 days

pull request commentHomebrew/homebrew-core

deno 0.38.0

This will use the new precompiled rust_v8 binaries by default. To continue building it from source. you have to set ENV["V8_FROM_SOURCE"] = "1". Also an upgrade to gn resource might be necessary and we need to again ENV["FORCE_MAC_SDK_MIN"] = "10.13" because Chromium has decided to require the 10.15 sdk in their build config.

diff --git a/Formula/deno.rb b/Formula/deno.rb
index a60f9cd886..eb9d34f4fc 100644
--- a/Formula/deno.rb
+++ b/Formula/deno.rb
@@ -24,7 +24,7 @@ class Deno < Formula
 
   resource "gn" do
     url "https://gn.googlesource.com/gn.git",
-      :revision => "a5bcbd726ac7bd342ca6ee3e3a006478fd1f00b5"
+      :revision => "fd3d768bcfd44a8d9639fe278581bd9851d0ce3a"
   end
 
   def install
@@ -37,6 +37,8 @@ class Deno < Formula
 
     # env args for building a release build with our clang, ninja and gn
     ENV["GN"] = buildpath/"gn/out/gn"
+    ENV["V8_FROM_SOURCE"] = "1"
+    ENV["FORCE_MAC_SDK_MIN"] = "10.13"
     if DevelopmentTools.clang_build_version < 1100
       # build with llvm and link against system libc++ (no runtime dep)
       ENV["CLANG_BASE_PATH"] = Formula["llvm"].prefix

waldyrious

comment created time in 5 days

issue commentdenoland/rusty_v8

gn gen failure on macOS

@ry: The error from above is from cloning this repository and using it's default precompiled binaries. But I keep that in mind, that we might have to update gn too in the homebrew formula.

chrmoritz

comment created time in 5 days

issue commentdenoland/rusty_v8

gn gen failure on macOS

@chenrui333 but only because you're using the precompiled rust_v8 binary. Building it from source by setting V8_FROM_SOURCE=1 still fails.

chrmoritz

comment created time in 5 days

issue commentdenoland/rusty_v8

gn gen failure on macOS

This is with rust 1.4.2. Also a syntax error in BUILD.gn files during the gn gen run should be completely unrelated to rust though.

chrmoritz

comment created time in 5 days

issue openeddenoland/rusty_v8

gn gen failure on macOS

I'm not able to build versions after the V8 upgrade to 8.2.308 from source on macOS, because of a failure in the gn gen command:

[rusty_v8 0.3.9] Downloading https://github.com/denoland/ninja_gn_binaries/archive/20200313.tar.gz... Done.
[rusty_v8 0.3.9] using Chromiums clang
[rusty_v8 0.3.9] clang_base_path /Users/chrmoritz/Documents/git/rusty_v8/target/debug/clang
[rusty_v8 0.3.9] Downloading https://commondatastorage.googleapis.com/chromium-browser-clang/Mac/clang-n344329-9284abd0-5.tgz .......... Done.
[rusty_v8 0.3.9] cargo:warning=Not using sccache
[rusty_v8 0.3.9] cargo:rustc-env=GN_OUT_DIR=/Users/chrmoritz/Documents/git/rusty_v8/target/debug/gn_out
[rusty_v8 0.3.9] running: "/Users/chrmoritz/Documents/git/rusty_v8/target/debug/ninja_gn_binaries-20200313/mac/ninja" "-C" "/Users/chrmoritz/Documents/git/rusty_v8/target/debug/gn_out" "rusty_v8"
[rusty_v8 0.3.9] ninja: Entering directory `/Users/chrmoritz/Documents/git/rusty_v8/target/debug/gn_out'
[rusty_v8 0.3.9] ninja: error: rebuilding 'build.ninja': subcommand failed
[rusty_v8 0.3.9] [1/1] Regenerating ninja files
[rusty_v8 0.3.9] FAILED: build.ninja 
[rusty_v8 0.3.9] ../build/rusty_v8-55982c004f00657d/out/gn_ninja_binaries/mac/gn --root=../../.. -q gen .
[rusty_v8 0.3.9] ERROR at //build/toolchain/mac/BUILD.gn:236:17: Unknown substitution pattern
[rusty_v8 0.3.9]       command = "$cc -MMD -MF $depfile {{defines}} {{include_dirs}} {{framework_dirs}} {{cflags}} {{cflags_objc}} -c {{source}} -o {{output}}"
[rusty_v8 0.3.9]                 ^-----------------------------------------------------------------------------------------------------------------------------
[rusty_v8 0.3.9] Found a {{ at offset 106 and did not find a known substitution following it.
[rusty_v8 0.3.9] See //build/toolchain/mac/BUILD.gn:484:1: whence it was called.
[rusty_v8 0.3.9] mac_toolchain("clang_arm") {
[rusty_v8 0.3.9] ^---------------------------
[rusty_v8 0.3.9] See //v8/gni/v8.gni:266:3: which caused the file to be included.
[rusty_v8 0.3.9]   static_library(target_name) {
[rusty_v8 0.3.9]   ^----------------------------
[rusty_v8 0.3.9] thread 'main' panicked at '
[rusty_v8 0.3.9] command did not execute successfully, got: exit code: 1
[rusty_v8 0.3.9] 
[rusty_v8 0.3.9] build script failed, must exit now', /Users/chrmoritz/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo_gn-0.0.15/src/lib.rs:203:3
[rusty_v8 0.3.9] note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
error: failed to run custom build command for `rusty_v8 v0.3.9 (/Users/chrmoritz/Documents/git/rusty_v8)`

Relevant chromium/build commit, which has introduced the {{framework_dirs}} at offset 70, which it's complaining about: https://github.com/denoland/chromium_build/commit/62dad5c5423c78f7ea2cf02cc535dcffe52a0734#diff-0448a2a05f9be285643f46f44cc31272.

This also blocks us in Homebrew from upgrading deno past 0.36.0 (Refs: https://github.com/Homebrew/homebrew-core/pull/52095)

created time in 5 days

PR closed chrmoritz/linuxbrew-core

test deno
+21 -355

0 comment

6 changed files

chrmoritz

pr closed time in a month

issue commentHomebrew/linuxbrew-core

Formulae `depends_on`/`uses_from_macos` "python@2"

Hi, just some idea of mine, but do you have already thought about trying to use pypy instead of python@2 for formulae which still depend on it / uses_from_macos "python@2", but don't work with Python 3? It should be at least sufficient for formulae where python@2 is just a simple build dependency (like v8, deno, ...) and PyPy2.7 will be supported 'as long as PyPy itself is around'..

In my test I was able to build deno just fine using only pypy inside the homebrew/brew docker container with this patch https://github.com/chrmoritz/linuxbrew-core/commit/349e9b207db148f97fd882b36a29ac32f4eef665 (after upgrading it to deno 0.35).

issyl0

comment created time in a month

create barnchchrmoritz/linuxbrew-core

branch : denopypy2

created branch time in a month

create barnchchrmoritz/linuxbrew-core

branch : denopypy

created branch time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha 4daf8d00c1902c73cf1359080572d839a66d83e5

Update deno.rb

view details

push time in a month

PR closed chrmoritz/linuxbrew-core

deno python2
  • [ ] Have you followed the guidelines for contributing?
  • [ ] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [ ] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
  • [ ] Have you included the output of brew gist-logs <formula> of the build failure if your PR fixes a build failure. Please quote the exact error message.

+13 -9

0 comment

2 changed files

chrmoritz

pr closed time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha cca49eba1bc8ec723f39a10250a75c56ef18d7ed

Update deno.rb

view details

push time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha b73d5f76330cf04fc599fa9b2713bb82a4b6888d

Update deno.rb

view details

push time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha ab7ed4723c20cd21ae286b49de1ba3c50a872746

Update build-bottles.yml

view details

push time in a month

create barnchchrmoritz/linuxbrew-core

branch : denopy2

created branch time in a month

PR opened chrmoritz/linuxbrew-core

deno python2
  • [ ] Have you followed the guidelines for contributing?
  • [ ] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [ ] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
  • [ ] Have you included the output of brew gist-logs <formula> of the build failure if your PR fixes a build failure. Please quote the exact error message.

+12 -8

0 comment

1 changed file

pr created time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha 9a5a142a9c50f7b137192b4591548b2993d1aa1a

Update deno.rb

view details

push time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha bd3d7f45d30ce5423f43eefc94095b5bd0582b94

Update deno.rb

view details

push time in a month

issue commentdenoland/deno_install

Installation with Homebrew doesn't work on Linux

It won't work on Linux, because of the missing Python 2 requirement. I'm currently experimenting if you can get it to work using PyPy2.7 instead.

Windvis

comment created time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha 29baa473633999bfd0d64da857300bcb2c4c91af

Update deno.rb

view details

push time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha 866717ada024776bac50e6714602b52092144763

test

view details

push time in a month

PR opened chrmoritz/linuxbrew-core

test deno
+9 -353

0 comment

5 changed files

pr created time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha bc7aaa36f4d57a898a86bffd8e99e77c42042f8e

Delete upload-bottles.yml

view details

push time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha 9ad0129e49003d7710549ba60737b3178b156ef5

Delete request-bottle-after-merge.yml

view details

push time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha c88c67dbc6d41879cd8a33c27666d29a988862d1

Delete generate_formulae.brew.sh_data.yml

view details

push time in a month

push eventchrmoritz/linuxbrew-core

Christian Moritz

commit sha 2bf060e8a3a0c34dd65571f224430fa1dc975d68

Delete dispatch-build-bottle.yml

view details

push time in a month

create barnchchrmoritz/linuxbrew-core

branch : deno

created branch time in a month

fork chrmoritz/linuxbrew-core

🍻🐧 Core formulae for the Homebrew package manager on Linux

https://docs.brew.sh/Homebrew-on-Linux

fork in a month

Pull request review commentHomebrew/homebrew-core

deno 0.35.0

 class Deno < Formula   desc "Command-line JavaScript / TypeScript engine"   homepage "https://deno.land/"-  url "https://github.com/denoland/deno/releases/download/v0.34.0/deno_src.tar.gz"-  version "0.34.0"-  sha256 "e6439e04b6df8db8d5192f98ee89c7d3ba9e966816fc7bf0d46cb52dc2e797aa"+  url "https://github.com/denoland/deno/releases/download/v0.35.0/deno_src.tar.gz"+  version "0.35.0"

🎉 Great that the version is no longer detected as src after the recent changes in brew. ✨

Also you might want to coordinate this with #50881.

waldyrious

comment created time in a month

pull request commentdenoland/deno_install

Indicate brew installs pre 0.35.x #93

That's not correct. The macOS package will be updated to 0.35 once the recent CI problem are resolved (already done as of now) and it's turn for deno in the currently large CI backlog.

It's just that you can't install it on Linux, because of the not satisfiable python@2 requirement.

clemens-tolboom

comment created time in a month

issue commentdenoland/deno_install

Installation with Homebrew doesn't work on Linux

Refs: https://github.com/Homebrew/linuxbrew-core/commit/70eeef0981c404e149a6650fc63355e5090fa353

This is unfortunately related to the fact that v8 (in rust_v8, a dependency of deno) still requires Python 2 to build. After the python@2 removal (from earlier this year), there is just no reliable way for Linuxbrew anymore to ensure that the python@2 build dependency is fulfilled, because not all Linux distribution are still shipping with a Python 2 version installed by default (unlike all current versions of macOS, but I'm not sure if this will still be the case after this fall).

In conclusion, we can't offer Linux support for installing deno with Homebrew anymore, until the Python 2 => 3 situation is sorted out and the Linux part should probably be removed from the docs until then.

Windvis

comment created time in a month

create barnchchrmoritz/homebrew-core

branch : v8-8.0.426.25

created branch time in a month

PR opened Homebrew/homebrew-core

v8 8.0.426.25

Created with brew bump-formula-pr.

+2 -2

0 comment

1 changed file

pr created time in a month

issue commentdenoland/deno

crate deno = "0.32.0" breaks when docs.rs tries to generate docs

The main requirement for building rusty_v8 (and hence deno) without using the Google binaries is having a recent version of clang / llvm installed. It looks like Ubuntu 18.04 (what doc.rs is using) still ships with clang 6, which is too old. The last time I've checked llvm 8.0 was the minimum requirement, but using the latest version 9.0 might be even better, because I'm not sure how long llvm 8.0 will still be supported. (BTW: we are using llvm 9.0 (or system clang on macOS Catalina) in homebrew for building deno.)

Other than that having ninja and gn installed is also required, but these tools are quite small and easy to build and shouldn't be a bigger issue to get (we are compiling gn on demand for every deno build for example). But getting at least ninja installed wouldn't hurt either.

But the 15min build time limit could also be an issue without network access and therefore without the ability to use sccache to speed up the build.

ry

comment created time in a month

create barnchchrmoritz/homebrew-core

branch : v8-8.0.426.16

created branch time in 2 months

PR opened Homebrew/homebrew-core

v8 8.0.426.16

Created with brew bump-formula-pr.

+12 -6

0 comment

2 changed files

pr created time in 2 months

PR closed andig/fritzapi

Add LED status API

This PR adds support for getting and setting the LED status of a Fritz!Box. It also includes a documentation for this new feature.

This PR is a preparation for the corresponding homebridge-fritz PR, which will add these status LEDs as a lightbulb to homebridge: https://github.com/andig/homebridge-fritz/pull/40

A little background on this feature.

A while ago AVM added support for deactivating the status LEDs from withing the LED settings page as a feature in Fritz!OS, but later decided to hide this feature again from all Fritz!Boxes (but not from the repeaters I think) for unknown reasons. But they didn't actual remove this feature as the POST endpoint is still working. It's just not accessible from the official web settings ui anymore. Nonetheless I think this is a very useful feature and everyone who has to sleep in the same room as their Fritz!Box will likely agree with me on this.

Tested with a Fritz!Box 6490 and FRITZ!OS 6.87.

+83 -0

5 comments

2 changed files

chrmoritz

pr closed time in 2 months

pull request commentandig/fritzapi

Add LED status API

I don't think this code works in FritzOS v7+ anymore. But at least AVM did bring back the ability to choose between the always on and on demand in their officially web GUI.

One could try to bind to that, but this isn't that important (at least for me) anymore, since it's available in the GUI again. So I'm closing this PR.

chrmoritz

comment created time in 2 months

pull request commentHomebrew/homebrew-core

balena-cli 11.23.0

I can confirm that in 11.23.0 only the first hunk of our dependency upgrade patch for node 13 compatibility (related to ext2fs) is needed. Everything else got already upgraded upstream.

So you are safe to delete everything starting from line 50 here.

chenrui333

comment created time in 2 months

issue commentdenoland/rusty_v8

unknown argument: '-gno-inline-line-tables'

There is already the possibility to specify export GN_ARGS="no_inline_line_tables=false". Using this together with https://github.com/denoland/chromium_build/commit/9b422958b703c9f734b8abdf9d12e04dd74b42da should work.

hayd

comment created time in 2 months

push eventchrmoritz/chromium_build

Christian Moritz

commit sha 9b422958b703c9f734b8abdf9d12e04dd74b42da

Update BUILD.gn

view details

push time in 2 months

fork chrmoritz/chromium_build

Deno floats patches to //build here (they will be sent upstream eventually)

https://chromium.googlesource.com/chromium/src/build/

fork in 2 months

PR opened Homebrew/homebrew-core

node: postinstall fix npm manpage symlinks
  • [x] Have you followed the guidelines for contributing?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Fixes: https://discourse.brew.sh/t/npm-upgrade-g-disables-npm-command/6715

Npm recently switched to installing symlinks to share/man instead of actually copying the files there. The fact that we still ship actually copied manpage files has broken npm's ability to self upgrade (npm i -g npm without --force) because it expects symlinks there and tries to overwrite them with ln -sf. This unfortunately fails with our copied files over there, leaving npm in a broken state (see discourse thread).

This PR fixes the issue my actually symlinking the manpages files to share/man as expected by npm. I can confirm, that you can now normally selfupdate npm after running postinstall with this change.

+3 -3

0 comment

1 changed file

pr created time in 2 months

push eventchrmoritz/homebrew-core

Michihito Shigemura

commit sha 3d256add26a5eeb9737df99fdcf4d010c5dd27ef

phpstan 0.12.7 (#49236)

view details

Parker Brown

commit sha dd7464c1fa9b0499d3c5b57c5f9604740339f0ab

exercism: add shell completion Co-Authored-By: FX Coudert <fxcoudert@gmail.com> Closes #49241. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 56ad4c6cc7913de767697ada3ce779040535fd68

exercism: update 3.0.13 bottle.

view details

Mislav Marohnić

commit sha 2d1119068e3238c3ef79f952cfc641ea30c3b209

hub 2.14.1 Closes #49252. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

BrewTestBot

commit sha 4a2979d0f27ca0215a368c2dbfdf21ddde724227

hub: update 2.14.1 bottle.

view details

Jaan Jänesmäe

commit sha c61e86949c98273b29a5b897b6f1c5f311bbc997

jetty 9.4.26.v20200117 (#49253)

view details

chenrui

commit sha e5579d9409d365edb6b3590d360deb6a068d9c52

exploitdb 2020-01-21 (#49249)

view details

Lou Rinaldi

commit sha fd9fc10f3d3da5115c0769c81bf9de3c730ca406

supermodel: Update HEAD build Makefile path (#49242) Signed-off-by: Issy Long <me@issyl0.co.uk>

view details

Issy Long

commit sha 697ffdf906158827752770c41e7643530bb809d0

terraform-docs 0.8.1 Closes #49254. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha 2732ddf828de5f38b3c873a05ac8a0094d6be488

terraform-docs: update 0.8.1 bottle.

view details

Rui Chen

commit sha cc971e3e83c9349a1efae8aad3f0b0be36f8d068

hlint 2.2.8 Closes #49257. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha 97eaa9dda8317e66dc6e49e704afad6ffbc7ef7b

hlint: update 2.2.8 bottle.

view details

Rui Chen

commit sha 28708c8b9cd0c066eda26ca2176e6598ccb8af45

borgmatic 1.4.22 Closes #49258. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha 8cfc1293ba237e94b50fa589454f9276dc45c9d0

borgmatic: update 1.4.22 bottle.

view details

Rui Chen

commit sha 1c46145437b6c8c26e8963b8ceaaa79b02e3ba0f

serverless 1.61.3 Closes #49259. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha ef5eaaa011f29d8a4fc13ae914aa63fc57f3bf85

serverless: update 1.61.3 bottle.

view details

Rui Chen

commit sha c2c3a8dcd52f76420ac7b7e26f09a46c23764bf0

git-lfs 2.10.0 Closes #49260. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha 058247d26e927988c79a1a38c3d1c042aa20bc82

git-lfs: update 2.10.0 bottle.

view details

Rui Chen

commit sha 2bcd85e75a6b5a01a004a37ba0b6a65133de412c

micronaut 1.2.10 Closes #49261. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

Rui Chen

commit sha 69171f51bb4894db4835975dd91972b432e30952

h3 3.6.3 Closes #49262. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

push time in 2 months

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 92ba77aab2949be11382ed76b36be64ebabb031d

node: postinstall fix npm man symlinks

view details

push time in 2 months

create barnchchrmoritz/homebrew-core

branch : nodeNpmMan

created branch time in 2 months

issue commentdenoland/rusty_v8

unknown argument: '-gno-inline-line-tables'

Looks like -gno-inline-line-tables was added in https://github.com/llvm/llvm-project/commit/ab76cfdd200d35177df2042a1c0c7e86868d01bc (a recommit after a revert of https://github.com/llvm/llvm-project/commit/6d03890384517919a3ba7fe4c35535425f278f89), which isn't part of a stable llvm/clang release yet. To use it on Linux, you have to either use a version of llvm build from the master branch or use Google's clang binaries.

hayd

comment created time in 2 months

create barnchchrmoritz/homebrew-core

branch : deno-0.30.0

created branch time in 2 months

PR opened Homebrew/homebrew-core

deno 0.30.0

Created with brew bump-formula-pr.

+4 -4

0 comment

1 changed file

pr created time in 2 months

PR opened Homebrew/homebrew-core

geckodriver: optimize download
  • [x] Have you followed the guidelines for contributing?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Fixes: #48660

Also optimize download size by following https://bugzilla.mozilla.org/show_bug.cgi?id=1606297.

+34 -4

0 comment

1 changed file

pr created time in 3 months

push eventchrmoritz/homebrew-core

equal-l2

commit sha 57e8a6f3981a6209cbca27960caad35993feba17

ctl: revision, use C++11 and add patch

view details

equal-l2

commit sha b7829b8260badfd93e5b59b53a8d6ae632b815c9

field3d: revision and use C++11

view details

equal-l2

commit sha 4d61f3d58bf554b65f73c35b31cd76f98c4a6875

imagemagick: revision bump

view details

equal-l2

commit sha e41d80b2024e3f843cec1bed8e064fa0540abb46

opencv: revision bump Closes #44807. Signed-off-by: FX Coudert <fxcoudert@gmail.com>

view details

equal-l2

commit sha 7d39fe220165ac52fd2a92afdbfb70222807805b

opencv@3: revision bump

view details

equal-l2

commit sha 506c1e20d73aae278ae046433564be815bca6fda

openvdb: revision bump

view details

equal-l2

commit sha 0e3b2616df3cb6ab45b7a09dce551651fc6de79e

rawtoaces: revision and use C++11

view details

equal-l2

commit sha 132a28b6a3579c2f4a337cc68e4c6939969ee550

synfig: revision bump

view details

equal-l2

commit sha 6efe1ad8ecbc4dc748510a78af8615c97fe8d426

opencv@2: revision and use C++11

view details

equal-l2

commit sha 1855fbe86f0b282422e0f60d90174df8a38751e1

openimageio: revision bump

view details

equal-l2

commit sha c5219029bd59bab20c47168cd7da02d49d59f71d

vips: revision bump

view details

BrewTestBot

commit sha 6925f1ffdc6669306e961f0f2ce5555417c594d9

imagemagick: update 7.0.9-13_1 bottle.

view details

BrewTestBot

commit sha 51eff06faf6d566402f43c86ad236772412d326f

ctl: update 1.5.2_4 bottle.

view details

BrewTestBot

commit sha 37d6d7a4326bd3b48c791d373e1e532df48fac75

openimageio: update 2.1.9_1 bottle.

view details

BrewTestBot

commit sha 51d6d0e8320e02710ded4a05946c627672785983

openexr: update 2.4.0 bottle.

view details

BrewTestBot

commit sha d5f2601ac0ce342b96063576b7c27455688ed9d8

vips: update 8.8.4_1 bottle.

view details

BrewTestBot

commit sha 5bd06e19c41b106ff3a7ced665b5801574680887

synfig: update 1.2.2_3 bottle.

view details

BrewTestBot

commit sha d3095f3de889869511336974943af34e353284c7

opencv: update 4.2.0_1 bottle.

view details

BrewTestBot

commit sha 99ec1ff17e6aafbbd3d4b20800ea4be139954623

rawtoaces: update 1.0_7 bottle.

view details

BrewTestBot

commit sha fc034806dfd2ccc055b4c96de060b815d33525a9

field3d: update 1.7.2_10 bottle.

view details

push time in 3 months

Pull request review commentHomebrew/homebrew-core

deno 0.29.0

 def install     end      # env args for building a release build with our clang, ninja and gn-    ENV["DENO_NO_BINARY_DOWNLOAD"] = "1"-    ENV["DENO_GN_PATH"] = buildpath/"gn/out/gn"-    args = %W[-      clang_use_chrome_plugins=false-      mac_deployment_target="#{MacOS.version}"-      treat_warnings_as_errors=false-    ]+    ENV["GN"] = buildpath/"gn/out/gn"     if DevelopmentTools.clang_build_version < 1100       # build with llvm and link against system libc++ (no runtime dep)-      args << "clang_base_path=\"#{Formula["llvm"].prefix}\""+      ENV["CLANG_BASE_PATH"] = Formula["llvm"].prefix       ENV.remove "HOMEBREW_LIBRARY_PATHS", Formula["llvm"].opt_lib     else # build with system clang-      args << "clang_base_path=\"/usr/\""+       ENV["CLANG_BASE_PATH"] = "/usr/"

Oh, maybe I should actually look at the audit results next time and not just run it and switch to another tab to test out the new test. 😆 But it was late and I was already tired.

Should be fixed now.

chrmoritz

comment created time in 3 months

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha 1c0c5e6e0d367c6e83a2254136a7f6f340131314

deno 0.29.0

view details

push time in 3 months

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha aec9e4e3f5de1b6ace95c66f360a70b60bd68819

deno 0.29.0

view details

push time in 3 months

PR opened Homebrew/homebrew-core

deno 0.29.0
  • [x] Have you followed the guidelines for contributing?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This PR upgrades deno to v0.29.0, which bring in the new Rust V8 bindings rust_v8, which simplifies our build a bit. 🎉

+9 -14

0 comment

1 changed file

pr created time in 3 months

create barnchchrmoritz/homebrew-core

branch : deno

created branch time in 3 months

issue commentHomebrew/homebrew-core

geckodriver checksum mismatch

I can confirm that, but the commit is still there, so they probably just have changed the compression level used by the zip archive, which would explain the checksum change for that specific commit. However I unfortunately don't have a copy of the old archive anymore, so I can't confirm this assumption.

These changes are quite unfortunate, because I'd really like to avoid having to clone the whole giant mozilla central repository here (containing all the unrelated source code for firefox (mobile), thunderbird...).

RazerM

comment created time in 3 months

create barnchchrmoritz/homebrew-core

branch : deno-0.28.1

created branch time in 3 months

PR opened Homebrew/homebrew-core

deno 0.28.1

Created with brew bump-formula-pr.

+3 -3

0 comment

1 changed file

pr created time in 3 months

create barnchchrmoritz/homebrew-core

branch : deno-0.28.0

created branch time in 3 months

PR opened Homebrew/homebrew-core

deno 0.28.0

Created with brew bump-formula-pr.

+3 -3

0 comment

1 changed file

pr created time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 363399198f1d4e5f86937d7b5110c3526ea25f1f

reset CI

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 9b1ddf0b50195bde315192e076d3b45f5184e745

add comments

view details

push time in 3 months

Pull request review commentdenoland/rusty_v8

allow building with compatible system clang

 bitflags = "1.2.1" [build-dependencies] cargo_gn = "0.0.13" which = "3.1.0"+regex = "1.3.1"

I don't know. Parsing all these different clang version string seems to be quite a difficult task and the regex's from Node.js have been proven over time. You have to distinguish between Apple clang (which uses XCode version and had different version string formats over time) and llvm clang (where also distributions like to modify the format of the version string).

chrmoritz

comment created time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 8000a370e89516007332f3ebb40cd4c0258fdae9

fix fmt

view details

push time in 3 months

push eventchrmoritz/homebrew-core

Christian Moritz

commit sha ff5cec9312ecad6da387f030721239256ec416a3

balena-cli 11.20.2

view details

push time in 3 months

pull request commentHomebrew/homebrew-core

balena-cli 11.20.2

Yeah, I've seen this, the removal of the npm-shrinkwrap.json has broken something else in the mean time (it worked yesterday): They're using a custom module to apply patches to dependency during the postinstall and some of these dependency got updated (according to semver ranges) and breaks the build now.

Trying something different now by making use of said module.

chrmoritz

comment created time in 3 months

PR opened Homebrew/homebrew-core

balena-cli 11.20.2
  • [x] Have you followed the guidelines for contributing?
  • [ ] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

supersedes #47039

+3 -2

0 comment

1 changed file

pr created time in 3 months

push eventchrmoritz/homebrew-core

BrewTestBot

commit sha 1f5afdebb5ec5dcf3d6a8f44bd3371d27c8cc36b

texlab: add 1.8.0 bottle.

view details

jon-ruckwood

commit sha 58fbc2571cd55e6cc2fbe03900db22bc3ece2bb0

terrahelp 0.7.3 (new formula) Closes #47573. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha eb59b8cba64df5fd3f76ebbe82772b9fb03874a7

terrahelp: add 0.7.3 bottle.

view details

Rui Chen

commit sha 6f4d111ab6ed44bdfa8ddc735532fbbb9ab2ace8

hlint 2.2.5 Closes #47583. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha e7f354e1eaac52202086cdef71ab978fd1f3bd83

hlint: update 2.2.5 bottle.

view details

Rui Chen

commit sha 58be107e680251794221a75a04c717467bb253aa

ethereum 1.9.9 Closes #47561. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha e89a5c523ccf0ad68a217a8fd4ce496603add5d7

ethereum: update 1.9.9 bottle.

view details

Matan Kushner

commit sha 4f3a72c8023c721684f195a29b2ba03860d1a19f

starship 0.28.0 Closes #47587. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha 03e180b02892f18f5d913befbe85e4955bc7adb3

starship: update 0.28.0 bottle.

view details

Rui Chen

commit sha 58e0fac13c0c09fbe304fa1c8e6a77a7d3abfd97

netlify-cli 2.24.0 Closes #47588. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha 5b9bd0e888f045285a0c2b538f8d39d3e2610df5

netlify-cli: update 2.24.0 bottle.

view details

BrewTestBot

commit sha e0a03299424531b5773362ac9c3ccf903513fca1

widelands: update 20_1 bottle.

view details

Issy Long

commit sha 32dc0b811a03162374eae914cb78d226bdb6111a

mpv: Ensure that installing uses Python 3 - Over in Homebrew/linuxbrew-core, we thought we could remove `uses_from_macos "python@2"` given this looked to have macOS Python 3 dependencies. - Turns out, `bootstrap.py`'s shebang line had `/usr/bin/env python`, which catches "Python 2" on macOS but nothing on Linux. - To make this actually run wholly with Python 3 everywhere, run `bootstrap` with python3 like the rest of the file does. Closes #47586. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha 8f56b0f0ab4e7bca731f8bf9c9e0ebca77ec7fdf

mpv: update 0.30.0 bottle.

view details

Rui Chen

commit sha 2d8a4d59e81fc08e07aed88bc688507dacf7302f

calicoctl 3.10.2 Closes #47589. Signed-off-by: Rui Chen <chenrui333@gmail.com>

view details

BrewTestBot

commit sha 4d03026d12d67db5656f6f7b78dcfb0b01a94315

calicoctl: update 3.10.2 bottle.

view details

chenrui

commit sha 39e80c94400167c251a8c6c21b440270f11076ad

exploitdb 2019-12-07 (#47593)

view details

Rui Chen

commit sha d3824cb3f5d179fae51f7c258a934acd1a51fbe1

tflint 0.13.2 Closes #47594. Signed-off-by: Caleb Xu <calebcenter@live.com>

view details

BrewTestBot

commit sha 5066c133d4689bafaede2035184a98061e567664

tflint: update 0.13.2 bottle.

view details

Rui Chen

commit sha 5cedce129791649c3ed30f272a7e5b8a2bd4bde2

just 0.5.2 Closes #47595. Signed-off-by: Caleb Xu <calebcenter@live.com>

view details

push time in 3 months

create barnchchrmoritz/homebrew-core

branch : balena

created branch time in 3 months

pull request commentHomebrew/homebrew-core

balena-cli 11.18.3

Can confirm that this works for me:

diff --git a/Formula/balena-cli.rb b/Formula/balena-cli.rb
index c4c6dde472..60aebab505 100644
--- a/Formula/balena-cli.rb
+++ b/Formula/balena-cli.rb
@@ -4,8 +4,8 @@ class BalenaCli < Formula
   desc "The official balena CLI tool"
   homepage "https://www.balena.io/docs/reference/cli/"
   # Frequent upstream releases, do not update more than once a week
-  url "https://registry.npmjs.org/balena-cli/-/balena-cli-11.18.0.tgz"
-  sha256 "39890bd18d6649ce041f477c22b8561027bdac70f0de7885d79709b9cb4875e7"
+  url "https://registry.npmjs.org/balena-cli/-/balena-cli-11.20.2.tgz"
+  sha256 "a78f84c3d343f274d3e51fed1f06656e7cfe557dbe22f9af78871c94f6c1040b"
 
   bottle do
     sha256 "0a5dcaf03c6e45854662631da360f55ca55b16f34341ac4ea1e024f2e0a79f19" => :catalina
@@ -16,6 +16,7 @@ class BalenaCli < Formula
   depends_on "node"
 
   def install
+    rm "npm-shrinkwrap.json" # fix node 13 compatibility
     system "npm", "install", *Language::Node.std_npm_install_args(libexec)
     bin.install_symlink Dir["#{libexec}/bin/*"]
   end
chenrui333

comment created time in 3 months

pull request commentHomebrew/homebrew-core

balena-cli 11.18.3

@chenrui333: This should work with the latest v11.20.2. Could you update this PR to use that version instead?

chenrui333

comment created time in 3 months

PR closed balena-io/node-ext2fs

fix node 13 compatibility

This fixes a compilation error with node 13 making node-ext2fs compatible with it:

../src/node_ext2fs.cc:682:13: error: no matching member function for call to 'Set'
                                result->Set(
                                ~~~~~~~~^~~
/private/tmp/balena-cli-20191121-70503-95z7s4/package/.brew_home/Library/Caches/node-gyp/13.1.0/include/node/v8.h:3424:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/private/tmp/balena-cli-20191121-70503-95z7s4/package/.brew_home/Library/Caches/node-gyp/13.1.0/include/node/v8.h:3427:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
1 error generated.

Refs: https://github.com/Homebrew/homebrew-core/pull/47039 (needed to make balena-cli build/work with node 13)

+4 -1

2 comments

3 changed files

chrmoritz

pr closed time in 3 months

pull request commentbalena-io/node-ext2fs

fix node 13 compatibility

This should be fixed with https://github.com/balena-io/node-ext2fs/commit/84ecfa5665738f42bf7ac7f1f125b09fa7f92dee in v1.0.31.

chrmoritz

comment created time in 3 months

PR closed balena-io/node-usb

Reviewers
fix node 13 compatibility

This PR fixes compilations errors with node 13 like:

../src/node_usb.cc:299:22: error: no matching member function for call to 'Set'
        e.As<v8::Object>()->Set(Nan::New<String>("errno").ToLocalChecked(), Nan::New<Integer>(errorno));
        ~~~~~~~~~~~~~~~~~~~~^~~
/Users/chrmoritz/Library/Caches/node-gyp/13.1.0/include/node/v8.h:3424:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/chrmoritz/Library/Caches/node-gyp/13.1.0/include/node/v8.h:3427:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^

by cherry-picking https://github.com/tessel/node-usb/commit/01ebf16712cf8bf2e30cd136c0f839b317286f46.

Refs: https://github.com/Homebrew/homebrew-core/pull/47039 (needed to make balena-cli build/work with node 13)

+10 -10

2 comments

3 changed files

chrmoritz

pr closed time in 3 months

pull request commentbalena-io/node-usb

fix node 13 compatibility

This should be fixed with https://github.com/balena-io/node-usb/commit/7dc32353a7326a673c9e11fdc1548ffcde88f04e in v1.3.13.

chrmoritz

comment created time in 3 months

Pull request review commentdenoland/rusty_v8

allow building with compatible system clang

 fn need_gn_ninja_download() -> bool {     && env::var_os("GN").is_some()) } +fn is_compatible_clang_version(clang_path: &Path) -> bool {

We'd just need to update the compatible versions constants roughly once per year during a V8 upgrade once Google decides to break compatibility with older clang's again.

Another side node: It looks like a lot of linux distributions ship their versioned clang packages with a version suffix (e.g. clang-8), which is unfortunately not compatible with Chromium's build scripts (and I guess we don't want to patch them too heavily). So this approve is only compatibly with: Apple clang (on macOS), homebrew's llvm packages (on macOS and linux via Homebrew on Linux?), the official llvm binaries (from http://releases.llvm.org/, all platforms) and maybe the default clang package on Linux (but they are often too old anyway).

chrmoritz

comment created time in 3 months

push eventchrmoritz/rusty_v8

Ry Dahl

commit sha d2d8c64785ee922f2e3dc19b2c5ad80b8990f40e

Upgrade to Rust 1.40.0 (#86)

view details

Ry Dahl

commit sha 11ba3520657a163ce64fdd5ce409611488528cb0

Rename CxxIsolate to Isolate and Isolate to OwnedIsolate (#85)

view details

Ryan Dahl

commit sha 71140b4cc486af25e34fb2e8e5bebce5eb36d307

Change HandleScope::enter to take &Isolate, make v8::Locker into opaque blob

view details

Ryan Dahl

commit sha 887af287907ce68941bc5f4a018a7efbded3b25c

Remove LockedIsolate

view details

Ry Dahl

commit sha b610e7cda928c502aa671526b9aaa3ea2f78cb62

Add v8::Isolate::add_message_listener (#89)

view details

Ry Dahl

commit sha 68742be01182576d2bc5b7c17a8cf0ea0fd5f042

Remove lifetimes from Local, HandleScope, Locker (#90) add v8_str

view details

Ryan Dahl

commit sha 8810789f7893e31443fb4c7fe0671112ad27256f

v0.0.13

view details

Ry Dahl

commit sha e89a968ff2120c2bb1131918173dae8be4ef93fb

add more docs and clean up exception, json modules (#92)

view details

Bartek Iwańczuk

commit sha beb9272f3882ad6d856fec9cfcaf83ad68162d3a

stub out v8::Module (#69)

view details

Ry Dahl

commit sha 9e30db08ce24cc7e7026542083071dce8ae1c94e

Remove 'using namespace v8' from binding.cc (#93)

view details

Bartek Iwańczuk

commit sha 85229bdd8ac9899b182a059725131d874e069bea

add v8::PropertyCallbackInfo (#68)

view details

Bert Belder

commit sha 450afc3dd64815d82f614583e318e203e2c4aa93

Add note about libglib2.0-dev dependency to README (#94)

view details

Ry Dahl

commit sha bbfaacfe56484581aaf301106a2d04f0efa0e8b0

Add v8::ScriptCompiler::compile_module (#96)

view details

Bert Belder

commit sha 331582561b3b4280c9d98d8d23405e04546c7ead

Add Local lifetimes back (#95)

view details

Bert Belder

commit sha f839aa221a57dcb9fc8795e2cdb7e44b77475a2b

Add TryCatch (#97)

view details

Ry Dahl

commit sha 32fc7e7befc0371ae821715efe5fe95eb0218671

add v8::Module::instantiate_module (#98) Co-authored-by: Bert Belder <bertbelder@gmail.com>

view details

Bert Belder

commit sha 61245546518005c040228821258188f952d1a0bd

Remove 'type' param from v8::String::new() convenience function (#99)

view details

Bert Belder

commit sha 52da1f32167ef5de479092070650a4fa05b88512

Upgrade crates (#100)

view details

Bert Belder

commit sha fab24e032e1eb701e1188ff4ce7f5b5986c06f52

Make TryCatchScope public, improve doc strings (#102)

view details

Bert Belder

commit sha 196b5f60e4bf5a80b398c7e1daeb1f9f7b6a35d3

Fix more mutability and lifetime issues (#103)

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 2e7fa31f2ef979ac1d757b1a406a62b8cb36ae01

llvm 8 is supported

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 35741b0d04e20710af6e5c2efe2e4d32087606c9

use upstream llvm 8 on linux

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 1359997dc91580b2a26b218f49efb5f5f306bc76

use upstream llvm 8 on linux

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 9de080663d77a81b045232934a4b45974c9f64b8

use upstream llvm 8 on linux

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 2f33bd53ef7b4b23eb3c3ccbee8a5d374f144b27

use upstream llvm 8 on linux

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 4d8413024b7059acb2666886cf68909c37f06743

use upstream llvm 8 on linux

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 79db4fbe8a7de75e4235d95383a7105f2ccbb02c

use upstream llvm 8 on linux

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha ebf0394c38c2f39823e8523b03942db2a48e92ed

use upstream llvm 8 on linux

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 54f5aba5e5e5d697f69178a148cf46e155db0e01

clang 8 on linux

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 0ac5aca781ae2b2ee11017a98eb2cad42e6dd8e1

clang 8 on linux

view details

push time in 3 months

push eventchrmoritz/rusty_v8

Christian Moritz

commit sha 5b1485acc40f4b236b8237ca106834b25871be38

llvm 8 is supported

view details

push time in 3 months

more