profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/chrislloyd/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

chrislloyd/brains 5

mmmm... BRAINS

carlwoodward/fancyroutes 2

The fanciest routes in town

chrislloyd/Binary 1

Binary clock for Mac OSX.

chrislloyd/decent_exposure 1

A helper for creating declarative interfaces in controllers

chrislloyd/agent 0

The Buildkite Agent is an open-source toolkit written in Golang for securely running build jobs on any device or network

chrislloyd/arcanist-owners 0

An Arcanist extension for displaying file ownership information

chrislloyd/basscss 0

Low-level CSS Toolkit

startedmypalmike/skastic

started time in 2 days

startedconventional-commits/conventionalcommits.org

started time in 2 days

startedorhun/git-cliff

started time in 2 days

startedJack000/SVGnest

started time in 14 days

startedadelsz/pgtyped

started time in 15 days

startedBenLangmead/bowtie

started time in 16 days

PR closed lobsters/lobsters

Fix master CI

This commit fixes 2 issues on master currently causing CI to fail:

  1. There's dead code causing a lint failure
  2. Mimemagic 0.3.5 was yanked from rubygems, causing gem installs to fail

To address these I've:

  1. Removed the dead code. It looks fairly useful, however it'll live on in git history if needed.
  2. Upgraded mimemagic to the closest published version.

Test plan: CI passes

+3 -29

0 comment

2 changed files

chrislloyd

pr closed time in 22 days

PR closed buildkite-plugins/docker-compose-buildkite-plugin

Defaults docker compose version to 2

When using the skip-checkout option and multi-step builds, build_image_override_file without a docker-compose.yml (it hasn't been checked out). This causes the script to fail with an error like:

[2020-07-02T00:34:10Z] /etc/buildkite-agent/plugins/github-com-buildkite-plugins-docker-compose-buildkite-plugin-v3-3-0/hooks/../lib/shared.bash: line 118: docker-compose.yml: No such file or directory
[2020-07-02T00:34:10Z] The 'build' option can only be used with Compose file versions 2.0 and above.
[2020-07-02T00:34:10Z] For more information on Docker Compose configuration file versions, see:
[2020-07-02T00:34:10Z] https://docs.docker.com/compose/compose-file/compose-versioning/#versioning

This PR conservatively sets docker_compose_config_version to 2 if no prior compose files are found (like in the case above). I selected 2 as it's the most conservative version that should a.) be able to execute the generated compose file and b.) expected to run on hosts (see comment on :146 of that file). I also specifically didn't fix this more locally to the usecase (build_image_override_file) because it's possible there are compose files but with incorrect versions and it would be difficult to pick up that case.

I believe this fixes #232 and #122.

Test Plan

None yet. I'm new to the project and the tests dir seemed a little light. I would love some help/direction in that regard!

+4 -0

1 comment

1 changed file

chrislloyd

pr closed time in 22 days

PR closed chrislloyd/arcanist-owners

Hide weak owners when there's a stronger owner

Sometimes weak ownership packages where confusing because they were listed with the same prominance as strong owners. If there's a strong owner, the weak owner isn't particularly useful. This stops outputting weak owners if there is a strong owner available. It also colorizes weak owners gray so we don't have to output the dominion labels each time.

+17 -5

0 comment

1 changed file

chrislloyd

pr closed time in 22 days

PR closed facebook/jscodeshift

Methods to find JSX elements from ES6 imports CLA Signed

This PR adds two extra methods to Collection that helps people find JSXElements when using ES6 imports. An example:

import Foo from 'foo';
import { Bar as NewBar } from 'bar';

<Foo />
<NewBar />
nodes.findJSXElementsByImport('foo'); // returns <Foo />
nodes.findJSXElementsByNamedImport('bar', 'Bar'); // returns <NewBar />

Tests included.

+83 -8

1 comment

2 changed files

chrislloyd

pr closed time in 22 days

PR closed chrislloyd/signupsumo-web

Update typos in the docs.

Just a couple of fixes to the docs around the place.

+4 -4

0 comment

2 changed files

chrislloyd

pr closed time in 22 days

issue closedpinterest/teletraan

Incorrect list of commits after deploying a cherry-pick build

The next deploy immediately after a cherry pick build has an incorrect set of commits. Consider this scenario:

Commit Build/deploy Actual commit list Expected commit list
C1
C2 C2 <- build 1, deploy 1 C1, C2 -
C3
C4 build 2, deploy 2 cherry picked commit on top of C2 C1, C2, C4 -
C5
C6 build 3, deploy 3 C5, C6 C3, C4, C5, C6

Teletraan is picking up the base SHA as the last cherry-picked commit instead of the base sha of the last non-cherry picked build.

closed time in 22 days

chrislloyd

issue closedpinterest/teletraan

Clicking on a date in the ngapp2 deploys page does nothing

screen shot 2018-09-14 at 4 02 59 pm

If you click the highlighted text or the arrow, nothing happens. I wasn't sure if this was a bug or intentional. URL is /ngapp2/deploys

closed time in 22 days

chrislloyd

issue closedpinterest/teletraan

Current builds on ngapp2 overview pages are incorrect

When viewing the overview page for an A/B deploy, the currently serving SHA is different than when viewing an environment directly:

screen shot 2018-09-13 at 9 43 23 am

In the A cluster:

screen shot 2018-09-13 at 9 43 35 am

In the B cluster:

screen shot 2018-09-13 at 9 43 31 am

closed time in 22 days

chrislloyd

issue closedpinterest/teletraan

Review apps

Heroku has the functionality to be able to deploy review apps for projects on a per PR basis. It's incredibly useful when trying to review code as you inspect visual changes via. a deployment and run integration tests on it.

Is this possible with Teletraan?

closed time in 22 days

chrislloyd

startedjamesog/tailscale-edgeos

started time in a month

startedluntergroup/octopus

started time in a month

pull request commentbazelbuild/rules_nodejs

Fix typo in stamping docs

@googlebot I signed it!

chrislloyd

comment created time in a month

push eventchrislloyd/upload-release-asset

Chris Lloyd

commit sha 6a52fa8db411fea59127eab27460ff7159a952c7

Glob support

view details

push time in a month

fork chrislloyd/upload-release-asset

An Action to upload a release asset via the GitHub Release API

fork in a month

PR opened bazelbuild/rules_nodejs

Fix typo in stamping docs
+1 -1

0 comment

1 changed file

pr created time in a month

push eventchrislloyd/rules_nodejs

Chris Lloyd

commit sha e41ebfd2557726a52b7fc3a92d8a25435d0c4f15

Fix typo in stamping docs

view details

push time in a month

fork chrislloyd/rules_nodejs

JavaScript and NodeJS rules for Bazel

fork in a month

delete branch chrislloyd/rules_codeowners

delete branch : patch-1

delete time in a month

startedalenia/aqiduck

started time in a month

PR opened zegl/rules_codeowners

Fix typo in docs
+1 -1

0 comment

1 changed file

pr created time in a month

push eventchrislloyd/rules_codeowners

Chris Lloyd

commit sha c2beee12dd7a056e34173d1e30c5dee9fda980b7

Fix typo in docs

view details

push time in a month

fork chrislloyd/rules_codeowners

Bazel rules for generating CODEOWNERS from a workspace.

fork in a month

delete branch chrislloyd/next.js

delete branch : fix-type-declarations-write

delete time in a month

Pull request review commentvercel/next.js

Avoid fs write `next-env.d.ts` on read-only filesystems

 export async function writeAppTypeDeclarations(   // Reference `next` types   const appTypeDeclarations = path.join(baseDir, 'next-env.d.ts') -  await fs.writeFile(-    appTypeDeclarations,+  const content =     '/// <reference types="next" />' +-      os.EOL +-      '/// <reference types="next/types/global" />' +-      os.EOL +-      (imageImportsEnabled-        ? '/// <reference types="next/image-types/global" />' + os.EOL-        : '') +-      os.EOL +-      '// NOTE: This file should not be edited' +-      os.EOL +-      '// see https://nextjs.org/docs/basic-features/typescript for more information.' +-      os.EOL-  )+    os.EOL ++    '/// <reference types="next/types/global" />' ++    os.EOL ++    (imageImportsEnabled+      ? '/// <reference types="next/image-types/global" />' + os.EOL+      : '') ++    os.EOL ++    '// NOTE: This file should not be edited' ++    os.EOL ++    '// see https://nextjs.org/docs/basic-features/typescript for more information.' ++    os.EOL++  // Avoids a write for read-only filesystems+  if (+    (await fileExists(appTypeDeclarations)) &&+    (await fs.readFile(appTypeDeclarations, 'utf8')) === content

Ah. That's a good point and would have fixed it if the merge queue hadn't kicked in. I think practically, that case is unlikely to be an issue here - the window where the user would have to write the file is slim and the consequence is small. Is it worth a PR to fix?

chrislloyd

comment created time in a month