profile
viewpoint

chingor13/cache_debugging 6

Verify rails cache dependencies

chingor13/autobots 5

Loading and serializing models in bulk with caching

chingor13/action_texter 1

ActionMailer like gem for sending SMS messages

chingor13/acts_as_expirable 1

ActiveRecord extension to easily allow expiration of records

chingor13/actions-test 0

Playground for testing GitHub Actions

chingor13/aoc 0

Advent of Code 2016, 2017

chingor13/api-spec-converter 0

Convert API descriptions between popular formats such as OpenAPI(fka Swagger), RAML, API Blueprint, WADL, etc.

chingor13/artman 0

Artifact Manager, a build and packaging tool for Google API client libraries.

Pull request review commentgoogleapis/release-please

fix: extra file path relativity

 export abstract class BaseStrategy implements Strategy {     return Version.parse('1.0.0');   } +  /**+   * Adds a given file path to the strategy path.+   * @param {string} file Desired file path.+   * @returns {string} The file relative to the strategy.+   */   protected addPath(file: string) {-    if (this.path === ROOT_PROJECT_PATH) {-      return file;+    // There is no strategy path to join, the strategy is at the root, or the+    // file is at the root (denoted by a leading slash or tilde)+    if (!this.path || this.path === ROOT_PROJECT_PATH || /^~?\//.test(file)) {+      file = path.posix.normalize(file);     }-    file = file.replace(/^[/\\]/, '');-    if (this.path === undefined) {-      return file;-    } else {-      const path = this.path.replace(/[/\\]$/, '');-      return `${path}/${file}`;+    // Otherwise, the file is relative to the strategy path+    else {+      file = path.posix.join(this.path, file);     }+    // Strip any leading pathings (i.e. ~/, ../, /) and any trailing slashes and return+    return file.replace(/^(\.{1,2}|~|\/)*\//, '').replace(/\/+$/, '');

Yes, let's disallow extra relativity. We should make sure that / actually is relative from the git root and that paths without the leading / are relative to the component's root.

axieum

comment created time in 10 hours

PullRequestReviewEvent

push eventgoogleapis/release-please

Jeff Ching

commit sha a0e244c6eb49b05a76dd7194f532c0273f970752

fix: release notes should parse initial version heading

view details

push time in 10 hours

push eventgoogleapis/release-please

Jeff Ching

commit sha 26c55b652218d087be08dcb6135f5aae7399ce1b

test: failing test for parsing initial release version

view details

push time in 10 hours

create barnchgoogleapis/release-please

branch : initial-release-notes

created branch time in 11 hours

pull request commentgoogleapis/repo-automation-bots

fix(deps): update dependency @octokit/webhooks-types to v5

Everything else is on v4

renovate-bot

comment created time in 11 hours

PR closed googleapis/repo-automation-bots

fix(deps): update dependency @octokit/webhooks-types to v5

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@octokit/webhooks-types ^4.15.0 -> ^5.0.0 age adoption passing confidence

Release Notes

<details> <summary>octokit/webhooks</summary>

v5.1.0

Compare Source

Features

v5.0.0

Compare Source

Bug Fixes
  • update event properties descriptions for changes in github docs URLs (#​596) (5f26c05)
BREAKING CHANGES
  • remove content_reference event

v4.18.0

Compare Source

Features
  • new changes.base property on pull_request#edited, new merged_at property on issues common schema, new rerequestable property on check_suite#completed, new log_url property on deployment#created (#​598) (12c2a16)

v4.17.1

Compare Source

Bug Fixes

v4.17.0

Compare Source

Features

v4.16.0

Compare Source

Features
Fixes
  • repository is not always present for project_card events (#​576) (06cd305)
  • add internal to allowed values for repository#visibility (#​576) (5309b15)
  • the property check_suite#after can be null (#​576) (2281de8)
  • add missing branch_protection_rule event to App (#​576) (4aa1c44)
  • correct typo in enum for App key permission (#​576) (de51a73)

</details>


Configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

+11 -4

6 comments

2 changed files

renovate-bot

pr closed time in 11 hours

PR opened googleapis/release-please

fix: multi-component manifest release notes for single component release

When merging pull requests for multi-component manifests, always use the component-separate pull request body style.

Fixes #1245

+40 -2

0 comment

7 changed files

pr created time in 11 hours

create barnchgoogleapis/release-please

branch : fix-manifest-single-release

created branch time in 11 hours

issue commentgoogleapis/release-please

Release notes in the github tag is in raw markdown

So in this one the release notes are actually empty, so it's showing the commit message from the tagged commit. Still need to figure out why it didn't parse correctly.

Neenu1995

comment created time in 12 hours

PullRequestReviewEvent

pull request commentgoogleapis/repo-automation-bots

chore: release main

Need to investigate why this is not using the multi-release body sections

release-please[bot]

comment created time in 12 hours

PullRequestReviewEvent

push eventgoogleapis/release-please

gsrushton

commit sha 04a44ab08e8ce3911ad814744cebb79aab2ef8aa

fix: Manifest.fromFile no longer ignores manifestFile arg (#1243) * fix: Manifest.fromFile no longer ignores manifestFile arg * chore: fix lint Co-authored-by: Jeff Ching <chingor@google.com>

view details

push time in 13 hours

issue closedgoogleapis/release-please

Pull requests generated in "manifest mode" don't include a patch for manifests that aren't at the default location

Environment details

  • OS: Ubuntu 20.04
  • Node.js version: 16.13.2
  • npm version: 8.1.2
  • release-please version: 13.4.1

Steps to reproduce

  1. Create release-please-config.json and .release-please-manifest.json and move .release-please-manifest.json to a sub-folder.
  2. Push a commit which would prompt a version bump.
  3. Run release-please release-pr --repo-url <...> --token <...> --config-file release-please-config.json --manifest-file subfolder/.release-please-manifest.json
  4. Observe that the pull request doesn't include a patch for subfolder/.release-please-manifest.json
  5. Also observe following in output:

❯ Fetching .release-please-manifest.json from branch master ⚠ file .release-please-manifest.json did not exist

closed time in 13 hours

gsrushton

push eventgsrushton/release-please

Jeff Ching

commit sha a52cd040e961553830ab243bc782b82f5afb0195

chore: fix lint

view details

push time in 13 hours

PullRequestReviewEvent

issue commentgoogleapis/release-please

manifest with single component updated does not create the correct pull request

Example: https://github.com/googleapis/repo-automation-bots/pull/3118

chingor13

comment created time in 13 hours

issue openedgoogleapis/release-please

manifest with single component updated does not create the correct pull request

It should still have the GitHub <summary> sections that have the component/version in the expanding window

created time in 13 hours

PullRequestReviewEvent

push eventgoogleapis/repo-automation-bots

Jeff Ching

commit sha 4b668fedd279e80461a63a6ca1e1c92f35d683e9

feat: allow overriding the backend service name (#3116)

view details

push time in 15 hours

delete branch googleapis/repo-automation-bots

delete branch : backend-name

delete time in 15 hours

PR merged googleapis/repo-automation-bots

feat: allow overriding the backend service name

This will allow us to run a separate frontend service from the backend service. The frontend will still queue to the task queue named after the bot, but it can target a different backend GCF/Cloud Run instance. This will allow us to tune the frontend/backend scaling differently.

To use, add taskTargetName option when initializing GCFBootstrapper.

Towards #2744

+90 -2

0 comment

2 changed files

chingor13

pr closed time in 15 hours

push eventgoogleapis/repo-automation-bots

Jeff Ching

commit sha 37a7f608b259ae7e55b19977a322f31d1a09798e

deps: update release-please to 13.4.1 (#3113)

view details

WhiteSource Renovate

commit sha e367482f80c3f9a62f4558e6b74327dafa39ff25

fix(deps): update google.golang.org/genproto commit hash to 00ab72f (#3096)

view details

yoshi-code-bot

commit sha 633fd098d50e0d9261a4ca86c26d7dfd8b44f90b

deps: update generate-bot deps (#3045) Co-authored-by: Benjamin E. Coe <bencoe@google.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>

view details

sofisl

commit sha c5a57f814f7714afd9106fe6df45dde3d59e8536

feat: make auto-approve handle build.gradle dependency upgrades and apiary versioning schemes (#3076) * feat: make auto-approve handle build.gradle dependency upgrades and apiary versioning schemes

view details

Jeff Ching

commit sha 5cb26cc287b34e1482a878a3d8f2bb01c39001d2

Merge branch 'main' into backend-name

view details

push time in 15 hours

PR opened googleapis/repo-automation-bots

feat: allow overriding the backend service name

This will allow us to run a separate frontend service from the backend service. The frontend will still queue to the task queue named after the bot, but it can target a different backend GCF/Cloud Run instance. This will allow us to tune the frontend/backend scaling differently.

Towards #2744

+90 -2

0 comment

2 changed files

pr created time in 16 hours

create barnchgoogleapis/repo-automation-bots

branch : backend-name

created branch time in 16 hours

delete branch GoogleCloudPlatform/getting-started-python

delete branch : chingor13-patch-1

delete time in 2 days

more