profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/charlesxsh/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

charlesxsh/mdk3-master 39

Modifications to MDK3 to reboot Access Points

charlesxsh/atom 0

:atom: The hackable text editor

charlesxsh/CocoaAsyncSocket 0

Asynchronous socket networking library for Mac and iOS

charlesxsh/cpython 0

Semi-official read-only mirror of the CPython Mercurial repository

PR opened kubernetes/kubernetes

correct fix in #102635

Signed-off-by: Shihao Xia charlesxsh@hotmail.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide/first-contribution.md#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here: https://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label
  3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
  4. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  5. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests -->

What type of PR is this?

<!-- Add one of the following kinds: /kind bug /kind cleanup /kind documentation /kind feature /kind design

/kind bug

Optionally add one or more of the following kinds if applicable: /kind api-change /kind deprecation /kind failing-test /kind flake /kind regression -->

What this PR does / why we need it:

This PR is intend to complete fix in #102635.

podKillChan is an unbuffered channel. It seems to me that some child goroutines are created by the function call at line 2. Those child goroutines send messages to podKillChan. If the parent goroutine chooses line 3, it terminates the current function and no other goroutine can pull messages from channel podKillChan, leaving some child goroutines to be blocked at their sending operations forever.

In total, there are len(tc.activePods) messages sent to channel podKillChan. Thus, we should change the channel buffer size to len(tc.activePods).

Which issue(s) this PR fixes:

<!-- Automatically closes linked issue when PR is merged. Usage: Fixes #<issue number>, or Fixes (paste link of issue). If PR is about failing-tests or flakes, please post the related issues/tests in a comment and do not use Fixes --> Fixes #102635

Special notes for your reviewer:

Does this PR introduce a user-facing change?

<!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md -->


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

<!-- This section can be blank if this pull request does not require a release note.

When adding links which point to resources within git repositories, like KEPs or supporting documentation, please reference a specific commit and avoid linking directly to the master branch. This ensures that links reference a specific point in time, rather than a document that may change over time.

See here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files

Please use the following format for linking documentation:

-->


+1 -1

0 comment

1 changed file

pr created time in 10 days

create barnchcharlesxsh/kubernetes

branch : fix-102635

created branch time in 10 days

pull request commentmoby/moby

fix a potential deadlock (restartmanager/restartmanager.go)

Not LGTM

If line 117 happened first, and there is no receiver for ch created at line 108, line 115 might be blocked forever.

Line 117 and 115 are mutually exclusive. If one case executes, the other doesn't.

More precise description should be: We cannot guarantee ch has a receiver when <-rm.cancel happened in all possible situations. Many rm.ShouldRestart(...) calls directly ignore the channel return value, which directly make ch has no receiver. That's I think making it buffer increase 1 can ensure sending operation will not block its child goroutine.

charlesxsh

comment created time in 10 days

push eventcharlesxsh/kubernetes

Anago GCB

commit sha d2fc500f0746d6b49195a83a30b96d45aadb488e

Merge remote-tracking branch 'origin/master'

view details

Anago GCB

commit sha 40bc3a81a8795c45b019fd720b5f22657e9ab136

Merge remote-tracking branch 'origin/master'

view details

Matthew Cary

commit sha fb5b966a88a4f32563cb8963a5cb0752bdef25d9

Revert "Add StatefulSetAutoDeletePVC feature gate" This reverts commit 0feba0c4eec86a65500ef2c0043f2c3b148f4685.

view details

Matthew Cary

commit sha 10a3cc815bea73f78f7126cab5df95233da96e1b

Revert "statefulset PersistentVolumeClaimDeletePolicy api change" This reverts commit e4e735cd1cf6e9c06f98a6cc8785ae5f0ab5c099. Change-Id: I3e17aa585fd9ae4f9e74b97326ae6b9fadd2a94c

view details

kerthcet

commit sha d1e9da9f8a0f17caad135e8baca63829b343d448

update comment with EnqueueExtensions Signed-off-by: kerthcet <kerthcet@gmail.com> update comment with EnqueueExtensions Signed-off-by: kerthcet <kerthcet@gmail.com> update comment with EnqueueExtensions Signed-off-by: kerthcet <kerthcet@gmail.com> update comment with EnqueueExtensions Signed-off-by: kerthcet <kerthcet@gmail.com>

view details

boenn

commit sha 1980b18c4589d62ffc08531dc81fa59eb45695fb

Solved the test problem and added update comment

view details

Aohan Yang

commit sha 4101c8b3cb3f8acc09e5bf04118a62910eb530ad

Set out.TargetCPUUtilizationPercentage correctly when converting autoscaling_HorizontalPodAutoscalerSpec to v1_HorizontalPodAutoscalerSpec

view details

Kubernetes Prow Robot

commit sha 76b09061362c789878fae5e7c3e0f65c82a40f50

Merge pull request #101047 from jsturtevant/issue-100966-dualstack-windows [sig-windows] update winkernel to only use dualstack if the node and config supports it

view details

David Ashpole

commit sha e5a1f86e0ac21de6bacbb9fed242853ff20c3aaf

add apiserver tracing integration test, and fix endpoint validation

view details

Kubernetes Prow Robot

commit sha 43c9e8e7a1d063670e40ca1c8e0fa280595043d0

Merge pull request #103234 from dashpole/apiserver_e2e_test Add integration test for apiserver tracing

view details

wojtekt

commit sha 1f2902a336cf1d2745d479610b4631bd3a69cc44

Fix panic in master upgrade tests

view details

Kubernetes Prow Robot

commit sha 5acefcc2bc68b527f22c70f476ca6da52d04c03c

Merge pull request #100886 from claudiubelu/cuda-vector-add-update tests: Updates cuda-vector-add:1.0 image to the promoted registry

view details

wojtekt

commit sha ef435b85b47618d0d463ac93e9758d75c2998681

Optimize APF support for watch initialization to fix the pod startup time regression.

view details

wojtekt

commit sha faed88bb7200cc4693b7a3f9cecff1a99ea1fc95

Add additional APF test for handling other panic types

view details

Kubernetes Prow Robot

commit sha 8cda0d7f9c826d694ab5809bbecd9ea854479971

Merge pull request #103733 from wojtek-t/fix_master_upgrade_test Fix panic in master upgrade tests

view details

Kubernetes Prow Robot

commit sha 33aba7ee025dfddcc140d20e9ca353ffd425f1ae

Merge pull request #103660 from wojtek-t/pf_optimize_watch_initialization Optimize APF support for watch initialization to fix the pod startup time regression

view details

Matthew Cary

commit sha aeb82243fc863c44c3603f0d3bf4d8910774765e

Revert "tests for statefulset PersistentVolumeClaimDeletePolicy api change" This reverts commit b259686b367ffef89310a71875834a97befc5b4b. Change-Id: I25cc8ae8a9aa77d0bc483147d3f8fb65616a2b2b

view details

Kir Kolyshkin

commit sha eb5df869baafdf1f74e4514c68f2c67efeb800b7

vendor: bump runc to 1.0.1 The commands used were (roughly): hack/pin-dependency.sh github.com/opencontainers/runc v1.0.1 hack/lint-dependencies.sh # Follow its recommendations. hack/pin-dependency.sh github.com/cilium/ebpf v0.6.2 hack/pin-dependency.sh github.com/opencontainers/selinux v1.8.2 hack/pin-dependency.sh github.com/sirupsen/logrus v1.8.1 # Recheck. hack/lint-dependencies.sh GO111MODULE=on go mod edit -dropreplace github.com/willf/bitset hack/update-vendor.sh # Recheck. hack/lint-dependencies.sh hack/update-internal-modules.sh # Recheck. hack/lint-dependencies.sh Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Kir Kolyshkin

commit sha e5b434e990de5f05c41411f07236cb7b2d663a00

kubelet/cm: don't set Devices Since runc 1.0.0 it is now sufficient to have SkipDevices: true. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

TAGAMI Yukihiro

commit sha 3d1076ebf310820a2e6163a48f1485e1ab2d670b

fix AsApproximateFloat64() for BinarySI

view details

push time in 10 days

push eventtheogonic/zeus

Shihao Xia

commit sha 4f034709e4c65760ff2f7c330b222abec43d6f9c

0.0.38

view details

push time in 11 days

push eventtheogonic/zeus

Shihao Xia

commit sha b9eb6d03ab264bffc51e94909c4adbd02ee52384

0.0.36

view details

Shihao Xia

commit sha da3a29b725b90f9b4d60b08e6457603d855b9b34

update gaea

view details

Shihao Xia

commit sha 6f698ce3b67ea56eac6555ed127315b04e6474d5

0.0.37

view details

Shihao Xia

commit sha 630cdc6187f111d63e1b017ff7fc6e07ad1bf98a

fix platform path issue at loader fix incorrect types

view details

push time in 11 days

issue commentnestjs/graphql

The reference parameter is undefined when passing the @Context() decorator using the @ResolveReference() decorator

The following code seems like a workaround for this issue

@ResolveReference()
resolveReference(@Parent() reference, @Context() ctx) {

This code works for me to correctly resolve reference and context

fredeprez

comment created time in 12 days

push eventtheogonic/gaea

Shihao Xia

commit sha 3135a76f85936a3c5627aab238dfcde6a52d5cca

add gql type

view details

push time in 14 days

push eventtheogonic/zeus

Shihao Xia

commit sha bb0ee1c3b6b8075bc753889b87e81b147d7851e3

small fixes

view details

push time in 15 days

push eventtheogonic/zeus

Shihao Xia

commit sha bde3d7ad6f30fce66e68b7ab9088820cab9b731d

0.0.35

view details

Shihao Xia

commit sha 17e8f4d6d83f1b7b3de94caa8dddd710eccf5b5b

support seperate schema

view details

push time in 20 days

issue openedapollographql/federation

Nested key with shared type failed to pass external check

<!--

Thanks for taking the time to file a helpful issue report!

Before reporting a bug, please first check for existing or closed issues and read the instructions for filing a bug report:

https://github.com/apollographql/federation/blob/HEAD/CONTRIBUTING.md#reporting-bugs

This bug report should include:

  • [ ] A short, but descriptive title. The title doesn't need "Apollo" in it.
  • [ ] When a published package is being used, the package management system it is published in along with the specific names and versions.
  • [ ] If applicable, the last version(s) where the problem did not occur.
  • [ ] The expected behavior.
  • [ ] The actual behavior.
  • [ ] A simple, runnable reproduction! Please make a GitHub repository that anyone can clone and run and see the problem.

Please make sure that you include the following information to ensure that your issue is actionable. If you don't follow the above template, your issue may end up being closed without anyone looking at it carefully.

We appreciate your help!

--> If Meta is a shared type (means it exists both services):

type Meta {
    id: ID!
}

User Service:

User @key(fields: "meta {id}") {
    meta: Meta
}

Another service is trying to extend type User:

extend type User @key(fields: "meta {id}") {
    meta: Meta @external
}

Under Apollo Federation, gateway will report [...] Meta -> A @key directive specifies the id field which has no matching @external field.

Am I missing anything?

created time in 21 days

issue commentapollographql/federation

Circular services + nested Entity keys fail to resolve

If Meta is are shared type (means it exists both services):

type Meta {
    id: ID!
}

User Service:

User @key(fields: "meta {id}") {
    meta: Meta
}

Another service is trying to extend type User:

extend type User @key(fields: "meta {id}") {
    meta: Meta @external
}

Under Apollo Federation, gateway will report [...] Meta -> A @key directive specifies the id field which has no matching @external field.

Am I missing anything?

rickhutcheson

comment created time in 21 days

issue commentapollographql/federation

Circular services + nested Entity keys fail to resolve

any update on this issue?

rickhutcheson

comment created time in 21 days

push eventtheogonic/zeus

Shihao Xia

commit sha 21f597a14823aaf73871131cb225007851bd3f98

0.0.31

view details

Shihao Xia

commit sha 152fd3cfbaf4648d8d1f94b1e8888e1d0f1066c5

add generate input version in gql

view details

Shihao Xia

commit sha 7589706ba414c0d936e7bec11608e451a87d7005

0.0.32

view details

Shihao Xia

commit sha 528be6322f1749ac845504268ba9033973f9ee79

fix recursive input generating in gql

view details

Shihao Xia

commit sha ad934e71e6415fa7be6b205081869a8991ab3ce9

0.0.33

view details

Shihao Xia

commit sha 55ae89bf027d8f7fde2bd614d7be0edeeee0e61d

fix array type

view details

Shihao Xia

commit sha 98b0a5eefa16c6f54d8e9095598fb2f420fc46cc

0.0.34

view details

Shihao Xia

commit sha c2b14d02d67b6cf25e08806f4a09d71f911a985e

ignore enum in input

view details

push time in 21 days

push eventtheogonic/zeus

Shihao Xia

commit sha ab072d80a5002dd2e527e2d6edc436a973279803

0.0.30

view details

Shihao Xia

commit sha ea05a4329289349d13c412f0526020a9a641defd

add empty input in graphql

view details

push time in 21 days

push eventtheogonic/zeus

Shihao Xia

commit sha acd7420e5d58d4805ff01f95cf36b53ec3893866

update readme.md

view details

Shihao Xia

commit sha 25560c3353f7a94f3a20a24f19b83332fbbec7eb

0.0.29

view details

Shihao Xia

commit sha ff71d56b9d723cc93160604699f9b3210c6b5af7

wip: rest-nestjs

view details

push time in 22 days

push eventtheogonic/zeus

Shihao Xia

commit sha 20bc7832886605bf89457a6017308bd694781f7f

update bool pipe

view details

Shihao Xia

commit sha 3577cad7639cc2203736d9f71167c9dbb97f332c

exclude examples

view details

Shihao Xia

commit sha f18b80bf98d77e868e1029bd0402fe2232c51790

0.0.26

view details

Shihao Xia

commit sha e33e17c6de3ac00b9cfc80ab9fa36d88ac76f19c

add query support

view details

Shihao Xia

commit sha 925baa00e057f71299ff4b1c9a4270753e6c4dc6

0.0.27

view details

Shihao Xia

commit sha 992b733d82e125328399d0e92829df4cd604cb48

add dep

view details

Shihao Xia

commit sha 8db1b04aa16984b4d859163a2ac9e6a12c2858dc

0.0.28

view details

Shihao Xia

commit sha 85b74b7b071e071e3dbfdaa38086661abd85c8a1

add graphql schema generation

view details

push time in 23 days

issue commentethereum/go-ethereum

console/console_test: channel operations found blocking forever during fuzzing

@BurtonQin thank you for reporting this. We need more information to reproduce this problem: what were the inputs that you used to find it? What is the protocol that you used? Are you jsut running the test repeatedly or are you modifying/instrumenting the code to figure this out?

We used fuzzing related methods to find these issues. We took the both ways: running the test repeatedly with instrumented code :)

BurtonQin

comment created time in 23 days

push eventtheogonic/gaea

Shihao Xia

commit sha 69c10e01928c302a78ae294b9877c82946062c3a

add base subscriber

view details

Shihao Xia

commit sha df7c174c594d8e56a6781a777bb5f3a90654eed6

0.0.6

view details

Shihao Xia

commit sha b8270deaa82c28783c02fc089b72d1605fdf78b2

update subscriber

view details

Shihao Xia

commit sha 5d00db95704ab059c25dc12d5891b2e84597f81c

0.0.7

view details

Shihao Xia

commit sha d0139a68efbac873e7f17e27ca3b623b46b9bef8

= =

view details

push time in 25 days

issue commentgremo/nest-winston

Log file does not been created by using WinstonModule.createLogger

From looking at your code example, I think you need to add the transports key.


import { WinstonModule } from 'nest-winston';



async function bootstrap() {

  const app = await NestFactory.createApplicationContext(AppModule, {

    logger: WinstonModule.createLogger({

        transports: [

            new winston.transports.File({ filename: 'abc.log' })

        ],

    })

  });

}

bootstrap();

This should then create the files, however I'm still experiencing an issue where the files are not being populated with logs when exceptions are thrown.

Apologized for the inaccurate example. Now fixed. The problem is quite interesting. Without NestFactory.createApplicationContext, the log file and logging works properly. Once we use NestFactory.createApplicationContext, the log file doesn't get created (if you put directory with file name like abc/def.log, abc directory is created but def.log is not.)

charlesxsh

comment created time in a month

issue openedgremo/nest-winston

Log file does not been created by using WinstonModule.createLogger

import { WinstonModule } from 'nest-winston';

async function bootstrap() {
  const app = await NestFactory.create(AppModule, {
    logger: WinstonModule.createLogger({
          new winston.transports.File({ filename: 'abc.log' }),
    })
  });
  await app.listen(3000);
}
bootstrap();

abc.log does not get created

created time in a month

push eventcharlesxsh/moby

Shihao Xia

commit sha 6a72e73c1d9f991c2f3da5199b8ad221c3668515

fix potential goroutine leak by making channel non-blocking Signed-off-by: Shihao Xia <charlesxsh@hotmail.com>

view details

push time in a month

PullRequestReviewEvent

Pull request review commentkubernetes/kubernetes

test: fix potential blocking problems in unit tests

 udpIdleTimeout: 250ms`) 		errCh := make(chan error, 1) 		go func() { 			errCh <- opt.runLoop()+			select {

As mentioned in the description part 1, During the second testcase "fake error", channel opt.errCh will be sent a non-nil error (server.go:329) and a nil error (server.go:269). However, its receive will only be executed once because the loop will be broken after the first non-nil error, as shown below:

kubernetes/cmd/kube-proxy/app/server.go Lines 332 to 337 in 234d731 for { err := <-o.errCh if err != nil { return err } }

This fix adds a select that can receive the second error.

lzhfromustc

comment created time in a month

Pull request review commentkubernetes/kubernetes

test: fix potential blocking problems in unit tests

 func TestExtractFromNonExistentFile(t *testing.T) { }  func TestUpdateOnNonExistentFile(t *testing.T) {-	ch := make(chan interface{})+	ch := make(chan interface{}, 1)

I suppose the reason for making it unblocking is from consideration of unblocked sending. If select goes with timeout, it means no receiver for ch, then sending operation in NewSourceFile will be blocked if channel is unbuffered.

lzhfromustc

comment created time in a month

PullRequestReviewEvent

pull request commentmoby/moby

fixes a potential deadlock (container/state.go)

@cpuguy83 Hi there, I updated the commit message, please check and let me know if there anything I need to fix, thanks!

charlesxsh

comment created time in a month

push eventcharlesxsh/moby

Shihao Xia

commit sha f2de68a4f3df911dc1aec72194c6807cae571fe2

fix potential deadlock in container/state.go by buffered channel Signed-off-by: Shihao Xia <charlesxsh@hotmail.com>

view details

push time in a month

push eventtheogonic/zeus

Shihao Xia

commit sha 096b1696a1573a4ec175b45ea97df06b1a288893

update readme

view details

push time in a month

push eventtheogonic/zeus

Shihao Xia

commit sha 5b0edc46249df4748d774d1f30033c637a81109e

update readme

view details

push time in a month