profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/chali/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

push eventchali/gradle-lint-plugin

Martin Chalupa

commit sha 7d46b72fd0a8e3ce8712067fabd53e94866dd43c

Create explicit callback for end of build file instead of relying on visitClassNode visitClassNode can be called multiple times if there are classes in a build file and it causes duplications if violations are created there

view details

Martin Chalupa

commit sha e6f55f22b3c94e77e133fdc9e15768e3c60ecc03

Merge pull request #344 from chali/EndBuildFileCallback Create explicit callback for end of build file instead of relying on visitClassNode

view details

push time in 2 days

created tagnebula-plugins/gradle-lint-plugin

tagv17.1.0

A pluggable and configurable linter tool for identifying and reporting on patterns of misuse or deprecations in Gradle scripts.

created time in 3 days

release nebula-plugins/gradle-lint-plugin

v17.1.0

released time in 3 days

push eventnebula-plugins/gradle-lint-plugin

Martin Chalupa

commit sha 7d46b72fd0a8e3ce8712067fabd53e94866dd43c

Create explicit callback for end of build file instead of relying on visitClassNode visitClassNode can be called multiple times if there are classes in a build file and it causes duplications if violations are created there

view details

Martin Chalupa

commit sha e6f55f22b3c94e77e133fdc9e15768e3c60ecc03

Merge pull request #344 from chali/EndBuildFileCallback Create explicit callback for end of build file instead of relying on visitClassNode

view details

push time in 3 days

PR merged nebula-plugins/gradle-lint-plugin

Reviewers
Create explicit callback for end of build file instead of relying on visitClassNode

visitClassNode can be called multiple times if there are classes in a build file and it causes duplications if violations are created there

+38 -2

0 comment

2 changed files

chali

pr closed time in 3 days

create barnchchali/gradle-lint-plugin

branch : EndBuildFileCallback

created branch time in 3 days

created tagnebula-plugins/nebula-publishing-plugin

tagv17.3.3

Publishing related plugins

created time in 4 days

release nebula-plugins/nebula-publishing-plugin

v17.3.3

released time in 4 days

issue closednebula-plugins/gradle-lint-plugin

[16.2.1] Cannot suppress transitive-duplicate-dependency-class

plugins {
	id 'java'
	id 'nebula.lint' version '16.2.1'
}

repositories {
	mavenCentral()
}

gradleLint {
	criticalRules = ['transitive-duplicate-dependency-class']
}

dependencies {
	gradleLint.ignore('transitive-duplicate-dependency-class') {
		implementation 'nu.validator:validator:18.11.5'
	}
	runtimeOnly 'org.subethamail:subethasmtp:3.1.7'
}

Run gradle autoLintGradle on this. You'll get:

error     transitive-duplicate-dependency-classnu.validator:cssvalidator:1.0.4 in configuration ':runtimeOnly' has 2 classes duplicated by org.w3c.jigsaw:jigsaw:2.2.6 (use --info for detailed class list) (no auto-fix available)

Which doesn't make sense as that error is ignored for the nu.validator line.

Removing the runtimeOnly line or moving it inside the gradleLint.ignore block fixes the issue.

closed time in 8 days

boris-petrov

issue commentnebula-plugins/gradle-lint-plugin

[16.2.1] Cannot suppress transitive-duplicate-dependency-class

Yes, sadly this is not easily solvable :-( the nu.validator:cssvalidator:1.0.4 dependency is transitivie dependency of nu.validator:validator:18.11.5 but that ignore will only work if the declared dependency has duplicate classes. We don't have connection to original declared dependencies so we could check if they were wrapped in ignore. I found this a bit strange workaround:

plugins {
	id 'java'
	id 'nebula.lint' version '16.2.1'
}

repositories {
	mavenCentral()
}

gradleLint {
	criticalRules = ['transitive-duplicate-dependency-class']
}

configurations {
    ignoreCheck
}

dependencies {
	gradleLint.ignore('transitive-duplicate-dependency-class') {
             ignoreCheck 'nu.validator:cssvalidator:1.0.4'
	}
        mplementation 'nu.validator:validator:18.11.5'
	runtimeOnly 'org.subethamail:subethasmtp:3.1.7'
}

I declared the problematic dependency directly to a configuration that is not used at all but the fact that it is wrapped in ignore is configuring the rule to ignore this specific source of linting error.

Hopefully that at least help a bit.

boris-petrov

comment created time in 8 days

issue commentnebula-plugins/gradle-lint-plugin

[16.2.1] Cannot suppress transitive-duplicate-dependency-class

This is very likely a quirk of the way how we discover those dependencies. Most rules are walking AST for the build file and if we encounter an ignore block the walk is not continuing that branch. However, dependencies are discovered by resolving from the Project model. I'm worried that it might be too hard to track back that the dependency is actually wrapped in the ignore block. I will check it out.

boris-petrov

comment created time in 8 days

push eventchali/gradle-nebula-integration

Roberto Perez Alcolea

commit sha 1f2ee981a5cb85681d4443cb5021c3404c182ef7

Add module replacement with sources issue

view details

Aubrey Chipman

commit sha 6c6c6c51ca22bf394119b3cbc70507f59619d7c5

Investigate using replacements as a capability versus a replacement rule - with core locking

view details

Aubrey Chipman

commit sha 58b724eff626b48b656354ef6447cebaf215d1a0

Show issue with replacement rule causing a binary store exception Internally, we were seeing a lock-out-of-date exception using core Gradle locking, and then seeing a failure to create a build scan when the locks were removed due to an issue with the variant. For this reproducer, I had trouble creating those issues, but have found a related-looking binary store exception

view details

Aubrey Chipman

commit sha 6fb75baa8b919ddd486a3233e87ccfc176addb1b

Show issue with replacement rule causing InvalidUserCodeException

view details

Aubrey Chipman

commit sha 16430e0552bffeb5c4f096d7c8c3829c4a6e4cbe

Show issue with replacement rule causing dependency lock state out of date

view details

Aubrey Chipman

commit sha a7068a65d61fe9064df92b61d9cfdcd187611edb

Reset the state for this issue

view details

Aubrey Chipman

commit sha 927bcea317c04879c5fa7237a365812a782b9ed9

Add exploration for alignment with a substitution and a force

view details

Roberto Perez Alcolea

commit sha 6e595e7c7583fef25c75a5ae5483fb7f960a5381

fix master

view details

Roberto Perez Alcolea

commit sha c776763f57dd8d5c0a5f4d12c0185ce252c5357f

Merge branch 'master' of ssh://github.com/nebula-plugins/gradle-nebula-integration

view details

Roberto Perez Alcolea

commit sha 723ec8ad043884eae2e714d3dce6f9ff50b37b67

enable failing test for testng

view details

Roberto Perez Alcolea

commit sha a2950c001af725a4ea185b86dbbaf34795ee5407

add testng-junit-platform-grpc

view details

push time in 9 days

push eventchali/gradle-extra-configurations-plugin

Roberto Perez Alcolea

commit sha d4c5a8479cfbb20f503d1001aeb62f09e673d574

Consolidate GHA workflows into one

view details

Danny Thomas

commit sha fc0e0bd8438dd4383b173cbeb3feb5cded5e15c1

Update actions badge

view details

Roberto Perez Alcolea

commit sha 9aef7b6688dca7db05af8e3db7ff6904ff386908

Gradle 6.9

view details

Martin Chalupa

commit sha 0603edef001018d5acbfff6547ec965a02e5c2d7

Update nebula.plugin-plugin to 15.4.1

view details

push time in 9 days

push eventchali/gradle-resolution-rules

Martin Chalupa

commit sha 0a1adf7ee5dfed3cc93ea7e2365dca3948bf689f

Remove jackson from tests since it is now only runtime dependency

view details

push time in 9 days

push eventchali/nebula-dependency-base-plugin

Martin Chalupa

commit sha d78ca2d5728bf7e718d5f369f0781e348638e989

Explicitly set source and target version for bytecode

view details

Martin Chalupa

commit sha f8c3ad4bdd81ff557a51eac3b21da5a88a6514c6

add jdk 8 for all build to allow crosscompilation

view details

push time in 9 days

push eventchali/gradle-contacts-plugin

Roberto Perez Alcolea

commit sha a3a1220be04e2ac85819c87b668af6ea92f30d5f

Consolidate GHA workflows into one

view details

Danny Thomas

commit sha a56ae16e60231688635dd43baf5204aed3b59f71

Update actions badge

view details

Roberto Perez Alcolea

commit sha 64a94b51ee5b44c34729e0802c51227b62bc877e

Gradle 6.9

view details

Martin Chalupa

commit sha 9347924bbb569451d4b3cb395cf09ec373eb5e46

Update nebula.plugin-plugin to 15.4.1

view details

push time in 9 days

push eventchali/gradle-info-plugin

Roberto Perez Alcolea

commit sha 4722875737636cb28aa22653ea49d378b6fb8f70

Gradle 6.9

view details

Martin Chalupa

commit sha df91c52a6746414170e2955336efd82c5daadff2

Update nebula.plugin-plugin to 15.4.1

view details

push time in 9 days

push eventchali/gradle-netflixoss-project-plugin

Martin Chalupa

commit sha c844b6ebc537b36aa20acc067e2d5602f6ad26a1

Migrate to core locking

view details

Martin Chalupa

commit sha 2a6ee965e25edc79959f501af4a73c2847259d84

Merge pull request #64 from chali/MigrateToCoreLocks Migrate to core locking

view details

Roberto Perez Alcolea

commit sha 36667ec4ab5c670dcca80687e8efbc91d4e081d3

NetflixOssProjectPlugin: Disable publish marker to sonatype and netflixoss when gradle plugin publish plugin is present

view details

Roberto Perez Alcolea

commit sha fd6865d2780b1099f4b17be90080d42a27242a27

Consolidate GHA workflows into one

view details

Danny Thomas

commit sha 4939540cc66cd81dcb281cf5b0e435e3b7fec218

Update actions badge

view details

Roberto Perez Alcolea

commit sha 1d79cb97a64bbb9d455a4f4d9a17dac245d7e145

Upgrade nebula-oss-publishing-plugin

view details

Roberto Perez Alcolea

commit sha 9e1c0e122bbeda4e1bf9a9568ffda5c9ef126015

Gradle 7.0

view details

Roberto Perez Alcolea

commit sha 980557ce120e9a1831ec643bcf30c985dfe8c5fd

Update dependency locks

view details

Roberto Perez Alcolea

commit sha d88e17472027659307a385f5c18b47162ac2b7fe

Go back to gradle 6.8.3

view details

Roberto Perez Alcolea

commit sha 003558379f47f2eaf6a444295f9f891ffe7ecc42

disable gmm when using shadow plugin

view details

Roberto Perez Alcolea

commit sha ddbd7f52de70ff8d8f22f35370f5abe6d9f85e2a

Gradle 6.9

view details

Roberto Perez Alcolea

commit sha 08635ea0bd282971f943a8858f5da2d75ceb3a00

upgrade nebula-oss-publishing-plugin to 1.2.1

view details

Martin Chalupa

commit sha 45543ac5fe0bbf675e77d2998b41cc440d52dec6

Update nebula.plugin-plugin to 15.4.1

view details

push time in 9 days

push eventchali/nebula-clojure-plugin

Roberto Perez Alcolea

commit sha d23b613327af1b5cd34cf8b5d4dd9e77d468999a

Consolidate GHA workflows into one

view details

Danny Thomas

commit sha 497addc55ec802c8cdf4d9d2eeb010c15dc12749

Update actions badge

view details

Roberto Perez Alcolea

commit sha 2417ce2000acc4fa0da439571ee38f7d11f1bb8f

Gradle 6.9

view details

Martin Chalupa

commit sha 13a0cee7574348aef16c136952838a4d40b7c42a

Update nebula.plugin-plugin to 15.4.1

view details

Roberto Perez Alcolea

commit sha ca7ee49f8703e6bc52d2e09f14c3aca52dd7ebda

Add support for Toolchains

view details

Roberto Perez Alcolea

commit sha 36d84c712816f168a565b2f9f67d077834c093c7

Merge pull request #37 from nebula-plugins/support-java-toolchains Add support for Toolchains

view details

push time in 9 days

push eventchali/gradle-nothing-plugin

Roberto Perez Alcolea

commit sha 2dd4ca78556d82357638c875af9ba935eb4ce6d0

Consolidate github action in one

view details

Roberto Perez Alcolea

commit sha 59b1beb625d9e75bb23cb3c3bb06de92d3f2f960

fix plugin

view details

Roberto Perez Alcolea

commit sha e95b1381344795f508049690e8c042dfbe28ca6d

Fix workflow

view details

Roberto Perez Alcolea

commit sha 3c0253d1f8db05921d36417dd8572f69f19bcc47

consolidate workflows

view details

Danny Thomas

commit sha 176bc8d01a937da998ab2cb53a0cd7e8db8f1191

Update actions badge

view details

Roberto Perez Alcolea

commit sha a4ce27aa43f484d57d8ec43303e26aef8295de40

Gradle 6.9

view details

push time in 9 days

push eventchali/gradle-override-plugin

Roberto Perez Alcolea

commit sha 347af99d32acb75c19e4fa12333ad04cf9daf071

Consolidate GHA workflows into one

view details

Danny Thomas

commit sha 8feac6ff571d9b92d40ddbdc4b09da56a4fefac1

Update actions badge

view details

Roberto Perez Alcolea

commit sha be4eab26883afe98abc63b12b51d6b09258a64a8

Gradle 6.9

view details

push time in 9 days

push eventchali/gradle-stash-plugin

Roberto Perez Alcolea

commit sha 1b7f67d419b61cea305e88fdba7ada85bdd626a1

Consolidate GHA workflows into one

view details

Danny Thomas

commit sha 6db9860d0e95b6d379ae4883fe68424e7df8e929

Update actions badge

view details

Roberto Perez Alcolea

commit sha 3d6e9cb5a630511dc3a9d5bd2ccbef7ae86d93ea

Gradle 6.9

view details

Martin Chalupa

commit sha 0f75480dc67f239c8399d7e29a8b17cb1c311a11

Update nebula.plugin-plugin to 15.4.1

view details

push time in 9 days

push eventchali/gradle-java-cross-compile-plugin

Martin Chalupa

commit sha ca5182da84b8c79ca61c622648468164d0932842

Remove guava from tests, it is not provided by nebula-test anymore

view details

Martin Chalupa

commit sha 6571caf550035a10df9bfe97d85ea37929ef5c9e

fix cause access in test asserts

view details

Roberto Perez Alcolea

commit sha 6d945c5ea2d0d2f285375e1fd241e8add1082f96

JavaCrossCompilePlugin: avoid configuration if Java Toolchains are used

view details

Roberto Perez Alcolea

commit sha 61ed190ba7ad25d71420d880da51817c82b7b57d

Merge pull request #19 from nebula-plugins/toolchain-support JavaCrossCompilePlugin: avoid configuration if Java Toolchains are used

view details

push time in 9 days

push eventchali/nebula-gradle-interop

Martin Chalupa

commit sha a1bffdf18cdead438233861b7cdcf24c57c07c3c

add jdk 8 for all build to allow crosscompilation

view details

Martin Chalupa

commit sha e54f848d2eddb6c569de43fab58b98b709ec55b9

Remove guava from tests, it is not provided by nebula-test anymore

view details

push time in 9 days

push eventchali/nebula-project-plugin

Martin Chalupa

commit sha 2061844d006bcc180251ce9dbd4de54023551248

Update nebula.plugin-plugin to 15.4.1

view details

Roberto Perez Alcolea

commit sha a4753bbfad2dd497d15cf7ed35c149f3967de4fb

NebulaResponsiblePlugin: Add flag to disable nebula dependency lock plugin. Fixes #68

view details

Roberto Perez Alcolea

commit sha 18df84797a421b4c954d248a69437b5314120333

Merge pull request #69 from nebula-plugins/68/dependency-lock-plugin-can-be-disabled NebulaResponsiblePlugin: Add flag to disable nebula dependency lock plugin.

view details

Roberto Perez Alcolea

commit sha 6ab082b3ecb9d9bd9909be8ba172295d84aa9a4b

Add context on gradle dependency locking and how to disable Nebula plugin

view details

Roberto Perez Alcolea

commit sha 9b80e480b6c4b1862c3c8f5062d4b79a5b5473ae

Update README.md

view details

push time in 9 days

push eventchali/gradle-git-scm-plugin

Roberto Perez Alcolea

commit sha 6a64b61a5cf857198af7e48fffb36f4c93e08124

Consolidate GHA workflows into one

view details

Danny Thomas

commit sha 2d2081e2384f0b88dd0f3d112e4cea809d9b2446

Update actions badge

view details

Roberto Perez Alcolea

commit sha ed33e5325347c53b7bd97890185e2a87f07210a5

Gradle 6.9

view details

Martin Chalupa

commit sha 9d3d04bd7a42d3c6cc664c3c8801c709e3242365

Update nebula.plugin-plugin to 15.4.1

view details

push time in 9 days

push eventchali/nebula-kotlin-plugin

Martin Chalupa

commit sha 2597f414fbe8b87cea8de3fcec34a3c29d63c2ff

add jdk 8 for all build to allow crosscompilation

view details

push time in 9 days

push eventchali/nebula-grails-plugin

Danny Thomas

commit sha ca077f3a559940f565f36867b4a9f0a9ef1413f4

Update actions badge

view details

Roberto Perez Alcolea

commit sha 2e64ede502bd8c8fd09158af297bbd0977c346f6

Gradle 6.9

view details

Martin Chalupa

commit sha b2d3c348ed511e266a5d6d2c67c104ff856321b9

Update nebula.plugin-plugin to 15.4.1

view details

push time in 9 days

push eventchali/nebula-release-plugin

Martin Chalupa

commit sha eb64c4f87bd4c4c49aeb1c73bb54e423f3112b7a

Fix test name which would start failing with Spock 2.x

view details

Martin Chalupa

commit sha 0d5a1dc0886a6b0a62cf5eeb143b301b4183c84a

Merge pull request #210 from chali/FixTestName Fix test name which would start failing with Spock 2.x

view details

Roberto Perez Alcolea

commit sha a054820703cc88e564ad06fe082af158bfb8f2fd

Consolidate GHA workflows into one

view details

Danny Thomas

commit sha d7e6f0973a1d391f42ff063677567b69d8b674df

Update actions badge

view details

Roberto Perez Alcolea

commit sha d99eafb7aa794c73f88496146b84eb1bc1ab7c24

Gradle 6.9

view details

Martin Chalupa

commit sha 9bfce64f2ddab2e79b0c77179c8c542464313e57

Update nebula.plugin-plugin to 15.4.1

view details

push time in 9 days