profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/cbarber/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

cbarber/BigBrother 1

BigBrother plugin for Bukkit (TEMPORARY UNTIL TKELLY RETURNS)

cbarber/active_scaffold_list_filters_gem 0

Gem-ified version of a slightly modified active_scaffold_list_filters plugin

cbarber/autological 0

Notepad is a Jekyll theme which is very simple, clean and beautiful

cbarber/Bogart 0

It's like Sinatra... in C.

cbarber/BoringAuth 0

Straightforward password, passphrase, TOTP, and HOTP user authentication

cbarber/campfire 0

PvP protection plugin for Minecraft

cbarber/chosen 0

Chosen is a library for making long, unwieldy select boxes more friendly.

cbarber/Combat-Tag 0

Combat Tag with NPCs and Instakill

issue commentnextcloud/android

Pixel 3a camera uploads to /InstantUpload/Camera failing with "Permission Error"

@tobiasKaminsky is there specific info this issue needs that I can provide?

cbarber

comment created time in a month

issue commentnextcloud/android

Pixel 3a camera uploads to /InstantUpload/Camera failing with "Permission Error"

I'm still producing a similar issue after upgrading to: Nextcloud server version: 21.0.4 Nextcloud app version: 3.17.0

Apache logs are still showing a missing HTTP AUTH on the MOVE request:

10.2.1.18 - cbarber [22/Aug/2021:19:57:18 -0400] "HEAD /remote.php/webdav/InstantUpload/Camera/PXL_20210120_175417736.jpg HTTP/1.1" 404 - "-" "Mozilla/5.0 (Android) Nextcloud-android/3.17.0"
10.2.1.18 - cbarber [22/Aug/2021:19:57:18 -0400] "MKCOL /remote.php/dav/uploads/cbarber/1402b2e0a2c303fd5de786977da08980 HTTP/1.1" 201 - "-" "Mozilla/5.0 (Android) Nextcloud-android/3.17.0"
10.2.1.18 - cbarber [22/Aug/2021:19:57:19 -0400] "PROPFIND /remote.php/dav/uploads/cbarber/1402b2e0a2c303fd5de786977da08980 HTTP/1.1" 207 776 "-" "Mozilla/5.0 (Android) Nextcloud-android/3.17.0"
10.2.1.18 - cbarber [22/Aug/2021:19:57:19 -0400] "PUT /remote.php/dav/uploads/cbarber/1402b2e0a2c303fd5de786977da08980/0000000000000000-0000000003216889 HTTP/1.1" 201 - "-" "Mozilla/5.0 (Android) Nextcloud-android/3.17.0"
10.2.1.18 - - [22/Aug/2021:19:57:21 -0400] "MOVE /remote.php/dav/uploads/cbarber/1402b2e0a2c303fd5de786977da08980/.file HTTP/1.1" 403 199 "-" "Mozilla/5.0 (Android) Nextcloud-android/3.17.0"
10.2.1.18 - - [22/Aug/2021:19:57:21 -0400] "GET /index.php/204 HTTP/1.1" 204 - "-" "Mozilla/5.0 (Android) Nextcloud-android/3.17.0"
10.2.1.18 - cbarber [22/Aug/2021:19:57:21 -0400] "HEAD /remote.php/webdav/InstantUpload/Camera/PXL_20210525_233458961.jpg HTTP/1.1" 404 - "-" "Mozilla/5.0 (Android) Nextcloud-android/3.17.0"

All uploads fail on the app.

cbarber

comment created time in a month

push eventmojotech/helios2

tucker-weed

commit sha d4e9d769d5b694a4da75d2a66e43f19bea349cbd

[feat] add cypress

view details

tucker-weed

commit sha 523b16db248af82a0a2b928803475c038fc7c720

[docs] update README to include cypress instructions

view details

push time in a month

delete branch mojotech/helios2

delete branch : tw/cypress-testing

delete time in a month

PR merged mojotech/helios2

Reviewers
feat: add cypress (and pvd and bld smoke tests)

Description:

  1. Adds cypress dev dependency
  2. Adds smoke tests for pvd and bld pages
+640 -18

1 comment

9 changed files

tucker-weed

pr closed time in a month

push eventmojotech/helios2

Ben Bazyk

commit sha 6ca20e30c46a3d96a9569af62b0da18525d5c46c

chore: remove unnecessary column div, remove uneven text top-margins

view details

Ben Bazyk

commit sha b75559f6b84456e3bfe8e0d8425e2321b26239cc

feat: wrap temperature and sky icon on the same line

view details

Ben Bazyk

commit sha 11ac893c65f8272cb1bdf3ecc800666dac5faa4c

feat: adjust AM/PM and sky icon position AM/PM rests on a lower line than the time text due to font size differences, and the sky icon also sat lower than temperature because of font spacing

view details

cbarber

commit sha 1eb5e312c806e740273643c94e3208b3c4c8e7f3

Merge branch 'master' into tw/cypress-testing

view details

push time in a month

PullRequestReviewEvent

push eventmojotech/helios2

Ben Bazyk

commit sha 6ca20e30c46a3d96a9569af62b0da18525d5c46c

chore: remove unnecessary column div, remove uneven text top-margins

view details

Ben Bazyk

commit sha b75559f6b84456e3bfe8e0d8425e2321b26239cc

feat: wrap temperature and sky icon on the same line

view details

Ben Bazyk

commit sha 11ac893c65f8272cb1bdf3ecc800666dac5faa4c

feat: adjust AM/PM and sky icon position AM/PM rests on a lower line than the time text due to font size differences, and the sky icon also sat lower than temperature because of font spacing

view details

push time in a month

delete branch mojotech/helios2

delete branch : bb/weathercorner_css

delete time in a month

PR merged mojotech/helios2

Reviewers
Bb/weathercorner css

Fixed styling issue where weather corner's div was unintentionally taller than the time + AM/PM div.. This caused all widget's side panel elements (besides the weather widget who doesn't render weathercorner) to be shifted downwards by that height offset.

ticket id: 179167655 Description: "Weather corner's styling doesn't apply to the weather widget (which neglects displaying weather in the top corner). This results in the rest of the weather widget's sidepanel styling to be offset."

+12 -19

0 comment

2 changed files

bbazyk

pr closed time in a month

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentmojotech/helios2

refactor loading and error

The ability to remain ignorant of what's happening under the hood is a privilege! One that can only be earned through often painful experience with the conceptual model.

I agree that its a privilege, but feel its one we strive to provide for all of the engineers that will maintain our software. Its not something we gatekeep behind unraveling every technology we lean on to develop modern software. That's a journey we're all still taking.

Beginners, in my experience, are deeply curious about what's happening under the hood and rightly hesitant to lean on abstractions they don't really understand yet. I'd even go so far as to say that an instinct for when abstractions can be trusted is one of the main dividing lines between beginner and intermediate.

I don't think using abstraction and curiosity of how the abstractions work are mutually exclusive. I feel like the abstraction we depend on naturally lead to why questions. Those why questions are the rabbit hole we take to further our understanding.

We should take this meta conversation to the mentor group to further refine our abstraction demarcation point.

cbarber

comment created time in 2 months

pull request commentmojotech/helios2

refactor loading and error

I am not a fan of adding react-recompose as a dependency here, especially given that this codebase serves as a sandbox for the interns to learn in. I don't feel like it adds much, but it does a lot to obfuscate what the HOCs are doing and how they're being applied.

I agree that there isn't much pay off here for the simple loading/error HoCs. Our pay off is likely further along when we start refactoring lifecycle/state functionality.

I'm picking recompose over roll your own here since it provides conceptual building blocks that describe what is happening. We don't have the expectation that beginners will think too hard about JSX and what it is doing under the hood, just use it as a pattern to generate DOM. I think the compose into a sequence of HoCs reads as a description of behavior that you don't need to think too deeply about to start using.

The more of the codebase we're able to do without extra dependencies, the smaller the number of concepts and amount of documentation a reader will need to load into their brain to understand what they're looking at.

I can get behind the fewer deps and less to learn. I was surprised to see we have a 6MB package when I splitting webpacker/webpack.

I'm going to mark this as DoNotMerge for now until we have some time to mull this over.

cbarber

comment created time in 2 months

Pull request review commentmojotech/helios2

refactor loading and error

 Bathroom.propTypes = {   location: PropTypes.shape({     bathroomCode: PropTypes.string,   }),-  loading: PropTypes.bool,-  error: PropTypes.bool, };  Bathroom.defaultProps = {   location: {},-  loading: true,-  error: false, }; -export default withFragment(Bathroom, { location: getBathroomCode });+export default compose(+  renderWhileError(ErrorMessage),+  renderWhileLoading(LoadingMessage),+  withFragment({ location: getBathroomCode }),+)(Bathroom);

I disagree. It saves us from extra churn when want to inject/reorder HoCs e.g. if in your example we switch to loading preceding error I should rename three variables.

cbarber

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmojotech/helios2

refactor loading and error

 Bathroom.propTypes = {   location: PropTypes.shape({     bathroomCode: PropTypes.string,   }),-  loading: PropTypes.bool,-  error: PropTypes.bool, };  Bathroom.defaultProps = {   location: {},-  loading: true,-  error: false, }; -export default withFragment(Bathroom, { location: getBathroomCode });+export default compose(+  renderWhileError(ErrorMessage),+  renderWhileLoading(LoadingMessage),

That's a good point. My first grep of the usages of if (loading) / if (error) should some alternative code paths, but those ended up being FaCC's that would be better solved by bubbling up their graphql fragments. I think defaulting the component seems reasonable.

cbarber

comment created time in 2 months

Pull request review commentmojotech/helios2

refactor loading and error

 Bathroom.propTypes = {   location: PropTypes.shape({     bathroomCode: PropTypes.string,   }),-  loading: PropTypes.bool,-  error: PropTypes.bool, };  Bathroom.defaultProps = {   location: {},-  loading: true,-  error: false, }; -export default withFragment(Bathroom, { location: getBathroomCode });+export default compose(+  renderWhileError(ErrorMessage),

I agree with this sentiment but the goal here is a first pass refactor, not a change of existing functionality.

cbarber

comment created time in 2 months

PullRequestReviewEvent

push eventmojotech/helios2

Craig Barber

commit sha f708f4d04cbcb677be49e31aa228b8e7c2ded014

feat: add render-while-loading hoc

view details

Craig Barber

commit sha 4b70b7cefcb7a429f8eb2ae8ae4d47a3707a93e0

feat: add render-while-error hoc

view details

Craig Barber

commit sha fb31a8ab1c3520a4bac0a12a411ca8a0d36dcd46

refactor: withFragement should return a function that accepts a component This update withFragment to interopt with compose and react-recompose which expect all HoCs to accept a single argument that is the component.

view details

Craig Barber

commit sha ffdcdd2141e66d7e7340f3bf41e12f78487933aa

refactor: replace loading conditions with hoc

view details

Craig Barber

commit sha 3582f5066962f6a965e73abefc90162e36620b98

refactor: replace error conditions with hoc

view details

push time in 2 months

PullRequestReviewEvent

PR opened mojotech/helios2

refactor loading and error
+236 -77

0 comment

26 changed files

pr created time in 2 months

create barnchmojotech/helios2

branch : cmb/refactor-loading-and-error

created branch time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmojotech/helios2

feat: save employees to database

 def events(after: nil, type: nil)   end    def employee_events-    # dummy return value for now because cannot return null-    # will be filled in with database calls in a later PR+    Clients::BamboohrClient.find_employees.update_employees

Should we be saving employees to the database when we query for employee events in graphql? It seems like it will still have a long request time so we probably want to save them asynchronously via sidekiq.

fallynlogan

comment created time in 2 months