This will be made available in the Piral.Blazor repository. Will be tracked there.

New Feature Proposal

Update Piral.Blazor from .NET Core 3.2. to .net5

Description

Since November 2020 .net5 is released, so when someone uses Pilets with .net5 this won't work.

Background

We love the idea behind Piral and it fits exactly our needs, but the support for .net5 is essential. Maybe there is a way to simple change the used framework but we didn't find it.

Discussion

Is it possible to use blazor-pilets with different .net version? I don't think this would work or is there a way to isolate the different webassemblies?

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

• [x] I have read the CONTRIBUTING document
• [x] My code follows the code style of this project
• [x] All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

• [ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
• [x] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] I have updated the documentation accordingly
• [ ] I have added tests to cover my changes

Description

Replaced the custom webpack loader SheetLoader with a custom webpack plugin SheetPlugin. This plugin (formerly loader) allows linking of stylesheets by injecting a code to the output index.js. When using a loader, there is a chance ( through misconfigurations ) to create multiple links in the resulting index.js. By using a plugin, there is a guarantee that the link is generated only once.

Reference to gitter thread in Piral community: https://gitter.im/piral-io/community?at=607deb98c60826673bb41d15

Just pinging @kingb12 - can you confirm that the issue is fixed in the preview version? Thanks!

Fixed in commit e13cafe.

Should be ./SheetPlugin (case).

<br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><hr/>Isuru Jayasooriya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.<br/>_{You have signed the CLA already but the status is still pending? Let us recheck it.}

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

• [x] I have read the CONTRIBUTING document
• [x] My code follows the code style of this project
• [x] All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

• [ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
• [x] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] I have updated the documentation accordingly
• [ ] I have added tests to cover my changes

Description

Replaced the custom webpack loader SheetLoader with a custom webpack plugin SheetPlugin. This plugin (formerly loader) allows linking of stylesheets by injecting a code to the output index.js. When using a loader, there is a chance ( through misconfigurations ) to create multiple links in the resulting index.js. By using a plugin, there is a guarantee that the link is generated only once.

Reference to gitter thread in Piral community: https://gitter.im/piral-io/community?at=607deb98c60826673bb41d15

Bumps ssri from 6.0.1 to 6.0.2. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md">ssri's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/zkat/ssri/compare/v6.0.1...v6.0.2">6.0.2</a> (2021-04-07)</h2> <h3>Bug Fixes</h3> <ul> <li>backport regex change from 8.0.1 (<a href="https://github.com/zkat/ssri/commit/b30dfdb">b30dfdb</a>), closes <a href="https://github-redirect.dependabot.com/zkat/ssri/issues/19">#19</a></li> </ul> <p><!-- raw HTML omitted --><!-- raw HTML omitted --></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/ssri/commit/b7c8c7c61db89aeb9fbf7596c0ef17071bc216ef"><code>b7c8c7c</code></a> chore(release): 6.0.2</li> <li><a href="https://github.com/npm/ssri/commit/b30dfdb00bb94ddc49a25a85a18fb27afafdfbb1"><code>b30dfdb</code></a> fix: backport regex change from 8.0.1</li> <li>See full diff in <a href="https://github.com/npm/ssri/compare/v6.0.1...v6.0.2">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~nlf">nlf</a>, a new releaser for ssri since your current version.</p> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Bumps ssri from 6.0.1 to 6.0.2. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md">ssri's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/zkat/ssri/compare/v6.0.1...v6.0.2">6.0.2</a> (2021-04-07)</h2> <h3>Bug Fixes</h3> <ul> <li>backport regex change from 8.0.1 (<a href="https://github.com/zkat/ssri/commit/b30dfdb">b30dfdb</a>), closes <a href="https://github-redirect.dependabot.com/zkat/ssri/issues/19">#19</a></li> </ul> <p><!-- raw HTML omitted --><!-- raw HTML omitted --></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/ssri/commit/b7c8c7c61db89aeb9fbf7596c0ef17071bc216ef"><code>b7c8c7c</code></a> chore(release): 6.0.2</li> <li><a href="https://github.com/npm/ssri/commit/b30dfdb00bb94ddc49a25a85a18fb27afafdfbb1"><code>b30dfdb</code></a> fix: backport regex change from 8.0.1</li> <li>See full diff in <a href="https://github.com/npm/ssri/compare/v6.0.1...v6.0.2">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~nlf">nlf</a>, a new releaser for ssri since your current version.</p> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

https://github.com/smapiot/sample-cross-fx-pilets/tree/master/ng

After applying Angular 8.0.0 version, getting below exception ..

Unhandled Promise rejection: Can't resolve all parameters for ApplicationModule: (?). ; Zone: <root> ; Task: Promise.then ; Value: Error: Can't resolve all parameters for ApplicationModule: (?).

Thanks much FlorianRappl for your quick response. I have created pilet-angular-demo-1 project with your recommended version. but got above exception. https://github.com/satishjs2297/piral-demo-stuff/tree/master/pilet-angular-demo-1

Do you have any sample angular pilet let and app shell project which I can refer the dependency configuration. I am sure, it is because of dependency compatibility issue. Can you please help us with the right configuration

Bug Report

For more information, see the CONTRIBUTING guide.

Prerequisites

• [x] Can you reproduce the problem in a MWE?
• [x] Are you running the latest version?
• [x] Did you perform a search in the issues?

Environment Details and Version

Package Version:

"@angular/common": "^11.2.10",
"@angular/compiler": "^11.2.10",
"@angular/core": "^11.2.10",
"@angular/platform-browser": "^11.2.10",
"@angular/platform-browser-dynamic": "^11.2.10",
"piral": "^0.13.1",
"piral-ng": "^0.13.1",
"rxjs": "^6.6.7",
"zone.js": "^0.11.4"

OS: MAC & Windows Browser: Chrome, Safari

Description

Unhandled Promise rejection: Can't resolve all parameters for NgExtension: (?, [object Object]). ; Zone: <root> ; Task: Promise.then ; Value: Error: Can't resolve all parameters for NgExtension: (?, [object Object]).

Steps to Reproduce

Followed the steps documented here https://www.npmjs.com/package/piral-ng

Here is my github repo: https://github.com/satishjs2297/piral-demo-stuff

Expected behavior

[What you expected to happen]

Actual behavior

[What actually happened]

Possible Origin / Solution

[Optionally, share your idea to fix the issue]

Hardly a bug. I think you missed the dependencies part. Please have a look:

https://github.com/smapiot/piral/blob/develop/src/converters/piral-ng/package.json#L55

Angular 11 is not officially supported. If you want to have it supported any kind of contribution is welcome.

I close this one (as its not a bug); feel free to open another issue with Angular 11 support to track some work being done there. Currently, we have no plans of investing more in Angular. Thanks!

Bug Report

For more information, see the CONTRIBUTING guide.

Prerequisites

• [ ] Can you reproduce the problem in a MWE?
• [ ] Are you running the latest version?
• [ ] Did you perform a search in the issues?

Environment Details and Version

[Package Version, OS, Browser, ...]

Description

Unhandled Promise rejection: Can't resolve all parameters for NgExtension: (?, [object Object]). ; Zone: <root> ; Task: Promise.then ; Value: Error: Can't resolve all parameters for NgExtension: (?, [object Object]).

Steps to Reproduce

Followed the steps documented here https://www.npmjs.com/package/piral-ng

Expected behavior

[What you expected to happen]

Actual behavior

[What actually happened]

Possible Origin / Solution

[Optionally, share your idea to fix the issue]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

We set the content length to Infinity already:

https://github.com/smapiot/piral/blob/develop/src/tooling/piral-cli/src/common/http.ts#L89

I guess its worth also setting the maxBodyLength as you suggest.

I've pushed the change - should be out in a couple of minutes in the preview version @next.

Bug Report

For more information, see the CONTRIBUTING guide.

Prerequisites

• [x] Can you reproduce the problem in a MWE?
• [x] Are you running the latest version?
• [x] Did you perform a search in the issues?

Environment Details and Version

Running from a mac (though I believe this is also seen on our linux TeamCity hosts), using piral-cli version 0.12.4, I am able to upload a pilet over 10mb successfully. On 0.13.0 and 0.13.1, I receive this error:

Failure cases: piral-cli versions 0.13.0 and 0.13.1 Last success: version 0.12.4 Feed service: both our internal implementation and piral.cloud (https://feed.piral.cloud/api/v1/pilet/brendanking)

Description

Publishing with 0.13.x we see:

> yarn pilet publish --source $PILET_PATH --url $FEED_URL --api-key $API_KEY --log-level 4  --ca-cert ops/certs/cacert.pem                                                                                                   
yarn run v1.22.4
warning package.json: No license field
warning ../package.json: No license field
$ /Users/bking/workspace/my-pilet/node_modules/.bin/pilet publish --source my-pilet-1.0.3.tgz --url https://feed.piral.cloud/api/v1/pilet/brendanking --log-level 4 --ca-cert ops/certs/cacert.pem
[11:21:28 AM]: Reading configuration ...
[11:21:28 AM]: [0003] Checking if certificate exists.
[11:21:28 AM]: [0003] Reading certificate file "cacert.pem" from "ops/certs".
[11:21:28 AM]: [0003] Getting the tgz files ...
[11:21:28 AM]: [0003] Did not find fresh flag. Trying to match from "local".
[11:21:28 AM]: [0003] Matching files using "my-pilet-1.0.3.tgz".
[11:21:28 AM]: [0003] Received available tgz files.
[11:21:28 AM]: [0000] Using feed service "https://feed.piral.cloud/api/v1/pilet/brendanking".
[11:21:28 AM]: [0003] Reading the file for upload ...
[11:21:28 AM]: Publishing "/Users/bking/workspace/my-pilet/my-pilet-1.0.3.tgz" ... https://feed.piral.cloud/api/v1/pilet/brendanking
[11:21:28 AM]: 🚨  [0065] Failed to upload via HTTP: Request body larger than maxBodyLength limit.
[11:21:28 AM]: ⚠️  [0062] Could not upload "my-pilet-1.0.3.tgz" to feed service.
[11:21:28 AM]: [0003] Finished uploading the file.
[11:21:28 AM]: 🚨  [0064] Failed to upload some pilet(s)!
Codes Reference: https://docs.piral.io/code/search
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Where $PILET_PATH is a > 10mb tgz pilet, other args as normal.

This happens both pointing at our own feed service implementation internally, and using the one hosted on piral.cloud. I believe this is related to some interceptor prior to a request being made, as leaving off the api key argument still results in the same issue against piral.cloud (where using 0.12.4 shows the expected 401, adding the arg results in successful publish). Similarly, we don't see logs in our internal feed service or ingress that would correspond with a rejected request.

Steps to Reproduce

1. Create a pilet overr 10mb in tgz size
2. Publish it to some feed using piral-cli 0.13.0 or 0.13.1

Expected behavior

Successful publish

Actual behavior

[11:21:28 AM]: 🚨 [0065] Failed to upload via HTTP: Request body larger than maxBodyLength limit. (no apparent post request made)

Possible Origin / Solution

See above, possibly an axios default? (https://github.com/yakovkhalinsky/backblaze-b2/issues/45). Our observations indicate no request ever reaches a feed service implementation.

Thanks in advance team! Let me know if theres more information I can provide or anything I can do to help 🍻