profile
viewpoint

SteffenKrohn/Dozer 4

Web Technology Project, developing a game entirely in dart, without external libraries and frameworks. Control the Dozer with your device motion! 👋

bttger/contributing-gen 3

A configurable CONTRIBUTING.md generator - The guideline to communicate how people should contribute to your project.

bttger/web-framework-benchmarks 3

Benchmarking the overhead ⚙️ and latency ⏱️ of different popular web frameworks

bttger/contributing-gen-web 2

Web Frontend of contributing-gen - The guideline to communicate how people should contribute to your project.

bttger/spotirip 2

Spotify Ripper - records your streamed music, exports it to wav or mp3 and tags it automatically

bttger/Dozer-1 1

Web Technology Project, developing a game entirely in dart, without external libraries and frameworks. Control the Dozer with your device motion! 👋

bttger/simplest-react-navigation-global-state 1

Used for a tutorial, to show how simple react navigation and global state management can be.

bttger/modheader 0

ModHeader browser extension

bttger/nodebestpractices 0

:white_check_mark: The Node.js best practices list (August 2020)

starteddaviddao/awful-ai

started time in 17 days

startedk8spatterns/examples

started time in 21 days

issue commenttexstudio-org/texstudio

The ToolTip-preview disappears immediately

I have the same issue on two computers (both Windows 10) with TexStudio 2.12.16 and TeXstudio 3.0.1, Qt Version 5.12.1.

The only workaround I found so far is to disable the checkbox "Show preview as tooltip on formulas in editor" under the preview tab.

Dellu

comment created time in 25 days

startedloadimpact/k6

started time in a month

PR closed kubernetes/website

Reviewers
Update API group of resource type `events` cncf-cla: yes language/en needs-rebase sig/docs size/XS

events went from the events.k8s.io into the core API group. Came across this, because I wasn't able to kubectl get events with just the events.k8s.io in the role rules.

+1 -1

11 comments

1 changed file

bttger

pr closed time in a month

pull request commentkubernetes/website

Update API group of resource type `events`

@tengqm @liggitt Thank you. Closing this now.

bttger

comment created time in a month

pull request commentkubernetes/website

Update API group of resource type `events`

@bttger It smells like a bug when the RBAC role doesn't work. I'd suggest you file a bug in kubernetes/kubernetes and tag it '/sig auth'.

I have done.

bttger

comment created time in a month

issue openedkubernetes/kubernetes

No access to events if only the API group `events.k8s.io` is specified in a role

What happened: I created a role which should grant access to events. I have only specified the API group events.k8s.io because according to the resource types this is the right API group to get access to events. The role manifest looked as followed:

kind: Role
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: namespace-limited
  namespace: restricted-example
rules:
- apiGroups: ["events.k8s.io"]
  resources: ["events"]
  verbs: ["*"]

I then associated the Role with the default ServiceAccount of that namespace via RoleBinding. But unfortunately the kubectl get events command threw the following error:

Error from server (Forbidden): events is forbidden: User "system:serviceaccount:restricted-example:default" cannot list resource "events" in API group "" in the namespace "restricted-example"

What you expected to happen: To be able to access the events resource type.

How to reproduce it (as minimally and precisely as possible): Create a namespace, the previously defined role and a role binding, like in the following example:

kind: Namespace
apiVersion: v1
metadata:
  name: restricted-example
---
kind: Role
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: namespace-limited
  namespace: restricted-example
rules:
- apiGroups: ["events.k8s.io"]
  resources: ["events"]
  verbs: ["*"]
---
kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: namespace-limited
  namespace: restricted-example
roleRef:
  kind: Role
  name: namespace-limited
  apiGroup: rbac.authorization.k8s.io
subjects:
- kind: ServiceAccount
  name: default
  namespace: restricted-example

Then create a kubeconfig and run the kubectl get events command as the default ServiceAccount of the namespace restricted-example.

Anything else we need to know?: It's possible to access the events only if specifying the core API group, too (via "" indication). Or by running the kubectl get events.events.k8s.io command with the group specified.

Environment:

  • Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.6-beta.0", GitCommit:"e7f962ba86f4ce7033828210ca3556393c377bcc", GitTreeState:"clean", BuildDate:"2020-01-15T08:26:26Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.0-34+1a52fbf0753680", GitCommit:"1a52fbf07536803015220f0a991187db5b42c8ae", GitTreeState:"clean", BuildDate:"2020-09-02T11:33:05Z", GoVersion:"go1.15", Compiler:"gc", Platform:"linux/amd64"}

and

Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.0", GitCommit:"e19964183377d0ec2052d1f1fa930c4d7575bd50", GitTreeState:"clean", BuildDate:"2020-08-26T14:30:33Z", GoVersion:"go1.15", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.0-34+1a52fbf0753680", GitCommit:"1a52fbf07536803015220f0a991187db5b42c8ae", GitTreeState:"clean", BuildDate:"2020-09-02T11:33:05Z", GoVersion:"go1.15", Compiler:"gc", Platform:"linux/amd64"}
  • Cloud provider or hardware configuration: Single node cluster
  • OS (e.g: cat /etc/os-release): linux (amd64), Ubuntu 18.04.5 LTS
  • Kernel (e.g. uname -a): 4.15.0-117-generic
  • Install tools: MicroK8s
  • Network plugin and version (if this is a network-related bug):
  • Others:

created time in a month

pull request commentkubernetes/website

Update API group of resource type `events`

@tengqm But in the API Reference v1.19 the Event type (from the core group) is listed under the "Metadata APIs" section and the types from the event.k8s.io group are listed under the "Old API Versions" section.

It's correct that you can create an Event using events.k8s.io. But when I defined a role, which should permit to GET the events emitted by pods, I was not able to do that with the following rule:

- apiGroups: ["events.k8s.io"]
  resources: ["events"]
  verbs: ["get", "list", "watch"]

kubectl get events then throws the following error for example: Error from server (Forbidden): events is forbidden: User "system:serviceaccount:restricted-example:default" cannot list resource "events" in API group "" in the namespace "restricted-example"

bttger

comment created time in a month

PR opened kubernetes/website

Update API group of resource type `events`

events went from the events.k8s.io into the core API group. Came across this, because I wasn't able to kubectl get events with just the events.k8s.io in the role rules.

+1 -1

0 comment

1 changed file

pr created time in a month

push eventbttger/website

Tom Boettger

commit sha 7754fde569a7269eb3909c944248b36fac92324e

Update API group of resource type `events` `events` went from the events.k8s.io into the core API group. Came across this, because I wasn't able to `kubectl get events` with just the events.k8s.io in the role rules.

view details

push time in a month

PR opened bewisse/modheader

Fix confusing lock icon for the tab lock feature

Unfortunately the tab lock icon was confusing to me and my colleagues. I believe it should be closed when visualizing the locked-to-one-tab state.

+2 -2

0 comment

1 changed file

pr created time in a month

push eventbttger/modheader

Tom Boettger

commit sha a4945c4fc702b369ba7f629e678db508b614fac6

Fix confusing lock icon for the tab lock feature Signed-off-by: Tom Boettger <t.boettger@live.de>

view details

push time in a month

fork bttger/modheader

ModHeader browser extension

fork in a month

delete branch bttger/website

delete branch : patch-1

delete time in a month

pull request commentkubernetes/website

Fix false Object in persistentVolumeClaim explanation

/check-cla

bttger

comment created time in a month

push eventbttger/contributing-gen-web

dependabot[bot]

commit sha 4812457d04674ea3e02382241125787ae1559f4e

Bump node-fetch from 2.6.0 to 2.6.1 Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Tom Boettger

commit sha 1c2eca9cce20c4be79eee9c9471119d72acd9b99

Merge pull request #14 from bttger/dependabot/npm_and_yarn/node-fetch-2.6.1 Bump node-fetch from 2.6.0 to 2.6.1

view details

push time in a month

PR merged bttger/contributing-gen-web

Bump node-fetch from 2.6.0 to 2.6.1 dependencies

Bumps node-fetch from 2.6.0 to 2.6.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bitinn/node-fetch/releases">node-fetch's releases</a>.</em></p> <blockquote> <h2>v2.6.1</h2> <p><strong>This is an important security release. It is strongly recommended to update as soon as possible.</strong></p> <p>See <a href="https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md#v261">CHANGELOG</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md">node-fetch's changelog</a>.</em></p> <blockquote> <h2>v2.6.1</h2> <p><strong>This is an important security release. It is strongly recommended to update as soon as possible.</strong></p> <ul> <li>Fix: honor the <code>size</code> option after following a redirect.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/node-fetch/node-fetch/commit/b5e2e41b2b50bf2997720d6125accaf0dd68c0ab"><code>b5e2e41</code></a> update version number</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/2358a6c2563d1730a0cdaccc197c611949f6a334"><code>2358a6c</code></a> Honor the <code>size</code> option after following a redirect and revert data uri support</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/8c197f8982a238b3c345c64b17bfa92e16b4f7c4"><code>8c197f8</code></a> docs: Fix typos and grammatical errors in README.md (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/686">#686</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/1e99050f944ac435fce26a9549eadcc2419a968a"><code>1e99050</code></a> fix: Change error message thrown with redirect mode set to error (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/653">#653</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/244e6f63d42025465796e3ca4ce813bf2c31fc5b"><code>244e6f6</code></a> docs: Show backers in README</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/6a5d192034a0f438551dffb6d2d8df2c00921d16"><code>6a5d192</code></a> fix: Properly parse meta tag when parameters are reversed (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/682">#682</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/47a24a03eb49a49d81b768892aee10074ed54a91"><code>47a24a0</code></a> chore: Add opencollective badge</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/7b136627c537cb24430b0310638c9177a85acee1"><code>7b13662</code></a> chore: Add funding link</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/5535c2ed478d418969ecfd60c16453462de2a53f"><code>5535c2e</code></a> fix: Check for global.fetch before binding it (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/674">#674</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/1d5778ad0d910dbd1584fb407a186f5a0bc1ea22"><code>1d5778a</code></a> docs: Add Discord badge</li> <li>Additional commits viewable in <a href="https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~akepinski">akepinski</a>, a new releaser for node-fetch since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in a month

PullRequestReviewEvent

pull request commentkubernetes/website

Fix false Object in persistentVolumeClaim explanation

@bttger pls check the CLA issue.

@tengqm Can't do anything more now. I am sure the emails match on the CLA, github and the commit (both author and commiter).

bttger

comment created time in 2 months

pull request commentkubernetes/website

Fix false Object in persistentVolumeClaim explanation

/check-cla

bttger

comment created time in 2 months

push eventbttger/website

Tom Boettger

commit sha 00abf7a80f3a97f87254b60f2108f82e57094f4b

Fix false Object in persistentVolumeClaim explanation The persistentVolumeClaim explanation was contradictory. I've changed it, since PersistentVolumeClaims are an abstraction layer for PersistentVolumes, which in turn "capture[..] the details of the implementation of the storage".

view details

push time in 2 months

pull request commentkubernetes/website

Fix false Object in persistentVolumeClaim explanation

In my opinion we should not talk about PersistentVolumes when at the same time saying "without knowing the details of the particular cloud environment." That is contradictory to the PersistentVolume page](https://kubernetes.io/docs/concepts/storage/persistent-volumes/#introduction), where it says that PersistentVolumes "capture[..] the details of the implementation of the storage, be that NFS, iSCSI, or a cloud-provider-specific storage system." In this case only the PersistentVolumeClaim is a way of abstracting the details.

Update: Just saw that someone deleted his comment before I was able to send my explanation.

bttger

comment created time in 2 months

pull request commentkubernetes/website

Fix false Object in persistentVolumeClaim explanation

/check-cla

@Arhell The command should be /retest according to: https://github.com/oracle/kubernetes-test-infra/blob/master/commands.md

bttger

comment created time in 2 months

pull request commentkubernetes/website

Fix false Object in persistentVolumeClaim explanation

/retest

bttger

comment created time in 2 months

pull request commentkubernetes/website

Fix false Object in persistentVolumeClaim explanation

/check cla

@Arhell I think the pipeline just needs to run and check it again. Can you trigger it manually or do I need to trigger it via a new commit?

bttger

comment created time in 2 months

pull request commentkubernetes/website

Fix false Object in persistentVolumeClaim explanation

/assign @jimangel

bttger

comment created time in 2 months

pull request commentkubernetes/website

Fix false Object in persistentVolumeClaim explanation

Successfully signed the CLA. /assign @jimangel

bttger

comment created time in 2 months

PR opened kubernetes/website

Fix false Object in persistentVolumeClaim explanation

The persistentVolumeClaim explanation was contradictory. I've changed it, since PersistentVolumeClaims are an abstraction layer for PersistentVolumes, which "capture[..] the details of the implementation of the storage".

+1 -1

0 comment

1 changed file

pr created time in 2 months

push eventbttger/website

Tom Boettger

commit sha c43dfd747e026061b00afdb6578463116c85c722

Fix false Object in persistentVolumeClaim explanation PersistentVolumeClaims are an abstraction layer for PersistentVolumes, which "capture[..] the details of the implementation of the storage". So the explanation was contradictory.

view details

push time in 2 months

fork bttger/website

Kubernetes website and documentation repo:

https://kubernetes.io

fork in 2 months

push eventbttger/abgabenlast

dependabot[bot]

commit sha 2b94385822b49477f37bfdf19984b9e147442349

Bump bl from 4.0.2 to 4.0.3 Bumps [bl](https://github.com/rvagg/bl) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](https://github.com/rvagg/bl/compare/v4.0.2...v4.0.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

Tom Boettger

commit sha d5ffe603b034a39df3d5591c37a17e6e90937d1b

Merge pull request #1 from bttger/dependabot/npm_and_yarn/bl-4.0.3 Bump bl from 4.0.2 to 4.0.3

view details

push time in 2 months

PR merged bttger/abgabenlast

Bump bl from 4.0.2 to 4.0.3 dependencies

Bumps bl from 4.0.2 to 4.0.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rvagg/bl/releases">bl's releases</a>.</em></p> <blockquote> <h2>v4.0.3</h2> <p>Fix unintialized memory access</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rvagg/bl/commit/f659836cc84211cad41b73bad89c78f7f874c626"><code>f659836</code></a> Bumped v4.0.3</li> <li><a href="https://github.com/rvagg/bl/commit/7a4ae7f818a4ceba234f3d186a1ffb3f0a34ad0c"><code>7a4ae7f</code></a> Node v14</li> <li><a href="https://github.com/rvagg/bl/commit/d3e240e3b8ba4048d3c76ef5fb9dd1f8872d3190"><code>d3e240e</code></a> Fix unintialized memory access</li> <li><a href="https://github.com/rvagg/bl/commit/1c590ad49e10a158783ada7cc0662d9e0cc6cc11"><code>1c590ad</code></a> add license MIT tag to package.json (<a href="https://github-redirect.dependabot.com/rvagg/bl/issues/83">#83</a>)</li> <li>See full diff in <a href="https://github.com/rvagg/bl/compare/v4.0.2...v4.0.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

PullRequestReviewEvent

Pull request review commentgoldbergyoni/nodebestpractices

Use npm ci command in Docker builds

 All statements above will return false if used with `===`  <br/><br/> -## ![✔] 5.19. Install your packages with `npm ci`+## ![✔] 5.19. Install your packages with `npm ci`  -**TL;DR:** You have to be sure that production code uses the exact version of the packages you have tested it with. Run `npm ci` to do a clean install of your dependencies matching package.json and package-lock.json.+**TL;DR:** You have to be sure that production code uses the exact version of the packages you have tested it with. Run `npm ci` to do a clean install of your dependencies matching package.json and package-lock.json. Using this command is recommended in automated environments such as continuous integration pipelines. It is stricter by throwing an error if the versions in package.json and package-lock.json do not match. Since it can be significantly faster than `npm install`, it can also save you CI pipeline minutes. See [here](https://docs.npmjs.com/cli/ci.html#description) for more info.

Thanks, I deleted following part

It is stricter by throwing an error if the versions in package.json and package-lock.json do not match. Since it can be significantly faster than npm install, it can also save you CI pipeline minutes. See here for more info.

since these points are already stated in the "more info" page. I think the hint that the ci command should be used in automated environments should stay in the TL;DR.

bttger

comment created time in 2 months

PullRequestReviewEvent

push eventbttger/nodebestpractices

Tom Boettger

commit sha 1a666db2d267818af584244412d8c3220e3c44be

Shorten the TL;DR

view details

push time in 2 months

Pull request review commentgoldbergyoni/nodebestpractices

Use npm ci command in Docker builds

 All statements above will return false if used with `===`  <br/><br/> -## ![✔] 5.19. Install your packages with `npm ci`+## ![✔] 5.19. Install your packages with `npm ci`  -**TL;DR:** You have to be sure that production code uses the exact version of the packages you have tested it with. Run `npm ci` to do a clean install of your dependencies matching package.json and package-lock.json.+**TL;DR:** You have to be sure that production code uses the exact version of the packages you have tested it with. Run `npm ci` to do a clean install of your dependencies matching package.json and package-lock.json. Using this command is recommended in automated environments such as continuous integration pipelines. It is stricter by throwing an error if the versions in package.json and package-lock.json do not match. Since it can be significantly faster than `npm install`, it can also save you CI pipeline minutes. See [here](https://docs.npmjs.com/cli/ci.html#description) for more info.

Ah I found it, it was under the production directory. Going to shorten the TL;DR and put it into the "more info" page.

bttger

comment created time in 2 months

PullRequestReviewEvent

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha 192cd471891d852ab1e8201d488b65be0c8d9247

Fix empty error message if required value is missing

view details

push time in 2 months

Pull request review commentgoldbergyoni/nodebestpractices

Use npm ci command in Docker builds

 All statements above will return false if used with `===`  <br/><br/> -## ![✔] 5.19. Install your packages with `npm ci`+## ![✔] 5.19. Install your packages with `npm ci`  -**TL;DR:** You have to be sure that production code uses the exact version of the packages you have tested it with. Run `npm ci` to do a clean install of your dependencies matching package.json and package-lock.json.+**TL;DR:** You have to be sure that production code uses the exact version of the packages you have tested it with. Run `npm ci` to do a clean install of your dependencies matching package.json and package-lock.json. Using this command is recommended in automated environments such as continuous integration pipelines. It is stricter by throwing an error if the versions in package.json and package-lock.json do not match. Since it can be significantly faster than `npm install`, it can also save you CI pipeline minutes. See [here](https://docs.npmjs.com/cli/ci.html#description) for more info.

I haven't found this file. Do you mean docker/install-for-production.md? This section already mentions the npm cicommand and also quotes the npm docs at the bottom.

bttger

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentgoldbergyoni/nodebestpractices

Use npm ci command in Docker builds

 Bear in mind that with the introduction of the new V8 engine alongside the new E  ## ![✔] 8.1 Use multi-stage builds for leaner and more secure Docker images -**TL;DR:** Use multi-stage build to copy only necessary production artifacts. A lot of build-time dependencies and files are not needed for running your application. With multi-stage builds these resources can be used during build while the runtime environment contains only what's necessary. Multi-stage builds are an easy way to get rid of overweight and security threats+**TL;DR:** Use multi-stage build to copy only necessary production artifacts. A lot of build-time dependencies and files are not needed for running your application. With multi-stage builds these resources can be used during build while the runtime environment contains only what's necessary. Multi-stage builds are an easy way to get rid of overweight and security threats. Since Docker is often used in continuous integration environments it is recommended to use the `npm ci` command (instead of `npm install`). It is faster, stricter and reduces inconsistencies by using only the versions specified in the package-lock.json file. See [here](https://docs.npmjs.com/cli/ci.html#description) for more info.

I agree, have put it to the docker/multi_stage_builds.md file and updated the code examples

bttger

comment created time in 2 months

PullRequestReviewEvent

push eventbttger/nodebestpractices

Tom Boettger

commit sha 74f47c8d66d2985c70d6cc107cbd8a01035c36fa

Update the multi_stage_builds section with npm ci

view details

push time in 2 months

PR opened goldbergyoni/nodebestpractices

Use npm ci command in Docker builds

Also added the hint in chapter 5.19 to use the npm ci command in automated environments.

Maybe this should also be updated in the in detail section Multi Stage Builds with Docker, but this example uses yarn, which would be yarn install --frozen-lockfile then. Ideally with a short explanation that both commands can be fine, depending which package manager you use.

+5 -5

0 comment

1 changed file

pr created time in 2 months

push eventbttger/nodebestpractices

Tom Boettger

commit sha 441519a1b79a89e207e8e2fc56274a7c1df39bc4

Add hint to use npm ci in automated environments npm ci command should be used within automated environments such as continuous integration pipelines https://docs.npmjs.com/cli/ci.html#description

view details

push time in 2 months

push eventbttger/nodebestpractices

Tom Boettger

commit sha 642dc29ac86697950f4854eb0cc3156701ab1fde

Use npm ci command in Docker builds

view details

push time in 2 months

fork bttger/nodebestpractices

:white_check_mark: The Node.js best practices list (August 2020)

https://twitter.com/nodepractices/

fork in 2 months

startedhoanhan101/ultimate-go

started time in 2 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha 6689523a343270520a2195609a73dab86ccf0a04

Add go/gin implementation

view details

Tom Boettger

commit sha 63e5e1b1f825ac0be235c9b627e6dbf1cab542d7

Refactor the main func Outsource handlers and use main func as controller with focus on the routes

view details

push time in 2 months

push eventbttger/web-framework-benchmarks

dependabot[bot]

commit sha d6655f41fb2f4e4933fda585da9f28a4102a1c0f

Bump prismjs from 1.20.0 to 1.21.0 Bumps [prismjs](https://github.com/PrismJS/prism) from 1.20.0 to 1.21.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](https://github.com/PrismJS/prism/compare/v1.20.0...v1.21.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

Tom Boettger

commit sha 4efd47d396cf3b85fe93896ec36bd8f98b3e8785

Merge pull request #1 from bttger/dependabot/npm_and_yarn/prismjs-1.21.0 Bump prismjs from 1.20.0 to 1.21.0

view details

push time in 3 months

PR merged bttger/web-framework-benchmarks

Bump prismjs from 1.20.0 to 1.21.0 dependencies

Bumps prismjs from 1.20.0 to 1.21.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/PrismJS/prism/releases">prismjs's releases</a>.</em></p> <blockquote> <h2>v1.21.0</h2> <p>Release 1.21.0</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/PrismJS/prism/blob/master/CHANGELOG.md">prismjs's changelog</a>.</em></p> <blockquote> <h2>1.21.0 (2020-08-06)</h2> <h3>New components</h3> <ul> <li><strong>.ignore</strong> & <strong>.gitignore</strong> & <strong>.hgignore</strong> & <strong>.npmignore</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2481">#2481</a>) <a href="https://github.com/PrismJS/prism/commit/3fcce6fe"><code>3fcce6fe</code></a></li> <li><strong>Agda</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2430">#2430</a>) <a href="https://github.com/PrismJS/prism/commit/3a127c7d"><code>3a127c7d</code></a></li> <li><strong>AL</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2300">#2300</a>) <a href="https://github.com/PrismJS/prism/commit/de21eb64"><code>de21eb64</code></a></li> <li><strong>Cypher</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2459">#2459</a>) <a href="https://github.com/PrismJS/prism/commit/398e2943"><code>398e2943</code></a></li> <li><strong>Dhall</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2473">#2473</a>) <a href="https://github.com/PrismJS/prism/commit/649e51e5"><code>649e51e5</code></a></li> <li><strong>EditorConfig</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2471">#2471</a>) <a href="https://github.com/PrismJS/prism/commit/ed8fff91"><code>ed8fff91</code></a></li> <li><strong>HLSL</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2318">#2318</a>) <a href="https://github.com/PrismJS/prism/commit/87a5c7ae"><code>87a5c7ae</code></a></li> <li><strong>JS stack trace</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2418">#2418</a>) <a href="https://github.com/PrismJS/prism/commit/ae0327b3"><code>ae0327b3</code></a></li> <li><strong>PeopleCode</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2302">#2302</a>) <a href="https://github.com/PrismJS/prism/commit/bd4d8165"><code>bd4d8165</code></a></li> <li><strong>PureBasic</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2369">#2369</a>) <a href="https://github.com/PrismJS/prism/commit/d0c1c70d"><code>d0c1c70d</code></a></li> <li><strong>Racket</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2315">#2315</a>) <a href="https://github.com/PrismJS/prism/commit/053016ef"><code>053016ef</code></a></li> <li><strong>Smali</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2419">#2419</a>) <a href="https://github.com/PrismJS/prism/commit/22eb5cad"><code>22eb5cad</code></a></li> <li><strong>Structured Text (IEC 61131-3)</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2311">#2311</a>) <a href="https://github.com/PrismJS/prism/commit/8704cdfb"><code>8704cdfb</code></a></li> <li><strong>UnrealScript</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2305">#2305</a>) <a href="https://github.com/PrismJS/prism/commit/1093ceb3"><code>1093ceb3</code></a></li> <li><strong>WarpScript</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2307">#2307</a>) <a href="https://github.com/PrismJS/prism/commit/cde5b0fa"><code>cde5b0fa</code></a></li> <li><strong>XML doc (.net)</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2340">#2340</a>) <a href="https://github.com/PrismJS/prism/commit/caec5e30"><code>caec5e30</code></a></li> <li><strong>YANG</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2467">#2467</a>) <a href="https://github.com/PrismJS/prism/commit/ed1df1e1"><code>ed1df1e1</code></a></li> </ul> <h3>Updated components</h3> <ul> <li>Markup & JSON: Added new aliases (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2390">#2390</a>) <a href="https://github.com/PrismJS/prism/commit/9782cfe6"><code>9782cfe6</code></a></li> <li>Fixed several cases of exponential backtracking (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2268">#2268</a>) <a href="https://github.com/PrismJS/prism/commit/7a554b5f"><code>7a554b5f</code></a></li> <li><strong>APL</strong> <ul> <li>Added <code>⍥</code> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2409">#2409</a>) <a href="https://github.com/PrismJS/prism/commit/0255cb6a"><code>0255cb6a</code></a></li> </ul> </li> <li><strong>AutoHotkey</strong> <ul> <li>Added missing <code>format</code> built-in (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2450">#2450</a>) <a href="https://github.com/PrismJS/prism/commit/7c66cfc4"><code>7c66cfc4</code></a></li> <li>Improved comments and other improvements (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2412">#2412</a>) <a href="https://github.com/PrismJS/prism/commit/ddf3cc62"><code>ddf3cc62</code></a></li> <li>Added missing definitions (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2400">#2400</a>) <a href="https://github.com/PrismJS/prism/commit/4fe03676"><code>4fe03676</code></a></li> </ul> </li> <li><strong>Bash</strong> <ul> <li>Added <code>composer</code> command (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2298">#2298</a>) <a href="https://github.com/PrismJS/prism/commit/044dd271"><code>044dd271</code></a></li> </ul> </li> <li><strong>Batch</strong> <ul> <li>Fix escaped double quote (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2485">#2485</a>) <a href="https://github.com/PrismJS/prism/commit/f0f8210c"><code>f0f8210c</code></a></li> </ul> </li> <li><strong>C</strong> <ul> <li>Improved macros and expressions (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2440">#2440</a>) <a href="https://github.com/PrismJS/prism/commit/8a72fa6f"><code>8a72fa6f</code></a></li> <li>Improved macros (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2320">#2320</a>) <a href="https://github.com/PrismJS/prism/commit/fdcf7ed2"><code>fdcf7ed2</code></a></li> </ul> </li> <li><strong>C#</strong> <ul> <li>Improved pattern matching (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2411">#2411</a>) <a href="https://github.com/PrismJS/prism/commit/7f341fc1"><code>7f341fc1</code></a></li> <li>Fixed adjacent string interpolations (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2402">#2402</a>) <a href="https://github.com/PrismJS/prism/commit/2a2e79ed"><code>2a2e79ed</code></a></li> </ul> </li> <li><strong>C++</strong> <ul> <li>Added support for default comparison operator (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2426">#2426</a>) <a href="https://github.com/PrismJS/prism/commit/8e9d161c"><code>8e9d161c</code></a></li> <li>Improved class name detection (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2348">#2348</a>) <a href="https://github.com/PrismJS/prism/commit/e3fe9040"><code>e3fe9040</code></a></li> <li>Fixed <code>enum class</code> class names (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2342">#2342</a>) <a href="https://github.com/PrismJS/prism/commit/30b4e254"><code>30b4e254</code></a></li> </ul> </li> <li><strong>Content-Security-Policy</strong> <ul> <li>Fixed directives (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2461">#2461</a>) <a href="https://github.com/PrismJS/prism/commit/537a9e80"><code>537a9e80</code></a></li> </ul> </li> <li><strong>CSS</strong> <ul> <li>Improved url and added keywords (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2432">#2432</a>) <a href="https://github.com/PrismJS/prism/commit/964de5a1"><code>964de5a1</code></a></li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/PrismJS/prism/commit/187c8a607ee70c7914682870156faa31ed01f001"><code>187c8a6</code></a> 1.21.0</li> <li><a href="https://github.com/PrismJS/prism/commit/bf4f323391d546d4b2e1a388f05c512a27491e9c"><code>bf4f323</code></a> Changelog for v1.21.0 (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2507">#2507</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/8bba4880202ef6bd7a1e379fe9aebe69dd75f7be"><code>8bba488</code></a> Previewers: Fixed XSS (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2506">#2506</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/158caf52343e59a66c2351ff1d83648efe871e33"><code>158caf5</code></a> JSON: Greedy comments (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2479">#2479</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/f0f8210c1a9745c064d49bfb985544c654986b24"><code>f0f8210</code></a> Batch: Fix escaped double quote (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2485">#2485</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/649e51e56250a81dc0b0c4f5b3a4ea23e1c21834"><code>649e51e</code></a> Added support for Dhall (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2473">#2473</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/453079bf96746e0c44f90cb7cd90fcae9a5f94cc"><code>453079b</code></a> Line Numbers: Fixed class name on website</li> <li><a href="https://github.com/PrismJS/prism/commit/a0efa40bde420ac3923947be611ebe6b3f077dce"><code>a0efa40</code></a> Fixed Treeview page (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2484">#2484</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/78161d607fe7d493831ff19759aac951330134a1"><code>78161d6</code></a> VB: Added VBA alias (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2469">#2469</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/ed1df1e1208401a8b84330ecc39689fa37d0e9f6"><code>ed1df1e</code></a> Added support for YANG (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2467">#2467</a>)</li> <li>Additional commits viewable in <a href="https://github.com/PrismJS/prism/compare/v1.20.0...v1.21.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha 898af630a051d03c1d7ce0a7b1e3d4d268ee8a32

Add links to the proposed frameworks

view details

push time in 3 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha 0a80058e406d82b9aa98bf9e4568d9e161ed6ddb

Add java/vertx implementation

view details

push time in 3 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha 8a081dfa758997459eb67d47ecb305f3a4b4ba5c

Add java/spring implementation

view details

push time in 3 months

push eventbttger/abgabenlast

Tom Boettger

commit sha 352a975a0b1b8b9a547834c3247f0fecf39e1fa2

Update README.md

view details

push time in 3 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha 85213704b30de61e138167d673631057cf2c9d29

Fix "405 Method not allowed"

view details

Tom Boettger

commit sha 68925843800091e854a387d4bbe600495fb3ae2b

Add postman collection to readme

view details

push time in 3 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha 8d9d06859c4331fd851ec32f7b26c1b7a269151a

Add python/fastapi implementation

view details

push time in 3 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha a1f904f9e1419235fa174a4aed17ce80eccdc3a6

Indicate json mime type for body content

view details

Tom Boettger

commit sha 9c7e5998ade10c4d8c6810242fd898b9524a725f

Add python/flask implementation

view details

push time in 3 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha ec1ec059b778498159fa9a8f098ecfec2006d300

Add computationally intense endpoint to benchmark

view details

Tom Boettger

commit sha 86b27586c76b4571ad08ddd34dede1b90d046744

Implement the added endpoint (/calculate)

view details

Tom Boettger

commit sha c255eca17fa2c7b179c6c7105b7c2b0f575cec38

Add express-cluster implementation

view details

push time in 3 months

startedtorus-online/torus

started time in 3 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha cf426811f153aaf63440e21aa3256166f5da4097

Improve flow Dont call the send method again (even if it has no effect on the user)

view details

Tom Boettger

commit sha 1473411c47b57521b33e8387f49490fa85a2a319

Add nodejs/express implementation

view details

push time in 3 months

push eventSteffenKrohn/Dozer

Tom Boettger

commit sha e7b3ce74e643185efb65b5f9f4e14315bdc52143

Fix the iOS 13+ device orientation permission

view details

Tom Boettger

commit sha a615c31226ddd1c661c5d8111feaf785677ea58d

Fix the iOS 13+ device orientation permission

view details

Tom Boettger

commit sha 7fd75dac920db1d445f9b520661a66055afa6304

Fix the iOS 13+ device orientation permission

view details

Tom Boettger

commit sha 1911447372c4e4d8c1582398822af2fac27f30f9

Fix the iOS 13+ device orientation permission

view details

Tom Boettger

commit sha 141dddecc02c6186abdf722aaff8b32fb6b50305

Fix the iOS 13+ device orientation permission

view details

Tom Boettger

commit sha 31739e80f4735f45aad852cbb11af9f01ddbda7c

Fix the iOS 13+ device orientation permission

view details

Tom Boettger

commit sha 9b11f76bd6dec402fe0efbd192f709d413d2f453

Merge pull request #6 from bttger/master Fix the iOS 13+ device orientation permission

view details

push time in 3 months

PR merged SteffenKrohn/Dozer

Fix the iOS 13+ device orientation permission
+43 -25

0 comment

2 changed files

bttger

pr closed time in 3 months

PR opened SteffenKrohn/Dozer

Fix the iOS 13+ device orientation permission
+43 -25

0 comment

2 changed files

pr created time in 3 months

push eventbttger/Dozer-1

Tom Boettger

commit sha 31739e80f4735f45aad852cbb11af9f01ddbda7c

Fix the iOS 13+ device orientation permission

view details

push time in 3 months

push eventbttger/Dozer-1

Tom Boettger

commit sha 141dddecc02c6186abdf722aaff8b32fb6b50305

Fix the iOS 13+ device orientation permission

view details

push time in 3 months

push eventbttger/Dozer-1

Tom Boettger

commit sha 1911447372c4e4d8c1582398822af2fac27f30f9

Fix the iOS 13+ device orientation permission

view details

push time in 3 months

push eventbttger/Dozer-1

Tom Boettger

commit sha 7fd75dac920db1d445f9b520661a66055afa6304

Fix the iOS 13+ device orientation permission

view details

push time in 3 months

push eventbttger/Dozer-1

Tom Boettger

commit sha a615c31226ddd1c661c5d8111feaf785677ea58d

Fix the iOS 13+ device orientation permission

view details

push time in 3 months

push eventbttger/Dozer-1

Tom Boettger

commit sha e7b3ce74e643185efb65b5f9f4e14315bdc52143

Fix the iOS 13+ device orientation permission

view details

push time in 3 months

push eventSteffenKrohn/Dozer

Tom Boettger

commit sha a9fbbf23b10f54989f61067205f7374f0ddb36a0

Add MIT license

view details

push time in 3 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha 6611d9c4584896cb935e82e370ae3314cc90dd52

Set example for text plain response

view details

Tom Boettger

commit sha 87802f6fd00c8af7ad47d492602d92540a629787

Update the readme, bolden important parts

view details

Tom Boettger

commit sha fc14d8e88e95ec237e80ba6657e9ece23673b2a9

Use strict mode

view details

Tom Boettger

commit sha 910fbf07089fef500d60f8539c244c0f5d1895f4

Implement benchmark script

view details

push time in 3 months

PublicEvent

startedbttger/web-framework-benchmarks

started time in 3 months

push eventbttger/web-framework-benchmarks

Tom Boettger

commit sha 00f0dd96aa81308c68193b2f27abbe5a97980904

Update readme

view details

push time in 3 months

more