profile
viewpoint
Brian Clifton bsclifton @brave Chandler, AZ USA https://clifton.io VP of Engineering @brave. Previously @godaddy & @intel. I love Mexican food and writing code in C++ and JavaScript.

brave/browser-laptop 8020

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave

brave-intl/bat-ledger 50

A BAT-based micropayments system for users and publishers

bsclifton/Clifton.Payment 20

Code relating to payment processing or point of sale

brave-experiments/brave-extension-store 8

Brave Extension Store

brave-intl/bat-client 7

An example of client code for the BAT.

bsclifton/BrowserWindowStyles 4

Demo project- experiment with Win32 window styles

bsclifton/home-router-config 4

Configuration used for my home router

brave/electron-installer-debian 3

Create a Debian package for your Electron app.

bsclifton/dotfiles 3

My dotfiles (bash, vim, etc)

Pull request review commentbrave/brave-core

[iOS] Add support for passing additional command line args at launch

  NS_ASSUME_NONNULL_BEGIN +typedef NSString* BraveCoreSwitch NS_STRING_ENUM;+/// Overrides the component updater source. Defaults to the CI provided value+///+/// Expected value: url-source={url}+OBJC_EXPORT const BraveCoreSwitch BraveCoreSwitchComponentUpdater;+/// Overrides Chromium VLOG verbosity. Defaults to only printing from folders+/// existing within a `brave` subfolder up to level 5.+///+/// Expected value: {folder-expression}={level}+OBJC_EXPORT const BraveCoreSwitch BraveCoreSwitchVModule;+/// Overrides the sync service base URL. Defaults to the CI provided value+///+/// Expected value: A URL string+OBJC_EXPORT const BraveCoreSwitch BraveCoreSwitchSyncURL;+/// Overrides the SKUs environment. Defaults to production (when not provided)+///+/// Expected value: `production`, `development`, or `staging`+OBJC_EXPORT const BraveCoreSwitch BraveCoreSwitchSkusEnvironment;

chef-kiss

kylehickinson

comment created time in 13 hours

PullRequestReviewEvent

push eventbrave/brave-core

Pete Miller

commit sha 0aeaac87f6b03b05dcdcc4b1cbf9dafa09c1ca49

API Request Helper can limit its body reponse size

view details

Pete Miller

commit sha 491cdaece4bbebd67eaf39cde12c5369091f463d

Introduce RSS / Atom feed support for Brave News This first version provides the user a feature to add custom feed urls to their preferences via the NTP "customize" button. Once added, feed content will be downloaded on the same schedule as the current "combined sources" single remote feed. The "direct feed" items will be scored using approximately the same algorithm as the existing items, and displayed using the existing Brave News feed view. This PR does not introduce the relevant UI for Android, only Desktop.

view details

Pete Miller

commit sha 750c3beebc152a4592b4b947707562ac8fdd361e

Brave News: validate RSS feed URLs in both frontend and backend before we download

view details

Brian Clifton

commit sha 4a465719d8cf2c892ad252d8f252047d550f8941

Merge pull request #11391 from brave/news-rss Brave News user-provided feed support (rss, atom, etc)

view details

push time in 17 hours

delete branch brave/brave-core

delete branch : news-rss

delete time in 17 hours

issue closedbrave/brave-browser

Add custom RSS to Brave News

Description

I love Brave Today, but I have a problem. Some news sites that I usually read aren't available in brave today sites, so I like to put them via their RSS feed.

Brave version (brave://version info)

brave://version brave://version
Version Brave: 1.20.17 nightly (64 bits) (Build official) Chromium: 87.0.4280.88
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Arch Linux
Execution flags /opt/brave.com/brave-nightly/brave --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=AutoupgradeMixedContent,WebUIDarkMode,DnsOverHttps,LegacyTLSEnforced,PasswordImport,ReducedReferrerGranularity,PrefetchPrivacyChanges --disable-features=AutofillEnableAccountWalletStorage,AutofillServerCommunication,TextFragmentAnchor,NetworkTimeServiceQuerying,PasswordCheck,IdleDetection,SignedExchangeSubresourcePrefetch,SafeBrowsingEnhancedProtection,PrivacySettingsRedesign,AllowPopupsDuringPageUnload,VideoPlaybackQuality,NotificationTriggers,SmsReceiver,TabHoverCards --flag-switches-begin --flag-switches-end
Binary path /opt/brave.com/brave-nightly/brave
Profile path /home/guillem/.config/BraveSoftware/Brave-Browser-Nightly/Default
Installation font Arch User Repository (AUR)

closed time in 17 hours

Alonely0

PR merged brave/brave-core

Reviewers
Brave News user-provided feed support (rss, atom, etc) CI/run-audit-deps CI/storybook-url

For now this is based on the VPN SKUs PR to gain its rust support. Do not merge before https://github.com/brave/brave-core/pull/10847

This first version provides the user a feature to add custom feed urls to their preferences via the NTP "customize" button. Once added, feed content will be downloaded on the same schedule as the current "combined sources" single remote feed. The "direct feed" items will be scored using approximately the same algorithm as the existing items, and displayed using the existing Brave News feed view.

This PR does not introduce the relevant UI for Android, only Desktop.

Resolves https://github.com/brave/brave-browser/issues/13095

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed, or that I have [requested] (https://github.com/brave/security/issues/new/choose) one https://github.com/brave/security/issues/697
  • [x] There is a ticket for my issue
  • [x] Used Github auto-closing keywords in the PR description above
  • [x] Wrote a good PR/commit description
  • [x] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [ ] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [ ] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

  • Adding a new feed via customize panel should immediately add to the list.
  • The feed title should be displayed in the customize panel list
  • Adding an incorrect feed url should present an error message
  • Content from the new feed should be displayed in the feed list on next refresh (either clicking the blue "update content" button that should appear if the new feed had content, or after browser restart (or 3 hours!)).
  • Removing a feed removes it from the feed list and removes its content
    • via customize panel
    • via clicking the publisher name on a content card by that publisher

Needs some unit tests for the feed parsing. I'll add this either here or in f/u depending on timing.

+2395 -232

7 comments

55 changed files

petemill

pr closed time in 17 hours

Pull request review commentbrave/brave-core

Brave News user-provided feed support (rss, atom, etc)

 include_rules = [+  "+net",   "+services/network/public",+  "+services/network/public/mojom",

DEPS changes LGTM! 👍

petemill

comment created time in 17 hours

PullRequestReviewEvent

delete branch brave/brave-core

delete branch : bsc-skus-sdk-keyed-backup

delete time in 20 hours

PullRequestReviewEvent
PullRequestReviewEvent

push eventbrave/brave-core

Simon Hong

commit sha 6c2304b688af51333de3caddf09e31404592fe12

Added feature flags for choosing skus environment When one of option is selected except default, it's value is passed via --skus-env command line switch. fix https://github.com/brave/brave-browser/issues/20557

view details

Brian Clifton

commit sha be57e528abbe165f23ef25d4eafd0d70c298e646

Merge pull request #11894 from brave/skus_env_feature_flags Added feature flags for choosing skus environment

view details

push time in 3 days

delete branch brave/brave-core

delete branch : skus_env_feature_flags

delete time in 3 days

PR merged brave/brave-core

Added feature flags for choosing skus environment

When one of option is selected except default, it's value is passed via --skus-env command line switch.

fix https://github.com/brave/brave-browser/issues/20557

Screen Shot 2022-01-19 at 4 51 40 PM

<!-- Add brave-browser issue bellow that this PR will resolve --> Resolves

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed, or that I have requested one
  • [x] There is a ticket for my issue
  • [x] Used Github auto-closing keywords in the PR description above
  • [x] Wrote a good PR/commit description
  • [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • [x] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [ ] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [x] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

  1. Launch Brave with fresh profile and check --skus-env cmd line switch is not used at brave://versions
  2. Choose production for Experimental SKU Environment via brave://flags and relaunch
  3. Check --skus-env=production switch is set at brave://versions
+30 -6

0 comment

2 changed files

simonhong

pr closed time in 3 days

issue closedbrave/brave-browser

SKUs environment should be configurable via brave://flags

Description

We already have brave://flags entries for both VPN and SKU (dependent on each other for Desktop) image

  • brave://flags/#brave-vpn
  • brave://flags/#skus-sdk

But at the moment, environment is defaulting to production for an official build (otherwise, it uses development).

There is a command line flag --skus-env which accepts the following values:

  • production
  • staging
  • development

It would be great to expose this in brave://flags. If Default, we can default to production. But if overridden, it can use the chosen environment.

closed time in 3 days

bsclifton
PullRequestReviewEvent

issue openedbrave/brave-browser

SKUs environment should be configurable via brave://flags

Description

We already have brave://flags entries for both VPN and SKU (dependent on each other for Desktop) image

  • brave://flags/#brave-vpn
  • brave://flags/#skus-sdk

But at the moment, environment is defaulting to production for an official build (otherwise, it uses development).

There is a command line flag --skus-env which accepts the following values:

  • production
  • staging
  • development

It would be great to expose this in brave://flags. If Default, we can default to production. But if overridden, it can use the chosen environment.

created time in 3 days

issue closedbrave/brave-browser

Lint errors after merging SKUS pull request

Description

Caused by https://github.com/brave/brave-core/pull/10847

There are some references used in the interop between C++ and Rust which our linter (npm run lint) is saying we should either make const or use a pointer.

The lint errors

08:40:36  components/skus/browser/rs/cxx/src/shim.h:97:  Is this a non-const reference? If so, make const or use a pointer: skus::SkusContext& ctx  [runtime/references] [2]
08:40:36  components/skus/browser/rs/cxx/src/shim.h:98:  Is this a non-const reference? If so, make const or use a pointer: skus::SkusContext& ctx  [runtime/references] [2]
08:40:36  components/skus/browser/rs/cxx/src/shim.h:101:  Is this a non-const reference? If so, make const or use a pointer: skus::SkusContext& ctx  [runtime/references] [2]
08:40:36  components/skus/browser/skus_context_impl.cc:76:  Is this a non-const reference? If so, make const or use a pointer: skus::SkusContext& ctx  [runtime/references] [2]
08:40:36  components/skus/browser/skus_context_impl.cc:80:  Is this a non-const reference? If so, make const or use a pointer: skus::SkusContext& ctx  [runtime/references] [2]
08:40:36  components/skus/browser/skus_context_impl.cc:87:  Is this a non-const reference? If so, make const or use a pointer: skus::SkusContext& ctx  [runtime/references] [2]

closed time in 4 days

bsclifton

push eventbrave/brave-core

Brian Clifton

commit sha 213bea2a4f96268d04437ac092355c9573cc8140

Add NOLINT for known issue added w/ SKUs Fixes https://github.com/brave/brave-browser/issues/20542

view details

Brian Clifton

commit sha 1daf93143a04d525f6cba9dddef314ff5296530c

Merge pull request #11878 from brave/bsc-fix-lint Add NOLINT for known issue added w/ SKUs

view details

push time in 4 days

delete branch brave/brave-core

delete branch : bsc-fix-lint

delete time in 4 days

PR merged brave/brave-core

Reviewers
Add NOLINT for known issue added w/ SKUs CI/skip-android CI/skip-linux CI/skip-macos CI/skip-windows CI/skip-ios

Fixes https://github.com/brave/brave-browser/issues/20542

Reported internally here: https://bravesoftware.slack.com/archives/C7VLGSR55/p1642435151118600?thread_ts=1642204016.099600&cid=C7VLGSR55

I thought linting only would give errors if you made changes to that file? But @Brandon-T was seeing it

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed, or that I have requested one
  • [x] There is a ticket for my issue
  • [x] Used GitHub auto-closing keywords in the PR description above
  • [x] Wrote a good PR/commit description
  • [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • [x] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [x] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [x] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

+8 -6

2 comments

2 changed files

bsclifton

pr closed time in 4 days

delete branch bsclifton/poker.js

delete branch : dependabot/npm_and_yarn/path-parse-1.0.7

delete time in 4 days

PR merged bsclifton/poker.js

Bump path-parse from 1.0.6 to 1.0.7 dependencies

Bumps path-parse from 1.0.6 to 1.0.7. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/jbgutierrez/path-parse/commits/v1.0.7">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 4 days

push eventbsclifton/poker.js

dependabot[bot]

commit sha ad933c1479a33ca34366976e418b23f742f96f2c

Bump path-parse from 1.0.6 to 1.0.7 Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Brian Clifton

commit sha 20a07a572a9031d4db6e81ae7564dd676969f247

Merge pull request #15 from bsclifton/dependabot/npm_and_yarn/path-parse-1.0.7 Bump path-parse from 1.0.6 to 1.0.7

view details

push time in 4 days

PullRequestReviewEvent

delete branch bsclifton/poker.js

delete branch : dependabot/npm_and_yarn/follow-redirects-1.14.7

delete time in 4 days

push eventbsclifton/poker.js

dependabot[bot]

commit sha 02eb7a8c272067682b0d6396570a1dc8573eb960

Bump follow-redirects from 1.14.1 to 1.14.7 Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Brian Clifton

commit sha db14eb44e3dcc72269cb243c5b19745bbaf06306

Merge pull request #14 from bsclifton/dependabot/npm_and_yarn/follow-redirects-1.14.7 Bump follow-redirects from 1.14.1 to 1.14.7

view details

push time in 4 days

PR merged bsclifton/poker.js

Bump follow-redirects from 1.14.1 to 1.14.7 dependencies

Bumps follow-redirects from 1.14.1 to 1.14.7. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/2ede36d7c60d3acdcd324dcd99a9dbd52e4fb3a6"><code>2ede36d</code></a> Release version 1.14.7 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/8b347cbcef7c7b72a6e9be20f5710c17d6163c22"><code>8b347cb</code></a> Drop Cookie header across domains.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/6f5029ae1a0fdab4dc25f6379a5ee303c2319070"><code>6f5029a</code></a> Release version 1.14.6 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/af706bee57de954414c0bde0a9f33e62beea3e52"><code>af706be</code></a> Ignore null headers.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/d01ab7a5c5df3617c7a40a03de7af6427fdfac55"><code>d01ab7a</code></a> Release version 1.14.5 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/40052ea8aa13559becee5795715c1d45b1f0eb76"><code>40052ea</code></a> Make compatible with Node 17.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/86f7572f9365dadc39f85916259b58973819617f"><code>86f7572</code></a> Fix: clear internal timer on request abort to avoid leakage</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/2e1eaf0218c5315a2ab27f53964d0535d4dafb51"><code>2e1eaf0</code></a> Keep Authorization header on subdomain redirects.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/2ad9e82b6277ae2104f7770e9ff1186cc6da29d4"><code>2ad9e82</code></a> Carry over Host header on relative redirects (<a href="https://github-redirect.dependabot.com/follow-redirects/follow-redirects/issues/172">#172</a>)</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/77e2a581e1d1811674b7b74745a9c20a5b939488"><code>77e2a58</code></a> Release version 1.14.4 of the npm package.</li> <li>Additional commits viewable in <a href="https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.7">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 4 days

PullRequestReviewEvent

push eventbsclifton/poker.js

dependabot[bot]

commit sha 4fabcbebfdc88c01d4804e60364fea206a106c42

Bump url-parse from 1.5.1 to 1.5.3 Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.3. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.3) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Brian Clifton

commit sha 250810d6aa1f818141b0e5f4221a746084198c88

Merge pull request #13 from bsclifton/dependabot/npm_and_yarn/url-parse-1.5.3 Bump url-parse from 1.5.1 to 1.5.3

view details

push time in 4 days

more