profile
viewpoint
Bruno Bord brunobord PeopleDoc (a.k.a. Novapost) Bayonne, France http://jehaisleprintemps.net

brunobord/cmdbot 15

CmdBot, a bot with `cmd` attitude

brunobord/critica 6

Django-powered CMS

brunobord/django-mini-issue-tracker 6

Django Mini Issue Tracker

brunobord/axe-not-axe 4

A RPG where Dwarves use their Axe to fight and everything else is Not Axe

brunobord/beeroverip 4

Beer Over IP - Mirror of the launchpad project

brunobord/conconf 4

Réservoir d'idées pour des Conférences à la Con™

brunobord/bayonne 3

Guide personnel et donc partial (partiel) de Bayonne, ma ville de coeur

brunobord/django-barcamp 3

A simple Django Barcamp application.

benoitbryon/formation-informatique 2

Projet de formation informatique à destination des établissements d'enseignement supérieur.

brunobord/colorize 2

Simply colorize python output

pull request commentpeopledoc/workalendar

new feature: method to export any Calendar to .ical

I'll definitely need your help with adding the dependency to the icalendar module to the project. I have no idea how to do that.

the requirements are simply listed in this list: https://github.com/peopledoc/workalendar/blob/master/setup.py#L21-L30 Adding a dependency is as simple as adding it to this list.

This will be slow though, as I can't dedicate much time to this project.

Yeah, a bit of the same here: summertime is not the best time of the year to work on a side project, with vacations, and all... but don't despair, this contribution won't be forgotten.

The way export_to_ical is written like now, it doesn't just take a path but also other file-like objects

mmmm... not really. it takes a string as a path that you may open for write.

see: https://github.com/peopledoc/workalendar/pull/527/files#diff-c8773c3a29eba8fa93fa4b7a0197b878R848-R852 (and to be honest, I don't see the point of providing a mechanism to add the extension if required, if I want to create a /tmp/foobar.txt file, I couldn't, because you would transform it into a /tmp/foobar.txt.ics file).

I think all I have to do is re-write the tests so they call the method with a file-like object that doesn't write to disc

Possibly, yes. But my point was to separate the content generation from the file generation. I think it's easier to separate internal computations from the Input/Output. Maybe it's just me, but I'm used to the fact that a program can write an export to the standard output and then as an option, being able to write to disk. This is more flexible if you want to grep your content or manipulate though a pipeline. And the output of your function could be manipulated without having to extract it from a file-like object, simply as a string. But yes, it's probably a matter of taste.

We'll see where this is going (slowly, but I have hope)

joooeey

comment created time in 19 days

issue commentpeopledoc/workalendar

Make GPL dependencies optional

I must say that I don't know right now what's best for the project.

It's been some time now since I spotted that calendars that required astronomical computation were infrequent ; and for various reasons, they're localized in certain parts of the world (Asia - incl. Middle-East & Africa).

From a technical point of view, it may appear useless to download and install several packages you'll never use, just because, for example, you only need Switzerland or Australia classes. In some use-cases, the library was "too big" because it implements "too many" calendars (but to be honest, I don't know what could be "the good size", after all, workalendar aims to be as global as possible) and/or would require several (too many, again?) libraries to be installed.

I was tempted to split the project in several sub-projects (one per continent?), but in the end, it'd invalidate one of the feature that was hardly implemented: the ISO registry.

And this feature might be one of the reason why I didn't try to implement what you've kindly suggested: optional requirements + "on-demand" imports ; because I didn't know if it was compatible with the ISO registry integration.

I've discussed with one of my collegue, who suggested to use a sort of "abstraction layer", that would act as a proxy to dynamically load the astronomical functions. Those functions would contain the imports to the optional libraries, and would fail gracefully if the requirements aren't installed and would return the expected results if they're available in your environment.

So that looks doable, so I won't advise you against it. But we'll need to keep this in mind:

1 - the ISO registry shouldn't fail to load all available calendars.

2 - there must be a transitionning mechanism to go from the "all inclusive" to the "opt-in" calendaring.

I was thinking about:

  1. implement of the "proxy functions", able to work if the requirements are installed and fail if not + raise a Deprecation Warning to warn integrators about the change in the requirements
  2. then make a major release that would "unplug" the "all inclusive" setup.

Now, onto the "longer term"...

You may try to work out, or find someone able to implement lunardate and pyCalverter equivalent libraries for Python3, that wouldn't require gcc or any sort of compilation with the same level of confidence. I certainly don't have the skills, so I don't know if it's easy or even doable.

Of course I can't have your complete context (and I am not a Lawyer), but as far as I can say, as long as the said libraries are used (that is to say dynamically linked and not integrated into the project), you're not bound to the so-called "virality" of the GPL.

You are free to use the software for whatever reason you need, without having to license your code under a Free license. The "virality" is only implied when you're redistributing (un)modified versions of this piece of software. Since it's only installed at runtime and you don't modify them, I don't see anything to fear yet. And that's for example the reason why workalendar can be licensed as MIT, and not bound to be GPL'ed.

This would be a totally different matter if they were using AGPLv3 licenses.

But again, I don't want to judge you, your whole context is beyond my knowledge, but at least I tried to make my point about the "non-GPL" policy.

scompt

comment created time in 19 days

issue openedpeopledoc/workalendar

Doubt on Rosh Hashana Eve in Israel calendar

As you can see on today's code, Rosh Hashana Eve is a holiday in Israel calendar: https://github.com/peopledoc/workalendar/blob/11bd8b0e446f84d0549c6b842cb3ef2d216b3ec0/workalendar/asia/israel.py

        holidays_hebrew_dates = [
            (HebrewDate(jewish_year, 6, 29), "Rosh Hashana Eve"),
            (HebrewDate(jewish_year + 1, 7, 1), "Rosh Hashana"),
            (HebrewDate(jewish_year + 1, 7, 2), "Rosh Hashana"),
            (HebrewDate(jewish_year + 1, 7, 9), "Yom Kippur Eve"),
    # ....
        ]

But after reading Wikipedia's article, I'm not sure... https://en.wikipedia.org/wiki/Public_holidays_in_Israel

It says there that it's only the 2 Rosh Hashana days that are non-working days, but not the day before.

I'm paging @elaav, @armona and @orzarchi, who have worked on this calendar, to investigate if this is a bug or not, and if needed, how to fix it.

created time in 20 days

issue openedsirredbeard/nim_lang_snap

Can't import any stdlib

result of snap --version:

 snap --version
snap    2.45.2
snapd   2.45.2
series  16
ubuntu  18.04
kernel  4.15.0-111-generic

Installed the classic nim snap using:

snap install --classic nim-lang

I've then tried to compile the following example:

import strformat

let msg = "hello"
doAssert &"{msg}\n" == "hello\\n"

It failed to compile:

nim c people.nim 
Hint: system [Processing]
Hint: widestrs [Processing]
Hint: io [Processing]
Hint: people [Processing]
/home/user/Nim/example.nim(1, 8) Error: cannot open file: strformat

I've also tried other examples, using different imports, and they've all failed at the import line(s).

Do you have any clue on why this is failing and how to fix this?

created time in 23 days

issue commentpeopledoc/workalendar

Brazil not computing right

Were you able to take some time to investigate on this?

z226

comment created time in a month

delete branch peopledoc/workalendar

delete branch : 529-immaculate-conception

delete time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha d8a2bf015570647fa79e3f6120133a9254c51183

Use `include_immaculate_conception` flag for Portugal, Brazil, Argentina & Paraguay calendars refs #529

view details

Bruno Bord

commit sha 11bd8b0e446f84d0549c6b842cb3ef2d216b3ec0

Merge pull request #535 from peopledoc/529-immaculate-conception Use `include_immaculate_conception` flag for Portugal, Brazil, Argentina & Paraguay calendars

view details

push time in a month

PR merged peopledoc/workalendar

Use `include_immaculate_conception` flag for Portugal, Brazil, Argentina & Paraguay calendars

closes #529

  • [x] Tests with a significant number of years to be tested for your calendar.
  • [x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.
+67 -29

0 comment

8 changed files

brunobord

pr closed time in a month

issue closedpeopledoc/workalendar

Portugal, Brazil, Argentina, Paraguay: Immaculate conception

Immaculate conception is added via the FIXED_HOLIDAYS constant. Should be handled via the include_immaculate_conception flag & label change.

closed time in a month

brunobord

PR opened peopledoc/workalendar

Use `include_immaculate_conception` flag for Portugal, Brazil, Argentina & Paraguay calendars

closes #529

  • [x] Tests with a significant number of years to be tested for your calendar.
  • [x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.
+67 -29

0 comment

8 changed files

pr created time in a month

create barnchpeopledoc/workalendar

branch : 529-immaculate-conception

created branch time in a month

delete branch peopledoc/workalendar

delete branch : 533-assert-equal-without-s

delete time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha 4756165679a8b12b5b557749549df39065fae26d

Replace occurrences of `assertEquals` with `assertEqual` to clear warnings refs #533

view details

Bruno Bord

commit sha 9b644814bb430510e291985c26ee24d9f05d7b1a

Merge pull request #534 from peopledoc/533-assert-equal-without-s Replace occurrences of `assertEquals` with `assertEqual` to clear warnings

view details

push time in a month

PR merged peopledoc/workalendar

Replace occurrences of `assertEquals` with `assertEqual` to clear warnings

closes #533

  • [x] No regression in tests
  • [x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.
+57 -56

0 comment

5 changed files

brunobord

pr closed time in a month

issue closedpeopledoc/workalendar

Remove assertEquals occurrences

assertEquals is deprecated in favor of assertEqual.

A small technical change, but would avoid ugly warnings when running pytest

closed time in a month

brunobord

PR opened peopledoc/workalendar

Replace occurrences of `assertEquals` with `assertEqual` to clear warnings

closes #533

  • [x] No regression in tests
  • [x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.
+57 -56

0 comment

5 changed files

pr created time in a month

create barnchpeopledoc/workalendar

branch : 533-assert-equal-without-s

created branch time in a month

issue openedpeopledoc/workalendar

Remove assertEquals occurrences

assertEquals is deprecated in favor of assertEqual.

A small technical change, but would avoid ugly warnings when running pytest

created time in a month

delete branch peopledoc/workalendar

delete branch : 467-worldwide-labour-day

delete time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha 7e9c79c79743f3a71d4c5bf5efaa24ff41952582

Migrating Labour Day as a worldwide holiday * Labour Day is handled at the higher level (`core.Calendar`). * Generalized this flag + optional label to 50 countries: Algeria, Angola, Argentina, Austria, Barbados, Belarus, Belgium, Benin, Brazil, Bulgaria, Chile, Colombia, Croatia, Cyprus, Czech Republic, European Central Bank, Finland, France, Germany, Greece, Hong-Kong, Hungary, Iceland, Italy, Ivory Coast, Kenya, Latvia, Lithuania, Luxembourg, Madagascar, Malaysia, Malta, Mexico, Norway, Panama, Paraguay, Poland, Portugal, Romania, Russia, Sao Tome & Principe, Serbia, Singapore, Slovakia, Slovenia, Spain (incl. Catalonia), Sweden, Switzerland, Turkey, Ukraine. * Contributing documentation amended refs #467

view details

Bruno Bord

commit sha abee8bb9b4006b0a1da59ec7450399f751470985

Merge pull request #532 from peopledoc/467-worldwide-labour-day Migrating Labour Day as a worldwide holiday

view details

push time in a month

PR merged peopledoc/workalendar

Migrating Labour Day as a worldwide holiday
  • Labour Day is handled at the higher level (core.Calendar).
  • Generalized this flag + optional label to 50 countries: Algeria, Angola, Argentina, Austria, Barbados, Belarus, Belgium, Benin, Brazil, Bulgaria, Chile, Colombia, Croatia, Cyprus, Czech Republic, European Central Bank, Finland, France, Germany, Greece, Hong-Kong, Hungary, Iceland, Italy, Ivory Coast, Kenya, Latvia, Lithuania, Luxembourg, Madagascar, Malaysia, Malta, Mexico, Norway, Panama, Paraguay, Poland, Portugal, Romania, Russia, Sao Tome & Principe, Serbia, Singapore, Slovakia, Slovenia, Spain (incl. Catalonia), Sweden, Switzerland, Turkey, Ukraine.
  • Contributing documentation amended

closes #467

  • [x] Tests with a significant number of years to be tested for your calendar.
  • [x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.
+259 -64

0 comment

58 changed files

brunobord

pr closed time in a month

issue closedpeopledoc/workalendar

Quick fix: Labour day / International Labour Day should be in core

This international holiday appears in a lot of calendars as fixed holiday. When its date is set to May 1st, it should eventually be activated by a flag and has its standard label (that could be overridden sometimes).

  • [x] Add it to core.Calendar with a deactivated flag,
  • [x] Activate it for the countries + add the label test if needed
  • [x] Edit the contributing.md documentation to explain this flag behaviour

Checksum: generate the "all holidays" for all tested calendars on master and compare with the WIP branch.

closed time in a month

brunobord

PR opened peopledoc/workalendar

Migrating Labour Day as a worldwide holiday
  • Labour Day is handled at the higher level (core.Calendar).
  • Generalized this flag + optional label to 50 countries: Algeria, Angola, Argentina, Austria, Barbados, Belarus, Belgium, Benin, Brazil, Bulgaria, Chile, Colombia, Croatia, Cyprus, Czech Republic, European Central Bank, Finland, France, Germany, Greece, Hong-Kong, Hungary, Iceland, Italy, Ivory Coast, Kenya, Latvia, Lithuania, Luxembourg, Madagascar, Malaysia, Malta, Mexico, Norway, Panama, Paraguay, Poland, Portugal, Romania, Russia, Sao Tome & Principe, Serbia, Singapore, Slovakia, Slovenia, Spain (incl. Catalonia), Sweden, Switzerland, Turkey, Ukraine.
  • Contributing documentation amended

closes #467

  • [x] Tests with a significant number of years to be tested for your calendar.
  • [x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.
+259 -64

0 comment

58 changed files

pr created time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha 7e9c79c79743f3a71d4c5bf5efaa24ff41952582

Migrating Labour Day as a worldwide holiday * Labour Day is handled at the higher level (`core.Calendar`). * Generalized this flag + optional label to 50 countries: Algeria, Angola, Argentina, Austria, Barbados, Belarus, Belgium, Benin, Brazil, Bulgaria, Chile, Colombia, Croatia, Cyprus, Czech Republic, European Central Bank, Finland, France, Germany, Greece, Hong-Kong, Hungary, Iceland, Italy, Ivory Coast, Kenya, Latvia, Lithuania, Luxembourg, Madagascar, Malaysia, Malta, Mexico, Norway, Panama, Paraguay, Poland, Portugal, Romania, Russia, Sao Tome & Principe, Serbia, Singapore, Slovakia, Slovenia, Spain (incl. Catalonia), Sweden, Switzerland, Turkey, Ukraine. * Contributing documentation amended refs #467

view details

push time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha f0acae1b1b7289f91dd7ff552f65dee5adb43669

fixup! Migrating Labour Day as a worldwide holiday

view details

push time in a month

create barnchpeopledoc/workalendar

branch : 467-worldwide-labour-day

created branch time in a month

issue openedpeopledoc/workalendar

Spain: calendars for autonomous regions

The wikipedia page about Public holidays in Spain is now displaying holidays for regions other than Catalonia.

Maybe it's time to add them all...

created time in a month

issue openedpeopledoc/workalendar

OrthodoxCalendar: do they all include Orthodox Christmas?

  • Check if they're all including January 1st as a holiday (much probable)
  • Include this day in the OrthodoxCalendar.FIXED_HOLIDAYS constant or in the get_fixed_days method

Less configuration, less code.

created time in a month

issue openedpeopledoc/workalendar

Portugal: Immaculate conception

Immaculate conception is added via the FIXED_HOLIDAYS constant. Should be handled via the include_immaculate_conception flag & label change.

created time in a month

issue commentpeopledoc/workalendar

BUG: duplicate shifted holiday in California

thank you for the bug report, very "interesting" bug. I'll get into it as soon as I can.

joooeey

comment created time in a month

pull request commentpeopledoc/workalendar

new feature: method to export any Calendar to .ical

hello,

Looks like a good start. I'll try to have a look at it. It might eventually lead to an optional requirement, but I'm going to need a bit of time to find an nice way to do it.

joooeey

comment created time in a month

issue openedpeopledoc/workalendar

Colombia / Barranquilla

The city of Barranquilla includes two more holidays for Carnaval.

Sources:

  • https://en.wikipedia.org/wiki/Public_holidays_in_Colombia
  • https://fr.wikipedia.org/wiki/Barranquilla

created time in a month

delete branch peopledoc/workalendar

delete branch : 509-colombia-refactor

delete time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha 5cee59d16ee3caf259f7fb1e597beb4b60242e15

Small refactoring for the Colombia / added docstrings & comments to clarify exceptions refs #509

view details

Bruno Bord

commit sha b6978e7e4f71348d57f0e516aa89a440ec918781

Merge pull request #525 from peopledoc/509-colombia-refactor Colombia refactor

view details

push time in a month

PR merged peopledoc/workalendar

Colombia refactor

Small refactoring for the Colombia / added docstrings & comments to clarify exceptions

closes #509

  • [x] Tests with a significant number of years to be tested for your calendar.
  • [x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.
+149 -33

0 comment

3 changed files

brunobord

pr closed time in a month

issue closedpeopledoc/workalendar

Colombia: refactor class

instead of using flags, it extends the variable days using the ChristianMixin functions directly. We could simplify it.

EDIT: Finally those variable days were legit, because most of them were set to "the next Monday after date X". I've amended the class & tests.

closed time in a month

brunobord

PR opened peopledoc/workalendar

Colombia refactor

Small refactoring for the Colombia / added docstrings & comments to clarify exceptions

closes #509

  • [x] Tests with a significant number of years to be tested for your calendar.
  • [x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.
+149 -33

0 comment

3 changed files

pr created time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha 5cee59d16ee3caf259f7fb1e597beb4b60242e15

Small refactoring for the Colombia / added docstrings & comments to clarify exceptions refs #509

view details

push time in a month

create barnchpeopledoc/workalendar

branch : 509-colombia-refactor

created branch time in a month

delete branch peopledoc/workalendar

delete branch : release/10.3.0

delete time in a month

release peopledoc/workalendar

10.3.0

released time in a month

created tagpeopledoc/workalendar

tag10.3.0

Worldwide holidays and workdays computational toolkit.

created time in a month

PR merged peopledoc/workalendar

v10.3.0
  • Commit for the tag:
    • [x] Edit version in setup.py
    • [x] Add version in Changelog.md ; trim things
    • [x] Push & wait for the tests to be green
    • [x] tag me.
    • [x] build sdist + wheel packages (make package)
  • Back to dev commit:
    • [x] Edit version in setup.py
    • [x] Add the "master / nothing to see here" in Changelog.md
    • [x] Push & wait for the tests to be green
  • [ ] Merge --ff
  • Github stuff
    • [ ] Push tag in Github
    • [ ] Edit release on Github using the changelog.
    • [ ] Delete branch
  • [ ] upload release on PyPI using twine
+13 -5

0 comment

2 changed files

brunobord

pr closed time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha 5ac9848dbab17be5d67677c2307b64a4633d0a66

v10.3.0

view details

Bruno Bord

commit sha 57840c4466c6f4af016c29bd4f3dad57f1322730

Back to dev => 10.4.0.dev0

view details

push time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha 57840c4466c6f4af016c29bd4f3dad57f1322730

Back to dev => 10.4.0.dev0

view details

push time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha 5ac9848dbab17be5d67677c2307b64a4633d0a66

v10.3.0

view details

push time in a month

PR opened peopledoc/workalendar

v10.3.0
  • Commit for the tag:
    • [ ] Edit version in setup.py
    • [ ] Add version in Changelog.md ; trim things
    • [ ] Push & wait for the tests to be green
    • [ ] tag me.
    • [ ] build sdist + wheel packages (make package)
  • Back to dev commit:
    • [ ] Edit version in setup.py
    • [ ] Add the "master / nothing to see here" in Changelog.md
    • [ ] Push & wait for the tests to be green
  • [ ] Merge --ff
  • Github stuff
    • [ ] Push tag in Github
    • [ ] Edit release on Github using the changelog.
    • [ ] Delete branch
  • [ ] upload release on PyPI using twine
+9 -5

0 comment

2 changed files

pr created time in a month

create barnchpeopledoc/workalendar

branch : release/10.3.0

created branch time in a month

delete branch peopledoc/workalendar

delete branch : 511-universal-new-year-day

delete time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha b34747233403561c0f27251894ac1a7d47869949

Refactoring core classes * Refactoring the core ``Calendar`` classes / mixins for better understanding. Only one ``Calendar`` subclass should be imported / used in calendar classes, the rest (when possible) should be ``Mixins`` (related to #511). * Fixed Belarus holidays related to the Orthodox calendar * Fixed Algeria week-end days

view details

Bruno Bord

commit sha b3d7a111053c3e2986a376bbd8e15d2e04fa0fa1

Declaring the New year's Day as a worldwide holiday To date, there are only two exceptions: Israel & Qatar refs #511

view details

Bruno Bord

commit sha bcae2aa20e0d03a87ec5d5fb18aade55a0b935a7

Merge pull request #523 from peopledoc/511-universal-new-year-day Declaring the New year's Day as a worldwide holiday

view details

push time in a month

PR merged peopledoc/workalendar

Declaring the New year's Day as a worldwide holiday

closes #511

During the refactoring, it appeared that Algeria & Belarus calendars were to be fixed.

  • [x] Tests with a significant number of years to be tested for your calendar.
  • [x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.
+985 -874

0 comment

76 changed files

brunobord

pr closed time in a month

issue closedpeopledoc/workalendar

Refactor fix: New years Day is almost universal

There are only two calendars (Qatar and Israel) until now that don't include New Year's Day as a holiday. it'd be "handy" to integrate this day as a "universal" day, with a flag set to True by default, and disable it for the calendars that don't include NYD.

closed time in a month

brunobord

push eventpeopledoc/workalendar

Bruno Bord

commit sha b3d7a111053c3e2986a376bbd8e15d2e04fa0fa1

Declaring the New year's Day as a worldwide holiday To date, there are only two exceptions: Israel & Qatar refs #511

view details

push time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha 4d203680cf0776180e810a04804adf0a74486b7f

fixup! Declaring the New year's Day as a worldwide holiday

view details

push time in a month

PR opened peopledoc/workalendar

Declaring the New year's Day as a worldwide holiday

refs #511

During the refactoring, it appeared that Algeria & Belarus calendars were to be fixed.

  • [x] Tests with a significant number of years to be tested for your calendar.
  • [x] Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.
+985 -874

0 comment

76 changed files

pr created time in a month

delete branch brunobord/typographeur

delete branch : 9-skip-tags

delete time in a month

PR merged brunobord/typographeur

Skip tags option

closes #9

Checklist

  • [x] Adding unittests.
  • [x] README updates.
  • [x] Changelog entry.
+117 -19

0 comment

4 changed files

brunobord

pr closed time in a month

issue closedbrunobord/typographeur

Options to define the HTML tag list you want to skip or not

ex:

typographeur --skip-tags="pre,samp,code,var"

this comma-separated list to be splitted into a normal list or tuple to feed the typographeur routine. Then the "normal" tags won't be a shared constant but a variable, with a predefined value. Will need to take care of the case when you don't set the variable OR you don't want any tag to be escaped, which shouldn't lead to the same result.

closed time in a month

brunobord

push eventbrunobord/typographeur

Bruno Bord

commit sha e032f43601f2de9be8513bd893fdcaee65c566be

Added an option to skip tags Also, fixed a bug in determining the start/end of a tag to skip closes #9

view details

push time in a month

issue closedbrunobord/typographeur

Options to define the HTML tag list you want to skip or not

ex:

typographeur --skip-tags="pre,samp,code,var"

this comma-separated list to be splitted into a normal list or tuple to feed the typographeur routine. Then the "normal" tags won't be a shared constant but a variable, with a predefined value. Will need to take care of the case when you don't set the variable OR you don't want any tag to be escaped, which shouldn't lead to the same result.

closed time in a month

brunobord

PR opened brunobord/typographeur

9 skip tags

closes #9

Checklist

  • [x] Adding unittests.
  • [ ] README updates.
  • [ ] Changelog entry.
+117 -19

0 comment

4 changed files

pr created time in a month

push eventbrunobord/typographeur

Bruno Bord

commit sha e032f43601f2de9be8513bd893fdcaee65c566be

Added an option to skip tags Also, fixed a bug in determining the start/end of a tag to skip closes #9

view details

push time in a month

create barnchbrunobord/typographeur

branch : 9-skip-tags

created branch time in a month

delete branch brunobord/typographeur

delete branch : show-default-skip-tags

delete time in a month

push eventbrunobord/typographeur

Bruno Bord

commit sha 1afcdc0ac65b43ebebd86b88a8b89e4dd5ce7a90

Ajout d'une option ``--show-default-skip-tags`` pour afficher la liste des balises HTML ignorées refs #9

view details

push time in a month

create barnchbrunobord/typographeur

branch : show-default-skip-tags

created branch time in a month

delete branch brunobord/typographeur

delete branch : dictionnaire-6.4.2

delete time in a month

push eventbrunobord/typographeur

Bruno Bord

commit sha 2616682f1729cfd50e5ebe3f7273fc07a02172ad

Integration the french hunspell dictionaries, version 6.4.2

view details

Bruno Bord

commit sha b0d927f6c569d9fffa7e02910ae6889056755333

New ligature files generated Dictionary format has totally changed, so we had to adapt the ligature generation script. In the meantime, several pluralisations were wrong, so they were fixed.

view details

push time in a month

PR merged brunobord/typographeur

Dictionnaire 6.4.2

Checklist

  • [x] Adding unittests.
  • [x] Changelog entry.
+324658 -320880

0 comment

8 changed files

brunobord

pr closed time in a month

PR opened brunobord/typographeur

Dictionnaire 6.4.2

Checklist

  • [x] Adding unittests.
  • [x] Changelog entry.
+324658 -320880

0 comment

8 changed files

pr created time in a month

push eventbrunobord/typographeur

Bruno Bord

commit sha b0d927f6c569d9fffa7e02910ae6889056755333

New ligature files generated Dictionary format has totally changed, so we had to adapt the ligature generation script. In the meantime, several pluralisations were wrong, so they were fixed.

view details

push time in a month

push eventbrunobord/typographeur

Bruno Bord

commit sha 2616682f1729cfd50e5ebe3f7273fc07a02172ad

Integration the french hunspell dictionaries, version 6.4.2

view details

Bruno Bord

commit sha db24c8738c48529f3d69e03533da12256a54e7e5

New ligature files generated Dictionary format has totally changed, so we had to adapt the ligature generation script. In the meantime, several pluralisations were wrong, so they were fixed.

view details

push time in a month

create barnchbrunobord/typographeur

branch : dictionnaire-6.4.2

created branch time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha b34747233403561c0f27251894ac1a7d47869949

Refactoring core classes * Refactoring the core ``Calendar`` classes / mixins for better understanding. Only one ``Calendar`` subclass should be imported / used in calendar classes, the rest (when possible) should be ``Mixins`` (related to #511). * Fixed Belarus holidays related to the Orthodox calendar * Fixed Algeria week-end days

view details

Bruno Bord

commit sha 56732dadbeec1c4221c679372a991cb2f2414334

Declaring the New year's Day as a worldwide holiday To date, there are only two exceptions: Israel & Qatar refs #511

view details

push time in a month

issue openedpeopledoc/workalendar

Control: Make sure the workweek is correct for all calendars

Source: https://en.wikipedia.org/wiki/Workweek_and_weekend

  • Check all countries
  • Eventually create issues when there are variants we need to implement,
  • Amend the contributing.md documentation to help people creating calendars. They need to make sure that their workweek is correct before submitting.
  • Maybe amend the PR template

created time in a month

push eventpeopledoc/workalendar

Bruno Bord

commit sha f879024ca03c43649ef8fc7a8f0ee31661a6f4ed

fixup! fixup! Declaring the New year's Day as a worldwide holiday

view details

Bruno Bord

commit sha efec4a2dc12a741982d9ce5b106cc9478178061c

fixup! fixup! Refactoring core classes

view details

push time in a month

create barnchpeopledoc/workalendar

branch : 511-universal-new-year-day

created branch time in a month

issue openedpeopledoc/workalendar

Malysia Week-end days

There are exceptions in the MON-FRI week. Some territories have a SUN-THU workweek.

see: https://en.wikipedia.org/wiki/Workweek_and_weekend#Asia_and_Australasia

created time in a month

release peopledoc/django-formidable

5.0.0

released time in a month

created tagpeopledoc/django-formidable

tag5.0.0

On the way to glory! again!

created time in a month

PR merged peopledoc/django-formidable

Reviewers
v5.0.0

Release

  • [x] Change formidable.version with the appropriate tag
  • [x] Amend CHANGELOG.rst (check the release date)
  • [x] If the version deprecates one or more feature(s) check the docs deprecations.rst file and change it if necessary.
  • [x] DON'T FORGET TO MAKE THE "BACK TO DEV COMMIT"
  • [ ] Tag the appropriate commit with the appropriate tag (i.e. not the "back to dev one")
  • [ ] Merge (fast forward is nice)
  • [ ] Push the tag (using: git push --tags)
  • [ ] Edit the release (copy/paste CHANGELOG)
  • [ ] Publish the new release to PyPI
+17 -5

0 comment

3 changed files

brunobord

pr closed time in a month

push eventpeopledoc/django-formidable

Bruno Bord

commit sha d1dc5087c5d9b2c8c87f934f438c598412ece93e

v5.0.0

view details

Bruno Bord

commit sha 5854e685602b88d594d1851799fa6c31e39908be

Back to dev => 5.1.0.dev0

view details

push time in a month

push eventpeopledoc/django-formidable

Bruno Bord

commit sha 5854e685602b88d594d1851799fa6c31e39908be

Back to dev => 5.1.0.dev0

view details

push time in a month

PR opened peopledoc/django-formidable

v5.0.0

Release

  • [ ] Change formidable.version with the appropriate tag
  • [ ] Amend CHANGELOG.rst (check the release date)
  • [ ] If the version deprecates one or more feature(s) check the docs deprecations.rst file and change it if necessary.
  • [ ] DON'T FORGET TO MAKE THE "BACK TO DEV COMMIT"
  • [ ] Tag the appropriate commit with the appropriate tag (i.e. not the "back to dev one")
  • [ ] Merge (fast forward is nice)
  • [ ] Push the tag (using: git push --tags)
  • [ ] Edit the release (copy/paste CHANGELOG)
  • [ ] Publish the new release to PyPI
+14 -7

0 comment

3 changed files

pr created time in a month

push eventpeopledoc/django-formidable

Bruno Bord

commit sha d1dc5087c5d9b2c8c87f934f438c598412ece93e

v5.0.0

view details

push time in a month

push eventpeopledoc/django-formidable

Bruno Bord

commit sha ea29c5ddb1d507cb97991573bae1e50fed923230

v5.0.0

view details

push time in a month

create barnchpeopledoc/django-formidable

branch : release/5.0.0

created branch time in a month

delete branch peopledoc/django-formidable

delete branch : include-parameters-contextualized-serializer

delete time in a month

push eventpeopledoc/django-formidable

Bruno Bord

commit sha 3279ec480c5017f92792b4912041c88873873327

Include parameters when serializing a form using the ContextFormSerializer

view details

Bruno Bord

commit sha 3ac35b6fe6b4a5c4016d58becdf37f178284418e

Merge pull request #400 from peopledoc/include-parameters-contextualized-serializer Include parameters when serializing a form using the ContextFormSerializer

view details

push time in a month

PR merged peopledoc/django-formidable

Include parameters when serializing a form using the ContextFormSerializer

Review

This PR closes #<!-- issue number -->

  • [x] Tests<!-- mandatory -->
  • [x] Docs/comments
  • [x] CHANGELOG.rst Updated
  • [ ] Delete your branch
+35 -4

0 comment

3 changed files

brunobord

pr closed time in a month

issue commentpeopledoc/workalendar

Brazil not computing right

Hello, and first of all, thank you for this interesting issue report (3049 working days in the future, wow!).

In order to make sure that we're at the same level, I think that it'd be better to first have a stable starting date... because... date.today() is changing... every day :o)

Also, I think it might be easier to start with a smaller amount of working days to add, for example to test out your calendar over a year or two, to make sure you can detect differences without having to count by hand 3000-ish days.

Here's the code sample I've used to get to the result that causes a problem for you:

import datetime
from workalendar.america import Brazil

cal = Brazil()
today = datetime.date(2020, 6, 28)

def main():
    print (date_business_days(today, 3049))

def date_business_days(initial_date, days):
    return cal.add_working_days(initial_date, days).strftime('%d/%m/%Y')

main()

its output is:

07/06/2032

Then, as you may have noticed, if you display Brazil "core class" holiday calendar, you'll see that its holidays differ with https://www.anbima.com.br/feriados/fer_nacionais/2020.asp:

>>> cal.holidays()
[(datetime.date(2020, 1, 1), 'New year'),
 (datetime.date(2020, 4, 12), 'Easter Sunday'),
 (datetime.date(2020, 4, 21), "Tiradentes' Day"),
 (datetime.date(2020, 5, 1), 'Labour Day'),
 (datetime.date(2020, 9, 7), 'Independence Day'),
 (datetime.date(2020, 10, 12), 'Our Lady of Aparecida'),
 (datetime.date(2020, 11, 2), "All Souls' Day"),
 (datetime.date(2020, 11, 15), 'Republic Day'),
 (datetime.date(2020, 12, 25), 'Christmas Day')]

It might be because the Brazil class is probably not meant to be used as your "target" calendar, but as a base class to build your own calendar, as it's done for all Brazil territories. For example, if you use BrazilRioDeJaneiro or BrazilAcre classes, you'll get different results:

>>> from workalendar.america import BrazilAcre, BrazilRioDeJaneiro
>>> BrazilAcre().holidays()
[(datetime.date(2020, 1, 1), 'New year'),
 (datetime.date(2020, 1, 23), 'Dia do evangélico'),
 (datetime.date(2020, 4, 12), 'Easter Sunday'),
 (datetime.date(2020, 4, 21), "Tiradentes' Day"),
 (datetime.date(2020, 5, 1), 'Labour Day'),
 (datetime.date(2020, 6, 15), 'Aniversário do Acre'),
 (datetime.date(2020, 8, 6), 'Início da Revolução Acreana'),
 (datetime.date(2020, 9, 5), 'Dia da Amazônia'),
 (datetime.date(2020, 9, 7), 'Independence Day'),
 (datetime.date(2020, 10, 12), 'Our Lady of Aparecida'),
 (datetime.date(2020, 11, 2), "All Souls' Day"),
 (datetime.date(2020, 11, 15), 'Republic Day'),
 (datetime.date(2020, 11, 17), 'Assinatura do Tratado de Petrópolis'),
 (datetime.date(2020, 12, 25), 'Christmas Day')]
>>> BrazilRioDeJaneiro().holidays()
[(datetime.date(2020, 1, 1), 'New year'),
 (datetime.date(2020, 2, 25), 'Carnaval'),
 (datetime.date(2020, 3, 1), 'Aniversário da Cidade do Rio de Janeiro'),
 (datetime.date(2020, 4, 12), 'Easter Sunday'),
 (datetime.date(2020, 4, 21), "Tiradentes' Day"),
 (datetime.date(2020, 4, 23), 'Dia de São Jorge'),
 (datetime.date(2020, 5, 1), 'Labour Day'),
 (datetime.date(2020, 9, 7), 'Independence Day'),
 (datetime.date(2020, 10, 12), 'Our Lady of Aparecida'),
 (datetime.date(2020, 10, 19), 'Dia do Comércio'),
 (datetime.date(2020, 10, 28), 'Dia do Funcionário Público'),
 (datetime.date(2020, 11, 2), "All Souls' Day"),
 (datetime.date(2020, 11, 15), 'Republic Day'),
 (datetime.date(2020, 11, 20), 'Dia da Consciência Negra'),
 (datetime.date(2020, 12, 8), 'Dia de Nossa Senhora da Conceição'),
 (datetime.date(2020, 12, 25), 'Christmas Day')]

I'm not sure of how the ANBIMA organization has decided which holidays were public holidays. It looks like this organization is related to banks and finance, but apparently they're not using the Brazil Bank calendar (which is included in the brazil.py module).

I think that, if you want to stick to their calendar you'll have to build your own ANBIMA class, derived/inherited from Brazil base class, and add their the holidays as they've defined them.

You can see an example of how to build a Calendar class in the Contributing documentation. It won't be exactly the same, because you won't have to build it from scratch, but it'll be your best approach.

If you need some help, do not hesitate to ask.

z226

comment created time in a month

delete branch brunobord/typographeur

delete branch : fix-skip-unskip

delete time in 2 months

push eventbrunobord/typographeur

Bruno Bord

commit sha 88dcfac34015c581398ae651138e5c5bd86a8dd2

Correction d'une erreur sur les balises ignorées. Une fois déclenchée, le "skip" des balises ne se remettait plus à zéro.

view details

push time in 2 months

create barnchbrunobord/typographeur

branch : fix-skip-unskip

created branch time in 2 months

delete branch brunobord/typographeur

delete branch : add-coverage

delete time in 2 months

push eventbrunobord/typographeur

Bruno Bord

commit sha fe20c3551e6a2cabef81efa86c6f78d4e8a4e933

Added coverage when running the tests

view details

push time in 2 months

push eventbrunobord/typographeur

Bruno Bord

commit sha fe20c3551e6a2cabef81efa86c6f78d4e8a4e933

Added coverage when running the tests

view details

push time in 2 months

push eventbrunobord/typographeur

Bruno Bord

commit sha 74a7878f333707ad14a6c17364aef288129824b8

fixup! Added coverage when running the tests

view details

push time in 2 months

push eventbrunobord/typographeur

push time in 2 months

push eventbrunobord/typographeur

Bruno Bord

commit sha ff49623f77e600ea5d2a0081c78ac2a007b75cfa

Added coverage when running the tests

view details

push time in 2 months

more