profile
viewpoint
Chris Broadfoot broady San Francisco and Sydney https://chrisbroadfoot.id.au/ @google @golang @GoogleCloudPlatform

broady/gae-postgres 23

Connect to Cloud SQL for PostgreSQL from Google App Engine

broady/cacerts 19

scratch + Debian's ca-certificates

broady/dropzone-saver 12

Save files using dropzone. Easier than SCP.

broady/flexdev 10

Quickly deploy Go GAE flexible apps

broady/cdbuild 9

Build docker images remotely and push to gcr.io

broady/chrisbroadfoot.id.au 3

Source for https://chrisbroadfoot.id.au

issue commentgoogleapis/google-cloud-go

bigtable: Client.Close() returns error with emulator as of v0.53.0

go get google.golang.org/api@latest

erock2112

comment created time in 21 hours

issue commentmicrosoft/vscode-go

Saving is very slow because waiting for "Quick Fixes" [flaky]

OK, log levels increased. When saving is slow again (it's fast right now) I'll add the logs here.

broady

comment created time in a day

release googleapis/google-api-go-client

v0.18.0

released time in a day

issue commentmicrosoft/vscode-go

Saving is very slow because waiting for "Quick Fixes" [flaky]

Looks like it does complete eventually (~20 seconds)

broady

comment created time in a day

issue openedmicrosoft/vscode-go

Can't save because waiting for "Quick Fixes" [flaky]

Issue Type: <b>Bug</b>

  1. Attempt to save a file
  2. See a window pop up "Running Save Participants... Quick Fixes"

Observe: Quick Fixes doesn't complete (sometimes, this seems flaky) Can't find anything relevant in the Go extension output

Extension version: 0.13.0 VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:44:27.652Z) OS version: Darwin x64 18.7.0 Remote OS version: Linux x64 5.2.17-1rodete3-amd64

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Xeon(R) W-2140B CPU @ 3.20GHz (16 x 3200)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off<br>surface_control: disabled_off<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off<br>webgl: enabled<br>webgl2: enabled
Load (avg) 1, 1, 2
Memory (System) 64.00GB (36.30GB free)
Process Argv
Screen Reader no
VM 0%
Item Value
Remote SSH: cbro.mtv.corp.google.com
OS Linux x64 5.2.17-1rodete3-amd64
CPUs Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz (6 x 2299)
Memory (System) 11.73GB (0.14GB free)
VM 0%

</details> <!-- generated by issue reporter -->

created time in a day

Pull request review commentGoogleCloudPlatform/cloudsql-proxy

fix: Remove incorrect api base url from the host flag.

 func parseInstanceConfig(dir, instance string, cl *http.Client) (instanceConfig, 	if err != nil { 		return instanceConfig{}, err 	}-	sql.BasePath = *host+	if *host != "" {+		sql.BasePath = *host

I suggest using

sqladmin.NewClient(ctx, option.WithEndpoint(*host))

Then the user can actually set a host (e.g., "sqladmin.sandbox.googleapis.com") rather than a full URL path because of this CL: https://code-review.googlesource.com/c/google-api-go-client/+/50190

(then you can remove the !strings.HasSuffix(*host, "/") check, and I'd also update the docs for the flag to include that it can be host[:port] or a full URL path)

kurtisvg

comment created time in a day

issue closedgoogleapis/google-cloud-go

google-cloud-go + google-api-go-client dependency is outdated

We are not able to use a later version of cloud.google.com/go than v0.38.0. Using a later version than > v0.38.0 results in compilation errors.

Interdependency

google.golang.org/api v0.17.0 (February 6, 2020)

References to

https://github.com/googleapis/google-api-go-client/blob/master/go.mod#L6

module google.golang.org/api

go 1.11

require (
	cloud.google.com/go v0.38.0 // indirect
        ...
)

This is the only valid Bazel configuration at this time

WORKSPACE

git_repository(
    name = "com_google_protobuf",
    commit = "d0bfd5221182da1a7cc280f3337b5e41a89539cf",
    remote = "https://github.com/protocolbuffers/protobuf",
)

load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")

protobuf_deps()

go_repository(
    name = "org_golang_google_grpc",
    build_file_proto_mode = "disable",
    importpath = "google.golang.org/grpc",
    sum = "h1:rRYRFMVgRv6E0D70Skyfsr28tDXIuuPZyWGMPdMcnXg=",
    version = "v1.27.0",
)

go_repository(
    name = "com_google_cloud_go",
    importpath = "cloud.google.com/go",
    sum = "h1:ROfEUZz+Gh5pa62DJWXSaonyu3StP6EA6lPEXPI6mCo=",
    version = "v0.38.0",
)

go_repository(
    name = "org_golang_google_api",
    importpath = "google.golang.org/api",
    sum = "h1:0q95w+VuFtv4PAx4PZVQdBMmYbaCHbnfKaEiDIcVyag=",
    version = "v0.17.0",
)

BUILD.bazel

go_library(
    name = "go_default_library",
    srcs = [
        "main.go",
    ],
    deps = [
        "@com_google_cloud_go//errorreporting:go_default_library",
        "@com_google_cloud_go//profiler:go_default_library",
        "@com_google_cloud_go_logging//:go_default_library",
    ],
)

closed time in 5 days

cherryland

issue commentgoogleapis/google-cloud-go

google-cloud-go + google-api-go-client dependency is outdated

Hi

You need to update your genproto dependency.

Regarding the title of this issue, we absolutely do care. We aren't very familiar with Bazel, but we have multiple layers of testing and tooling that ensures we maintain compatibility across our multiple dependencies with standard Go module dependency system.

On Thu, Feb 20, 2020, 8:49 AM Tyler Bui-Palsulich notifications@github.com wrote:

Assigned #1789 https://github.com/googleapis/google-cloud-go/issues/1789 to @broady https://github.com/broady.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/googleapis/google-cloud-go/issues/1789?email_source=notifications&email_token=AAAGDFRXZTPHSL6PHFMQGHLRD2YBHA5CNFSM4KYSQQKKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWY4KUCQ#event-3057166858, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGDFRARLBDB4XLZ5PF6L3RD2YBHANCNFSM4KYSQQKA .

cherryland

comment created time in 5 days

issue commentgoogleapis/google-cloud-go

bigtable: Client.Close() returns error with emulator as of v0.53.0

it'll be fixed on the next tag of google.golang.org/api/transport/grpc. should be this week sometime.

erock2112

comment created time in 7 days

issue closedmicrosoft/vscode-remote-release

Remote SSH timeout too aggressive and not configurable

Issue Type: <b>Bug</b>

  1. attempt to SSH to a server that takes a while to connect
  2. observe Remote SSH extension timeout

My SSH server requires two-factor authentication via a ubico security key. If I don't press it in time, Remote SSH times out.

Extension version: 0.36.0 VS Code version: Code - Insiders 1.34.0-insider (daf71423252a707b8e396e8afa8102b717f8213b, 2019-05-06T22:07:35.830Z) OS version: Darwin x64 18.7.0 Remote OS version: Linux x64 5.2.17-1rodete3-amd64

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz (4 x 3300)
GPU Status 2d_canvas: enabled<br>checker_imaging: disabled_off<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: enabled<br>rasterization: enabled<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>webgl: enabled<br>webgl2: enabled
Load (avg) 32, 51, 35
Memory (System) 16.00GB (0.12GB free)
Process Argv
Screen Reader no
VM 0%
Item Value
Remote SSH: cbro
OS Linux x64 5.2.17-1rodete3-amd64
CPUs Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz (6 x 2299)
Memory (System) 11.73GB (0.18GB free)
VM 0%

</details> <!-- generated by issue reporter -->

closed time in 7 days

broady

issue commentmicrosoft/vscode-remote-release

Remote SSH timeout too aggressive and not configurable

Thanks. I'm on a new computer now and I'm going to try the non-insiders version. I'll try this setting. Thanks.

broady

comment created time in 7 days

issue openedmicrosoft/vscode

Support tmux control mode (-CC flag)

Issue Type: <b>Feature Request</b>

I saw the suggestion from @roblourens to use tmux in microsoft/vscode-remote-release#1185

That's mostly good, however has a few issues:

  • code command doesn't work inside tmux.
  • no GUI support - the built-in tab management and split panes then aren't usable.
  • scrolling doesn't work (control codes not sent to the terminal?)

I'd love to see support for tmux's control mode (tmux -CC) - then vscode could use its native tab/window management and sessions would be persisted between app opens/closes.

Extension version: 0.36.0 VS Code version: Code - Insiders 1.34.0-insider (daf71423252a707b8e396e8afa8102b717f8213b, 2019-05-06T22:07:35.830Z) OS version: Darwin x64 18.7.0 Remote OS version: Linux x64 5.2.17-1rodete3-amd64

<!-- generated by issue reporter -->

created time in 12 days

issue openedmicrosoft/vscode-remote-release

Support tmux control mode (-CC flag)

Issue Type: <b>Feature Request</b>

I saw the suggestion from @roblourens to use tmux in #1185

That's mostly good, however has a few issues:

  • code command doesn't work inside tmux.
  • no GUI support - the built-in tab management and split panes then aren't usable.
  • scrolling doesn't work (control codes not sent to the terminal?)

I'd love to see support for tmux's control mode (tmux -CC) - then vscode could use its native tab/window management and sessions would be persisted between app opens/closes.

Extension version: 0.36.0 VS Code version: Code - Insiders 1.34.0-insider (daf71423252a707b8e396e8afa8102b717f8213b, 2019-05-06T22:07:35.830Z) OS version: Darwin x64 18.7.0 Remote OS version: Linux x64 5.2.17-1rodete3-amd64

<!-- generated by issue reporter -->

created time in 12 days

issue openedmicrosoft/vscode-remote-release

Remote SSH timeout too aggressive and not configurable

Issue Type: <b>Bug</b>

  1. attempt to SSH to a server that takes a while to connect
  2. observe Remote SSH extension timeout

My SSH server requires two-factor authentication via a ubico security key. If I don't press it in time, Remote SSH times out.

Extension version: 0.36.0 VS Code version: Code - Insiders 1.34.0-insider (daf71423252a707b8e396e8afa8102b717f8213b, 2019-05-06T22:07:35.830Z) OS version: Darwin x64 18.7.0 Remote OS version: Linux x64 5.2.17-1rodete3-amd64

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz (4 x 3300)
GPU Status 2d_canvas: enabled<br>checker_imaging: disabled_off<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: enabled<br>rasterization: enabled<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>webgl: enabled<br>webgl2: enabled
Load (avg) 32, 51, 35
Memory (System) 16.00GB (0.12GB free)
Process Argv
Screen Reader no
VM 0%
Item Value
Remote SSH: cbro
OS Linux x64 5.2.17-1rodete3-amd64
CPUs Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz (6 x 2299)
Memory (System) 11.73GB (0.18GB free)
VM 0%

</details> <!-- generated by issue reporter -->

created time in 12 days

issue commentcli/cli

Allow for standardized output format

@lucasyvas oh, right, you were talking about the tool's current output, not the proposed JSON output. Yeah, agreed, everything seems very geared toward an interactive workflow.

dfockler

comment created time in 12 days

pull request commentcli/cli

Add "go get" command to source installation instructions

Yep. Everything is functional, though.

Feel free to close if you want to discourage this. But gh works perfectly for me when installed this way.

broady

comment created time in 12 days

PR opened cli/cli

Add "go get" command to source installation instructions
+5 -0

0 comment

1 changed file

pr created time in 13 days

push eventbroady/cli

Chris Broadfoot

commit sha c321196c3042e93dfdaa53134e9cc2754983ec48

Add "go get" command to source installation instructions

view details

push time in 13 days

fork broady/cli

The GitHub CLI

https://cli.github.com/

fork in 13 days

issue commentcli/cli

Allow for standardized output format

@lucasyvas I don't know about your definition of "standard", but jq is pretty great.

dfockler

comment created time in 13 days

release googleapis/google-cloud-go

bigtable/v1.3.0

released time in 13 days

release googleapis/google-cloud-go

datastore/v1.1.0

released time in 13 days

release googleapis/google-cloud-go

v0.53.0

released time in 13 days

issue commentgoogleapis/google-cloud-go

all: remove last uses of gtransport.Dial

Blocks https://github.com/googleapis/google-api-go-client/issues/441

broady

comment created time in 13 days

issue commentgoogleapis/google-cloud-go

all: remove last uses of gtransport.Dial

Any ETA on that, @noahdietz? Primarily concerned about pubsub/apiv1 which is used by hand-written pubsub client, which uses pooling by default.

broady

comment created time in 13 days

issue openedgoogleapis/google-cloud-go

all: remove last uses of gtransport.Dial

$ git grep transport.Dial | grep -v DialPool | grep -v test | cut -d: -f1 | sort | uniq
asset/v1beta1/asset_client.go
automl/apiv1/auto_ml_client.go
automl/apiv1beta1/auto_ml_client.go
automl/apiv1beta1/prediction_client.go
automl/apiv1/prediction_client.go
bigquery/datatransfer/apiv1/data_source_client.go
cloudbuild/apiv1/cloud_build_client.go
containeranalysis/apiv1/container_analysis_client.go
container/apiv1/cluster_manager_client.go
grafeas/apiv1/grafeas_client.go
iam/admin/apiv1/iam_client.go
pubsub/apiv1/publisher_client.go
pubsub/apiv1/subscriber_client.go
talent/apiv4beta1/application_client.go
talent/apiv4beta1/company_client.go
talent/apiv4beta1/completion_client.go
talent/apiv4beta1/event_client.go
talent/apiv4beta1/job_client.go
talent/apiv4beta1/profile_client.go
talent/apiv4beta1/tenant_client.go

@shollyman re: bigquery/datatransfer/apiv1/data_source_client: "we can probably just remove it"

created time in 13 days

issue commentgoogleapis/google-api-go-client

grpc.RoundRobin and grpc.WithBalancer no longer exist

Quick update... Next steps:

  • tag a release of all modules in google-cloud-go
  • submit CL 50573
  • tag a release of google-api-go-client
jqll

comment created time in 14 days

push eventgoogleapis/go-genproto

ananya saxena

commit sha 55294c81d78435ecfdececac701201a9ce1aa114

tools: remove golang.org/x/exp/apidiff (#303) golang.org/x/exp should no longer be needed after #167

view details

push time in 15 days

PR merged googleapis/go-genproto

tools: remove golang.org/x/exp/apidiff cla: yes

golang.org/x/exp should no longer be needed after #167

+0 -3

0 comment

3 changed files

ananyasaxena

pr closed time in 15 days

startedtailscale/tailscale

started time in 15 days

delete branch googleapis/go-genproto

delete branch : regen_genproto

delete time in 18 days

push eventgoogleapis/go-genproto

Chris Broadfoot

commit sha c843d3f5f06c0c5c1117f7c6a526aa1e7ada197b

auto-regenerate .pb.go files This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genmgr will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night. If you have been assigned to review this CL, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genmgr to assign reviewers to the gocloud CL. Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/51650

view details

push time in 18 days

PR opened googleapis/go-genproto

auto-regenerate .pb.go files

This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genmgr will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night.

If you have been assigned to review this CL, please:

  • Ensure that CI is passing. If it's failing, it requires your manual attention.
  • Approve and submit this PR if you believe it's ready to ship. That will prompt genmgr to assign reviewers to the gocloud CL.
+1969 -951

0 comment

21 changed files

pr created time in 18 days

create barnchgoogleapis/go-genproto

branch : regen_genproto

created branch time in 18 days

issue commentgoogleapis/google-api-go-client

Broken sql/sqladmin package

Thank you for flagging it.

kacper-zylka

comment created time in 18 days

delete branch googleapis/gapic-generator-go

delete branch : dialpool

delete time in 19 days

push eventgoogleapis/gapic-generator-go

Chris Broadfoot

commit sha 551bc71fdbeed2c6d112221b3b46b1e43c7da0a3

internal/gengapic: use gtransport.DialPool, deprecate Connection() (#301) Connection pooling via gtransport.Dial will be removed soon. See https://github.com/googleapis/google-api-go-client/issues/441

view details

push time in 19 days

PR merged googleapis/gapic-generator-go

internal/gengapic: use gtransport.DialPool, deprecate Connection() cla: yes

Connection pooling via gtransport.Dial will be removed soon.

See https://github.com/googleapis/google-api-go-client/issues/441

+65 -48

4 comments

6 changed files

broady

pr closed time in 19 days

push eventgoogleapis/gapic-generator-go

WhiteSource Renovate

commit sha 785fa087c02806e1cd89323ccb64fb50bb5d0370

chore(deps): update google.golang.org/genproto commit hash to fa8e72b (#297)

view details

WhiteSource Renovate

commit sha 910e8bdac905623072cfd937c2ea493654f8f174

chore(deps): update google.golang.org/genproto commit hash to fb4a7af (#299)

view details

WhiteSource Renovate

commit sha 64cbf8f23b185f4c21a6f207bbca611543969c74

chore(deps): update google.golang.org/genproto commit hash to a86caf9 (#300)

view details

Chris Broadfoot

commit sha b1613b0e2c6e7dc57afc0abee29e40c84808d82d

internal/gengapic: use gtransport.DialPool, deprecate Connection() Connection pooling via gtransport.Dial will be removed soon. See https://github.com/googleapis/google-api-go-client/issues/441

view details

push time in 19 days

pull request commentgoogleapis/gapic-generator-go

internal/gengapic: use gtransport.DialPool, deprecate Connection()

Hurrah!

Fixing merge conflict.

broady

comment created time in 19 days

push eventgoogleapis/gapic-generator-go

Chris Broadfoot

commit sha 740069afaab378e77aaed2fe4b0050f9541fd0bc

internal/gengapic: use gtransport.DialPool, deprecate Connection() Connection pooling via gtransport.Dial will be removed soon. See https://github.com/googleapis/google-api-go-client/issues/441

view details

push time in 19 days

push eventgoogleapis/gapic-generator-go

Chris Broadfoot

commit sha 63946a9a72f3915f12a8d1cc91ac24cadcf941eb

internal/gengapic: use gtransport.DialPool, deprecate Connection() Connection pooling via gtransport.Dial will be removed soon. See https://github.com/googleapis/google-api-go-client/issues/441

view details

push time in 19 days

pull request commentgoogleapis/gapic-showcase

release v0.7.0

LGTM++

noahdietz

comment created time in 19 days

issue openedgoogleapis/gapic-showcase

Please make a new release

The Go protoc output now uses grpc.ClientConnInterface, which we need for the Go GAPIC.

created time in 19 days

Pull request review commentgoogleapis/gapic-generator-go

internal/gengapic: use gtransport.DialPool, deprecate Connection()

 func (g *generator) clientInit(serv *descriptor.ServiceDescriptorProto, servName 		p("// Methods, except Close, may be called concurrently. However, fields must not be modified concurrently with method calls.") 		p("type %sClient struct {", servName) -		p("// The connection to the service.")-		p("conn *grpc.ClientConn")+		p("// Connection pool of gRPC connections to the service.")+		p("connp gtransport.ConnPool")

done

broady

comment created time in 19 days

push eventgoogleapis/gapic-generator-go

Chris Broadfoot

commit sha df191d569cd5f2f1f148179b0c10ef55043679b6

internal/gengapic: use gtransport.DialPool, deprecate Connection() Connection pooling via gtransport.Dial will be removed soon. See https://github.com/googleapis/google-api-go-client/issues/441

view details

push time in 19 days

push eventgoogleapis/gapic-generator-go

Chris Broadfoot

commit sha 4d5150761d1f65866241239e88f0188fd9cb9ae3

internal/gengapic: use gtransport.DialPool, deprecate Connection() Connection pooling via gtransport.Dial will be removed soon. See https://github.com/googleapis/google-api-go-client/issues/441

view details

push time in 19 days

Pull request review commentgoogleapis/gapic-generator-go

internal/gengapic: use gtransport.DialPool, deprecate Connection()

 func (g *generator) clientInit(serv *descriptor.ServiceDescriptorProto, servName 		p("//") 		g.comment(g.comments[serv]) 		p("func New%[1]sClient(ctx context.Context, opts ...option.ClientOption) (*%[1]sClient, error) {", servName)-		p("  conn, err := transport.DialGRPC(ctx, append(default%sClientOptions(), opts...)...)", servName)+		p("  connp, err := gtransport.DialPool(ctx, append(default%sClientOptions(), opts...)...)", servName) 		p("  if err != nil {") 		p("    return nil, err") 		p("  }") 		p("  c := &%sClient{", servName)-		p("    conn:        conn,")+		p("    connp:       connp,") 		p("    CallOptions: default%sCallOptions(),", servName) 		p("") 		p("    %s: %s.New%sClient(conn),", grpcClientField(servName), imp.Name, serv.GetName())

absolutely it is incorrect

broady

comment created time in 19 days

push eventgoogleapis/gapic-generator-go

Chris Broadfoot

commit sha aecbd20cddf119fb186c0f70bc020105a6f5003b

internal/gengapic: use gtransport.DialPool, deprecate Connection() Connection pooling via gtransport.Dial will be removed soon. See https://github.com/googleapis/google-api-go-client/issues/441

view details

push time in 19 days

pull request commentgoogleapis/gapic-generator-go

internal/gengapic: use gtransport.DialPool, deprecate Connection()

I'm finding it very difficult to update the go.mod and go.sum files in the showcase directory.

gapic-generator-go/showcase +dialpool $ go get google.golang.org/api/transport@latest && go mod tidy
go: cloud.google.com/go/showcase@v0.0.0: parsing gen/cloud.google.com/go/showcase/go.mod: open /usr/local/google/home/cbro/modsrc/gapic-generator-go/showcase/gen/cloud.google.com/go/showcase/go.mod: no such file or directory

< comment out replace directive >

gapic-generator-go/showcase +dialpool $ go get google.golang.org/api/transport@latest && go mod tidy
go: cloud.google.com/go/showcase@v0.0.0: unrecognized import path "cloud.google.com/go/showcase" (parse https://cloud.google.com/go/showcase?go-get=1: no go-import meta tags ())

< comment out require entry for showcase in go.mod >

gapic-generator-go/showcase +dialpool $ go get google.golang.org/api/transport@latest && go mod tidy
go: downloading cloud.google.com/go v0.45.0
go: extracting cloud.google.com/go v0.45.0
go: downloading github.com/googleapis/gapic-showcase v0.5.0
go: extracting github.com/googleapis/gapic-showcase v0.5.0
showcase_integration tested by
        showcase_integration.test imports
        cloud.google.com/go/showcase/apiv1beta1: module cloud.google.com/go@latest found (v0.52.0), but does not contain package cloud.google.com/go/showcase/apiv1beta1

I've just made the change to go.mod manually.

broady

comment created time in 19 days

push eventgoogleapis/gapic-generator-go

Chris Broadfoot

commit sha a2d34756c58323a46d0bdef3be143eae3faf965c

internal/gengapic: use gtransport.DialPool, deprecate Connection() Connection pooling via gtransport.Dial will be removed soon. See https://github.com/googleapis/google-api-go-client/issues/441

view details

push time in 19 days

PR opened googleapis/gapic-generator-go

internal/gengapic: use gtransport.DialPool, deprecate Connection()

Connection pooling via gtransport.Dial will be removed soon.

See https://github.com/googleapis/google-api-go-client/issues/441

+39 -31

0 comment

4 changed files

pr created time in 19 days

create barnchgoogleapis/gapic-generator-go

branch : dialpool

created branch time in 19 days

issue commentgoogleapis/google-api-go-client

Broken sql/sqladmin package

v0.17.0 is tagged.

kacper-zylka

comment created time in 19 days

release googleapis/google-api-go-client

v0.17.0

released time in 19 days

issue commentgoogleapis/google-api-go-client

Broken sql/sqladmin package

This is the diff between running make all vs make local:

-// Package sqladmin provides access to the Cloud SQL Admin API.
-//   import "google.golang.org/api/sqladmin/v1beta4"
-//   sqladminService, err := sqladmin.NewService(ctx)
-//   sqladminService, err := sqladmin.NewService(ctx, option.WithScopes(sqladmin.SqlserviceAdminScope))
-//   sqladminService, err := sqladmin.NewService(ctx, option.WithAPIKey("AIza..."))
-//   sqladminService, err := sqladmin.NewService(ctx, option.WithTokenSource(config.TokenSource(ctx, token)))
-package sqladmin // import "google.golang.org/api/sqladmin/v1beta4"
-       StorageAutoResize *bool `json:"storageAutoResize,omitempty"`
kacper-zylka

comment created time in 20 days

issue commentgoogleapis/google-api-go-client

Broken sql/sqladmin package

I really don't understand what happened, but I regenerated everything again and now it's back to the way it should be.

https://code-review.googlesource.com/c/google-api-go-client/+/51550

kacper-zylka

comment created time in 20 days

issue commentgoogleapis/google-api-go-client

Broken sql/sqladmin package

The discovery doc changed substantially back in November: https://code-review.googlesource.com/c/google-api-go-client/+/48474/2/sqladmin/v1beta4/sqladmin-api.json#b32

Strangely, it looks like sqladmin hadn't been re-generated since my manual re-generation (8c19f07ca61ae7b417f580832f8f7a91c8e16de8) even though the discovery doc had changed several times.

The root cause is certainly that the discovery doc says "sql" when the API name is "sqladmin".

Root discovery service says:

    {
      "kind": "discovery#directoryItem",
      "id": "sql:v1beta4",
      "name": "sql",
      "version": "v1beta4",
      "title": "Cloud SQL Admin API",
      "description": "API for Cloud SQL database instance management",
      "discoveryRestUrl": "https://sqladmin.googleapis.com/$discovery/rest?version=v1beta4",
      "icons": {
        "x16": "https://www.gstatic.com/images/branding/product/1x/googleg_16dp.png",
        "x32": "https://www.gstatic.com/images/branding/product/1x/googleg_32dp.png"
      },
      "documentationLink": "https://developers.google.com/cloud-sql/",
      "preferred": true
    },
    {
      "kind": "discovery#directoryItem",
      "id": "sqladmin:v1beta4",
      "name": "sqladmin",
      "version": "v1beta4",
      "title": "Cloud SQL Admin API",
      "description": "Creates and manages Cloud SQL instances, which provide fully managed MySQL or PostgreSQL databases.",
      "discoveryRestUrl": "https://www.googleapis.com/discovery/v1/apis/sqladmin/v1beta4/rest",
      "discoveryLink": "./apis/sqladmin/v1beta4/rest",
      "icons": {
        "x16": "https://www.gstatic.com/images/branding/product/1x/googleg_16dp.png",
        "x32": "https://www.gstatic.com/images/branding/product/1x/googleg_32dp.png"
      },
      "documentationLink": "https://cloud.google.com/sql/docs/reference/latest",
      "preferred": true
    },

But the discovery doc at https://www.googleapis.com/discovery/v1/apis/sqladmin/v1beta4/rest says:

{
  "basePath": "",
  "ownerDomain": "google.com",
  "name": "sql",
  "batchPath": "batch",
  "revision": "20200124",
  "documentationLink": "https://developers.google.com/cloud-sql/",
  "id": "sql:v1beta4",
  "title": "Cloud SQL Admin API",
...

notice how name and id say "sql" and not "sqladmin"

kacper-zylka

comment created time in 20 days

issue commentgoogleapis/google-api-go-client

Broken sql/sqladmin package

Very strange. The changes to the JSON discovery doc should not have caused that.

https://code-review.googlesource.com/c/google-api-go-client/+/51393/2/sqladmin/v1beta4/sqladmin-api.json#25

Will investigate.

kacper-zylka

comment created time in 20 days

issue closedgoogleapis/google-cloud-go

is there anyway to just routing the credential request to an arbitrary credential provider endpoint ?

I saw this:

os.Setenv("GOOGLE_APPLICATION_CREDENTIALS", config.Creds)
os.Setenv(metadataHostEnv, "127.0.0.1")

But, these is not something we exactly looking for.

GOOGLE_APPLICATION_CREDENTIALS is a one-time setting for creds.

With metadataHostEnv, it is doable to route all the requests, but it would be nice to just configure the credentials endpoint.

Ideally, if SDK to send the credential request and retry to an external provider, it would be much easier to release the credential rotation work from our own services.

refer: https://github.com/aws/aws-sdk-go-v2/issues/451

closed time in 21 days

hixichen

issue commentgoogleapis/google-cloud-go

is there anyway to just routing the credential request to an arbitrary credential provider endpoint ?

Closing this for now, but we are thinking about ways to integrate third-party credentials (e.g., AWS metadata server) into our auth stack.

If we do, it will not be a Go-specific solution.

Thanks for raising this request!

hixichen

comment created time in 21 days

created taggoogleapis/google-api-go-client

tagv0

Auto-generated Google APIs for Go.

created time in 21 days

release googleapis/google-api-go-client

v0

released time in 21 days

created taggoogleapis/google-api-go-client

tagv0.16.0

Auto-generated Google APIs for Go.

created time in 21 days

issue openedgoogleapis/google-api-go-client

generator: gl-go value is not very useful

we send a User-Agent header like

x-goog-api-client: gl-go/1.12.5 gdcl/....

1.12.5 is the version of Go that the generator was built with. This is not very useful. It would be better to make this a static value (so it doesn't look useful) or use the version of Go that the user is using (but I can't think of a good reason to do that either).

/cc @JustinBeckwith @tbpg

created time in 22 days

PR closed googleapis/google-api-go-client

Reviewers
option: remove experimental API WithGRPCConnectionPool cla: yes

The experimental APIs relied upon by this option were deleted in https://github.com/grpc/grpc-go/pull/3301

Fixes #441

+0 -131

6 comments

3 changed files

dfawley

pr closed time in 22 days

pull request commentgoogleapis/google-api-go-client

option: remove experimental API WithGRPCConnectionPool

as discussed, fix is in progress

dfawley

comment created time in 22 days

issue openedgoogleapis/google-api-go-client

generator: broken by unknown oauth scope

...
2020/02/03 16:43:48 Generating API pagespeedonline:v5
2020/02/03 16:43:48 Unexpected oauth2 scope "openid" doesn't start with "https://"

created time in 22 days

issue closedgoogleapis/google-cloud-go

internal/gapicgen: changes in grpc appear to have broken proto generation

Generation of protobuf files managed by internal/gapicgen are failing. Quick look implicates changes in grpc side.

Example failures (happens for multiple APIs):

googleapis/ads/admob/v1/admob_api.pb.go:608:11: undefined: grpc.SupportPackageIsVersion6 googleapis/ads/admob/v1/admob_api.pb.go:628:5: undefined: grpc.ClientConnInterface

Scanning grpc, it seems there's changes in the expectations of consumers: https://github.com/grpc/grpc-go/pull/3350 just updated readme:

Compiling error, undefined: grpc.SupportPackageIsVersion If you are using Go modules: Please ensure your gRPC-Go version is required at the appropriate version in the same module containing the generated .pb.go files. For example, SupportPackageIsVersion6 needs v1.27.0, so in your go.mod file:

module <your module name>

require ( google.golang.org/grpc v1.27.0 )

closed time in 22 days

shollyman

issue commentgoogleapis/google-cloud-go

internal/gapicgen: changes in grpc appear to have broken proto generation

protos and gapics all up-to-date.

feel free to re-open (e.g. if you want to track the preventative work)

shollyman

comment created time in 22 days

push eventgoogleapis/go-genproto

Chris Broadfoot

commit sha ff9e8190c2f5c6edf2864d357532fa1d163ffb02

auto-regenerate .pb.go files (#297) This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genmgr will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night. If you have been assigned to review this CL, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genmgr to assign reviewers to the gocloud CL. Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/51331

view details

push time in 22 days

PR merged googleapis/go-genproto

Reviewers
auto-regenerate .pb.go files cla: yes

This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genmgr will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night.

If you have been assigned to review this CL, please:

  • Ensure that CI is passing. If it's failing, it requires your manual attention.
  • Approve and submit this PR if you believe it's ready to ship. That will prompt genmgr to assign reviewers to the gocloud CL.

Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/51331

+1882 -0

0 comment

2 changed files

broady

pr closed time in 22 days

push eventgoogleapis/go-genproto

Chris Broadfoot

commit sha 3662e03db2037b9213faa584264e0001f6726c15

auto-regenerate .pb.go files This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genmgr will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night. If you have been assigned to review this CL, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genmgr to assign reviewers to the gocloud CL. Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/51331

view details

push time in 22 days

PR opened googleapis/go-genproto

auto-regenerate .pb.go files

This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genmgr will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night.

If you have been assigned to review this CL, please:

  • Ensure that CI is passing. If it's failing, it requires your manual attention.
  • Approve and submit this PR if you believe it's ready to ship. That will prompt genmgr to assign reviewers to the gocloud CL.
+1882 -0

0 comment

2 changed files

pr created time in 22 days

create barnchgoogleapis/go-genproto

branch : regen_genproto

created branch time in 22 days

delete branch googleapis/go-genproto

delete branch : regen_genproto

delete time in 22 days

push eventgoogleapis/go-genproto

Chris Broadfoot

commit sha 83524a1c9dc490f4d4afaedaaa17aef7ddb9e255

auto-regenerate .pb.go files (#296) This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, autotogen will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night. If you have been assigned to review this CL, please: - Ensure that CI is passin If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt gapicgen to assign reviewers to the gocloud CL. Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/51330

view details

push time in 22 days

PR merged googleapis/go-genproto

Reviewers
auto-regenerate .pb.go files cla: yes

This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, autotogen will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night.

If you have been assigned to review this CL, please:

  • Ensure that CI is passin If it's failing, it requires your manual attention.
  • Approve and submit this PR if you believe it's ready to ship. That will prompt gapicgen to assign reviewers to the gocloud CL.

Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/51330

+19574 -13544

0 comment

545 changed files

broady

pr closed time in 22 days

push eventgoogleapis/go-genproto

Chris Broadfoot

commit sha f1e35d43f8bbf4a2688286214a5bef04689d208b

auto-regenerate .pb.go files This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, autotogen will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night. If you have been assigned to review this CL, please: - Ensure that CI is passin If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt gapicgen to assign reviewers to the gocloud CL. Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/51330

view details

push time in 22 days

create barnchgoogleapis/go-genproto

branch : regen_genproto

created branch time in 22 days

PR opened googleapis/go-genproto

auto-regenerate .pb.go files

This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, autotogen will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night.

If you have been assigned to review this CL, please:

  • Ensure that CI is passin If it's failing, it requires your manual attention.
  • Approve and submit this PR if you believe it's ready to ship. That will prompt gapicgen to assign reviewers to the gocloud CL.
+19574 -13544

0 comment

545 changed files

pr created time in 22 days

issue commentgoogleapis/google-cloud-go

go get -u cloud.google.com/go/ fails "unrecognized import path "cloud.google.com/go""

Locking this issue. If you see something similar, please open a new bug.

macrael

comment created time in 22 days

issue commentgoogleapis/google-cloud-go

internal/gapicgen: changes in grpc appear to have broken proto generation

Yep, I think I needed to install protobuf-dev too.

The other day I learned about Alpine's package searcher: https://pkgs.alpinelinux.org/contents?file=descriptor.proto&path=&name=protobuf-dev&branch=edge&repo=main&arch=x86_64

Very handy!

shollyman

comment created time in 22 days

issue commentgoogleapis/google-cloud-go

internal/gapicgen: changes in grpc appear to have broken proto generation

GAPIC generation failed:

microgen generating texttospeech
exec.Command.Run: /usr/bin/protoc [protoc -I /tmp/update-genproto212726311/googleapis -I /tmp/update-genproto212726311/proto --go_gapic_out /tmp/update-genproto212726311/gocloud --go_gapic_opt go-gapic-package=cloud.google.com/go/texttospeech/apiv1;texttospeech --go_gapic_opt grpc-service-config=google/cloud/texttospeech/v1/texttospeech_grpc_service_config.json --go_gapic_opt gapic-service-config=google/cloud/texttospeech/v1/texttospeech_v1.yaml --go_gapic_opt release-level=alpha /tmp/update-genproto212726311/googleapis/google/cloud/texttospeech/v1/cloud_tts.proto]
google/protobuf/descriptor.proto: File not found.
google/api/annotations.proto:20:1: Import "google/protobuf/descriptor.proto" was not found or had errors.
google/api/annotations.proto:28:8: "google.protobuf.MethodOptions" is not defined.
google/api/client.proto:20:1: Import "google/protobuf/descriptor.proto" was not found or had errors.
google/api/client.proto:28:8: "google.protobuf.MethodOptions" is not defined.
google/api/client.proto:67:8: "google.protobuf.ServiceOptions" is not defined.
google/api/client.proto: "google.protobuf.ServiceOptions" is not defined.
google/api/field_behavior.proto:20:1: Import "google/protobuf/descriptor.proto" was not found or had errors.
google/api/field_behavior.proto:28:8: "google.protobuf.FieldOptions" is not defined.
google/cloud/texttospeech/v1/cloud_tts.proto:20:1: Import "google/api/annotations.proto" was not found or had errors.
google/cloud/texttospeech/v1/cloud_tts.proto:21:1: Import "google/api/client.proto" was not found or had errors.
google/cloud/texttospeech/v1/cloud_tts.proto:22:1: Import "google/api/field_behavior.proto" was not found or had errors.
error generating gapics (may need to check logs for more errors): exit status 1
shollyman

comment created time in 22 days

delete branch googleapis/go-genproto

delete branch : update-deps

delete time in 22 days

push eventgoogleapis/go-genproto

Chris Broadfoot

commit sha f68cdc7a78978c6bef81c266bd6bceb1e4f88625

mod: update protobuf and grpc deps (#295) Needed for new ClientConnInterface, introduced in grpc recently. ``` $ go get google.golang.org/grpc@latest $ go mod tidy $ go get github.com/golang/protobuf@latest $ go mod tidy ```

view details

push time in 22 days

PR merged googleapis/go-genproto

mod: update protobuf and grpc deps cla: yes

Needed for new ClientConnInterface, introduced in grpc recently.

$ go get google.golang.org/grpc@latest
$ go mod tidy
$ go get github.com/golang/protobuf@latest
$ go mod tidy
+30 -5

2 comments

2 changed files

broady

pr closed time in 22 days

push eventgoogleapis/go-genproto

Chris Broadfoot

commit sha 597bf6678ef1e744471d18cb2e8b25832f8cbaaa

mod: update protobuf and grpc deps Needed for new ClientConnInterface, introduced in grpc recently. ``` $ go get google.golang.org/grpc@latest $ go mod tidy $ go get github.com/golang/protobuf@latest $ go mod tidy ```

view details

push time in 22 days

push eventgoogleapis/go-genproto

Chris Broadfoot

commit sha c98e6837567ee508676bd3be1dea2942d52f82c3

mod: update protobuf and grpc deps Needed for new ClientConnInterface, introduced in grpc recently. ``` $ go get google.golang.org/grpc@latest $ go mod tidy $ go get github.com/golang/protobuf@latest $ go mod tidy ```

view details

push time in 22 days

pull request commentgoogleapis/go-genproto

mod: update deps

and... should we add the dependency updater bot to this repo?

broady

comment created time in 22 days

pull request commentgoogleapis/go-genproto

mod: update deps

Needed for new protoc grpc output that uses "ClientConnInterface" introduced in a recent grpc version

broady

comment created time in 22 days

PR opened googleapis/go-genproto

mod: update deps

Ran go get -u ./... && go mod tidy

+81 -6

0 comment

2 changed files

pr created time in 24 days

create barnchgoogleapis/go-genproto

branch : update-deps

created branch time in 24 days

Pull request review commentgrpc/grpc-go

client: add interface for ClientConn to be accepted by generated code

 func (csm *connectivityStateManager) getNotifyChan() <-chan struct{} { 	return csm.notifyChan } +// ClientConnInterface defines the functions clients need to perform unary and+// streaming RPCs.  It is implemented by ClientConn.

Seems like a grpc-internal detail.

I think that any code interacting with grpc conns should use the interface, as I think user code shouldn't need any of the concrete methods on ClientConn like GetState, GetMethodConfig. (Maybe I'm totally wrong about that?)

dfawley

comment created time in a month

pull request commentgrpc/grpc-go

client: add interface for ClientConn to be accepted by generated code

Looks good. I think we also need Close() error.

dfawley

comment created time in a month

startedgoogleapis/gapic-generator-go

started time in a month

release googleapis/google-api-go-client

v0.15.0

released time in a month

issue openedgoogleapis/java-storage

Add Blob.uploadFrom(InputStream)

We have Blob.downloadFrom(OutputStream) (and other downloadFrom variants)

Should probably have uploadFrom with a stream. People currently have to buffer/chunk their writes manually.

/cc @crwilcox

created time in a month

pull request commentgoogleapis/google-api-go-client

option: remove experimental API WithGRPCConnectionPool

-2 on this CL. I'll work on this. Thanks for raising.

On Mon, Jan 13, 2020, 11:46 AM Jean de Klerk notifications@github.com wrote:

Ooo, yikes, this one is bad. I'm OOO and also no longer on client libraries - paging @tbpg https://github.com/tbpg, @codyoss https://github.com/codyoss, @broady https://github.com/broady .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/googleapis/google-api-go-client/pull/442?email_source=notifications&email_token=AAAGDFQBJ6QU4IZLKGS6NYTQ5TALHA5CNFSM4KGFTIQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI2BFPI#issuecomment-573838013, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGDFQGDMNUVKFEIWK5BPDQ5TALHANCNFSM4KGFTIQA .

dfawley

comment created time in a month

issue commentgooglemaps/android-maps-utils

kml: Whitespace in <color> throws exception

un-stale

On Thu, Jan 2, 2020, 9:28 AM stale[bot] notifications@github.com wrote:

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/googlemaps/android-maps-utils/issues/427?email_source=notifications&email_token=AAAGDFRE4F3AFUXYAGRHANDQ3YBZRA5CNFSM4D56RYY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH6TBBY#issuecomment-570241159, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGDFV3KDHQUKA4SFVK3JTQ3YBZRANCNFSM4D56RYYQ .

akirmse

comment created time in 2 months

more