profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/brew0722/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Jiyong Ha brew0722 @slave5vw's company account

brew0722/lfb 0

LINE Financial Blockchain forked from gaia(https://github.com/cosmos/gaia)

brew0722/lfb-sdk 0

A framework for building blockchains based LINE Blockchain Mainnet that is forked from cosmos-sdk(https://github.com/cosmos/cosmos-sdk)

brew0722/ostracon 0

Ostracon, a consensus algorithm, is forked from Tendermint Core. We have added VRF to Tendermint BFT. It adds randomness to PoS Validator elections and improves security.

slave5vw/cosmwasm 0

Library for building cosmos-compatible wasm smart contracts

slave5vw/rangemap 0

Map data structure whose keys are stored as ranges

slave5vw/wasmer 0

🚀 The leading WebAssembly Runtime supporting WASI and Emscripten

slave5vw/wasmvm 0

Go bindings to the running cosmwasm contracts with wasmer

delete branch brew0722/lfb

delete branch : apply-wasm-opts

delete time in a month

push eventline/lfb

Jiyong Ha

commit sha 1670395f7539bb25b06d399d7b100a97168f382d

feat: apply wasm opts (#23)

view details

push time in a month

PR merged line/lfb

Reviewers
feat: apply wasm opts

<!--- Provide a general summary of your changes in the Title above -->

Description

Closes: https://github.com/line/lfb-sdk/issues/308 Add wasm opts to enable telemetry.

Motivation and context

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> https://github.com/CosmWasm/wasmd/blob/93e2e669402dd96b99f223bc6176abef6e794455/cmd/wasmd/root.go#L204 The telemetry metrics is included :1317(API Server metrics).

e.g) recorded instantiate {"Name":"wasm.contract.instantiate","Count":1,"Rate":2.222800064086914,"Sum":22.22800064086914,"Min":22.22800064086914,"Max":22.22800064086914,"Mean":22.22800064086914,"Stddev":0,"Labels":{}}]}

How has this been tested?

<!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. -->

Screenshots (if appropriate):

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [ ] I followed the contributing guidelines.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
+16 -5

5 comments

5 changed files

brew0722

pr closed time in a month

PullRequestReviewEvent

pull request commentline/lfb

feat: apply wasm opts

Me too, I didn't even know it was added. thanks for the review!

brew0722

comment created time in a month

pull request commentline/lfb

feat: apply wasm opts

please note The metric measurement code using telemetry is already in wasm keeper.

https://github.com/line/lfb-sdk/blob/7214594363f82d35245b7a0ea6d98397dfa3a78f/x/wasm/keeper/keeper.go#L236 https://github.com/line/lfb-sdk/blob/7214594363f82d35245b7a0ea6d98397dfa3a78f/x/wasm/keeper/keeper.go#L334 https://github.com/line/lfb-sdk/blob/7214594363f82d35245b7a0ea6d98397dfa3a78f/x/wasm/keeper/keeper.go#L383 https://github.com/line/lfb-sdk/blob/7214594363f82d35245b7a0ea6d98397dfa3a78f/x/wasm/keeper/keeper.go#L462 https://github.com/line/lfb-sdk/blob/7214594363f82d35245b7a0ea6d98397dfa3a78f/x/wasm/keeper/keeper.go#L639 https://github.com/line/lfb-sdk/blob/7214594363f82d35245b7a0ea6d98397dfa3a78f/x/wasm/keeper/keeper.go#L663

brew0722

comment created time in a month

pull request commentline/lfb

feat: apply wasm opts

Closes: line/lfb-sdk#308

I think this PR is a part of this issue and does not directly close the issue. Is it right?

I think This PR resolve the entire issue. Instantiate time includes compilation time, and Execute time includes execution time. So it looks like we don't need to add additional metrics.

Are there any more metrics that need to be added?

brew0722

comment created time in a month

PullRequestReviewEvent

issue closedline/lfb-sdk

Add VM Metrics

closed time in a month

brew0722

issue commentline/lfb-sdk

Add VM Metrics

There is already a metric record that can replace compilation time and execution time. https://github.com/CosmWasm/wasmd/pull/463 It makes sense enough as I'm recording execution times for Instantiate and Execute. Of course, the other runs are also included in the metrics, but that seems good enough for the JIT bomb or gas consumption measurements we're concerned about.

The telemetry metrics is included :1317(API Server metrics). {"Name":"wasm.contract.instantiate","Count":1,"Rate":2.222800064086914,"Sum":22.22800064086914,"Min":22.22800064086914,"Max":22.22800064086914,"Mean":22.22800064086914,"Stddev":0,"Labels":{}}]}

And VM cache metrics is included :26660(Instrumentation via tendermint).

# HELP wasmvm_cache_elements_total Total number of elements in the cache
# TYPE wasmvm_cache_elements_total gauge
wasmvm_cache_elements_total{type="memory"} 1
wasmvm_cache_elements_total{type="pinned"} 0
# HELP wasmvm_cache_hits_total Total number of cache hits
# TYPE wasmvm_cache_hits_total counter
wasmvm_cache_hits_total{type="fs"} 1
wasmvm_cache_hits_total{type="memory"} 0
wasmvm_cache_hits_total{type="pinned"} 0
# HELP wasmvm_cache_misses_total Total number of cache misses
# TYPE wasmvm_cache_misses_total counter
wasmvm_cache_misses_total 0
# HELP wasmvm_cache_size_bytes Total number of elements in the cache
# TYPE wasmvm_cache_size_bytes gauge
wasmvm_cache_size_bytes{type="memory"} 3.036677e+06
wasmvm_cache_size_bytes{type="pinned"} 0
brew0722

comment created time in a month

PR opened line/lfb

feat: apply wasm opts

<!--- Provide a general summary of your changes in the Title above -->

Description

Add wasm opts to enable telemetry.

Motivation and context

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. -->

How has this been tested?

<!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. -->

Screenshots (if appropriate):

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [ ] I followed the contributing guidelines.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
+16 -5

0 comment

5 changed files

pr created time in a month

push eventbrew0722/lfb

Jiyong Ha

commit sha 205e1302443c259dfaf629768cbe4ae030ab7c07

feat: apply wasm opts

view details

push time in a month

create barnchbrew0722/lfb

branch : apply-wasm-opts

created branch time in a month

issue openedline/lfb-sdk

Add VM Metrics

created time in a month

issue openedline/cosmwasm

Add VM Metrics

created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

delete branch brew0722/lfb-sdk

delete branch : swagger_wasm

delete time in 2 months

push eventline/lfb-sdk

Jiyong Ha

commit sha 7214594363f82d35245b7a0ea6d98397dfa3a78f

docs: update swagger for wasm (#297)

view details

push time in 2 months

PR merged line/lfb-sdk

Reviewers
docs: update swagger for wasm documentation

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->

Description

<!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. -->

closes: #295


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
  • [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [ ] Code follows the module structure standards.
  • [ ] Wrote unit and integration tests
  • [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • [ ] Added relevant godoc comments.
  • [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • [ ] Re-reviewed Files changed in the Github PR explorer
  • [ ] Review Codecov Report in the comment section below once CI passes
+4568 -1484

2 comments

2 changed files

brew0722

pr closed time in 2 months

pull request commentline/lfb-sdk

docs: update swagger for wasm

@brew0722 , some example address's prefix of swagger is cosmos. So I think it is good to change to our prefix. Do you know how we could change this?

Probably independent of wasm, it seems to be an example recorded in swagger_legacy.yaml. swagger_legacy.yaml still has about gaia, tendermint, and cosmos throughout.

But as far as I know the REST API is deprecated(via lcd). So I will check to see if we need to continue supporting legacy REST APIs, and if necessary I will update them in a separate PR.

brew0722

comment created time in 2 months

PR opened line/lfb-sdk

Reviewers
docs: update swagger for wasm documentation

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->

Description

<!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. -->

closes: #295


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
  • [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [ ] Code follows the module structure standards.
  • [ ] Wrote unit and integration tests
  • [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • [ ] Added relevant godoc comments.
  • [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • [ ] Re-reviewed Files changed in the Github PR explorer
  • [ ] Review Codecov Report in the comment section below once CI passes
+4568 -1484

0 comment

2 changed files

pr created time in 2 months

create barnchbrew0722/lfb-sdk

branch : swagger_wasm

created branch time in 2 months

pull request commentline/lfb-sdk

docs: update swagger proto path for wasm

Correction. Just add the wasm API you want to expose in your swagger config.json.

brew0722

comment created time in 2 months

delete branch brew0722/lfb-sdk

delete branch : swagger_wasm_proto

delete time in 2 months

push eventline/lfb-sdk

Jiyong Ha

commit sha 996b9c59eaf671f6620b3b137b3b260c750429e4

docs: update swagger proto path for wasm (#295) wasmd 0.17.0(#249) After merging, the legacy style wasm proto path was fixed.

view details

push time in 2 months

PR merged line/lfb-sdk

Reviewers
docs: update swagger proto path for wasm

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->

Description

<!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. -->

closes: #249

wasmd 0.17.0(#249) After merging, the legacy style wasm proto path was fixed. This PR purpose is follow-up. However, wasm doesn't have a service.proto, so it doesn't change swagger for wasm.

Other than that, it contains what appears to be missing during the merging of main in PR #249.(e.g reverted COSMOS SDK->LFB SDK)


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
  • [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [ ] Code follows the module structure standards.
  • [ ] Wrote unit and integration tests
  • [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • [ ] Added relevant godoc comments.
  • [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • [ ] Re-reviewed Files changed in the Github PR explorer
  • [ ] Review Codecov Report in the comment section below once CI passes
+29 -3

0 comment

2 changed files

brew0722

pr closed time in 2 months

PR opened line/lfb-sdk

docs: update swagger for wasm

wasmd 0.17.0(#249) After merging, the legacy style wasm proto path was fixed.

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->

Description

<!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. -->

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
  • [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [ ] Code follows the module structure standards.
  • [ ] Wrote unit and integration tests
  • [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • [ ] Added relevant godoc comments.
  • [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • [ ] Re-reviewed Files changed in the Github PR explorer
  • [ ] Review Codecov Report in the comment section below once CI passes
+29 -3

0 comment

2 changed files

pr created time in 2 months